Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-12 Thread Greg KH
On Fri, May 11, 2007 at 11:17:11PM -0700, Andrew Morton wrote: > On Fri, 11 May 2007 23:55:37 +0200 > Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > here my new patch with a lot of fixes. > > > > The only issue not still fixed is the one related with: > > > > #define NETLI

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-11 Thread Andrew Morton
On Fri, 11 May 2007 23:55:37 +0200 Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > Hello, > > here my new patch with a lot of fixes. > > The only issue not still fixed is the one related with: > > #define NETLINK_PPSAPI 20 > > I need time to resolve it. > > Follows my comments an

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-11 Thread Rodolfo Giometti
Hello, here my new patch with a lot of fixes. The only issue not still fixed is the one related with: #define NETLINK_PPSAPI 20 I need time to resolve it. Follows my comments and then the patch, hope now I can came back into -mm tree again! :) On Thu, May 10, 2007 at 12:27:52

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread David Miller
BTW, please remove the linuxpps list from the CC: for future postings in this thread, it bounces every one of my emails back because it only allows postings from subscribers. Thanks a lot. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread David Miller
From: Rodolfo Giometti <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 13:45:03 +0200 > On Thu, May 10, 2007 at 04:01:52AM -0700, David Miller wrote: > > > > It's not OK, please use the generic netlink interface and as > > such you will not need to allocate any numbers at all. > > > > Documentation/n

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread Rodolfo Giometti
On Thu, May 10, 2007 at 04:01:52AM -0700, David Miller wrote: > > It's not OK, please use the generic netlink interface and as > such you will not need to allocate any numbers at all. > > Documentation/networking/generic_netlink.txt gives a link > to some infomration on this topic. If I well und

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread David Miller
From: Rodolfo Giometti <[EMAIL PROTECTED]> Date: Thu, 10 May 2007 12:58:37 +0200 > On Thu, May 10, 2007 at 12:27:40AM -0700, Andrew Morton wrote: > > > > Please check with Dave Miller that this: > > > > #define NETLINK_PPSAPI 20 > > > > reservation is OK. > > Hello, as you can

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread Rodolfo Giometti
On Thu, May 10, 2007 at 12:27:40AM -0700, Andrew Morton wrote: > > Please check with Dave Miller that this: > > #define NETLINK_PPSAPI 20 > > reservation is OK. Hello, as you can see here Andrew Morton asked to me to check with you about NETLINK_PPSAPI reservation. Please, l

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread Andrew Morton
On Thu, 10 May 2007 00:27:40 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > - Can we get rid of the private dbg, err and info macros? Surely there are > generic ones somewhere. i386 allmodconfig: In file included from drivers/usb/misc/uss720.c:48: include/linux/usb.h:1505:1: warning: "dbg"

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-10 Thread Andrew Morton
On Wed, 2 May 2007 21:33:15 +0200 Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > Pulse per Second (PPS) support for Linux. Have a patch: From: Andrew Morton <[EMAIL PROTECTED]> Review comments: - Running a timer once per second will make the super-low-power people upset. - This uses netlink?

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-03 Thread Rodolfo Giometti
On Wed, May 02, 2007 at 02:06:53PM -0700, john stultz wrote: > > Please inline your patch, rather then attaching them. It makes it very > difficult to discuss when it is attached. Ok. > > +++ b/drivers/pps/clients/ktimer.c > > @@ -0,0 +1,106 @@ > > +/* > > + * ktimer.c -- kernel timer test clien

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-02 Thread john stultz
On Wed, 2007-05-02 at 21:33 +0200, Rodolfo Giometti wrote: > Pulse per Second (PPS) support for Linux. > > Signed-off-by: Rodolfo Giometti <[EMAIL PROTECTED]> > > --- > > Here my last release of PPS support for Linux. > > The difference against my last patch is about all userland specific > cod

[PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-02 Thread Rodolfo Giometti
Pulse per Second (PPS) support for Linux. Signed-off-by: Rodolfo Giometti <[EMAIL PROTECTED]> --- Here my last release of PPS support for Linux. The difference against my last patch is about all userland specific code (timepps.h) which has been removed, I hope now you can consider adding it int

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-04-26 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 04:35:22PM -0600, Reg Clemens wrote: > > On Wed, Mar 21, 2007 at 10:55:58AM -0600, Reg Clemens wrote: > > > > > > Just one point with your patch. > > > A couple of years ago there was a long discussion on the Linux Kernel > > > mailing > > > list > > > as to how USER code

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Reg Clemens
> On Wed, Mar 21, 2007 at 10:55:58AM -0600, Reg Clemens wrote: > > > > Just one point with your patch. > > A couple of years ago there was a long discussion on the Linux Kernel > > mailing > > list > > as to how USER codes were not supposed to use KERNEL include files. Now I > > still > > see

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 10:55:58AM -0600, Reg Clemens wrote: > > Just one point with your patch. > A couple of years ago there was a long discussion on the Linux Kernel mailing > list > as to how USER codes were not supposed to use KERNEL include files. Now I > still > see __KERNEL__ all over t

Re: [LinuxPPS] [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Reg Clemens
Just one point with your patch. A couple of years ago there was a long discussion on the Linux Kernel mailing list as to how USER codes were not supposed to use KERNEL include files. Now I still see __KERNEL__ all over the place in the linux=source includes so mabe this never went anywhere, but

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Lennart Sorensen
On Wed, Mar 21, 2007 at 09:05:34AM +0100, Jon K Hellan wrote: > Have you received any comments on this from the NTP community? From > Ulrich Windl? Well as just a user, this patch seems to work, and is actively being worked on and maintained for modern kernels (which unforunately Ulrich Windl's p

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Rodolfo Giometti
On Wed, Mar 21, 2007 at 09:05:34AM +0100, Jon K Hellan wrote: > Have you received any comments on this from the NTP community? From > Ulrich Windl? Not yet... that's why I reposted my patch. Thanks, Rodolfo -- GNU/Linux Solutions e-mail:[EMAIL PROTECTED] Linux Device Dr

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-21 Thread Jon K Hellan
Rodolfo Giometti wrote: Pulse per Second (PPS) support for Linux. Signed-off-by: Rodolfo Giometti <[EMAIL PROTECTED]> --- Please, note that this PPS implementation is not RFC 2783 fully compatible since, IMHO, the RFC simply doesn't consider PPS devices connected with special GPIOs or other po

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-15 Thread Rodolfo Giometti
On Thu, Mar 15, 2007 at 11:18:55AM -0400, Lennart Sorensen wrote: > How come none of the .patch files in > http://ftp.enneenne.com/pub/misc/linuxpps/refclocks/nmea/ can be > accessed? Does your web server not like serving up .patch files? Sorry. I set wrong file permissions. :) Try now. Ciao,

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-15 Thread Lennart Sorensen
On Thu, Mar 15, 2007 at 11:29:12AM +0100, Rodolfo Giometti wrote: > Can you please provide a little help about it? A patch against current > wiki wuold be great! ;) Well all I actually did was simply stick #define HAVE_PPSAPI at the tome of the refclock_nmea.c file. The configure script in ntp is

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-15 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 04:57:32PM -0400, Lennart Sorensen wrote: > > Well it does work for our GPS receiver at least. Of course I have to > change the baud rate in the driver since our unit doens't use the NNEA > standard 4800. And the configure script for ntp doesn't recognize the > v2 PPSAPI,

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Lennart Sorensen
On Wed, Mar 14, 2007 at 04:47:32PM +0100, Rodolfo Giometti wrote: > On Wed, Mar 14, 2007 at 11:37:05AM -0400, Lennart Sorensen wrote: > > Well here is my current version of the refclock_nmea.c.patch for > > LinuxPPS. It now uses /dev/gps# for the nmea messages and /dev/pps# for > > the PPS device

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 11:37:05AM -0400, Lennart Sorensen wrote: > Well here is my current version of the refclock_nmea.c.patch for > LinuxPPS. It now uses /dev/gps# for the nmea messages and /dev/pps# for > the PPS device (which in my case is of course the same device). I am > running some more

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Lennart Sorensen
Well here is my current version of the refclock_nmea.c.patch for LinuxPPS. It now uses /dev/gps# for the nmea messages and /dev/pps# for the PPS device (which in my case is of course the same device). I am running some more tests on it, but I think it is OK. --- refclock_nmea.c.ori 2007-03-14 11

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 10:42:51AM -0400, Lennart Sorensen wrote: > > Now you said to check the return value of time_pps_readlink. Well it I refere to readlink(), not to time_pps_readlink(). I'm sorry for mistake. > If the call was to readlink directly it needs to be done, while your > time_pps

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Lennart Sorensen
On Wed, Mar 14, 2007 at 03:27:12PM +0100, Rodolfo Giometti wrote: > Ok! Thanks. > > Yes, this could be a good solution while waiting for a new setserial. Now you said to check the return value of time_pps_readlink. Well it returns void so that isn't much good, and the stuff the wiki says to do,

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 10:12:53AM -0400, Lennart Sorensen wrote: > > I looked at those, and they didn't sound important. I will grab it > anyhow just for completeness. Ok! Thanks. > Well I think I may just write a small tool to do the ioctl to enable it > so I don't need the full setserial aro

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Lennart Sorensen
On Wed, Mar 14, 2007 at 03:06:23PM +0100, Rodolfo Giometti wrote: > Some fixes up... see the git log for further info. I looked at those, and they didn't sound important. I will grab it anyhow just for completeness. > Unluckely you need a patched version of setserial (see the patch on my > site)

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Wed, Mar 14, 2007 at 09:19:34AM -0400, Lennart Sorensen wrote: > > I will grab the last couple of commits and try although they didn't > sound like they really make much difference. Some fixes up... see the git log for further info. > I couldn't find any way to do that with setserial (at leas

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Lennart Sorensen
On Wed, Mar 14, 2007 at 10:31:46AM +0100, Rodolfo Giometti wrote: > On Tue, Mar 13, 2007 at 06:48:17PM -0400, Lennart Sorensen wrote: > > > > I have tried out 3.0.0-rc2 which seems to work pretty well so far (when > > Thanks. I just posted to the linux kernel ML the last release > 3.0.0. Maybe yo

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-14 Thread Rodolfo Giometti
On Tue, Mar 13, 2007 at 06:48:17PM -0400, Lennart Sorensen wrote: > > I have tried out 3.0.0-rc2 which seems to work pretty well so far (when Thanks. I just posted to the linux kernel ML the last release 3.0.0. Maybe you can do a "git pull" and try it out. :) > combined with the patches to the j

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-03-13 Thread Lennart Sorensen
On Tue, Mar 13, 2007 at 10:38:43PM +0100, Rodolfo Giometti wrote: > here my new patch for PPS support in Linux. > > I tried to follow your suggestions as much possible! Please let me > know if this new version could be more acceptable. I have tried out 3.0.0-rc2 which seems to work pretty well so

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 10:16:45AM +, Pavel Machek wrote: > Hi! > > > @@ -0,0 +1,206 @@ > > + > > + PPS - Pulse Per Second > > + -- > > + > > +(C) Copyright 2007 Rodolfo Giometti <[EMAIL PROTECTED]> > > If you add copyright, add license,

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Pavel Machek
Hi! > @@ -0,0 +1,206 @@ > + > + PPS - Pulse Per Second > + -- > + > +(C) Copyright 2007 Rodolfo Giometti <[EMAIL PROTECTED]> If you add copyright, add license, too. > +PROCFS support > +-- > + > +If PROCFS support is enable

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Thu, Feb 22, 2007 at 12:51:48AM +0100, Roman Zippel wrote: > Hi, > > On Wednesday 21 February 2007 13:04, Rodolfo Giometti wrote: > > > RFC simply doesn't consider the fact that you can have a PPS source > > __without__ a filedes connected with, and a single filedes is > > considered __always_

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-22 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 08:14:14AM -0800, H. Peter Anvin wrote: > > If you have a kernel driver at all, then it makes perfect sense. If you > don't have a kernel driver at all, then it's irrelevant to the > linux-kernel discussion. ??? So you are told me that if my PPS source is connected wit

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-21 Thread Roman Zippel
Hi, On Wednesday 21 February 2007 13:04, Rodolfo Giometti wrote: > RFC simply doesn't consider the fact that you can have a PPS source > __without__ a filedes connected with, and a single filedes is > considered __always__ connected with a single PPS source. That's not entirely true. It doesn't

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-21 Thread H. Peter Anvin
Rodolfo Giometti wrote: The problem is that sometimes you cannot have a filedescriptor at all. Think about a PPS source connected with a CPU's GPIO pin. You have no filedes to use and defining one just for a PPS source or for a class of PPS sources, I think, is a non sense. If you have a kern

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-21 Thread Rodolfo Giometti
On Mon, Feb 19, 2007 at 06:56:20PM -0800, H. Peter Anvin wrote: > It's not a precondition for a file descriptor, either. There are plenty > of ioctl-only device drivers in existence. > > Furthermore, a file descriptor doesn't imply a device entry. Consider > pipe(2), for example. > > As far

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-19 Thread H. Peter Anvin
Rodolfo Giometti wrote: Please read the following consideratios before sending to /dev/null! :) RFC considerations -- While implementing a PPS API as RFC 2783 defines and using an embedded CPU GPIO-Pin as physical link to the signal, I encountered a deeper problem: At start

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Jan Dittmer
Rodolfo Giometti wrote: >>> +PROCFS support >>> +-- >> New features shouldn't introduce new /proc stuff. > > It's a must? I can leave procfs for backward compatibility with old > utilities? Hmm, as this is a new feature with regard to the mainline kernel, old utilities don't count (if

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 08:51:35PM +, Russell King wrote: > > You can't because it doesn't go through the interfaces you're hooking > into. Existing interfaces are "changed" to point at the UARTs using > setserial, which does its work via an ioctl. I see. > Not specifically only userland -

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 08:56:18PM +0100, Jan Dittmer wrote: > Drop the linux prefix. It's in the linux kernel after all. Ok. > > +PROCFS support > > +-- > > New features shouldn't introduce new /proc stuff. It's a must? I can leave procfs for backward compatibility with old utilit

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Russell King
On Fri, Feb 16, 2007 at 09:43:36PM +0100, Rodolfo Giometti wrote: > On Fri, Feb 16, 2007 at 07:12:08PM +, Russell King wrote: > > > > Yuck. Please. No. Doing it this way means you have to modify every > > single serial driver out there which is a mamouth task. > > > > > u

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Rodolfo Giometti
On Fri, Feb 16, 2007 at 07:12:08PM +, Russell King wrote: > > Yuck. Please. No. Doing it this way means you have to modify every > single serial driver out there which is a mamouth task. > > > uart_handle_dcd_change(&up->port, status & > > UART_MSR_DCD); > > Did you n

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Jan Dittmer
Some non political comments Rodolfo Giometti wrote: > +Coding example > +-- > + > +To register a PPS source into the kernel you should define a struct > +linuxpps_source_info_s as follow: > + > +static struct linuxpps_source_info_s linuxpps_ktimer_info = { Drop the linux prefix. I

Fwd: Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Russell King
For anyone elses benefit when replying to Rodolfo... - Forwarded message from [EMAIL PROTECTED] - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Date: Fri, 16 Feb 2007 20:11:37 +0100 Subject: Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux You are not allowed to post to this

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-16 Thread Russell King
On Fri, Feb 16, 2007 at 07:52:30PM +0100, Rodolfo Giometti wrote: > diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c > index 98ec861..cd9a003 100644 > --- a/drivers/serial/8250.c > +++ b/drivers/serial/8250.c > @@ -1315,8 +1315,25 @@ static unsigned int check_modem_status(struct > uart_8