Re: [PATCHv1 2/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator

2019-09-01 Thread Anand Moon 
Hi Martin,

Thanks of your review comments.

On Sun, 1 Sep 2019 at 17:11, Martin Blumenstingl
 wrote:
>
> On Wed, Aug 28, 2019 at 10:27 PM Anand Moon  wrote:
> >
> > As per shematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which
> typo: "schematics"
>
Ok
> > is supplied by VDDIO_AO3V3.
> please add a short sentence to the description (since you probably
> have to re-send a v2) like:
> "While here, move the comment name with the signal name in the
> schematics above the gpio property to make it consistent with other
> regulators"
>

Ok I will append this in next version.

> > Cc: Martin Blumenstingl 
> > Cc: Jerome Brunet 
> > Cc: Neil Armstrong 
> > Signed-off-by: Anand Moon 
> with the patch rebased (see below) and the two issues from above addressed:
> Reviewed-by: Martin Blumenstingl 
>
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 13 ++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts 
> > b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > index 98e742bf44c1..a078a1ee5004 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> > @@ -67,17 +67,19 @@
> > };
> >
> > tflash_vdd: regulator-tflash_vdd {
> > -   /*
> > -* signal name from schematics: TFLASH_VDD_EN
> > -*/
> > compatible = "regulator-fixed";
> >
> > regulator-name = "TFLASH_VDD";
> > regulator-min-microvolt = <330>;
> > regulator-max-microvolt = <330>;
> >
> > +   /*
> > +* signal name from schematics: TFLASH_VDD_EN
> > +*/
> > gpio = < GPIOY_12 GPIO_ACTIVE_HIGH>;
> > enable-active-high;
> > +   /* U16 RT9179GB */
> > +   vin-supply = <_ao3v3>;
> > };
> >
> > tf_io: gpio-regulator-tf_io {
> > @@ -95,6 +97,8 @@
> >
> > states = <330 0
> >   180 1>;
> > +   /* U12/U13 RT9179GB */
> > +   vin-supply = <_ao3v3>;
> > };
> thank you for the patch but I think it won't apply on top of Neil's
> "arm64: dts: meson: fix boards regulators states format" (which was
> applied just after you sent this series)
>

>
> Martin

Ok will re-base these changes on linux-next next time.

Best Regards
-Anand

Re: [PATCHv1 2/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator

2019-09-01 Thread Martin Blumenstingl 
On Wed, Aug 28, 2019 at 10:27 PM Anand Moon  wrote:
>
> As per shematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which
typo: "schematics"

> is supplied by VDDIO_AO3V3.
please add a short sentence to the description (since you probably
have to re-send a v2) like:
"While here, move the comment name with the signal name in the
schematics above the gpio property to make it consistent with other
regulators"

> Cc: Martin Blumenstingl 
> Cc: Jerome Brunet 
> Cc: Neil Armstrong 
> Signed-off-by: Anand Moon 
with the patch rebased (see below) and the two issues from above addressed:
Reviewed-by: Martin Blumenstingl 

> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 13 ++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts 
> b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 98e742bf44c1..a078a1ee5004 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -67,17 +67,19 @@
> };
>
> tflash_vdd: regulator-tflash_vdd {
> -   /*
> -* signal name from schematics: TFLASH_VDD_EN
> -*/
> compatible = "regulator-fixed";
>
> regulator-name = "TFLASH_VDD";
> regulator-min-microvolt = <330>;
> regulator-max-microvolt = <330>;
>
> +   /*
> +* signal name from schematics: TFLASH_VDD_EN
> +*/
> gpio = < GPIOY_12 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> +   /* U16 RT9179GB */
> +   vin-supply = <_ao3v3>;
> };
>
> tf_io: gpio-regulator-tf_io {
> @@ -95,6 +97,8 @@
>
> states = <330 0
>   180 1>;
> +   /* U12/U13 RT9179GB */
> +   vin-supply = <_ao3v3>;
> };
thank you for the patch but I think it won't apply on top of Neil's
"arm64: dts: meson: fix boards regulators states format" (which was
applied just after you sent this series)


Martin

[PATCHv1 2/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator

2019-08-28 Thread Anand Moon 
As per shematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which
is supplied by VDDIO_AO3V3.

Cc: Martin Blumenstingl 
Cc: Jerome Brunet 
Cc: Neil Armstrong 
Signed-off-by: Anand Moon 
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts 
b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 98e742bf44c1..a078a1ee5004 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -67,17 +67,19 @@
};
 
tflash_vdd: regulator-tflash_vdd {
-   /*
-* signal name from schematics: TFLASH_VDD_EN
-*/
compatible = "regulator-fixed";
 
regulator-name = "TFLASH_VDD";
regulator-min-microvolt = <330>;
regulator-max-microvolt = <330>;
 
+   /*
+* signal name from schematics: TFLASH_VDD_EN
+*/
gpio = < GPIOY_12 GPIO_ACTIVE_HIGH>;
enable-active-high;
+   /* U16 RT9179GB */
+   vin-supply = <_ao3v3>;
};
 
tf_io: gpio-regulator-tf_io {
@@ -95,6 +97,8 @@
 
states = <330 0
  180 1>;
+   /* U12/U13 RT9179GB */
+   vin-supply = <_ao3v3>;
};
 
vcc1v8: regulator-vcc1v8 {
@@ -102,6 +106,9 @@
regulator-name = "VCC1V8";
regulator-min-microvolt = <180>;
regulator-max-microvolt = <180>;
+   regulator-always-on;
+   /* U18 RT9179GB */
+   vin-supply = <_ao3v3>;
};
 
vddio_ao1v8: regulator-vddio-ao1v8 {
-- 
2.23.0