Re: [patch 0/4] make pr_debug() dynamic

2008-02-11 Thread Jason Baron
On Sat, Feb 09, 2008 at 11:21:58PM +0100, Jan Engelhardt wrote: What's wrong with klogd -c 8 or equivalent? Setting the loglevel higher, will not make pr_debug() calls visible. The only way to make them visible right now, is by re-compiling the kernel. pr_debug() was IMHO meant to be a

Re: [PATCH 3/6] dyndbg: add more info to -E2BIG log warning

2012-09-24 Thread Jason Baron
On Tue, Sep 18, 2012 at 05:36:44PM -0600, Jim Cromie wrote: Tell user how big the attempted write was, in case its not obvious. This helped identify a missing flush in my stress-test script. Signed-off-by: Jim Cromie jim.cro...@gmail.com --- lib/dynamic_debug.c | 3 ++- 1 file changed, 2

Re: [PATCH 5/6] dyndbg: in dynamic_emit_prefix, change inter-field separator

2012-09-24 Thread Jason Baron
On Tue, Sep 18, 2012 at 07:56:42PM -0700, Joe Perches wrote: On Tue, 2012-09-18 at 17:36 -0600, Jim Cromie wrote: dynamic_emit_prefix() currently separates modname, funcname, lineno with ':'. This is confounds use of cut -d: logfile, since the field positions can change per callsite with

Re: [PATCH] dynamic_debug: Remove unnecessary __used

2012-10-18 Thread Jason Baron
(__verbose))) name = { \ .modname = KBUILD_MODNAME, \ .function = __func__, \ Greg, Pls pull this. Acked-by: Jason Baron jba...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: pty_chars_in_buffer NULL pointer (kernel oops)

2005-04-13 Thread Jason Baron
On Sun, 27 Feb 2005, Linus Torvalds wrote: On Sun, 27 Feb 2005, Marcelo Tosatti wrote: Alan, Linus, what correction to the which the above thread discusses has been deployed? This is the hacky hide the problem patch that is in my current tree (and was discussed in the original

[PATCH] tty races

2005-04-20 Thread Jason Baron
There are a couple of tty race conditions, which lead to inconsistent tty reference counting and tty layer oopses. The first is a tty_open vs. tty_close race in drivers/char/tty.io.c. Basically, from the time that the tty-count is deemed to be 1 and that we are going to free it to the time

pty_chars_in_buffer oops fix

2005-07-11 Thread Jason Baron
hi, This is a re-posting of a fix for a race condition between changing the line discipline on a pty and and a poll on the 'other' side. The reference is: http://marc.theaimsgroup.com/?l=linux-kernelm=111342171410005w=2. Below is a diff against the current tree. thanks, -Jason ---

Re: Merging relayfs?

2005-07-12 Thread Jason Baron
On Mon, 11 Jul 2005, Tom Zanussi wrote: Hi Andrew, can you please merge relayfs? It provides a low-overhead logging and buffering capability, which does not currently exist in the kernel. One concern I had regarding relayfs, which was raised previously, was regarding its use of vmap,

Re: racy jump label users

2013-04-18 Thread Jason Baron
Hi Andi, Agreed. However, other users of 'static_key_enabled()', provide their own locking. For example, in kernel/tracepoint.c, 'static_key_enabled()', relies on the tracepoints_mutex. Were there any other users that are problematic? I agree a 'setstate' would be nice. Maybe something like:

Re: Bug involving dynamic_debug and '-p' modifier

2013-03-16 Thread Jason Baron
Hi Andrew, Thanks for the bug report. I need to send a patch to update the maintainers file... Haven't had a chance to look into this yet. Will get back to you. Thanks, -Jason On 03/11/2013 10:28 PM, Andrew Cooks wrote: On Tue, Mar 12, 2013 at 9:14 AM, Andrew Cooks aco...@gmail.com wrote:

Re: Weird code in scripts/kconfig/Makefile

2006-12-12 Thread Jason Baron
On Tue, 12 Dec 2006, Pete Zaitcev wrote: Hi, Roman All: In 2.6.19 (and Linus' curent tree), I found the following: libpath=$$dir/lib; lib=qt; osdir=; \ $(HOSTCXX) -print-multi-os-directory /dev/null 21 \ osdir=x$$($(HOSTCXX) -print-multi-os-directory);

PATCH: fix disassociate_ctty vs. fork race

2005-09-06 Thread Jason Baron
for a NULL tty *after* it has been attached to the proper session group and clears it as necessary. Alternatively, we could simply do the tty assignment after the the process is added to the proper session group. thanks, -Jason Signed-off-by: Jason Baron [EMAIL PROTECTED] --- linux-2.6.git/kernel

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-06 Thread Jason Baron
On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: The recent commit to fix dynamic_debug was a bit unclean. Neaten the style for dynamic_debug. Reduce the stack use of message logging that uses netdev_printk Add utility functions dev_printk_emit and dev_vprintk_emit for /dev/kmsg.

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-06 Thread Jason Baron
On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: On Thu, Aug 30, 2012 at 09:48:12PM -0600, Jim Cromie wrote: On Thu, Aug 30, 2012 at 11:43 AM, Jim Cromie jim.cro...@gmail.com wrote: On Sun, Aug 26, 2012 at 5:25 AM, Joe Perches j...@perches.com wrote: The recent commit

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-07 Thread Jason Baron
On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches wrote: The recent commit to fix dynamic_debug was a bit unclean. Neaten the style for dynamic_debug. Reduce the stack

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-07 Thread Jason Baron
On Fri, Sep 07, 2012 at 08:12:01AM -0700, Joe Perches wrote: On Fri, 2012-09-07 at 10:52 -0400, Jason Baron wrote: On Thu, Sep 06, 2012 at 11:43:46AM -0700, Joe Perches wrote: On Thu, 2012-09-06 at 13:51 -0400, Jason Baron wrote: On Sun, Aug 26, 2012 at 04:25:25AM -0700, Joe Perches

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-10 Thread Jason Baron
On Fri, Sep 07, 2012 at 06:55:50PM -0700, Joe Perches wrote: On Fri, 2012-09-07 at 11:35 -0400, Jason Baron wrote: If nobody else thinks this patch is better, let's at least add a comment in __dev_printk() and __netdev_printk() to fix dynamic debug, if these are changed. Or maybe make

Re: [PATCH 0/5] dev_level and dynamic_debug cleanups

2012-09-12 Thread Jason Baron
On Wed, Sep 12, 2012 at 06:13:30PM -0700, Joe Perches wrote: On Thu, 2012-09-06 at 13:53 -0400, Jason Baron wrote: On Thu, Sep 06, 2012 at 09:13:59AM -0700, Greg Kroah-Hartman wrote: Jason, any ACK on these, or any of the other random dynamic debug patches floating around? What am I

Re: [RFC PATCH 1/1] trace: Move trace event enable from fs_initcall to early_initcall

2012-08-17 Thread Jason Baron
On Fri, Aug 17, 2012 at 10:39:39AM -0400, Steven Rostedt wrote: On Fri, 2012-08-17 at 11:04 -0300, Ezequiel Garcia wrote: On Fri, Aug 17, 2012 at 10:55 AM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 2012-08-17 at 08:01 -0300, Ezequiel Garcia wrote: Regarding the 'complete

[patch 4/4] make pr_debug() dynamic - update docs

2008-02-07 Thread Jason Baron
-add documentation about pr_debug kernel-parameters.txt Signed-off-by: Jason Baron [EMAIL PROTECTED] --- Documentation/kernel-parameters.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt

[patch 3/4] make pr_debug() dynamic - sysctl support

2008-02-07 Thread Jason Baron
-add /proc/sys/debug/pr_debug, to toggle pr_debug() on/off Signed-off-by: Jason Baron [EMAIL PROTECTED] --- kernel/sysctl.c | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 7cb1ac3

[patch 0/4] make pr_debug() dynamic

2008-02-07 Thread Jason Baron
hi, make the pr_debug() function dependent upon the new immediate infrastruture. Thus, b/c of the low runtime impact, we can dynamically enable/disable pr_debug withoug recompiling. Patch allows 'pr_debug=0/1' on the command line or via /proc/sys/debug/pr_debug. thanks, -Jason -- To

[patch 1/4] make pr_debug() dynamic

2008-02-07 Thread Jason Baron
-make pr_debug() dynamic so it can be switched on/off. The off state is implemented on top of the immediate infrastructure, so as to promote more dynamic printing and debugging. depends on CONFIG_HAVE_IMMEDIATE and CONFIG_PRINTK Signed-off-by: Jason Baron [EMAIL PROTECTED] --- include

[patch 2/4] make pr_debug() dynamic

2008-02-07 Thread Jason Baron
-make pptp_msg_name dependent on CONFIG_PR_DEBUG_DYNAMIC Signed-off-by: Jason Baron [EMAIL PROTECTED] --- net/netfilter/nf_conntrack_pptp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/nf_conntrack_pptp.c b/net/netfilter/nf_conntrack_pptp.c index

Re: [patch 0/4] make pr_debug() dynamic

2008-02-08 Thread Jason Baron
On Thu, Feb 07, 2008 at 02:42:14PM -0800, Joe Perches wrote: On Thu, 2008-02-07 at 16:03 -0500, Jason Baron wrote: make the pr_debug() function dependent upon the new immediate infrastruture. What's wrong with klogd -c 8 or equivalent? Setting the loglevel higher, will not make pr_debug

Re: [patch 4/4] make pr_debug() dynamic - update docs

2008-02-08 Thread Jason Baron
On Thu, Feb 07, 2008 at 01:26:04PM -0800, Randy Dunlap wrote: --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -1494,6 +1494,11 @@ and is between 256 and 4096 characters. It is defined in the file autoconfiguration.

Re: [patch 3/4] make pr_debug() dynamic - sysctl support

2008-02-08 Thread Jason Baron
On Thu, Feb 07, 2008 at 04:10:52PM -0800, Stephen Hemminger wrote: Jason Baron [EMAIL PROTECTED] wrote: -add /proc/sys/debug/pr_debug, to toggle pr_debug() on/off Signed-off-by: Jason Baron [EMAIL PROTECTED] --- kernel/sysctl.c | 41

Re: [PATCH 0/3] dyndbg: dev_dbg bugfix + 2 trivials

2012-07-20 Thread Jason Baron
On Thu, Jul 19, 2012 at 01:46:19PM -0600, Jim Cromie wrote: 3 patches here, 1st is bugfix, others are trivial. 1- fix __dev_printk, which broke dev_dbg() prefix under CONFIG_DYNAMIC_DEBUG. Patch looks good, and would be really nice to get into 3.5. Kay, are you ok with this patch? 2-

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jason Baron
lost. Signed-off-by: Jim Cromie jim.cro...@gmail.com --- drivers/base/core.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Acked-by: Jason Baron jba...@redhat.com diff --git a/drivers/base/core.c b/drivers/base/core.c index 346be8b..ebdb7c5 100644 --- a/drivers/base

[PATCH 1/3] dynamic_debug: Fix vpr_foo logging styles

2012-12-05 Thread Jason Baron
From: Joe Perches j...@perches.com vpr_info_dq should be a function and vpr_info should have a do {} while (0) Add missing newlines to pr_levels. Miscellaneous neatening too. braces, coalescing formats, alignments, etc... Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Jason Baron

[PATCH 3/3] dynamic_debug: add pr_errs before -EINVALs

2012-12-05 Thread Jason Baron
...@perches.com CC: Greg KH gre...@linuxfoundation.org Signed-off-by: Jim Cromie jim.cro...@gmail.com Signed-off-by: Jason Baron jba...@redhat.com --- lib/dynamic_debug.c | 47 +++ 1 files changed, 35 insertions(+), 12 deletions(-) diff --git a/lib

[PATCH 2/3] dynamic_debug: dynamic hex dump

2012-12-05 Thread Jason Baron
multiple lines and long prefix would impact readability. To provide line/file etc. information, use pr_debug or similar before/after print_hex_dump_debug() Signed-off-by: Vladimir Kondratiev qca_vkond...@qca.qualcomm.com Signed-off-by: Jason Baron jba...@redhat.com --- Documentation/dynamic-debug

[PATCH 0/3] dynamic_debug: Add print_hex_dump_bytes/debug support and cleanups

2012-12-05 Thread Jason Baron
Hi Greg, Here's a collection of the latest dyanmic debug patches that I have pending. Thanks, -Jason Jim Cromie (1): dynamic_debug: add pr_errs before -EINVALs Joe Perches (1): dynamic_debug: Fix vpr_foo logging styles Vladimir Kondratiev (1): dynamic_debug: dynamic hex dump

Re: [PATCH 0/3] dynamic_debug: Add print_hex_dump_bytes/debug support and cleanups

2012-12-05 Thread Jason Baron
On Wed, Dec 05, 2012 at 02:05:06PM -0800, Joe Perches wrote: On Wed, 2012-12-05 at 16:48 -0500, Jason Baron wrote: Here's a collection of the latest dynamic debug patches that I have pending. Any update on the jump table support? I have patches that implement the support, although

Re: [PATCH 02/10] kvm: Check userspace_addr when modifying a memory slot

2012-12-07 Thread Jason Baron
On Thu, Dec 06, 2012 at 03:20:37PM -0700, Alex Williamson wrote: The API documents that only flags and guest physical memory space can be modified on an existing slot, but we don't enforce that the userspace address cannot be modified. Instead we just ignore it. This means that a user may

Re: [PATCH 02/10] kvm: Check userspace_addr when modifying a memory slot

2012-12-07 Thread Jason Baron
On Fri, Dec 07, 2012 at 11:32:08AM -0700, Alex Williamson wrote: On Fri, 2012-12-07 at 13:17 -0500, Jason Baron wrote: On Thu, Dec 06, 2012 at 03:20:37PM -0700, Alex Williamson wrote: The API documents that only flags and guest physical memory space can be modified on an existing slot

Re: [RFC] dynamic_debug: introduce debug_hex_dump()

2012-12-11 Thread Jason Baron
On Tue, Dec 11, 2012 at 11:36:46AM -0800, Luis R. Rodriguez wrote: On Tue, Dec 04, 2012 at 11:28:26AM +0200, Vladimir Kondratiev wrote: Hi Jason, Do you have any update on the status for patches below? Where is it now? When do you expect it to merge? 3.8? I am waiting for this to merge

Re: [RFC] dynamic_debug: introduce debug_hex_dump()

2012-11-20 Thread Jason Baron
On Sun, Nov 18, 2012 at 10:35:40AM -0800, Joe Perches wrote: On Sun, 2012-11-18 at 19:01 +0200, Vladimir Kondratiev wrote: In case this option wins, patch follows. There is no need for 2-nd one to fix existing drivers. Thanks Vladimir. Yes, thanks. I've pulled in this patch, and

Re: [PATCH] jump_label: constify jump_label_text_reserved and friends

2013-01-07 Thread Jason Baron
On Mon, Jan 07, 2013 at 08:58:09AM -0500, Sasha Levin wrote: jump_label_text_reserved() doesn't modify the memory it works on, it just checks whether there are any jump labels there. Constify the parameters of it to prevent warnings when working with it. I don't see any 'const' data passed

[PATCH] madvise_need_mmap_write() usage

2007-06-15 Thread Jason Baron
hi, i was just looking at the new madvise_need_mmap_write() call...can we avoid an extra case statement and function call as follows? thanks, -Jason Signed-off-by: Jason Baron [EMAIL PROTECTED] diff --git a/mm/madvise.c b/mm/madvise.c --- a/mm/madvise.c +++ b/mm/madvise.c @@ -287,9 +287,10

Re: [PATCH] madvise_need_mmap_write() usage

2007-06-18 Thread Jason Baron
On Sat, 16 Jun 2007, Christoph Hellwig wrote: On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote: hi, i was just looking at the new madvise_need_mmap_write() call...can we avoid an extra case statement and function call as follows? Sounds like a good idea, but please move

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. I think that we need the total number of locking calls, not just the total number of *contended* locking calls, in order to

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per lock class. Additionally track the first four callsites that resulted in the contention. I think

Re: [PATCH 3/7] lockdep: lock contention tracking

2007-05-23 Thread Jason Baron
On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 12:11 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: On Wed, 2007-05-23 at 10:40 -0400, Jason Baron wrote: On Wed, 23 May 2007, Peter Zijlstra wrote: Count lock contention events per

Re: [PATCH] lockdep: lock contention tracking

2007-05-21 Thread Jason Baron
such patch below, which also introduces a 'event', thiking of things like lock timings that were mentioned, but this is not necessary. thanks, -Jason Signed-off-by: Jason Baron [EMAIL PROTECTED] --- linux-2.6.22-rc2-lockdep/include/linux/lockdep.h.bak2007-05-21 15:55:30.0

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-05 Thread Jason Baron
On 08/05/2013 03:40 PM, Marek Polacek wrote: On Mon, Aug 05, 2013 at 11:34:55AM -0700, Linus Torvalds wrote: On Mon, Aug 5, 2013 at 11:24 AM, Linus Torvalds torva...@linux-foundation.org wrote: Ugh. I can see the attraction of your section thing for that case, I just get the feeling that we

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-05 Thread Jason Baron
On 08/05/2013 02:39 PM, Steven Rostedt wrote: On Mon, 2013-08-05 at 11:20 -0700, Linus Torvalds wrote: Of course, it would be good to optimize static_key_false() itself - right now those static key jumps are always five bytes, and while they get nopped out, it would still be nice if there was

Re: [RFC] gcc feature request: Moving blocks into sections

2013-08-05 Thread Jason Baron
On 08/05/2013 04:35 PM, Richard Henderson wrote: On 08/05/2013 09:57 AM, Jason Baron wrote: On 08/05/2013 03:40 PM, Marek Polacek wrote: On Mon, Aug 05, 2013 at 11:34:55AM -0700, Linus Torvalds wrote: On Mon, Aug 5, 2013 at 11:24 AM, Linus Torvalds torva...@linux-foundation.org wrote: Ugh. I

Re: [RFC][PATCH 3/2] x86/jump labels: Count and display the short jumps used

2013-08-07 Thread Jason Baron
On 08/07/2013 03:22 PM, Linus Torvalds wrote: On Wed, Aug 7, 2013 at 10:54 AM, Steven Rostedt rost...@goodmis.org wrote: On another box, using a distro config, I had even better results: [2.352448] short jumps: 193 [2.355407] long jumps: 219 .. well, another way of looking at this

Re: [RFC][PATCH 3/2] x86/jump labels: Count and display the short jumps used

2013-08-07 Thread Jason Baron
On 08/07/2013 04:47 PM, Linus Torvalds wrote: On Wed, Aug 7, 2013 at 1:19 PM, Jason Baron jba...@akamai.com wrote: The whole point of the thread started with wanting to move the default 'disabled' branch further out-of-line. Yeah, but I always disagreed with that. Putting the unusual code

Re: [PATCH] dynamic_debug: add wildcard support to filter files/functions/modules

2013-07-29 Thread Jason Baron
On 07/25/2013 12:47 PM, Joe Perches wrote: On Thu, 2013-07-25 at 21:02 +0800, Du, Changbin wrote: From: Du, Changbin changbin...@gmail.com This patch add wildcard '*'(matches zero or more characters) and '?' (matches one character) support when qurying debug flags. Seems very useful. Caveat

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-27 Thread Jason Baron
On 08/27/2013 12:20 PM, Joe Perches wrote: On Tue, 2013-08-27 at 17:47 +0300, Dmitry Kasatkin wrote: When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data structures even when CONFIG_DYNAMIC_DEBUG is not defined. It leads to build break. For example, when I try to use

Re: [PATCH] dynamic debug: line queries failing due to uninitialized local variable

2013-08-28 Thread Jason Baron
On 08/27/2013 01:41 PM, Greg KH wrote: On Tue, Aug 27, 2013 at 04:50:03PM +, jba...@akamai.com wrote: Settings of the form, 'line x module y +p', can fail arbitrarily due to an uninitialized local variable. With this patch results are consistent, as expected. Signed-off-by: Jason Baron

Re: Dynamic debug on by default?

2013-08-14 Thread Jason Baron
On 08/14/2013 12:51 PM, Joe Perches wrote: On Wed, 2013-08-14 at 09:40 -0700, Sarah Sharp wrote: Hi Xenia, I'm a bit confused. I thought that debugging messages would be turned off by default for a module if CONFIG_DYNAMIC_DEBUG was turned on. When I tested your patch to remove the

Re: [RFC] [PATCH 0/2] x86: make jump labels use int3-based breakpoint instead of stop_machine()

2013-07-10 Thread Jason Baron
On 07/10/2013 04:25 PM, Jiri Kosina wrote: Hi, this is a resurrection of a few years old idea to have jump labels use synchronization based on int3 breakpoint rather than relying on stop_machine() with all the consequences. ftrace has been doing exactly this kind of patching for year

Re: [RFC] [PATCH 1/2 v2] x86: introduce int3-based instruction patching

2013-07-11 Thread Jason Baron
On 07/11/2013 10:35 AM, Steven Rostedt wrote: On Wed, 2013-07-10 at 14:36 -0700, H. Peter Anvin wrote: On 07/10/2013 02:31 PM, Jiri Kosina wrote: If any CPU instruction execution would collide with the patching, it'd be trapped by the int3 breakpoint and redirected to the provided handler

Re: [PATCH] MAINTAINERS: dynamic debug: Jason's not there...

2013-07-11 Thread Jason Baron
Thanks Joe - feel free to add: Acked-by: Jason Baron jba...@akamai.com On 07/10/2013 06:36 PM, Joe Perches wrote: He must be too, umm, busy to update his own bouncing email address too. Signed-off-by: Joe Perches j...@perches.com --- poke - prod... MAINTAINERS | 2 +- 1 file changed

[PATCH] panic: Make panic_timeout configurable

2013-11-08 Thread Jason Baron
exceptions- one in mips and one in powerpc where settings didn't match these default values. In those two cases, I left the arch code so it continues to override. Perhaps, these cases can be converted to the default? Signed-off-by: Jason Baron jba...@akamai.com --- arch/mips/netlogic/xlp/setup.c | 1

[PATCH 1/2 v2] epoll: optimize EPOLL_CTL_DEL using rcu

2013-10-01 Thread Jason Baron
in combination with the patch epoll: Do not take global 'epmutex' for simple topologies, shows a dramatic performance improvement in scalability for SPECjbb. Tested-by: Nathan Zimmer nzim...@sgi.com Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 65

[PATCH 2/2 v2] epoll: Do not take global 'epmutex' for simple topologies

2013-10-01 Thread Jason Baron
scaling at around 40-44 sockets but it seems like I found a second unrelated bottleneck. Tested-by: Nathan Zimmer nzim...@sgi.com Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 94 ++ 1 file changed, 68 insertions(+), 26

[PATCH 0/2 v2] epoll: reduce 'epmutex' lock contention

2013-10-01 Thread Jason Baron
in v2: -use a union for rcu callback and drop patch #3 v1: http://marc.info/?l=linux-kernelm=138057995316598w=2 Jason Baron (2): epoll: optimize EPOLL_CTL_DEL using rcu epoll: Do not take global 'epmutex' for simple topologies fs/eventpoll.c | 153

Re: [PATCH 2/2 v2] epoll: Do not take global 'epmutex' for simple topologies

2013-10-04 Thread Jason Baron
On 10/03/2013 05:50 PM, Andrew Morton wrote: On Tue, 1 Oct 2013 17:08:14 + (GMT) Jason Baron jba...@akamai.com wrote: When calling EPOLL_CTL_ADD for an epoll file descriptor that is attached directly to a wakeup source, we do not need to take the global 'epmutex', unless the epoll file

Re: [RFC] eventpoll: Move a kmem_cache_alloc and kmem_cache_free

2013-09-18 Thread Jason Baron
find the one posted by Jason Baron at https://lkml.org/lkml/2011/2/25/297. Any thoughts? Hi, Intersting - I think its also possible to completely drop taking the 'epmutex' for EPOLL_CTL_DEL by using rcu, and restricting it on add to more 'complex' topologies. That is when we have an epoll

Re: disappearing listen()ed SO_REUSEPORT sockets across fork() when using epoll

2013-11-25 Thread Jason Baron
On 11/22/2013 12:53 PM, Shawn Landden wrote: Hello, when running the attached program on 3.12 child processes are missing a socket fd opened, set with SO_REUSEPORT, listen()ed to, and added to epoll_ctl(). This is the output I get when pointing wget http://localhost:/; at the attached

[PATCH 0/3 v3] build in panic_timeout value

2013-11-25 Thread Jason Baron
(), in case .config specifies a non-default timeout Jason Baron (2): panic: Make panic_timeout configurable powerpc: cleanup panic_timeout Ralf Baechle (1): mips: remove panic_timeout settings. arch/mips/ar7/setup.c | 1 - arch/mips/emma/markeins/setup.c| 3 --- arch/mips

[PATCH 1/3 v3] panic: Make panic_timeout configurable

2013-11-25 Thread Jason Baron
-by: Jason Baron jba...@akamai.com --- include/linux/kernel.h | 9 + kernel/panic.c | 2 +- lib/Kconfig.debug | 9 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index d4e98d1..2ac0277 100644

[PATCH 3/3 v3] powerpc: cleanup panic_timeout

2013-11-25 Thread Jason Baron
, if the user changes the default setting of 180 seconds, we honor that user setting. Signed-off-by: Jason Baron jba...@akamai.com --- arch/powerpc/Kconfig | 4 arch/powerpc/include/asm/setup.h | 1 + arch/powerpc/kernel/setup_32.c | 3 --- arch/powerpc/kernel/setup_64.c

[PATCH 2/3 v3] mips: remove panic_timeout settings

2013-11-25 Thread Jason Baron
From: Ralf Baechle r...@linux-mips.org Now that we have a CONFIG_PANIC_TIMEOUT=x setting, remove the mips settings. The default is 0, which means don't reboot on panic. Signed-off-by: Ralf Baechle r...@linux-mips.org Acked-by: Shinya Kuribayashi skuri...@pobox.com Signed-off-by: Jason Baron jba

Re: [PATCH v4 1/2] panic: setup panic_timeout early

2013-11-27 Thread Jason Baron
On 11/27/2013 01:17 AM, Felipe Contreras wrote: Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c

Re: [PATCH] panic: Make panic_timeout configurable

2013-11-12 Thread Jason Baron
On 11/11/2013 04:32 AM, Ingo Molnar wrote: * Jason Baron jba...@akamai.com wrote: The panic_timeout can be set via the command line option 'panic=x', or via /proc/sys/kernel/panic, however that is not sufficient when the panic occurs before we are able to set up these values. Thus, add

[PATCH v2] panic: Make panic_timeout configurable

2013-11-18 Thread Jason Baron
. Signed-off-by: Jason Baron jba...@akamai.com --- -Restrict arch defaults to arch/ code -add set_arch_panic_timeout(), in case .config specifies a non-default timeout arch/mips/Kconfig | 4 arch/mips/ar7/setup.c | 2 +- arch/mips/emma/markeins/setup.c

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-19 Thread Jason Baron
On 11/19/2013 04:02 AM, Ralf Baechle wrote: On Mon, Nov 18, 2013 at 09:04:36PM +, Jason Baron wrote: The panic_timeout value can be set via the command line option 'panic=x', or via /proc/sys/kernel/panic, however that is not sufficient when the panic occurs before we are able to set

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 01:29 PM, Joe Perches wrote: On Tue, 2013-06-25 at 10:02 -0700, Greg KH wrote: On Tue, Jun 25, 2013 at 05:30:02PM +0100, Rupesh Gujare wrote: convert all debug messages from printk to dev_dbg() add kernel config to enable/disable these messages during compilation. No, just use

Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

2013-06-26 Thread Jason Baron
On 06/25/2013 02:03 PM, Joe Perches wrote: (Using Jason Baron's most current email address) On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote: On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote: On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote: a long needed extension to dev_dbg

[PATCH] epoll: remove the on_list check for 'struct epitem'

2013-10-30 Thread Jason Baron
, eventpoll_release_file() can not race with ep_free(), since they both acquire the 'epmutex'. Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 755bda0..69de7a6

Re: linux-next: build failure after merge of the akpm-current tree

2013-10-30 Thread Jason Baron
On 10/30/2013 03:00 AM, Stephen Rothwell wrote: Hi Andrew, After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/init.h:4:0, from fs/eventpoll.c:14: fs/eventpoll.c: In function

Re: [PATCH 1/2 v2] epoll: optimize EPOLL_CTL_DEL using rcu

2013-10-24 Thread Jason Baron
Thanks for looking at this. Comments below. -Jason On 10/24/2013 04:52 AM, Paul E. McKenney wrote: On Tue, Oct 01, 2013 at 05:08:10PM +, Jason Baron wrote: Optimize EPOLL_CTL_DEL such that it does not require the 'epmutex' by converting the file-f_ep_links list into an rcu one

Re: [PATCH 2/2 v2] epoll: Do not take global 'epmutex' for simple topologies

2013-10-24 Thread Jason Baron
On 10/24/2013 06:09 AM, Paul E. McKenney wrote: On Tue, Oct 01, 2013 at 05:08:14PM +, Jason Baron wrote: When calling EPOLL_CTL_ADD for an epoll file descriptor that is attached directly to a wakeup source, we do not need to take the global 'epmutex', unless the epoll file descriptor

Re: [RFC] eventpoll: Move a kmem_cache_alloc and kmem_cache_free

2013-09-23 Thread Jason Baron
On 09/19/2013 12:37 PM, Nathan Zimmer wrote: On 09/18/2013 02:09 PM, Jason Baron wrote: On 09/13/2013 11:54 AM, Nathan Zimmer wrote: We noticed some scaling issue in the SPECjbb benchmark. Running perf we found that the it was spending lots of time in SYS_epoll_ctl. In particular

Re: [RFC] eventpoll: Move a kmem_cache_alloc and kmem_cache_free

2013-09-23 Thread Jason Baron
On 09/22/2013 04:41 PM, Eric Wong wrote: Jason Baron jba...@akamai.com wrote: epoll: reduce usage of global 'epmutex' lock Epoll file descriptors that are 1 link from a wakeup source and are not nested within other epoll descriptors, or pointing to other epoll descriptors

[PATCH 0/3] epoll: reduce 'epmutex' lock contention

2013-09-30 Thread Jason Baron
the benchmark stops scaling at around 40-44 sockets but it seems like I found a second unrelated bottleneck. Jason Baron (3): epoll: optimize EPOLL_CTL_DEL using rcu epoll: Do not take global 'epmutex' for simple topologies epoll: restore 'struct epitem' size fs/eventpoll.c | 150

[PATCH 1/3] epoll: optimize EPOLL_CTL_DEL using rcu

2013-09-30 Thread Jason Baron
topologies, shows a dramatic performance improvement in scalability for SPECjbb. Tested-by: Nathan Zimmer nzim...@sgi.com Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 58 -- 1 file changed, 32 insertions(+), 26 deletions(-) diff

[PATCH 3/3] epoll: restore 'struct epitem' size

2013-09-30 Thread Jason Baron
the hack-ish nature of this thing. Tested-by: Nathan Zimmer nzim...@sgi.com Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index daaec16..2f06737

[PATCH 2/3] epoll: Do not take global 'epmutex' for simple topologies

2013-09-30 Thread Jason Baron
stops scaling at around 40-44 sockets but it seems like I found a second unrelated bottleneck. Tested-by: Nathan Zimmer nzim...@sgi.com Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 94 ++ 1 file changed, 68 insertions

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-06-11 Thread Jason Baron
On 04/09/2014 05:33 PM, Luck, Tony wrote: Unfortunately, the box reporting the ue errors just went into transit (so that I can better examine this issue), so I will probably not be able to run this experiment on that specific box until next week. Do you have any other logs from this machine.

Re: [PATCH] epoll: fix use-after-free in eventpoll_release_file

2014-06-17 Thread Jason Baron
this more difficult to hit, but obviously it happens. Thanks for finding/fixing this! Acked-by: Jason Baron jba...@akamai.com On 06/16/2014 10:58 PM, Konstantin Khlebnikov wrote: This fixes use-after-free of epi-fllink.next inside list loop macro. This loop actually releases elements

Re: eventpoll __list_del_entry corruption

2014-06-03 Thread Jason Baron
On 05/15/2014 02:11 PM, Peter Zijlstra wrote: On Mon, May 12, 2014 at 11:42:33AM -0400, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools guest running the latest -next kernel I've stumbled on the following spew. Maybe related to the very recent change in freeing on

Re: [PATCH 3/3] dynamic_debug: replace obselete simple_strtoul() with kstrtouint()

2014-01-24 Thread Jason Baron
Hi, I think we want some sort of commit message for this patch. But they all look good to me and they tested fine. Acked-by: Jason Baron jba...@akamai.com Greg, Can you pick up this series? Thanks, -Jason On 01/23/2014 08:20 AM, Andrey Ryabinin wrote: Signed-off-by: Andrey Ryabinin a.ryabi

Re: [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability

2013-12-18 Thread Jason Baron
: Acked-by: Jason Baron jba...@akamai.com Thanks, -Jason -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH] epoll: Do not take the nested ep-mtx on EPOLL_CTL_DEL

2013-12-26 Thread Jason Baron
performance gains, did not perform this additional locking. Signed-off-by: Jason Baron jba...@akamai.com --- fs/eventpoll.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 8b5e258..af90312 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1907,10

[PATCH 0/3] Add new ie31200_edac driver

2014-04-04 Thread Jason Baron
, -Jason Jason Baron (3): readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q x38_edac: make use of lo_hi_readq() ie31200_edac: Add driver drivers/edac/Kconfig| 7 + drivers/edac/Makefile | 1 + drivers/edac

[PATCH 3/3] ie31200_edac: Add driver

2014-04-04 Thread Jason Baron
-datasheet.html I've tested this on bad memory hardware, and observed correlating bad reads and uncorrected memory errors as reported by the driver. Signed-off-by: Jason Baron jba...@akamai.com --- drivers/edac/Kconfig| 7 + drivers/edac/Makefile | 1 + drivers/edac/ie31200_edac.c | 540

[PATCH 2/3] x38_edac: make use of lo_hi_readq()

2014-04-04 Thread Jason Baron
Convert to the generic API. Signed-off-by: Jason Baron jba...@akamai.com --- drivers/edac/x38_edac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c index 4891b45..e644b52 100644 --- a/drivers/edac/x38_edac.c

[PATCH 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]_q

2014-04-04 Thread Jason Baron
/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16) I can confirm this is true via several hard machine lockups. Thus, add explicit hi_lo_[readq|write]_q and lo_hi_[read|write]_q so that these uses are spelled out. Signed-off-by: Jason Baron jba...@akamai.com --- include/asm-generic/io-64

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-08 Thread Jason Baron
Hi, On 04/08/2014 05:09 AM, Borislav Petkov wrote: On Fri, Apr 04, 2014 at 09:14:04PM +, Jason Baron wrote: Add 'ie31200_edac' driver for the E3-1200 series of Intel processors. Driver is based on the following E3-1200 specs: http://www.intel.com/content/www/us/en/processors/xeon/xeon

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-08 Thread Jason Baron
On 04/08/2014 06:34 PM, Luck, Tony wrote: Btw, this driver is polling, AFAICT. Doesn't e3-12xx support the CMCI interrupt which you can feed into this driver directly and thus not need the polling at all? On the system with the ce and ue events that I'm testing on, I don't see 'MCE' nudge

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 07:35 AM, Borislav Petkov wrote: On Fri, Apr 04, 2014 at 09:14:04PM +, Jason Baron wrote: Add 'ie31200_edac' driver for the E3-1200 series of Intel processors. Driver is based on the following E3-1200 specs: http://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 01:36 PM, Borislav Petkov wrote: On Wed, Apr 09, 2014 at 05:17:53PM +, Luck, Tony wrote: The E3-12xx processors connect out to a different (desktop) chipset from the E5 (server parts). Perhaps that means the memory controller are different too??? You gotta love how Intel

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 03:14 PM, Borislav Petkov wrote: On Wed, Apr 09, 2014 at 02:57:19PM -0400, Jason Baron wrote: Right, so maybe the fact that its a desktop chipset means that it behaves differently and doesn't raise MCEs on memory errors. We have a bunch of these processors and we haven't yet seen

Re: [PATCH 3/3] ie31200_edac: Add driver

2014-04-09 Thread Jason Baron
On 04/09/2014 05:33 PM, Luck, Tony wrote: Unfortunately, the box reporting the ue errors just went into transit (so that I can better examine this issue), so I will probably not be able to run this experiment on that specific box until next week. Do you have any other logs from this machine.

  1   2   3   4   5   6   7   8   9   >