Re: [PATCH] [media] vb2: move dma-buf unmap from __vb2_dqbuf() to vb2_buffer_done()

ds, > Javier > Hello all, Tested this using the same GStreamer pipeline as Javier mentions above. It works nicely. Thanks, Luis Tested-by: Luis de Bethencourt

Re: Volunteering for BeFS maintainership

On 27/07/16 14:23, Theodore Ts'o wrote: > On Wed, Jul 27, 2016 at 12:45:36PM +0100, Luis de Bethencourt wrote: >> Support for BeFS in Linux is read-only. So there are no tools to create >> BeFS file systems. I have a bunch of BeFS images created from Haiku OS >> that

Re: [RESEND PATCH 1/4] fs: befs: Remove redundant validation from befs_find_brun_direct

On 27/07/16 04:11, Salah Triki wrote: > The only caller of befs_find_brun_direct is befs_fblock2brun, which > already validates that the block is within the range of direct blocks. > So remove the duplicate validation. > > Signed-off-by: Salah Triki > Acked-by: Luis de Bethen

Re: [RESEND PATCH V3] fs: befs: Insert NULL inode to dentry

txt:383 "If the named inode does not exist a NULL inode should be inserted into the dentry (this is called a negative dentry)." Acked-by: Luis de Bethencourt I have applied this patch into [0]: https://github.com/luisbg/linux-befs/tree/befs-next Thanks, Luis [0] reason for the git branch: https://lkml.org/lkml/2016/7/26/533

Re: [RESEND PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr

On 27/07/16 04:11, Salah Triki wrote: > Since goto statement merely returns NULL, replace it with return > statement. > > Signed-off-by: Salah Triki > --- > fs/befs/io.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/fs/befs/io.c b/fs/befs/io.c > index 4223b77.

[PATCH] MAINTAINERS: befs: Add new maintainers

Salah Triki and Luis de Bethencourt are taking over maintainership of befs. Signed-off-by: Luis de Bethencourt Acked-by: Greg Kroah-Hartman Acked-by: Theodore Ts'o --- Hi, Following up the discussion in which I volunteered, with Salah, to maintain befs [0]. Here is the patch fo

Re: [PATCH 1/3] befs: remove off argument of befs_read_datastream

On 28/07/16 00:37, Salah Triki wrote: > On Tue, Jul 12, 2016 at 12:02:48AM +0100, Luis de Bethencourt wrote: >> befs_read_datastream() is used to read the inode from the disk, off is >> meant to provide the offset of the data in the buffer head. But the only >> function using

Re: [PATCH 1/6] fs: befs: remove unneeded initialization to zero

On 31/07/16 21:34, Salah Triki wrote: > off is reinitialized by befs_read_datastream, so no need to init it with > zero in the beginning of befs_bt_read_node. > > Signed-off-by: Salah Triki > --- > fs/befs/btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/

Re: [PATCH 2/6] fs: befs: remove in vain variable assignment

dkey_len = strlen(findkey); > > /* if node can not contain key, just skeep this node */ > Hi Salah, The key here is that befs_btree_find(), the only consumer of befs_find_key(), doesn't use the value if the return is BEFS_BT_NOT_FOUND. Tested the patch anyway to be sure.

Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

ree_super bt_super; > - befs_off_t node_off = 0; > + befs_off_t node_off; > int cur_key; > fs64 *valarray; > char *keystart; > Looks good to me. Strange that static analysis didn't pick this one up before. Acked-by: Luis de Bethencourt Pushed to the bef

Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

t_range >> BEFS_SB(sb)->block_shift; > > off_t dbl_indir_off = blockno - indir_start_blk; > > This looks to be consistent with other uses of BEFS_SB() when the value is only used once. Thanks, Luis Acked-by: Luis de Bethencourt Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next

Re: [PATCH 5/6] fs: befs: remove in vain variable assignment

BEFS_I(inode)->i_data.ds; > befs_block_run run = BAD_IADDR; > - int res = 0; > + int res; > ulong disk_off; > > befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", > Looks good. Thanks Salah, Luis Acked-by: Luis de Bet

Re: [PATCH 6/6] fs: befs: remove ret variable

ice catch, since your patch also makes the code more readable. No need to check the value of ret when you read that return ERR_PTR() anymore. This has been this way since the introduction of ret in commit 96eb5419412fbc7f39fa45d987034c5d0e6e1202. No need to add a "Fixes" tag in the commit

[PATCH] befs: remove unused BEFS_BT_MATCH

befs_btree_find(), the only caller of befs_find_key(), only cares about if the return from that function is BEFS_BT_MATCH or not. It never uses the partial match given with BEFS_BT_MATCH. Removing that return and don't set the value that will go unused. Signed-off-by: Luis de Bethencourt --

[PATCH v2 1/2] befs: remove unused BEFS_BT_MATCH

befs_btree_find(), the only caller of befs_find_key(), only cares about if the return from that function is BEFS_BT_MATCH or not. It never uses the partial match given with BEFS_BT_MATCH. Removing that return and don't set the value that will go unused. Signed-off-by: Luis de Bethencourt -

[PATCH v2 2/2] befs: fix typo in befs_find_key

Fixing skeep to skip. Signed-off-by: Luis de Bethencourt --- fs/befs/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index bc7efb0..784688c 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -343,7 +343,7 @@ befs_find_key(struct

Re: [PATCH v2 1/2] befs: remove unused BEFS_BT_MATCH

On 06/08/16 19:34, Salah Triki wrote: > On Fri, Aug 05, 2016 at 01:41:20PM +0100, Luis de Bethencourt wrote: >> befs_btree_find(), the only caller of befs_find_key(), only cares about if >> the return from that function is BEFS_BT_MATCH or not. It never uses the >> par

[PATCH v3 2/2] befs: fix typo in befs_find_key

Fixing skeep to skip. Signed-off-by: Luis de Bethencourt --- v3: no change fs/befs/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 27b0336..54a1f95 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -344,7 +344,7

[PATCH v3 1/2] befs: remove unused BEFS_BT_PARMATCH

: Luis de Bethencourt --- v3: check for BEFS_BT_OVERFLOW instead of value == 0 Hi, Switching to using BEFS_BT_OVERFLOW. This makes logic of befs_find_key() clearer. Thanks, Luis fs/befs/befs.h | 2 +- fs/befs/btree.c | 38 -- 2 files changed, 17 insertions

[PATCH] MAINTAINERS: update email address for Luis de Bethencourt

From: Luis de Bethencourt The current email address will stop being valid next week. Update it to the email address that should be used instead from now on. Signed-off-by: Luis de Bethencourt --- Hello, I wonder if people would prefer I use a kernel.org account. I think I have enough

Re: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()

On 05/10/15 15:24, Jiri Kosina wrote: > On Sat, 3 Oct 2015, Luis de Bethencourt wrote: > >>> But I am not really sure where you are seeing the bug (mapping to >>> -EPERM) in this case? I think the only caller of hiddev_connect() >>> should be hid_connect(),

[PATCH 0/5] clk: sunxi: Fix module autoload for OF platform driver

Hello, This series add the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 3/5] clk: sunxi: sun6i-ar100: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/clk/sunxi/clk-sun6i-ar100.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sun6i-ar

[PATCH 4/5] clk: sunxi: sun8i-apb0: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/clk/sunxi/clk-sun8i-apb0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sun8i-apb0

[PATCH 5/5] clk: sunxi: sun9i-mmc: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/clk/sunxi/clk-sun9i-mmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sun9i-mmc

[PATCH 2/5] clk: sunxi: sun6i-apb0-gates: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/clk/sunxi/clk-sun6i-apb0-gates.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sun6i

[PATCH 1/5] clk: sunxi: sun6i-apb0: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/clk/sunxi/clk-sun6i-apb0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/sunxi/clk-sun6i-apb0

[PATCH 0/3] crypto: Fix module autoload for OF platform drivers

Hello, This series add the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 1/3] crypto: amcc: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/crypto/amcc/crypto4xx_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/amcc/crypto4xx_c

[PATCH 2/3] crypto: picoxcell: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/crypto/picoxcell_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/picoxcell_crypto

[PATCH 3/3] crypto: ux500: Fix module autoload for OF platform drivers

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/crypto/ux500/cryp/cryp_core.c | 1 + drivers/crypto/ux500/hash/hash_core.c | 1 + 2 files changed, 2 inser

[PATCH v2 1/6] input: ab8500-ponkey: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block. As suggested by Dmitry Torokhov. Thanks, Luis dr

[PATCH v2 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block. As suggested by Dmitry Torokhov. Thanks, Luis dr

[PATCH v2 3/6] input: regulator-haptic: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Better without an empty line between of_device_id and MODULE_DEVICE_TABLE. Thanks, Luis drivers/input/misc/regu

[PATCH v2 5/6] input: egalax_ts: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/input/touchscreen/egalax_ts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchs

[PATCH v2 4/6] input: sparcspkr: Fix module autoload for OF platform drivers

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/input/misc/sparcspkr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/misc/sparcspk

[PATCH v2 6/6] input: mms114: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Moving the MODULE_DEVICE_TABLE into the CONFIG_OF #ifdef block. As suggested by Dmitry Torokhov. Thanks for the r

[PATCH 0/6] leds: Fix module autoload for OF platform drivers

Hello, This series adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 1/6] leds: aat1290: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-aat1290.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-aat1290.c b/drivers

[PATCH 2/6] leds: bcm6328: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-bcm6328.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-bcm6328.c b/drivers

[PATCH 3/6] leds: bcm6358: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-bcm6358.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-bcm6358.c b/drivers

[PATCH 4/6] leds: ktd2692: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-ktd2692.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-ktd2692.c b/drivers

[PATCH 6/6] leds: leds-ns2: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-ns2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-

[PATCH 5/6] leds: max77693: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/leds/leds-max77693.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-max77693.c b/drivers

[PATCH] mfd: Compile MFD_STW481X with COMPILE_TEST

the build. Signed-off-by: Luis de Bethencourt --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 99d6367..68d708f 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1471,7 +1471,7 @@ config MFD_WM8994

[PATCH] regulator: stw481x: compile on COMPILE_TEST

the build. Signed-off-by: Luis de Bethencourt --- drivers/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 64bccff..8df0b0e 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -62

[PATCH] watchdog: Compile possible drivers with COMPILE_TEST

Signed-off-by: Luis de Bethencourt --- drivers/watchdog/Kconfig | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 79e1aa1..c741bb9 100644 --- a/drivers/watchdog/Kco

[PATCH] thermal: kconfig: When possible, compile drivers with COMPILE_TEST

-off-by: Luis de Bethencourt --- drivers/thermal/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index a94ebb5..844c219 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -252,7 +252,7 @@ config

[PATCH] ssb: extif: Compile with COMPILE_TEST

, when building with allyesconfig. Signed-off-by: Luis de Bethencourt --- drivers/ssb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index f0d22cd..1819a54 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -150,7

[PATCH] spi: kconfig: When possible, compile drivers with COMPILE_TEST

-off-by: Luis de Bethencourt --- drivers/spi/Kconfig | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 26b8605..585d0cb 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -128,7 +128,7 @@ config SPI_AU1550

[PATCH v2] thermal: db8500_cpufreq_cooling: Compile with COMPILE_TEST

: Luis de Bethencourt --- Hi, This is the second version of: https://lkml.org/lkml/2015/10/14/691 After removing COMPILE_TEST for INTEL_QUARK_DTS_THERMAL, only DB8500_CPUFREQ_COOLING remains. Which is why I have changed the subject line of the commit message. Sorry for the kbuild test robot

[PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST

Signed-off-by: Luis de Bethencourt --- Hi, I have removed the COMPILE_TEST for SIRFSOC_WATCHDOG, since the kbuild test robot complained with warnings about it. Thanks, Luis drivers/watchdog/Kconfig | 46 +++--- 1 file changed, 23 insertions(+), 23

[PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

-off-by: Luis de Bethencourt --- drivers/scsi/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index d2f480b..0d8ee16 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -416,7 +416,7 @@ config

Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST

On 14/10/15 22:35, Guenter Roeck wrote: > On 10/14/2015 11:55 AM, Luis de Bethencourt wrote: >> These drivers have depends that aren't build dependencies, so it's >> a good idea to allow these drivers to always be built when the >> COMPILE_TEST option is enabled. >

Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

On 14/10/15 23:42, James Bottomley wrote: > On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote: >> These drivers only have runtime but no build time dependencies, so they can >> be built for testing purposes if the Kconfig COMPILE_TEST option is enabled. >> >>

[PATCH v2] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

-off-by: Luis de Bethencourt --- Hi, This version corrects a typo pointed out by Randy Dunlap. The validity of the patch is still in question after the comments by James Bottomley. [0] I just wanted to send a correct version as a thank you to Randy. Thanks, Luis [0] https://lkml.org/lkml/2015/10

[PATCH] OMAPDSS: DISPC: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/video/fbdev/omap2/dss/dispc-compat.c | 6 +++--- drivers/video/fbdev/omap2/dss/dispc.c| 6 +++--- drivers/video/fbdev/omap2/dss/manager.c | 2 +- 3 files changed, 7

[PATCH] staging: vt6655: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/vt6655/card.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index f842be6..5159270

[PATCH] staging: rtl8192u: simplify conditional statement

The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt --- drivers/stag

Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote: > Luis de Bethencourt writes: > > > These platform drivers have a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. > > > >

Re: [PATCH v2] watchdog: Compile possible drivers with COMPILE_TEST

On 15/10/15 03:11, Krzysztof Kozlowski wrote: > 2015-10-15 7:40 GMT+09:00 Guenter Roeck : >> On 10/14/2015 03:11 PM, Luis de Bethencourt wrote: >>> >>> On 14/10/15 22:35, Guenter Roeck wrote: >>>> >>>> On 10/14/2015 11:55 AM, Luis de Bethencourt

Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST

On 15/10/15 00:39, James Bottomley wrote: > On Thu, 2015-10-15 at 00:30 +0100, Luis de Bethencourt wrote: >> On 14/10/15 23:42, James Bottomley wrote: >>> On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote: >>>> These drivers only have runtime but no build

[PATCH v2] staging: rtl8192u: simplify conditional statement

The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt --- Sorry for the

[PATCH] spi: davinci: use spi->cs_gpio directly

Use spi->cs_gpio directly to remove the following build warning: drivers/spi/spi-davinci.c:219:6: warning: 'gpio' may be used uninitialized in this function Signed-off-by: Luis de Bethencourt Suggested-by: Geert Uytterhoeven --- Hi, The warning and suggestion can be see

[PATCH] staging: wilc1000: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers

[PATCH v3] staging: rtl8192u: simplify conditional

The code can be much cleaner and readable by simplifying the conditional statement. Signed-off-by: Luis de Bethencourt --- Hi, Dan Carpenter pointed out that the check needs to be >= and not just > because ieee->state can change between the two if statements. Thanks for the rev

[PATCH] staging: rtl8188eu: fix misleading indentation

intended? Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rf_cfg.c b/drivers/staging/rtl8188eu/hal/rf_cfg.c index 067649a..a3f1aba 100644 --- a/drivers/staging/rtl8188eu

[PATCH] staging: rtl8723au: core: rtw_wlan_util: fix misleading indentation

For loop is outside of the else branch of the above conditional statement. Fixing misleading indentation. Fix a smatch warning: drivers/staging/rtl8723au/core/rtw_wlan_util.c:528 WMMOnAssocRsp23a() warn: curly braces intended? Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8723au

[PATCH] staging: lustre: o2iblnd: fix misleading indentation

The code is correct, the indentation is misleading. Only the the return rc is part of the conditional statement if rc != 0. Fix a smatch warning: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157 kiblnd_hdev_setup_mrs() warn: curly braces intended? Signed-off-by: Luis de Bethencourt

[PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Fixes smatch warning and similars: drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt --- drivers

[PATCH 00/12] ASoC: Fix module autoload for OF platform drivers

Hello, This series adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 01/12] ASoC: atmel_wm8904: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/atmel/atmel_wm8904.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/atmel/atmel_wm8904.c b/soun

[PATCH 03/12] ASoC: wm8510: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/codecs/wm8510.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/c

[PATCH 02/12] ASoC: da9055: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/codecs/da9055.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/da9055.c b/sound/soc/c

[PATCH 04/12] ASoC: wm8580: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/codecs/wm8580.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/c

[PATCH 05/12] ASoC: wm8523: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/codecs/wm8523.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/wm8523.c b/sound/soc/c

[PATCH 06/12] ASoC: fsl-asoc-card: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/fsl/fsl-asoc-card.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/soun

[PATCH 07/12] ASoC: fsl_sai: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/fsl/fsl_sai.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_

[PATCH 08/12] ASoC: jz4740: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/jz4740/jz4740-i2s.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/jz4740/jz4740-i2s.c b/soun

[PATCH 09/12] ASoC: kirkwood: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/kirkwood/armada-370-db.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/kirkwood/armada-370-db

[PATCH 10/12] ASoC: pxa: Fix module autoload for OF platform drivers

These platform drivers have a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/pxa/pxa-ssp.c| 1 + sound/soc/pxa/pxa2xx-pcm.c | 1 + 2 files changed, 2 insertions(+) diff --git a/

[PATCH 11/12] ASoC: mop500: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/ux500/mop500.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/ux500/mop500.c b/sound/soc/

[PATCH 12/12] ASoC: ux500: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- sound/soc/ux500/ux500_msp_dai.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/ux500/ux500_msp_dai.c b/

[PATCH] ALSA: sparc: amd7930: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the co

[PATCH 0/3] watchdog: Fix module autoload for OF platform drivers

Hello, This series adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/watchdog/moxart_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/moxart_wdt.c b/dr

[PATCH 3/3] watchdog: gef_wdt: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/watchdog/gef_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/gef_wdt.c b/drivers/wat

[PATCH 2/3] watchdog: mena21_wdt: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/watchdog/mena21_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/mena21_wdt.c b/dr

[PATCH] uio: uio_fsl_elbc_gpcm: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the co

[PATCH] thermal: db8500_cpufreq_cooling: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- Hello, This patch adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the co

[PATCH 0/2] staging: Fix module autoload for OF platform drivers

Hello, This series adds the missing MODULE_DEVICE_TABLE() for OF to eport that information so modules have the correct aliases built-in and autoloading works correctly. A longer explanation by Javier Canillas can be found here: https://lkml.org/lkml/2015/7/30/519 Thanks, Luis Luis de

[PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/st

[PATCH 2/2] staging: octeon-usb: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work. Signed-off-by: Luis de Bethencourt --- drivers/staging/octeon-usb/octeon-hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/octeon-usb/o

Re: [PATCH 1/2] staging: mt29f_spinand: Fix module autoload for OF platform driver

On Fri, Sep 04, 2015 at 11:42:37AM +0530, Sudip Mukherjee wrote: > On Thu, Sep 03, 2015 at 01:13:14PM +0200, Luis de Bethencourt wrote: > > This platform driver has a OF device ID table but the OF module > > alias information is not created so module autoloading won't work. &g

[PATCH] staging: rtl8712: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/os_intfs.c| 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 9 +- drivers/staging/rtl8712/rtl8712_efuse.c | 49 drivers/staging

[PATCH] staging: ft1000: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++-- drivers/staging/ft1000/ft1000-usb/ft1000_hw.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] staging: emxx_udc: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/emxx_udc/emxx_udc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c

Re: [PATCH v2] HID: hiddev: change hiddev_connect() to return bool

On 13/10/15 02:49, Krzysztof Kozlowski wrote: > 2015-10-09 22:00 GMT+09:00 Luis de Bethencourt : >> Since hid_connect() only cares about hiddev_connect() succeeding or >> failing, there is no need for this function to return an int and it can >> return a bool instead. >

[PATCH v2 0/3] staging: code cleanup

ng it cover all rtl8712. In other words, these are a series of recursive cleanup changes. Thanks for the review Mike, Luis Luis de Bethencourt (3): staging: rtl8712: Remove boolean comparisons staging: rtl8712: braces should be used on all arms staging: rtl8712: spaces preferred around ope

[PATCH v2 1/3] staging: rtl8712: Remove boolean comparisons

Boolean tests do not need explicit comparison to true or false. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8712/os_intfs.c| 4 +- drivers/staging/rtl8712/rtl8712_cmd.c | 9 +- drivers/staging/rtl8712/rtl8712_efuse.c | 56 - drivers/staging

  1   2   3   4   5   6   7   >