Re: [RFC PATCH 01/10] s390/pci: base support

2012-12-18 Thread Sebastian Ott
On Thu, 13 Dec 2012, Bjorn Helgaas wrote: > On Thu, Dec 13, 2012 at 4:51 AM, Jan Glauber wrote: > > On Mon, 2012-12-10 at 14:14 -0700, Bjorn Helgaas wrote: > >> On Wed, Nov 14, 2012 at 2:41 AM, Jan Glauber > >> wrote: > >> > Add PCI support for s390, (only 64 bit mode is supported by hardware

[PATCH] pci: add pcibios_release_device

2013-06-04 Thread Sebastian Ott
() call that architectures can override to do so. Signed-off-by: Sebastian Ott --- drivers/pci/pci.c | 10 ++ drivers/pci/probe.c |1 + include/linux/pci.h |1 + 3 files changed, 12 insertions(+) --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1335,6 +1335,16 @@ int __weak

Re: [PATCH] misc/genwqe: ensure zero initialization

2016-09-23 Thread Sebastian Ott
On Thu, 22 Sep 2016, Frank Haverkamp wrote: > > On 12.09.2016, at 20:09, Sebastian Ott wrote: > > Genwqe uses dma_alloc_coherent and depends on zero initialized memory. On > > one occasion it ueses an explicit memset on others it uses un-initialized > > memory. >

Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Sebastian Ott
On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > Remove unnecessary error handling because the only failure value that > can be returned is NULL and so the test can never be true. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e = debugfs

Re: [PATCH] s390/pci: Remove unnecessary if condition

2016-07-29 Thread Sebastian Ott
On Fri, 29 Jul 2016, Julia Lawall wrote: > On Fri, 29 Jul 2016, Sebastian Ott wrote: > > On Fri, 29 Jul 2016, Amitoj Kaur Chawla wrote: > > > Remove unnecessary error handling because the only failure value that > > > can be returned is NULL and so the test can nev

[PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap label is one too big which results in a panic in mlx4_free_eq. This patch fixes the index in the error path. Signed-off-by: Sebastian Ott --- drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++-- 1 file changed, 2

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
Hello Tariq, On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > If an error occurs in mlx4_init_eq_table the index used in the > > err_out_unmap label is one too big which results in a panic in > > mlx4_free_eq. This patch fixes the in

Re: [PATCH] net/mlx4_en: fix off by one in error handling

2016-09-14 Thread Sebastian Ott
On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 4:53 PM, Sebastian Ott wrote: > > On Wed, 14 Sep 2016, Tariq Toukan wrote: > > > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > > > If an error occurs in mlx4_init_eq_table the index used in the > > &g

Re: [PATCH] s390: provide default ioremap and iounmap declaration

2017-05-29 Thread Sebastian Ott
Hi, On Fri, 26 May 2017, Logan Gunthorpe wrote: > On 26/05/17 06:38 AM, Heiko Carstens wrote: > > On Thu, May 25, 2017 at 09:43:48AM -0600, Logan Gunthorpe wrote: > > I'd rather move the #ifdef CONFIG_PCI than implementing this yet another > > time (see patch below). But I'll leave that up to Seba

Re: [PATCH v2] s390: provide default ioremap and iounmap declaration

2017-05-30 Thread Sebastian Ott
where they'd likely > never be called without CONFIG_PCI set, but this is needed to compile > such changes. > > Signed-off-by: Logan Gunthorpe > Cc: Martin Schwidefsky > Cc: Heiko Carstens > cc: Sebastian Ott > Cc: Al Viro > --- > > v2 of this patch is cha

Re: [PATCH] security: device_cgroup: fix RCU lockdep splat

2015-09-01 Thread Sebastian Ott
On Mon, 31 Aug 2015, Felipe Balbi wrote: > while booting AM437x device, the following splat > triggered: > > [ 12.005238] === > [ 12.009749] [ INFO: suspicious RCU usage. ] > [ 12.014116] 4.2.0-next-20150831 #1154 Not tainted > [ 12.019050] -

Re: [PATCH 3/3] s390/cmf: fix kerneldoc

2018-01-23 Thread Sebastian Ott
On Tue, 23 Jan 2018, Cornelia Huck wrote: > Make sure we use proper Return sections, and make the output > for cmf_enable() less odd. > > Signed-off-by: Cornelia Huck > --- > +++ b/drivers/s390/cio/cmf.c > @@ -1118,9 +1118,10 @@ int ccw_set_cmf(struct ccw_device *cdev, int enable) > * enable_cm

Re: [PATCH 0/3] s390: documentation update

2018-01-24 Thread Sebastian Ott
On Tue, 23 Jan 2018, Cornelia Huck wrote: > Cornelia Huck (3): > s390/docs: mention subchannel types > s390/docs: reword airq section > s390/cmf: fix kerneldoc All applied. Thanks!

Re: [PATCH] PCI: Add SPDX GPL-2.0+ to replace implicit GPL v2 or later statement

2018-01-30 Thread Sebastian Ott
subsequently replaced the MODULE_LICENSE() with a "License: GPL" comment. > > Add SPDX GPL-2.0+ and remove the "License: GPL" comment, relying on the > assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license > identifier to files with no license") that the SPDX identifier may be used > instead of the full boilerplate text. > > Signed-off-by: Bjorn Helgaas Acked-by: Sebastian Ott

dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7

2018-03-27 Thread Sebastian Ott
Hi, commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma allocations specifying __GFP_ZERO by silently removing that flag. Why should "the memory returned [] always be zeroed."? Regards, Sebastian

Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7

2018-03-27 Thread Sebastian Ott
Hello Geert, On Tue, 27 Mar 2018, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott > wrote: > > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma > > allocations specifying __GFP_ZERO by silently removing that flag. > > How d

Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7

2018-03-27 Thread Sebastian Ott
On Tue, 27 Mar 2018, Christoph Hellwig wrote: > On Tue, Mar 27, 2018 at 10:12:54AM +0200, Sebastian Ott wrote: > > Hi, > > > > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma > > allocations specifying __GFP_ZERO by silently removing that flag. >

[bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-06 Thread Sebastian Ott
Hi, Today's kernel oopsed on s390. Bisect points to: 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") [1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total size, 48 KB/track, compatible disk layout [1.898308] [ cut here ]--

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-06 Thread Sebastian Ott
On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 9:47 AM, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > >> Today's kernel oopsed on s390. Bisect points to: > >> 3c8ba0d61d04 ("kernel.h: Retain con

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-09 Thread Sebastian Ott
On Fri, 6 Apr 2018, Kees Cook wrote: > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > wrote: > > Today's kernel oopsed on s390. Bisect points to: > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()") > > > > [1.898

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-09 Thread Sebastian Ott
On Mon, 9 Apr 2018, Sebastian Ott wrote: > On Fri, 6 Apr 2018, Kees Cook wrote: > > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott > > wrote: > > > Today's kernel oopsed on s390. Bisect points to: > > > 3c8ba0d61d04 ("kernel.h: Retain cons

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-09 Thread Sebastian Ott
On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott wrote: > > > > Both of the following return 0 on my machine: > > + pr_warn("%u\n", min_not_zero(100, 1000)); > > + pr_warn("%u\n", min_not_zero(

Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

2018-04-09 Thread Sebastian Ott
On Mon, 9 Apr 2018, Linus Torvalds wrote: > On Mon, Apr 9, 2018 at 10:03 AM, Linus Torvalds > wrote: > > > > Our old "min()" had the internal variables called "min1" and "min2", > > which is crazy too. > > Actually, no, it used the really cumbersome "__UNIQUE_ID" and then > passed that odd as the

Re: [PATCH] s390: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread Sebastian Ott
On Sat, 1 Dec 2018, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > drivers/s390/block/dasd.c | 15 +-- > drivers/s390/cio/qdio_debug.c | 16 ++-- > 2 files changed, 3 insertions(+), 28 deletions(-) Appl

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-05-30 Thread Sebastian Ott
On Wed, 30 May 2018, Christoph Hellwig wrote: > > - req->completion_data = cqr; > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > + > > Please don't play such tricks. In general your driver structure > should have struct request embedded. If for some reason > struct dasd_cc

[PATCH] s390/cio: make vfio_ccw_io_region static

2018-10-15 Thread Sebastian Ott
Fix the following sparse warning: drivers/s390/cio/vfio_ccw_drv.c:25:19: warning: symbol 'vfio_ccw_io_region' was not declared. Should it be static? Signed-off-by: Sebastian Ott --- drivers/s390/cio/vfio_ccw_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH v3 10/16] s390: add pci_iomap_range

2015-01-16 Thread Sebastian Ott
ber of mappings created, and only clear out the mapping for a BAR > when this number reaches 0. > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Tested-by: Sebastian Ott > Signed-off-by: Michael S. Tsirkin > --- > > Heiko, Martin, can you please ack merging this t

Re: [PATCH] lib/dma-debug: fix bucket_find_contain

2015-03-20 Thread Sebastian Ott
On Thu, 19 Mar 2015, Andrew Morton wrote: > On Mon, 16 Mar 2015 19:24:29 +0100 (CET) Sebastian Ott > wrote: > > > bucket_find_contain will search the bucket list for a dma_debug_entry. When > > the entry isn't found it needs to search other buckets too, since only the

Re: [PATCH v1 7/7] s390/block/dasd: remove obsolete while -EBUSY loop

2015-04-08 Thread Sebastian Ott
nder Viro > CC: Markus Pargmann > CC: Stefan Weinhuber > CC: Stefan Haberland > CC: Sebastian Ott > CC: Fabian Frederick > CC: Ming Lei > CC: David Herrmann > CC: Andrew Morton > CC: Peter Zijlstra > CC: nbd-gene...@lists.sourceforge.net > CC: linux-s...@vge

Re: [PATCH] driver core: move uevent call to driver_register

2012-07-17 Thread Sebastian Ott
Hi, On Mon, 16 Jul 2012, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2012 at 09:35:02AM +0800, Ming Lei wrote: > > On Tue, Jul 3, 2012 at 1:08 AM, Sebastian Ott > > wrote: > > > > > --- a/drivers/base/driver.c > > > +++ b/drivers/base/driver.c > &

Re: [PATCH] driver core: move uevent call to driver_register

2012-07-17 Thread Sebastian Ott
Hi, On Tue, 17 Jul 2012, Ming Lei wrote: > On Tue, Jul 3, 2012 at 1:08 AM, Sebastian Ott > wrote: > > > --- a/drivers/base/driver.c > > +++ b/drivers/base/driver.c > > @@ -187,6 +187,9 @@ int driver_register(struct device_driver > > ret = d

Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7

2018-03-27 Thread Sebastian Ott
On Tue, 27 Mar 2018, Christoph Hellwig wrote: > On Tue, Mar 27, 2018 at 05:24:10PM +0200, Sebastian Ott wrote: > > What do you mean by current implementations? Arch specific code? At least > > on s390 we don't do that. dma-mapping.h doesn't do it either. > > The ar

Re: [PATCH v9 2/2] blk-mq: Rework blk-mq timeout handling again

2018-05-15 Thread Sebastian Ott
On Mon, 14 May 2018, Bart Van Assche wrote: > Recently the blk-mq timeout handling code was reworked. See also Tejun > Heo, "[PATCHSET v4] blk-mq: reimplement timeout handling", 08 Jan 2018 > (https://www.mail-archive.com/linux-block@vger.kernel.org/msg16985.html). > This patch reworks the blk-mq t

make TAGS broken with commit 99443f811c452c6 ("scripts/tags.sh: change find_other_sources()...")

2018-04-26 Thread Sebastian Ott
Hi, on my s390 test system make TAGS is broken since commit 99443f811c452c6 ("scripts/tags.sh: change find_other_sources() for include directories") # make TAGS GEN TAGS xargs: etags: terminated by signal 11 This is a rather old etags from fedora 24. On x86 using a more recent etags (fedor

Re: make TAGS broken with commit 99443f811c452c6 ("scripts/tags.sh: change find_other_sources()...")

2018-04-26 Thread Sebastian Ott
On Thu, 26 Apr 2018, Sebastian Ott wrote: > on my s390 test system make TAGS is broken since commit 99443f811c452c6 > ("scripts/tags.sh: change find_other_sources() for include directories") > > # make TAGS > GEN TAGS > xargs: etags: terminated by signal 11 >

Re: [PATCH 07/12] s390: cio: fix cio_irb declaration

2019-04-09 Thread Sebastian Ott
On Mon, 8 Apr 2019, Arnd Bergmann wrote: > clang points out that the declaration of cio_irb does not match the > definition exactly, it is missing the alignment attribute: > > ../drivers/s390/cio/cio.c:50:1: warning: section does not match previous > declaration [-Wsection] > DEFINE_PER_CPU_ALIGN

Re: [PATCH 7/7] s390/PCI: Use generic pci_enable_resources()

2014-03-03 Thread Sebastian Ott
isn't a problem. > > - Checks res->parent. The s390 pcibios_add_device() calls > pci_claim_resource() on all BARs (except ROM, IOV, and bridge windows) > so this isn't a problem either. > > Signed-off-by: Bjorn Helgaas > CC: Martin Schwidefsky >

Re: [GIT PULL] ima: bug fixes for Linus

2013-11-27 Thread Sebastian Ott
Hello, On Mon, 25 Nov 2013, Roberto Sassu wrote: > On 11/25/2013 07:46 PM, Roberto Sassu wrote: > > On 11/25/2013 04:40 PM, James Morris wrote: > > > On Mon, 25 Nov 2013, Mimi Zohar wrote: > > > > > > > Hi James, > > > > > > > > These are the "essential fixes for regressions". > > > > > > > >

Re: [PATCH] ima: store address of template_fmt_copy in a pointer before calling strsep

2013-11-27 Thread Sebastian Ott
On Wed, 27 Nov 2013, Roberto Sassu wrote: > This patch stores the address of the 'template_fmt_copy' variable in a new > variable, called 'template_fmt_ptr', so that the latter is passed as an > argument of strsep() instead of the former. This modification is needed > in order to correctly free t

mm/dmapool.c: possible circular locking dependency detected

2013-11-08 Thread Sebastian Ott
CPU0CPU1 [ 34.736005] [ 34.736006] lock(pools_lock); [ 34.736008] lock(s_active#27); [ 34.736010]lock(pools_lock); [ 34.736013] lock(s_active#27); [ 34.736015] [

Re: [PATCH] misc/GenWQE: fix pci_enable_msi usage

2014-07-18 Thread Sebastian Ott
On Thu, 17 Jul 2014, Frank Haverkamp wrote: > Hi Bjorn and Sebastian, > > Am Mittwoch, den 16.07.2014, 15:10 -0600 schrieb Bjorn Helgaas: > > [+cc linux-pci] > > > > On Wed, Jul 09, 2014 at 12:46:39PM +0200, Sebastian Ott wrote: > > > GenWQE used to cal

hanging aio process

2014-05-19 Thread Sebastian Ott
Hello, on the latest kernel a fio job with 4 workers using libaio hangs. git bisect points to: commit e02ba72aabfade4c9cd6e3263e9b57bf890ad25c Author: Anatol Pomozov Date: Tue Apr 15 11:31:33 2014 -0700 aio: block io_destroy() until all context requests are

Re: hanging aio process

2014-05-20 Thread Sebastian Ott
On Mon, 19 May 2014, Benjamin LaHaise wrote: > On Mon, May 19, 2014 at 07:38:51PM +0200, Sebastian Ott wrote: > > Hello, > > > > on the latest kernel a fio job with 4 workers using libaio hangs. > > Is more than one process stuck in state D when the hang occurs? If s

Re: hanging aio process

2014-05-20 Thread Sebastian Ott
On Tue, 20 May 2014, Sebastian Ott wrote: > On Mon, 19 May 2014, Benjamin LaHaise wrote: > > It is entirely possible the bug isn't > > caused by the referenced commit, as the commit you're pointing to merely > > makes io_destroy() syscall wait for all aio outs

[PATCH] mm/mempool: warn about __GFP_ZERO usage

2014-04-14 Thread Sebastian Ott
even when called with __GFP_ZERO. Add a note and VM_BUG_ON statement to make that clear. Signed-off-by: Sebastian Ott --- mm/mempool.c |2 ++ 1 file changed, 2 insertions(+) --- a/mm/mempool.c +++ b/mm/mempool.c @@ -192,6 +192,7 @@ EXPORT_SYMBOL(mempool_resize); * returns NULL. Note t

Re: [PATCH] s390: fix new ccwgroup.h kernel-doc warning

2014-04-14 Thread Sebastian Ott
On Mon, 14 Apr 2014, Randy Dunlap wrote: > From: Randy Dunlap > > Fix new s390 kernel-doc warning: > > Warning(arch/s390/include/asm/ccwgroup.h:27): No description found for > parameter 'ungroup_work' > > Signed-off-by: Randy Dunlap > Cc: Sebastian O

[PATCH] misc/GenWQE: fix pci_enable_msi usage

2014-07-09 Thread Sebastian Ott
enWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()" pci_enable_msi_exact is used which fails if the desired number of MSI's was not possible to allocate. Change GenWQE to use pci_enable_msi_range to restore the old behavior. Signed-off-by: Sebastian Ott --- drivers/misc/genw

Re: [PATCH] misc/GenWQE: fix pci_enable_msi usage

2014-07-09 Thread Sebastian Ott
On Wed, 9 Jul 2014, Alexander Gordeev wrote: > On Wed, Jul 09, 2014 at 12:46:39PM +0200, Sebastian Ott wrote: > > GenWQE used to call pci_enable_msi_block to allocate a desired number > > of MSI's. If that was not possible pci_enable_msi_block returned with a > > sma

Re: hanging aio process

2014-05-20 Thread Sebastian Ott
Hi, On Tue, 20 May 2014, Anatol Pomozov wrote: > On Tue, May 20, 2014 at 6:16 AM, Sebastian Ott > wrote: > > On Tue, 20 May 2014, Sebastian Ott wrote: > >> On Mon, 19 May 2014, Benjamin LaHaise wrote: > >> > It is entirely possible the bug isn't > >

Re: hanging aio process

2014-05-21 Thread Sebastian Ott
On Tue, 20 May 2014, Anatol Pomozov wrote: > On Tue, May 20, 2014 at 11:09 AM, Sebastian Ott > wrote: > > On Tue, 20 May 2014, Anatol Pomozov wrote: > >> On Tue, May 20, 2014 at 6:16 AM, Sebastian Ott > >> wrote: > >> > On Tue, 20 May 2014, Sebast

Re: hanging aio process

2014-05-21 Thread Sebastian Ott
On Wed, 21 May 2014, Sebastian Ott wrote: > On Tue, 20 May 2014, Anatol Pomozov wrote: > > On Tue, May 20, 2014 at 11:09 AM, Sebastian Ott > > wrote: > > > On Tue, 20 May 2014, Anatol Pomozov wrote: > > >> On Tue, May 20, 2014 at 6:16 AM, Sebastian Ott > &g

Re: [PATCH 1/1] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

2014-05-21 Thread Sebastian Ott
On Tue, 20 May 2014, Joe Perches wrote: > On Tue, 2014-05-20 at 18:37 +0200, Fabian Frederick wrote: > > This is untested. > [] > > diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c > [] > > @@ -411,15 +411,14 @@ static inline void qdio_stop_polling(struct qdio_q *q) > > >

Re: hanging aio process

2014-05-21 Thread Sebastian Ott
On Wed, 21 May 2014, Anatol Pomozov wrote: > On Wed, May 21, 2014 at 1:48 AM, Sebastian Ott > wrote: > > On Wed, 21 May 2014, Sebastian Ott wrote: > >> On Tue, 20 May 2014, Anatol Pomozov wrote: > >> > On Tue, May 20, 2014 at 11:09 AM, Sebastian Ott > >&

Re: linux-next: build failure after merge of the pci tree

2014-05-21 Thread Sebastian Ott
/pci-sysfs.c:429:1: warning: control reaches end of non-void function [-Wreturn-type] Reported-by: Stephen Rothwell Signed-off-by: Sebastian Ott --- drivers/pci/pci-sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 4e0acef..d6e61a

Re: [PATCH 1/1] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

2014-06-02 Thread Sebastian Ott
Hello Fabian, On Tue, 20 May 2014, Fabian Frederick wrote: > > This is untested. > > Cc: Sebastian Ott > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > drivers/s390/cio/qdio_main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > &

Re: [PATCH 1/1] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

2014-06-03 Thread Sebastian Ott
On Mon, 2 Jun 2014, Fabian Frederick wrote: > On Mon, 2 Jun 2014 16:41:48 +0200 (CEST) > Sebastian Ott wrote: > > > Hello Fabian, > > > > On Tue, 20 May 2014, Fabian Frederick wrote: > > > > > > This is untested. > > > > > >

Re: [PATCH 8/10] s390/pci: use safer test on the result of find_first_zero_bit

2014-06-04 Thread Sebastian Ott
On Wed, 4 Jun 2014, Julia Lawall wrote: > From: Julia Lawall > > Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may > return a larger number than the maximum position argument if that position > is not a multiple of BITS_PER_LONG. > > The semantic match that finds this prob

[PATCH] percpu-refcount: fix usage of this_cpu_ops (was Re: hanging aio process)

2014-06-04 Thread Sebastian Ott
Hello, On Wed, 21 May 2014, Anatol Pomozov wrote: > Hi > > On Wed, May 21, 2014 at 1:48 AM, Sebastian Ott > wrote: > > On Wed, 21 May 2014, Sebastian Ott wrote: > >> On Tue, 20 May 2014, Anatol Pomozov wrote: > >> > On Tue, May 20, 2014 at 11:09 AM, Sebas

Re: [PATCH V2 2/2] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

2014-06-04 Thread Sebastian Ott
On Tue, 3 Jun 2014, Fabian Frederick wrote: > account_sbals is called by get_inbound_buffer_frontier and > get_outbound_buffer_frontier with 'count' value > 0 so we can safely convert > shift loop to ilog2. > > Cc: Sebastian Ott > Cc: Joe Perches > Cc: Andr

Re: [PATCH] percpu-refcount: fix usage of this_cpu_ops (was Re: hanging aio process)

2014-06-04 Thread Sebastian Ott
Hi, On Wed, 4 Jun 2014, Tejun Heo wrote: > On Wed, Jun 04, 2014 at 03:58:24PM +0200, Sebastian Ott wrote: > > From 82295633cad58c7d6b9af4e470e3168ed43a6779 Mon Sep 17 00:00:00 2001 > > From: Heiko Carstens > > Date: Wed, 4 Jun 2014 12:53:19 +0200 > > Subject: [PATCH]

Re: [PATCH 3.16 098/217] s390/pci: enforce fmb page boundary rule

2016-04-27 Thread Sebastian Ott
On Wed, 27 Apr 2016, Ben Hutchings wrote: > 3.16.35-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Sebastian Ott > > commit 80c544ded25ac14d7cc3e555abb8ed2c2da99b84 upstream. > > The function measurement

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-17 Thread Sebastian Ott
Hi, On Wed, 17 Feb 2016, Kirill A. Shutemov wrote: > On Tue, Feb 16, 2016 at 05:24:44PM +0100, Gerald Schaefer wrote: > > On Mon, 15 Feb 2016 23:35:26 +0200 > > "Kirill A. Shutemov" wrote: > > > > > Is there any chance that I'll be able to trigger the bug using QEMU? > > > Does anybody have an Q

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-15 Thread Sebastian Ott
On Mon, 15 Feb 2016, Kirill A. Shutemov wrote: > > [ 59.851421] list_del corruption. next->prev should be 6e1eb000, > > but was 0400 > > This kinda interesting: 0x400 is TAIL_MAPPING.. Hm.. > > Could you check if you see the problem on commit 1c290f642101 and its > immediat

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-16 Thread Sebastian Ott
On Mon, 15 Feb 2016, Kirill A. Shutemov wrote: > Just to make sure: commit 122afea9626a is fine, commit 61f5d698cc97 > crashes. Correct? Correct.

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-24 Thread Sebastian Ott
On Wed, 24 Feb 2016, Martin Schwidefsky wrote: > On Tue, 23 Feb 2016 22:33:45 +0300 > "Kirill A. Shutemov" wrote: > > > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote: > > > I'll check with Martin, maybe it is actually trivial, then we can > > > do a quick test it to rule that on

PATCH] s390: fix machine check handling

2014-11-28 Thread Sebastian Ott
Hi, would it be possible to have this one for 3.18 (if not, please add Cc: sta...@vger.kernel.org # v3.18) Regards, Sebastian >8- >From ca198a6ff5766f19645104b7f8d621774524c4b4 Mon Sep 17 00:00:00 2001 From: Sebastian Ott Date: Fri, 28 Nov 2014 15:40:57 +0100 Subject: [PATCH] s39

Re: [PATCH 1/1] s390/pci: Deletion of unnecessary checks before the function call "debug_unregister"

2014-11-24 Thread Sebastian Ott
On Sat, 22 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 22 Nov 2014 15:00:55 +0100 > > The debug_unregister() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software.

Re: [PATCH percpu/for-3.18-fixes] s390: fix machine check regression caused by the conversion from __get_cpu_var() to this_cpu_ptr()

2014-12-02 Thread Sebastian Ott
On Tue, 2 Dec 2014, Tejun Heo wrote: > Sorry about the delay. Was on vacation. > > Patch applied to percpu/for-3.18-fixes w/ minor updates to the patch > subject and description. Will push out to Linus soon. > I've seen that Martin took the patch and it's already in Linus' tree - commit 2cb4a1

Re: [PATCH v3 22/27] s390/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-10-16 Thread Sebastian Ott
On Wed, 15 Oct 2014, Yijing Wang wrote: > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Signed-off-by: Yijing Wang > --- > Hi Sebastian, >I dropped the Acked-by , because this version has a > lot c

Re: [PATCH RFC 2/5] s390: add pci_iomap_range

2014-12-19 Thread Sebastian Ott
On Mon, 15 Dec 2014, Michael S. Tsirkin wrote: > From: Michael S Tsirkin > > Virtio drivers should map the part of the range they need, not > necessarily all of it. > To this end, support mapping ranges within BAR on s390. > Since multiple ranges can now be mapped within a BAR, we keep track of >

Re: [PATCH RFC 2/5] s390: add pci_iomap_range

2014-12-19 Thread Sebastian Ott
On Fri, 19 Dec 2014, Michael S. Tsirkin wrote: > On Fri, Dec 19, 2014 at 03:13:37PM +0100, Sebastian Ott wrote: > > On Mon, 15 Dec 2014, Michael S. Tsirkin wrote: > > > From: Michael S Tsirkin > > > > > > Virtio drivers should map the part of the range they n

[PATCH] infiniband/mlx4: check for mapping error

2015-03-16 Thread Sebastian Ott
Since ib_dma_map_single can fail use ib_dma_mapping_error to check for errors. Signed-off-by: Sebastian Ott --- drivers/infiniband/hw/mlx4/mad.c |9 + drivers/infiniband/hw/mlx4/qp.c |4 2 files changed, 13 insertions(+) --- a/drivers/infiniband/hw/mlx4/mad.c +++ b

[PATCH] lib/dma-debug: fix bucket_find_contain

2015-03-16 Thread Sebastian Ott
hash bucket but when its list is searched the original dma_debug_entry is to be used not its modified copy. This fixes false "device driver tries to sync DMA memory it has not allocated" warnings. Signed-off-by: Sebastian Ott --- lib/dma-debug.c |2 +- 1 file changed, 1 insertion

Re: [PATCH 19/27] s390: Remove use of seq_printf return value

2015-02-22 Thread Sebastian Ott
On Sat, 21 Feb 2015, Joe Perches wrote: > The seq_printf return value, because it's frequently misused, > will eventually be converted to void. > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > seq_has_overflowed() and make public") >

[PATCH] iommu/s390: fix sparse warnings

2015-11-06 Thread Sebastian Ott
atic? Signed-off-by: Sebastian Ott --- drivers/iommu/s390-iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c index cbe198c..030e94c 100644 --- a/drivers/iommu/s390-iommu.c +++ b/drivers/iommu/s390-iommu.c @@ -49,7

mlx4: "failed to allocate default counter port 1"

2015-06-30 Thread Sebastian Ott
Hello, after the latest mellanox update the mlx4 driver fails to probe a VF: [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed to allocate default counter port 1 err -22 [ 88.909564] mlx4_core :00:00.0: Failed to allocate default counters, aborting [ 88.961735

Re: mlx4: "failed to allocate default counter port 1"

2015-06-30 Thread Sebastian Ott
On Tue, 30 Jun 2015, Or Gerlitz wrote: > On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott > wrote: > > after the latest mellanox update the mlx4 driver fails to probe a VF: > > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: > > failed to allocate de

[PATCH] misc/genwqe: get rid of atomic allocations

2015-09-29 Thread Sebastian Ott
tomic. Regards, Sebastian >8 misc/genwqe: get rid of atomic allocations All of genwqe's atomic allocations happen in a context where it's allowed to sleep. Change these to use GFP_KERNEL. Signed-off-by: Sebastian Ott --- drivers/misc/genwqe/card_ddcb.c |2 +- drivers/misc/g

Re: [PATCH v2 02/10] s390/pci: Loop using PCI_STD_NUM_BARS

2019-08-16 Thread Sebastian Ott
sm/pci_clp.h | 6 +++--- > arch/s390/pci/pci.c | 16 > arch/s390/pci/pci_clp.c | 6 +++--- > 4 files changed, 15 insertions(+), 18 deletions(-) > Acked-by: Sebastian Ott

Re: [PATCH] s390/cio: fix intparm documentation

2019-09-16 Thread Sebastian Ott
On Wed, 11 Sep 2019, Cornelia Huck wrote: > The common I/O layer is maintaining an "intparm" inspired by > the hardware intparm for driver usage. This "intparm" is not > only applicaple for ssch, but also for hsch/csch. The kerneldoc > states that it is only updated for hsch/csch if no prior reques

Re: [PATCH v2] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-07 Thread Sebastian Ott
On Wed, 6 Feb 2019, Tony Krowiak wrote: > diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c > +void ap_bus_cfg_chg(void) > +{ > + AP_DBF(DBF_INFO, "%s config change, forcing bus rescan\n", __func__); > + > + ap_bus_force_rescan(); > +} > +EXPORT_SYMBOL(ap_bus_cfg_chg)

Re: [PATCH] s390: pci: no need to check return value of debugfs_create functions

2019-01-23 Thread Sebastian Ott
iko Carstens > Cc: Sebastian Ott > Cc: Gerald Schaefer > Cc: linux-s...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Applied for inclusion via s390/linux.git Thanks!

Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

2019-02-04 Thread Sebastian Ott
On Thu, 31 Jan 2019, Tony Krowiak wrote: > On 1/30/19 1:32 PM, Sebastian Ott wrote: > > On Wed, 30 Jan 2019, Tony Krowiak wrote: > >> +++ b/drivers/s390/cio/chsc.h > >> @@ -9,6 +9,7 @@ > >> #include > >> #include > >> #include > >

Re: [PATCH] s390/pci: PCI_IOV_RESOURCES loop refactoring in zpci_map_resources

2019-08-06 Thread Sebastian Ott
On Tue, 6 Aug 2019, Denis Efremov wrote: > This patch alters the for loop iteration scheme in zpci_map_resources > to make it more usual. Thus, the patch generalizes the style for > PCI_IOV_RESOURCES iteration and improves readability. > > Signed-off-by: Denis Efremov Applied for inclusion via s

Re: [PATCH v3] zcrypt: handle AP Info notification from CHSC SEI command

2019-03-11 Thread Sebastian Ott
On Mon, 11 Mar 2019, Tony Krowiak wrote: > On 2/18/19 12:01 PM, Tony Krowiak wrote: > > The current AP bus implementation periodically polls the AP configuration > > to detect changes. When the AP configuration is dynamically changed via the > > SE or an SCLP instruction, the changes will not be re

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-06-08 Thread Sebastian Ott
Hello, On Wed, 30 May 2018, Sebastian Ott wrote: > On Wed, 30 May 2018, Christoph Hellwig wrote: > > > - req->completion_data = cqr; > > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > > + > > > > Please don't play such tricks.

[BUG, PATCH] random: sleep in irq context

2018-04-23 Thread Sebastian Ott
e+0x32/0x50 [<008e659e>] default_idle_call+0x3e/0x68 [<001889aa>] do_idle+0xea/0x1c0 [<00188d26>] cpu_startup_entry+0x3e/0x48 [<0011758e>] smp_start_secondary+0x13e/0x158 [<008e87a2>] restart_int_handler+0x5a/0x70 [&l

Re: [BUG, PATCH] random: sleep in irq context

2018-04-23 Thread Sebastian Ott
On Mon, 23 Apr 2018, Sebastian Ott wrote: > From 9d29e0c92efaf94277bc178782523283958ae8c8 Mon Sep 17 00:00:00 2001 > From: Sebastian Ott > Date: Mon, 23 Apr 2018 14:59:20 +0200 > Subject: [PATCH] random: don't sleep during allocations in irq context > > Since numa_crng_in

Re: [BUG, PATCH] random: sleep in irq context

2018-04-24 Thread Sebastian Ott
On Mon, 23 Apr 2018, Sebastian Ott wrote: > This happend once during boot and I could not reproduce this since, but I > think the following patch should fix the issue: I can now recreate the issue reliably. The following patch works for me: -->8 >From 6bbfab86beae8fe8b6efeffd08c9

Re: [PATCH] s390/cio/chp : Remove deprecated create_singlethread_workqueue

2016-07-16 Thread Sebastian Ott
On Sat, 16 Jul 2016, Bhaktipriya Shridhar wrote: > The workqueue "chp_wq" is involved in performing pending > configure tasks for channel paths. > > It has a single work item(&cfg_work) and hence doesn't require > ordering. Also, it is not being used on a memory reclaim path. > Hence, the singleth

[PATCH] lib/iommu-helper: skip to next segment

2016-06-08 Thread Sebastian Ott
start of the next segment (which is the next bit position such that we'll not cross the same segment boundary again). Signed-off-by: Sebastian Ott Reviewed-by: Gerald Schaefer --- lib/iommu-helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/iommu-helper.c

mlx5: ifup failure due to huge allocation

2016-11-02 Thread Sebastian Ott
Hi, Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: [ 22.318553] [ cut here ] [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 __alloc_pages_nodemask+0x2ee/0x1298 [ 22.318568] Modules linked in: mlx4_ib ib_core mlx5_core mlx4_en m

mlx5: net_device.addr_list_lock usage before initialization

2016-12-13 Thread Sebastian Ott
Hi, I ran into the following lockdep complaint: [7.059561] INFO: trying to register non-static key. [7.059566] the code is fine but needs lockdep annotation. [7.059570] turning off the locking correctness validator. [7.059579] CPU: 6 PID: 6 Comm: kworker/u32:0 Not tainted 4.9.0-0

[PATCH resend] IB/core: fix unmap_sg argument

2016-12-13 Thread Sebastian Ott
_common.isra.15+0x572/0x1010 [mlx4_ib] [ 20.781949] [<03ff8013929e>] mlx4_ib_create_qp+0x1de/0x438 [mlx4_ib] [ 20.781953] [<03ff8004f52c>] create_qp.isra.11+0x44c/0x7f0 [ib_uverbs] The following patch fixes this: >8 >From ec91646d8c14e2a8dd2b62187084dab32ef8

[PATCH] IB/core: fix unmap_sg argument

2016-12-02 Thread Sebastian Ott
_common.isra.15+0x572/0x1010 [mlx4_ib] [ 20.781949] [<03ff8013929e>] mlx4_ib_create_qp+0x1de/0x438 [mlx4_ib] [ 20.781953] [<03ff8004f52c>] create_qp.isra.11+0x44c/0x7f0 [ib_uverbs] The following patch fixes this: >8 >From ec91646d8c14e2a8dd2b62187084dab32ef8

lockdep warning: console vs. mem hotplug

2017-03-20 Thread Sebastian Ott
Since commit f975237b7682 ("printk: use printk_safe buffers in printk") I observe lockdep warnings on s390 when doing memory hotplug: [ 132.379220] == [ 132.379220] [ INFO: possible circular locking dependency detected ] [ 132.379221] 4.11.0-r

Re: lockdep warning: console vs. mem hotplug

2017-03-24 Thread Sebastian Ott
On Fri, 24 Mar 2017, Steven Rostedt wrote: > Is there a stack trace of where the lockdep dump happened? That is > useful too. Otherwise we don't see where the inverse happened. Sure. Here you go. [ 132.379220] == [ 132.379220] [ INFO: possible

Re: lockdep warning: console vs. mem hotplug

2017-03-25 Thread Sebastian Ott
On Sat, 25 Mar 2017, Sergey Senozhatsky wrote: > On (03/21/17 13:44), Sergey Senozhatsky wrote: > [..] > > so we probably can > > > > > > 1) move pr_info() out of zone->lock in __offline_isolated_pages(). > >meh... > > > > > > 2) switch to printk_deferred() in __offline_isolated_pages(). >

[PATCH] mm, add_memory_resource: hold device_hotplug lock over mem_hotplug_{begin, done}

2017-02-26 Thread Sebastian Ott
d to a warning when add_memory() is called. Fix this by acquiring device_hotplug_lock in add_memory_resource(). Signed-off-by: Sebastian Ott --- mm/memory_hotplug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 1d3ed58..c633bbc 10064

IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device"

2017-02-27 Thread Sebastian Ott
Hi, commit 99db94940 "IB/core: Remove ib_device.dma_device" breaks infiniband on s390 (and I think also other archs that do something like to_pci_dev(dev) in one of their dma_ops callbacks). With this commit you use the dma_ops of the device that called ib_register_device but you call e.g. dma_ma

  1   2   >