Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Viresh Kumar
On 27-11-18, 09:09, Quentin Perret wrote: > On Tuesday 27 Nov 2018 at 09:27:35 (+0530), Viresh Kumar wrote: > > On 26-11-18, 13:20, Daniel Lezcano wrote: > > > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > >

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Viresh Kumar
On 27-11-18, 09:09, Quentin Perret wrote: > On Tuesday 27 Nov 2018 at 09:27:35 (+0530), Viresh Kumar wrote: > > On 26-11-18, 13:20, Daniel Lezcano wrote: > > > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > >

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Quentin Perret
On Tuesday 27 Nov 2018 at 09:27:35 (+0530), Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: > > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > index 84262cd..f53a3c9 100644 > > ---

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Quentin Perret
On Tuesday 27 Nov 2018 at 09:27:35 (+0530), Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: > > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > index 84262cd..f53a3c9 100644 > > ---

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Daniel Lezcano
On 27/11/2018 04:57, Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: >> diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> b/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> index 84262cd..f53a3c9 100644 >> ---

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Daniel Lezcano
On 27/11/2018 04:57, Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: >> diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> b/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> index 84262cd..f53a3c9 100644 >> ---

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Viresh Kumar
On 26-11-18, 13:20, Daniel Lezcano wrote: > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > index 84262cd..f53a3c9 100644 > --- a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > +++

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Viresh Kumar
On 26-11-18, 13:20, Daniel Lezcano wrote: > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > index 84262cd..f53a3c9 100644 > --- a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > +++

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Rob Herring
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: > In the case of asymmetric SoC with the same micro-architecture, we > have a group of CPUs with smaller OPPs than the other group. One > example is the 96boards dragonboard 820c. There is no dmips/MHz > difference between both

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Rob Herring
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: > In the case of asymmetric SoC with the same micro-architecture, we > have a group of CPUs with smaller OPPs than the other group. One > example is the 96boards dragonboard 820c. There is no dmips/MHz > difference between both

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
Hi Greg, thanks for the review. On 26/11/2018 16:06, Greg Kroah-Hartman wrote: > On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >> @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void)

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
Hi Greg, thanks for the review. On 26/11/2018 16:06, Greg Kroah-Hartman wrote: > On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >> @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void)

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void) >* until we have the necessary code to parse the cpu capacity, so >*

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote: > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void) >* until we have the necessary code to parse the cpu capacity, so >*

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
On 26/11/2018 13:48, Quentin Perret wrote: > On Monday 26 Nov 2018 at 13:20:43 (+0100), Daniel Lezcano wrote: >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> index fd5325b..e0c5b60 100644 >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >>

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Daniel Lezcano
On 26/11/2018 13:48, Quentin Perret wrote: > On Monday 26 Nov 2018 at 13:20:43 (+0100), Daniel Lezcano wrote: >> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c >> index fd5325b..e0c5b60 100644 >> --- a/drivers/base/arch_topology.c >> +++ b/drivers/base/arch_topology.c >>

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Quentin Perret
On Monday 26 Nov 2018 at 13:20:43 (+0100), Daniel Lezcano wrote: > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index fd5325b..e0c5b60 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -243,9 +243,20 @@ static int __init

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-26 Thread Quentin Perret
On Monday 26 Nov 2018 at 13:20:43 (+0100), Daniel Lezcano wrote: > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index fd5325b..e0c5b60 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -243,9 +243,20 @@ static int __init