Re: Linux 4.18-rc6
On Wed, 25 Jul 2018 12:40:26 -0700 Kees Cook wrote: > On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky > wrote: > > On Tue, 24 Jul 2018 09:15:58 +0200 > > Christian Borntraeger wrote: > > > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > >> > On Mon, 23 Jul 2018 16:17:22 -0700 > >> > Linus Torvalds wrote: > >> > > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck > >> >> wrote: > >> >>> > >> > >> Martin - can we just remove the > >> > >> select HAVE_GCC_PLUGINS > >> > >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > >> disable it). > >> > >> Because if it's not getting fixed, it shouldn't be exposed. > >> > >> >>> The problem only affects 4.18 - the code has been rearranged in -next. > >> >>> Only, in my builders, I can't disable a flag for individual releases, > >> >>> so I just disabled it completely for s390. > >> >> > >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> >> this *will* be disabled if it's not fixed. > >> >> > >> >> The fact that it might be fixed in linux-next is entirely immaterial > >> >> to the release of 4.18. > >> > > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be > >> > important enough to warrant a fix, it can be pulled from here: > >> > > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > >> > > >> > Martin Schwidefsky (1): > >> > s390: disable gcc plugins > >> > > >> > Once that is in I will create another patch to undo this one and place > >> > it after the early boot rework. > >> > >> On the list a different fix was proposed about 2 weeks ago, > > https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com > > >> > >> something like > >> > >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > >> > >> and I prefer that. Because your patch disables all gcc plugins. > > > > This change would cause trouble with patch dependencies as als.c is moved > > to a different directory. I would prefer to disable all gcc plugins for > > 4.18. > > I don't understand why not just add it to the Makefile. For -next and > 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o > entry for a file that doesn't exist should be harmless... > > Of course, if no one is actually using the gcc plugins on s390, then > okay, disabling them isn't a problem. :) But since it's been working > on s390 since 4.15, it seems weird to turn all of them off just for > 4.18 when a trivial fix is available. The gcc plugins have not in wide-spread use, it is no problem to just disable them all. The advantage doing the fixing with the Kconfig file is that I avoid a merge conflict with the current features branch. And I do not want to rebase that branch this late in the -rcs just because of this problem. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Wed, 25 Jul 2018 12:40:26 -0700 Kees Cook wrote: > On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky > wrote: > > On Tue, 24 Jul 2018 09:15:58 +0200 > > Christian Borntraeger wrote: > > > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > >> > On Mon, 23 Jul 2018 16:17:22 -0700 > >> > Linus Torvalds wrote: > >> > > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck > >> >> wrote: > >> >>> > >> > >> Martin - can we just remove the > >> > >> select HAVE_GCC_PLUGINS > >> > >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > >> disable it). > >> > >> Because if it's not getting fixed, it shouldn't be exposed. > >> > >> >>> The problem only affects 4.18 - the code has been rearranged in -next. > >> >>> Only, in my builders, I can't disable a flag for individual releases, > >> >>> so I just disabled it completely for s390. > >> >> > >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> >> this *will* be disabled if it's not fixed. > >> >> > >> >> The fact that it might be fixed in linux-next is entirely immaterial > >> >> to the release of 4.18. > >> > > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be > >> > important enough to warrant a fix, it can be pulled from here: > >> > > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > >> > > >> > Martin Schwidefsky (1): > >> > s390: disable gcc plugins > >> > > >> > Once that is in I will create another patch to undo this one and place > >> > it after the early boot rework. > >> > >> On the list a different fix was proposed about 2 weeks ago, > > https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com > > >> > >> something like > >> > >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > >> > >> and I prefer that. Because your patch disables all gcc plugins. > > > > This change would cause trouble with patch dependencies as als.c is moved > > to a different directory. I would prefer to disable all gcc plugins for > > 4.18. > > I don't understand why not just add it to the Makefile. For -next and > 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o > entry for a file that doesn't exist should be harmless... > > Of course, if no one is actually using the gcc plugins on s390, then > okay, disabling them isn't a problem. :) But since it's been working > on s390 since 4.15, it seems weird to turn all of them off just for > 4.18 when a trivial fix is available. The gcc plugins have not in wide-spread use, it is no problem to just disable them all. The advantage doing the fixing with the Kconfig file is that I avoid a merge conflict with the current features branch. And I do not want to rebase that branch this late in the -rcs just because of this problem. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >> > On Mon, 23 Jul 2018 16:17:22 -0700 >> > Linus Torvalds wrote: >> > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >> >>> >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> >> >>> The problem only affects 4.18 - the code has been rearranged in -next. >> >>> Only, in my builders, I can't disable a flag for individual releases, >> >>> so I just disabled it completely for s390. >> >> >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> >> this *will* be disabled if it's not fixed. >> >> >> >> The fact that it might be fixed in linux-next is entirely immaterial >> >> to the release of 4.18. >> > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be >> > important enough to warrant a fix, it can be pulled from here: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >> > >> > Martin Schwidefsky (1): >> > s390: disable gcc plugins >> > >> > Once that is in I will create another patch to undo this one and place >> > it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. I don't understand why not just add it to the Makefile. For -next and 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o entry for a file that doesn't exist should be harmless... Of course, if no one is actually using the gcc plugins on s390, then okay, disabling them isn't a problem. :) But since it's been working on s390 since 4.15, it seems weird to turn all of them off just for 4.18 when a trivial fix is available. -Kees -- Kees Cook Pixel Security
Re: Linux 4.18-rc6
On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >> > On Mon, 23 Jul 2018 16:17:22 -0700 >> > Linus Torvalds wrote: >> > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >> >>> >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> >> >>> The problem only affects 4.18 - the code has been rearranged in -next. >> >>> Only, in my builders, I can't disable a flag for individual releases, >> >>> so I just disabled it completely for s390. >> >> >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> >> this *will* be disabled if it's not fixed. >> >> >> >> The fact that it might be fixed in linux-next is entirely immaterial >> >> to the release of 4.18. >> > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be >> > important enough to warrant a fix, it can be pulled from here: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >> > >> > Martin Schwidefsky (1): >> > s390: disable gcc plugins >> > >> > Once that is in I will create another patch to undo this one and place >> > it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. I don't understand why not just add it to the Makefile. For -next and 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o entry for a file that doesn't exist should be harmless... Of course, if no one is actually using the gcc plugins on s390, then okay, disabling them isn't a problem. :) But since it's been working on s390 since 4.15, it seems weird to turn all of them off just for 4.18 when a trivial fix is available. -Kees -- Kees Cook Pixel Security
Re: Linux 4.18-rc6
On 07/24/2018 09:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >>> On Mon, 23 Jul 2018 16:17:22 -0700 >>> Linus Torvalds wrote: >>> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. >>> >>> Ok, if gcc with the plugins and an allmodconfig is considered to be >>> important enough to warrant a fix, it can be pulled from here: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >>> >>> Martin Schwidefsky (1): >>> s390: disable gcc plugins >>> >>> Once that is in I will create another patch to undo this one and place >>> it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. ok.
Re: Linux 4.18-rc6
On 07/24/2018 09:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >>> On Mon, 23 Jul 2018 16:17:22 -0700 >>> Linus Torvalds wrote: >>> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. >>> >>> Ok, if gcc with the plugins and an allmodconfig is considered to be >>> important enough to warrant a fix, it can be pulled from here: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >>> >>> Martin Schwidefsky (1): >>> s390: disable gcc plugins >>> >>> Once that is in I will create another patch to undo this one and place >>> it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. ok.
Re: Linux 4.18-rc6
On Tue, 24 Jul 2018 09:15:58 +0200 Christian Borntraeger wrote: > On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > > On Mon, 23 Jul 2018 16:17:22 -0700 > > Linus Torvalds wrote: > > > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >>> > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > > >>> The problem only affects 4.18 - the code has been rearranged in -next. > >>> Only, in my builders, I can't disable a flag for individual releases, > >>> so I just disabled it completely for s390. > >> > >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> this *will* be disabled if it's not fixed. > >> > >> The fact that it might be fixed in linux-next is entirely immaterial > >> to the release of 4.18. > > > > Ok, if gcc with the plugins and an allmodconfig is considered to be > > important enough to warrant a fix, it can be pulled from here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > > > Martin Schwidefsky (1): > > s390: disable gcc plugins > > > > Once that is in I will create another patch to undo this one and place > > it after the early boot rework. > > On the list a different fix was proposed about 2 weeks ago, > > something like > > CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > > and I prefer that. Because your patch disables all gcc plugins. This change would cause trouble with patch dependencies as als.c is moved to a different directory. I would prefer to disable all gcc plugins for 4.18. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Tue, 24 Jul 2018 09:15:58 +0200 Christian Borntraeger wrote: > On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > > On Mon, 23 Jul 2018 16:17:22 -0700 > > Linus Torvalds wrote: > > > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >>> > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > > >>> The problem only affects 4.18 - the code has been rearranged in -next. > >>> Only, in my builders, I can't disable a flag for individual releases, > >>> so I just disabled it completely for s390. > >> > >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> this *will* be disabled if it's not fixed. > >> > >> The fact that it might be fixed in linux-next is entirely immaterial > >> to the release of 4.18. > > > > Ok, if gcc with the plugins and an allmodconfig is considered to be > > important enough to warrant a fix, it can be pulled from here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > > > Martin Schwidefsky (1): > > s390: disable gcc plugins > > > > Once that is in I will create another patch to undo this one and place > > it after the early boot rework. > > On the list a different fix was proposed about 2 weeks ago, > > something like > > CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > > and I prefer that. Because your patch disables all gcc plugins. This change would cause trouble with patch dependencies as als.c is moved to a different directory. I would prefer to disable all gcc plugins for 4.18. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > On Mon, 23 Jul 2018 16:17:22 -0700 > Linus Torvalds wrote: > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >>> Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. >>> The problem only affects 4.18 - the code has been rearranged in -next. >>> Only, in my builders, I can't disable a flag for individual releases, >>> so I just disabled it completely for s390. >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> this *will* be disabled if it's not fixed. >> >> The fact that it might be fixed in linux-next is entirely immaterial >> to the release of 4.18. > > Ok, if gcc with the plugins and an allmodconfig is considered to be > important enough to warrant a fix, it can be pulled from here: > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > Martin Schwidefsky (1): > s390: disable gcc plugins > > Once that is in I will create another patch to undo this one and place > it after the early boot rework. On the list a different fix was proposed about 2 weeks ago, something like CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) and I prefer that. Because your patch disables all gcc plugins.
Re: Linux 4.18-rc6
On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > On Mon, 23 Jul 2018 16:17:22 -0700 > Linus Torvalds wrote: > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >>> Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. >>> The problem only affects 4.18 - the code has been rearranged in -next. >>> Only, in my builders, I can't disable a flag for individual releases, >>> so I just disabled it completely for s390. >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> this *will* be disabled if it's not fixed. >> >> The fact that it might be fixed in linux-next is entirely immaterial >> to the release of 4.18. > > Ok, if gcc with the plugins and an allmodconfig is considered to be > important enough to warrant a fix, it can be pulled from here: > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > Martin Schwidefsky (1): > s390: disable gcc plugins > > Once that is in I will create another patch to undo this one and place > it after the early boot rework. On the list a different fix was proposed about 2 weeks ago, something like CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) and I prefer that. Because your patch disables all gcc plugins.
Re: Linux 4.18-rc6
On Mon, 23 Jul 2018 16:17:22 -0700 Linus Torvalds wrote: > On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > > > > Martin - can we just remove the > > > > > > select HAVE_GCC_PLUGINS > > > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > > disable it). > > > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > > > The problem only affects 4.18 - the code has been rearranged in -next. > > Only, in my builders, I can't disable a flag for individual releases, > > so I just disabled it completely for s390. > > Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > this *will* be disabled if it's not fixed. > > The fact that it might be fixed in linux-next is entirely immaterial > to the release of 4.18. Ok, if gcc with the plugins and an allmodconfig is considered to be important enough to warrant a fix, it can be pulled from here: git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus Martin Schwidefsky (1): s390: disable gcc plugins Once that is in I will create another patch to undo this one and place it after the early boot rework. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Mon, 23 Jul 2018 16:17:22 -0700 Linus Torvalds wrote: > On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > > > > Martin - can we just remove the > > > > > > select HAVE_GCC_PLUGINS > > > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > > disable it). > > > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > > > The problem only affects 4.18 - the code has been rearranged in -next. > > Only, in my builders, I can't disable a flag for individual releases, > > so I just disabled it completely for s390. > > Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > this *will* be disabled if it's not fixed. > > The fact that it might be fixed in linux-next is entirely immaterial > to the release of 4.18. Ok, if gcc with the plugins and an allmodconfig is considered to be important enough to warrant a fix, it can be pulled from here: git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus Martin Schwidefsky (1): s390: disable gcc plugins Once that is in I will create another patch to undo this one and place it after the early boot rework. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > Martin - can we just remove the > > > > select HAVE_GCC_PLUGINS > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > disable it). > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > Martin - can we just remove the > > > > select HAVE_GCC_PLUGINS > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > disable it). > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > My patch is also at > > https://patchwork.ozlabs.org/patch/937283/ Ah, ok, so that just adds the forward-declaration of 'struct page' in the right global namespace. Anyway, I'll just re-order the includes as I suggested, which I think is the right fix and makes the forward-declaration unnecessary (although not _wrong_) Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > My patch is also at > > https://patchwork.ozlabs.org/patch/937283/ Ah, ok, so that just adds the forward-declaration of 'struct page' in the right global namespace. Anyway, I'll just re-order the includes as I suggested, which I think is the right fix and makes the forward-declaration unnecessary (although not _wrong_) Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 01:56:15PM -0700, Linus Torvalds wrote: > Adding davem for the sparc issue, Martin for the s390 one. > > On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > > > The s390 gcc plugins related build error reported previously has not really > > been fixed; after feedback from the s390 maintainers, suggesting that it > > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > > not my preferred solution, but it beats not testing s390:allmodconfig > > builds at all. > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > The problem only affects 4.18 - the code has been rearranged in -next. Only, in my builders, I can't disable a flag for individual releases, so I just disabled it completely for s390. > > The sparc32 build error is still: > > > > In file included from > > ... > > from drivers/staging/media/omap4iss/iss_video.c:15: > > include/linux/highmem.h: In function 'clear_user_highpage': > > include/linux/highmem.h:137:31: error: > > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > > pointer type > > > > due to a missing declaration of 'struct page', as previously reported. > > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > Good idea. > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). > Looks like they dropped lkml completely. Odd. My patch is also at https://patchwork.ozlabs.org/patch/937283/ Also, there is now another patch from Randy Dunlap, pretty much doing the same. https://patchwork.ozlabs.org/patch/947434/ I'll submit separate patches to address the include file ordering; it does make sense to do that. I'll do the same for android/binder.c; it has the same problem, only there it only generates a warning. Thanks, Guenter
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 01:56:15PM -0700, Linus Torvalds wrote: > Adding davem for the sparc issue, Martin for the s390 one. > > On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > > > The s390 gcc plugins related build error reported previously has not really > > been fixed; after feedback from the s390 maintainers, suggesting that it > > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > > not my preferred solution, but it beats not testing s390:allmodconfig > > builds at all. > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > The problem only affects 4.18 - the code has been rearranged in -next. Only, in my builders, I can't disable a flag for individual releases, so I just disabled it completely for s390. > > The sparc32 build error is still: > > > > In file included from > > ... > > from drivers/staging/media/omap4iss/iss_video.c:15: > > include/linux/highmem.h: In function 'clear_user_highpage': > > include/linux/highmem.h:137:31: error: > > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > > pointer type > > > > due to a missing declaration of 'struct page', as previously reported. > > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > Good idea. > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). > Looks like they dropped lkml completely. Odd. My patch is also at https://patchwork.ozlabs.org/patch/937283/ Also, there is now another patch from Randy Dunlap, pretty much doing the same. https://patchwork.ozlabs.org/patch/947434/ I'll submit separate patches to address the include file ordering; it does make sense to do that. I'll do the same for android/binder.c; it has the same problem, only there it only generates a warning. Thanks, Guenter
Re: Linux 4.18-rc6
From: Linus Torvalds Date: Mon, 23 Jul 2018 13:56:15 -0700 > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). I think modifying the include order in that driver is the best fix. BTW, here is a proper patchwork link in the SPARC project on ozlabs: http://patchwork.ozlabs.org/patch/947434/
Re: Linux 4.18-rc6
From: Linus Torvalds Date: Mon, 23 Jul 2018 13:56:15 -0700 > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). I think modifying the include order in that driver is the best fix. BTW, here is a proper patchwork link in the SPARC project on ozlabs: http://patchwork.ozlabs.org/patch/947434/
Re: Linux 4.18-rc6
Adding davem for the sparc issue, Martin for the s390 one. On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > The s390 gcc plugins related build error reported previously has not really > been fixed; after feedback from the s390 maintainers, suggesting that it > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > not my preferred solution, but it beats not testing s390:allmodconfig > builds at all. Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. > The sparc32 build error is still: > > In file included from > ... > from drivers/staging/media/omap4iss/iss_video.c:15: > include/linux/highmem.h: In function 'clear_user_highpage': > include/linux/highmem.h:137:31: error: > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > pointer type > > due to a missing declaration of 'struct page', as previously reported. Hmm. I assume it's arch/sparc/include/asm/cacheflush_32.h that wants a forward-declaration of 'struct page', and doesn't include any header files. The fix is presumably to move the #include in drivers/staging/media/omap4iss/iss_video.c down to below the includes? The old patchwork link you had for a fix no longer works, I think because the patchwork database got re-generated during the upgrade (and the patchwork numbering isn't stable). Davem? Linus
Re: Linux 4.18-rc6
Adding davem for the sparc issue, Martin for the s390 one. On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > The s390 gcc plugins related build error reported previously has not really > been fixed; after feedback from the s390 maintainers, suggesting that it > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > not my preferred solution, but it beats not testing s390:allmodconfig > builds at all. Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. > The sparc32 build error is still: > > In file included from > ... > from drivers/staging/media/omap4iss/iss_video.c:15: > include/linux/highmem.h: In function 'clear_user_highpage': > include/linux/highmem.h:137:31: error: > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > pointer type > > due to a missing declaration of 'struct page', as previously reported. Hmm. I assume it's arch/sparc/include/asm/cacheflush_32.h that wants a forward-declaration of 'struct page', and doesn't include any header files. The fix is presumably to move the #include in drivers/staging/media/omap4iss/iss_video.c down to below the includes? The old patchwork link you had for a fix no longer works, I think because the patchwork database got re-generated during the upgrade (and the patchwork numbering isn't stable). Davem? Linus
Re: Linux 4.18-rc6
On Sun, Jul 22, 2018 at 02:23:39PM -0700, Linus Torvalds wrote: > So this was the week when the other shoe dropped ... The reason the > two previous rc releases were so nice and small was that David hadn't > sent me much networking fixes, and they came in this week. > Build results: total: 134 pass: 133 fail: 1 Failed builds: sparc32:allmodconfig Qemu test results: total: 172 pass: 172 fail: 0 The s390 gcc plugins related build error reported previously has not really been fixed; after feedback from the s390 maintainers, suggesting that it won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is not my preferred solution, but it beats not testing s390:allmodconfig builds at all. The sparc32 build error is still: In file included from ... from drivers/staging/media/omap4iss/iss_video.c:15: include/linux/highmem.h: In function 'clear_user_highpage': include/linux/highmem.h:137:31: error: passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type due to a missing declaration of 'struct page', as previously reported. Guenter
Re: Linux 4.18-rc6
On Sun, Jul 22, 2018 at 02:23:39PM -0700, Linus Torvalds wrote: > So this was the week when the other shoe dropped ... The reason the > two previous rc releases were so nice and small was that David hadn't > sent me much networking fixes, and they came in this week. > Build results: total: 134 pass: 133 fail: 1 Failed builds: sparc32:allmodconfig Qemu test results: total: 172 pass: 172 fail: 0 The s390 gcc plugins related build error reported previously has not really been fixed; after feedback from the s390 maintainers, suggesting that it won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is not my preferred solution, but it beats not testing s390:allmodconfig builds at all. The sparc32 build error is still: In file included from ... from drivers/staging/media/omap4iss/iss_video.c:15: include/linux/highmem.h: In function 'clear_user_highpage': include/linux/highmem.h:137:31: error: passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type due to a missing declaration of 'struct page', as previously reported. Guenter
