Hi Pavel,
Thanks for the review.
On 01/09/2015 06:40 PM, Pavel Machek wrote:
Hi!
The documentation being added contains overall description of the
LED Flash Class and the related sysfs attributes.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Acked-by: Kyungmin Park
Hi Pavel,
Thanks for the review.
On 01/09/2015 07:46 PM, Pavel Machek wrote:
On Fri 2015-01-09 16:22:58, Jacek Anaszewski wrote:
This patch adds led-flash support to Maxim max77693 chipset.
A device can be exposed to user space through LED subsystem
sysfs interface. Device supports up to two
Hi, Guennadi and Laurent
On 1/9/2015 6:47 AM, Laurent Pinchart wrote:
Hi Guennadi and Josh,
On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote:
On Wed, 7 Jan 2015, Josh Wu wrote:
On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote:
On Tue, 6 Jan 2015, Josh Wu wrote:
Hi, Guennadi
On 01/09/2015 07:33 PM, Rob Herring wrote:
On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Add a property for defining the device outputs the LED
represented by the DT child node is connected to.
Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com
Hi Pavel,
Thanks for the review.
On 01/09/2015 09:54 PM, Pavel Machek wrote:
On Fri 2015-01-09 16:23:05, Jacek Anaszewski wrote:
This patch adds helper functions for registering/unregistering
LED Flash class devices as V4L2 sub-devices. The functions should
be called from the LED subsystem
On 01/11/2015 10:33 AM, Raimonds Cicans wrote:
Hello.
I contacted you because I am hit by regression caused by your commit:
453afdd [media] cx23885: convert to vb2
My system:
AMD Athlon(tm) II X2 240e Processor on Asus M5A97 LE R2.0 motherboard
TBS6981 card (Dual DVB-S/S2 PCIe
My first code review of the new year, so let's start with a simple one to avoid
taxing my brain cells (that are still in vacation mode) too much...
On 12/18/2014 05:20 PM, Shuah Khan wrote:
There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap()
vidioc_try_fmt_vid_cap(), and
Hi Shuah,
Looks good! I do have a few small comments, see below.
On 12/18/2014 05:20 PM, Shuah Khan wrote:
Convert au0828 to use videobuf2. Tested with NTSC.
Tested video and vbi devices with xawtv, tvtime,
and vlc. Ran v4l2-compliance to ensure there are
no new regressions in video and vbi
On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
On 01/09/2015 07:33 PM, Rob Herring wrote:
On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Add a property for defining the device outputs the LED
represented by the DT child
Hi!
+* the state of V4L2_CID_FLASH_INDICATOR_INTENSITY control only.
+* Therefore it must be possible to set it to 0 level which in
+* the LED subsystem reflects LED_OFF state.
+*/
+ if (cdata_id != INDICATOR_INTENSITY)
+ ++__intensity;
And normally we'd do
On 12/22/2014 05:00 PM, Philipp Zabel wrote:
The encoder needs to know the nominal framerate for the constant bitrate
control mechanism to work. Currently the only way to set the framerate is
by using VIDIOC_S_PARM on the output queue.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Hi!
+struct max77693_sub_led {
+ /* related FLED output identifier */
-flash LED, about 4x.
+/* split composite current @i into two @iout according to @imax weights */
+static void __max77693_calc_iout(u32 iout[2], u32 i, u32 imax[2])
+{
+ u64 t = i;
+
+ t *= imax[1];
+
On 01/12/2015 02:25 PM, Pavel Machek wrote:
Hi!
+struct max77693_sub_led {
+ /* related FLED output identifier */
-flash LED, about 4x.
+/* split composite current @i into two @iout according to @imax weights */
+static void __max77693_calc_iout(u32 iout[2], u32 i, u32 imax[2])
+{
+
Hi Jean-Marc,
On 01/09/2015 05:38 PM, Jean-Marc VOLLE wrote:
Hello Hans!
Best wishes!
You too.
In reply to the below mail (sorry I do not know how to reply to mails I did
not get but only found on the mail archive).
I think (reading the HDMI spec 1.4b) that in fact any of the
On 11/01/15 10:26, Olliver Schinagl wrote:
Hey Adam,
I've merged your changes, but this last patch seems to go against the
old (obsolete) dvbv3 stuff (that gets auto-generated afaik) and fails to
apply.
Look at the result on the various repositories and see what needs to be
changed.
OK, I'll
On 12/18/2014 05:20 PM, Shuah Khan wrote:
Convert au0828 to use videobuf2. Tested with NTSC.
Tested video and vbi devices with xawtv, tvtime,
and vlc. Ran v4l2-compliance to ensure there are
no new regressions in video and vbi now has 3 fewer
failures.
video before:
test VIDIOC_G_FMT:
On 12/18/2014 05:20 PM, Shuah Khan wrote:
au0828 does video and vbi buffer timeout handling to prevent
applications such as tvtime from hanging by ensuring that the
video frames continue to be delivered even when the ITU-656
input isn't receiving any data. This work-around is complex
as it
Hi Jurgen,
On 12/27/2014 10:35 AM, Jurgen Kramer wrote:
I am seeing kernel oopses using recent media_builds on kernel 3.17:
[ 506.969697] BUG: unable to handle kernel NULL pointer dereference at
0058
[ 506.969720] IP: [a03a233a] vb2_thread+0x17a/0x480
[videobuf2_core]
On 12/23/2014 03:32 PM, Kamil Debski wrote:
From: Hans Verkuil hansv...@cisco.com
Add the CEC framework.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil]
[k.deb...@samsung.com: Merged Update author commit by Hans Verkuil]
Hi Thierry,
On 12/19/2014 01:14 PM, Hans Verkuil wrote:
This patch series adds new HDMI 2.0/CEA-861-F defines to hdmi.h and
adds unpacking and logging functions to hdmi.c. It also uses those
in the V4L2 adv7842 driver (and they will be used in other HDMI drivers
once this functionality is
On 12/23/2014 03:32 PM, Kamil Debski wrote:
From: Hans Verkuil hansv...@cisco.com
Add the CEC framework.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil]
[k.deb...@samsung.com: Merged Update author commit by Hans Verkuil]
Hi Josh,
On Monday 12 January 2015 17:14:33 Josh Wu wrote:
On 1/9/2015 6:47 AM, Laurent Pinchart wrote:
On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote:
On Wed, 7 Jan 2015, Josh Wu wrote:
On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote:
On Tue, 6 Jan 2015, Josh Wu
Hi Kukjin,
On Wednesday, January 07, 2015 6:09 PM, Jacek Anaszewski wrote,
Hi Tony,
On 01/07/2015 01:08 PM, Tony K Nadackal wrote:
Dear Jacek,
On Wednesday, January 07, 2015 3:15 PM Jacek Anaszewski wrote,
Hi Tony,
Sorry for late response, just got back from vacation.
On
On 12/29/2014 03:38 PM, Jurgen Kramer wrote:
On Sat, 2014-12-27 at 10:35 +0100, Jurgen Kramer wrote:
I am seeing kernel oopses using recent media_builds on kernel 3.17:
[ 506.969697] BUG: unable to handle kernel NULL pointer dereference at
0058
[ 506.969720] IP:
On 01/12/2015 04:35 PM, Philipp Zabel wrote:
Hi Hans,
thank you for the comments!
Am Montag, den 12.01.2015, 16:03 +0100 schrieb Hans Verkuil:
On 12/22/2014 05:00 PM, Philipp Zabel wrote:
The encoder needs to know the nominal framerate for the constant bitrate
control mechanism to work.
Hi Hans,
thank you for the comments!
Am Montag, den 12.01.2015, 16:03 +0100 schrieb Hans Verkuil:
On 12/22/2014 05:00 PM, Philipp Zabel wrote:
The encoder needs to know the nominal framerate for the constant bitrate
control mechanism to work. Currently the only way to set the framerate is
My USB dongle is recognized by the system but I have a problem with
the channels. Please read all my post for any help ;-)
At first, I used this guide:
http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers
After that dmesg showed that system was searching
On 12/29/2014 02:33 PM, Ondrej Zary wrote:
Hello,
I'm working on an old driver called qcamvc for Connectix QuickCam VC
webcams
(parallel port and USB models), found here:
http://sourceforge.net/projects/usb-quickcam-vc/
Luckily, it was modified last year to compile with 3.x kernels.
On 12.01.2015 12:55, Hans Verkuil wrote:
On 01/11/2015 10:33 AM, Raimonds Cicans wrote:
After upgrade from kernel 3.13.10 (do not have commit) to 3.17.7
(have commit) I started receiving following IOMMU related messages:
This makes no sense. The cx23885 driver in 3.17.7 doesn't use vb2.
Are
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 8e040cf..c94c6a3 100644
--- a/drivers/media/tuners/r820t.c
+++
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index c94c6a3..b4c85ba 100644
--- a/drivers/media/tuners/r820t.c
+++
Dear DVB-experts,
since recently I own a DVBSky S960CI incorporating a m88ds3103. I am on 3.18.2
with two patches from 3.19 in (the S960 CI support + the dvb-usb-dvbsky: fix
i2c adapter for sp2 device commit), using firmware 3.B for the m88ds3103.
My card is connected to a Quad LNB, to which
My USB dongle is recognized by the system but I have a problem with
the channels. Please read all my post for any help ;-)
At first, I used this guide:
http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers
After that dmesg showed that system was searching
On 01/12/2015 06:58 AM, Hans Verkuil wrote:
My first code review of the new year, so let's start with a simple one to
avoid
taxing my brain cells (that are still in vacation mode) too much...
On 12/18/2014 05:20 PM, Shuah Khan wrote:
There is no need to zero out fmt.pix.priv in
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Jan 13 04:00:14 CET 2015
git branch: test
git hash: 99f3cd52aee21091ce62442285a68873e3be833f
gcc
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88473/mn88473.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index
On 01/12/2015 07:19 AM, Hans Verkuil wrote:
On 12/18/2014 05:20 PM, Shuah Khan wrote:
Convert au0828 to use videobuf2. Tested with NTSC.
Tested video and vbi devices with xawtv, tvtime,
and vlc. Ran v4l2-compliance to ensure there are
no new regressions in video and vbi now has 3 fewer
Add xtal as a configuration parameter so it can be used
in the IF register value calculation. If not set in the
configuration then use a default value.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/dvb-frontends/mn88473.h| 6 ++
On 01/12/2015 07:10 AM, Hans Verkuil wrote:
On 12/18/2014 05:20 PM, Shuah Khan wrote:
au0828 does video and vbi buffer timeout handling to prevent
applications such as tvtime from hanging by ensuring that the
video frames continue to be delivered even when the ITU-656
input isn't receiving
au0828 picked up UNSET from videobuf-core.h and fails to compile
if videobuf-core.h isn't included. Change it to use -1U instead
to fix the problem.
drivers/media/usb/au0828/au0828-cards.c:47:17: error: ‘UNSET’ undeclared
here (not in a function)
.tuner_type = UNSET,
Signed-off-by:
Convert au0828 to use videobuf2. Tested with NTSC.
Tested video and vbi devices with xawtv, tvtime,
and vlc. Ran v4l2-compliance to ensure there are
no regressions. video now has no failures and vbi
has 3 fewer failures.
video before:
test VIDIOC_G_FMT: FAIL 3 failures
Total: 72, Succeeded: 69,
This patch series includes patch v3 of the au0828 vb2 conversion,
removing video and vbi buffer timeout handling, and a patch to
fix compile error from au0828_boards initialization which uses a
a define from videobuf-core.h which is no longer included with the
vb2 conversion change.
The following
au0828 does video and vbi buffer timeout handling to prevent
applications such as tvtime from hanging by ensuring that the
video frames continue to be delivered even when the ITU-656
input isn't receiving any data. This work-around is complex
as it introduces set and clear timer code paths in
Hi Shuah,
On Mon, Jan 12, 2015 at 9:56 PM, Shuah Khan shua...@osg.samsung.com wrote:
au0828 does video and vbi buffer timeout handling to prevent
applications such as tvtime from hanging by ensuring that the
video frames continue to be delivered even when the ITU-656
input isn't receiving any
On 01/12/2015 02:52 PM, Rob Herring wrote:
On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
On 01/09/2015 07:33 PM, Rob Herring wrote:
On Fri, Jan 9, 2015 at 9:22 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
Add a property for defining the device
Building with the attached random configuration file,
drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x124915): undefined reference to `input_allocate_device'
drivers/built-in.o: In function `gspca_dev_probe2':
(.text+0x1249c1): undefined reference to `input_register_device'
Hi Hans,
On Mon, 2015-01-12 at 16:29 +0100, Hans Verkuil wrote:
On 12/29/2014 03:38 PM, Jurgen Kramer wrote:
On Sat, 2014-12-27 at 10:35 +0100, Jurgen Kramer wrote:
I am seeing kernel oopses using recent media_builds on kernel 3.17:
[ 506.969697] BUG: unable to handle kernel NULL
Adding Mark B and Liam...
On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
On 01/12/2015 02:52 PM, Rob Herring wrote:
On Mon, Jan 12, 2015 at 2:32 AM, Jacek Anaszewski
j.anaszew...@samsung.com wrote:
On 01/09/2015 07:33 PM, Rob Herring wrote:
On Fri, Jan 9,
On Mon, Jan 12, 2015 at 10:55:29AM -0600, Rob Herring wrote:
On Mon, Jan 12, 2015 at 10:10 AM, Jacek Anaszewski
There are however devices that don't fall into this category, i.e. they
have many outputs, that can be connected to a single LED or to many LEDs
and the driver has to know what
49 matches
Mail list logo
