The v4l2_m2m_fop_mmap function takes the core mutex, but this will result in a
potential
circular locking dependency:
[ 262.517164] ==
[ 262.517166] [ INFO: possible circular locking dependency detected ]
[ 262.517169] 4.2.0-rc2-koryphon
On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
+ ret = media_entity_setup_link(link, flags);
+ if (ret) {
+ dev_err(mctl-media_dev-dev,
+ Couldn't change tuner link,
+ %s-%s to %s.
In the absence of reduced blanking v2, the clock granularity is not
sufficient enough to allow pixel clock reduction done by factor of
1000 / 1001 in case of reduced fps.
Cc: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Prashant Laddha prlad...@cisco.com
---
The bt pointer was never used, remove it.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 4e8811c..9447d88 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1316,7 +1316,6 @@ static
Hi Hans,
2015-07-20 10:58 GMT+03:00 Hans Verkuil hverk...@xs4all.nl:
Since vb2_fop_mmap doesn't take the lock, neither should v4l2_m2m_fop_mmap.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
[snip]
Tested-by: Mikhail Ulyanov mikhail.ulya...@cogentembedded.com
--
W.B.R, Mikhail.
--
To
Sorry for this nit-pick and some time after you sent this patch. It's
not a redo the patch complaint, it's something that could be fixed
later.
On Tue, Jul 14, 2015 at 06:34:05PM -0600, Shuah Khan wrote:
@@ -131,10 +132,12 @@ static void au0828_unregister_media_device(struct
au0828_dev *dev)
On Mon, 20 Jul 2015 10:47:46 +0200,
Dan Carpenter wrote:
On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
+ ret = media_entity_setup_link(link, flags);
+ if (ret) {
+ dev_err(mctl-media_dev-dev,
+ Couldn't change
On 07/19/2015 04:40 PM, Mikhail Ulyanov wrote:
Hi Hans,
I've made some changes to driver(mostly minor, like sequence v4l2_buf
field filling and so on)to make it pass v4l2-compliance -s test(MMAP
part), but suddenly get stuck with USERPTR part. First there is WARN
about zero bytesused.
I
From: Hans Verkuil hans.verk...@cisco.com
Convert this driver to the control framework and struct v4l2_fh
(needed for handling control events).
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 69 ++-
From: Hans Verkuil hans.verk...@cisco.com
This patch series converts the usbvision driver to the control framework.
It also fixes a bunch of other bugs, making it a bit more v4l2-compliance
friendly.
This driver still needs a lot of work to make it pass v4l2-compliance, but
this is a start.
From: Philipp Zabel p.za...@pengutronix.de
The chroma interleaved NV12 format has higher memory bandwidth efficiency
because the chroma planes can be read/written with longer burst lengths.
Use NV12 as default format if available and consistently sort it first.
Signed-off-by: Philipp Zabel
From: Hans Verkuil hans.verk...@cisco.com
- Fix an off-by-one index check in vidioc_enum_fmt()
- Fill in the pix.sizeimage field in vidioc_try_fmt_cap()
- Fix an off-by-one index check in vidioc_s_input()
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c |
From: Hans Verkuil hans.verk...@cisco.com
Convert the driver to use v4l2_fh in order to support control events.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
The names of the pixelformats is set by the core. So there no longer
is any need for drivers to fill it in.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c | 9 ++---
1 file changed, 2 insertions(+), 7
From: Hans Verkuil hans.verk...@cisco.com
- fill in the missing colorspace value.
- don't reject incorrect field values, always replace with a valid value.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c | 14 +++---
1 file changed, 3
From: Hans Verkuil hans.verk...@cisco.com
The bus_info field was never filled.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c
index
Hi,
I'm very new to video input devices.
I have a new project where I need to get a SDI video stream to a CPU via a FPGA.
I'll use a Xilinx device and Xilinx video IP cores. This is what I (think) need:
++ +-+
++
|
On Mon, Jul 20, 2015 at 2:00 AM, Tony Chang(Wincomm)
to...@wincomm.com.tw wrote:
Dear : Steven
Sorry for my poor english !! I don’t know how to install it
According your feedback..
diff --git a/drivers/media/pci/cx23885/Kconfig
b/drivers/media/pci/cx23885/Kconfigindex 2e1b88c..3e6398f
From: Hans Verkuil hans.verk...@cisco.com
Don't return -1, return a proper error code.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
The radio device node had the same caps as the video node. Fix this.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff
From: Hans Verkuil hans.verk...@cisco.com
This causes lots of problems and is *very* slow as well.
One of the main problems is that this prohibits the use of the control
framework since subdevs will be unloaded on power off which is not allowed
as long as they are used by a usb device.
From: Hans Verkuil hans.verk...@cisco.com
These things are only initialized if you start streaming video, but
they are also used in the disconnect function. So just init them
always during probe time.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
The g/s_audio ioctls didn't do anything, so remove them all for both
video and radio nodes and remove V4L2_CAP_AUDIO.
The enum/g/s_input ioctls are invalid for radio nodes, so remove them
from the radio ioctl_ops.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
In various places the stack was used to provide buffers for USB data, but
this should be allocated memory.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-core.c | 18 ++
From: Hans Verkuil hans.verk...@cisco.com
If remove_pending is non-zero, then the v4l2_lock is never unlocked.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Set the colorspace and field in vidioc_try_fmt_vid_cap().
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
- setup initial radio and tv frequencies.
- set/get the correct frequency (radio vs tv).
- disable tuner/freq ioctls if there is no tuner.
- fix some tuner index checks.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
From: Hans Verkuil hans.verk...@cisco.com
The standards supported by S-Video and Composite inputs are not
limited by PAL, so make it more generic.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/usbvision/usbvision-video.c | 6 +++---
1 file changed, 3 insertions(+), 3
From: Hans Verkuil hans.verk...@cisco.com
Interestingly enough, the existing control handling code basically did
nothing. At least the new code will inherit the controls from the
saa7115 driver.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/fsl-viu.c | 110
From: Hans Verkuil hans.verk...@cisco.com
Convert this driver to the control framework and do a few more fixes to
make v4l2-compliance happy.
Most of these patches have been posted before over two years ago but I never
made a pull request for it.
This is the original patch series:
On Sun, Jul 19, 2015 at 3:34 AM, Tycho Lürsen tycholur...@gmail.com wrote:
Hi Steven,
Tested your si2186 patch with my DVBSky T982 and TBS 6285 cards using
European DVB-C
Since MythTV can't handle multistandard frontends (yet), I've disabled
DVB-T/T2 like this (I always do that):
sed -i
From: Hans Verkuil hans.verk...@cisco.com
Use the standard core lock to take care of serializing ioctl calls and
to serialize file operations.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/zoran/zoran.h| 3 +-
drivers/media/pci/zoran/zoran_card.c | 6 +-
From: Hans Verkuil hans.verk...@cisco.com
The zoran driver has now been converted to the control framework
which means that these three subdevice drivers no longer need to
support the legacy core control ops since the last bridge driver
that needed that has now been converted.
Signed-off-by:
From: Hans Verkuil hans.verk...@cisco.com
Switch this driver to the control framework and to v4l2_fh for
handling control events.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/zoran/zoran.h| 4 ++
drivers/media/pci/zoran/zoran_card.c | 5 +++
From: Hans Verkuil hans.verk...@cisco.com
There is no need to zero the v4l2_capability struct, the v4l2 core has done
that already.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/zoran/zoran_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
The zoran_read/write functions always return an error. Just remove them.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/zoran/zoran_driver.c | 25 -
1 file changed, 25 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
Convert the zoran driver to the control framework. As a result of that
it is now also possible to drop the legacy control ops from three
subdev drivers that were only used by the zoran driver.
Regards,
Hans
Hans Verkuil (5):
zoran: remove
On 07/20/2015 03:00 AM, Takashi Iwai wrote:
On Mon, 20 Jul 2015 10:47:46 +0200,
Dan Carpenter wrote:
On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
+ ret = media_entity_setup_link(link, flags);
+ if (ret) {
+ dev_err(mctl-media_dev-dev,
+
On 07/19/2015 01:21 AM, Steven Toth wrote:
http://git.linuxtv.org/cgit.cgi/stoth/hvr1275.git/log/?h=hvr-1275
Patches above are available for test.
Antti, note the change to SI2168 to add support for enabling and
disabling the SI2168 transport bus dynamically.
I've tested with a combo card,
On 07/20/2015 03:52 PM, Ricardo Ribalda Delgado wrote:
Hello
I have no preference over the two implementations, but I see an issue
with this suggestion.
What happens to out out tree drivers, or drivers that don't support
this functionality?
With the ioctl, the user receives a
On 06/12/2015 06:46 PM, Ricardo Ribalda Delgado wrote:
This ioctl returns the default value of one or more extended controls.
It has the same interface as VIDIOC_EXT_CTRLS.
It is needed due to the fact that QUERYCTRL was not enough to
provide the initial value of pointer type controls.
This
Hello
I have no preference over the two implementations, but I see an issue
with this suggestion.
What happens to out out tree drivers, or drivers that don't support
this functionality?
With the ioctl, the user receives a -ENOTTY. So he knows there is
something wrong with the driver.
With
On Mon, Jul 20, 2015 at 10:30 AM, Antti Palosaari cr...@iki.fi wrote:
On 07/19/2015 01:21 AM, Steven Toth wrote:
http://git.linuxtv.org/cgit.cgi/stoth/hvr1275.git/log/?h=hvr-1275
Patches above are available for test.
Antti, note the change to SI2168 to add support for enabling and
We can agree or disagree about whether a part should be tri-stated in
init/sleep() and under what circumstances, but why bother when someone
has gone to the trouble of declaring a perfectly good tr-state
interface in dvb-core, taht automatically asserts and de-asserts any
dvb_frontend device
Hi Steven,
I was not aware of the fact that your patch depends on dvb-core as in
4.2-RC2 (and up, I guess)
I tested against 3.18.18 and 4.1.2. That might explain the failures.
Anyhow, as soon as Antti and you are on the same page regarding this
patch, I'll test again against a 4.2-RC1
This commits moves the Intersil/Techwell PCI vendor ID, and
the device IDs for the TW68 PCI video capture cards.
This will allow to support future Intersil/Techwell devices
without duplicating the IDs.
Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar
---
On Mon, Jul 20, 2015 at 09:55:50AM -0600, Shuah Khan wrote:
#ifdef CONFIG_MEDIA_CONTROLLER
- if (dev-media_dev) {
- media_device_unregister(dev-media_dev);
- kfree(dev-media_dev);
- dev-media_dev = NULL;
+ if (dev-media_dev
+
On Jul 17, 2015, at 5:07 PM, Luis R. Rodriguez mcg...@do-not-panic.com
wrote:
From: Luis R. Rodriguez mcg...@suse.com
WARN() may confuse users, fix that. ipath_init_one() is part the
device's probe so this would only be triggered if a corresponding
device was found.
Signed-off-by:
On 07/20/2015 08:14 PM, Steven Toth wrote:
On Mon, Jul 20, 2015 at 12:54 PM, Antti Palosaari cr...@iki.fi wrote:
On 07/20/2015 07:45 PM, Devin Heitmueller wrote:
Look at the em28xx driver and you will probably see why it does not work
as
expected. For my eyes, according to em28xx driver, it
On 07/20/2015 06:00 PM, Steven Toth wrote:
On Mon, Jul 20, 2015 at 10:30 AM, Antti Palosaari cr...@iki.fi wrote:
On 07/19/2015 01:21 AM, Steven Toth wrote:
http://git.linuxtv.org/cgit.cgi/stoth/hvr1275.git/log/?h=hvr-1275
Patches above are available for test.
Antti, note the change to
Look at the em28xx driver and you will probably see why it does not work as
expected. For my eyes, according to em28xx driver, it looks like that bus
control is aimed for bridge driver. You or em28xx is wrong.
Neither are wrong. In some cases the call needs to be intercepted by
the frontend
On 07/20/2015 02:42 AM, Dan Carpenter wrote:
Sorry for this nit-pick and some time after you sent this patch. It's
not a redo the patch complaint, it's something that could be fixed
later.
On Tue, Jul 14, 2015 at 06:34:05PM -0600, Shuah Khan wrote:
@@ -131,10 +132,12 @@ static void
On 07/20/2015 01:01 PM, Dan Carpenter wrote:
On Mon, Jul 20, 2015 at 09:55:50AM -0600, Shuah Khan wrote:
#ifdef CONFIG_MEDIA_CONTROLLER
- if (dev-media_dev) {
- media_device_unregister(dev-media_dev);
- kfree(dev-media_dev);
- dev-media_dev = NULL;
+ if
This reverts commit a0466f15b4654cf1ac9e387d7c1a401eff494b4f.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
This reverts commit cf257e288ad3a134d4bb809c542a3ae6c87ddfa3.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
This reverts commit 0d830b2d1295fee82546d57185da5a6604f11ae2.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
This reverts commit da7ee60b03bd66bb10974d7444aa444de6391312.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
The issues were discussed in this thread:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg86998.html
And
This reverts commit 2e4ebde269236da2a41183522127715b6d9d80ce.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
This reverts commit 1d971d927efa2e10194c96ed0475b6d6054342d8.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
This reverts commit 9869da5bacc5c9b865a183bd36c04be76cdd325d.
The current code is not mature enough, the API should allow a single
protocol to be specified. Also, the current code contains heuristics
that will depend on module load order.
Signed-off-by: David Härdeman da...@hardeman.nu
---
On Mon, Jul 20, 2015 at 12:06 PM, Tycho Lürsen tycholur...@gmail.com wrote:
Hi Steven,
I was not aware of the fact that your patch depends on dvb-core as in
4.2-RC2 (and up, I guess)
I tested against 3.18.18 and 4.1.2. That might explain the failures.
Anyhow, as soon as Antti and you are on
On 07/20/2015 07:45 PM, Devin Heitmueller wrote:
Look at the em28xx driver and you will probably see why it does not work as
expected. For my eyes, according to em28xx driver, it looks like that bus
control is aimed for bridge driver. You or em28xx is wrong.
Neither are wrong. In some cases
On Mon, Jul 20, 2015 at 12:54 PM, Antti Palosaari cr...@iki.fi wrote:
On 07/20/2015 07:45 PM, Devin Heitmueller wrote:
Look at the em28xx driver and you will probably see why it does not work
as
expected. For my eyes, according to em28xx driver, it looks like that bus
control is aimed for
Here's the driver for the Renesas R-Car JPEG processing unit.
The driver is implemented within the V4L2 framework as a memory-to-memory
device. It presents two video nodes to userspace, one for the encoding part,
and one for the decoding part.
It was found that the only working mode for
Add Renesas R-Car JPEG processing unit driver device tree bindings
documentation.
Signed-off-by: Mikhail Ulyanov mikhail.ulya...@cogentembedded.com
---
Changes since v2:
- remove generic renesas,jpu-gen2 descriptor
Changes since v1:
- Fix typos
.../devicetree/bindings/media/renesas,jpu.txt
This series of patches contains a driver for the JPEG codec integrated
peripheral found in the Renesas R-Car SoCs and associated DT documentation.
This series of patches is against the 'master' branch of
linuxtv.org/media_tree.git
v4l2-compliance -s
Driver Info:
Driver name : rcar_jpu
Update RENESAS JPU driver maintainer in MAINTAINERS file.
Signed-off-by: Mikhail Ulyanov mikhail.ulya...@cogentembedded.com
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b65b22b..da57ec1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@
tree: git://git.infradead.org/users/ezequielg/linux tw68_ids_upstream_v2
head: 182300e6004285b7cbc26d76bf2fffe3b3bed212
commit: 2f8e75d2762496bb2fcea7fa437a3339d2a6d9d4 [82/109] [media]
adv7604/cobalt: Allow compile test if !GPIOLIB
config: x86_64-randconfig-n0-07210714 (attached as .config)
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Jul 21 04:00:21 CEST 2015
git branch: test
git hash: 6727d4fce95586e60922bdaf57b8a0eb99482557
gcc
70 matches
Mail list logo
