cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 9 05:00:14 CEST 2017 media-tree git hash:079c6eaf80d9fb6d9cea7ad71e590c8425c1b0fe media_build

[PATCH v1 2/2] media: v4l2-core: Update V4L2 framework with new fourcc codes

New fourcc codes have been added to support additional video memory layout supported by Xilinx Video IP. These have been added to the V4L2 framework with this patch. Signed-off-by: Jeffrey Mouroux --- drivers/media/v4l2-core/v4l2-ioctl.c | 9 + 1 file changed, 9

[PATCH v1 0/2] New fourcc codes needed by Video DMA Driver

This patch set is introduced to support a driver we are developing for our new Video Framebuffer DMA IP, a DMA device that is "video format aware". Clients need only specify memory layout information for a single plane (i.e. luma) and then provide a video format code (e.g. YUV420) which will

[PATCH v1 1/2] uapi: media: New fourcc codes needed by Xilinx Video IP

The Xilinx Video Mixer andn Xilinx Video Framebuffer DMA IP support video memory formats that are not represented in the current V4L2 fourcc library. This patch adds those missing fourcc codes. Signed-off-by: Jeffrey Mouroux --- include/uapi/linux/videodev2.h | 9 +

Re: [PATCH 1/6] [media] v4l: mt9t001: constify video_subdev structures

Hi Julia, Thank you for the patch. On Tuesday 08 Aug 2017 12:58:27 Julia Lawall wrote: > The v4l2_subdev_ops structure is only passed as the third argument of > v4l2_i2c_subdev_init, which is const, so the v4l2_subdev_ops structure > can be const as well. The other structures are only stored in

[PATCH] [media_build] Fixup api_version.patch after version field removals

From: Daniel Scheller Fixes prepatching wrt commit 2bd8682375f3 ("media: media-device: remove driver_version" and commit 71269bf607bc ("media: uvc: don't set driver_version") Signed-off-by: Daniel Scheller --- backports/api_version.patch | 35

Re: [PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

On Tue, Aug 08, 2017 at 04:29:57PM +0300, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev

[GIT PULL FOR v4.14] v2: Add meson-ao-cec driver

Changes since v1: added MAINTAINERS patch. Regards, Hans The following changes since commit 079c6eaf80d9fb6d9cea7ad71e590c8425c1b0fe: media: v4l2-tpg: fix the SMPTE-2084 transfer function (2017-08-08 07:05:09 -0400) are available in the git repository at:

media: mtk-mdp: use IS_ERR to check return value of of_clk_get

Function of_clk_get() returns an ERR_PTR on failures. In file mtk_mdp_commp.c, its return value is checked against NULL. Such checks cannot prevent from accessing bad memory. This patch replaces the NULL checks with IS_ERR checks. Signed-off-by: Pan Bian ---

Re: [PATCH v4 09/21] media: camss: Add files which handle the video device nodes

Hi Todor, On Tue, Aug 08, 2017 at 04:30:06PM +0300, Todor Tomov wrote: ... > +static int video_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct camss_video *video = vb2_get_drv_priv(q); > + struct video_device *vdev = >vdev; > + struct media_entity *entity; > +

Re: [PATCH] MAINTAINERS: add entry for meson ao cec driver

Le 08/08/2017 16:18, Hans Verkuil a écrit : > Add entry to the MAINTAINERS file for the meson ao cec driver. > > Signed-off-by: Hans Verkuil > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index 9826a918d37a..ed568e1ac856 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS >

[PATCH] MAINTAINERS: add entry for meson ao cec driver

Add entry to the MAINTAINERS file for the meson ao cec driver. Signed-off-by: Hans Verkuil --- diff --git a/MAINTAINERS b/MAINTAINERS index 9826a918d37a..ed568e1ac856 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8671,6 +8671,16 @@ F: drivers/leds/leds-menf21bmc.c

[PATCH v4 00/21] Qualcomm 8x16 Camera Subsystem driver

This patchset adds basic support for the Qualcomm Camera Subsystem found on Qualcomm MSM8916 and APQ8016 processors. The driver implements V4L2, Media controller and V4L2 subdev interfaces. Camera sensor using V4L2 subdev interface in the kernel is supported. The driver is implemented using as a

[PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Add a document to describe Qualcomm Camera Subsystem driver. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 124 + 1 file changed, 124 insertions(+) create mode 100644

[PATCH v4 03/21] MAINTAINERS: Add Qualcomm Camera subsystem driver

Add an entry for Qualcomm Camera subsystem driver. Signed-off-by: Todor Tomov --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bdde944..87d0c7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10996,6 +10996,14 @@

[PATCH v4 07/21] media: camss: Add ISPIF files

These files control the ISPIF module which handles the routing of the data streams from the CSIDs to the inputs of the VFE. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-ispif.c | 1164

[PATCH v4 05/21] media: camss: Add CSIPHY files

These files control the CSIPHY modules which are responsible for the physical layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csiphy.c | 823 + .../media/platform/qcom/camss-8x16/camss-csiphy.h |

[PATCH v4 06/21] media: camss: Add CSID files

These files control the CSID modules which handle the protocol and application layer of the CSI2 receivers. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-csid.c| 1003 .../media/platform/qcom/camss-8x16/camss-csid.h|

[PATCH v4 01/21] v4l: Add packed Bayer raw12 pixel formats

From: Sakari Ailus These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit variants. The formats added by this patch are V4L2_PIX_FMT_SBGGR12P V4L2_PIX_FMT_SGBRG12P

[PATCH v4 02/21] dt-bindings: media: Binding document for Qualcomm Camera subsystem driver

Add DT binding document for Qualcomm Camera subsystem driver. CC: Rob Herring CC: devicet...@vger.kernel.org Signed-off-by: Todor Tomov Acked-by: Rob Herring --- .../devicetree/bindings/media/qcom,camss.txt | 197

[PATCH v4 08/21] media: camss: Add VFE files

These files control the VFE module. The VFE has different input interfaces. The PIX input interface feeds the input data to an image processing pipeline. Three RDI input interfaces bypass the image processing pipeline. The VFE also contains the AXI bus interface which writes the output data to

[PATCH v4 10/21] media: camms: Add core files

These files implement the platform driver code. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss.c | 699 + drivers/media/platform/qcom/camss-8x16/camss.h | 97 2 files changed, 796 insertions(+) create mode

[PATCH v4 09/21] media: camss: Add files which handle the video device nodes

These files handle the video device nodes of the camss driver. Signed-off-by: Todor Tomov --- .../media/platform/qcom/camss-8x16/camss-video.c | 681 + .../media/platform/qcom/camss-8x16/camss-video.h | 64 ++ 2 files changed, 745 insertions(+)

[PATCH v4 13/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - PIX Interface

Update Qualcomm Camera Subsystem driver document for the PIX interface and format conversion support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 46 -- 1 file changed, 36 insertions(+), 10 deletions(-) diff

[PATCH v4 12/21] camss: vfe: Format conversion support using PIX interface

Use VFE PIX input interface and do format conversion in VFE. Supported input format is UYVY (single plane YUV 4:2:2) and its different sample order variations. Supported output formats are: - NV12/NV21 (two plane YUV 4:2:0) - NV16/NV61 (two plane YUV 4:2:2) Signed-off-by: Todor Tomov

[PATCH v4 11/21] media: camss: Enable building

Add Makefile and update platform/Kconfig and platform/Makefile to enable building of the QCom CAMSS driver. Signed-off-by: Todor Tomov --- drivers/media/platform/Kconfig | 7 +++ drivers/media/platform/Makefile | 2 ++

[PATCH v4 15/21] camss: vfe: Add interface for scaling

Add compose selection ioctls to handle scaling configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 184 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 183 insertions(+), 2

[PATCH v4 14/21] camss: vfe: Support for frame padding

Add support for horizontal and vertical frame padding. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 85 +- .../media/platform/qcom/camss-8x16/camss-video.c | 53 ++

[PATCH v4 17/21] camss: vfe: Add interface for cropping

Extend selection ioctls to handle cropping configuration. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 191 - drivers/media/platform/qcom/camss-8x16/camss-vfe.h | 1 + 2 files changed, 150 insertions(+), 42

[PATCH v4 16/21] camss: vfe: Configure scaler module in VFE

Add scaler module configuration support to be able to apply scaling. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 59 +- 1 file changed, 46 insertions(+), 13 deletions(-) diff --git

[PATCH v4 19/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Scale and crop

Update the Qualcomm Camera Subsystem driver document for VFE scale and crop modules support. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v4 18/21] camss: vfe: Configure crop module in VFE

Add crop module configuration support to be able to apply cropping. Signed-off-by: Todor Tomov --- drivers/media/platform/qcom/camss-8x16/camss-vfe.c | 41 +- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git

[PATCH v4 21/21] doc: media/v4l-drivers: Qualcomm Camera Subsystem - Media graph

Update the Qualcomm Camera Subsystem driver document with a media controller pipeline graph diagram. Signed-off-by: Todor Tomov --- Documentation/media/v4l-drivers/qcom_camss.rst | 27 ++ .../media/v4l-drivers/qcom_camss_graph.dot | 41

[PATCH v4 20/21] camss: Use optimal clock frequency rates

Use standard V4L2 control to get pixel clock rate from a sensor linked in the media controller pipeline. Then calculate clock rates on CSIPHY, CSID and VFE to use the lowest possible. If the currnet pixel clock rate of the sensor cannot be read then use the highest possible. This case covers also

Re: [PATCH v1 2/2] [media] ov9655: fix missing mutex_destroy()

On Fri, Jul 21, 2017 at 05:49:41PM +0200, Hugues Fruchet wrote: > Fix missing mutex_destroy() when probe fails and > when driver is removed. > > Signed-off-by: Hugues Fruchet Thanks, applied both, with the subject changed to reflect the driver file name (ov9550.c). --

Re: [PATCH] media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space

On Wed, Aug 02, 2017 at 01:11:06AM -0700, Joe Perches wrote: > On Wed, 2017-08-02 at 18:00 +1000, Sergei A. Trusov wrote: > > The calloc function returns either a null pointer or a pointer to the > > allocated space. Add the second case that is missed. > > gads. > > Bug added by commit

[PATCH 0/5] UVC patches for v4.14

Hi Hans, Here are the patches to the uvcvideo driver that I have queued for v4.14. Guennadi Liakhovetski (2): uvcvideo: Fix .queue_setup() to check the number of planes uvcvideo: Convert from using an atomic variable to a reference count Guenter Roeck (1): uvcvideo: Prevent heap overflow

[PATCH 5/5] uvcvideo: Constify video_subdev structures

From: Julia Lawall uvc_subdev_ops is only passed as the second argument of v4l2_subdev_init, which is const, so uvc_subdev_ops can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Reviewed-by: Laurent Pinchart

[PATCH 4/5] uvcvideo: Convert from using an atomic variable to a reference count

From: Guennadi Liakhovetski When adding support for metadata nodes, we'll have to keep video devices registered until all metadata nodes are closed too. Since this has nothing to do with stream counting, replace the nstreams atomic variable with a reference counter.

[PATCH 2/5] uvcvideo: Prevent heap overflow when accessing mapped controls

From: Guenter Roeck The size of uvc_control_mapping is user controlled leading to a potential heap overflow in the uvc driver. This adds a check to verify the user provided size fits within the bounds of the defined buffer size. Cc: sta...@vger.kernel.org Originally-from:

[PATCH 1/5] uvcvideo: Fix incorrect timeout for Get Request

From: Jim Lin Section 9.2.6.4 of USB 2.0/3.x specification describes that "device must be able to return the first data packet to host within 500 ms of receipt of the request. For subsequent data packet, if any, the device must be able to return them within 500 ms". This is to

[PATCH 3/5] uvcvideo: Fix .queue_setup() to check the number of planes

From: Guennadi Liakhovetski According to documentation of struct vb2_ops the .queue_setup() callback should return an error if the number of planes parameter contains an invalid value on input. Fix this instead of ignoring the value. Signed-off-by: Guennadi Liakhovetski

Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures

On Tue, 8 Aug 2017, Laurent Pinchart wrote: > Hi Julia, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > > uvc_subdev_ops is only passed as the second argument of > > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > > const as well. > > > > Done

Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures

Hi Julia, Thank you for the patch. On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > uvc_subdev_ops is only passed as the second argument of > v4l2_subdev_init, which is const, so uvc_subdev_ops can be > const as well. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall

Re: [PATCH 5/6] [media] exynos4-is: constify video_subdev structures

On 08/08/2017 12:58 PM, Julia Lawall wrote: The v4l2_subdev_ops structures are only passed as the second argument of v4l2_subdev_init, which is const, so the v4l2_subdev_ops structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall

Re: [PATCH] staging: media: atomisp: use kvmalloc/kvzalloc

On Mon, 2017-08-07 at 21:44 +0800, Geliang Tang wrote: > Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc() > /atomisp_kernel_zalloc(). > > Signed-off-by: Geliang Tang Definitely better now we have kvmalloc/kvzalloc. Thanks Alan

Re: [PATCH 1/2] [media] ov7670: Return the real error code

On Tue, Aug 08, 2017 at 08:56:14AM -0300, Fabio Estevam wrote: > Hi Sakari, > > On Tue, Aug 8, 2017 at 8:24 AM, Sakari Ailus wrote: > > > I don't think -EPROBE_DEFER is returned by clk_get() if the clock can't be > > found. The clock providers often are e.g. ISP drivers

Nokia N900 camera support in linux-next

Hi! Most of CSI-1 / N900 camera support is there in linux-next tree: patches marked "n" are in, unmarked patches are only in Sakari's tree. Is there something I can do to help merging patches to linux-next? We are quite close, and it would be nice to have camera support in v4.14... Thanks,

Re: [PATCH 1/2] [media] ov7670: Return the real error code

Hi Sakari, On Tue, Aug 8, 2017 at 8:24 AM, Sakari Ailus wrote: > I don't think -EPROBE_DEFER is returned by clk_get() if the clock can't be > found. The clock providers often are e.g. ISP drivers that may well be Yes, it is. Please check: commit

[PATCH 1/5] media: platform: s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.

From: Tony K Nadackal In case of corrupt images, multiple interrupts may occur due to different error scenarios. Since we are removing the src and dest buffers in the first interrupt itself, crash occurs in the second error interrupts. Disable the global interrupt before

[PATCH 3/5] media: platform: s5p-jpeg: Clear JPEG_CODEC_ON bits in sw reset function

From: Tony K Nadackal Bits EXYNOS4_DEC_MODE and EXYNOS4_ENC_MODE do not get cleared on software reset. These bits need to be cleared explicitly. Even though the bits in question are already cleared in interrupt service routine, the reset should also clear them in case e.g.

[PATCH 2/5] media: platform: s5p-jpeg: disable encoder/decoder in exynos4-like hardware after use

Clearing the bits turns off the encoder/decoder. If the hardware is not turned off after use, at subsequent uses it does not work in a stable manner, resulting in incorrect interrupt status value being read and e.g. erroneous read of compressed bitstream size. Signed-off-by: Andrzej Pietrasiewicz

[PATCH 4/5] media: platform: s5p-jpeg: fix number of components macro

The value to be processed must be first masked and then shifted, not the other way round. Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/5] media: platform: s5p-jpeg: directly use parsed subsampling on 5433

On 5433 variant JPEG data is parsed by hardware only from SOS marker, so subsampling is parsed by software. As such, its value need not be translated from hardware-specific encoding to V4L2 encoding. Signed-off-by: Andrzej Pietrasiewicz ---

[PATCH 1/6] [media] v4l: mt9t001: constify video_subdev structures

The v4l2_subdev_ops structure is only passed as the third argument of v4l2_i2c_subdev_init, which is const, so the v4l2_subdev_ops structure can be const as well. The other structures are only stored in the v4l2_subdev_ops structure, all the fields of which are const, so these structures can also

[PATCH 6/6] [media] uvcvideo: constify video_subdev structures

uvc_subdev_ops is only passed as the second argument of v4l2_subdev_init, which is const, so uvc_subdev_ops can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/media/usb/uvc/uvc_entity.c |2 +- 1 file changed, 1

[PATCH 3/6] staging: atomisp: constify video_subdev structures

These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/staging/media/atomisp/i2c/ap1302.c |2 +-

[PATCH 0/6] constify video_subdev structures

The structures of type v4l2_subdev_ops are only passed as the second argument of v4l2_subdev_init or as the third argument of v4l2_i2c_subdev_init, both of which are const. The structures of type v4l2_subdev_core_ops, v4l2_subdev_pad_ops, v4l2_subdev_sensor_ops, v4l2_subdev_video_ops are only

[PATCH 2/6] [media] vimc: constify video_subdev structures

These structures are all only stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/media/platform/vimc/vimc-debayer.c |2 +-

[PATCH 5/6] [media] exynos4-is: constify video_subdev structures

The v4l2_subdev_ops structures are only passed as the second argument of v4l2_subdev_init, which is const, so the v4l2_subdev_ops structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall ---

[PATCH 4/6] [media] media: mt9m111: constify video_subdev structures

The v4l2_subdev_ops structure is only passed as the third argument of v4l2_i2c_subdev_init, which is const, so the v4l2_subdev_ops structure can be const as well. The other structures are only stored in the v4l2_subdev_ops structure, all the fields of which are const, so these structures can also

Re: [PATCH 1/2] [media] ov7670: Return the real error code

On Wed, Jul 19, 2017 at 12:34:18AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > When devm_clk_get() fails the real error code should be propagated, > instead of always returning -EPROBE_DEFER. > > Signed-off-by: Fabio Estevam Hi Fabio, I

[PATCH 0/5] s5p-jpeg fixes

Hi All, This series contains a number of fixes to the s5p-jpeg driver. There are two patches from Tony K Nadackal, which got lost long time ago. @Thierry: The patch changing the software reset routine you sent recently was actually a resend of Tony's patch. I investigated the question why this

[PATCHv2] v4l2-tpg: fix the SMPTE-2084 transfer function

The SMPTE-2084 transfer functions maps to the luminance range of 0-1 cd/m^2. Other transfer functions use the traditional range of 0-100 cd/m^2. I didn't take this into account so the luminance was off by a factor of 100. Since qv4l2 made the same mistake in reverse I never noticed this

Re: [PATCH 2/5] [media] atomisp: constify videobuf_queue_ops structures

On Fri, Aug 04, 2017 at 02:09:45PM +0200, Julia Lawall wrote: > These videobuf_queue_ops structures are only passed as the second > argument to videobuf_queue_vmalloc_init, which is declared as const. > Thus the videobuf_queue_ops structures themselves can be const. > > Done with the help of

Re: [PATCH v2] media: ov13858: Correct link-frequency and pixel-rate

On Sat, Jul 29, 2017 at 12:00:39AM -0700, Chiranjeevi Rapolu wrote: > Previously both link-frequency and pixel-rate reported by > the sensor was incorrect, resulting in incorrect FPS. > Report link-frequency in Hz rather than link data rate in bps. > Calculate pixel-rate from link-frequency. > >

Re: [GIT PULL FOR v4.14] Add meson-ao-cec driver

Em Fri, 28 Jul 2017 15:05:07 +0200 Hans Verkuil escreveu: > The following changes since commit da48c948c263c9d87dfc64566b3373a858cc8aa2: > > media: fix warning on v4l2_subdev_call() result interpreted as bool > (2017-07-26 13:43:17 -0400) > > are available in the git

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

On Mon, Aug 07, 2017 at 06:26:44PM +0100, Andrey Utkin wrote: > Hi Anton, > Hi > > @@ -90,16 +93,110 @@ static void solo_gpio_config(struct solo_dev *solo_dev) > > > > > /* Initially set relay status to 0 */ > > Do you mean that relay is initially disabled? > Maybe a rewording would

Re: [GIT PULL FOR v4.14] Doc and TGP fixes

Em Fri, 28 Jul 2017 09:38:52 +0200 Hans Verkuil escreveu: > Hi Mauro, > > Here are various documentation fixes/improvements. > > The first patch renames the old pixfmt-0XX.rst files to something I can > understand since I could never find the right rst file for the

Re: [PATCH] v4l2-tpg: fix the SMPTE-2084 transfer function

Em Wed, 26 Jul 2017 20:45:55 +0200 Hans Verkuil escreveu: > The SMPTE-2084 transfer functions maps to the luminance range of 0-1 > cd/m^2. > Other transfer functions use the traditional range of 0-100 cd/m^2. > > I didn't take this into account so the luminance was off

Re: [PATCH 2/2] cec: fix remote control passthrough

On 07/08/17 22:58, Sean Young wrote: > On Mon, Aug 07, 2017 at 03:31:24PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The 'Press and Hold' operation was not correctly implemented, in >> particular the requirement that the repeat doesn't start until >> the second