cron job: media_tree daily build: ERRORS

2018-03-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 3 05:00:11 CET 2018 media-tree git hash:e3e389f931a14ddf43089c7db92fc5d74edf93a4 media_build

Re: [PATCH 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

2018-03-02 Thread Steve Longerbeam
On 03/02/2018 11:14 AM, Fabio Estevam wrote: From: Fabio Estevam Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error.

Re: [v5 2/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-03-02 Thread Sakari Ailus
On Fri, Mar 02, 2018 at 12:59:00PM -0600, Rob Herring wrote: > On Wed, Feb 28, 2018 at 03:31:26PM +0200, Sakari Ailus wrote: > > Hi Rob, > > > > Thanks for the review. > > > > On Tue, Feb 27, 2018 at 04:10:31PM -0600, Rob Herring wrote: > > > On Fri, Feb 23, 2018 at 10:13 AM, Andy Yeh

[PATCH 4/8] media: em28xx: constify most static structs

2018-03-02 Thread Mauro Carvalho Chehab
There are several em28xx static structs that can now be constified. That caused a significant reduction at data segment: Before: textdata bss dec hex filename 85017 59588 576 145181 2371d drivers/media/usb/em28xx/em28xx.o After: textdata bss dec

[PATCH 6/8] media: em28xx: split up em28xx_dvb_init to reduce stack size

2018-03-02 Thread Mauro Carvalho Chehab
From: Arnd Bergmann With CONFIG_KASAN, the init function uses a large amount of kernel stack: drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init.part.4': drivers/media/usb/em28xx/em28xx-dvb.c:2061:1: error: the frame size of 3232 bytes is larger than 2048 bytes

[PATCH 8/8] media: em28xx-dvb: simplify DVB module probing logic

2018-03-02 Thread Mauro Carvalho Chehab
The module probing logic there is a way more complex than it should be, and requires some special magic to avoid stack overflows when KASAN is enabled. Solve it by creating ancillary functions to setup the platform data and request module. Now, the probing functions are cleaner and easier to

[PATCH 5/8] media: em28xx: adjust I2C timeout according with I2C speed

2018-03-02 Thread Mauro Carvalho Chehab
If the I2C speed is too slow, it should wait more for an answer. While here, change disconnected type from char to unsigned int, just like all other bitmask fields there at em28xx struct. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c

[PATCH 7/8] media: dvb-core: add helper functions for I2C binding

2018-03-02 Thread Mauro Carvalho Chehab
The dvb_attach()/dvb_detach() methods are ugly hacks designed to keep using the I2C low-level API. The proper way is to do I2C bus bindings instead. Several modules were already converted to use it. Yet, it is painful to use it, as lots of code need to be duplicated. Make it easier by providing

[PATCH 0/8] em28xx: some improvements

2018-03-02 Thread Mauro Carvalho Chehab
The first patch in this series change the em28xx to don't require coherent memory for DMA transfers. This should bring some performance gains on non-x86 archs. The other patches in this series are results of my tests with the first patch :-) patch 2 does some cleanups at i2c and Xclock speed

[PATCH 1/8] media: em28xx: don't use coherent buffer for DMA transfers

2018-03-02 Thread Mauro Carvalho Chehab
While coherent memory is cheap on x86, it may cause performance impacts on other archs. As we don't have any good reason to use it, let's change the logic by allocating memory via kmalloc() and letting the USB core to do the DMA mapping and memory free for us. While here, also fixes an issue that

[PATCH 3/8] media: em28xx: stop rewriting device's struct

2018-03-02 Thread Mauro Carvalho Chehab
Writing at the device's struct is evil, as two em28xx devices may be using it. So, stop abusing it, storing the values inside struct em28xx_dev. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 12 +++-

[PATCH 2/8] media: em28xx: improve the logic with sets Xclk and I2C speed

2018-03-02 Thread Mauro Carvalho Chehab
The logic there should be called on two places. Also, ideally, it should not be modifying the device struct. So, change the logic accordingly. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/em28xx/em28xx-cards.c | 45 + 1

[PATCH 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

2018-03-02 Thread Fabio Estevam
From: Fabio Estevam Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl

[PATCH 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

2018-03-02 Thread Fabio Estevam
From: Gustavo A. R. Silva Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. The proper pointer to be passed as argument is pinctrl instead of priv->vdev. This issue was detected with the help of Coccinelle. Fixes: 52e17089d185 ("media: imx: Don't initialize vars

Re: [v5 2/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-03-02 Thread Rob Herring
On Wed, Feb 28, 2018 at 03:31:26PM +0200, Sakari Ailus wrote: > Hi Rob, > > Thanks for the review. > > On Tue, Feb 27, 2018 at 04:10:31PM -0600, Rob Herring wrote: > > On Fri, Feb 23, 2018 at 10:13 AM, Andy Yeh wrote: > > > From: Alan Chiang > > > >

[PATCH 0/5] Renesas CEU: SH7724 ECOVEC + Aptina mt9t112

2018-03-02 Thread Jacopo Mondi
Hello, now that CEU has been picked up for inclusion in v4.17, we can start moving users of old sh_mobile_ceu_camera driver to use the newly introduced one. Migo-R has been first, now it's SH7724 ECOVEC board turn. ECOVEC has a camera board with two MT9T112 image sensor and one TW9910 video

[PATCH 4/5] arch: sh: ecovec: Use new renesas-ceu camera driver

2018-03-02 Thread Jacopo Mondi
SH4 7724 Ecovec platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Get rid of soc_camera defined components used to register sensor drivers and of platform specific enable/disable routines. Register GPIOs for sensor drivers

[PATCH 3/5] media: i2c: mt9t112: Fix code style issues

2018-03-02 Thread Jacopo Mondi
Fix code style issues reported by checkpatch run with --strict options. Also fix other non reported style issues manually. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/mt9t112.c | 256 1 file changed, 118

[PATCH 2/5] media: i2c: mt9t112: Remove soc_camera dependencies

2018-03-02 Thread Jacopo Mondi
Remove soc_camera framework dependencies from mt9t112 sensor driver. - Handle clk, gpios and power routines - Register async subdev - Remove deprecated g/s_mbus_config operations - Remove driver flags - Change driver interface and add kernel doc - Adjust build system This commit does not remove

[PATCH 5/5] media: MAINTAINERS: Add entry for Aptina MT9T112

2018-03-02 Thread Jacopo Mondi
Add entry for Aptina/Micron MT9T112 camera sensor. The driver is currently orphaned. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 91ed6ad..1d8be25 100644 --- a/MAINTAINERS +++

[PATCH 1/5] media: i2c: Copy mt9t112 soc_camera sensor driver

2018-03-02 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-02 Thread Tomasz Figa
Hi Andy, Thanks for the patch. Let me post some comments inline. On Fri, Mar 2, 2018 at 11:55 PM, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > >

[PATCH v4] media: radio: Critical interrupt bugfix for si470x over i2c

2018-03-02 Thread Douglas Fischer
Fixed si470x_start() disabling the interrupt signal, causing tune operations to never complete. This does not affect USB radios because they poll the registers instead of using the IRQ line. Stylistic and comment changes from v3. Signed-off-by: Douglas Fischer ---

[PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-02 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Jason Chen Signed-off-by: Alan Chiang --- since v2: -- Update the streaming function

[PATCH v2 10/11] media: ov772x: Replace msleep(1) with usleep_range

2018-03-02 Thread Jacopo Mondi
msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 08/11] media: ov772x: Empty line before end-of-function return

2018-03-02 Thread Jacopo Mondi
Add an empty line before return at the end of functions. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index 8849da1..4f464ac 100644 ---

[PATCH v2 07/11] media: ov772x: Re-organize in-code comments

2018-03-02 Thread Jacopo Mondi
A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 32 ++-- 1 file changed, 10

[PATCH v2 06/11] media: ov772x: Align function parameters

2018-03-02 Thread Jacopo Mondi
Align all function parameters to first open brace when declaring functions. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c

[PATCH v2 04/11] media: tw9910: Sort includes alphabetically

2018-03-02 Thread Jacopo Mondi
Sort include directives alphabetically to ease maintenance. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index

[PATCH v2 05/11] media: tw9910: Replace msleep(1) with usleep_range

2018-03-02 Thread Jacopo Mondi
msleep() can sleep up to 20ms. As suggested by Documentation/timers/timers_howto.txt replace it with usleep_range() with up to 5ms delay. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 11/11] media: ov772x: Unregister async subdevice

2018-03-02 Thread Jacopo Mondi
As the media subdevice is registered with 'v4l2_async_register_subdev()' unregister it at module removal time with 'v4l2_async_unregister_subdev()' Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 09/11] media: ov772x: Re-order variables declaration

2018-03-02 Thread Jacopo Mondi
Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov772x.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov772x.c

[PATCH v2 03/11] media: tw9910: Mixed style fixes

2018-03-02 Thread Jacopo Mondi
Two minor style fixes, align function parameter and remove un-necessary spaces. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tw9910.c

[PATCH v2 01/11] media: tw9910: Re-order variables declaration

2018-03-02 Thread Jacopo Mondi
Re-order variables declaration to respect 'reverse christmas tree' ordering whenever possible. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH v2 02/11] media: tw9910: Re-organize in-code comments

2018-03-02 Thread Jacopo Mondi
A lot of comments that would fit a single line were spread on two or more lines. Also fix capitalization and punctuation where appropriate. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/tw9910.c | 44 +--- 1 file changed, 13

[PATCH v2 00/11] media: ov772x/tw9910 cleanup

2018-03-02 Thread Jacopo Mondi
Hi Mauro, as I had one more patch to add to the series, I have now re-based it on top of Joe's changes, which were based on top of yours already part of media-tree master branch. Please apply on top of: commit bc3c49d6bbfb ("media: tw9910: Miscellaneous neatening") commit 71c07c61b340

[PATCH 12/12] media: ov5640: Remove duplicate auto-exposure setup

2018-03-02 Thread Maxime Ripard
The autoexposure setup in the 1080p init array is redundant with the default value of the sensor. Remove it. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH 10/12] media: ov5640: Enhance FPS handling

2018-03-02 Thread Maxime Ripard
Now that we have moved the clock generation logic out of the bytes array, these arrays are identical between the 15fps and 30fps variants. Remove the duplicate entries, and convert the code accordingly. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c |

[PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-02 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either

[PATCH 00/12] media: ov5640: Misc cleanup and improvements

2018-03-02 Thread Maxime Ripard
Hi, Here is a "small" series that mostly cleans up the ov5640 driver code, slowly getting rid of the big data array for more understandable code (hopefully). The biggest addition would be the clock rate computation at runtime, instead of relying on those arrays to setup the clock tree properly.

[PATCH 04/12] media: ov5640: Init properly the SCLK dividers

2018-03-02 Thread Maxime Ripard
The SCLK and SCLK2X dividers are fixed in stone in the initialization array. Let's make explicit what we're doing and move that away from the huge array to the initialization code. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 11 ++- 1 file

[PATCH 03/12] media: ov5640: Don't force the auto exposure state at start time

2018-03-02 Thread Maxime Ripard
The sensor needs to have the auto exposure stopped while changing mode. However, when the new mode is set, the driver will force the auto exposure on, disregarding whether the control has been changed or not. Bypass the controls code entirely to do that, and only use the control value cached when

[PATCH 01/12] media: ov5640: Add auto-focus feature

2018-03-02 Thread Maxime Ripard
From: Mylène Josserand Add the auto-focus ENABLE/DISABLE feature as V4L2 control. Disabled by default. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 16

[PATCH 02/12] media: ov5640: Add light frequency control

2018-03-02 Thread Maxime Ripard
From: Mylène Josserand Add the light frequency control to be able to set the frequency to manual (50Hz or 60Hz) or auto. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard ---

[PATCH 06/12] media: ov5640: Add horizontal and vertical totals

2018-03-02 Thread Maxime Ripard
All the initialization arrays are changing the horizontal and vertical totals for some value. In order to clean up the driver, and since we're going to need that value later on, let's introduce in the ov5640_mode_info structure the horizontal and vertical total sizes, and move these out of the

[PATCH 09/12] media: ov5640: Compute the clock rate at runtime

2018-03-02 Thread Maxime Ripard
The clock rate, while hardcoded until now, is actually a function of the resolution, framerate and bytes per pixel. Now that we have an algorithm to adjust our clock rate, we can select it dynamically when we change the mode. This changes a bit the clock rate being used, with the following

[PATCH 11/12] media: ov5640: Add 60 fps support

2018-03-02 Thread Maxime Ripard
Now that we have everything in place to compute the clock rate at runtime, we can enable the 60fps framerate for the mode we tested it with. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 20 +++- 1 file changed, 15 insertions(+), 5

[PATCH 07/12] media: ov5640: Program the visible resolution

2018-03-02 Thread Maxime Ripard
The active frame size is set in the initialization arrays, but the value itself is also available in the struct ov5640_mode_info. Let's move these values out of the big bytes arrays, and program it with the value of the mode that we are given. Signed-off-by: Maxime Ripard

[PATCH 05/12] media: ov5640: Change horizontal and vertical resolutions name

2018-03-02 Thread Maxime Ripard
The current width and height parameters in the struct ov5640_mode_info are actually the active horizontal and vertical resolutions. Since we're going to add a few other parameters, let's pick a better, more precise name for these values. Signed-off-by: Maxime Ripard

Re: [bug report] media: i2c: Copy tw9910 soc_camera sensor driver

2018-03-02 Thread jacopo mondi
Hi Dan, On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote: > [ I know you're just copying files, but you might have a fix for these > since you're looking at the code. - dan ] According to the static analyzer I should simply substitute all those expressions with 0s. I would

Re: [RESEND PATCH v5 0/6] IR support for A83T

2018-03-02 Thread Sean Young
On Fri, Mar 02, 2018 at 01:11:34PM +0100, Philipp Rossak wrote: > On 13.02.2018 13:29, Philipp Rossak wrote: > > This patch series adds support for the sunxi A83T ir module and enhances > > the sunxi-ir driver. Right now the base clock frequency for the ir driver > > is a hard coded define and is

Re: [RESEND PATCH v5 0/6] IR support for A83T

2018-03-02 Thread Philipp Rossak
On 13.02.2018 13:29, Philipp Rossak wrote: This patch series adds support for the sunxi A83T ir module and enhances the sunxi-ir driver. Right now the base clock frequency for the ir driver is a hard coded define and is set to 8 MHz. This works for the most common ir receivers. On the Sinovoip

Re: [PATCH v11 28/32] rcar-vin: add link notify for Gen3

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:47 EET Niklas Söderlund wrote: > Add the ability to process media device link change request. Link s/request/requests/ > enabling is a bit complicated on Gen3, whether or not it's possible to > enable a link depends on what

Re: [PATCH v11 26/32] rcar-vin: add chsel information to rvin_info

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:45 EET Niklas Söderlund wrote: > Each Gen3 SoC has a limited set of predefined routing possibilities for > which CSI-2 device and channel can be routed to which VIN instance. > Prepare to store this information in the struct

Re: [PATCH v11 21/32] rcar-vin: use different v4l2 operations in media controller mode

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:40 EET Niklas Söderlund wrote: > When the driver runs in media controller mode it should not directly > control the subdevice instead userspace will be responsible for > configuring the pipeline. To be able to run in this mode a

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2018-03-02 Thread Laurent Pinchart
Hi Niklas, On Friday, 19 January 2018 02:46:03 EET Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your comments. > > Apart from the issue with the input API Hans pointed which indicates I > need to keep that around until it's fixed in the framework I agree with > all your comments but

Re: [PATCH v11 19/32] rcar-vin: add function to manipulate Gen3 chsel value

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:38 EET Niklas Söderlund wrote: > On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One > feature of this register is that it's only present in the VIN0 and VIN4 > instances. The register in VIN0 controls the

Re: [PATCH v11 17/32] rcar-vin: move media bus configuration to struct rvin_info

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:36 EET Niklas Söderlund wrote: > Bus configuration will once the driver is extended to support Gen3 > contain information not specific to only the directly connected parallel > subdevice. Move it to struct rvin_dev to show it's

Re: [PATCH v11 16/32] rcar-vin: read subdevice format for crop only when needed

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:35 EET Niklas Söderlund wrote: > Instead of caching the subdevice format each time the video device > format is set read it directly when it's needed. As it turns out the > format is only needed when figuring out the max rectangle

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

2018-03-02 Thread Philipp Zabel
Hi Fabio, On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > > > Oh, this only works for csi ports that have pinctrl in their csi port > > node, like: > > > > _csi0 { > > pinctrl-names = "default"; >

Re: [PATCH v11 12/32] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:31 EET Niklas Söderlund wrote: > There was never proper support in the VIN driver to deliver ALTERNATING > field format to user-space, remove this field option. The problem is > that ALTERNATING filed order requires the sequence

Re: [PATCH v11 22/32] rcar-vin: force default colorspace for media centric mode

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:41 EET Niklas Söderlund wrote: > When the VIN driver is running in media centric mode (on Gen3) the > colorspace is not retrieved from the video source instead the user is > expected to set it as part of the format. There is no

Re: [PATCH v11 15/32] rcar-vin: break out format alignment and checking

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:34 EET Niklas Söderlund wrote: > Part of the format alignment and checking can be shared with the Gen3 > format handling. Break that part out to a separate function. > > Signed-off-by: Niklas Söderlund

Re: [PATCH v5 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-03-02 Thread Maxime Ripard
Hi Benoit, On Thu, Mar 01, 2018 at 02:35:16PM -0600, Benoit Parrot wrote: > > + writel(CSI2TX_DPHY_CLK_WAKEUP_ULPS_CYCLES(32), > > + csi2tx->base + CSI2TX_DPHY_CLK_WAKEUP_REG); > > I am sorry if I missed this previously but do all these > CSI2TX_DPHY* reg access assume that

Re: [PATCH v11 13/32] rcar-vin: update bytesperline and sizeimage calculation

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:32 EET Niklas Söderlund wrote: > Remove over complicated logic to calculate the value for bytesperline > and sizeimage that was carried over from the soc_camera port. There is > no need to find the max value of bytesperline and

[PATCH] media: doc: poll: fix links to dual-ioctl sections

2018-03-02 Thread Luca Ceresoli
Links like :ref:`VIDIOC_STREAMON` expand to "ioctl VIDIOC_STREAMON, VIDIOC_STREAMOFF". Thus our reader will think we are talking about STREAMON _and_ STREAMOFF, but only one of the two actually applies in some cases. Fix by adding a link title, so the reader will read only the correct ioctl name.

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-03-02 Thread Maxime Ripard
Hi Benoit, On Thu, Mar 01, 2018 at 02:09:18PM -0600, Benoit Parrot wrote: > > + /* > > +* FIXME: Once we'll have internal D-PHY support, the check > > +* will need to be removed. > > +*/ > > + if (csi2rx->has_internal_dphy) { > > + dev_err(>dev, "Internal D-PHY not

[GIT FIXES FOR v4.16] tegra-cec: reset rx_buf_cnt when start bit detected

2018-03-02 Thread Hans Verkuil
Fix for 4.16 with CC to stable for 4.15. Regards, Hans The following changes since commit e3e389f931a14ddf43089c7db92fc5d74edf93a4: media: rc: fix race condition in ir_raw_event_store_edge() handling (2018-02-27 08:16:09 -0500) are available in the git repository at:

Your response is important

2018-03-02 Thread jeddy
Hello, I am contacting you to be my foreign partner in a financial transaction in my Corporation with the objective of investing the fund in your country. Thanks in anticipation of your response. Mr.Jeddy

Re: [PATCH v11 11/32] rcar-vin: set a default field to fallback on

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:30 EET Niklas Söderlund wrote: > If the field is not supported by the driver it should not try to keep > the current field. Instead it should set it to a default fallback. Since > trying a format should always result in the same

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-03-02 Thread Claudiu Beznea
On 28.02.2018 22:04, Jani Nikula wrote: > On Wed, 28 Feb 2018, Thierry Reding wrote: >> Anyone that needs something other than normal mode should use the new >> atomic PWM API. > > At the risk of revealing my true ignorance, what is the new atomic PWM > API? Where?

Re: [PATCH v11 02/32] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:21 EET Niklas Söderlund wrote: > From: Fabrizio Castro > > Add compatible strings for r8a7743 and r8a7745. No driver change > is needed as "renesas,rcar-gen2-vin" will activate the right code. >

Re: [PATCH v11 01/32] dt-bindings: media: rcar_vin: Reverse SoC part number list

2018-03-02 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday, 2 March 2018 03:57:20 EET Niklas Söderlund wrote: > From: Fabrizio Castro > > Change the sorting of the part numbers from descending to ascending to > match with other documentation. > > Signed-off-by: Fabrizio

Re: [PATCH v3 05/10] pwm: add PWM mode to pwm_config()

2018-03-02 Thread Claudiu Beznea
On 28.02.2018 21:44, Thierry Reding wrote: > On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote: >> Add PWM mode to pwm_config() function. The drivers which uses pwm_config() >> were adapted to this change. >> >> Signed-off-by: Claudiu Beznea >> --- >>

Re: [PATCH v5 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-03-02 Thread Maxime Ripard
Hi, On Thu, Mar 01, 2018 at 05:26:58PM +0100, Niklas Söderlund wrote: > I did not do a full review on this series, I only browsed it to check > how you handled some CSI-2 related problems. While doing so I noticed a > few small issues. Thanks for your review :) The comment I stripped out will

[PATCH] w1: fix w1_ds2438 documentation

2018-03-02 Thread Mariusz Bialonczyk
Signed-off-by: Mariusz Bialonczyk --- Documentation/w1/slaves/w1_ds2438 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/w1/slaves/w1_ds2438 b/Documentation/w1/slaves/w1_ds2438 index b99f3674c5b4..e64f65a09387 100644 ---

Re: [PATCH v5 0/2] media: v4l: Add support for the Cadence MIPI-CSI2 TX controller

2018-03-02 Thread Maxime Ripard
Hi Niklas, On Thu, Mar 01, 2018 at 05:13:38PM +0100, Niklas Söderlund wrote: > On 2018-03-01 12:30:47 +0100, Maxime Ripard wrote: > > Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence. > > > > This IP block is able to receive 4 video streams and stream them over > > a