This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Mar 3 05:00:11 CET 2018
media-tree git hash:e3e389f931a14ddf43089c7db92fc5d74edf93a4
media_build
On 03/02/2018 11:14 AM, Fabio Estevam wrote:
From: Fabio Estevam
Since commit 52e17089d185 ("media: imx: Don't initialize vars that
won't be used") imx_csi_probe() fails to probe after propagating the
devm_pinctrl_get_select_default() error.
On Fri, Mar 02, 2018 at 12:59:00PM -0600, Rob Herring wrote:
> On Wed, Feb 28, 2018 at 03:31:26PM +0200, Sakari Ailus wrote:
> > Hi Rob,
> >
> > Thanks for the review.
> >
> > On Tue, Feb 27, 2018 at 04:10:31PM -0600, Rob Herring wrote:
> > > On Fri, Feb 23, 2018 at 10:13 AM, Andy Yeh
There are several em28xx static structs that can now be constified.
That caused a significant reduction at data segment:
Before:
textdata bss dec hex filename
85017 59588 576 145181 2371d drivers/media/usb/em28xx/em28xx.o
After:
textdata bss dec
From: Arnd Bergmann
With CONFIG_KASAN, the init function uses a large amount of kernel stack:
drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init.part.4':
drivers/media/usb/em28xx/em28xx-dvb.c:2061:1: error: the frame size of 3232
bytes is larger than 2048 bytes
The module probing logic there is a way more complex than
it should be, and requires some special magic to avoid
stack overflows when KASAN is enabled.
Solve it by creating ancillary functions to setup the
platform data and request module.
Now, the probing functions are cleaner and easier to
If the I2C speed is too slow, it should wait more for an
answer.
While here, change disconnected type from char to unsigned
int, just like all other bitmask fields there at em28xx
struct.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-cards.c
The dvb_attach()/dvb_detach() methods are ugly hacks designed
to keep using the I2C low-level API. The proper way is to
do I2C bus bindings instead.
Several modules were already converted to use it. Yet,
it is painful to use it, as lots of code need to be
duplicated.
Make it easier by providing
The first patch in this series change the em28xx to don't
require coherent memory for DMA transfers. This should bring
some performance gains on non-x86 archs.
The other patches in this series are results of my tests
with the first patch :-)
patch 2 does some cleanups at i2c and Xclock speed
While coherent memory is cheap on x86, it may cause performance
impacts on other archs. As we don't have any good reason to
use it, let's change the logic by allocating memory via kmalloc()
and letting the USB core to do the DMA mapping and memory free
for us.
While here, also fixes an issue that
Writing at the device's struct is evil, as two em28xx devices
may be using it. So, stop abusing it, storing the values
inside struct em28xx_dev.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-cards.c | 12 +++-
The logic there should be called on two places. Also,
ideally, it should not be modifying the device struct.
So, change the logic accordingly.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-cards.c | 45 +
1
From: Fabio Estevam
Since commit 52e17089d185 ("media: imx: Don't initialize vars that
won't be used") imx_csi_probe() fails to probe after propagating the
devm_pinctrl_get_select_default() error.
devm_pinctrl_get_select_default() may return -ENODEV when the CSI pinctrl
From: Gustavo A. R. Silva
Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
The proper pointer to be passed as argument is pinctrl
instead of priv->vdev.
This issue was detected with the help of Coccinelle.
Fixes: 52e17089d185 ("media: imx: Don't initialize vars
On Wed, Feb 28, 2018 at 03:31:26PM +0200, Sakari Ailus wrote:
> Hi Rob,
>
> Thanks for the review.
>
> On Tue, Feb 27, 2018 at 04:10:31PM -0600, Rob Herring wrote:
> > On Fri, Feb 23, 2018 at 10:13 AM, Andy Yeh wrote:
> > > From: Alan Chiang
> > >
>
Hello,
now that CEU has been picked up for inclusion in v4.17, we can start moving
users of old sh_mobile_ceu_camera driver to use the newly introduced one.
Migo-R has been first, now it's SH7724 ECOVEC board turn.
ECOVEC has a camera board with two MT9T112 image sensor and one TW9910 video
SH4 7724 Ecovec platform uses sh_mobile_ceu camera driver, which is now
being replaced by a proper V4L2 camera driver named 'renesas-ceu'.
Get rid of soc_camera defined components used to register sensor drivers
and of platform specific enable/disable routines.
Register GPIOs for sensor drivers
Fix code style issues reported by checkpatch run with --strict
options. Also fix other non reported style issues manually.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/mt9t112.c | 256
1 file changed, 118
Remove soc_camera framework dependencies from mt9t112 sensor driver.
- Handle clk, gpios and power routines
- Register async subdev
- Remove deprecated g/s_mbus_config operations
- Remove driver flags
- Change driver interface and add kernel doc
- Adjust build system
This commit does not remove
Add entry for Aptina/Micron MT9T112 camera sensor. The driver is
currently orphaned.
Signed-off-by: Jacopo Mondi
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 91ed6ad..1d8be25 100644
--- a/MAINTAINERS
+++
Copy the soc_camera based driver in v4l2 sensor driver directory.
This commit just copies the original file without modifying it.
No modification to KConfig and Makefile as soc_camera framework
dependencies need to be removed first in next commit.
Signed-off-by: Jacopo Mondi
Hi Andy,
Thanks for the patch. Let me post some comments inline.
On Fri, Mar 2, 2018 at 11:55 PM, Andy Yeh wrote:
> Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
>
>
Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Stylistic and comment changes from v3.
Signed-off-by: Douglas Fischer
---
Add a V4L2 sub-device driver for the Sony IMX258 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Signed-off-by: Jason Chen
Signed-off-by: Alan Chiang
---
since v2:
-- Update the streaming function
msleep() can sleep up to 20ms.
As suggested by Documentation/timers/timers_howto.txt replace it with
usleep_range() with up to 5ms delay.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Add an empty line before return at the end of functions.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
index 8849da1..4f464ac 100644
---
A lot of comments that would fit a single line were spread on two or
more lines. Also fix capitalization and punctuation where appropriate.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 32 ++--
1 file changed, 10
Align all function parameters to first open brace when declaring
functions.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
Sort include directives alphabetically to ease maintenance.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/tw9910.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
index
msleep() can sleep up to 20ms.
As suggested by Documentation/timers/timers_howto.txt replace it with
usleep_range() with up to 5ms delay.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/tw9910.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
As the media subdevice is registered with 'v4l2_async_register_subdev()'
unregister it at module removal time with
'v4l2_async_unregister_subdev()'
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Re-order variables declaration to respect 'reverse christmas tree'
ordering whenever possible.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov772x.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov772x.c
Two minor style fixes, align function parameter and remove un-necessary
spaces.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/tw9910.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tw9910.c
Re-order variables declaration to respect 'reverse christmas tree'
ordering whenever possible.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/tw9910.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git
A lot of comments that would fit a single line were spread on two or
more lines. Also fix capitalization and punctuation where appropriate.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/tw9910.c | 44 +---
1 file changed, 13
Hi Mauro,
as I had one more patch to add to the series, I have now re-based it on top
of Joe's changes, which were based on top of yours already part of media-tree
master branch.
Please apply on top of:
commit bc3c49d6bbfb ("media: tw9910: Miscellaneous neatening")
commit 71c07c61b340
The autoexposure setup in the 1080p init array is redundant with the
default value of the sensor.
Remove it.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c
Now that we have moved the clock generation logic out of the bytes array,
these arrays are identical between the 15fps and 30fps variants.
Remove the duplicate entries, and convert the code accordingly.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c |
The clock structure for the PCLK is quite obscure in the documentation, and
was hardcoded through the bytes array of each and every mode.
This is troublesome, since we cannot adjust it at runtime based on other
parameters (such as the number of bytes per pixel), and we can't support
either
Hi,
Here is a "small" series that mostly cleans up the ov5640 driver code,
slowly getting rid of the big data array for more understandable code
(hopefully).
The biggest addition would be the clock rate computation at runtime,
instead of relying on those arrays to setup the clock tree
properly.
The SCLK and SCLK2X dividers are fixed in stone in the initialization
array. Let's make explicit what we're doing and move that away from the
huge array to the initialization code.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 11 ++-
1 file
The sensor needs to have the auto exposure stopped while changing mode.
However, when the new mode is set, the driver will force the auto exposure
on, disregarding whether the control has been changed or not.
Bypass the controls code entirely to do that, and only use the control
value cached when
From: Mylène Josserand
Add the auto-focus ENABLE/DISABLE feature as V4L2 control.
Disabled by default.
Signed-off-by: Mylène Josserand
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 16
From: Mylène Josserand
Add the light frequency control to be able to set the frequency
to manual (50Hz or 60Hz) or auto.
Signed-off-by: Mylène Josserand
Signed-off-by: Maxime Ripard
---
All the initialization arrays are changing the horizontal and vertical
totals for some value.
In order to clean up the driver, and since we're going to need that value
later on, let's introduce in the ov5640_mode_info structure the horizontal
and vertical total sizes, and move these out of the
The clock rate, while hardcoded until now, is actually a function of the
resolution, framerate and bytes per pixel. Now that we have an algorithm to
adjust our clock rate, we can select it dynamically when we change the
mode.
This changes a bit the clock rate being used, with the following
Now that we have everything in place to compute the clock rate at runtime,
we can enable the 60fps framerate for the mode we tested it with.
Signed-off-by: Maxime Ripard
---
drivers/media/i2c/ov5640.c | 20 +++-
1 file changed, 15 insertions(+), 5
The active frame size is set in the initialization arrays, but the value
itself is also available in the struct ov5640_mode_info.
Let's move these values out of the big bytes arrays, and program it with
the value of the mode that we are given.
Signed-off-by: Maxime Ripard
The current width and height parameters in the struct ov5640_mode_info are
actually the active horizontal and vertical resolutions.
Since we're going to add a few other parameters, let's pick a better, more
precise name for these values.
Signed-off-by: Maxime Ripard
Hi Dan,
On Thu, Mar 01, 2018 at 12:59:54PM +0300, Dan Carpenter wrote:
> [ I know you're just copying files, but you might have a fix for these
> since you're looking at the code. - dan ]
According to the static analyzer I should simply substitute all those
expressions with 0s. I would
On Fri, Mar 02, 2018 at 01:11:34PM +0100, Philipp Rossak wrote:
> On 13.02.2018 13:29, Philipp Rossak wrote:
> > This patch series adds support for the sunxi A83T ir module and enhances
> > the sunxi-ir driver. Right now the base clock frequency for the ir driver
> > is a hard coded define and is
On 13.02.2018 13:29, Philipp Rossak wrote:
This patch series adds support for the sunxi A83T ir module and enhances
the sunxi-ir driver. Right now the base clock frequency for the ir driver
is a hard coded define and is set to 8 MHz.
This works for the most common ir receivers. On the Sinovoip
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:47 EET Niklas Söderlund wrote:
> Add the ability to process media device link change request. Link
s/request/requests/
> enabling is a bit complicated on Gen3, whether or not it's possible to
> enable a link depends on what
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:45 EET Niklas Söderlund wrote:
> Each Gen3 SoC has a limited set of predefined routing possibilities for
> which CSI-2 device and channel can be routed to which VIN instance.
> Prepare to store this information in the struct
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:40 EET Niklas Söderlund wrote:
> When the driver runs in media controller mode it should not directly
> control the subdevice instead userspace will be responsible for
> configuring the pipeline. To be able to run in this mode a
Hi Niklas,
On Friday, 19 January 2018 02:46:03 EET Niklas Söderlund wrote:
> Hi Laurent,
>
> Thanks for your comments.
>
> Apart from the issue with the input API Hans pointed which indicates I
> need to keep that around until it's fixed in the framework I agree with
> all your comments but
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:38 EET Niklas Söderlund wrote:
> On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One
> feature of this register is that it's only present in the VIN0 and VIN4
> instances. The register in VIN0 controls the
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:36 EET Niklas Söderlund wrote:
> Bus configuration will once the driver is extended to support Gen3
> contain information not specific to only the directly connected parallel
> subdevice. Move it to struct rvin_dev to show it's
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:35 EET Niklas Söderlund wrote:
> Instead of caching the subdevice format each time the video device
> format is set read it directly when it's needed. As it turns out the
> format is only needed when figuring out the max rectangle
Hi Fabio,
On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote:
> On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote:
>
> > Oh, this only works for csi ports that have pinctrl in their csi port
> > node, like:
> >
> > _csi0 {
> > pinctrl-names = "default";
>
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:31 EET Niklas Söderlund wrote:
> There was never proper support in the VIN driver to deliver ALTERNATING
> field format to user-space, remove this field option. The problem is
> that ALTERNATING filed order requires the sequence
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:41 EET Niklas Söderlund wrote:
> When the VIN driver is running in media centric mode (on Gen3) the
> colorspace is not retrieved from the video source instead the user is
> expected to set it as part of the format. There is no
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:34 EET Niklas Söderlund wrote:
> Part of the format alignment and checking can be shared with the Gen3
> format handling. Break that part out to a separate function.
>
> Signed-off-by: Niklas Söderlund
Hi Benoit,
On Thu, Mar 01, 2018 at 02:35:16PM -0600, Benoit Parrot wrote:
> > + writel(CSI2TX_DPHY_CLK_WAKEUP_ULPS_CYCLES(32),
> > + csi2tx->base + CSI2TX_DPHY_CLK_WAKEUP_REG);
>
> I am sorry if I missed this previously but do all these
> CSI2TX_DPHY* reg access assume that
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:32 EET Niklas Söderlund wrote:
> Remove over complicated logic to calculate the value for bytesperline
> and sizeimage that was carried over from the soc_camera port. There is
> no need to find the max value of bytesperline and
Links like :ref:`VIDIOC_STREAMON` expand to "ioctl VIDIOC_STREAMON,
VIDIOC_STREAMOFF". Thus our reader will think we are talking about
STREAMON _and_ STREAMOFF, but only one of the two actually applies
in some cases.
Fix by adding a link title, so the reader will read only the correct
ioctl name.
Hi Benoit,
On Thu, Mar 01, 2018 at 02:09:18PM -0600, Benoit Parrot wrote:
> > + /*
> > +* FIXME: Once we'll have internal D-PHY support, the check
> > +* will need to be removed.
> > +*/
> > + if (csi2rx->has_internal_dphy) {
> > + dev_err(>dev, "Internal D-PHY not
Fix for 4.16 with CC to stable for 4.15.
Regards,
Hans
The following changes since commit e3e389f931a14ddf43089c7db92fc5d74edf93a4:
media: rc: fix race condition in ir_raw_event_store_edge() handling
(2018-02-27 08:16:09 -0500)
are available in the git repository at:
Hello,
I am contacting you to be my foreign partner in a financial transaction in my
Corporation with the objective of investing the fund in your country.
Thanks in anticipation of your response.
Mr.Jeddy
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:30 EET Niklas Söderlund wrote:
> If the field is not supported by the driver it should not try to keep
> the current field. Instead it should set it to a default fallback. Since
> trying a format should always result in the same
On 28.02.2018 22:04, Jani Nikula wrote:
> On Wed, 28 Feb 2018, Thierry Reding wrote:
>> Anyone that needs something other than normal mode should use the new
>> atomic PWM API.
>
> At the risk of revealing my true ignorance, what is the new atomic PWM
> API? Where?
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:21 EET Niklas Söderlund wrote:
> From: Fabrizio Castro
>
> Add compatible strings for r8a7743 and r8a7745. No driver change
> is needed as "renesas,rcar-gen2-vin" will activate the right code.
>
Hi Niklas,
Thank you for the patch.
On Friday, 2 March 2018 03:57:20 EET Niklas Söderlund wrote:
> From: Fabrizio Castro
>
> Change the sorting of the part numbers from descending to ascending to
> match with other documentation.
>
> Signed-off-by: Fabrizio
On 28.02.2018 21:44, Thierry Reding wrote:
> On Thu, Feb 22, 2018 at 02:01:16PM +0200, Claudiu Beznea wrote:
>> Add PWM mode to pwm_config() function. The drivers which uses pwm_config()
>> were adapted to this change.
>>
>> Signed-off-by: Claudiu Beznea
>> ---
>>
Hi,
On Thu, Mar 01, 2018 at 05:26:58PM +0100, Niklas Söderlund wrote:
> I did not do a full review on this series, I only browsed it to check
> how you handled some CSI-2 related problems. While doing so I noticed a
> few small issues.
Thanks for your review :)
The comment I stripped out will
Signed-off-by: Mariusz Bialonczyk
---
Documentation/w1/slaves/w1_ds2438 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/w1/slaves/w1_ds2438
b/Documentation/w1/slaves/w1_ds2438
index b99f3674c5b4..e64f65a09387 100644
---
Hi Niklas,
On Thu, Mar 01, 2018 at 05:13:38PM +0100, Niklas Söderlund wrote:
> On 2018-03-01 12:30:47 +0100, Maxime Ripard wrote:
> > Here is an attempt at supporting the MIPI-CSI2 TX block from Cadence.
> >
> > This IP block is able to receive 4 video streams and stream them over
> > a
77 matches
Mail list logo