Re: [PATCH 02/14] sh-veu: don't use COLORSPACE_JPEG.

2015-06-21 Thread Guennadi Liakhovetski
hans.verk...@cisco.com Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Thanks Guennadi --- drivers/media/platform/sh_veu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c index 77a74d3..f5e3eb3a 100644

Re: [PATCH 01/14] sh-veu: initialize timestamp_flags and copy timestamp info

2015-06-21 Thread Guennadi Liakhovetski
On Mon, 15 Jun 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This field wasn't set, causing WARN_ON's from the vb2 core. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Thanks Guennadi --- drivers/media

Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions

2015-06-21 Thread Guennadi Liakhovetski
On Sat, 20 Jun 2015, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev, + enum pxa_camera_active_dma act_dma); + +static void pxa_camera_dma_irq_y(void *data) Wait, how

Re: [PATCH 04/14] tw9910: init priv-scale and update standard

2015-06-21 Thread Guennadi Liakhovetski
On Mon, 15 Jun 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com When the standard changes the VACTIVE and VDELAY values need to be updated. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/soc_camera/tw9910.c | 29 -

Re: [PATCH 11/15] media: soc_camera: soc_scale_crop: Use correct pad number in try_fmt

2015-06-20 Thread Guennadi Liakhovetski
On Wed, 3 Jun 2015, William Towle wrote: From: Rob Taylor rob.tay...@codethink.co.uk Fix calls to subdev try_fmt to use correct pad. Fixes failures with subdevs that care about having the right pad number set. Signed-off-by: William Towle william.to...@codethink.co.uk Reviewed-by: Rob

Re: [PATCH 11/15] media: soc_camera: soc_scale_crop: Use correct pad number in try_fmt

2015-06-20 Thread Guennadi Liakhovetski
On Wed, 3 Jun 2015, William Towle wrote: From: Rob Taylor rob.tay...@codethink.co.uk Fix calls to subdev try_fmt to use correct pad. Fixes failures with subdevs that care about having the right pad number set. Signed-off-by: William Towle william.to...@codethink.co.uk Reviewed-by: Rob

Re: [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt

2015-06-20 Thread Guennadi Liakhovetski
Hi William, On Wed, 3 Jun 2015, William Towle wrote: Fix rcar_vin_try_fmt to use the correct pad number when calling the subdev set_fmt. Previously pad number 0 was always used, resulting in EINVAL if the subdev cares about the pad number (e.g. ADV7612). Signed-off-by: William Towle

Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions

2015-06-20 Thread Guennadi Liakhovetski
On Sun, 22 Mar 2015, Robert Jarzmik wrote: From: Robert Jarzmik robert.jarz...@intel.com This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are

Re: [PATCH 09/15] media: soc_camera pad-aware driver initialisation

2015-06-14 Thread Guennadi Liakhovetski
Hi William, On Wed, 3 Jun 2015, William Towle wrote: Add detection of source pad number for drivers aware of the media controller API, so that the combination of soc_camera and rcar_vin can create device nodes to support modern drivers such as adv7604.c (for HDMI on Lager) and the converted

[GIT PULL] soc-camera: 3 more atmel-isi patches for 4.2

2015-06-14 Thread Guennadi Liakhovetski
Hi Mauro, Please pull 3 atmel-isi patches for 4.2. I've got two more patch series under review currently: pxa and rcar_vin, but they will need some more time. I'll try to review them next weekend, but I don't think we'll manage to push them for 4.2. Even if the PXA series will not produce any

Re: [PATCH v5 0/3] media: atmel-isi: rework on the clock part and add runtime pm support

2015-06-11 Thread Guennadi Liakhovetski
Hi Josh, On Thu, 11 Jun 2015, Josh Wu wrote: Hi, Guennadi Any feedback for this patch series? Sorry, I haven't found the time to look at patches from you and William Towle, they are at the top of my todo list now - after all the compulsory things, of course. I'll handle them as soon as I

Re: [PATCH 4/4] media: pxa_camera: conversion to dmaengine

2015-06-07 Thread Guennadi Liakhovetski
Hi Robert, Please, correct me if I am wrong, but doesn't this patch have to be updates? Elgl looking at this: On Sun, 22 Mar 2015, Robert Jarzmik wrote: From: Robert Jarzmik robert.jarz...@intel.com Convert pxa_camera to dmaengine. This removes all DMA registers manipulation in favor of

Re: [PATCH 0/4] media: pxa_camera conversion to dmaengine

2015-06-07 Thread Guennadi Liakhovetski
Hi Robert, I've sent you two replies, did you get them? Spam filter? Thanks Guennadi On Sat, 6 Jun 2015, Robert Jarzmik wrote: Robert Jarzmik robert.jarz...@free.fr writes: Robert Jarzmik robert.jarz...@free.fr writes: Hi Guennadi, I've been cooking this since 2012. At that time,

Re: [PATCH 03/20] media: adv7604: chip info and formats for ADV7612

2015-05-25 Thread Guennadi Liakhovetski
Hi William, Just a nitpick: On Wed, 20 May 2015, William Towle wrote: Add support for the ADV7612 chip as implemented on Renesas' Lager board to adv7604.c, including lists for formats/colourspace/timing selection and an IRQ handler. Signed-off-by: William Towle

Re: [PATCH 07/20] media: soc_camera: rcar_vin: Add BT.709 24-bit RGB888 input support

2015-05-25 Thread Guennadi Liakhovetski
Hi William, How about this version of this patch: https://patchwork.linuxtv.org/patch/28098/ ? I personally like that one better, it seems clearer to me. This one first sets a bit to vnmp, then make another check and inverts it, whereas that version clearly sets it just for equal

Re: [PATCH 16/20] media: adv7180: Fix set_pad_format() passing wrong format

2015-05-25 Thread Guennadi Liakhovetski
On Wed, 20 May 2015, William Towle wrote: Return a usable format (and resolution) from adv7180_set_pad_format() in the TRY_FORMAT case Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk Tested-by: William Towle william.to...@codethink.co.uk Author? --- drivers/media/i2c/adv7180.c |

Re: [PATCH 13/20] media: soc_camera: v4l2-compliance fixes for querycap

2015-05-25 Thread Guennadi Liakhovetski
Hi William, On Wed, 20 May 2015, William Towle wrote: Fill in bus_info field and zero reserved field. Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk If you're the author and the submitter of this patch, why is Rob's Sob here needed? Or is he the author? Thanks Guennadi

Re: [PATCH 17/20] media: adv7604: Support V4L_FIELD_INTERLACED

2015-05-25 Thread Guennadi Liakhovetski
On Wed, 20 May 2015, William Towle wrote: When hardware reports interlaced input, correctly set field to V4L_FIELD_INTERLACED ini adv76xx_fill_format. Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk ---

Re: [PATCH v2 1/3] media: atmel-isi: remove the useless code which disable isi

2015-05-25 Thread Guennadi Liakhovetski
Hi Josh, On Tue, 12 May 2015, Josh Wu wrote: Hi, Guennadi On 5/12/2015 4:16 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for the patch. I'm afraid I don't quite understand why it is needed, could you maybe explain a bit more? Is it because (1) during ISI configuration

Re: [PATCH 14/20] media: rcar_vin: Reject videobufs that are too small for current format

2015-05-25 Thread Guennadi Liakhovetski
On Wed, 20 May 2015, William Towle wrote: In videobuf_setup reject buffers that are too small for the configured format. Fixes v4l2-complience issue. Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk Ditto: why Rob's Sob if you're

Re: [PATCH 20/20] media: soc_camera: Add debugging for get_formats

2015-05-25 Thread Guennadi Liakhovetski
Hi William, In principle, we could add these or a bunch of other useful debugging prints, but mostly they are are one-off - you used them for your debugging, then you throw them away until the next time. Do you really find them so valuable? Usually when a new code fragment is added, it can

Re: [PATCH 19/20] media: rcar_vin: Clean up format debugging statements

2015-05-25 Thread Guennadi Liakhovetski
Hi William, On Wed, 20 May 2015, William Towle wrote: Pretty print fourcc and code in format debugging statements. Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk --- drivers/media/platform/soc_camera/rcar_vin.c | 22

Re: v4.1-rcX regression in v4l2 build

2015-05-12 Thread Guennadi Liakhovetski
in your .config? Although, no, it's not PXA CCF, it's most probably this commit 4f528afcfbcac540c8690b41307cac5c22088ff1 Author: Guennadi Liakhovetski g.liakhovet...@gmx.de Date: Sun Feb 1 08:12:33 2015 -0300 [media] V4L: add CCF support to the v4l2_clk API :( But I don't understand how

Re: v4.1-rcX regression in v4l2 build

2015-05-12 Thread Guennadi Liakhovetski
On Tue, 12 May 2015, Guennadi Liakhovetski wrote: Hi Robert, On Tue, 12 May 2015, Robert Jarzmik wrote: Hi Guennadi, Today I noticed the mioa701 build is broken on v4.1-rcX series. It was working in v4.0. The build error I get is : LINKvmlinux LD vmlinux.o

Re: [PATCH v2 1/3] media: atmel-isi: remove the useless code which disable isi

2015-05-11 Thread Guennadi Liakhovetski
Hi Josh, Thanks for the patch. I'm afraid I don't quite understand why it is needed, could you maybe explain a bit more? Is it because (1) during ISI configuration the pixel clock from the sensor is (usually) anyway disabled, so, we don't have to additionally disable the ISI, without the

Re: [PATCH 9/9] mt9t112: initialize left and top

2015-05-04 Thread Guennadi Liakhovetski
On Mon, 4 May 2015, Hans Verkuil wrote: On 05/03/2015 11:02 PM, Guennadi Liakhovetski wrote: Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off

Re: [PATCH 9/9] mt9t112: initialize left and top

2015-05-04 Thread Guennadi Liakhovetski
On Mon, 4 May 2015, Hans Verkuil wrote: On 05/04/2015 09:40 AM, Guennadi Liakhovetski wrote: On Mon, 4 May 2015, Hans Verkuil wrote: On 05/03/2015 11:02 PM, Guennadi Liakhovetski wrote: Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com

Re: soc-camera: opinion poll - future directions

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: Hi Guennadi, On 05/03/2015 06:11 PM, Guennadi Liakhovetski wrote: Hi all, Just a quick opinion poll - where and how should the soc-camera framework and drivers be heading? Possible (probably not all) directions: (1) all is good

Re: [PATCH 5/9] ov5642: avoid calling ov5642_find_datafmt() twice

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov5642_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov5642.c | 7 --- 1

Re: [PATCH 6/9] ov772x: avoid calling ov772x_select_params() twice

2015-05-03 Thread Guennadi Liakhovetski
On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Merge ov772x_s_fmt into ov772x_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [PATCH 8/9] ov9740: avoid calling ov9740_res_roundup() twice

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov9740_s_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9740.c | 18

Re: [PATCH 9/9] mt9t112: initialize left and top

2015-05-03 Thread Guennadi Liakhovetski
On Sun, 3 May 2015, Guennadi Liakhovetski wrote: Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off-by: Hans Verkuil hans.verk...@cisco.com

Re: [PATCH 7/9] ov9640: avoid calling ov9640_res_roundup() twice

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov9640_s_fmt and ov9640_set_fmt Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov9640.c

Re: [PATCH 9/9] mt9t112: initialize left and top

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The left and top variables were uninitialized, leading to unexpected results. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/soc_camera/mt9t112.c | 3 ++- 1 file

soc-camera: opinion poll - future directions

2015-05-03 Thread Guennadi Liakhovetski
Hi all, Just a quick opinion poll - where and how should the soc-camera framework and drivers be heading? Possible (probably not all) directions: (1) all is good, keep as is. That means keep all drivers, killing them off only when it becomes very obvious, that noone wants them, keep developing

Re: [PATCH 1/9] imx074: don't call imx074_find_datafmt() twice

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, Thanks for fixing the drivers! On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify imx074_set_fmt(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c

Re: [PATCH 3/9] mt9v022: avoid calling mt9v022_find_datafmt() twice

2015-05-03 Thread Guennadi Liakhovetski
On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify mt9v022_s_fmt and mt9v022_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [PATCH 2/9] mt9m001: avoid calling mt9m001_find_datafmt() twice

2015-05-03 Thread Guennadi Liakhovetski
On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify mt9m001_s_fmt and mt9m001_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [PATCH 4/9] ov2640: avoid calling ov2640_select_win() twice

2015-05-03 Thread Guennadi Liakhovetski
Hi Hans, On Sun, 3 May 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Simplify ov2640_set_params and ov2640_set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Reported-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/soc_camera/ov2640

Re: [PATCH 3/7] v4l2: replace try_mbus_fmt by set_fmt

2015-05-02 Thread Guennadi Liakhovetski
will replace both try_mbus_fmt and s_mbus_fmt by set_fmt. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Jonathan Corbet cor...@lwn.net Cc: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7183.c| 36

Re: [PATCH 2/7] v4l2: replace video op g_mbus_fmt by pad op get_fmt

2015-04-15 Thread Guennadi Liakhovetski
On Thu, 9 Apr 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The g_mbus_fmt video op is a duplicate of the pad op. Replace all uses by the get_fmt pad op and remove the video op. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Guennadi Liakhovetski g.liakhovet

Re: [PATCH 1/7] v4l2: replace enum_mbus_fmt by enum_mbus_code

2015-04-15 Thread Guennadi Liakhovetski
On Thu, 9 Apr 2015, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Replace all calls to the enum_mbus_fmt video op by the pad enum_mbus_code op and remove the duplicate video op. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Guennadi Liakhovetski g.liakhovet

[GIT PULL] soc-camera: one rcar-vin patch for 4.1

2015-04-11 Thread Guennadi Liakhovetski
Hi Mauro, Would it be still possible to get this patch in for 4.1? Especially since this is actually a fix, not a new feature. The following changes since commit bfb4e26f253201aa4f63f13be9447116b3785194: Merge branch 'patchwork' into to_next (2015-04-08 18:08:38 -0300) are available in the

Re: [PATCH V2] [media] V4L: soc-camera: add SPI device support

2015-04-05 Thread Guennadi Liakhovetski
Hi Kassey, Thanks for updating your patch and addressing my comments! In your reply to v1 of this patch you said, that you would add DT support in v2, i.e. in this version, right? Is it now present in this patch? If yes - can you explain to me how it works? For I2C the

Re: [media-workshop] [ANN] Media Mini-Summit Draft Agenda for March 26th

2015-03-24 Thread Guennadi Liakhovetski
Hi Mauro, On Sun, 22 Mar 2015, Mauro Carvalho Chehab wrote: Em Mon, 16 Mar 2015 12:25:28 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: This is the draft agenda for the media mini-summit in San Jose on March 26th. Time: 9 AM to 5 PM (approximately) Room: TBC (Mauro, do you know

Re: [PATCH/RFC] media: soc_camera: rcar_vin: Fix wait_for_completion

2015-03-15 Thread Guennadi Liakhovetski
Hi, Thanks for the patch. On Sun, 15 Mar 2015, Yoshihiro Kaneko wrote: From: Koji Matsuoka koji.matsuoka...@renesas.com When stopping abnormally, a driver can't return from wait_for_completion. This patch resolved this problem by changing wait_for_completion_timeout from

Re: [PATCH v1.1 3/3] v4l: of: Add link-frequencies array to struct v4l2_of_endpoint

2015-03-15 Thread Guennadi Liakhovetski
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de for soc-camera drivers above. drivers/media/v4l2-core/v4l2-of.c | 51 +++- include/media/v4l2-of.h|9 + 14 files changed, 84 insertions(+), 19 deletions(-) diff --git

[GIT PULL] soc-camera: first 4.1 patch set

2015-03-15 Thread Guennadi Liakhovetski
/gliakhovetski/v4l-dvb.git for-4.1-1 for you to fetch changes up to ca1613ec1a022fe2a3091fc1c0fbbe0661f1b2a6: rcar-vin: Don't implement empty optional clock operations (2015-03-15 18:58:43 +0100) Guennadi Liakhovetski (2): V4L

Re: [PATCH/RFC 4/4] soc-camera: Skip v4l2 clock registration if host doesn't provide clk ops

2015-03-15 Thread Guennadi Liakhovetski
Hi Laurent, On Mon, 9 Mar 2015, Laurent Pinchart wrote: If the soc-camera host doesn't provide clock start and stop operations registering a v4l2 clock is pointless. Don't do it. This can introduce breakage only for camera-host drivers, that don't provide .clock_start() or .clock_stop().

Re: Aptina MT9V024

2015-03-11 Thread Guennadi Liakhovetski
Guennadi Liakhovetski g.liakhovet...@gmx.de: Hi, On Sun, 8 Mar 2015, Ayhan KÃ~\Ã~GÃ~\KMANÄ°SA wrote: Hi Guennadi, Previously i asked you a problem about accesing camera i2c bus. I solved camera i2c detect problem. Now i can get images using mplayer and v4l2 lib. But i

Re: [PATCH v4 2/2] V4L: add CCF support to the v4l2_clk API

2015-03-09 Thread Guennadi Liakhovetski
Hi Mauro, On Mon, 2 Mar 2015, Mauro Carvalho Chehab wrote: Em Sun, 1 Feb 2015 12:12:33 +0100 (CET) Guennadi Liakhovetski g.liakhovet...@gmx.de escreveu: V4L2 clocks, e.g. used by camera sensors for their master clock, do not have to be supplied by a different V4L2 driver, they can also

Re: Aptina MT9V024

2015-03-08 Thread Guennadi Liakhovetski
Hi, On Sun, 8 Mar 2015, Ayhan KÃ~\Ã~GÃ~\KMANÄ°SA wrote: Hi Guennadi, Previously i asked you a problem about accesing camera i2c bus. I solved camera i2c detect problem. Now i can get images using mplayer and v4l2 lib. But i couldnt get right images. I try to get test pattern but when i get

Re: [PATCH 3/3] media: atmel-isi: remove mck back compatiable code as we don't need it

2015-03-06 Thread Guennadi Liakhovetski
Hi Josh, Laurent, On Fri, 6 Mar 2015, Josh Wu wrote: On 3/5/2015 6:41 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Thursday 05 March 2015 13:01:01 Josh Wu wrote: The master clock should handled by sensor itself. I like that :-) Signed-off-by: Josh Wu

Re: [PATCH] [media] soc_camera: fix devm_kfree warning on error path

2015-03-02 Thread Guennadi Liakhovetski
Hi Axel, On Mon, 2 Mar 2015, Axel Haslam wrote: sorry, i had not seen the thread with Geert about this issue, i guess it is fixed allready! Np, thanks for your version too! It is identical to Geert's one, yes, which is good! It means the chances for the patch to be corect become even

Re: [PATCH v5 2/4] media: ov2640: add async probe function

2015-03-01 Thread Guennadi Liakhovetski
Hi Josh, Thanks for a patch update. I think it looks good as a first step in your patch series, just a minor comment below: On Tue, 10 Feb 2015, Josh Wu wrote: In async probe, there is a case that ov2640 is probed before the host device which provided 'mclk'. To support this async probe, we

[GIT PULL] a fix for 4.0-rc1 + stable

2015-02-28 Thread Guennadi Liakhovetski
Hi Mauro, Please pull and forward this fix. The following changes since commit 895c8b7b4623d4f55e260e5dee2574b4f7113105: Merge tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2015-02-27 16:18:33 -0800) are available in the git repository at:

Re: [PATCH] [media] soc-camera: Remove bogus devm_kfree() in soc_of_bind()

2015-02-18 Thread Guennadi Liakhovetski
On Wed, 18 Feb 2015, Sergei Shtylyov wrote: Hello. On 02/18/2015 07:32 PM, Geert Uytterhoeven wrote: Unlike scan_async_group(), soc_of_bind() doesn't allocate its soc_camera_async_client structure using devm_kzalloc(), but has it embedded inside the soc_of_info structure. Hence on

[GIT PULL] soc-camera: one delayed patch for 3.20 or 3.21

2015-02-15 Thread Guennadi Liakhovetski
Hi Mauro, This is just a single patch for a single soc-camera host driver. No rush, I presume, you're not planning another 3.20 pull request, in which case it will wait until 3.21. But in case you are planning one and you find it acceptable to also take this one - here goes. I just missed this

Re: [PATCH] media: atmel-isi: increase the burst length to improve the performance

2015-02-02 Thread Guennadi Liakhovetski
Hi Josh, On Mon, 2 Feb 2015, Josh Wu wrote: Hi, Guennadi Ping? what about the status of this patch? Right, got lost, sorry... Added to the queue now. Thanks Guennadi Best Regards, Josh Wu On 11/25/2014 5:30 PM, Josh Wu wrote: The burst length could be BEATS_4/8/16. Before this

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-02-01 Thread Guennadi Liakhovetski
On a second thought: On Sun, 1 Feb 2015, Guennadi Liakhovetski wrote: Hi Wills, Thanks for the patch. First and foremost, the title of the patch is wrong. This patch does more than just adding some adv7604 compatibility. It's adding pad-level API to soc-camera. This is just a rough

Re: [PATCH 7/8] WmT: rcar_vin new ADV7612 support

2015-02-01 Thread Guennadi Liakhovetski
Hi Wills, Same proposed wrappers could be used here. Thanks Guennadi On Thu, 29 Jan 2015, William Towle wrote: Add 'struct media_pad pad' member and suitable glue code, so that soc_camera/rcar_vin can become agnostic to whether an old or new- style driver (wrt pad API use) can sit

[PATCH v4 2/2] V4L: add CCF support to the v4l2_clk API

2015-02-01 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- v4: sizeof(*clk) :) drivers/media/v4l2-core/v4l2-clk.c | 48 +++--- include/media/v4l2-clk.h | 2 ++ 2 files changed, 47 insertions

Re: RFC: supporting adv7604.c under soc_camera/rcar_vin

2015-02-01 Thread Guennadi Liakhovetski
Hi Wills, A general comment: please, don't prefix patch titles with WmT, this isn't the way authors or submitters are credited for their work in the Linux kernel. Thanks Guennadi On Thu, 29 Jan 2015, William Towle wrote: The following constitutes parts of our rcar_vin development branch

[GIT PULL] soc-camera for 3.20 #1

2015-02-01 Thread Guennadi Liakhovetski
) Guennadi Liakhovetski (1): soc-camera: remove redundant code Ian Molton (1): rcar_vin: helper function for streaming stop Josh Wu (1): ov2640: use the v4l2 size definitions Lad, Prabhakar (1): soc_camera: use

Re: [PATCH 5/8] media: rcar_vin: Add RGB888_1X24 input format support

2015-02-01 Thread Guennadi Liakhovetski
Hi Wills, On Thu, 29 Jan 2015, William Towle wrote: This adds V4L2_MBUS_FMT_RGB888_1X24 input format support which is used by the ADV7612 chip. Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com --- URL:http://marc.info/?l=linux-shm=138002993417489q=raw FIXMEs

Re: [PATCH V1] [media] V4L: soc-camera: add SPI device support

2015-02-01 Thread Guennadi Liakhovetski
Hi Kassey, Thanks for the patch. Do I understand it right, that this patch only supports SPI subdevices, supplied in platform data, no support for asynchronous SPI clients / DT? Does your platform not support DT? I'm not an expert in SPI, so, not really sure how correct is the use of the SPI

soc-camera: patches in work

2015-02-01 Thread Guennadi Liakhovetski
Hi all, I've just posted a pull request with 5 relatively simple patches for soc-camera 3.20. AFAICS, the following patches are still in work (respective authors and submitters Cc'ed): From: Koji Matsuoka koji.matsuoka...@renesas.com Signed-off-by: Yoshihiro Kaneko ykaneko0...@gmail.com

[PATCH v3 0/2] V4L2: add CCF support to v4l2_clk

2015-01-31 Thread Guennadi Liakhovetski
Hi, A v3 of a CCF support for v4l2_clk. Comments addressed. Thanks Guennadi -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/2] V4L: remove clock name from v4l2_clk API

2015-01-31 Thread Guennadi Liakhovetski
All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v3: .id field removed from the struct. Since CCF clocks won't

Re: [PATCH 6/8] WmT: adv7604 driver compatibility

2015-01-31 Thread Guennadi Liakhovetski
Hi Wills, Thanks for the patch. First and foremost, the title of the patch is wrong. This patch does more than just adding some adv7604 compatibility. It's adding pad-level API to soc-camera. This is just a rough review. I'm not an expert in media-controller / pad-level API, I hope someone

[PATCH v3 2/2] V4L: add CCF support to the v4l2_clk API

2015-01-31 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v3: 1. return -EPROBE_DEFER if it's returned by clk_get() 2. handle the case of disabled CCF in kernel configuration 3. use clk_prepare_enable() and clk_unprepare_disable() drivers/media/v4l2-core/v4l2-clk.c | 48

Re: [PATCH 5/8] media: rcar_vin: Add RGB888_1X24 input format support

2015-01-29 Thread Guennadi Liakhovetski
Hi Sergei, On Thu, 29 Jan 2015, Sergei Shtylyov wrote: Hello. On 01/29/2015 07:19 PM, William Towle wrote: This adds V4L2_MBUS_FMT_RGB888_1X24 input format support which is used by the ADV7612 chip. Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com I

Re: [PATCH 5/8] media: rcar_vin: Add RGB888_1X24 input format support

2015-01-29 Thread Guennadi Liakhovetski
On Thu, 29 Jan 2015, Sergei Shtylyov wrote: On 01/29/2015 11:19 PM, Guennadi Liakhovetski wrote: This adds V4L2_MBUS_FMT_RGB888_1X24 input format support which is used by the ADV7612 chip. Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com

Re: [PATCH 5/8] media: rcar_vin: Add RGB888_1X24 input format support

2015-01-29 Thread Guennadi Liakhovetski
On Thu, 29 Jan 2015, Sergei Shtylyov wrote: Hello. On 01/29/2015 09:18 PM, Guennadi Liakhovetski wrote: This adds V4L2_MBUS_FMT_RGB888_1X24 input format support which is used by the ADV7612 chip. Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com I

Re: [PATCH 1/2] media: v4l2-image-sizes.h: add SVGA, XGA and UXGA size definitions

2015-01-28 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 28 Jan 2015, Josh Wu wrote: Hi, Guennadi On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote: Hi Josh, On Thu, 27 Nov 2014, Josh Wu wrote: Hi, Guennadi On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 25 Nov 2014, Josh Wu

[GIT FIXES FOR v3.19] soc-camera: capabilities warning fix

2015-01-20 Thread Guennadi Liakhovetski
to 52e83770291eb575fec552396a63e95bea9f1557: rcar_vin: Update device_caps and capabilities in querycap (2015-01-20 23:22:17 +0100) Guennadi Liakhovetski (1): soc-camera: fix device capabilities in multiple camera host drivers Nobuhiro Iwamatsu (1

[PATCH] soc-camera: fix device capabilities in multiple camera host drivers

2015-01-19 Thread Guennadi Liakhovetski
camera host drivers. Reported-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Only compile tested on one platform. Would be nice to have a slightly wider test coverage. I'll try to do some more verification too, then send out as a fix

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
Hi, On Mon, 19 Jan 2015, William Towle wrote: On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: Well, I thought that too. Will's submission from last week has that change: http://thread.gmane.org/gmane.linux.drivers.video-input

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
On Mon, 19 Jan 2015, Ben Hutchings wrote: On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so

Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-18 Thread Guennadi Liakhovetski
On Wed, 7 Jan 2015, Guennadi Liakhovetski wrote: Hi Andy, Thanks for the patch. Will queue for the next pull request. Actually no, I won't. I don't think there's currently a but there. the pointer isn't dereferenced before being checked. Only an address of a field in a struct, it's

Re: [PATCH 2/4] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stopping.

2015-01-18 Thread Guennadi Liakhovetski
Hi Ian, Apparently, I wasn't quite right in my reply to patch 1 from this series. It seems to be related to this one and to Hans' comment below. Taking it into account, it seems you shouldn't remove cancelled active buffers from the list without calling vb2_buffer_done(buf-vb,

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-18 Thread Guennadi Liakhovetski
On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv-queue_buf[] is handled as

Re: [RFC PATCH 1/5] media: rcar_vin: Dont aggressively retire buffers

2015-01-18 Thread Guennadi Liakhovetski
Hi Ben, Sorry for a long delay. The patch looks good to me, although I'll extend it a bit by also removing the comment above the deleted loop - it's no longer relevant. Thanks Guennadi On Thu, 18 Dec 2014, Ben Hutchings wrote: From: Ian Molton ian.mol...@codethink.co.uk

Re: [RFC PATCH 3/5] media: rcar_vin: Fix race condition terminating stream

2015-01-18 Thread Guennadi Liakhovetski
On Thu, 18 Dec 2014, Sergei Shtylyov wrote: Hello. On 12/18/2014 05:49 PM, Ben Hutchings wrote: From: Ian Molton ian.mol...@codethink.co.uk This patch fixes a race condition whereby a frame being captured may generate an interrupt between requesting capture to halt and freeing

Re: Media Summit planning for 2015 - was: Re: ELC 2015 - March - San Jose

2015-01-09 Thread Guennadi Liakhovetski
Hi Mauro, On Thu, 8 Jan 2015, Mauro Carvalho Chehab wrote: Em Thu, 08 Jan 2015 22:29:43 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On 01/08/2015 08:19 PM, Mauro Carvalho Chehab wrote: Hi all, I want to do the media planning for 2015. As we've agreed last year, we're

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-08 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 7 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote: Hi Josh, On Tue, 6 Jan 2015, Josh Wu wrote: Hi, Guennadi After look deep into this patch, I found you miss one line that should be changed as well. It's

Re: [PATCH] [media] soc_camera: avoid potential null-dereference

2015-01-07 Thread Guennadi Liakhovetski
Hi Andy, Thanks for the patch. Will queue for the next pull request. Regards Guennadi On Wed, 7 Jan 2015, Andy Shevchenko wrote: We have to check the pointer before dereferencing it. Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com ---

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-06 Thread Guennadi Liakhovetski
even further, I'll update the patch. Did you only test this patch or both? Thanks Guennadi On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote: All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT

Re: [PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-05 Thread Guennadi Liakhovetski
Hi Josh, On Mon, 5 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote: All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. This patch

Re: [PATCH v2 2/2] V4L2: add CCF support to the v4l2_clk API

2015-01-05 Thread Guennadi Liakhovetski
On Mon, 5 Jan 2015, Josh Wu wrote: Hi, Guennadi On 1/3/2015 4:18 AM, Guennadi Liakhovetski wrote: From aeaee56e04d023f3a019d2595ef5128015acdb06 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski g.liakhovet...@gmx.de Date: Fri, 2 Jan 2015 12:26:41 +0100 Subject: [PATCH 2/2] V4L2

Re: [PATCH v2 2/2] V4L2: add CCF support to the v4l2_clk API

2015-01-04 Thread Guennadi Liakhovetski
On Sun, 4 Jan 2015, Laurent Pinchart wrote: Hi Guennadi, Thank you for the patch. On Friday 02 January 2015 21:18:41 Guennadi Liakhovetski wrote: From aeaee56e04d023f3a019d2595ef5128015acdb06 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski g.liakhovet...@gmx.de Date: Fri, 2 Jan

[PATCH v2 2/2] V4L2: add CCF support to the v4l2_clk API

2015-01-02 Thread Guennadi Liakhovetski
From aeaee56e04d023f3a019d2595ef5128015acdb06 Mon Sep 17 00:00:00 2001 From: Guennadi Liakhovetski g.liakhovet...@gmx.de Date: Fri, 2 Jan 2015 12:26:41 +0100 Subject: [PATCH 2/2] V4L2: add CCF support to the v4l2_clk API V4L2 clocks, e.g. used by camera sensors for their master clock, do not have

[PATCH 0/2] V4L2: add CCF support to v4l2_clk

2015-01-02 Thread Guennadi Liakhovetski
Hi, This is an attempt to implement CCF support for v4l2_clk to be able to use e.g. DT-based clocks. Beware - completely untested! Josh, could you please see, whether you can use this as a starting point? Thanks Guennadi -- To unsubscribe from this list: send the line unsubscribe linux-media

[PATCH 2/2] V4L2: add CCF support to the v4l2_clk API

2015-01-02 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/v4l2-core/v4l2-clk.c | 76 +- include/media/v4l2-clk.h | 2 + 2 files changed, 68 insertions(+), 10 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-clk.c b/drivers/media

[PATCH 1/2] V4L: remove clock name from v4l2_clk API

2015-01-02 Thread Guennadi Liakhovetski
All uses of the v4l2_clk API so far only register one clock with a fixed name. This allows us to get rid of it, which also will make CCF and DT integration easier. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/platform/soc_camera/soc_camera.c | 6 +++--- drivers

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Guennadi Liakhovetski
Hi Laurent, First of all, sorry, I am currently on a holiday, so, replies are delayed, real work (reviewing or anything else) is impossible. On Tue, 30 Dec 2014, Laurent Pinchart wrote: Hi Guennadi, On Friday 26 December 2014 11:38:11 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Guennadi Liakhovetski
On Tue, 30 Dec 2014, Josh Wu wrote: [snip] And until omap1 is in the mainline we cannot drop v4l2_clk. s/until/as lonh as/ So I think the better way right now for ov2640 driver is still request both the v4l2_clock: mclk, and the clock: xvclk in probe(). In that way, we can take our time

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 26 Dec 2014, Laurent Pinchart wrote: Hi Josh, On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22 Dec 2014, Josh Wu wrote: On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Guennadi Liakhovetski
On Fri, 26 Dec 2014, Laurent Pinchart wrote: Hi Guennadi, On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-24 Thread Guennadi Liakhovetski
Hi Josh, On Mon, 22 Dec 2014, Josh Wu wrote: Hi, Guennadi On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014, Josh Wu wrote: Hi, Guennadi Thanks for the review. On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks

<    1   2   3   4   5   6   7   8   9   10   >