Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Stephen Warren wrote: > On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: > > Hi Steffen > > > > Sorry for chiming in so late in the game, but I've long been wanting to > > have a look at this and compare with what we do for V4L2, so, thi

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-08 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Sascha Hauer wrote: > On Fri, Oct 05, 2012 at 05:41:00PM +0200, Guennadi Liakhovetski wrote: > > Hi Sascha > > > > > > + > > > > + ceu0: ceu@0xfe91 { > > > > + compatible = "renesas,sh-mob

Re: [PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-10-08 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Anatolij Gustschin wrote: > On Fri, 5 Oct 2012 16:31:58 +0200 (CEST) > Guennadi Liakhovetski wrote: > > > Hi Anatolij > > > > On Fri, 5 Oct 2012, Anatolij Gustschin wrote: > > > > > Hi Guennadi, > > > > >

[PATCH] media: soc-camera: remove superfluous JPEG checking

2012-10-05 Thread Guennadi Liakhovetski
user-provided line length by the image height to obtain a frame buffer size estimate. The original version of the "media: soc_camera: don't clear pix->sizeimage in JPEG mode" patch was correct and my amendment, adding these two checks was superfluous. Signed-off-by: Guennadi Liak

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-05 Thread Guennadi Liakhovetski
Hi Sascha On Fri, 5 Oct 2012, Sascha Hauer wrote: > Hi Guennadi, > > Some comments inline. > > > On Thu, Sep 27, 2012 at 04:07:23PM +0200, Guennadi Liakhovetski wrote: > > This patch adds a document, describing common V4L2 device tree bindings. > > > >

[PATCH] media: soc-camera: update documentation

2012-10-05 Thread Guennadi Liakhovetski
Update soc-camera documentation to reflect the current camera host API and the use of the common V4L2 subdev API. Signed-off-by: Guennadi Liakhovetski --- Documentation/video4linux/soc-camera.txt | 146 +++--- 1 files changed, 75 insertions(+), 71 deletions(-) diff

Re: [PATCH 00/14] V4L2 DT support

2012-10-05 Thread Guennadi Liakhovetski
e. > Patch failed at 0007 media: soc-camera: support deferred probing of clients > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching ru

Re: [PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-10-05 Thread Guennadi Liakhovetski
Hi Anatolij On Fri, 5 Oct 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Wed, 3 Oct 2012 00:09:29 +0200 (CEST) > Guennadi Liakhovetski wrote: > > > Hi Anatolij > > > > > > > +#if !defined(CONFIG_VIDEO_MPC52xx_CSI) && \ >

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-05 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Hans Verkuil wrote: > On Fri October 5 2012 11:43:27 Guennadi Liakhovetski wrote: > > On Wed, 3 Oct 2012, Rob Herring wrote: > > > > > On 10/02/2012 09:33 AM, Guennadi Liakhovetski wrote: > > > > Hi Rob > > > >

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-05 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Hans Verkuil wrote: > On Fri October 5 2012 12:58:21 Guennadi Liakhovetski wrote: > > On Fri, 5 Oct 2012, Hans Verkuil wrote: [snip] > > > One area that I do not yet completely understand is the i2c bus > > > notifications > > > (or

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-05 Thread Guennadi Liakhovetski
On Fri, 5 Oct 2012, Hans Verkuil wrote: > On Tue October 2 2012 12:13:20 Sylwester Nawrocki wrote: > > Hi Guennadi, > > > > On 10/02/2012 11:49 AM, Guennadi Liakhovetski wrote: > > >>> + if (!of_property_read_u32_

[PATCH v4] media: add a VEU MEM2MEM format conversion and scaling driver

2012-10-05 Thread Guennadi Liakhovetski
for VEU. So far only conversion from NV12 to RGB565 is supported. Further functionality shall be added in the future. This driver is based on a VEU vidix driver by Magnus Damm. Signed-off-by: Guennadi Liakhovetski --- v4: - remove redundant checks - embed struct video_device - move

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-05 Thread Guennadi Liakhovetski
On Wed, 3 Oct 2012, Rob Herring wrote: > On 10/02/2012 09:33 AM, Guennadi Liakhovetski wrote: > > Hi Rob > > > > On Tue, 2 Oct 2012, Rob Herring wrote: > > > >> On 09/27/2012 09:07 AM, Guennadi Liakhovetski wrote: > >>> This patch adds a docum

[PATCH v3] media: add a VEU MEM2MEM format conversion and scaling driver

2012-10-05 Thread Guennadi Liakhovetski
for VEU. So far only conversion from NV12 to RGB565 is supported. Further functionality shall be added in the future. This driver is based on a VEU vidix driver by Magnus Damm. Signed-off-by: Guennadi Liakhovetski --- v3: - compliance test is now happy apart from 2 warnings - CREATE_BUFS not

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Guennadi Liakhovetski
i.e. of the board? Can the same display controller on one board require interlaced data and on another board - progressive? BTW, I'm not very familiar with display interfaces, but for interlaced you probably sometimes use a field signal, whose polarity you also want to specify here? We use a &quo

RE: Previewing PAL fields on framebuffer

2012-10-03 Thread Guennadi Liakhovetski
omplish this. Sorry, I don't know what file you mean. In any case you'd have to implement overlay support in the mx3fb.c framebuffer driver. Thanks Guennadi > Cheers, > Alex > > -Original Message- > From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] &

Re: Previewing PAL fields on framebuffer

2012-10-03 Thread Guennadi Liakhovetski
but the > support "community" is a bit quiet. > > Thanks > > Alex Pollard > Software Engineer > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscr

mail lost due to a hard-drive crash

2012-10-02 Thread Guennadi Liakhovetski
) But if anyone thinks, that I missed their mail, please, re-send. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

Re: [PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-10-02 Thread Guennadi Liakhovetski
r does in it is totally its own business. Nobody says, that you have to issue I2C commands in it. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-medi

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-02 Thread Guennadi Liakhovetski
Hi Rob On Tue, 2 Oct 2012, Rob Herring wrote: > On 09/27/2012 09:07 AM, Guennadi Liakhovetski wrote: > > This patch adds a document, describing common V4L2 device tree bindings. > > > > Co-authored-by: Sylwester Nawrocki > > Signed-off-by: Guennadi Liakhovetski

Re: [PATCH] media: add a VEU MEM2MEM format conversion and scaling driver

2012-10-02 Thread Guennadi Liakhovetski
Hi Hans On Tue, 2 Oct 2012, Hans Verkuil wrote: > On Mon 1 October 2012 19:51:18 Guennadi Liakhovetski wrote: > > Hi Hans > > > > Thanks for the review. As you might have seen, I just posted v2 of this > > driver. In it I addressed almost all your comments. As for th

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-02 Thread Guennadi Liakhovetski
On Tue, 2 Oct 2012, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 10/02/2012 11:49 AM, Guennadi Liakhovetski wrote: > >>> + if (!of_property_read_u32_array(node, "data-lanes", data_lanes, > >>> + ARRAY

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-02 Thread Guennadi Liakhovetski
Hi Sylwester On Mon, 1 Oct 2012, Sylwester Nawrocki wrote: > On 09/27/2012 04:07 PM, Guennadi Liakhovetski wrote: > > Add a V4L2 OF parser, implementing bindings, documented in > > Documentation/devicetree/bindings/media/v4l2.txt. > > > > Signed-of

Re: [PATCH] media: add a VEU MEM2MEM format conversion and scaling driver

2012-10-01 Thread Guennadi Liakhovetski
Hi Hans Thanks for the review. As you might have seen, I just posted v2 of this driver. In it I addressed almost all your comments. As for the rest: On Tue, 11 Sep 2012, Hans Verkuil wrote: > On Tue 11 September 2012 15:01:19 Guennadi Liakhovetski wrote: [snip] > > +struct s

[PATCH v2] media: add a VEU MEM2MEM format conversion and scaling driver

2012-10-01 Thread Guennadi Liakhovetski
for VEU. So far only conversion from NV12 to RGB565 is supported. Further functionality shall be added in the future. This driver is based on a VEU vidix driver by Magnus Damm. Signed-off-by: Guennadi Liakhovetski --- v2: addressed comments from Hans (thanks!), namely: - taking into account

Re: cron job: media_tree daily build: ERRORS

2012-10-01 Thread Guennadi Liakhovetski
for ‘sh_mobile_ceu_host_ops.set_livecrop’) > [enabled by default > > -- > > Regards, > Sylwester > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo inf

Re: [PATCH 3/4] [media] marvell-ccic: mmp: add soc camera support on marvell-ccic mmp-driver

2012-10-01 Thread Guennadi Liakhovetski
oc_host = &mcam->soc_host; > +#else > + struct mmp_camera_platform_data *pdata = cam->pdev->dev.platform_data; > +#endif > > mmpcam_remove_device(cam); > - free_irq(cam->irq, mcam); > + devm_free_irq(&cam->pdev->dev, cam->irq,

Re: [PATCH 2/4] [media] marvell-ccic: core: add soc camera support on marvell-ccic mcam-core

2012-09-29 Thread Guennadi Liakhovetski
nd re-use the common stuff. > That, I think, is how I'd like to go toward a cleaner, more reviewable, > more maintainable solution. Make sense? Definitely! Thanks Guennadi > Thanks, > > jon > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://

Re: [PATCH 1/4] [media] mmp: add register definition for marvell ccic

2012-09-29 Thread Guennadi Liakhovetski
SDH0APMU_REG(0x054) > #define APMU_SDH1APMU_REG(0x058) > #define APMU_USB APMU_REG(0x05c) > -- > 1.7.0.4 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 0/4] [media] marvell-ccic: add soc camera support on marvell-ccic

2012-09-29 Thread Guennadi Liakhovetski
buffers support in > DMA_CONTIG mode > > > Thanks > Albert Wang > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Guennadi Liakhovetski
On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Fri, 28 Sep 2012 14:33:34 +0200 (CEST) > Guennadi Liakhovetski wrote: > ... > > > @@ -235,12 +238,32 @@ static int mt9v022_s_stream(struct v4l2_subdev *sd, > > > int enable)

[PATCH 5/7] media: mx2_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx2_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx2_camera.c |5 +++-

[PATCH 1/7] media: sh_mobile_ceu_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in sh_mobile_ceu_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c

[PATCH 6/7] media: mx1_camera: use the default .set_crop() implementation

2012-09-28 Thread Guennadi Liakhovetski
.set_crop() implementation in mx1_camera is identical with the default. Remove the copy to switch to using the default stab. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx1_camera.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a

[PATCH 0/7] soc-camera and sh_vou cropping constification fixes

2012-09-28 Thread Guennadi Liakhovetski
pull request. Thanks Guennadi Guennadi Liakhovetski (7): media: sh_mobile_ceu_camera: fix const cropping related warnings media: pxa_camera: fix const cropping related warnings media: sh_vou: fix const cropping related warnings media: mx3_camera: fix const cropping related warnings

[PATCH 7/7] media: omap1_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in omap1_camera. Fix them by adjusting a function declaration. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/omap1_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2

[PATCH 3/7] media: sh_vou: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in sh_vou. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/sh_vou.c |3 ++- 1 files changed, 2

[PATCH 4/7] media: mx3_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in mx3_camera. Fix them by cleanly separating writable and read-only variables in cropping operations. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/mx3_camera.c |5 +++-

[PATCH 2/7] media: pxa_camera: fix const cropping related warnings

2012-09-28 Thread Guennadi Liakhovetski
A recent commit "[media] v4l2: make vidioc_s_crop const" introduced warnings in pxa_camera.c. Fix them by adjusting a function declaration. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/pxa_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletion

Re: [PATCH] mt9v022: support required register settings in snapshot mode

2012-09-28 Thread Guennadi Liakhovetski
ring running streaming, right? Then how does this patch help you with that? Thanks Guennadi > > if (reg_write(client, MT9V022_CHIP_CONTROL, mt9v022->chip_control) < 0) > return -EIO; > @@ -652,6 +675,8 @@ static int mt9v022_video_probe(struct i2c_client *client)

Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Guennadi Liakhovetski
Hi Eric On Fri, 28 Sep 2012, Guennadi Liakhovetski wrote: > Hi Anatolij > > I can take this patch, but we need an ack from a PXA / ARM maintainer. Could we have your ack, please? Thanks Guennadi > On Fri, 28 Sep 2012, Anatolij Gustschin wrote: > > > Set "y_sk

Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Guennadi Liakhovetski
0..4056180 > --- /dev/null > +++ b/include/media/mt9v022.h > @@ -0,0 +1,16 @@ > +/* > + * mt9v022 sensor > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * publis

Re: [PATCH 2/2] V4L: soc_camera: disable I2C subdev streamon for mpc52xx_csi

2012-09-28 Thread Guennadi Liakhovetski
any further I2C commands, while streaming, their drivers have to do that themselves. And not only for stream-on, there are many operations, that are allowed during streaming. Thanks Guennadi > if (!ret) > v4l2_subdev_call(sd, video, s_stream, 1); > +#endif >

[PATCH 15/14] OF: define of_*_cmp() macros also if CONFIG_OF isn't set

2012-09-28 Thread Guennadi Liakhovetski
of_*_cmp() macros do not depend on any OF functions and can be defined also if CONFIG_OF isn't set. Also include linux/string.h, required by those macros. Signed-off-by: Guennadi Liakhovetski --- These definitions are also required for "# CONFIG_OF is not set" builds. inc

Re: [PULL] soc-camera 3.7-rc7 fixes

2012-09-27 Thread Guennadi Liakhovetski
Mauro, that should have been "3.6-rc7" of course... Please don't delay until 3.7-rc7;-) I think, I'll rename the branch _after_ you pull it. Thanks Guennadi On Tue, 25 Sep 2012, Guennadi Liakhovetski wrote: > Hi Mauro > > There go the 3 fixes, that popped up (

[PATCH 03/14] OF: make a function pointer argument const

2012-09-27 Thread Guennadi Liakhovetski
The "struct device_node *" argument of of_parse_phandle_*() can be const. Signed-off-by: Guennadi Liakhovetski --- drivers/of/base.c |4 ++-- include/linux/of.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c ind

[PATCH 02/14] of: add a dummy inline function for when CONFIG_OF is not defined

2012-09-27 Thread Guennadi Liakhovetski
If CONFIG_OF isn't defined, no declaration of of_get_parent will be found and compilation can fail. This patch adds a dummy inline function definition to fix the problem. Signed-off-by: Guennadi Liakhovetski --- include/linux/of.h |5 + 1 files changed, 5 insertions(+), 0 dele

[PATCH 01/14] i2c: add dummy inline functions for when CONFIG_OF_I2C(_MODULE) isn't defined

2012-09-27 Thread Guennadi Liakhovetski
If CONFIG_OF_I2C and CONFIG_OF_I2C_MODULE are undefined no declaration of of_find_i2c_device_by_node and of_find_i2c_adapter_by_node will be available. Add dummy inline functions to avoid compilation breakage. Signed-off-by: Guennadi Liakhovetski Cc: Ben Dooks --- include/linux/of_i2c.h | 12

[PATCH 00/14] V4L2 DT support

2012-09-27 Thread Guennadi Liakhovetski
nt to depend on the clock framework progress, we could implement V4L2 generic functions to do the same until clocks become available. 2. the two driver-specific DT properties in patch 13/14 are just an RFC and can be modified / discussed. Thanks Guennadi Guennadi Liakhovetski (14): i2c: add dummy i

[PATCH 11/14] media: sh-mobile-ceu-camera: runtime PM suspending doesn't have to be synchronous

2012-09-27 Thread Guennadi Liakhovetski
In both error and clean up cases there is no need to wait for runtime PM to finish suspending the device. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 09/14] media: mt9t112: support deferred probing

2012-09-27 Thread Guennadi Liakhovetski
If .probe() is called without our private data, this might mean, that the host driver hasn't probed yet. Defer probing in this case. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/soc_camera/mt9t112.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --

[PATCH 07/14] media: soc-camera: support deferred probing of clients

2012-09-27 Thread Guennadi Liakhovetski
rface. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/soc_camera.c | 255 ++-- include/media/soc_camera.h |2 + 2 files changed, 197 insertions(+), 60 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/dr

[PATCH 06/14] media: soc-camera: prepare for asynchronous client probing

2012-09-27 Thread Guennadi Liakhovetski
be probed and / or used with it. However, if a client probes at a different time, there is no way to know when to attach it to and when to detach it from the host. To solve this we allow the client to decide itself, when it hae to be attached and detached. Signed-off-by: Guennadi Liakhovetski --

[PATCH 10/14] media: soc-camera: support OF cameras

2012-09-27 Thread Guennadi Liakhovetski
ff-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/soc_camera.c | 337 ++-- include/media/soc_camera.h |5 + 2 files changed, 326 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/pla

[PATCH 04/14] media: add V4L2 DT binding documentation

2012-09-27 Thread Guennadi Liakhovetski
This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki Signed-off-by: Guennadi Liakhovetski --- Documentation/devicetree/bindings/media/v4l2.txt | 162 ++ 1 files changed, 162 insertions(+), 0 deletions(-) create mode

[PATCH 14/14] media: sh_mobile_ceu_camera: support all standard V4L2 DT properties

2012-09-27 Thread Guennadi Liakhovetski
Additionally to the basic DT support, added to the driver in previous patches, this patch implements complete interface configuration from DT. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 126 1 files changed, 78 insertions

[PATCH 13/14] media: sh-mobile-ceu-driver: support max width and height in DT

2012-09-27 Thread Guennadi Liakhovetski
Some CEU implementations have non-standard (larger) maximum supported width and height values. Add two OF properties to specify them. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 19 +++ 1 files changed, 19 insertions(+), 0

[PATCH 08/14] media: soc-camera: use managed devm_regulator_bulk_get()

2012-09-27 Thread Guennadi Liakhovetski
Using device-managed devm_regulator_bulk_get() eliminates the need to release regulators explicitly. Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/soc_camera.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform

[PATCH 05/14] media: add a V4L2 OF parser

2012-09-27 Thread Guennadi Liakhovetski
Add a V4L2 OF parser, implementing bindings, documented in Documentation/devicetree/bindings/media/v4l2.txt. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/Makefile |3 + drivers/media/v4l2-core/v4l2-of.c | 190 + include/media/v4l2

[PATCH 12/14] media: sh-mobile-ceu-camera: add primitive OF support

2012-09-27 Thread Guennadi Liakhovetski
Add an OF hook to sh_mobile_ceu_camera.c, no properties so far. Booting with DT also requires platform data to be optional. Signed-off-by: Guennadi Liakhovetski --- .../platform/soc_camera/sh_mobile_ceu_camera.c | 34 ++-- 1 files changed, 24 insertions(+), 10 deletions

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-25 Thread Guennadi Liakhovetski
Hi Sylwester Ok, looks like there are no more comments coming, so, we can submit a new version:-) Thanks for your comments: On Tue, 11 Sep 2012, Sylwester Nawrocki wrote: > Hi Guennadi, > > On 09/11/2012 05:51 PM, Guennadi Liakhovetski wrote: > > This patch adds a document, de

[PULL] soc-camera 3.7-rc7 fixes

2012-09-25 Thread Guennadi Liakhovetski
ivers/media/video/soc_camera.c: fix error return code drivers/media/video/mx2_camera.c |4 +++- drivers/media/video/ov2640.c |5 + drivers/media/video/soc_camera.c |3 ++- 3 files changed, 10 insertions(+), 2 deletions(-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freel

Re: [PATCH] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Guennadi Liakhovetski
On Sun, 23 Sep 2012, Frank Schäfer wrote: > Am 24.09.2012 00:33, schrieb Guennadi Liakhovetski: > > On Sun, 23 Sep 2012, Frank SchÀfer wrote: > > > >> We currently don't select the register bank in ov2640_s_ctrl, so we can > >> end up > >> writing

Re: [PATCH] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Guennadi Liakhovetski
); > + if (ret < 0) > + return ret; > > switch (ctrl->id) { > case V4L2_CID_VFLIP: > -- > 1.7.10.4 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this li

Re: Fwd: [PATCH 1/14] drivers/media/platform/soc_camera/soc_camera.c: fix error return code

2012-09-23 Thread Guennadi Liakhovetski
;s occurring too often in real life, so, I didn't bother sending a separate fix:-) But yes, let's fix it properly. Please, update the other patch to mx2_camera and I'll send a "fixes" pull request with these two and an ov2640 fix. Thanks Guennadi > > /* At

Re: [PATCH v2 3/3] ov2640: simplify single register writes

2012-09-23 Thread Guennadi Liakhovetski
On Sun, 23 Sep 2012, Frank Schäfer wrote: > Am 23.09.2012 23:43, schrieb Guennadi Liakhovetski: > > On Sun, 23 Sep 2012, Frank Schäfer wrote: > > > >> Signed-off-by: Frank Schäfer > >> --- > >> drivers/media/i2c/soc_camera/ov2640.c | 17

Re: Fwd: [PATCH 2/14] drivers/media/platform/soc_camera/mx2_camera.c: fix error return code

2012-09-23 Thread Guennadi Liakhovetski
} > } > > pcdev->soc_host.drv_name = MX2_CAM_DRV_NAME, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.

Re: [PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Guennadi Liakhovetski
On Sun, 23 Sep 2012, Frank Schäfer wrote: > Am 23.09.2012 23:21, schrieb Guennadi Liakhovetski: > > Hi Frank > > > > On Sun, 23 Sep 2012, Frank Schäfer wrote: > > > >> We currently don't select the register bank in ov2640_s_ctrl, so we can > >> e

Re: [PATCH v2 3/3] ov2640: simplify single register writes

2012-09-23 Thread Guennadi Liakhovetski
u8 val; > > - regval.reg_num = BANK_SEL; > - regval.value = BANK_SEL_SENS; > - ret = ov2640_write_array(client, ®val); > + ret = ov2640_write_single(client, BANK_SEL, BANK_SEL_SENS); > if (ret < 0) > return ret; > > -

Re: [PATCH v2 2/3] ov2640: add support for V4L2_MBUS_FMT_YUYV8_2X8, V4L2_MBUS_FMT_RGB565_2X8_BE

2012-09-23 Thread Guennadi Liakhovetski
9,11 +942,13 @@ static int ov2640_try_fmt(struct v4l2_subdev *sd, > mf->field = V4L2_FIELD_NONE; > > switch (mf->code) { > + case V4L2_MBUS_FMT_RGB565_2X8_BE: > case V4L2_MBUS_FMT_RGB565_2X8_LE: > mf->colorspace = V4L2_COLO

Re: [PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Guennadi Liakhovetski
Guennadi > + if (ret < 0) > + return ret; > + > switch (ctrl->id) { > case V4L2_CID_VFLIP: > val = ctrl->val ? REG04_VFLIP_IMG : 0x00; > -- > 1.7.10.4 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://ww

Re: mt9t031 driver support on OMAP3 system

2012-09-22 Thread Guennadi Liakhovetski
e you more specifically. > Thanks, Pete   Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] media: sh-vou: fix compilation breakage

2012-09-19 Thread Guennadi Liakhovetski
unction 'sh_vou_poll': drivers/media/platform/sh_vou.c:1242: error: 'vdev' undeclared (first use in this function) make[2]: *** [drivers/media/platform/sh_vou.o] Error 1 Add missing variable definitions. Signed-off-by: Guennadi Liakhovetski --- This is a fix for 3.7 drivers/me

Re: [RFC] Processing context in the V4L2 subdev and V4L2 controls API ?

2012-09-18 Thread Guennadi Liakhovetski
ramefmt::colorspace field > to select between capture/preview in a device or using 32-bit integer > control where upper 16-bits are used for pixel width and lower 16 for > pixel height. This may suggest there something missing at the API. > > Any suggestions, critics, please ?... :) >

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, javier Martin wrote: > Hi Shawn, > > On 17 September 2012 11:21, Guennadi Liakhovetski > wrote: > > On Mon, 17 Sep 2012, Shawn Guo wrote: > > > >> It changes the driver to use platform_device_id rather than cpu_is_xxx > >> to dete

Re: [PATCH 14/34] dma: ipu: rename mach/ipu.h to include/linux/dma/ipu-dma.h

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: > The header ipu.h really belongs to dma subsystem rather than imx > platform. Rename it to ipu-dma.h and put it into include/linux/dma/. > > Signed-off-by: Shawn Guo > Cc: Vinod Koul > Cc: Guennadi Liakhovetski > Cc: Florian To

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

2012-09-17 Thread Guennadi Liakhovetski
ned-off-by: Shawn Guo > Cc: Guennadi Liakhovetski > Cc: linux-media@vger.kernel.org Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > arch/arm/mach-imx/clk-imx25.c |6 +- > arch/arm/mach-imx/clk-imx27.c |6 +- > arc

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

2012-09-17 Thread Guennadi Liakhovetski
On Mon, 17 Sep 2012, Shawn Guo wrote: > Use managed functions to clean up the error handling code and function > mx2_camera_remove(). Along with the change, a few variables get removed > from struct mx2_camera_dev. > > Signed-off-by: Shawn Guo > Cc: Guennadi Liakhovetski

Re: [PATCH 12/34] media: mx1_camera: remove the driver

2012-09-17 Thread Guennadi Liakhovetski
known the breakage [1], but > no one shows the interest to bring it back to work. Thus it becomes > a piece of unmaintained code, so let's remove it. > > [1] https://lkml.org/lkml/2012/2/9/171 > > Signed-off-by: Shawn Guo > Cc: Paulius Zaleckas > Cc: Guennadi L

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

2012-09-17 Thread Guennadi Liakhovetski
e EMMA > mandatory). It should have been removed together with the commit. > Remove it now. > > Signed-off-by: Shawn Guo > Cc: Guennadi Liakhovetski > Cc: linux-media@vger.kernel.org Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > drivers/media/video/mx2_

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-12 Thread Guennadi Liakhovetski
On Wed, 12 Sep 2012, Stephen Warren wrote: > On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote: > > Hi Stephen > > > > On Wed, 12 Sep 2012, Stephen Warren wrote: > > > >> On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote: > >>> This patch add

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-12 Thread Guennadi Liakhovetski
Hi Stephen On Wed, 12 Sep 2012, Stephen Warren wrote: > On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote: > > This patch adds a document, describing common V4L2 device tree bindings. > > > > Co-authored-by: Sylwester Nawrocki > > Signed-off-by: Guennadi Liakhove

[PATCH] media: add V4L2 DT binding documentation

2012-09-11 Thread Guennadi Liakhovetski
This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki Signed-off-by: Guennadi Liakhovetski --- Documentation/devicetree/bindings/media/v4l2.txt | 143 ++ 1 files changed, 143 insertions(+), 0 deletions(-) create mode

Re: [RFC v5] V4L DT bindings

2012-09-11 Thread Guennadi Liakhovetski
Hi Stephen Thanks for the review. On Wed, 5 Sep 2012, Stephen Warren wrote: > On 09/05/2012 04:57 AM, Guennadi Liakhovetski wrote: > > Hi all > > > > Version 5 of this RFC is a result of a discussion of its version 4, which > > took place during the recent Linux

[PATCH] media: add a VEU MEM2MEM format conversion and scaling driver

2012-09-11 Thread Guennadi Liakhovetski
for VEU. So far only conversion from NV12 to RGB565 is supported. Further functionality shall be added in the future. This driver is based on a VEU vidix driver by Magnus Damm. Signed-off-by: Guennadi Liakhovetski --- Tested on Linux and Android ;-) drivers/media/platform/Kconfig |9

[PATCH] media: mem2mem: make reference to struct m2m_ops in the core const

2012-09-11 Thread Guennadi Liakhovetski
The mem2mem core doesn't change struct m2m_ops, provided by the driver, make references to it const. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/v4l2-mem2mem.c |4 ++-- include/media/v4l2-mem2mem.h |2 +- 2 files changed, 3 insertions(+), 3 dele

[PATCH] media: use list_first_entry() instead of open-coding in mem2mem core

2012-09-11 Thread Guennadi Liakhovetski
Using list_first_entry() improves code readability and makes it less error-prone. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/v4l2-mem2mem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media

[PULL] soc-camera 3.7 set 2

2012-09-11 Thread Guennadi Liakhovetski
form/soc_camera/mx2_camera.c |6 ++-- drivers/media/platform/soc_camera/soc_camera.c | 37 --- 2 files changed, 10 insertions(+), 33 deletions(-) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe

Re: [PATCH 3/3] mt9v022: set y_skip_top field to zero

2012-09-11 Thread Guennadi Liakhovetski
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) > Guennadi Liakhovetski wrote: > > > On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > > > > > Set "y_skip_top" to zero and remove comment as I do not see thi

Re: [PATCH 1/3] mt9v022: add v4l2 controls for blanking and other register settings

2012-09-11 Thread Guennadi Liakhovetski
Hi Anatolij On Tue, 28 Aug 2012, Anatolij Gustschin wrote: > Hi Guennadi, > > On Fri, 24 Aug 2012 23:23:37 +0200 (CEST) > Guennadi Liakhovetski wrote: > ... > > > Every time the sensor is reset, it resets this register. Without setting > > > the register after

Re: [PATCH] drivers: media: video: Add support for Aptina ar0130 sensor

2012-09-09 Thread Guennadi Liakhovetski
ude Do you really need the soc_camera.h header? From a quick glance I didn't find any uses of the soc-camera API. If I missed them and you really are using the API, the driver should probably go under drivers/media/i2c/soc_camera/ and be submitted to the mainline via my tree. Since you&#x

Re: [PATCH 1/2] [media] soc_camera: Use devm_kzalloc function

2012-09-05 Thread Guennadi Liakhovetski
era_device_register(icd); > } > > /* > @@ -1572,8 +1563,6 @@ static int __devexit soc_camera_pdrv_remove(struct > platform_device *pdev) > > list_del(&icd->list); > > - kfree(icd); > - > return 0; > } > > -- > 1.7.4.1 > ---

Re: [PATCH] soc-camera: Use new selection target definitions

2012-09-05 Thread Guennadi Liakhovetski
gt; + s->target == V4L2_SEL_TGT_COMPOSE) { > icd->user_width = s->r.width; > icd->user_height = s->r.height; > if (!icd->streamer) > -- > 1.7.4.1 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software

[RFC v5] V4L DT bindings

2012-09-05 Thread Guennadi Liakhovetski
to the parent. (8) use standard names for "SoC-external" (e.g., i2c) devices on their respective busses. "Sensor" has been proposed, maybe "camera" is a better match though. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer htt

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-09-05 Thread Guennadi Liakhovetski
On Wed, 5 Sep 2012, Guennadi Liakhovetski wrote: > Hi Javier > > On Mon, 3 Sep 2012, javier Martin wrote: > > > Hi, > > Guennadi,did you pick this one? > > Wanted to do so, but I've applied this your patch with only that "memset()" line additiona

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

2012-09-05 Thread Guennadi Liakhovetski
o have to be removed? Thanks Guennadi > > if ((mf.width != pix->width || mf.height != pix->height) && > > - pcdev->emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) { > > + emma_prp->cfg.in_fmt == PRP_CNTL_DATA_IN_YUV422) { >

Re: V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-31 Thread Guennadi Liakhovetski
On Thu, 30 Aug 2012, Hans Verkuil wrote: > Fine by me! Good, then let's meet at 11:55 in front of Nautilus 3 / 4 and then see what's available. Thanks Guennadi > > Hans > > Guennadi Liakhovetski wrote: > > >On Fri, 31 Aug 2012, Laurent Pi

Re: V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Guennadi Liakhovetski
On Fri, 31 Aug 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 30 August 2012 22:58:17 Guennadi Liakhovetski wrote: > > Hi all > > > > Do we still want to try to organise a short discussion of this while at > > plumbers? Maybe tomorrow during or ar

V4L DT @ plumbers (was Re: [RFC v4] V4L DT bindings)

2012-08-30 Thread Guennadi Liakhovetski
Hi all Do we still want to try to organise a short discussion of this while at plumbers? Maybe tomorrow during or around lunch? Or any other time for that matter? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To

Re: [PATCH] [media] atmel_isi: allocate memory to store the isi platform data.

2012-08-29 Thread Guennadi Liakhovetski
this going to work when this driver is build and as a module > and its loading is deferred past system booting ? At that time the driver's > platform data may be well discarded. Right, it will be gone, I think. > You may wan't to duplicate it on the > running boards in boa

<    5   6   7   8   9   10   11   12   13   14   >