RE: [REPORT] Brainstorm meeting on V4L2 memory handling

driver: http://www.mail-archive.com/linux-media@vger.kernel.org/msg13606.html And there is always the test device, which was posted along with v2. If you come across any problems or have more questions, I would be happy to help. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Ce

RE: [PATCH/RFC] videobuf refactoring

signed int *fc = CALL(q, vaddr, buf); I'd add a check against fc == NULL, unless I am missing something. Now that I look at it, there is no such check in current code either. I could imagine a buffer without a kernel mapping. This requires a more in-depth analysis of read handling code. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH/RFC 0/2] Fix DQBUF behavior for recoverable streaming errors

>Laurent Pinchart wrote: >On Wednesday 17 March 2010 21:05:19 Hans Verkuil wrote: >> On Wednesday 17 March 2010 15:29:48 Pawel Osciak wrote: >> > Hello, >> > >> > during the V4L2 brainstorm meeting in Norway we have concluded that >> > streaming er

RE: [PATCH v2] v4l: videobuf: code cleanup.

nal changes instead of them having to do codingstyle >> cleanups at the same time. I want to avoid that. > >Sounds reasonable. > >I wont say naything more about the topic. I think you guys have cleared it >enough for me :) Come on guys, I really do not give up that easily,

[PATCH/RFC 0/2] Fix DQBUF behavior for recoverable streaming errors

ming errors [PATCH 2/2] v4l: videobuf: Add support for V4L2_BUF_FLAG_ERROR Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] v4l: Add a new ERROR flag for DQBUF after recoverable streaming errors

buffer the operation failed. Signed-off-by: Pawel Osciak --- include/linux/videodev2.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 3c26560..1ae1568 100644 --- a/include/linux/videodev2.h +++ b/include/linux

[PATCH 2/2] v4l: videobuf: Add support for V4L2_BUF_FLAG_ERROR

On dqbuf videobuf will now return 0 and an error flag will be set, instead of returning EIO in case of recoverable streaming errors. --- drivers/media/video/videobuf-core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/videobuf-core.c b/drivers/m

RE: [PATCH v2] v4l: videobuf: code cleanup.

ve the decision up to Mauro then. I have some more "normal" patches lined up, so please let me know. I'm guessing we are cancelling the clean-up then though. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the l

[PATCH] v4l: videobuf: make poll() report proper flags for output video devices

According to the V4L2 specification, poll() should set POLLOUT | POLLWRNORM flags for output devices after the frame has been displayed. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/videobuf-core.c | 10 -- 1 files changed, 8 insertions(+), 2

[PATCH v2] v4l: videobuf: code cleanup.

Make videobuf pass checkpatch; minor code cleanups. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/videobuf-core.c| 116 ++--- drivers/media/video/videobuf-dma-sg.c | 276 drivers/media/video/videobuf-vmalloc.c

[no subject]

Changes from v1: - now includes headers as well [PATCH v2] v4l: videobuf: code cleanup. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] v4l: videobuf: code cleanup.

Make videobuf pass checkpatch; minor code cleanups. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/videobuf-core.c| 116 ++--- drivers/media/video/videobuf-dma-sg.c | 276 drivers/media/video/videobuf-vmalloc.c

RE: Magic in videobuf

>Hans Verkuil wrote: >>>Andy Walls wrote: >>>On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: >>>> Hans Verkuil wrote: >>>> >> Hans Verkuil wrote: >>>> >>>> Pawel Osciak wrote: >>> &

RE: Magic in videobuf

-aligned at the DMA, it is likely that the magic number of the >>> next buffer >>> will be overwritten if something got bad. The real situation will depend >>> on how >>> fragmented is the memory. >> >> For the record: we are talking about the magic fiel

RE: Magic in videobuf

>Andy Walls wrote: >On Mon, 2010-03-15 at 14:26 -0300, Mauro Carvalho Chehab wrote: >> Hans Verkuil wrote: >> >> Hans Verkuil wrote: >> >>>> Pawel Osciak wrote: > >> >>>>> is anyone aware of any other uses for MAGIC_CHECK()s in v

Magic in videobuf

Hello, is anyone aware of any other uses for MAGIC_CHECK()s in videobuf code besides driver debugging? I intend to remove them, as we weren't able to find any particular use for them when we were discussing this at the memory handling meeting in Norway... Best regards -- Pawel Osciak

[PATCH v2 2/3] v4l: videobuf: Add support for multi-plane buffers.

Add support for multiplanar buffers to videobuf core, dma-contig and vmalloc memory types. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/videobuf-core.c | 375 - drivers/media/video/videobuf-dma-contig.c | 297

[PATCH v2 3/3] v4l: vivi: add 2- and 3-planar YCbCr422

Add example 2- and 3- planar YCbCr422 formats for multi-plane format testing. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/vivi.c | 179 +++- include/linux/videodev2.h |3 + 2 files changed, 147 insertions(+), 35

[PATCH/RFC v2 0/3] Multi-plane video buffer support for V4L2 API and videobuf

-- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/3] v4l: Add support for multi-plane buffers to V4L2 API.

, which allows passing additional, per-plane info in the video buffer structure. Signed-off-by: Pawel Osciak Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/v4l2-ioctl.c | 97 ++--- include/linux/videodev2.h| 33

RE: More videobuf and streaming I/O questions

>On Tuesday 23 February 2010 08:41:49 Pawel Osciak wrote: >> >On Mon, 22 Feb 2010 00:12:18 +0100 >> >Laurent Pinchart wrote: >> As for the REQBUF, I've always thought it'd be nice to be able to ask the >> driver for the "recommended" number

RE: [PATCH/RFC v1 0/4] Multi-plane video buffer support for V4L2 API and videobuf

Hello, thank you for your comments. >From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] >Pawel Osciak wrote: >> Only streaming I/O has been tested, read/write might not work correctly. >> vivi has been adapted for testing and demonstration purposes, but other >

RE: More videobuf and streaming I/O questions

le to determine whether the planes array should be copied from/to user along with the buffer. Just wanted to add another view to the problem, as multiplanes are accepted yet of course. As for the REQBUF, I've always thought it'd be nice to be able to ask the driver for the "recommen

[PATCH v1 3/4] v4l: videobuf: Add support for multi-plane buffers.

Add support for multiplanar buffers to videobuf core, dma-contig and vmalloc memory types. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/videobuf-core.c | 363 +++- drivers/media/video/videobuf-dma-contig.c | 303

[EXAMPLE v1] Test application for multiplane vivi driver.

This is an example application for testing muliplane buffer V4L2 extensions with the vivi driver. --- --- /dev/null 2010-02-15 07:42:03.265396000 +0100 +++ vivi-mplane.c 2010-02-22 16:58:19.925762651 +0100 @@ -0,0 +1,582 @@ +/* + * Pawel Osciak, + * + * This program is free software; you

[PATCH v1 2/4] v4l: Add support for multi-plane buffers to V4L2 API.

, which allows passing additional, per-plane info in the video buffer structure. Signed-off-by: Pawel Osciak Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/v4l2-ioctl.c | 97 ++--- include/linux/videodev2.h| 33

[PATCH v1 4/4] v4l: vivi: add 2- and 3-planar YCbCr422

Add example 2- and 3- planar YCbCr422 formats for multi-plane format testing. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- drivers/media/video/vivi.c | 179 +++- include/linux/videodev2.h |3 + 2 files changed, 147 insertions(+), 35

[PATCH/RFC v1 0/4] Multi-plane video buffer support for V4L2 API and videobuf

The series contains: [PATCH v1 1/4] v4l: add missing checks for kzalloc returning NULL. [PATCH v1 2/4] v4l: Add support for multi-plane buffers to V4L2 API. [PATCH v1 3/4] v4l: videobuf: Add support for multi-plane buffers. [PATCH v1 4/4] v4l: vivi:

[PATCH v1 1/4] v4l: add missing checks for kzalloc returning NULL.

Signed-off-by: Pawel Osciak --- drivers/media/video/videobuf-dma-sg.c |2 ++ drivers/media/video/videobuf-vmalloc.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/videobuf-dma-sg.c b/drivers/media/video/videobuf-dma-sg.c index fa78555..fcd045e

RE: Fourcc for multiplanar formats

of writing the RFC. I should be posting everything really soon (still waiting for a green light but it's usually a matter of hours, couple of days at most). Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "

Fourcc for multiplanar formats

ar version of V4L2_PIX_FMT_YUV422P) - YCbCr 420 2-planar (multiplanar version of V4L2_PIX_FMT_NV12) - YCbCr 420 3-planar (multiplanar version of V4L2_PIX_FMT_YUV420) Could anyone give any suggestions how we should name such formats and what to pass to the v4l2_fourcc() macro? Best regards -- Pa

[PATCH v1 1/1] V4L: Add sync before a hardware operation to videobuf.

and handled by each memory type-specific module. Whether it is a sync before or after the operation can be determined from the current buffer state: VIDEOBUF_DONE and VIDEOBUF_ERROR indicate a sync called after an operation. Signed-off-by: Pawel Osciak Reviewed-by: Marek Szyprowski Reviewed-by

[PATCH/RFC v1 0/1] Buffer sync for non cache-coherent architectures

ged. We will be posting cache coherency patches for dma-contig in the near future. Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.ker

RE: [PATCH/RFC v2.1 0/2] Mem-to-mem device framework

s as part of the meta-data associated with the image. There may well > be more of those. This got pushed back but now after m2m, it's become next task on my list. I expect to be posting patches in a week or two, hopefully. I understand that you'd like to make the pointer in the union

[EXAMPLE v2] Mem-to-mem userspace test application.

processed. Tested on a 800x480 framebuffer with the following script: #!/bin/bash for i in {0..3} do ((x=$i * 100)) ./process-vmalloc 0 $(($i + 1)) $((2000 - $i * 500)) $((($i+1) * 4)) \ $x $x 100 100 & done Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/

[PATCH v2.1 1/2] V4L: Add memory-to-memory device helper framework for V4L2.

. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. This patch also adds a separate kconfig submenu for mem-to-mem V4L devices. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyu

[PATCH v2.1 2/2] V4L: Add a mem-to-mem V4L2 framework test device.

operation (via the mem2mem framework). Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 14 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testde

[PATCH/RFC v2.1 0/2] Mem-to-mem device framework

--- Future work --- - read/write support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards

[PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver

. Signed-off-by: Pawel Osciak Signed-off-by: Sylwester Nawrocki Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |2 + drivers/media/video/samsung-rotator/Makefile |1

[EXAMPLE] S3C/S5P image rotator test application

(c) 2009 Samsung Electronics Co., Ltd. + * Pawel Osciak, + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the + * License, or (at your option

[PATCH 0/2] [ARM] Add Samsung S3C/S5P image rotator driver

] [ARM] samsung-rotator: Add rotator device platform definitions. [PATCH 2/2] [ARM] samsung-rotator: Add Samsung S3C/S5P rotator driver [EXAMPLE] S3C/S5P image rotator test application Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list:

[PATCH 1/2] [ARM] samsung-rotator: Add rotator device platform definitions.

Add S3C/S5P rotator platform device. Signed-off-by: Pawel Osciak Signed-off-by: Sylwester Nawrocki Reviewed-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- arch/arm/mach-s3c6400/include/mach/map.h |2 + arch/arm/plat-s3c/Kconfig |5 ++ arch/arm/plat-s3c

[EXAMPLE v2] Mem-to-mem userspace test application.

processed. Tested on a 800x480 framebuffer with the following script: #!/bin/bash for i in {0..3} do ((x=$i * 100)) ./process-vmalloc 0 $(($i + 1)) $((2000 - $i * 500)) $((($i+1) * 4)) \ $x $x 100 100 & done Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/

[PATCH v2 2/2] V4L: Add a mem-to-mem V4L2 framework test device.

operation (via the mem2mem framework). Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testde

[PATCH v2 1/2] V4L: Add memory-to-memory device helper framework for V4L2.

. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. This patch also adds a separate kconfig submenu for mem-to-mem V4L devices. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyu

[PATCH/RFC v2 0/2] Mem-to-mem device framework

- - read/write support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubsc

Syncing videobuf buffers before an operation

e to an agreement on this as well. Thank you! Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[EXAMPLE v1] Mem-to-mem userspace test application.

processed. Signed-off-by: Pawel Osciak Reviewed-by: Kyungmin Park --- --- /dev/null 2009-11-17 07:51:25.574927259 +0100 +++ process-vmalloc.c 2009-11-26 11:00:26.0 +0100 @@ -0,0 +1,420 @@ +/** + * process-vmalloc.c + * Capture+output (process) V4L2 device tester. + * + * Pawel Osciak

[PATCH 2/2] Added a mem-to-mem V4L2 framework test device.

Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mem2mem_testdev.c | 1050 + 3 files changed, 1058

[PATCH 1/2] Added memory-to-memory device helper framework for V4L2.

. Although no such devices are present in the V4L2 framework, a demand for such a model exists, e.g. for 'resizer devices'. Signed-off-by: Pawel Osciak Signed-off-by: Marek Szyprowski Reviewed-by: Kyungmin Park --- drivers/media/video/Kconfig|4 + drivers/media/video/Makefile

[PATCH/RFC v1] Mem-to-mem device framework

e support - transaction/abort timeouts - extracting more common code to the framework? (e.g. per-queue format details, transaction length, etc.) Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubsc

RE: V4L2_MEMORY_USERPTR support in videobuf-core

p;& buf_state != VIDEOBUF_IDLE) would most probably fail anyway. How to enqueue and handle multiple userptr buffers? Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

V4L2_MEMORY_USERPTR support in videobuf-core

other development effort underway related to this problem? Best regards -- Pawel Osciak Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo

RE: [RFC] v1.1: Multi-plane (discontiguous) buffers

ory types as usual */ } 2. Let the driver (videobuffer framework) handle it however it wants. For example, store the "PLANE_MMAPED" somewhere in internal structures and do not expose the plane mapped state to the userspace. What do you think? I'm leaning towards the first so

<    1   2   3   4