Re: [PATCH v2 3/6] media: mt9m111: add support to select formats and fps for {Q,SXGA}

2018-11-16 Thread Hans Verkuil
On 11/16/2018 02:26 PM, Sakari Ailus wrote: > Hi Marco, Michael, > > On Mon, Oct 29, 2018 at 07:24:07PM +0100, Marco Felsch wrote: >> From: Michael Grzeschik >> >> This patch implements the framerate selection using the skipping and >> readout power-modi features. The power-modi cut the

Re: [PATCH v2 3/6] media: mt9m111: add support to select formats and fps for {Q,SXGA}

2018-11-16 Thread Sakari Ailus
Hi Marco, Michael, On Mon, Oct 29, 2018 at 07:24:07PM +0100, Marco Felsch wrote: > From: Michael Grzeschik > > This patch implements the framerate selection using the skipping and > readout power-modi features. The power-modi cut the framerate by half > and each context has an independent

Re: [PATCH 4/4] media: ov5640: Add additional media bus formats

2018-11-16 Thread Sakari Ailus
Hi Sam, On Mon, Oct 08, 2018 at 11:48:02PM -0700, Sam Bobrowicz wrote: > Add support for 1X16 yuv media bus formats (v4l2_mbus_framefmt). > These formats are equivalent to the 2X8 formats that are already > supported, both of which accurately describe the data present on > the CSI2 interface.

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-16 Thread Hans Verkuil
On 11/16/2018 10:00 AM, Tomasz Figa wrote: > Hi Hans, > > On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> As was discussed here (among other places): >> >> https://lkml.org/lkml/2018/10/19/440 >> >> using capture queue buffer indices to refer to reference

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Hans Verkuil
On 11/16/2018 09:45 AM, Tomasz Figa wrote: > On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: >> >> On 11/16/2018 09:34 AM, Tomasz Figa wrote: >>> Hi Hans, >>> >>> On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: Calling the stop_streaming op can release the core serialization

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-16 Thread Hans Verkuil
On 11/16/2018 09:43 AM, Tomasz Figa wrote: > Hi Hans, > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: >> >> Calling VIDIOC_DQBUF can release the core serialization lock pointed to >> by vb2_queue->lock if it has to wait for a new buffer to arrive. >> >> However, if userspace dup()ped

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: > > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag'

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
On Fri, Nov 16, 2018 at 5:42 PM Hans Verkuil wrote: > > On 11/16/2018 09:34 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > >> > >> Calling the stop_streaming op can release the core serialization lock > >> pointed to by vb2_queue->lock if it

Re: [PATCH 1/2] vb2: add waiting_in_dqbuf flag

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling VIDIOC_DQBUF can release the core serialization lock pointed to > by vb2_queue->lock if it has to wait for a new buffer to arrive. > > However, if userspace dup()ped the video device filehandle, then it is > possible to

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Hans Verkuil
On 11/16/2018 09:34 AM, Tomasz Figa wrote: > Hi Hans, > > On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: >> >> Calling the stop_streaming op can release the core serialization lock >> pointed to by vb2_queue->lock if it has to wait for buffers to finish. >> An example of that behavior is

Re: [PATCH 2/2] vb2: don't allow queueing buffers when canceling queue

2018-11-16 Thread Tomasz Figa
Hi Hans, On Wed, Nov 14, 2018 at 12:08 AM Hans Verkuil wrote: > > Calling the stop_streaming op can release the core serialization lock > pointed to by vb2_queue->lock if it has to wait for buffers to finish. > An example of that behavior is the vivid driver. Why would vb2_queue->lock have to

Re: media: ov8856: Add support for OV8856 sensor

2018-11-16 Thread Sakari Ailus
Hi Ben, On Thu, Nov 08, 2018 at 11:41:46AM +0800, Ben Kao wrote: > This patch adds driver for Omnivision's ov8856 sensor, > the driver supports following features: > > - manual exposure/gain(analog and digital) control support > - two link frequencies > - VBLANK/HBLANK support > - test pattern

Re: TechnoTrend CT2-4500 remote not working

2018-11-15 Thread martin.kono...@mknetz.de
Sean, Am 15.11.2018 um 00:07 schrieb Sean Young: >> >> I turned on dynamic debug and got the following messages in the kernel log: >> >> [ 837.160992] rc rc0: get_key_fusionhdtv: ff ff ff ff >> [ 837.263927] rc rc0: ir_key_poll >> [ 837.264528] rc rc0: get_key_fusionhdtv: ff ff ff ff >> [

RE: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-15 Thread Zhi, Yong
nel.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media > framework > > On 10/29/

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Hans Verkuil
On 11/15/18 13:52, Philipp Zabel wrote: > On Thu, 2018-11-15 at 11:21 +0100, Hans Verkuil wrote: >> On 11/14/18 15:38, Philipp Zabel wrote: >>> Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for >>> both MMAP and DMABUF memory types. If supported, try to orphan buffers >>> by

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Philipp Zabel
On Thu, 2018-11-15 at 11:21 +0100, Hans Verkuil wrote: > On 11/14/18 15:38, Philipp Zabel wrote: > > Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for > > both MMAP and DMABUF memory types. If supported, try to orphan buffers > > by calling reqbufs(0) before unmapping or

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 10/29/18 23:22, Yong Zhi wrote: > These meta formats are used on Intel IPU3 ImgU video queues > to carry 3A statistics and ISP pipeline parameters. > > V4L2_META_FMT_IPU3_3A > V4L2_META_FMT_IPU3_PARAMS > > Signed-off-by: Yong Zhi > Signed-off-by: Chao C Li > Signed-off-by: Rajmohan Mani >

Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-15 Thread Hans Verkuil
On 10/29/18 23:23, Yong Zhi wrote: > Implement video driver that utilizes v4l2, vb2 queue support > and media controller APIs. The driver exposes single > subdevice and six nodes. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-v4l2.c | 1091 >

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Sakari Ailus
On Thu, Nov 15, 2018 at 11:29:35AM +0100, Hans Verkuil wrote: > On 11/14/18 20:59, Laurent Pinchart wrote: > > Hi Philipp, > > > > Thank you for the patch. > > > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: > >> From: John Sheu > >> > >> Videobuf2 presently does not allow

Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-15 Thread Hans Verkuil
On 11/07/18 00:27, Mani, Rajmohan wrote: > Hi Mauro, > > Thanks for the reviews. > >> Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI >> >> Hi Mauro, >> >> On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab >> wrote: >>

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/14/18 16:04, Philipp Zabel wrote: > From: John Sheu > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > considered "in use". This is different behavior than for other memory > types and

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/14/18 20:59, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: >> From: John Sheu >> >> Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding >> buffers if the queue is of type

Re: [PATCH v4l-utils] v4l2-compliance: test orphaned buffer support

2018-11-15 Thread Hans Verkuil
On 11/14/18 15:38, Philipp Zabel wrote: > Test that V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS is reported equally for > both MMAP and DMABUF memory types. If supported, try to orphan buffers > by calling reqbufs(0) before unmapping or closing DMABUF fds. > > Also close exported DMABUF fds and free

Re: [PATCH] cedrus: add action item to the TODO

2018-11-15 Thread Paul Kocialkowski
Hi, On Thu, 2018-11-15 at 08:49 +0100, Hans Verkuil wrote: > Mention that the request validation should increment the memory refcount > of reference buffers so we don't forget to do this. Thanks for adding this item, we should definitely take care of it before unstaging. Acked-by: Paul

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-15 Thread Hans Verkuil
On 11/15/2018 08:49 AM, Laurent Pinchart wrote: > Hi Hans, > > > On Thursday, 15 November 2018 09:30:55 EET Hans Verkuil wrote: >> On 11/14/2018 08:52 PM, Laurent Pinchart wrote: >>> On Tuesday, 13 November 2018 17:43:48 EET Hans Verkuil wrote: On 11/13/18 16:06, Philipp Zabel wrote: >

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Laurent Pinchart
Hi Hans, On Thursday, 15 November 2018 09:30:55 EET Hans Verkuil wrote: > On 11/14/2018 08:52 PM, Laurent Pinchart wrote: > > On Tuesday, 13 November 2018 17:43:48 EET Hans Verkuil wrote: > >> On 11/13/18 16:06, Philipp Zabel wrote: > >>> From: John Sheu > >>> > >>> Videobuf2 presently does

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Hans Verkuil
On 11/14/2018 08:59 PM, Laurent Pinchart wrote: > Hi Philipp, > > Thank you for the patch. > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: >> From: John Sheu >> >> Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding >> buffers if the queue is of type

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Hans Verkuil
On 11/14/2018 08:52 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 13 November 2018 17:43:48 EET Hans Verkuil wrote: >> On 11/13/18 16:06, Philipp Zabel wrote: >>> From: John Sheu >>> >>> Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding >>> buffers if the queue is

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Tomasz Figa
On Thu, Nov 15, 2018 at 4:59 AM Laurent Pinchart wrote: > > Hi Philipp, > > Thank you for the patch. > > On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: > > From: John Sheu > > > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > > buffers if the queue

Re: TechnoTrend CT2-4500 remote not working

2018-11-14 Thread Sean Young
Martin, On Wed, Nov 14, 2018 at 09:51:38PM +0100, martin.kono...@mknetz.de wrote: > > It would be interesting to see what the device is sending. Please can you > > turn > > on dynamic debug for ir-kbd-i2c.c: > > > > echo "file ir-kbd-i2.c +p" > /sys/kernel/debug/dynamic_debug/control > > > >

Re: TechnoTrend CT2-4500 remote not working

2018-11-14 Thread martin.kono...@mknetz.de
It would be interesting to see what the device is sending. Please can you turn on dynamic debug for ir-kbd-i2c.c: echo "file ir-kbd-i2.c +p" > /sys/kernel/debug/dynamic_debug/control Try the remote again and report what in the kernel messages. Sean I turned on dynamic debug and got

Re: [PATCH v3] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Wednesday, 14 November 2018 17:04:49 EET Philipp Zabel wrote: > From: John Sheu > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > considered "in use".

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Laurent Pinchart
Hi Hans, On Tuesday, 13 November 2018 17:43:48 EET Hans Verkuil wrote: > On 11/13/18 16:06, Philipp Zabel wrote: > > From: John Sheu > > > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > >

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-14 Thread jacopo mondi
Hi Maxime, many thanks for re-sending this updated version On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every mode. > > This is troubl

Re: cec kernel oops with pulse8 usb cec adapter

2018-11-14 Thread Torbjorn Jansson
On 2018-11-14 14:23, Hans Verkuil wrote: On 11/14/18 14:00, Torbjorn Jansson wrote: since there now is a patch that appears to be working and fixing this problem i'd like to ask for some troubleshooting advice with another cec issue i have that i haven't figured out why it is happening and

Re: [PATCH v2 1/4] dt-bindings: media: sun6i: Add A31 and H3 compatibles

2018-11-14 Thread Chen-Yu Tsai
On Wed, Nov 14, 2018 at 10:59 PM Maxime Ripard wrote: > > The H3 has a slightly different CSI controller (no BT656, no CCI) which > looks a lot like the original A31 controller. Add a compatible for the A31, > and more specific compatible the for the H3 to be used in combination for > the A31. >

Re: [PATCH v2 2/4] media: sun6i: Add A31 compatible

2018-11-14 Thread Chen-Yu Tsai
On Wed, Nov 14, 2018 at 10:59 PM Maxime Ripard wrote: > > The first device that used that IP was the A31. Add it to our list of > compatibles. > > Signed-off-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai

Re: [PATCH v2 3/4] ARM: dts: sun8i: Add the H3/H5 CSI controller

2018-11-14 Thread Chen-Yu Tsai
Hi, On Wed, Nov 14, 2018 at 10:59 PM Maxime Ripard wrote: > > From: Mylène Josserand > > The H3 and H5 features the same CSI controller that was initially found on > the A31. > > Add a DT node for it. > > Signed-off-by: Mylène Josserand > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Hans Verkuil
On 11/14/18 15:43, Philipp Zabel wrote: > Hi Hans, > > On Tue, 2018-11-13 at 16:43 +0100, Hans Verkuil wrote: >> Hi Philipp, >> >> On 11/13/18 16:06, Philipp Zabel wrote: >>> From: John Sheu >>> >>> Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding >>> buffers if the queue

Re: [PATCH 07/15] media: coda: don't disable IRQs across buffer meta handling

2018-11-14 Thread Philipp Zabel
On Mon, 2018-11-05 at 16:25 +0100, Philipp Zabel wrote: > From: Lucas Stach > > The CODA driver uses threaded IRQs only, so there is nothing happening > in hardirq context that could interfere with the buffer meta handling. > > Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel regards

Re: [PATCH 04/15] media: coda: limit queueing into internal bitstream buffer

2018-11-14 Thread Philipp Zabel
Hi, I forgot to add the proper SoB tag: On Mon, 2018-11-05 at 16:25 +0100, Philipp Zabel wrote: > From: Lucas Stach > > The ringbuffer used to hold the bitstream is very conservatively sized, > as keyframes can get very large and still need to fit into this buffer. > This means that the buffer

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Philipp Zabel
Hi Hans, On Tue, 2018-11-13 at 16:43 +0100, Hans Verkuil wrote: > Hi Philipp, > > On 11/13/18 16:06, Philipp Zabel wrote: > > From: John Sheu > > > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the

Re: [PATCH v4 00/22] i.MX media mem2mem scaler

2018-11-14 Thread Adam Ford
PU image converter, and independent of the >internal image converter implementation. > - Remove the source and destination buffers on error in device_run(). >Otherwise the conversion is re-attempted apparently over and over >again (with WARN() backtraces). > - Allow subscribing to

Re: cec kernel oops with pulse8 usb cec adapter

2018-11-14 Thread Hans Verkuil
On 11/14/18 14:00, Torbjorn Jansson wrote: > since there now is a patch that appears to be working and fixing this problem > i'd like to ask for some troubleshooting advice with another cec issue i have > that i haven't figured out why it is happening and exactly whats causing it. > > i'm

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-14 Thread Adam Ford
On Tue, Nov 13, 2018 at 7:04 AM Maxime Ripard wrote: > > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every mode. > > This is troublesome, since we cannot adjust it at runtime based on other > parameters (such as

Re: cec kernel oops with pulse8 usb cec adapter

2018-11-14 Thread Torbjorn Jansson
On 2018-10-22 10:59, Sean Young wrote: On Sat, Oct 20, 2018 at 11:12:16PM +0200, Hans Verkuil wrote: Hi Sean, Can you take a look at this, it appears to be an RC issue, see my analysis below. On 10/20/2018 03:26 PM, Torbjorn Jansson wrote: Hello i'm using the pulse8 usb cec adapter to

Re: [PATCH] media: rc: cec devices do not have a lirc chardev

2018-11-14 Thread Torbjorn Jansson
On 2018-10-22 15:17, Sean Young wrote: On Mon, Oct 22, 2018 at 01:28:42PM +0100, Sean Young wrote: On Mon, Oct 22, 2018 at 12:30:29PM +0100, Hans Verkuil wrote: On 10/22/2018 11:14 AM, Sean Young wrote: Would you be able to test the following patch please? Sean, I think you should be able

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-14 Thread Philipp Zabel
Hi Sakari, On Wed, 2018-11-14 at 00:27 +0200, Sakari Ailus wrote: [...] > This lets the user to allocate lots of mmap'ed buffers that are pinned in > physical memory. This is already possible without this patch, by closing the fd instead of calling reqbufs(0). > Considering that we don't really

Re: [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units

2018-11-14 Thread Tomasz Figa
Hi Sakari, On Fri, Sep 28, 2018 at 11:00 PM Hans Verkuil wrote: > > On 09/25/2018 12:14 PM, Sakari Ailus wrote: > > Add support for exponential bases, prefixes as well as units for V4L2 > > controls. This makes it possible to convey information on the relation > > between the control value and

Re: [PATCH v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-14 Thread Sakari Ailus
Hi Sasha, On Thu, Nov 08, 2018 at 12:28:53PM -0500, Sasha Levin wrote: > On Thu, Nov 08, 2018 at 01:46:06PM +0200, Sakari Ailus wrote: > > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > > > Patch ad608fbcf166 changed how events were subscribed to address an issue > > elsewhere.

Re: [RFC PATCH 0/3] Media Controller Properties

2018-11-14 Thread Hans Verkuil
On 11/14/2018 09:09 AM, Tomasz Figa wrote: > Hi Hans, > > On Fri, Aug 3, 2018 at 11:36 PM Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> This RFC patch series implements properties for the media controller. >> >> This is not finished, but I wanted to post this so people can discuss >> this

Re: [RFC PATCH 0/3] Media Controller Properties

2018-11-14 Thread Tomasz Figa
Hi Hans, On Fri, Aug 3, 2018 at 11:36 PM Hans Verkuil wrote: > > From: Hans Verkuil > > This RFC patch series implements properties for the media controller. > > This is not finished, but I wanted to post this so people can discuss > this further. > > No documentation yet (too early for that).

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread Sakari Ailus
Hi Jacopo, On Wed, Nov 14, 2018 at 01:25:11AM +0100, jacopo mondi wrote: > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: > > Hi, > > > > This series adds support for the Intel IPU3 (Image Processing Unit) > > ImgU which is essentially a modern memory-to-memory ISP. It implements > >

Re: [PATCH 1/9] videodev2.h: add tag support

2018-11-13 Thread Hans Verkuil
On 11/13/2018 10:42 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for 'tags' to struct v4l2_buffer. These can be used > by m2m devices so userspace can set a tag for an output buffer and > this value will then be copied to the capture buffer(s). > > This tag can be used to refer

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread Bing Bu Cao
On 11/14/2018 05:58 AM, Sakari Ailus wrote: > On Tue, Nov 13, 2018 at 07:04:01PM +0800, Bing Bu Cao wrote: >> >> On 11/13/2018 06:31 PM, Sakari Ailus wrote: >>> Hi Bing Bu, >>> >>> On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: On 11/09/2018 06:09 PM, Sakari Ailus wrote:

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Tomasz Figa
On Wed, Nov 14, 2018 at 8:51 AM Nicolas Dufresne wrote: > > Le mercredi 14 novembre 2018 à 00:27 +0200, Sakari Ailus a écrit : > > Hi Philipp, > > > > On Tue, Nov 13, 2018 at 04:06:21PM +0100, Philipp Zabel wrote: > > > From: John Sheu > > > > > > Videobuf2 presently does not allow

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread jacopo mondi
4L2 Kernel driver interface > and IO-Control parameters, except for the ISP internal algorithm and its > parameters (which is Intel proprietary IP). > > version 5: > - ipu3-css-pool.c/ipu3_css_pool_check(). > add handling of the framenum wrap around case in ipu3_css_pool_c

Re: [PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

2018-11-13 Thread jacopo mondi
Hello Mita-san, thanks for the patches On Tue, Nov 13, 2018 at 01:00:47AM +0900, Akinobu Mita wrote: > This patchset addds relatively small enhancements (log_status ioctl, event > interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for > mt9m111, ov2640, ov5640, ov7670, and

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Nicolas Dufresne
Le mercredi 14 novembre 2018 à 00:27 +0200, Sakari Ailus a écrit : > Hi Philipp, > > On Tue, Nov 13, 2018 at 04:06:21PM +0100, Philipp Zabel wrote: > > From: John Sheu > > > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > > buffers if the queue is of type

Re: [PATCH 4/4] SoC camera: Tidy the header

2018-11-13 Thread Sakari Ailus
Hi Hans, Mauro, On Wed, Oct 31, 2018 at 07:54:21AM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2018 11:00:22 +0100 > Hans Verkuil escreveu: > > > On 10/31/2018 10:40 AM, Mauro Carvalho Chehab wrote: > > > Em Wed, 31 Oct 2018 11:29:45 +0200 > > > Sakari Ailus escreveu: > > > > > >>

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Sakari Ailus
Hi Philipp, On Tue, Nov 13, 2018 at 04:06:21PM +0100, Philipp Zabel wrote: > From: John Sheu > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > considered "in use". This is different behavior

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread Sakari Ailus
On Tue, Nov 13, 2018 at 07:04:01PM +0800, Bing Bu Cao wrote: > > > On 11/13/2018 06:31 PM, Sakari Ailus wrote: > > Hi Bing Bu, > > > > On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: > >> > >> On 11/09/2018 06:09 PM, Sakari Ailus wrote: > >>> Hi Bing Bu, > >>> > >>> On Wed, Nov 07,

Re: [PATCH 3/7] media: ov2640: add V4L2_CID_TEST_PATTERN control

2018-11-13 Thread Sakari Ailus
On Tue, Nov 13, 2018 at 10:55:46PM +0900, Akinobu Mita wrote: > 2018年11月13日(火) 19:37 Sakari Ailus : > > > > On Tue, Nov 13, 2018 at 01:00:50AM +0900, Akinobu Mita wrote: > > > The ov2640 has the test pattern generator features. This makes use of > > > it through V4L2_CID_TEST_PATTERN control. > >

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-13 Thread VDR User
> On Sat, 2018-11-03 at 07:55 -0700, Derek Kelly wrote: > > The following patch adds event codes for common buttons found on > > various > > provider and universal remote controls. They represent functions not > > covered by existing event codes. Once added, rc_keymaps can be > > updated > >

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Hans Verkuil
Hi Philipp, On 11/13/18 16:06, Philipp Zabel wrote: > From: John Sheu > > Videobuf2 presently does not allow VIDIOC_REQBUFS to destroy outstanding > buffers if the queue is of type V4L2_MEMORY_MMAP, and if the buffers are > considered "in use". This is different behavior than for other memory

Re: [PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2018-11-13 Thread Philipp Zabel
Sorry, that should have said [PATCH v2]. regards Philipp

Re: [PATCH 3/7] media: ov2640: add V4L2_CID_TEST_PATTERN control

2018-11-13 Thread Akinobu Mita
2018年11月13日(火) 19:37 Sakari Ailus : > > On Tue, Nov 13, 2018 at 01:00:50AM +0900, Akinobu Mita wrote: > > The ov2640 has the test pattern generator features. This makes use of > > it through V4L2_CID_TEST_PATTERN control. > > > > Cc: Sakari Ailus > > Cc: Mauro Carvalho Chehab > > Signed-off-by:

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-13 Thread Bastien Nocera
On Sat, 2018-11-03 at 07:55 -0700, Derek Kelly wrote: > The following patch adds event codes for common buttons found on > various > provider and universal remote controls. They represent functions not > covered by existing event codes. Once added, rc_keymaps can be > updated > accordingly where

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread Bing Bu Cao
On 11/13/2018 06:31 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: >> >> On 11/09/2018 06:09 PM, Sakari Ailus wrote: >>> Hi Bing Bu, >>> >>> On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: On 11/01/2018 08:03 PM, Sakari

Re: [PATCH 3/7] media: ov2640: add V4L2_CID_TEST_PATTERN control

2018-11-13 Thread Sakari Ailus
On Tue, Nov 13, 2018 at 01:00:50AM +0900, Akinobu Mita wrote: > The ov2640 has the test pattern generator features. This makes use of > it through V4L2_CID_TEST_PATTERN control. > > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > drivers/media/i2c/ov2640.c

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-13 Thread Sakari Ailus
Hi Bing Bu, On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: > > > On 11/09/2018 06:09 PM, Sakari Ailus wrote: > > Hi Bing Bu, > > > > On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: > >> On 11/01/2018 08:03 PM, Sakari Ailus wrote: > >>> Hi Yong, > >>> > >>> Thanks for

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-13 Thread Paul Kocialkowski
; > > > This series goal is to avoid drivers from having ad-hoc code > > > > to call .device_run in non-atomic context. Currently, .device_run > > > > can be called via v4l2_m2m_job_finish(), not only running > > > > in interrup

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-13 Thread Paul Kocialkowski
lso creating a nasty re-entrant > path into mem2mem drivers. > > The proposed solution is to add a per-device worker that is scheduled > by v4l2_m2m_job_finish, which replaces drivers having a threaded interrupt > or similar. > > This change allows v4l2_m2m_job_finish() to

Re: [RFC PATCHv2 5/5] cedrus: add tag support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 05:47 PM, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: >> Replace old reference frame indices by new tag method. > > I tested this for the cedrus driver and it works properly! > Thanks a lot for implementating this for our driver. > I

Re: [RFC PATCHv2 0/5] vb2/cedrus: add tag support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 05:32 PM, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: >> As was discussed here (among other places): >> >> https://lkml.org/lkml/2018/10/19/440 >> >> using capture queue buffer indices to refer to reference frames is >> not a good idea.

RE: [PATCH v7 15/16] intel-ipu3: Add imgu top level pci device driver

2018-11-12 Thread Zhi, Yong
.verk...@cisco.com; > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > ; Zheng, Jian Xu ; Hu, > Jerry W ; Toivonen, Tuukka > ; Qiu, Tian Shu ; Cao, > Bingbu > Subject: Re: [PATCH v7 15/16] intel-ipu3: Add imgu top level pci device driver > > Hi Yong, > > On Mon,

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-12 Thread Ezequiel Garcia
t; to call .device_run in non-atomic context. Currently, .device_run > > > can be called via v4l2_m2m_job_finish(), not only running > > > in interrupt context, but also creating a nasty re-entrant > > > path into mem2mem drivers. > > > >

Re: VIVID/VIMC and media fuzzing

2018-11-12 Thread Dmitry Vyukov
t;>>> This will create two vivid instances, one using the single planar API >>>>>> and one using >>>>>> the multiplanar API. That will improve the test coverage. >>>>> >>>>> Re this and collisions between multip

Re: [PATCH v5 5/5] media: cedrus: Get rid of interrupt bottom-half

2018-11-12 Thread Paul Kocialkowski
Hi, On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > Now that the mem2mem framework guarantees that .device_run > won't be called from interrupt context, it is safe to call > v4l2_m2m_job_finish directly in the top-half. > > So this means the bottom-half is no longer needed and we >

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-12 Thread Paul Kocialkowski
gt; can be called via v4l2_m2m_job_finish(), not only running > > in interrupt context, but also creating a nasty re-entrant > > path into mem2mem drivers. > > > > The proposed solution is to add a per-device worker that is scheduled > > by v4l2_m2m_job_finish, which replaces

Re: [RFC PATCHv2 5/5] cedrus: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > Replace old reference frame indices by new tag method. I tested this for the cedrus driver and it works properly! Thanks a lot for implementating this for our driver. I have one minor cosmetic comment below. Regarding the padding

Re: [RFC PATCHv2 0/5] vb2/cedrus: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag' (thanks to Alexandre > for

Re: [RFC PATCHv2 1/5] videodev2.h: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for 'tags' to struct v4l2_buffer. These can be used > by m2m devices so userspace can set a tag for an output buffer and > this value will then be copied to the capture buffer(s). > > This tag can

Re: VIVID/VIMC and media fuzzing

2018-11-12 Thread Hans Verkuil
>>>> "vivid.n_devs=2 vivid.multiplanar=1,2" >>>>> >>>>> This will create two vivid instances, one using the single planar API and >>>>> one using >>>>> the multiplanar API. That will improve the test coverage. >>>>

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-12 Thread Hans Verkuil
On 11/12/2018 10:29 AM, Philipp Zabel wrote: > Hi Tomasz, > > On Sun, 2018-11-11 at 12:43 +0900, Tomasz Figa wrote: >> On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne >> wrote: >>> >>> Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > In this patch we should consider a way

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

2018-11-12 Thread Jean Delvare
On Mon, 2018-11-12 at 11:03 +0100, Paul Kocialkowski wrote: > On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote: > > Fix the following build-time warning: > > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > > without #include > > We already have a similar fix in

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote: > Fix the following build-time warning: > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > without #include We already have a similar fix in the media tree:

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-12 Thread Philipp Zabel
Hi Tomasz, On Sun, 2018-11-11 at 12:43 +0900, Tomasz Figa wrote: > On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne wrote: > > > > Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > > > In this patch we should consider a way to tell userspace that this has > > > > been opt in,

Re: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility functions

2018-11-12 Thread Sakari Ailus
@vger.kernel.org; tf...@chromium.org; > > mche...@kernel.org; hans.verk...@cisco.com; > > laurent.pinch...@ideasonboard.com; Mani, Rajmohan > > ; Zheng, Jian Xu ; Hu, > > Jerry W ; Toivonen, Tuukka > > ; Qiu, Tian Shu ; Cao, > > Bingbu > > Subject:

Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 08:07 AM, Alexandre Courbot wrote: > Hi Hans, > > On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote: >> >> As was discussed here (among other places): >> >> https://lkml.org/lkml/2018/10/19/440 >> >> using capture queue buffer indices to refer to reference frames is >> not a good

Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-11 Thread Alexandre Courbot
Hi Hans, On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote: > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use 'cookies' (a better name is >

Re: [RFC PATCH 1/5] videodev2.h: add cookie support

2018-11-11 Thread Alexandre Courbot
On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote: > > From: Hans Verkuil > > Add support for 'cookies' to struct v4l2_buffer. These can be used to This "to" seems unneeded.

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-11 Thread Bing Bu Cao
On 11/09/2018 06:09 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: >> On 11/01/2018 08:03 PM, Sakari Ailus wrote: >>> Hi Yong, >>> >>> Thanks for the update! >>> >>> On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: Hi,

Re: TechnoTrend CT2-4500 remote not working

2018-11-11 Thread Sean Young
On Sat, Nov 10, 2018 at 10:35:29PM +0100, martin.kono...@mknetz.de wrote: > Hi all, > > the remote on my TechnoTrend CT2-4500 is not working with kernel 4.18. > The TV-card itself works fine: > > cx25840 6-0044: loaded v4l-cx23885-avcore-01.fw firmware (16382 bytes) > cx23885:

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-11 Thread Ezequiel Garcia
ting a nasty re-entrant > path into mem2mem drivers. > > The proposed solution is to add a per-device worker that is scheduled > by v4l2_m2m_job_finish, which replaces drivers having a threaded interrupt > or similar. > > This change allows v4l2_m2m_job_finish() to be called i

RE,

2018-11-11 Thread Miss Juliet Muhammad
Hello, My Name is Juliet Muhammad from Turkey, I very happy to contact you because i want to be your friend and business partner hope you don't mind writing me back I came across your e-mail contact prior a private search while in need of your assistance.

RE,

2018-11-10 Thread Miss Juliet Muhammad
I have a deal for you, in your region.

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-10 Thread Tomasz Figa
On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne wrote: > > Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > > In this patch we should consider a way to tell userspace that this has > > > been opt in, otherwise existing userspace will have to remain using > > > sub-optimal copy

Re: [PATCH v6 08/10] media: uvcvideo: Split uvc_video_enable into two

2018-11-10 Thread Kieran Bingham
Hi Laurent, I see that you made changes to this patch before accepting it last time. I'm afraid I haven't made those changes here, so please just cherry-pick your previous incarnation. There are no changes here from me between v5, and v6. Regards -- Kieran On 09/11/2018 17:05, Kieran Bingham

Re: VIVID/VIMC and media fuzzing

2018-11-10 Thread Dmitry Vyukov
>> >>>> This will create two vivid instances, one using the single planar API and >>>> one using >>>> the multiplanar API. That will improve the test coverage. >>> >>> Re this and collisions between multiple test processes. We actually &

<    1   2   3   4   5   6   7   8   9   10   >