Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-20 Thread Michael Jones
Hi Laurent, On 01/19/2011 05:38 PM, Laurent Pinchart wrote: Hi Michael, snip @@ -1144,10 +1148,15 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) else syn_mode = ~ISPCCDC_SYN_MODE_SDR2RSZ; - isp_reg_writel(isp, syn_mode, OMAP3_ISP_IOMEM_CCDC, ISPCCDC_SYN_MODE); +

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-20 Thread Laurent Pinchart
Hi Martin, On Wednesday 19 January 2011 18:47:59 mar...@neutronstar.dyndns.org wrote: On Wed, Jan 19, 2011 at 12:27:19AM +0100, Laurent Pinchart wrote: On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-20 Thread Martin Hostettler
On Thu, Jan 20, 2011 at 03:37:50PM +0100, Laurent Pinchart wrote: Hi Martin, On Wednesday 19 January 2011 18:47:59 mar...@neutronstar.dyndns.org wrote: But the only clean solution i can think of is setting it to 0 unconditionally. I'm not sure what this default should acomplish, so maybe

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-19 Thread Michael Jones
Hi Martin, a couple of comments inline below. On 01/19/2011 12:27 AM, Laurent Pinchart wrote: Hi Martin, Thanks for the patch. One comment below. On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in synchronous

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-19 Thread Laurent Pinchart
Hi Michael, On Wednesday 19 January 2011 14:45:46 Michael Jones wrote: On 01/19/2011 12:27 AM, Laurent Pinchart wrote: On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in synchronous interface. When in 8bit

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-19 Thread martin
On Wed, Jan 19, 2011 at 12:27:19AM +0100, Laurent Pinchart wrote: Hi Martin, Thanks for the patch. One comment below. On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in synchronous interface. When in 8bit

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-18 Thread Laurent Pinchart
Hi Martin, Thanks for the patch. One comment below. On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in synchronous interface. When in 8bit mode don't apply DC substraction of 64 per default as this would remove