Re: Debug code in HG repositories

2011-04-03 Thread Mauro Carvalho Chehab
Em 10-01-2011 23:10, Oliver Endriss escreveu: On Monday 10 January 2011 13:04:54 Mauro Carvalho Chehab wrote: Em 07-01-2011 21:56, Oliver Endriss escreveu: ... There are large pieces of driver code which are currently unused, and nobody can tell whether they will ever be needed. On the

Re: [patch] addition to v2.6.35_i2c_new_probed_device.patch (was: Re: Debug code in HG repositories)

2011-01-14 Thread Vincent McIntyre
On 1/13/11, Mauro Carvalho Chehab mche...@redhat.com wrote: This seems to be a relatively simple patch, inline below. This is against the linux-media tree, I could not figure out how to turn it into a clean patch of media_build/backports/v2.6.35_i2c_new_probed_device.patch I did look for

Re: [patch] addition to v2.6.35_i2c_new_probed_device.patch (was: Re: Debug code in HG repositories)

2011-01-13 Thread Mauro Carvalho Chehab
Em 13-01-2011 02:43, Vincent McIntyre escreveu: On 1/12/11, Mauro Carvalho Chehab mche...@redhat.com wrote: which on the face of it suggests btty-input.c already handled, my mistake. cx88-input.c the search string was in a comment hdpvr-i2c.c see below I have no time

[patch] addition to v2.6.35_i2c_new_probed_device.patch (was: Re: Debug code in HG repositories)

2011-01-12 Thread Vincent McIntyre
On 1/12/11, Mauro Carvalho Chehab mche...@redhat.com wrote: which on the face of it suggests btty-input.c already handled, my mistake. cx88-input.c the search string was in a comment hdpvr-i2c.c see below I have no time currently to touch on it, since I still have lots of patches

Re: Debug code in HG repositories

2011-01-11 Thread Vincent McIntyre
On 1/10/11, Mauro Carvalho Chehab mche...@redhat.com wrote: Thanks for your script, but it seems specific to your environment. Could you please make it more generic and perhaps patch the existing build.sh script? I was mainly intending to show how I happen to do this. It's way too complicated

Re: Debug code in HG repositories

2011-01-11 Thread Vincent McIntyre
On 1/10/11, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 07-01-2011 23:02, Vincent McIntyre escreveu: On 1/8/11, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely.

Re: Debug code in HG repositories

2011-01-11 Thread Mauro Carvalho Chehab
Em 11-01-2011 08:37, Vincent McIntyre escreveu: On 1/10/11, Mauro Carvalho Chehab mche...@redhat.com wrote: Thanks for your script, but it seems specific to your environment. Could you please make it more generic and perhaps patch the existing build.sh script? I was mainly intending to

Re: Debug code in HG repositories

2011-01-11 Thread Mauro Carvalho Chehab
Em 11-01-2011 08:47, Vincent McIntyre escreveu: On 1/10/11, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 07-01-2011 23:02, Vincent McIntyre escreveu: On 1/8/11, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from

Re: Debug code in HG repositories

2011-01-10 Thread Mauro Carvalho Chehab
Em 07-01-2011 19:06, Hans Verkuil escreveu: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT? When

Re: Debug code in HG repositories

2011-01-10 Thread Mauro Carvalho Chehab
Em 07-01-2011 21:42, Theodore Kilgore escreveu: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. Probably a good idea. I have been too busy to know about it, myself. And

Re: Debug code in HG repositories

2011-01-10 Thread Mauro Carvalho Chehab
Em 07-01-2011 21:56, Oliver Endriss escreveu: On Friday 07 January 2011 22:06:30 Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code

Re: Debug code in HG repositories

2011-01-10 Thread Mauro Carvalho Chehab
Em 10-01-2011 10:04, Mauro Carvalho Chehab escreveu: Em 07-01-2011 21:56, Oliver Endriss escreveu: On Friday 07 January 2011 22:06:30 Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi

Re: Debug code in HG repositories

2011-01-10 Thread Mauro Carvalho Chehab
Em 07-01-2011 23:02, Vincent McIntyre escreveu: On 1/8/11, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. I could add backwards

Re: Debug code in HG repositories

2011-01-10 Thread Johannes Stezenbach
On Mon, Jan 10, 2011 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote: Em 07-01-2011 21:42, Theodore Kilgore escreveu: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more.

Re: Debug code in HG repositories

2011-01-10 Thread Theodore Kilgore
Mauro, A few comments in-line. Vide infra. On Mon, 10 Jan 2011, Mauro Carvalho Chehab wrote: Em 07-01-2011 21:42, Theodore Kilgore escreveu: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we

Re: Debug code in HG repositories

2011-01-10 Thread Oliver Endriss
On Monday 10 January 2011 13:27:09 Mauro Carvalho Chehab wrote: ... diff -upr /tmp/stripped/drivers/media/dvb/ngene/ngene-cards.c /tmp/not_stripped/drivers/media/dvb/ngene/ngene-cards.c --- /tmp/stripped/drivers/media/dvb/ngene/ngene-cards.c 2011-01-10 10:01:49.0 -0200

Re: Debug code in HG repositories

2011-01-07 Thread Devin Heitmueller
On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT? When drivers were submitted to the kernel from HG, the '#if 0' stuff was stripped, unless it was marked as 'keep'...

Re: Debug code in HG repositories

2011-01-07 Thread Theodore Kilgore
On Fri, 7 Jan 2011, Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT?

Re: Debug code in HG repositories

2011-01-07 Thread Oliver Endriss
On Friday 07 January 2011 22:06:30 Hans Verkuil wrote: On Friday, January 07, 2011 21:13:31 Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not

Re: Debug code in HG repositories

2011-01-07 Thread Vincent McIntyre
On 1/8/11, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. I could add backwards compatibility builds to my daily build script that uses

Re: Debug code in HG repositories

2011-01-07 Thread VDR User
On Fri, Jan 7, 2011 at 1:06 PM, Hans Verkuil hverk...@xs4all.nl wrote: Have you tried Mauro's media_build tree? I had to use it today to test a driver from git on a 2.6.35 kernel. Works quite nicely. Perhaps we should promote this more. I could add backwards compatibility builds to my daily

Re: Debug code in HG repositories

2011-01-07 Thread Jarod Wilson
On Jan 7, 2011, at 3:13 PM, Devin Heitmueller wrote: On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss o.endr...@gmx.de wrote: Hi guys, are you aware that there is a lot of '#if 0' code in the HG repositories which is not in GIT? When drivers were submitted to the kernel from HG, the '#if