Hello Mauro Carvalho Chehab,
This is a semi-automatic email about new static checker warnings.
The patch 4a83b0115066: [media] tm6000: rewrite IR support from Nov
29, 2011, leads to the following Smatch complaint:
drivers/media/video/tm6000/tm6000-input.c +327 __tm6000_ir_int_start
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/video/tm6000/tm6000-cards.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/tm6000/tm6000-cards.c
b/drivers/media/video/tm6000/tm6000-cards.c
index ec2578a..0b54132 100644
---
protocol;
- Always provide 16 bits for NEC and RC-5;
- Fix polling code;
- Split polling functions from URB Interrupt ones;
- Don't hardcode the XTAL reference for tm6000 IR;
- If a URB submit fails, retries after 100ms;
- etc.
Tested on Hauppauge HVR
On Mon, Dec 20, 2010 at 02:41:03PM +0900, Dmitri Belimov wrote:
Hi
If Apple use full 32-bit scancode we need full raw 32-bit keytable for
compatibility.
The Apple format is two bytes for what I guess is vendor ID, one byte for
pairing ID and one byte for the actual command. The actual
Hi
If Apple use full 32-bit scancode we need full raw 32-bit keytable for
compatibility.
For this need rework all keytables and all keyread function for add scanmask
configuration and
rework single byte scancode code - key 8.
Use scanmask and return IR reading bytes on real place.
For
On Fri, 2010-12-17 at 22:24 -0200, Mauro Carvalho Chehab wrote:
Despite all discussions, we didn't reach an agreement yet.
There are some points to consider whatever solution we do:
1) A keycode table should be able to work with a generic raw decoder. So, on
all
drivers, the bit order
thoughts.
Regards,
Andy
Thanks,
Mauro
TM5600, TM6000 and TM6010 IR
==
It give two ways to receive data
1. over the control pipe (ep0)
- polling must stop if it loads firmware
- data length are a byte (command)
2. over interrupt pipe (only TM6010)
- data length
Hi Dmitri/Stefan,
Em 17-12-2010 05:08, Dmitri Belimov escreveu:
On Fri, 17 Dec 2010 06:18:31 +0100
Stefan Ringel stefan.rin...@arcor.de wrote:
Am 17.12.2010 02:46, schrieb Dmitri Belimov:
Hi Stefan
Am 16.12.2010 10:38, schrieb Dmitri Belimov:
Hi
I think your mean is wrong. Our IR
Hi
I think your mean is wrong. Our IR remotes send extended NEC it is
4 bytes. We removed inverted 4 byte and now we have 3 bytes from
remotes. I think we must have full RCMAP with this 3 bytes from
remotes. And use this remotes with some different IR recievers like
some TV cards and
Hi Stefan
Am 16.12.2010 10:38, schrieb Dmitri Belimov:
Hi
I think your mean is wrong. Our IR remotes send extended NEC it is
4 bytes. We removed inverted 4 byte and now we have 3 bytes from
remotes. I think we must have full RCMAP with this 3 bytes from
remotes. And use this remotes
Am 17.12.2010 02:46, schrieb Dmitri Belimov:
Hi Stefan
Am 16.12.2010 10:38, schrieb Dmitri Belimov:
Hi
I think your mean is wrong. Our IR remotes send extended NEC it is
4 bytes. We removed inverted 4 byte and now we have 3 bytes from
remotes. I think we must have full RCMAP with this 3
On Fri, 17 Dec 2010 06:18:31 +0100
Stefan Ringel stefan.rin...@arcor.de wrote:
Am 17.12.2010 02:46, schrieb Dmitri Belimov:
Hi Stefan
Am 16.12.2010 10:38, schrieb Dmitri Belimov:
Hi
I think your mean is wrong. Our IR remotes send extended NEC it
is 4 bytes. We removed inverted 4
Am 15.12.2010 08:46, schrieb Dmitri Belimov:
Hi Stefan
Am 14.12.2010 04:23, schrieb Dmitri Belimov:
Hi
What about my last patch?? This is OK or bad?
Our customers kick me every day with IR remotes.
With my best regards, Dmitry.
I think, you use the second variant, Dmitry.
Why you doesn't
it
doesn't work
How to main IR core search scancodes in RCMAP keytable?
I think it search full equal scancode value with returned from tm6000.
Example:
defined keytable:
0x86 0x6B 0x00
tm6000 read IR data
0x86 0x00
When return 0x86 0x00 to IR core a key is unknown because
0x86 0x6B 0x00 != 0x86 0x00
I
Am 14.12.2010 04:23, schrieb Dmitri Belimov:
Hi
What about my last patch?? This is OK or bad?
Our customers kick me every day with IR remotes.
With my best regards, Dmitry.
I think, you use the second variant, Dmitry.
Why you doesn't use this key map - RCMAP_BEHOLD.
The power led we can
Hi Stefan
Am 14.12.2010 04:23, schrieb Dmitri Belimov:
Hi
What about my last patch?? This is OK or bad?
Our customers kick me every day with IR remotes.
With my best regards, Dmitry.
I think, you use the second variant, Dmitry.
Why you doesn't use this key map - RCMAP_BEHOLD.
No
Hi
What about my last patch?? This is OK or bad?
Our customers kick me every day with IR remotes.
With my best regards, Dmitry.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Am 08.12.2010 04:55, schrieb Dmitri Belimov:
Hi Stefan
Am 06.12.2010 11:02, schrieb Dmitri Belimov:
Thank you. When I switched to this branch modules is not crash
when USB removed. But disable IR over interrupt after start
video/radio
With my best regards, Dmitry.
changing the interface
Hi
This is my summary changes:
1. Add vendor specific keymap for USB TV card (try git add file, but git diff
doesn't include this into diff)
2. Spilt ir_config and work with a key to different rc_type
3. When rc_type is NEC get first scancode from a scantable cut address and
store it for
Am 06.12.2010 11:02, schrieb Dmitri Belimov:
Thank you. When I switched to this branch modules is not crash when
USB removed. But disable IR over interrupt after start video/radio
With my best regards, Dmitry.
changing the interface configuration by initiation isoc urb can
deactivating the
Hi Stefan
Am 06.12.2010 11:02, schrieb Dmitri Belimov:
Thank you. When I switched to this branch modules is not crash
when USB removed. But disable IR over interrupt after start
video/radio
With my best regards, Dmitry.
changing the interface configuration by initiation isoc urb
[ 150.070160] input: tm5600/60x0 IR (tm6000 #0)
as /class/input/input5 [ 150.070217] rc0: tm5600/60x0 IR (tm6000
#0) as /class/rc/rc0 [ 150.227066] usbcore: registered new
interface driver tm6000 [ 151.063914] tm6000: open called
(dev=video0)
press some keys
[ 168.703849
]
[ 150.070012] Registered IR keymap rc-behold-columbus
[ 150.070160] input: tm5600/60x0 IR (tm6000 #0)
as /class/input/input5 [ 150.070217] rc0: tm5600/60x0 IR (tm6000
#0) as /class/rc/rc0 [ 150.227066] usbcore: registered new
interface driver tm6000 [ 151.063914] tm6000: open called
(dev=video0
that.
See dmesg with my comments
after modprobe tm6000
[ 150.009123] usb 1-1: link qh0-00ff/f4fa0b00 start 0 [1/0 us]
[ 150.070012] Registered IR keymap rc-behold-columbus
[ 150.070160] input: tm5600/60x0 IR (tm6000 #0)
as /class/input/input5 [ 150.070217] rc0: tm5600/60x0 IR (tm6000
#0
Am 01.12.2010 06:47, schrieb Dmitri Belimov:
Hi Stefan
Am 29.11.2010 09:44, schrieb Dmitri Belimov:
Hi
I try add IR for our TV cards.
After my some changes IR is working. But when I remove USB stick
from USB port
What has you change?
1. Add vendor-specific init code for IR.
2. Add
Am 01.12.2010 17:41, schrieb Stefan Ringel:
Am 01.12.2010 06:47, schrieb Dmitri Belimov:
Hi Stefan
Am 29.11.2010 09:44, schrieb Dmitri Belimov:
Hi
I try add IR for our TV cards.
After my some changes IR is working. But when I remove USB stick
from USB port
What has you change?
1. Add
]
[ 150.070012] Registered IR keymap rc-behold-columbus
[ 150.070160] input: tm5600/60x0 IR (tm6000 #0) as /class/input/input5
[ 150.070217] rc0: tm5600/60x0 IR (tm6000 #0) as /class/rc/rc0
[ 150.227066] usbcore: registered new interface driver tm6000
[ 151.063914] tm6000: open called (dev=video0
this problem right
now.
sorry, I don't understand that.
See dmesg with my comments
after modprobe tm6000
[ 150.009123] usb 1-1: link qh0-00ff/f4fa0b00 start 0 [1/0 us]
[ 150.070012] Registered IR keymap rc-behold-columbus
[ 150.070160] input: tm5600/60x0 IR (tm6000 #0) as /class/input
called (dev=video0)
[ 144.825125] usb 1-1: link qh0-00ff/f6762340 start 0 [1/0 us]
[ 144.888012] Registered IR keymap rc-behold-columbus
[ 144.888159] input: tm5600/60x0 IR (tm6000 #0) as /class/input/input5
[ 144.888217] rc0: tm5600/60x0 IR (tm6000 #0) as /class/rc/rc0
[ 145.044067] usbcore
called (dev=video0) [ 144.825125] usb
1-1: link qh0-00ff/f6762340 start 0 [1/0 us] [ 144.888012]
Registered IR keymap rc-behold-columbus [ 144.888159] input:
tm5600/60x0 IR (tm6000 #0) as /class/input/input5 [ 144.888217]
rc0: tm5600/60x0 IR (tm6000 #0) as /class/rc/rc0 [ 145.044067
/TM6010 USB2 board (Load status: 0)
[ 144.671201] tm6000: open called (dev=video0)
[ 144.825125] usb 1-1: link qh0-00ff/f6762340 start 0 [1/0 us]
[ 144.888012] Registered IR keymap rc-behold-columbus
[ 144.888159] input: tm5600/60x0 IR (tm6000 #0) as /class/input/input5
[ 144.888217] rc0
register */
+ err = ir_input_register(ir-input, dev-ir_codes,
+ ir-props, tm6000);
+ if (err)
+ goto err_out_stop;
+
+ return 0;
+
+err_out_stop:
+ dev-ir = NULL;
+err_out_free:
+ kfree(ir);
+ return err;
+}
+
+int tm6000_ir_fini(struct
On Sun, Jun 20, 2010 at 11:38 AM, stefan.rin...@arcor.de wrote:
From: Stefan Ringel stefan.rin...@arcor.de
Signed-off-by: Stefan Ringel stefan.rin...@arcor.de
---
drivers/staging/tm6000/Makefile | 3 +-
drivers/staging/tm6000/tm6000-cards.c | 27 +++-
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am 20.06.2010 18:31, schrieb Jarod Wilson:
On Sun, Jun 20, 2010 at 11:38 AM, stefan.rin...@arcor.de wrote:
From: Stefan Ringel stefan.rin...@arcor.de
Signed-off-by: Stefan Ringel stefan.rin...@arcor.de
---
drivers/staging/tm6000/Makefile
On Sun, Jun 20, 2010 at 12:44 PM, Stefan Ringel stefan.rin...@arcor.de wrote:
Am 20.06.2010 18:31, schrieb Jarod Wilson:
On Sun, Jun 20, 2010 at 11:38 AM, stefan.rin...@arcor.de wrote:
From: Stefan Ringel stefan.rin...@arcor.de
Signed-off-by: Stefan Ringel stefan.rin...@arcor.de
---
,
+ ir-props, tm6000);
+ if (err)
+ goto err_out_stop;
+
+ return 0;
+
+err_out_stop:
+ dev-ir = NULL;
+err_out_free:
+ kfree(ir_input_dev);
+ kfree(ir);
+ return err;
+}
+
+int tm6000_ir_fini(struct tm6000_core *dev)
+{
+ struct tm6000_IR
Hi Stefan,
Em 04-06-2010 18:03, Stefan Ringel escreveu:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Mauro,
I write actually the ir implementation (tm6000-input.c). Can you give
me any stuff what can help me?
I never tried to implement IR support for tm6000, but if you use
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Mauro,
I write actually the ir implementation (tm6000-input.c). Can you give
me any stuff what can help me?
Stefan Ringel
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http
38 matches
Mail list logo
