On 12/11/2014 01:28 AM, Shuah Khan wrote:
Convert au0828 to use videobuf2. Tested with NTSC.
Tested video and vbi devices with xawtv, tvtime,
and vlc. Ran v4l2-compliance to ensure there are
no new regressions in video and vbi now has 3 fewer
failures.
video before:
test
On 11/12/2014 15:03, Philipp Zabel wrote:
Am Mittwoch, den 10.12.2014, 22:04 -0200 schrieb Fabio Estevam:
On Wed, Dec 10, 2014 at 7:54 PM, Pierluigi Passaro
pierluigi.pass...@phoenixsoftware.it wrote:
Hi all,
I'm trying to use VPU code driver on iMX51 with kernel 3.18, following these
steps:
-
Hi Shuah,
This is my review for au0828-vbi.c with your patch applied.
/*
au0828-vbi.c - VBI driver for au0828
Copyright (C) 2010 Devin Heitmueller dheitmuel...@kernellabs.com
This work was sponsored by GetWellNetwork Inc.
This program is free software; you can redistribute
Hi Shuah,
This is the video.c review with your patch applied.
/*
* Auvitek AU0828 USB Bridge (Analog video support)
*
* Copyright (C) 2009 Devin Heitmueller dheitmuel...@linuxtv.org
* Copyright (C) 2005-2008 Auvitek International, Ltd.
*
* This program is free software; you can
Hi Sifan,
On 11/12/14 18:54, Sifan Naeem wrote:
+/*
+ * Timer function to re-enable the current protocol after it had been
+ * cleared when invalid interrupts were generated due to a quirk in
+the
+ * img-ir decoder.
+ */
+static void img_ir_suspend_timer(unsigned long arg) {
+ struct
Hi Sifan,
On 11/12/14 20:06, Sifan Naeem wrote:
Biphase decoding in the current img-ir has got a quirk, where multiple
Interrupts are generated when an incomplete IR code is received by the
decoder.
Patch adds a work around for the quirk and enables biphase decoding.
Changes from v1:
*
Em Fri, 05 Dec 2014 15:53:11 +0100
Guennadi Liakhovetski g.liakhovet...@gmx.de escreveu:
Hi Mauro,
On Fri, 5 Dec 2014, Mauro Carvalho Chehab wrote:
Em Fri, 05 Dec 2014 08:07:07 +0100
Guennadi Liakhovetski g.liakhovet...@gmx.de escreveu:
Hi Mauro,
On Mon, 1 Dec 2014, Mauro
-Original Message-
From: James Hogan
Sent: 12 December 2014 10:56
To: Sifan Naeem; mche...@osg.samsung.com
Cc: linux-ker...@vger.kernel.org; linux-media@vger.kernel.org; James
Hartley; Ezequiel Garcia
Subject: Re: [PATCH 3/5] rc: img-ir: biphase enabled with workaround
Hi
Em Fri, 12 Dec 2014 11:16:01 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Shuah,
This is the video.c review with your patch applied.
/*
* Auvitek AU0828 USB Bridge (Analog video support)
*
* Copyright (C) 2009 Devin Heitmueller dheitmuel...@linuxtv.org
* Copyright (C)
On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote:
Em Fri, 12 Dec 2014 11:16:01 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Shuah,
This is the video.c review with your patch applied.
/*
* Auvitek AU0828 USB Bridge (Analog video support)
*
* Copyright (C) 2009 Devin
Em Fri, 12 Dec 2014 13:55:14 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote:
Em Fri, 12 Dec 2014 11:16:01 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
Hi Shuah,
This is the video.c review with your patch applied.
/*
*
On Thu, Dec 04, 2014 at 10:54:52AM +0100, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
The crop and selection pad ops are duplicates. Replace all uses of
get/set_crop
by get/set_selection. This will make it possible to drop get/set_crop
altogether.
Signed-off-by: Hans
This patch series converts this driver to the vb2 framework.
I have tested video capture with my cx25821 board. Audio capture
DMA works as well, but since my board doesn't have an audio line-in
I couldn't test it with actual audio.
This patch series also removes the last case of btcx-risc abuse,
From: Hans Verkuil hans.verk...@cisco.com
The alsa driver uses videobuf low-level functions that are not
available in vb2, so replace them by driver-specific functions.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/cx25821/cx25821-alsa.c | 107
On Thu, Dec 04, 2014 at 10:54:54AM +0100, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Weird, this op isn't used at all. Seems to be orphaned code.
Remove it.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
--
From: Hans Verkuil hans.verk...@cisco.com
This patch converts the cx25821 driver from the old videobuf framework to
the new vb2 framework.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/cx25821/Kconfig | 2 +-
drivers/media/pci/cx25821/cx25821-core.c | 76
From: Hans Verkuil hans.verk...@cisco.com
The btcx-risc module is no longer used by other drivers except for bttv.
So move it from common to bt8xx and make it part of the bttv driver instead
of as a separate module.
This module should never have been a common module since most of the code
has
From: Hans Verkuil hans.verk...@cisco.com
Add support for the VIDIOC_CREATE_BUFS ioctl. This was missing in this
driver and in vb2 it's trivial to add.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/cx25821/cx25821-video.c | 7 ++-
1 file changed, 6 insertions(+),
On Thu, Dec 04, 2014 at 10:54:53AM +0100, Hans Verkuil wrote:
From: Hans Verkuil hans.verk...@cisco.com
Drop the duplicate get/set_crop pad ops and only use get/set_selection.
It makes no sense to have two duplicate ops in the internal subdev API.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
The video output functionality never worked for this driver. Now remove the
creation of the output video nodes as well to prevent users from thinking
that video output is available, when it isn't.
To correctly implement this the video output should use
From: Hans Verkuil hans.verk...@cisco.com
Remove this comment block, it's unused. This removes the btcx_riscmem
reference as well, since that will no longer be available to other
drivers except bttv.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/usb/cx231xx/cx231xx.h | 10
From: Hans Verkuil hans.verk...@cisco.com
Those btcx_risc functions are meant for use with bttv, other drivers
should just allocate the memory themselves.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/pci/cx25821/Kconfig | 1 -
drivers/media/pci/cx25821/Makefile
On 11/05/2014 09:11 PM, Andrey Utkin wrote:
Dropping code (introduced in 316d9e84a72069e04e483de0d5934c1d75f6a44c)
which intends to make raising of motion events more smooth(?).
It made motion event never appear in my installation.
That code is complicated, so I couldn't figure out quickly
Hi Mauro,
The first 9 patches are all fixes that need to go to kernel 3.19.
The last three patches deprecate drivers. Since I haven't seen a reply from
Ondrej yet regarding the parport drivers, I will leave it up to you whether
you will apply the last patch to 3.19 or not. I pinged him again, so
On Fri, Dec 12, 2014 at 3:30 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Acked-by: Hans Verkuil hans.verk...@cisco.com
I have tested this and it looks good. I am not sure what problems I had
originally that caused me to write that code, since it is now functioning
as expected.
So you can
On 12/12/14 12:07, James Hogan wrote:
Hi Sifan,
On 11/12/14 20:06, Sifan Naeem wrote:
Biphase decoding in the current img-ir has got a quirk, where multiple
Interrupts are generated when an incomplete IR code is received by the
decoder.
Patch adds a work around for the quirk and enables
On Wednesday 10 December 2014, Hans Verkuil wrote:
On 12/02/14 23:42, Ondrej Zary wrote:
On Tuesday 02 December 2014 16:40:30 Hans Verkuil wrote:
This patch series deprecates the vino/saa7191 video driver (ancient SGI
Indy computer), the parallel port webcams bw-qcam, c-qcam and w9966, the
On 12/12/2014 03:29 PM, Ondrej Zary wrote:
On Wednesday 10 December 2014, Hans Verkuil wrote:
On 12/02/14 23:42, Ondrej Zary wrote:
On Tuesday 02 December 2014 16:40:30 Hans Verkuil wrote:
This patch series deprecates the vino/saa7191 video driver (ancient SGI
Indy computer), the parallel
On 12/12/2014 02:42 AM, Hans Verkuil wrote:
Hi Shuah,
This is my review for au0828-vbi.c with your patch applied.
Thanks. Will fix all of these.
-- Shuah
/*
au0828-vbi.c - VBI driver for au0828
Copyright (C) 2010 Devin Heitmueller dheitmuel...@kernellabs.com
This work was
Hi Hans,
Thanks for a quick review.
On 12/12/2014 03:16 AM, Hans Verkuil wrote:
Hi Shuah,
This is the video.c review with your patch applied.
/*
* Auvitek AU0828 USB Bridge (Analog video support)
*
* Copyright (C) 2009 Devin Heitmueller dheitmuel...@linuxtv.org
* Copyright (C)
On 12/12/2014 08:28 AM, Hans Verkuil wrote:
On 12/12/2014 04:26 PM, Shuah Khan wrote:
On 12/12/2014 06:14 AM, Mauro Carvalho Chehab wrote:
Em Fri, 12 Dec 2014 13:55:14 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote:
Em Fri, 12 Dec 2014
Hi Laurent,
I'll check the patches you indicated on
git://linuxtv.org/pinchartl/media.git omap3isp/tvp5151
Which version of the kernel are these patches for?
Regards
Francesco
Il giorno Tue, 02 Dec 2014 01:41:23 +0200
Laurent Pinchart laurent.pinch...@ideasonboard.com ha scritto:
No, tvtime no longer hangs if no frames arrive, so there is no need for
this timeout handling. I'd strip it out, which can be done in a separate
patch.
Did you actually try it? Do you have some patches to tvtime which
aren't upstream?
I wrote the comment in question (and added the associated
On 12/12/2014 04:52 PM, Devin Heitmueller wrote:
No, tvtime no longer hangs if no frames arrive, so there is no need for
this timeout handling. I'd strip it out, which can be done in a separate
patch.
Did you actually try it?
Mauro tried it, not me. I'm not sure if he looked at whether the
In short, that code cannot be removed.
Sure it can. I just tried tvtime and you are right, it blocks the GUI.
But the fix is very easy as well. So now I've updated tvtime so that
it timeouts and gives the GUI time to update itself.
That's a nice change to tvtime and I'm sure it will make it
This patch adds three new RGB media bus formats that describe
18-bit or 24-bit samples transferred over an LVDS bus with three
or four differential data pairs, serialized into 7 time slots,
using standard SPWG/PSWG/VESA or JEIDA data ordering.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Am Freitag, den 12.12.2014, 10:15 +0100 schrieb Pierluigi Passaro:
On 11/12/2014 15:03, Philipp Zabel wrote:
Am Mittwoch, den 10.12.2014, 22:04 -0200 schrieb Fabio Estevam:
On Wed, Dec 10, 2014 at 7:54 PM, Pierluigi Passaro
pierluigi.pass...@phoenixsoftware.it wrote:
Hi all,
I'm trying
Em Fri, 12 Dec 2014 11:46:13 -0500
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
In short, that code cannot be removed.
Sure it can. I just tried tvtime and you are right, it blocks the GUI.
But the fix is very easy as well. So now I've updated tvtime so that
it timeouts and
As we've discussed on IRC channel, it would be good to add support
for format enumeration on it, but the changes don't seem to be
trivial. I'm not willing to do it, due to my lack of time, but,
if someone steps up for doing that, then we can wait for those
patches before bumping the version.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 4d80046..746cc94 100644
---
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 107552a..4d80046 100644
---
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index ab48b5f..cdc342a 100644
---
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Dec 13 04:00:22 CET 2014
git branch: test
git hash: e272d95f8c0544cff55c485a10828b063c8e417c
gcc
That breaks DVB-C lock check as old utmp = 0x08 was set according to
DVB-C lock check, right?
Antti
On 12/13/2014 02:18 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 9 -
1 file changed, 8
I am not sure even idea of that. You didn't add even commit description,
like all the other patches too :( You should really start adding commit
messages explaining why and how commit is.
So the question is why that patch should be applied?
On the other-hand, how there is
if (fe-id == 1
That patch is simply wrong. Kernel logging system is able to add
function name automatically - it should not be defined manually for
debug logging.
See kernel documentation:
Documentation/dynamic-debug-howto.txt
around the line 213.
--
The flags are:
p
On 12/13/2014 02:18 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
Reviewed-by: Antti Palosaari cr...@iki.fi
Even I could accept that, as a staging driver, I see there some issues:
* missing commit message (ok, it is trivial and patch subject says)
* it
47 matches
Mail list logo
