[patch] media/ov511: cleanup: remove unneeded null check

2010-05-05 Thread Dan Carpenter
We dereference ov unconditionally throughout the function so there is no way it can be NULL here. This code has been around for ages so if it were possible for ov to be NULL someone would have complained. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/ov511.c

[patch -next 2/2] media/s2255drv: remove dead code

2010-05-05 Thread Dan Carpenter
My concern initially was we dereference dev in the parameter list to s2255_dev_err() but it turns out that code path is never used. The s2255_stop_readpipe() is only called from one place and dev is never null. So this patch just removes the whole condition here. Signed-off-by: Dan Carpenter

[patch -next 1/2] media/s2255drv: return if vdev not found

2010-05-05 Thread Dan Carpenter
The original code didn't handle the case where vdev was not found so I added a check for that. Signed-off-by: Dan Carpenter erro...@gmail.com diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c index ac9c40c..1f9a49e 100644 --- a/drivers/media/video/s2255drv.c +++

Re: tm6000 calculating urb buffer

2010-05-05 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 04.05.2010 21:50, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: datagram from urb to videobuf urb copy to temp copy to 1. videobuf buffer

Re: tm6000

2010-05-05 Thread Dmitri Belimov
On Wed, 5 May 2010 13:44:38 +0800 Bee Hock Goh beeh...@gmail.com wrote: Did you comment off the code in the get_next_buff that clear the previous frame data? No. Git tree + my last patch. With my best regards, Dmitry. On Wed, May 5, 2010 at 12:50 PM, Dmitri Belimov d.beli...@gmail.com

-next: staging/cx25821: please revert 7a02f549fcc

2010-05-05 Thread Dan Carpenter
This was my patch: cx25821: fix double unlock in medusa_video_init() It accidentally got merged two times. The version from the staging tree is not correct. Please can you revert it: 7a02f549fcc30fe6be0c0024beae9a3db22e1af6 Staging: cx25821: fix double unlock in medusa_video_init() I guess

Re: [PATCH] Rework for support xc5000

2010-05-05 Thread Dmitri Belimov
On Wed, 5 May 2010 10:16:27 +0800 Bee Hock Goh beeh...@gmail.com wrote: There does not seem to be any radio support in the tm6000 codes. tun_setup.mode_mask |= (T_ANALOG_TV | T_RADIO); Is the T_RADIO mode still required since this is a cleanup? Now radio may be not work. But we want write

Re: tm6000

2010-05-05 Thread Bee Hock Goh
If you do that you will get some decent looking video. On Wed, May 5, 2010 at 3:27 PM, Dmitri Belimov d.beli...@gmail.com wrote: On Wed, 5 May 2010 13:44:38 +0800 Bee Hock Goh beeh...@gmail.com wrote: Did you comment off the code in the get_next_buff that clear the previous frame data? No.

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Simon Kenyon
On 31/03/2009 21:10, Antti Palosaari wrote: Moi Mauro, Please pull from http://linuxtv.org/hg/~anttip/af9015/ for the following: af9015: remove experimental af9015: add new USB ID for KWorld USB DVB-T TV Stick II (VS-DVB-T 395U) af9015: add support for TrekStor DVB-T USB Stick af9015: remove

Re: UVC Webcam

2010-05-05 Thread Laurent Pinchart
Hi Gijo, On Thursday 29 April 2010 12:54:16 Gijo Prems wrote: Hello, I have some queries related to linux uvc client driver(uvcvideo) and general uvc webcam functionality. 1. There is a wDelay (during probe-commit) parameter which camera exposes to the host signifying the delay (Latency)

[PATCH] tda10048: fix the uncomplete function tda10048_read_ber

2010-05-05 Thread Guillaume Audirac
Hello, Completes the bit-error-rate read function with the CBER register (before Viterbi decoder). The returned value is 1e8*actual_ber to be positive. Also includes some typo mistakes. Signed-off-by: Guillaume Audirac guillaume.audi...@webag.fr --- drivers/media/dvb/frontends/tda10048.c |

Help Central

2010-05-05 Thread Support
This is to inform you that you have exceeded your email quota limit of 625MB and you need to increase your email quota limit because in less than 48 hours your email will be disable. Increase your email quota limit and continue to use your webmail account. To increase your email quota limit

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Bee Hock Goh
Simon, There is already a patch that will make af9105/tda18218 work. However, it seem that there is no active effort to merge with the mainstream code. I have been running that codes with mythtv(recording only) for quite a while and its working fine. https://patchwork.kernel.org/patch/82494/

Re: [PATCH] tda10048: fix the uncomplete function tda10048_read_ber

2010-05-05 Thread Steven Toth
Completes the bit-error-rate read function with the CBER register (before Viterbi decoder). The returned value is 1e8*actual_ber to be positive. Also includes some typo mistakes. Signed-off-by: Guillaume Audirac guillaume.audi...@webag.fr Thanks Guillaume, I have a pile of other patches I'm

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Bee Hock Goh
Antti, Thanks for coming out to clarify. So the step going forward is to getting clearance from Lauris? I didnt really look at the codes but the your tree with the tda18218 patch seem to working very well for me. http://ubuntuforums.org/showthread.php?p=8936585 On Wed, May 5, 2010 at 8:58 PM,

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Antti Palosaari
On 05/05/2010 03:36 PM, Bee Hock Goh wrote: There is already a patch that will make af9105/tda18218 work. However, it seem that there is no active effort to merge with the mainstream code. I have been running that codes with mythtv(recording only) for quite a while and its working fine.

Re: tm6000

2010-05-05 Thread Mauro Carvalho Chehab
Dmitri Belimov wrote: On Wed, 5 May 2010 13:44:38 +0800 Bee Hock Goh beeh...@gmail.com wrote: Did you comment off the code in the get_next_buff that clear the previous frame data? No. Git tree + my last patch. A green tree can happen due to lots of conditions, like: 1) it

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Simon Kenyon
On 05/05/2010 13:36, Bee Hock Goh wrote: Simon, There is already a patch that will make af9105/tda18218 work. However, it seem that there is no active effort to merge with the mainstream code. I have been running that codes with mythtv(recording only) for quite a while and its working fine.

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Bee Hock Goh
You need to follow this link: http://ubuntuforums.org/showthread.php?p=8936585 If you download the correct version of the antti af9015 tree, you can apply the patch correctly and it will work(a tda18218/af9015 stick) without any code change. On Wed, May 5, 2010 at 10:00 PM, Simon Kenyon

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Bee Hock Goh
Use the attached firmware which work well for me. An earlier firmware will hung the stick and this version fixed that issue. On Wed, May 5, 2010 at 10:07 PM, Bee Hock Goh beeh...@gmail.com wrote: You need to follow this link: http://ubuntuforums.org/showthread.php?p=8936585 If you download

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Bee Hock Goh
On Wed, May 5, 2010 at 10:13 PM, Bee Hock Goh beeh...@gmail.com wrote: Use the attached firmware which work well for me. An earlier firmware will hung the stick and this version fixed that issue. On Wed, May 5, 2010 at 10:07 PM, Bee Hock Goh beeh...@gmail.com wrote: You need to follow this

Re: [PULL] http://linuxtv.org/hg/~anttip/af9015/

2010-05-05 Thread Simon Kenyon
On 05/05/2010 15:07, Bee Hock Goh wrote: You need to follow this link: http://ubuntuforums.org/showthread.php?p=8936585 If you download the correct version of the antti af9015 tree, you can apply the patch correctly and it will work(a tda18218/af9015 stick) without any code change. thanks

[PATCH] media/IR: Add missing include file to rc-map.c

2010-05-05 Thread Peter Hüwe
From: Peter Huewe peterhu...@gmx.de This patch adds a missing include linux/delay.h to prevent build failures[1-5] Signed-off-by: Peter Huewe peterhu...@gmx.de --- KernelVersion: linux-next-20100505 References: [1] http://kisskb.ellerman.id.au/kisskb/buildresult/2571452/ [2] http

Re: -next: staging/cx25821: please revert 7a02f549fcc

2010-05-05 Thread Mauro Carvalho Chehab
Dan Carpenter wrote: This was my patch: cx25821: fix double unlock in medusa_video_init() It accidentally got merged two times. The version from the staging tree is not correct. Please can you revert it: 7a02f549fcc30fe6be0c0024beae9a3db22e1af6 Staging: cx25821: fix double unlock in

RE: -next: staging/cx25821: please revert 7a02f549fcc

2010-05-05 Thread Palash Bandyopadhyay
Will do. Thanks for passing over the info. Regards, Palash -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Wednesday, May 05, 2010 8:30 AM To: Dan Carpenter; Palash Bandyopadhyay Cc: Greg Kroah-Hartman; linux-media@vger.kernel.org Subject: Re: -next:

Re: [GIT PATCHES FOR 2.6.35] sn9c20x updates

2010-05-05 Thread Brian Johnson
On Sat, May 1, 2010 at 10:36 AM, Brian Johnson brij...@gmail.com wrote: The following changes since commit d3be2fab3a10b6c798a5f9970146d166d3345c37:  Jean-François Moine (1):        V4L/DVB: gspca - zc3xx: Fix the gamma calculation from the contrast are available in the git repository at:  

[PATCH/RFC 5/7] dsbr100: properly initialize the radio

2010-05-05 Thread David Ellingsworth
This patch adds a flag to indicate if the radio has been initialized or not. If the flag has not been set upon open, the radio initialized to a known state. It combines the STARTED/STOPPED indicators into a single MUTED flag and defines a couple of macros for determining the status of the radio.

[PATCH/RFC 2/7] dsbr100: fix potential use after free

2010-05-05 Thread David Ellingsworth
Signed-off-by: David Ellingsworth da...@identd.dyndns.org --- drivers/media/radio/dsbr100.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c index 673eda8..2f96e13 100644 --- a/drivers/media/radio/dsbr100.c +++

[PATCH/RFC 1/7] dsbr100: implement proper locking

2010-05-05 Thread David Ellingsworth
Signed-off-by: David Ellingsworth da...@identd.dyndns.org --- drivers/media/radio/dsbr100.c | 77 +--- 1 files changed, 33 insertions(+), 44 deletions(-) diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c index ed9cd7a..673eda8 100644

[PATCH/RFC 3/7] dsbr100: only change frequency upon success

2010-05-05 Thread David Ellingsworth
Signed-off-by: David Ellingsworth da...@identd.dyndns.org --- drivers/media/radio/dsbr100.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c index 2f96e13..b62fe40 100644 ---

[PATCH/RFC 6/7] dsbr100: cleanup usb probe routine

2010-05-05 Thread David Ellingsworth
This patch simplifies the error paths within the usb_dsbr100_probe routine. It also removes an unnecessary local variable. Signed-off-by: David Ellingsworth da...@identd.dyndns.org --- drivers/media/radio/dsbr100.c | 39 --- 1 files changed, 20

[PATCH/RFC 4/7] dsbr100: remove disconnected indicator

2010-05-05 Thread David Ellingsworth
Signed-off-by: David Ellingsworth da...@identd.dyndns.org --- drivers/media/radio/dsbr100.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c index b62fe40..c949ace 100644 --- a/drivers/media/radio/dsbr100.c

[PATCH/RFC 0/7] dsbr100: driver cleanup

2010-05-05 Thread David Ellingsworth
This patch series addresses several issues in the dsbr100 driver. This series is based on the v4l-dvb master git branch and has been compile tested only. It should be tested before applying. The following patches are included in this series: [PATCH/RFC 1/7] dsbr100: implement proper locking

[PATCH/RFC 7/7] dsbr100: simplify access to radio device

2010-05-05 Thread David Ellingsworth
This patch replaces calls to video_drvdata with references to struct file-private_data which is set during usb_dsbr100_open. This value is passed by video_ioctl2 via the *priv argument and is accessible via file-private_data otherwise. Signed-off-by: David Ellingsworth da...@identd.dyndns.org ---

[cron job] v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: ERRORS

2010-05-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Wed May 5 19:00:28 CEST 2010 path:http://www.linuxtv.org/hg/v4l-dvb changeset: 14644:4a8d6d981f07 git master:

Re: [PATCH] fix dvb frontend lockup

2010-05-05 Thread matthieu castet
matthieu castet a écrit : Hi, With my current kernel (2.6.32), if my dvb device is removed while in use, I got [1]. After checking the source code, the problem seems to happen also in master : If there are users (for example users == -2) : - dvb_unregister_frontend : - stop kernel thread

[PATCH] videobuf: remove external function videobuf_dma_sync()

2010-05-05 Thread Mauro Carvalho Chehab
While analyzing one of the videobuf patches, I noticed that videobuf_dma_sync is only used internally inside videobuf-dma-sg. So, let's remove this function, merging the code at __videobuf_dma_sync() Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git

Re: -next: staging/cx25821: please revert 7a02f549fcc

2010-05-05 Thread Dan Carpenter
On Wed, May 05, 2010 at 12:30:01PM -0300, Mauro Carvalho Chehab wrote: This simplifies the code a little bit, and, instead of just return -EINVAL, it will return the error condition reported by the called functions. Thanks for that. There was one return that got missed. Probably you can

[PATCH] videobuf-vmalloc: remove __videobuf_sync()

2010-05-05 Thread Mauro Carvalho Chehab
videobuf-core checks if .sync ops is defined before calling. So, we don't need a do-nothing function. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com -- Cheers, Mauro diff --git a/drivers/media/video/videobuf-vmalloc.c b/drivers/media/video/videobuf-vmalloc.c index f8b5b56..583728f

Re: [PATCH/RFC 1/7] dsbr100: implement proper locking

2010-05-05 Thread Hans Verkuil
On Wednesday 05 May 2010 19:05:24 David Ellingsworth wrote: Signed-off-by: David Ellingsworth da...@identd.dyndns.org Does this actually fix bugs or does this just clean up the locking? I ask because I am planning to make it easier to do locking for ioctl calls. Basically there will be pre-hook

[GIT PATCHES FOR 2.6.35] tvp7002 fixes

2010-05-05 Thread Hans Verkuil
The following changes since commit d3be2fab3a10b6c798a5f9970146d166d3345c37: Jean-François Moine (1): V4L/DVB: gspca - zc3xx: Fix the gamma calculation from the contrast are available in the git repository at: ssh://linuxtv.org/git/hverkuil/v4l-dvb.git tvp7002 Tested on a DM6467T

[videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup() call?

2010-05-05 Thread Aguirre, Sergio
Hi all, While working on an old port of the omap3 camera-isp driver, I have faced some problem. Basically, when calling VIDIOC_REQBUFS with a certain buffer Count, we had a software limit for total size, calculated depending on: Total bytesize = bytesperline x height x count So, we had an

Re: [PATCH v1 1/1] V4L: Add sync before a hardware operation to videobuf.

2010-05-05 Thread Mauro Carvalho Chehab
Pawel Osciak wrote: Architectures with non-coherent CPU cache (e.g. ARM) may require a cache flush or invalidation before starting a hardware operation if the data in a video buffer being queued has been touched by the CPU. This patch adds calls to sync before a hardware operation that are

[RFC] Third OLPC viafb patch series (camera driver)

2010-05-05 Thread Jonathan Corbet
This is, perhaps, the last set of viafb patches I'll send around before the merge window. This series completes the task of adding the via-camera driver - in the correct spot, this time. To that end, it has to reorganize the viafb header files a bit. V4L2 folks: only the final patch in this

[PATCH 2/5] viafb: get rid of i2c debug cruft

2010-05-05 Thread Jonathan Corbet
It's ugly and adds a global.h dependency. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/via_i2c.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/via/via_i2c.c b/drivers/video/via/via_i2c.c index febc1dd..84ec2d6 100644 ---

[PATCH 1/5] viafb: fold via_io.h into via-core.h

2010-05-05 Thread Jonathan Corbet
Preparatory move toward the ultimate goal of moving pan-subdevice stuff into include/linux. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/hw.h |1 - drivers/video/via/share.h | 11 ++ drivers/video/via/via-core.h| 48

[PATCH 5/5] Add the viafb video capture driver

2010-05-05 Thread Jonathan Corbet
Add a driver for the video capture port on VIA integrated chipsets. This version has a remaining OLPCism or two and expects to be talking to an ov7670; those can be improved as the need arises. This work was supported by the One Laptop Per Child project. Signed-off-by: Jonathan Corbet

[PATCH 4/5] viafb: move some include files to include/linux

2010-05-05 Thread Jonathan Corbet
These are the files which should be available to subdevices compiled outside of drivers/video/via. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/accel.c |2 +- drivers/video/via/dvi.c |4 +- drivers/video/via/hw.c |3 +-

[PATCH 3/5] viafb: Eliminate some global.h references

2010-05-05 Thread Jonathan Corbet
The various subdev drivers (other than the framebuffer itself) no longer need this file. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/via-gpio.c |1 - drivers/video/via/via_i2c.c |4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH -next] media: fix vivi build error

2010-05-05 Thread Randy Dunlap
+- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20100505.orig/drivers/media/video/Kconfig +++ linux-next-20100505/drivers/media/video/Kconfig @@ -559,7 +559,7 @@ config VIDEO_DAVINCI_VPIF config VIDEO_VIVI tristate Virtual Video Driver - depends on VIDEO_DEV

setting up a tevii s660

2010-05-05 Thread Tim Coote
Hullo I've been struggling with this for a couple of days. I have checked archives, but missed anything useful. I've got a tevii s660 (dvbs2 via usb). It works with some limitations on windows xp (I cannot get HD signals decoded, but think that's a limitation of the software that comes on

Re: [videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup() call?

2010-05-05 Thread Mauro Carvalho Chehab
Aguirre, Sergio wrote: Hi all, While working on an old port of the omap3 camera-isp driver, I have faced some problem. Basically, when calling VIDIOC_REQBUFS with a certain buffer Count, we had a software limit for total size, calculated depending on: Total bytesize = bytesperline x

RE: [videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup() call?

2010-05-05 Thread Aguirre, Sergio
-Original Message- From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Wednesday, May 05, 2010 6:24 PM To: Aguirre, Sergio Cc: linux-media@vger.kernel.org Subject: Re: [videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup() call? Aguirre, Sergio

Re: [videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup() call?

2010-05-05 Thread Mauro Carvalho Chehab
Aguirre, Sergio wrote: -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Wednesday, May 05, 2010 6:24 PM To: Aguirre, Sergio Cc: linux-media@vger.kernel.org Subject: Re: [videobuf] Query: Condition bytesize limit in videobuf_reqbufs - buf_setup()

Re: [PATCH 2/2] V4L/DVB: buf-dma-sg.c: support non-pageable user-allocated memory

2010-05-05 Thread Mauro Carvalho Chehab
Hi Arnout, Arnout Vandecappelle wrote: videobuf_dma_init_user_locked() uses get_user_pages() to get the virtual-to-physical address mapping for user-allocated memory. However, the user-allocated memory may be non-pageable because it is an I/O range or similar. get_user_pages() fails with

Re: [PATCH] tda10048: fix the uncomplete function tda10048_read_ber

2010-05-05 Thread Guillaume Audirac
Hello Steven, Thanks Guillaume, I have a pile of other patches I'm ready to present for merge so I'll pull this into one of my dev trees and present this for merge also of course, I'll test it first! :) Thanks again for working on this. You're welcome. I am just starting reviewing the