[PATCH-Trivial 2/2] [media] s5p-fimc: Add missing braces around sizeof

2012-08-16 Thread Sachin Kamat
Silences the following warning: WARNING: sizeof *ctx should be sizeof(*ctx) Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/fimc-capture.c |2 +- drivers/media/platform/s5p-fimc/fimc-m2m.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/m

[PATCH-Trivial 1/2] [media] s5p-fimc: Replace asm/* headers with linux/*

2012-08-16 Thread Sachin Kamat
Silences the following warning: WARNING: Use #include instead of Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/fimc-core.h |2 +- drivers/media/platform/s5p-fimc/fimc-lite.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s

[PATCH-Trivial] [media] s5p-mfc: Add missing braces around sizeof

2012-08-16 Thread Sachin Kamat
Silences the following warnings: WARNING: sizeof *ctx should be sizeof(*ctx) WARNING: sizeof *dev should be sizeof(*dev) Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p

[PATCH 1/1] driver-core: Shut up dev_dbg_reatelimited() without DEBUG

2012-08-16 Thread Hiroshi Doyu
dev_dbg_reatelimited() without DEBUG printed "217078 callbacks suppressed". This shouldn't print anything without DEBUG. Signed-off-by: Hiroshi Doyu Reported-by: Antti Palosaari --- include/linux/device.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/include/linu

Re: noisy dev_dbg_ratelimited()

2012-08-16 Thread Hiroshi Doyu
On Thu, 16 Aug 2012 22:29:43 +0200 Hin-Tak Leung wrote: > --- On Thu, 16/8/12, Antti Palosaari wrote: > > > Hello Hiroshi > > > > On 08/16/2012 10:12 AM, Hiroshi Doyu wrote: > > > Hi Antti, > > > > > > Antti Palosaari > > wrote @ Thu, 16 Aug 2012 03:11:56 +0200: > > > > > >> Hello Hiroshi, >

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Sekhar Nori
On 8/17/2012 10:51 AM, Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote: >> Hi Prabhakar, >> >> Thanks for the patch. >> >> On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> Signe

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> Signed-off-by: Lad, Prabhakar >> Signed-off-by: Manjunath Hadli

[PATCH] [media] smiapp: Remove unused function

2012-08-16 Thread Sachin Kamat
smiapp_replace_limit_at() function is not called by the driver. This was detected by sparse as: drivers/media/i2c/smiapp/smiapp-quirk.c:64:5: warning: symbol 'smiapp_replace_limit_at' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/i2c/smiapp/smiapp-quirk.c |

[PATCH v2] smiapp: Use devm_* functions in smiapp-core.c file

2012-08-16 Thread Sachin Kamat
devm_* functions are device managed functions and make code a bit smaller and cleaner. Signed-off-by: Sachin Kamat --- Changes since v1: Used devm_kzalloc for sensor->nvm. Used devm_clk_get and devm_regulator_get functions. This patch is based on Mauro's re-organized tree (media_tree staging/for

Re: [PATCH] smiapp: Use devm_kzalloc() in smiapp-core.c file

2012-08-16 Thread Sachin Kamat
Hi Sakari, Thanks for reviewing the patch. On 16 August 2012 22:26, Sakari Ailus wrote: > Hi Sachin, > > Thanks for the patch. > > On Thu, Aug 16, 2012 at 04:59:30PM +0530, Sachin Kamat wrote: >> devm_kzalloc is a device managed function and makes code a bit >> smaller and cleaner. >> >> Signed-

[samsung:v4l-exynos-gsc 77/299] drivers/media/video/em28xx/em28xx-video.c:2269:17-20: ERROR: reference preceded by free on line 2267

2012-08-16 Thread Fengguang Wu
Hi Hans, FYI, there are new coccinelle warnings show up in tree: git://git.infradead.org/users/kmpark/linux-samsung v4l-exynos-gsc head: 8ac9447881f291e7b473d946bde20ec952621a23 commit: 876cb14db3bec19960751bb02f03f72ee024a46f [77/299] [media] em28xx: remove V4L2_FL_LOCK_ALL_FOPS All coccin

[PATCH] dvb-usb: remove unused files

2012-08-16 Thread Antti Palosaari
Those files were left from dvb-usb-v2 development as I have made mistake during rebase operation. Reported-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb/dvb_usb_dvb.c| 403 - drivers/media/usb/dvb-usb/dvb_usb_remote.c | 117 ---

[PATCH] dvb_usb_v2: use ratelimited debugs where appropriate

2012-08-16 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/usb_urb.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/usb_urb.c b/drivers/media/usb/dvb-usb-v2/usb_urb.c index eaf673a..5989b65 100644 --- a/drivers/media/usb/dvb-usb-v2/

[PATCH 4/4] dvb_frontend: add routine for DTMB parameter validation

2012-08-16 Thread Antti Palosaari
Common routine for use of dvb-core, demodulator and tuner for check given DTMB parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 97 +++ drivers/media/dvb-core/dvb_frontend.h | 1 + 2 files changed, 98 insertions(+

[PATCH 1/4] dvb_frontend: add routine for DVB-T parameter validation

2012-08-16 Thread Antti Palosaari
Common routine for use of dvb-core, demodulator and tuner for check given DVB-T parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 136 ++ drivers/media/dvb-core/dvb_frontend.h | 2 + 2 files changed, 138 insertion

[PATCH 0/4] dvb_frontend: few DTV validation routines

2012-08-16 Thread Antti Palosaari
It could be nice to validate transmission parameters, coming from the userspace, against standards before those are passed to the individual chipset driver. As a starting point towards that I implemented checks for few common standards. Those checks could be better as I added almost none checks for

[PATCH 3/4] dvb_frontend: add routine for DVB-C annex A parameter validation

2012-08-16 Thread Antti Palosaari
Common routine for use of dvb-core, demodulator and tuner for check given DVB-C annex A parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 54 +++ drivers/media/dvb-core/dvb_frontend.h | 1 + 2 files changed, 55 ins

[PATCH 2/4] dvb_frontend: add routine for DVB-T2 parameter validation

2012-08-16 Thread Antti Palosaari
Common routine for use of dvb-core, demodulator and tuner for check given DVB-T2 parameters correctness. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 118 ++ drivers/media/dvb-core/dvb_frontend.h | 1 + 2 files changed, 119 insertio

[PATCH 6/6] DVB API: LNA documentation

2012-08-16 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/dvb/dvbproperty.xml | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml index d188be9..2dfa6a0 100644 --- a/Documenta

[PATCH 3/6] cxd2820r: use Kernel GPIO for GPIO access

2012-08-16 Thread Antti Palosaari
Currently there is LNA behind cxd2820r demodulator GPIO. Use Kernel GPIO interface to access those GPIOs. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/cxd2820r.h | 14 ++-- drivers/media/dvb-frontends/cxd2820r_c.c| 5 -- drivers/media/dvb-frontends/cxd2820r_core.c |

[PATCH 5/6] cxd2820r: GPIO when GPIOLIB is undefined

2012-08-16 Thread Antti Palosaari
Use static GPIO config when GPIOLIB is undefined. It is fallback condition as GPIOLIB seems to be disabled by default. Better solution is needed, maybe GPIOLIB could be enabled by default? Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/cxd2820r_core.c | 29 ---

[PATCH 4/6] em28xx: implement FE set_lna() callback

2012-08-16 Thread Antti Palosaari
Make LNA run-time switching possible for PCTV nanoStick T2 290e! Signed-off-by: Antti Palosaari --- drivers/media/usb/em28xx/em28xx-dvb.c | 40 ++- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/medi

[PATCH 2/6] cxd2820r: switch to Kernel dev_* logging

2012-08-16 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/cxd2820r_c.c| 26 - drivers/media/dvb-frontends/cxd2820r_core.c | 84 - drivers/media/dvb-frontends/cxd2820r_priv.h | 13 - drivers/media/dvb-frontends/cxd2820r_t.c| 28 +- drive

[PATCH 1/6] add LNA support for DVB API

2012-08-16 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb_frontend.c | 5 + drivers/media/dvb-core/dvb_frontend.h | 1 + include/linux/dvb/frontend.h | 4 +++- include/linux/dvb/version.h | 2 +- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/me

[PATCH 0/6] DVB API LNA

2012-08-16 Thread Antti Palosaari
LNA API and one implementation as for example. Implementation relies Kernel GPIOLIB as LNAs are typically controlled by GPIO. Anyhow, GPIOLIB seems to be disabled by default thus I was forced to add some glue macros to handle situation where GPIOLIB is not available. But lets try to found out sol

Re: [RFC 0/5] Generic panel framework

2012-08-16 Thread Jingoo Han
On Friday, August 17, 2012 9:50 AM Laurent Pinchart wrote: > > Hi everybody, > > While working on DT bindings for the Renesas Mobile SoC display controller > (a.k.a. LCDC) I quickly realized that display panel implementation based on > board code callbacks would need to be replaced by a driver-ba

Re: [PATCH] dvb_frontend: Multistream support

2012-08-16 Thread Akihiro TSUKADA
Hi, > diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.h > b/drivers/media/dvb/dvb-core/dvb_frontend.h > index 7c64c09..bec0cda 100644 > --- a/drivers/media/dvb/dvb-core/dvb_frontend.h > +++ b/drivers/media/dvb/dvb-core/dvb_frontend.h > @@ -368,11 +368,8 @@ struct dtv_frontend_properties { >

[RFC 3/5] video: panel: Add MIPI DBI bus support

2012-08-16 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- drivers/video/panel/Kconfig |4 + drivers/video/panel/Makefile|1 + drivers/video/panel/panel-dbi.c | 217 +++ include/video/panel-dbi.h | 92 + 4 files changed, 314 insertions(+), 0 d

[RFC 5/5] video: panel: Add R61517 panel support

2012-08-16 Thread Laurent Pinchart
The R61517 is a MIPI DBI panel controller from Renesas. Signed-off-by: Laurent Pinchart --- drivers/video/panel/Kconfig|9 + drivers/video/panel/Makefile |1 + drivers/video/panel/panel-r61517.c | 408 include/video/panel-r61517.h

[RFC 4/5] video: panel: Add R61505 panel support

2012-08-16 Thread Laurent Pinchart
The R61505 is a SYS-80 bus panel controller from Renesas. Signed-off-by: Laurent Pinchart --- drivers/video/panel/Kconfig|9 + drivers/video/panel/Makefile |1 + drivers/video/panel/panel-r61505.c | 520 include/video/panel-r61505.h

[RFC 1/5] video: Add generic display panel core

2012-08-16 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- drivers/video/Kconfig|1 + drivers/video/Makefile |1 + drivers/video/panel/Kconfig |4 + drivers/video/panel/Makefile |1 + drivers/video/panel/panel.c | 269 ++ include/video/panel.h

[RFC 2/5] video: panel: Add dummy panel support

2012-08-16 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart --- drivers/video/panel/Kconfig | 11 drivers/video/panel/Makefile |1 + drivers/video/panel/panel-dummy.c | 103 + include/video/panel-dummy.h | 25 + 4 files changed, 140 insertions(+), 0

[RFC 0/5] Generic panel framework

2012-08-16 Thread Laurent Pinchart
Hi everybody, While working on DT bindings for the Renesas Mobile SoC display controller (a.k.a. LCDC) I quickly realized that display panel implementation based on board code callbacks would need to be replaced by a driver-based panel framework. Several driver-based panel support solution alread

Re: [PATCH] dvb_frontend: Multistream support

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 15:11, Antti Palosaari escreveu: > On 08/16/2012 08:46 PM, CrazyCat wrote: >> DTV_ISDBS_TS_ID replaced with DTV_STREAM_ID. >> Aliases DTV_ISDBS_TS_ID, DTV_DVBS2_MIS_ID for DTV_STREAM_ID. >> DTV_DVBT2_PLP_ID marked as legacy. >> >> Signed-off-by: Evgeny Plehov >> diff --git a/include/

Re: [media] rc-core: move timeout and checks to lirc

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 19:15, Sean Young escreveu: > >> The lirc TX functionality expects the process which writes (TX) data to >> the lirc dev to sleep until the actual data has been transmitted by the >> hardware. >> >> Since the same timeout calculation is duplicated in more than one driver >> (and wou

Re: [media] rc-core: move timeout and checks to lirc

2012-08-16 Thread Sean Young
> The lirc TX functionality expects the process which writes (TX) data to > the lirc dev to sleep until the actual data has been transmitted by the > hardware. > > Since the same timeout calculation is duplicated in more than one driver > (and would have to be duplicated in even more drivers as

Re: [PATCH] [media] winbond-cir: Fix initialization

2012-08-16 Thread Sean Young
On Thu, Aug 16, 2012 at 09:19:09AM -0700, Greg KH wrote: > On Tue, Jul 31, 2012 at 11:37:03AM +0100, Sean Young wrote: > > The serial driver will detect the winbond cir device as a serial port, > > since it looks exactly like a serial port unless you know what it is > > from the PNP ID. > > > > Wi

[PATCH] [media] ddbridge: fix error handling in module_init_ddbridge()

2012-08-16 Thread Alexey Khoroshilov
If pci_register_driver() failed, resources allocated in ddb_class_create() are leaked. The patch fixes it as well as it replaces -1 with correct error code in ddb_class_create(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/d

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 11:06 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 15:48, Antti Palosaari escreveu: On 08/16/2012 09:34 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 15:31, Antti Palosaari escreveu: On 08/16/2012 07:50 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 11:29, Antti Palosaari esc

Re: noisy dev_dbg_ratelimited()

2012-08-16 Thread Hin-Tak Leung
--- On Thu, 16/8/12, Antti Palosaari wrote: > Hello Hiroshi > > On 08/16/2012 10:12 AM, Hiroshi Doyu wrote: > > Hi Antti, > > > > Antti Palosaari > wrote @ Thu, 16 Aug 2012 03:11:56 +0200: > > > >> Hello Hiroshi, > >> > >> I see you have added dev_dbg_ratelimited() > recently, commit > >> 6ca04

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 15:48, Antti Palosaari escreveu: > On 08/16/2012 09:34 PM, Mauro Carvalho Chehab wrote: >> Em 16-08-2012 15:31, Antti Palosaari escreveu: >>> On 08/16/2012 07:50 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 11:29, Antti Palosaari escreveu: > On 08/16/2012 05:07 PM, Hans Ver

Re: noisy dev_dbg_ratelimited()

2012-08-16 Thread Antti Palosaari
Hello Hiroshi On 08/16/2012 10:12 AM, Hiroshi Doyu wrote: Hi Antti, Antti Palosaari wrote @ Thu, 16 Aug 2012 03:11:56 +0200: Hello Hiroshi, I see you have added dev_dbg_ratelimited() recently, commit 6ca045930338485a8cdef117e74372aa1678009d . However it seems to be noisy as expected simila

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Hans Verkuil
On Thu August 16 2012 19:39:51 Steven Toth wrote: > >> So, I've ran v4l2-compliance and it pointed out a few things that I've > >> fixed, but it also does a few things that (for some reason) I can't > >> seem to catch. One particular test is on (iirc) s_fmt. It attempts to > >> set ATSC but by ioct

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 09:34 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 15:31, Antti Palosaari escreveu: On 08/16/2012 07:50 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 11:29, Antti Palosaari escreveu: On 08/16/2012 05:07 PM, Hans Verkuil wrote: On Thu August 16 2012 15:45:47 Antti Palosaari wr

cron job: media_tree daily build: ERRORS

2012-08-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Aug 16 19:00:26 CEST 2012 git hash:893430558e5bf116179915de2d3d119ad25c01cf gcc version: i686-linux-gcc (GC

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 15:31, Antti Palosaari escreveu: > On 08/16/2012 07:50 PM, Mauro Carvalho Chehab wrote: >> Em 16-08-2012 11:29, Antti Palosaari escreveu: >>> On 08/16/2012 05:07 PM, Hans Verkuil wrote: On Thu August 16 2012 15:45:47 Antti Palosaari wrote: > On 08/16/2012 03:18 PM, Antti Palo

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 07:50 PM, Mauro Carvalho Chehab wrote: Em 16-08-2012 11:29, Antti Palosaari escreveu: On 08/16/2012 05:07 PM, Hans Verkuil wrote: On Thu August 16 2012 15:45:47 Antti Palosaari wrote: On 08/16/2012 03:18 PM, Antti Palosaari wrote: On 08/16/2012 01:33 PM, Hans Verkuil wrote: Bui

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 11:29, Antti Palosaari escreveu: > On 08/16/2012 05:07 PM, Hans Verkuil wrote: >> On Thu August 16 2012 15:45:47 Antti Palosaari wrote: >>> On 08/16/2012 03:18 PM, Antti Palosaari wrote: On 08/16/2012 01:33 PM, Hans Verkuil wrote: > Building the kernel with the Sensoray 2250/

Re: [git:v4l-dvb/for_v3.7] [media] media: rc: Introduce RX51 IR transmitter driver

2012-08-16 Thread Timo Kokkonen
On 08/16/12 19:34, Sakari Ailus wrote: > Hi Sebastian, > > On Thu, Aug 16, 2012 at 01:21:04PM +0200, Sebastian Reichel wrote: >> Hi, >> It was an requirement back then that this driver needs to be a module as 99% of the N900 owners still don't even know they have this kind of capabi

Re: [PATCH] dvb_frontend: Multistream support

2012-08-16 Thread Antti Palosaari
On 08/16/2012 08:46 PM, CrazyCat wrote: DTV_ISDBS_TS_ID replaced with DTV_STREAM_ID. Aliases DTV_ISDBS_TS_ID, DTV_DVBS2_MIS_ID for DTV_STREAM_ID. DTV_DVBT2_PLP_ID marked as legacy. Signed-off-by: Evgeny Plehov diff --git a/include/linux/dvb/frontend.h b/include/linux/dvb/frontend.h index f50d40

Re: [RFCv3 PATCH 3/8] v4l2-subdev: add support for the new edid ioctls.

2012-08-16 Thread Soby Mathew
Hi Hans, For EDID update, it is recommended that the HPD line be toggled after the EDID update is completed. So for the driver to detect the EDID write is complete, probably a field mentioning the EDID write completed would be good, so that the HPD toggling can be done by the driver. Best Regar

[PATCH] stv090x: Multistream support

2012-08-16 Thread CrazyCat
DVB-S2 Multistream support for stv090x Signed-off-by: Evgeny Plehov diff --git a/drivers/media/dvb/frontends/stv090x.c b/drivers/media/dvb/frontends/stv090x.c index ea86a56..13caec0 100644 --- a/drivers/media/dvb/frontends/stv090x.c +++ b/drivers/media/dvb/frontends/stv090x.c @@ -3425,6 +3425,33

[PATCH] dvb_frontend: Multistream support

2012-08-16 Thread CrazyCat
DTV_ISDBS_TS_ID replaced with DTV_STREAM_ID. Aliases DTV_ISDBS_TS_ID, DTV_DVBS2_MIS_ID for DTV_STREAM_ID. DTV_DVBT2_PLP_ID marked as legacy. Signed-off-by: Evgeny Plehov diff --git a/include/linux/dvb/frontend.h b/include/linux/dvb/frontend.h index f50d405..3444dda 100644 --- a/include/linux/dvb/

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Steven Toth
>> So, I've ran v4l2-compliance and it pointed out a few things that I've >> fixed, but it also does a few things that (for some reason) I can't >> seem to catch. One particular test is on (iirc) s_fmt. It attempts to >> set ATSC but by ioctl callback never receives ATSC in the norm/id arg, >> it a

Re: [PATCH 2/2] marvell-cam: Build fix: missing "select VIDEOBUF2_VMALLOC"

2012-08-16 Thread Jonathan Corbet
On Mon, 13 Aug 2012 19:40:08 -0300 Mauro Carvalho Chehab wrote: > Ping? > > Is this patch needed or not? Sorry, I have dropped vast numbers of balls over the last six months and am far from having picked them all up. Reviewing the conversation, I still must confess that I don't understand the

Re: [PATCH] smiapp: Use devm_kzalloc() in smiapp-core.c file

2012-08-16 Thread Sakari Ailus
Hi Sachin, Thanks for the patch. On Thu, Aug 16, 2012 at 04:59:30PM +0530, Sachin Kamat wrote: > devm_kzalloc is a device managed function and makes code a bit > smaller and cleaner. > > Signed-off-by: Sachin Kamat > --- > This patch is based on Mauro's re-organized tree > (media_tree staging/f

Re: [git:v4l-dvb/for_v3.7] [media] media: rc: Introduce RX51 IR transmitter driver

2012-08-16 Thread Sakari Ailus
Hi Sebastian, On Thu, Aug 16, 2012 at 01:21:04PM +0200, Sebastian Reichel wrote: > Hi, > > > > It was an requirement back then that this driver needs to be a module as > > > 99% of the N900 owners still don't even know they have this kind of > > > capability on their devices, so it doesn't make s

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-08-16 Thread Sakari Ailus
Hi Manju, On Thu, Aug 09, 2012 at 09:13:52AM +0530, Manjunath Hadli wrote: > Hi Sakari, > > Thank you for the comments. Thanks for the graphs! > On Thursday 02 August 2012 05:37 AM, Sakari Ailus wrote: > > Hi Manju, > > > > Thanks for the patch. > > > > Please make sure these patches reach li

Re: [PATCH] [media] winbond-cir: Fix initialization

2012-08-16 Thread Greg KH
On Tue, Jul 31, 2012 at 11:37:03AM +0100, Sean Young wrote: > The serial driver will detect the winbond cir device as a serial port, > since it looks exactly like a serial port unless you know what it is > from the PNP ID. > > Winbond CIR 00:04: Region 0x2f8-0x2ff already in use! > Winbond CIR 00:

Re: [PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Laurent Pinchart
Hi Prabhakar, Thanks for the patch. On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote: > From: Lad, Prabhakar > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Manjunath Hadli > Cc: Hans Verkuil > --- > drivers/media/video/davinci/vpif_capture.c | 12 +++- > drivers/media/v

[PATCH] cx23885: fix pointer to structure for CAM

2012-08-16 Thread ptqa
Hello, Mauro. Please, check our patch. Fixes problem with CAM, when after re-iinitialization CAM used old pointer to structure. Signed-off-by: Anton Nurkin --- drivers/media/pci/cx23885/altera-ci.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci/

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Hans Verkuil
On Thu August 16 2012 15:27:51 Steven Toth wrote: > >> While I don't necessarily agree with Mauro that adoption of subdev is > >> "MANDATORY" (in the larger sense of the kernel driver development - > >> and common practices throughout the entire source base), I do hear and > >> value your comments

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 05:07 PM, Hans Verkuil wrote: On Thu August 16 2012 15:45:47 Antti Palosaari wrote: On 08/16/2012 03:18 PM, Antti Palosaari wrote: On 08/16/2012 01:33 PM, Hans Verkuil wrote: Building the kernel with the Sensoray 2250/2251 staging go7007 driver enabled fails with this link error:

[PATCH] m5mols: Add missing free_irq() on error path

2012-08-16 Thread Sylwester Nawrocki
Make sure the interrupt is freed when the driver probing fails. Reported-by: Marek Szyprowski Cc: HeungJun Kim Signed-off-by: Sylwester Nawrocki --- drivers/media/video/m5mols/m5mols_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/m5mols/m5mols

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Hans Verkuil
On Thu August 16 2012 15:45:47 Antti Palosaari wrote: > On 08/16/2012 03:18 PM, Antti Palosaari wrote: > > On 08/16/2012 01:33 PM, Hans Verkuil wrote: > >> Building the kernel with the Sensoray 2250/2251 staging go7007 driver > >> enabled > >> fails with this link error: > >> > >> ERROR: "usb_cypre

[PATCH] media: davinci: vpif: add check for NULL handler

2012-08-16 Thread Prabhakar Lad
From: Lad, Prabhakar Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli Cc: Hans Verkuil --- drivers/media/video/davinci/vpif_capture.c | 12 +++- drivers/media/video/davinci/vpif_display.c | 14 -- 2 files changed, 15 insertions(+), 11 deletions(-) diff --g

Re: [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI)

2012-08-16 Thread Bjørn Mork
Manu Abraham writes: > Terratec Cinregy C is VP-2033 and not VP-2040. Can you please enlighten me on how to tell this difference? I have two of these cards: bjorn@canardo:~$ lspci -vvnns 05:00 05:00.0 Multimedia controller [0480]: Twinhan Technology Co. Ltd Mantis DTV PCI Bridge Controller [V

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 03:18 PM, Antti Palosaari wrote: On 08/16/2012 01:33 PM, Hans Verkuil wrote: Building the kernel with the Sensoray 2250/2251 staging go7007 driver enabled fails with this link error: ERROR: "usb_cypress_load_firmware" [drivers/staging/media/go7007/s2250-loader.ko] undefined! As f

Re: [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI)

2012-08-16 Thread Bjørn Mork
Mauro Carvalho Chehab writes: > Hmm... there's something wrong: this would be the revert patch, as produced > by git revert: > > diff --git a/drivers/media/pci/mantis/mantis_cards.c > b/drivers/media/pci/mantis/mantis_cards.c > index 0207d1f..095cf3a 100644 > --- a/drivers/media/pci/mantis/manti

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Steven Toth
>> While I don't necessarily agree with Mauro that adoption of subdev is >> "MANDATORY" (in the larger sense of the kernel driver development - >> and common practices throughout the entire source base), I do hear and >> value your comments and concerns from a peer review perspective. > > You're aw

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-08-16 Thread Prabhakar Lad
Hi Rob, On Thursday 16 August 2012 06:40 PM, Rob Landley wrote: > On 07/11/2012 10:39 AM, Manjunath Hadli wrote: >> Add documentation on the Davinci VPFE driver. Document the subdevs, >> and private IOTCLs the driver implements >> >> Signed-off-by: Manjunath Hadli >> Signed-off-by: Lad, Prabhakar

Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-16 Thread Bjørn Mork
Manu Abraham writes: > That's just peanuts you are talking about. The memory usage appears only > if you are using the module. 200 lines of .text is nothing. OK. Deleting 200 completely useless lines of code is nothing? I don't think we live in the same world. > That exists to > differentiate

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-08-16 Thread Rob Landley
On 07/11/2012 10:39 AM, Manjunath Hadli wrote: > Add documentation on the Davinci VPFE driver. Document the subdevs, > and private IOTCLs the driver implements > > Signed-off-by: Manjunath Hadli > Signed-off-by: Lad, Prabhakar I saw the comment on the 8th, is there another version of this docum

Re: [PATCH Trivial] [media] s5p-jpeg: Add missing braces around sizeof

2012-08-16 Thread Sylwester Nawrocki
On 08/16/2012 01:52 PM, Sachin Kamat wrote: > Silences the following warning: > WARNING: sizeof *ctx should be sizeof(*ctx) > > Signed-off-by: Sachin Kamat Thanks Sachin, I've added this to my tree for v3.7. > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- > 1 files changed, 1 in

Re: dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Antti Palosaari
On 08/16/2012 01:33 PM, Hans Verkuil wrote: Building the kernel with the Sensoray 2250/2251 staging go7007 driver enabled fails with this link error: ERROR: "usb_cypress_load_firmware" [drivers/staging/media/go7007/s2250-loader.ko] undefined! As far as I can tell this is related to the dvb-usb

[PATCH] [media] s5p-mfc: Add device tree support

2012-08-16 Thread Arun Kumar K
This patch will add the device tree support for MFC driver. Signed-off-by: Arun Kumar K --- drivers/media/video/s5p-mfc/s5p_mfc.c | 106 - 1 files changed, 90 insertions(+), 16 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/vide

[PATCH Trivial] [media] s5p-jpeg: Add missing braces around sizeof

2012-08-16 Thread Sachin Kamat
Silences the following warning: WARNING: sizeof *ctx should be sizeof(*ctx) Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/

[PATCH] Add MFC device tree support

2012-08-16 Thread Arun Kumar K
The patch adds device tree support for the MFC driver. The ARCH side patch for the device tree support for Exynos4 and 5 SoCs are posted in linux-samsung mailing list [1]. This patch has to be applied over the patchset for MFC v6 support [2]. [1] http://www.mail-archive.com/linux-samsung-soc@vger

Re: [PATCH] s5p-fimc: Add pipeline ops to separate FIMC-LITE module (was From: Sylwester Nawrocki )

2012-08-16 Thread Sylwester Nawrocki
On 08/16/2012 12:34 PM, Sylwester Nawrocki wrote: The patch's subject got wrong due to stray characters that snicked in, the subject should read: [PATCH] s5p-fimc: Add pipeline ops to separate FIMC-LITE module My apologies for spamming. Thanks, Sylwester > In order to reuse the FIMC-LITE module

Re: [git:v4l-dvb/for_v3.7] [media] media: rc: Introduce RX51 IR transmitter driver

2012-08-16 Thread Sebastian Reichel
Hi, > > It was an requirement back then that this driver needs to be a module as > > 99% of the N900 owners still don't even know they have this kind of > > capability on their devices, so it doesn't make sense to keep the module > > loaded unless the user actually needs it. > > I don't think tha

[PATCH] smiapp: Use devm_kzalloc() in smiapp-core.c file

2012-08-16 Thread Sachin Kamat
devm_kzalloc is a device managed function and makes code a bit smaller and cleaner. Signed-off-by: Sachin Kamat --- This patch is based on Mauro's re-organized tree (media_tree staging/for_v3.7) and is compile tested. --- drivers/media/i2c/smiapp/smiapp-core.c | 11 ++- 1 files changed

Re: Update VIP to videobuf2 and control framework

2012-08-16 Thread Federico Vaga
In data mercoledì 1 agosto 2012 07:04:18, Jonathan Corbet ha scritto: > On Wed, 1 Aug 2012 08:41:56 +0200 > > Hans Verkuil wrote: > > > The second patch adds a new memory allocator for the videobuf2. I > > > name it videobuf2-dma-streaming but I think "streaming" is not > > > the best choice, so

RE: [PATCH v3 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available

2012-08-16 Thread Marek Szyprowski
Hello, On Thursday, August 16, 2012 12:14 PM Hideki EIRAKU wrote: > From: Marek Szyprowski > Subject: RE: [PATCH v3 3/4] media: videobuf2-dma-contig: use > dma_mmap_coherent if available > Date: Tue, 07 Aug 2012 16:53:25 +0200 > > > I'm sorry for bringing this issue now, once you have already

Re: Patches submitted via linux-media ML that are at patchwork.linuxtv.org

2012-08-16 Thread Prabhakar Lad
Hi Mauro, On Thursday 16 August 2012 05:16 AM, Mauro Carvalho Chehab wrote: > Em 14-08-2012 10:04, Mauro Carvalho Chehab escreveu: >> In order to help people to know about the status of the pending patches, >> I'm summing-up the patches pending for merge on this email. > > Thank you all maintaine

From: Sylwester Nawrocki

2012-08-16 Thread Sylwester Nawrocki
In order to reuse the FIMC-LITE module on Exynos4 and Exynos5 SoC introduce a set of callbacks for the media pipeline control from within FIMC/FIMC-LITE video node. It lets us avoid symbol dependencies between FIMC-LITE and the whole media device driver, which simplifies the initialization sequence

dvb-usb-v2 change broke s2250-loader compilation

2012-08-16 Thread Hans Verkuil
Building the kernel with the Sensoray 2250/2251 staging go7007 driver enabled fails with this link error: ERROR: "usb_cypress_load_firmware" [drivers/staging/media/go7007/s2250-loader.ko] undefined! As far as I can tell this is related to the dvb-usb-v2 changes. Can someone take a look at this?

Re: [ANNOUNCE] tree renaming patches part 1 applied

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 06:24, Sylwester Nawrocki escreveu: > Hi Mauro, > > On 08/14/2012 01:59 PM, Mauro Carvalho Chehab wrote: >> Anyway, in order to help people that might still have patches against >> the old structure, I created a small script and added them at the >> media_build tree: >> >> http

Re: [git:v4l-dvb/for_v3.7] [media] media: rc: Introduce RX51 IR transmitter driver

2012-08-16 Thread Sakari Ailus
Moi, On Wed, Aug 15, 2012 at 10:46:43PM +0300, Timo Kokkonen wrote: > Long time no see. Indeed! Better late than never I guess. :) > On 08/15/12 19:06, Sakari Ailus wrote: > > Heippa, > > > > Thanks for the patch! I know Mauro has already applied this so any changes > > would make a separate pa

Re: [PATCH v3 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available

2012-08-16 Thread Hideki EIRAKU
Hello, From: Marek Szyprowski Subject: RE: [PATCH v3 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available Date: Tue, 07 Aug 2012 16:53:25 +0200 > I'm sorry for bringing this issue now, once you have already created v3 of > your > patches, but similar patch has been already prop

[PATCH 4/4] s5p-fimc: Don't allocate fimc-m2m video device dynamically

2012-08-16 Thread Sylwester Nawrocki
There is no need to to dynamically allocate struct video_device for the M2M devices, so embed it instead in driver's private data structure as it is done in case of fimc-capture and fimc-lite, where it solves some bugs on cleanup paths. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Pa

[PATCH 3/4] s5p-fimc: Don't allocate fimc-capture video device dynamically

2012-08-16 Thread Sylwester Nawrocki
This fixes potential invalid pointer de-reference, when media_entity_cleanup() is called before video device is unregistered. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-capture.c | 28 drivers/media/platform

[PATCH 2/4] s5p-fimc: Don't allocate fimc-lite video device structure dynamically

2012-08-16 Thread Sylwester Nawrocki
This fixes potential invalid pointer de-reference, when media_entity_cleanup() is called after video_unregister_device, and video device structure memory is already freed. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/fimc-lite-reg.c |2 +

[PATCH 1/4] s5p-fimc: Enable FIMC-LITE driver only for SOC_EXYNOS4x12

2012-08-16 Thread Sylwester Nawrocki
Allow to compile-in the FIMC-LITE driver only on Exynos4212, Exynos4412 and Exynos5250 SoC where the device is available. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-fimc/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH] [media] ddbridge: fix error handling in module_init_ddbridge()

2012-08-16 Thread Mauro Carvalho Chehab
Em 16-08-2012 06:26, Mauro Carvalho Chehab escreveu: > Em 15-08-2012 17:42, Alexey Khoroshilov escreveu: >> If pci_register_driver() failed, resources allocated in >> ddb_class_create() are leaked. The patch fixes it. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed

Re: [PATCH] [media] ddbridge: fix error handling in module_init_ddbridge()

2012-08-16 Thread Mauro Carvalho Chehab
Em 15-08-2012 17:42, Alexey Khoroshilov escreveu: > If pci_register_driver() failed, resources allocated in > ddb_class_create() are leaked. The patch fixes it. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers/media/dvb/ddb

Re: [ANNOUNCE] tree renaming patches part 1 applied

2012-08-16 Thread Sylwester Nawrocki
Hi Mauro, On 08/14/2012 01:59 PM, Mauro Carvalho Chehab wrote: > Anyway, in order to help people that might still have patches against > the old structure, I created a small script and added them at the > media_build tree: > > http://git.linuxtv.org/media_build.git/blob/HEAD:/devel_scripts/

Re: [RFC PATCHv2 0/1] Adding core TMC decoding support to RDS library

2012-08-16 Thread Hans Verkuil
On Wed August 15 2012 16:30:57 Konke Radlow wrote: > this patch is an updated version of the last RDS-TMC core support patch. > > The changes proposed by Hans Verkuil were implemented. In addition > the handling and decoding of multi-group TMC messages was heavily modified, > in order to improve

Re: (still) NULL pointer crashes with nuvoton_cir driver

2012-08-16 Thread Matthijs Kooijman
Hi folks, > I'm currently compiling a 3.5 kernel with just the rdev initialization > moved up to see if this will fix my problem at all, but I'd like your > view on this in the meantime as well. Ok, this seems to fix my problem: --- a/drivers/media/rc/nuvoton-cir.c +++ b/drivers/media/rc/nuvoton-

Re: noisy dev_dbg_ratelimited()

2012-08-16 Thread Hiroshi Doyu
Hi Antti, Antti Palosaari wrote @ Thu, 16 Aug 2012 03:11:56 +0200: > Hello Hiroshi, > > I see you have added dev_dbg_ratelimited() recently, commit > 6ca045930338485a8cdef117e74372aa1678009d . > > However it seems to be noisy as expected similar behavior than normal > dev_dbg() without a rat