On Wed, Mar 27, 2013 at 7:17 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 03/27/2013 05:31 AM, Arun Kumar K wrote:
On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
On 03/26/2013 01:17 PM, Arun Kumar K wrote:
[...]
Only issue
Hi Sylwester,
Sorry for the late reply.
OK, thanks for the explanation.
I can think of at least one possible way to get hold of the fimc-is
context in the subdev. For instance, in subdev's .registered callback
you get a pointer to struct v4l2_device, which is normally embedded
in a top
-decoder simultaneous run due to memory allocation
happening from interrupt context.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
Changes from v2:
- Addressed review comments from Kamil Debski
https://patchwork.kernel.org/patch/2335091/
Changes from v1:
- Corrected the commit message
with the gate clock. So there is no need
for the driver to use this sclk. This patch removes the
sclk usage from driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc.c|2 --
drivers/media/platform/s5p-mfc/s5p_mfc_common.h |1 -
drivers/media
which accepts
bayer input data and provides 2 different scaled outputs with most of
the post processing blocks disabled.
Arun Kumar K (10):
exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings
documentation
exynos5-fimc-is: Adds fimc-is driver core files
exynos5-fimc-is: Adds
Signed-off-by: Arun Kumar K arun...@samsung.com
---
.../devicetree/bindings/media/exynos5-fimc-is.txt | 41
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/exynos5-fimc-is.txt
diff --git a/Documentation/devicetree/bindings
This driver is for the FIMC-IS IP available in Samsung Exynos5
SoC onwards. This patch adds the core files for the new driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/fimc-is-core.c | 304
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/fimc-is-regs.h | 107
FIMC-IS uses certain sensors which are exclusively controlled
from the IS firmware. This patch adds the sensor subdev for the
fimc-is sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/fimc-is-sensor.c
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5
The hardware interface module finally sends the commands to the
FIMC-IS firmware and runs the interrupt handler for getting the
responses.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
.../media/platform/exynos5-is/fimc-is-interface.c
Modifies the exynos5-is Makefile and Kconfig to include the new
fimc-is driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
---
drivers/media/platform/exynos5-is/Kconfig | 12
drivers/media/platform/exynos5-is/Makefile |3
Hi Sachin,
Thank you for the review.
Will address your comments in next iteration.
Regards
Arun
On Thu, Jun 6, 2013 at 10:50 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Arun,
On 31 May 2013 18:33, Arun Kumar K arun...@samsung.com wrote:
This driver is for the FIMC-IS IP available
Hi Sachin,
Its a leftover from old PMU register access which is now modified
to be DT based. Will remove it.
Thanks Regards
Arun
On Thu, Jun 6, 2013 at 11:54 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
On 31 May 2013 18:33, Arun Kumar K arun...@samsung.com wrote:
This patch adds
Hi Sachin,
+ isp-refcount++;
+ return ret;
You can directly return 0 here instead of creating a local variable
'ret' which is not used anywhere else.
Ok.
+
nit: Please consider changing Adds to Add in the patch titles of
this series during the next spin.
Ok will change
Hi Sachin,
+ if (ret 0) {
+ pr_err(Pipeline already opened.\n);
+ return -EBUSY;
why not propogate 'ret'? Same for other instances below.
Yes it can be done. Will change it.
Regards
Arun
--
To unsubscribe from this list: send the
This patch series adds MFC v7 firmware support to the Exynos
MFC driver. MFC v7 is present in 5420 SoC which has support
for VP8 encoding and many other features.
Arun Kumar K (6):
[media] s5p-mfc: Update v6 encoder buffer sizes
[media] s5p-mfc: Add register definition file for MFC v7
The patch updates few encoder buffer sizes for MFC v6.5
as per the udpdated user manual. The same buffer sizes
holds good for v7 firmware also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v6.h |4 ++--
1 file changed, 2 insertions(+), 2
The patch adds the register definition file for new firmware
version v7 for MFC. New firmware supports VP8 encoding along with
many other features.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v7.h | 58 ++
1 file changed
Adds variant data and core support for the MFC v7 firmware
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 32 +++
drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 ++
2 files changed, 34 insertions(+)
diff --git
Firmware version v7 is mostly similar to v6 in terms
of hardware specific controls and commands. So the hardware
specific opr_v6 and cmd_v6 are re-used for v7 also. This patch
updates the v6 files to handle v7 version also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media
This patch adds new V4L controls for VP8 encoding.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
---
Documentation/DocBook/media/v4l/controls.xml | 145 ++
drivers/media/v4l2-core/v4l2-ctrls.c | 38
MFC v7 supports VP8 encoding and this patch adds support
for it in the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c |3 +
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 19 -
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
Hi Hans,
Thank you for the review.
+
+section id=vpx-controls
+ titleVPX Control Reference/title
+
+ paraThe VPX control class includes controls for encoding parameters
+ of VPx video codec./para
Are these controls defined by the VPx standard, or are they specific to
Hi Sylwester,
Thank you for the review.
+ static const char * const vpx_num_partitions[] = {
+ 1 partition,
+ 2 partitions,
+ 4 partitions,
+ 8 partitions,
+ NULL,
+ };
+ static const char * const
Hi Sylwester,
+ static const char * const vpx_num_partitions[] = {
+ 1 partition,
+ 2 partitions,
+ 4 partitions,
+ 8 partitions,
+ NULL,
+ };
+ static const char * const vpx_num_ref_frames[] = {
+ 1
Hi Sylwester,
On Fri, Jun 14, 2013 at 3:23 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
Hi Arun,
On 06/14/2013 11:26 AM, Arun Kumar K wrote:
Hi Sylwester,
+ static const char * const vpx_num_partitions[] = {
+ 1 partition,
+ 2 partitions
Hi Sylwester,
On Sat, Jun 15, 2013 at 1:01 AM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
Hi Arun,
On 06/14/2013 03:21 PM, Arun Kumar K wrote:
On Fri, Jun 14, 2013 at 3:23 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 06/14/2013 11:26 AM, Arun Kumar K wrote:
+ static
Hi Sylwester,
Also for number of ref frames, the standard allows only the options 1,
2 and 3 which
cannot be extended more. So is it correct to use INTEGER_MENU control here
and
let the driver define the values?
If this is standard then the core should define available menu items. But
Hi Sylwester,
On Mon, Jun 17, 2013 at 2:34 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 06/17/2013 06:25 AM, Arun Kumar K wrote:
On Sat, Jun 15, 2013 at 1:01 AM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 06/14/2013 03:21 PM, Arun Kumar K wrote:
On Fri, Jun 14, 2013 at 3
Hi Kamil,
Thank you for the review.
#define IS_MFCV6(dev)(dev-variant-version = 0x60 ? 1 :
0)
+#define IS_MFCV7(dev)(dev-variant-version = 0x70 ? 1 :
0)
According to this, MFC v7 is also detected as MFC v6. Was this intended?
Yes this was intentional as
Hi Sachin,
On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
On 18 June 2013 10:21, Arun Kumar K arunkk.sams...@gmail.com wrote:
Hi Kamil,
Thank you for the review.
#define IS_MFCV6(dev)(dev-variant-version = 0x60 ? 1 :
0)
+#define IS_MFCV7
Hi Sachin,
On Tue, Jun 18, 2013 at 11:42 AM, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Arun,
On 18 June 2013 11:25, Arun Kumar K arunkk.sams...@gmail.com wrote:
Hi Sachin,
On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org
wrote:
On 18 June 2013 10:21, Arun
The patch updates few encoder buffer sizes for MFC v6.5
as per the udpdated user manual. The same buffer sizes
holds good for v7 firmware also.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v6.h |4
The MFC v6 specific code holds good for MFC v7 also as
the v7 version is a superset of v6 and the HW interface
remains more or less similar. This patch renames the macro
IS_MFCV6() to IS_MFCV6_PLUS() so that it can be used
for v7 also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers
.html
http://www.mail-archive.com/linux-media@vger.kernel.org/msg63311.html
- Modified IS_MFCV6 macro to IS_MFCV6_PLUS to include v7 also
Arun Kumar K (7):
[media] s5p-mfc: Update v6 encoder buffer sizes
[media] s5p-mfc: Rename IS_MFCV6 macro
[media] s5p-mfc: Add register definition file
The patch adds the register definition file for new firmware
version v7 for MFC. New firmware supports VP8 encoding along with
many other features.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/regs-mfc-v7.h | 58 ++
1 file changed
Firmware version v7 is mostly similar to v6 in terms
of hardware specific controls and commands. So the hardware
specific opr_v6 and cmd_v6 are re-used for v7 also. This patch
updates the v6 files to handle v7 version also.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media
Adds variant data and core support for the MFC v7 firmware
Signed-off-by: Arun Kumar K arun...@samsung.com
---
.../devicetree/bindings/media/s5p-mfc.txt |1 +
drivers/media/platform/s5p-mfc/s5p_mfc.c | 32
drivers/media/platform/s5p-mfc
From: Sylwester Nawrocki s.nawro...@samsung.com
The patch modifies the helper function v4l2_ctrl_new_std_menu
to accept integer menu controls with standard menu items.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
Documentation
MFC v7 supports VP8 encoding and this patch adds support
for it in the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c |3 +
drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 19 -
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
This patch adds new V4L controls for VP8 encoding.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
---
Documentation/DocBook/media/v4l/controls.xml | 151 ++
drivers/media/v4l2-core/v4l2-ctrls.c | 36
Hi Sylwester,
On Fri, Jun 21, 2013 at 4:16 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Guys, I was wondering how difficult would be to make a common driver
for the Exynos4 and Exynos5 FIMC-IS ? My feeling is that it would allow
to save significant amount of code, since the
This patch is re-worked version of the original patch posted
by Jeongtae Park for support of MFCv6.x
The comment given by Kamil Debski can be found here:
http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/45189
The crash issue reported on MFC 5.1 on applying this patch has
This is the v2 series of patches for adding support for MFC v6.x.
In this the new v4l controls added in patch [1] are removed. These can be
added as a separate patch later for providing extra encoder controls for
MFC v6. This also incorporates the review comments received for the original
patch
From: Jeongtae Park jtp.p...@samsung.com
Add new fourcc definitions for interleaved YCbCr and
compressed formats MVC and VP8.
Signed-off-by: Jeongtae Park jtp.p...@samsung.com
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Cc: Marek
This patch set adds new control and fourcc definitions which will be
used by samsung s5p-mfc driver.
Patch 1 adds new fourcc definitions for YCbCr and compressed formats.
Patch 2 adds control definitions for new H264 encoder features.
The review comments given in [1] are addressed.
[1]
...@samsung.com
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kamil Debski k.deb...@samsung.com
---
Documentation/DocBook/media/v4l/pixfmt-nv12m.xml | 17 -
Documentation
ch.nav...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kamil Debski k.deb...@samsung.com
---
Documentation/DocBook/media/v4l/controls.xml | 268 +-
drivers/media/video/v4l2-ctrls.c | 42
Hi Kyungmin Park,
Thank you for the review.
Please find my comments inline.
On Fri, Jul 6, 2012 at 7:51 PM, Kyungmin Park kmp...@infradead.org wrote:
Hi,
On Fri, Jul 6, 2012 at 11:00 PM, Arun Kumar K arun...@samsung.com wrote:
From: Jeongtae Park jtp.p...@samsung.com
Multi Format Codec 6.x
Hi Kamil,
Thank you for the review. Please find my comments inline.
On Tue, Jul 10, 2012 at 8:40 PM, Kamil Debski k.deb...@samsung.com wrote:
Hi Arun,
Please find some additional comments below.
From: Arun Kumar K [mailto:arun...@samsung.com]
Sent: 06 July 2012 16:00
[snip]
diff
The patchset adds support for MFCv6 firmware in s5p-mfc driver.
The original patch is split into 4 patches for easy review.
This patchset have to be applied on patches [1] and [2] posted
earlier which adds the required v4l2 controls.
Changelog
- Supports MFCv5 and v6 co-existence.
- Tested for
...@samsung.com
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/video/s5p-mfc/s5p_mfc_dec.c | 223 -
drivers/media/video/s5p-mfc/s5p_mfc_dec.h |1 +
drivers/media/video/s5p-mfc/s5p_mfc_enc.c
)
Title : RE: [PATCH v3 4/4] [media] s5p-mfc: New files for MFCv6 support
Hi Arun,
Please find my comments below.
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland RD Center
From: Arun Kumar K [mailto:arun...@samsung.com]
Sent: 23 July 2012 14:29
From: Jeongtae Park jtp.p
://www.mail-archive.com/linux-media@vger.kernel.org/msg48972.html
[2] http://www.mail-archive.com/linux-media@vger.kernel.org/msg48973.html
Arun Kumar K (1):
[media] s5p-mfc: Update MFCv5 driver for callback based architecture
Jeongtae Park (3):
[media] s5p-mfc: Add MFC variant data to device context
Kim janghyuck@samsung.com
Signed-off-by: Jaeryul Oh jaeryul...@samsung.com
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/video/s5p-mfc/regs-mfc.h |2 +-
drivers/media/video/s5p-mfc/s5p_mfc.c
...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/video/s5p-mfc/regs-mfc-v6.h | 429 +
1 files changed, 429 insertions(+), 0 deletions(-)
create mode 100644 drivers/media/video/s5p-mfc/regs-mfc-v6.h
diff --git a/drivers/media/video/s5p-mfc
@vger.kernel.org/msg11872.html
[2] http://www.mail-archive.com/linux-media@vger.kernel.org/msg50204.html
Arun Kumar K (1):
[media] s5p-mfc: Add device tree support
drivers/media/video/s5p-mfc/s5p_mfc.c | 106 -
1 files changed, 90 insertions(+), 16 deletions
This patch will add the device tree support for MFC driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/video/s5p-mfc/s5p_mfc.c | 106 -
1 files changed, 90 insertions(+), 16 deletions(-)
diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c
Hi Sylwester,
Will make the changes you suggested.
Will re-spin this entire series with some more minor fixes after more
rigorous testing.
Regards
Arun
On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
On 08/21/2013 08:34 AM, Arun Kumar K wrote
Hi Sylwester,
On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
On 08/21/2013 08:34 AM, Arun Kumar K wrote:
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal
The patch adds the DT binding documentation for Samsung
Exynos5 SoC series imaging subsystem (FIMC-IS).
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../devicetree/bindings/media/exynos5-fimc-is.txt | 46
1
This driver is for the FIMC-IS IP available in Samsung Exynos5
SoC onwards. This patch adds the core files for the new driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media
comments from Sylwester, Hans, Andrzej, Sachin
Changes from v1
---
- Addressed all review comments from Sylwester
- Made sensor subdevs as independent i2c devices
- Lots of cleanup
- Debugfs support added
- Removed PMU global register access
Arun Kumar K (12):
[media] exynos5-fimc-is: Add
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
Adds Kconfig and Makefile for exynos5-is driver files.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/platform/Kconfig |1 +
drivers/media/platform
Some sensors to be used with fimc-is are exclusively controlled
by the fimc-is firmware. This minimal sensor driver provides
the required info for the firmware to configure the sensors
sitting on I2C bus.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
s5k6a3 sensor has actual pixel resolution of 1408x1402 against
the active resolution 1392x1392. The real resolution is needed
when raw sensor SRGB data is dumped to memory by fimc-lite.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
The hardware interface module finally sends the commands to the
FIMC-IS firmware and runs the interrupt handler for getting the
responses.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
communication.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../devicetree/bindings/media/i2c/s5k4e5.txt | 45 +++
drivers/media/i2c/Kconfig |8 +
drivers/media/i2c/Makefile
, ODC, 3DNR, FD etc.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../media/platform/exynos5-is/fimc-is-pipeline.c | 1708
.../media/platform/exynos5-is/fimc
Hi Philipp,
+Example:
+
+ i2c-isp@1313 {
+ s5k4e5@20 {
+ compatible = samsung,s5k4e5;
+ reg = 0x20;
+ gpios = gpx1 2 1;
This probably should be 'reset-gpios', too.
Yes thats right. I missed updating the
Hi Sylwester,
I'd like to propose a little re-design of this binding. The reason is that
I've noticed issues related to the power domain and FIMC-LITE, FIMC-IS
clocks
handling sequences. This lead to a failure to disable the ISP power domain
and to complete the system suspend/resume cycle.
Hi Sylwester,
On Wed, Sep 18, 2013 at 2:20 AM, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Hi Arun,
On 09/17/2013 01:29 PM, Arun Kumar K wrote:
Wont this make fimc-is to be enabled to use fimc-lite?
Hmm, it would be runtime PM active, yes. But it doesn't mean the
Cortex-A5's
The patch adds the DT binding documentation for Samsung
Exynos5 SoC series imaging subsystem (FIMC-IS).
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../devicetree/bindings/media/exynos5-fimc-is.txt | 84
1
This driver is for the FIMC-IS IP available in Samsung Exynos5
SoC onwards. This patch adds the core files for the new driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media
The hardware interface module finally sends the commands to the
FIMC-IS firmware and runs the interrupt handler for getting the
responses.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
, ODC, 3DNR, FD etc.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../media/platform/exynos5-is/fimc-is-pipeline.c | 1708
.../media/platform/exynos5-is/fimc
Some sensors to be used with fimc-is are exclusively controlled
by the fimc-is firmware. This minimal sensor driver provides
the required info for the firmware to configure the sensors
sitting on I2C bus.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro
s5k6a3 sensor has actual pixel resolution of 1408x1402 against
the active resolution 1392x1392. The real resolution is needed
when raw sensor SRGB data is dumped to memory by fimc-lite.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
communication.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
.../devicetree/bindings/media/i2c/s5k4e5.txt | 45 +++
drivers/media/i2c/Kconfig |8 +
drivers/media/i2c/Makefile
Adds Kconfig and Makefile for exynos5-is driver files.
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
drivers/media/platform/Kconfig |1 +
drivers/media/platform
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
---
- Addressed all review comments from Sylwester
- Made sensor subdevs as independent i2c devices
- Lots of cleanup
- Debugfs support added
- Removed PMU global register access
Arun Kumar K (12):
[media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings
documentation
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
|
++ ++ +---+ +---+
Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
.../bindings/media/exynos5250-camera.txt | 126 ++
drivers/media/platform/exynos5-is/exynos5-mdev.c | 1211
The patch sets the default values of MAX_QP and GOP size encoder
parameters to some firmware recommended default values. This enables
the applications to get a better encoded output using the default
settings itself.
Signed-off-by: Kiran AVND avnd.ki...@samsung.com
Signed-off-by: Arun Kumar K
after waking up the device queue to ensure that we don't have to wait
for more than one frame to be processed.
Signed-off-by: Prathyush K prathyus...@samsung.com
Signed-off-by: Arun Mankuzhi aru...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
---
drivers/media/platform/s5p-mfc
Hi Sylwester,
On Thu, Oct 17, 2013 at 10:33 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
Hi Arun,
My apologies for the delay.
On 27/09/13 12:59, Arun Kumar K wrote:
s5k6a3 sensor has actual pixel resolution of 1408x1402 against
the active resolution 1392x1392. The real resolution
Hi Sylwester,
On Thu, Oct 17, 2013 at 10:40 PM, Sylwester Nawrocki
s.nawro...@samsung.com wrote:
On 27/09/13 12:59, Arun Kumar K wrote:
This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor
Hi Hans,
Thank you for the review.
On Mon, Sep 30, 2013 at 6:13 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 09/27/2013 12:59 PM, Arun Kumar K wrote:
This patch adds the crucial hardware pipeline control for the
fimc-is driver. All the subdev nodes will call this pipeline
interfaces
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
Some sensors to be used with fimc-is are exclusively controlled
by the fimc-is firmware. This minimal sensor driver provides
the required info for the firmware to configure the sensors
sitting on I2C bus.
Signed-off-by: Arun Kumar K arun...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki
, Sachin
Changes from v1
---
- Addressed all review comments from Sylwester
- Made sensor subdevs as independent i2c devices
- Lots of cleanup
- Debugfs support added
- Removed PMU global register access
Arun Kumar K (12):
exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K arun...@samsung.com
Signed-off-by: Kilyeon Im kilyeon...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
1 - 100 of 450 matches
Mail list logo
