Re: [media] winbond-cir: Move a variable assignment in wbcir_tx()

October 19, 2016 3:32 PM, "SF Markus Elfring" wrote: >>> Move the assignment for the local variable "data" behind the source code >>> for a memory allocation by this function. >> >> Sorry, I can't see what the point is? > > * How do you think about to avoid a

Re: [PATCH] Fix RC5 decoding with Fintek CIR chipset

lowing for a previous space in the >received remote command). > >Signed-off-by: Jonathan McDowell <nood...@earth.li> Signed-off-by: David Härdeman <da...@hardeman.nu> >Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117221 >Cc: sta...@vger.kernel.org > >-

[PATCH] rc-core: improve the lirc protocol reporting

-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-main.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index ecaee02..3f0f71a 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc

[PATCH 5/7] [PATCH FIXES] Revert [media] rc: ir-rc5-decoder: Add encode capability

This reverts commit a0466f15b4654cf1ac9e387d7c1a401eff494b4f. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 4/7] [PATCH FIXES] Revert [media] rc: ir-rc6-decoder: Add encode capability

This reverts commit cf257e288ad3a134d4bb809c542a3ae6c87ddfa3. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 3/7] [PATCH FIXES] Revert [media] rc: rc-core: Add support for encode_wakeup drivers

This reverts commit 0d830b2d1295fee82546d57185da5a6604f11ae2. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 1/7] [PATCH FIXES] Revert [media] rc: nuvoton-cir: Add support for writing wakeup samples via sysfs filter callback

This reverts commit da7ee60b03bd66bb10974d7444aa444de6391312. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 0/7] rc-core: Revert encoding patchset

And Antti agreed at the end of the thread: https://www.mail-archive.com/linux-media@vger.kernel.org/msg86998.html This needs to go in upstream before 4.2 is released. Signed-off-by: David Härdeman da...@hardeman.nu --- David Härdeman (7): Revert [media] rc: nuvoton-cir: Add support for writing

[PATCH 2/7] [PATCH FIXES] Revert [media] rc: rc-loopback: Add loopback of filter scancodes

This reverts commit 2e4ebde269236da2a41183522127715b6d9d80ce. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 6/7] [PATCH FIXES] Revert [media] rc: rc-ir-raw: Add Manchester encoder (phase encoder) helper

This reverts commit 1d971d927efa2e10194c96ed0475b6d6054342d8. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 7/7] [PATCH FIXES] Revert [media] rc: rc-ir-raw: Add scancode encoder callback

This reverts commit 9869da5bacc5c9b865a183bd36c04be76cdd325d. The current code is not mature enough, the API should allow a single protocol to be specified. Also, the current code contains heuristics that will depend on module load order. Signed-off-by: David Härdeman da...@hardeman.nu

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On Mon, Jun 29, 2015 at 09:05:24PM +0200, David Härdeman wrote: On Tue, Jun 23, 2015 at 10:45:42PM +0200, David Härdeman wrote: On 2015-06-18 23:23, Mauro Carvalho Chehab wrote: Em Sun, 14 Jun 2015 01:44:54 +0200 David Härdeman da...@hardeman.nu escreveu: Maurowake up? I hope you're

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On Tue, Jun 23, 2015 at 10:45:42PM +0200, David Härdeman wrote: On 2015-06-18 23:23, Mauro Carvalho Chehab wrote: Em Sun, 14 Jun 2015 01:44:54 +0200 David Härdeman da...@hardeman.nu escreveu: Maurowake up? I hope you're not planning to push the current code upstream??? What's

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On 2015-06-18 23:23, Mauro Carvalho Chehab wrote: Em Sun, 14 Jun 2015 01:44:54 +0200 David Härdeman da...@hardeman.nu escreveu: If you've followed the development of rc-core during the last few years it should be pretty clear that Mauro has little to no long-term plan, understanding

Re: [PATCH 1/2] rc-core: use the full 32 bits for NEC scancodes

On 2015-05-20 22:24, David Härdeman wrote: On Thu, May 14, 2015 at 05:57:39PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 06 Apr 2015 13:23:08 +0200 David Härdeman da...@hardeman.nu escreveu: +static inline enum rc_type guess_protocol(struct rc_dev *rdev) +{ + struct rc_map *rc_map

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On 2015-05-23 13:34, Antti Seppälä wrote: On 22 May 2015 at 13:33, David Härdeman da...@hardeman.nu wrote: On 2015-05-22 07:27, Antti Seppälä wrote: I think that approach too is far from perfect as it leaves us with questions such as: How do we let the user know what variant of protocol

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On 2015-05-22 07:27, Antti Seppälä wrote: On 21 May 2015 at 22:40, David Härdeman da...@hardeman.nu wrote: On Thu, May 21, 2015 at 05:22:08PM +0300, Antti Seppälä wrote: On 21 May 2015 at 15:30, David Härdeman da...@hardeman.nu wrote: On 2015-05-21 13:51, Antti Seppälä wrote: On 21 May 2015

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On 2015-05-21 09:53, Antti Seppälä wrote: On 20 May 2015 at 23:45, David Härdeman da...@hardeman.nu wrote: On Wed, May 20, 2015 at 10:26:54PM +0300, Antti Seppälä wrote: On 20 May 2015 at 21:29, David Härdeman da...@hardeman.nu wrote: On Wed, May 20, 2015 at 07:46:21PM +0300, Antti Seppälä

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On 2015-05-21 13:51, Antti Seppälä wrote: On 21 May 2015 at 12:14, David Härdeman da...@hardeman.nu wrote: I'm talking about ir_raw_encode_scancode() which is entirely broken in its current state. It will, given more than one enabled protocol, encode a scancode to pulse/space events according

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On Thu, May 21, 2015 at 05:22:08PM +0300, Antti Seppälä wrote: On 21 May 2015 at 15:30, David Härdeman da...@hardeman.nu wrote: On 2015-05-21 13:51, Antti Seppälä wrote: On 21 May 2015 at 12:14, David Härdeman da...@hardeman.nu wrote: I'm talking about ir_raw_encode_scancode() which

Re: [RFC PATCH 4/6] [media] rc: lirc is not a protocol or a keymap

On 2015-05-20 11:01, Mauro Carvalho Chehab wrote: Em Wed, 20 May 2015 10:49:34 +0200 David Härdeman da...@hardeman.nu escreveu: On 2015-05-20 10:19, Mauro Carvalho Chehab wrote: Em Tue, 19 May 2015 22:34:42 +0200 David Härdeman da...@hardeman.nu escreveu: I think we should be able

Re: [RFC PATCH 6/6] [media] rc: teach lirc how to send scancodes

On 2015-03-19 22:50, Sean Young wrote: The send mode has to be switched to LIRC_MODE_SCANCODE and then you can send one scancode with a write. The encoding is the same as for receiving scancodes. Why do the encoding in-kernel when it can be done in userspace? I'd understand if it was

Re: [RFC PATCH 6/6] [media] rc: teach lirc how to send scancodes

On 2015-05-20 11:08, Mauro Carvalho Chehab wrote: Em Wed, 20 May 2015 10:53:59 +0200 David Härdeman da...@hardeman.nu escreveu: On 2015-03-19 22:50, Sean Young wrote: The send mode has to be switched to LIRC_MODE_SCANCODE and then you can send one scancode with a write. The encoding

Re: [RFC PATCH 4/6] [media] rc: lirc is not a protocol or a keymap

On 2015-05-20 10:19, Mauro Carvalho Chehab wrote: Em Tue, 19 May 2015 22:34:42 +0200 David Härdeman da...@hardeman.nu escreveu: On Thu, May 14, 2015 at 01:51:23PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 19 Mar 2015 21:50:15 + Sean Young s...@mess.org escreveu: Since the lirc bridge

Re: [RFC PATCH 4/6] [media] rc: lirc is not a protocol or a keymap

On Wed, May 20, 2015 at 11:06:06AM +0200, David Härdeman wrote: On 2015-05-20 11:01, Mauro Carvalho Chehab wrote: Em Wed, 20 May 2015 10:49:34 +0200 David Härdeman da...@hardeman.nu escreveu: On 2015-05-20 10:19, Mauro Carvalho Chehab wrote: Em Tue, 19 May 2015 22:34:42 +0200 David Härdeman da

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On Wed, May 20, 2015 at 10:26:54PM +0300, Antti Seppälä wrote: On 20 May 2015 at 21:29, David Härdeman da...@hardeman.nu wrote: On Wed, May 20, 2015 at 07:46:21PM +0300, Antti Seppälä wrote: On 19 May 2015 at 23:38, David Härdeman da...@hardeman.nu wrote: On Tue, Mar 31, 2015 at 08:48:06PM +0300

Re: [RFC PATCH 4/6] [media] rc: lirc is not a protocol or a keymap

On Wed, May 20, 2015 at 09:16:32PM +0200, David Härdeman wrote: On Wed, May 20, 2015 at 11:06:06AM +0200, David Härdeman wrote: On 2015-05-20 11:01, Mauro Carvalho Chehab wrote: Em Wed, 20 May 2015 10:49:34 +0200 David Härdeman da...@hardeman.nu escreveu: On 2015-05-20 10:19, Mauro Carvalho

Re: [PATCH 1/2] rc-core: use the full 32 bits for NEC scancodes

On Thu, May 14, 2015 at 05:57:39PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 06 Apr 2015 13:23:08 +0200 David Härdeman da...@hardeman.nu escreveu: Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. At the same time

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

On Wed, May 20, 2015 at 07:46:21PM +0300, Antti Seppälä wrote: On 19 May 2015 at 23:38, David Härdeman da...@hardeman.nu wrote: On Tue, Mar 31, 2015 at 08:48:06PM +0300, Antti Seppälä wrote: From: James Hogan ja...@albanarts.com Add a callback to raw ir handlers for encoding and modulating

[PATCH 0/4] rc-core fixups

The first two patches are fixups that should be uncontroversial. The third patch is another take on a similar patch already submitted by Sean. The fourth patch is another cleanup that should be applied before we look at implementing scancodes in the set/get keycode ioctls. --- David Härdeman

[PATCH 3/4] rc-core: remove the LIRC protocol

The LIRC protocol was always a bad fit and if we're ever going to expose protocol numbers in a user-space API, it'd be better to get rid of the LIRC protocol first. The sysfs API is kept backwards compatible by always listing the lirc protocol as present and enabled. Signed-off-by: David

Re: [PATCH v3 1/7] rc: rc-ir-raw: Add scancode encoder callback

suitable for raw hardware wake up filters. Signed-off-by: James Hogan ja...@albanarts.com Signed-off-by: Antti Seppälä a.sepp...@gmail.com Cc: David Härdeman da...@hardeman.nu --- Notes: Changes in v3: - Ported to apply against latest media-tree Changes in v2: - Alter encode

Re: [PATCH 4/4] ir-keytable: allow protocol for scancode-keycode mappings

On Thu, May 14, 2015 at 06:24:46PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 06 Apr 2015 13:26:18 +0200 David Härdeman da...@hardeman.nu escreveu: Introduce a list of kernel ir protocols (e.g. sony12 instead of sony) and extend the set-key command to ir-keytable to allow for a mapping

Re: [PATCH] rc-core: use an IDA rather than a bitmap

On Thu, May 14, 2015 at 05:29:29PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 02 Apr 2015 12:18:55 +0200 David Härdeman da...@hardeman.nu escreveu: This patch changes rc-core to use the kernel facilities that are already available for handling unique numbers instead of rolling its own bitmap

Re: [RFC PATCH 4/6] [media] rc: lirc is not a protocol or a keymap

-x10 -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] lmedm04: NEC scancode cleanup

This changes the keymap back to the state before commit 616a4b83 and changes the driver to use full NEC32 scancodes following the instructions provided by Malcolm Priestley tvbox...@gmail.com. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/keymaps/rc-lme2510.c | 132

[PATCH 2/4] rc-core: use an IDA rather than a bitmap

This patch changes rc-core to use the kernel facilities that are already available for handling unique numbers instead of rolling its own bitmap stuff. Signed-off-by: David Härdeman da...@hardeman.nu Tested-by: Stefan Lippers-Hollmann s@gmx.de --- drivers/media/rc/rc-ir-raw.c |2

[PATCH 1/4] rc-core: fix remove uevent generation

The input_dev is already gone when the rc device is being unregistered so checking for its presence only means that no remove uevent will be generated. Cc: sta...@kernel.org Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-main.c |3 --- 1 file changed, 3 deletions

Re: using TSOP receiver without lircd

On Mon, Apr 06, 2015 at 06:01:52PM +0200, Sergio Serrano wrote: Hi members! In the hope that someone can help me, I has come to this mailing list after contacting David Hardeman (thank you!). He has already given me some clues. This is my scenario. I'm using a OMAP2 processor and capturing

[PATCH 1/4] ir-keytable: clarify the meaning of ir protocols

Clarify that ir protocols refer to the ones used by sysfs (e.g. sony, not sony12 or sony15) and replace a bunch of if-else protocol comparison code with loops instead. Signed-off-by: David Härdeman da...@hardeman.nu --- utils/keytable/keytable.c | 408

[PATCH 2/4] ir-keytable: replace more sysfs if-else code with loops

Document the sysfs1 interface in protocol_map[] and replace some more if-else code with loops. Signed-off-by: David Härdeman da...@hardeman.nu --- utils/keytable/keytable.c | 124 - 1 file changed, 55 insertions(+), 69 deletions(-) diff --git a/utils

[PATCH 4/4] ir-keytable: allow protocol for scancode-keycode mappings

doesn't support the new approach with protocols. The read command is also updated to show the protocol information if the kernel supports it. Signed-off-by: David Härdeman da...@hardeman.nu --- utils/keytable/keytable.c | 288 - 1 file changed, 202

[PATCH 3/4] ir-keytable: cleanup keytable code

Cleanup the keytable code by giving the struct members more explicit names (scancode instead of codes[0], keycode instead of codes[1]). Also, replace a linked list implementation using a quirky empty list member as the head of the list rather than the classical pointer. Signed-off-by: David

[PATCH 0/4] Add protocol support to ir-keytable

(backward compatible) for set-key and reading the keytable. Separate patches would be necessary to also support reading keytable files with protocol information. --- David Härdeman (4): ir-keytable: clarify the meaning of ir protocols ir-keytable: replace more sysfs if-else code with loops

[PATCH 1/2] rc-core: use the full 32 bits for NEC scancodes

to NEC32 as necessary when userspace adds entries to the keytable using the regular input ioctls. No conversion will be made for the newer rc_keymap_entry based ioctls (see the next patch). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ir-nec-decoder.c| 26

[PATCH 2/2] rc-core: don't throw away protocol information

thing with older ioctls in order to preserve backwards compatibility. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ati_remote.c |1 drivers/media/rc/imon.c |7 + drivers/media/rc/rc-main.c| 196 + include/media/rc

[PATCH 0/2] NEC scancodes and protocols in keymaps - v2

information. v2: fix some bugs found while implementing support in ir-keytables. --- David Härdeman (2): rc-core: use the full 32 bits for NEC scancodes rc-core: don't throw away protocol information drivers/media/rc/ati_remote.c|1 drivers/media/rc/imon.c

Re: [PATCH 0/2] NEC scancodes and protocols in keymaps

On Thu, Apr 02, 2015 at 01:56:37PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 02 Apr 2015 14:02:57 +0200 David Härdeman da...@hardeman.nu escreveu: The following two patches should show more clearly what I mean by adding protocols to the keytables (and letting userspace add keytable entries

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Fri, Apr 03, 2015 at 11:11:30AM +0100, Sean Young wrote: On Thu, Apr 02, 2015 at 12:19:41AM +0200, David Härdeman wrote: On Tue, Mar 31, 2015 at 08:47:16PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 30 Mar 2015 23:18:19 +0200 David Härdeman da...@hardeman.nu escreveu: And on a much more

Re: [RFC PATCH] ir: add tools for receiving and sending ir

On Thu, Mar 19, 2015 at 09:51:08PM +, Sean Young wrote: Provide simple tools for displaying raw IR and received scancodes, and sending them. Todo: - ir-rec cannot enable protocol decoders - ir-send should accept scancode on commandline - long options Didn't look at it in detail, but I

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Wed, Apr 01, 2015 at 08:10:16PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 02 Apr 2015 00:19:41 +0200 David Härdeman da...@hardeman.nu escreveu: On Tue, Mar 31, 2015 at 08:47:16PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 30 Mar 2015 23:18:19 +0200 David Härdeman da...@hardeman.nu

[PATCH 1/2] rc-core: use the full 32 bits for NEC scancodes

to NEC32 as necessary when userspace adds entries to the keytable using the regular input ioctls. No conversion will be made for the newer rc_keymap_entry based ioctls (see the next patch). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ir-nec-decoder.c| 26

[PATCH 0/2] NEC scancodes and protocols in keymaps

information. --- David Härdeman (2): rc-core: use the full 32 bits for NEC scancodes rc-core: don't throw away protocol information drivers/media/rc/ati_remote.c|1 drivers/media/rc/imon.c |7 + drivers/media/rc/ir-nec-decoder.c| 26 --- drivers

[PATCH 2/2] rc-core: don't throw away protocol information

thing with older ioctls in order to preserve backwards compatibility. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ati_remote.c |1 drivers/media/rc/imon.c |7 + drivers/media/rc/rc-main.c| 195 + include/media/rc

[PATCH] rc-core: use an IDA rather than a bitmap

This patch changes rc-core to use the kernel facilities that are already available for handling unique numbers instead of rolling its own bitmap stuff. Stefan, this should apply cleanly to the media git tree...could you test it? --- drivers/media/rc/rc-ir-raw.c |2 +-

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Wed, Apr 01, 2015 at 08:10:16PM -0300, Mauro Carvalho Chehab wrote: Em Thu, 02 Apr 2015 00:19:41 +0200 David Härdeman da...@hardeman.nu escreveu: On Tue, Mar 31, 2015 at 08:47:16PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 30 Mar 2015 23:18:19 +0200 David Härdeman da...@hardeman.nu

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Tue, Mar 31, 2015 at 08:47:16PM -0300, Mauro Carvalho Chehab wrote: Em Mon, 30 Mar 2015 23:18:19 +0200 David Härdeman da...@hardeman.nu escreveu: On Thu, Mar 19, 2015 at 09:50:11PM +, Sean Young wrote: Second, if we expose protocol type (which we should, not doing so is throwing away

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Tue, Mar 31, 2015 at 12:08:37AM +0100, Sean Young wrote: On Mon, Mar 30, 2015 at 11:18:19PM +0200, David Härdeman wrote: On Thu, Mar 19, 2015 at 09:50:11PM +, Sean Young wrote: This patch series tries to fix the lirc interface and extend it so it can be used to send/recv scancodes

Re: mceusb: sysfs: cannot create duplicate filename '/class/rc/rc0' (race condition between multiple RC_CORE devices)

On 2015-03-30 17:30, Stefan Lippers-Hollmann wrote: Hi This is a follow-up for: http://lkml.kernel.org/r/201412181916.18051.s@gmx.de http://lkml.kernel.org/r/201412302211.40801.s@gmx.de I can't swear that it's the case but I'm guessing this might be fixed by the

Re: mceusb: sysfs: cannot create duplicate filename '/class/rc/rc0' (race condition between multiple RC_CORE devices)

On 2015-03-30 22:21, Stefan Lippers-Hollmann wrote: On 2015-03-30, David Härdeman wrote: On 2015-03-30 17:30, Stefan Lippers-Hollmann wrote: This is a follow-up for: http://lkml.kernel.org/r/201412181916.18051.s@gmx.de http://lkml.kernel.org/r/201412302211.40801.s@gmx.de I

Re: [RFC PATCH 0/6] Send and receive decoded IR using lirc interface

On Thu, Mar 19, 2015 at 09:50:11PM +, Sean Young wrote: This patch series tries to fix the lirc interface and extend it so it can be used to send/recv scancodes in addition to raw IR: - Make it possible to receive scancodes from hardware that generates scancodes (with rc protocol

[PATCH] rc-core: fix dib0700 scancode generation for RC5

commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9 cleaned up the NEC scancode logic but overlooked the RC5 case. This patch brings the RC5 case in line with the NEC code and makes the struct self-documenting. Signed-off-by: David Härdeman da...@hardeman.nu Reported-by: David Cimbůrek david.cimbu

[PATCH] rc-core: fix dib0700 scancode generation for RC5

David, could you please test this patch? --- drivers/media/usb/dvb-usb/dib0700_core.c | 70 +- 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c index 50856db..605b090

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

On 2015-02-24 11:08, David Cimbůrek wrote: Hi, I looked at this again and I still don't see why the order is important. Plus the code looks like it does what it should be doing when using RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and RC_SCANCODE_RC5. Unfortunately I can't review

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

On 2015-02-24 14:44, Mauro Carvalho Chehab wrote: Em Tue, 24 Feb 2015 11:15:53 +0100 David Härdeman da...@hardeman.nu escreveu: The output that you gave (the actual scancodes that are generated) is what I was looking for, not the keymap. If I remember correctly my patch wasn't supposed

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

Can you generate some scancodes before and after commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9? On 2015-02-11 14:53, David Cimbůrek wrote: David Härdeman: I'm using defaults, I have no custom modifications. 2015-02-11 14:24 GMT+01:00 David Härdeman da...@hardeman.nu: David C: are you

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

David C: are you using the in-kernel keymap or loading a custom one? On 2015-02-10 11:45, Antti Palosaari wrote: David Härdeman, Could you look that as it is your patch which has broken it commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9 Author: David Härdeman da...@hardeman.nu Date: Thu Apr

[PATCH] rc-core: fix toggle handling in the rc6 decoder

The toggle bit shouldn't be cleared before the toggle value is calculated. This should probably go into 3.17.x as well. Fixes: 120703f9eb32 ([media] rc-core: document the protocol type) Tested-by: Stephan Raue mailingli...@openelec.tv Signed-off-by: David Härdeman da...@hardeman.nu Cc: sta

Re: bisected: IR press/release behavior changed in 3.17, repeat events

On Sat, Nov 15, 2014 at 06:59:05PM +0100, Stephan Raue wrote: Hi with kernel 3.17 using a RC6 remote with a buildin nuvoton IR receiver (not tested others, but i think its a common problem) when pressing/releasing the same button often within 1 second there will no release event sent. Instead we

Re: bisected: IR press/release behavior changed in 3.17, repeat events

On Thu, Nov 20, 2014 at 12:20:55AM +0100, Stephan Raue wrote: with kernel 3.17: (you dont see the messages with toggle 1 here) if i press once and wait: Ummm...kinda embarassing...try swapping the order of the scancode and toggle lines in the rc6 decoder (drivers/media/rc/ir-rc6-decoder.c).

Re: [PATCH] [media] rc-main: Fix rc_type handling

On 2014-11-05 13:27, Mauro Carvalho Chehab wrote: As reported by smatch: drivers/media/rc/rc-main.c:1426 rc_register_device() warn: should '1 rc_map-rc_type' be a 64 bit type? Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git a/drivers/media/rc/rc-main.c

Re: [PATCH] [media] rc5-decoder: BZ#85721: Fix RC5-SZ decoding

On 2014-10-30 10:54, Mauro Carvalho Chehab wrote: changeset e87b540be2dd broke RC5-SZ decoding, as it forgot to add the extra bit check for the enabled protocols at the beginning of the logic. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: David Härdeman da

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

On 2014-10-26 20:33, Tomas Melin wrote: On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman da...@hardeman.nu wrote: Wouldn't something like this be a simpler way of achieving the same result? (untested): The idea was to remove the empty change_protocol function that had been added

Re: [PATCH v3] [media] rc-core: fix protocol_change regression in ir_raw_event_register

raw decoders to restore original behaviour. Signed-off-by: Tomas Melin tomas.me...@iki.fi Acked-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

On Tue, Oct 21, 2014 at 09:30:17PM +0300, Tomas Melin wrote: IR reciever using nuvoton-cir and lirc required additional configuration steps after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ([media] rc-core: simplify sysfs code).

Re: [PATCH 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

On 2014-10-19 12:21, Tomas Melin wrote: IR reciever using nuvoton-cir and lirc was not working anymore after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ([media] rc-core: simplify sysfs code). FWIW, I think not working is

Re: [PATCH 2/2] [media] rc-core: change enabled_protocol default setting

On 2014-10-19 12:21, Tomas Melin wrote: Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled by default. Protocol to use will be enabled when keycode table is written by

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

On Thu, Oct 09, 2014 at 09:30:36PM +0300, Tomas Melin wrote: IR reciever using nuvoton-cir and lirc was not working anymore after upgrade from kernel 3.16 to 3.17-rcX. Bisected regression to commit da6e162d6a4607362f8478c715c797d84d449f8b ([media] rc-core: simplify sysfs code). The regression

Re: [PATCH 00/49] rc-core: my current patch queue

On Fri, Apr 04, 2014 at 01:31:15AM +0200, David Härdeman wrote: The following patches is what I currenly have in my queue: Patches 1 - 6 should be ok to be committed right now, they contain some fixes and some reverts (of the NEC32 and generic scancode functionality). Patches 7 - 9

Re: [PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature

On Thu, Jun 19, 2014 at 10:25:29AM +0200, Niels Laukens wrote: Made the distinction between repeated key presses, and a single long press. The NEC-protocol does not have a toggle-bit (cfr RC5/RC6), but has specific repeat-codes. Not all NEC remotes use repeat codes. Some just transmit the full

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

Hi, the problem with triggering a keypress as soon as 32 bits have been received (i.e. before the trailing silence is detected) is that it would cause phantom keypresses on some other protocols (I'm thinking of NEC48, which does exist in the wild). Now, the question is why the trailing

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

On 2014-06-12 13:22, Niels Laukens wrote: On 2014-06-12 12:42, David Härdeman wrote: Hi, Hi, thanks for the response the problem with triggering a keypress as soon as 32 bits have been received (i.e. before the trailing silence is detected) Just for clarity: this patch does wait

Re: [BUG PATCH] media/rc/ir-nec-decode : phantom keypress

On 2014-06-12 14:12, Niels Laukens wrote: On 2014-06-12 13:51, David Härdeman wrote: On 2014-06-12 13:22, Niels Laukens wrote: In that case, the alternative would be to start a timer when the TRAILING_SPACE is entered, and trigger the key-event after, say 2 bit-times. Another alternative

Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver

On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: This patch adds driver for sunxi IR controller. It is based on Alexsey Shestacov's work based on the original driver supplied by Allwinner. ... +static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) +{ + unsigned long

[PATCH 0/3] 3.15 fixes

-by lines if he agrees to each patch). --- David Härdeman (3): rc-core: do not change 32bit NEC scancode format for now rc-core: split dev-s_filter rc-core: remove generic scancode filter drivers/media/rc/img-ir/img-ir-hw.c | 15 + drivers/media/rc/img-ir/img-ir-nec.c | 27

[PATCH 1/3] rc-core: do not change 32bit NEC scancode format for now

: update comments Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/img-ir/img-ir-nec.c | 27 ++- drivers/media/rc/ir-nec-decoder.c|5 -- drivers/media/rc/keymaps/rc-tivo.c | 86 +- 3 files changed, 59 insertions(+), 59

[PATCH 2/3] rc-core: split dev-s_filter

should be moved from this to the next patch. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/img-ir/img-ir-hw.c | 15 ++- drivers/media/rc/rc-main.c | 24 +--- include/media/rc-core.h |6 -- 3 files changed, 35

[PATCH 3/3] rc-core: remove generic scancode filter

the valid sysfs files are created in the first place. v2: correct dev-s_filter check v3: move some parts over from the previous patch Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-main.c | 88 +++- include/media/rc-core.h|2

Re: [GIT PULL for v3.15-rc1] media updates

missed something? -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 05/49] rc-core: split dev-s_filter

Overloading dev-s_filter to do two different functions (set wakeup filters and generic hardware filters) makes it impossible to tell what the hardware actually supports, so create a separate dev-s_wakeup_filter and make the distinction explicit. Signed-off-by: David Härdeman da...@hardeman.nu

[PATCH 06/49] rc-core: remove generic scancode filter

the valid sysfs files are created in the first place. v2: correct dev-s_filter check Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/rc-main.c | 67 +--- include/media/rc-core.h|2 + 2 files changed, 46 insertions(+), 23

[PATCH 08/49] lmedm04: NEC scancode cleanup

This changes the keymap back to the state before commit 616a4b83 and changes the driver to use full NEC32 scancodes following the instructions provided by Malcolm Priestley tvbox...@gmail.com. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/keymaps/rc-lme2510.c | 132

[PATCH 00/49] rc-core: my current patch queue

). Lots and lots of cleanups as well. Enjoy :) --- David Härdeman (49): bt8xx: fixup RC5 decoding rc-core: improve ir-kbd-i2c get_key functions rc-core: document the protocol type rc-core: do not change 32bit NEC scancode format for now rc-core: split dev-s_filter rc

[PATCH 04/49] rc-core: do not change 32bit NEC scancode format for now

Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/img-ir/img-ir-nec.c | 27 ++- drivers/media/rc/ir-nec-decoder.c|5 -- drivers/media/rc/keymaps/rc-tivo.c | 86 +- 3 files changed, 59 insertions(+), 59 deletions(-) diff --git

[PATCH 03/49] rc-core: document the protocol type

and makes it easier to e.g. support multiple protocols with one decoder (think rc5 and rc-streamzap). The information isn't used yet so there should be no functional changes. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/i2c/ir-kbd-i2c.c |5 + drivers/media/pci

[PATCH 02/49] rc-core: improve ir-kbd-i2c get_key functions

The arguments used for ir-kbd-i2c's get_key() functions are not really suited for rc-core and the ir_raw/ir_key distinction is just confusing. Convert all of them to return a protocol/scancode/toggle triple instead. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/i2c/ir-kbd

[PATCH 09/49] saa7134: NEC scancode fix

hint that the change is correct). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/pci/saa7134/saa7134-input.c |2 - drivers/media/rc/keymaps/rc-behold.c | 68 +++-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/media

[PATCH 01/49] bt8xx: fixup RC5 decoding

that this is perfectly backwards compatible). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/pci/bt8xx/bttv-input.c | 62 ++- drivers/media/pci/bt8xx/bttvp.h |2 - drivers/media/rc/keymaps/rc-nebula.c | 112 +- 3 files changed, 88

[PATCH 07/49] dib0700: NEC scancode cleanup

in drivers/media/rc/ir-nec-decoder.c. This patch changes the code to match my assumption (the generated scancode should, however, not change). Signed-off-by: David Härdeman da...@hardeman.nu CC: Patrick Boettcher pboettc...@kernellabs.com --- drivers/media/usb/dvb-usb/dib0700_core.c | 28

[PATCH 11/49] [RFC] rc-core: don't throw away protocol information

to communicate the protocol to userspace. This needs review by the input maintainer as well. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ati_remote.c |1 drivers/media/rc/imon.c | 12 ++- drivers/media/rc/rc-main.c| 182

<    1   2   3   4   5   6   >