AT91: m10/g45: add Atmel ISI device and OV2640 on board.
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/mach-at91/at91sam9g45_devices.c | 66
arch/arm/mach-at91/board-sam9m10g45ek.c | 97 ++
arch/arm/mach-at91/include/mach/board.h
This patch enable the configuration for ISI_MCK, which is provided by
programmable clock.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/video/atmel-isi.c | 56 ++-
include/media/atmel-isi.h |4 +++
2 files changed, 59 insertions(+), 1
This patch enable the configuration for ISI_MCK, which is provided by
programmable clock.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/video/atmel-isi.c | 60 ++-
include/media/atmel-isi.h |4 ++
2 files changed, 63 insertions(+), 1
This patch add code to enable/disable ISI_MCK clock when add/remove soc camera
device.it also set ISI_MCK frequence before using it.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/video/atmel-isi.c | 30 --
include/media/atmel-isi.h |2 ++
2
This patch
1. add ISI_MCK parent setting code when add ISI device.
2. add ov2640 support on board file.
3. define isi_mck clock in sam9g45 chip file.
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/mach-at91/at91sam9g45.c |3 +
arch/arm/mach-at91/at91sam9g45_devices.c | 105
This patch
- add ISI_MCK clock enable/disable code.
- change field name in isi_platform_data structure
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/video/atmel-isi.c | 34 +++---
include/media/atmel-isi.h |4 +++-
2 files changed, 34
to
at91_add_device_isi, so that the SoC programmable clock can be used or not.
To summary, programmable clock is managed in SoC level. The user can decide to
use or not to use SoC clock as the sensor MCK at board level.
In later case, user has to provide a clock source named isi_mck
Best Regards,
Josh
This patch add parameters for at91_add_device_isi function
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/mach-at91/at91sam9263_devices.c | 13 ++---
arch/arm/mach-at91/include/mach/board.h |4 +++-
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm
This patch add:
- ov2640 sensor in sam9m10/sam9g45 board.
- support to use PCK as ISI_MCK. PCK's parent is managed in SoC level, e.g.
at91sam9g45_devices.c
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/mach-at91/at91sam9g45_devices.c | 98 +-
arch/arm/mach
Signed-off-by: Josh Wu josh...@atmel.com
---
fix codeing style
using bool instead of int for boolean type
arch/arm/mach-at91/at91sam9263_devices.c | 13 ++---
arch/arm/mach-at91/include/mach/board.h |4 +++-
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm
This patch adds:
- ov2640 sensor in sam9m10/sam9g45 board
- support to use PCK as ISI_MCK. PCK's parent is managed in SoC level, e.g.
at91sam9g45_devices.c
Signed-off-by: Josh Wu josh...@atmel.com
---
fix the coding style
using simpler code
arch/arm/mach-at91/at91sam9g45_devices.c | 94
This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
- Using soc-camera framework with videobuf2 dma-contig allocator
- Supporting video streaming of YUV packed format
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
---
base on branch
This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
- Using soc-camera framework with videobuf2 dma-contig allocator
- Supporting video streaming of YUV packed format
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
---
base on branch
This patch is to enable Atmel Image Sensor Interface (ISI) driver support.
- Using soc-camera framework with videobuf2 dma-contig allocator
- Supporting video streaming of YUV packed format
- Tested on AT91SAM9M10G45-EK with OV2640
Signed-off-by: Josh Wu josh...@atmel.com
---
base on branch
Signed-off-by: Josh Wu josh...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
Hi, Mauro
The first patch of this serie, [PATCH 1/2 v3] V4L: atmel-isi: add code to
enable/disable ISI_MCK clock, is already queued in media tree.
But this patch (the second one of this serie
Signed-off-by: Josh Wu josh...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
v2: made the label name to be consistent.
v4: add goto for handling pclk prepare error.
drivers/media/video/atmel-isi.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff
This patch
- add ISI_MCK clock enable/disable code.
- change field name in isi_platform_data structure
Signed-off-by: Josh Wu josh...@atmel.com
[g.liakhovet...@gmx.de: fix label names]
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
This patch
- add ISI_MCK clock enable/disable code.
- change field name in isi_platform_data structure
Signed-off-by: Josh Wu josh...@atmel.com
[g.liakhovet...@gmx.de: fix label names]
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Signed-off-by: Josh Wu josh...@atmel.com
---
in v2 version, made the label name to be consistent
drivers/media/video/atmel-isi.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/atmel-isi.c b/drivers/media/video/atmel-isi.c
index
This patch
- add ISI_MCK clock enable/disable code.
- change field name in isi_platform_data structure
Signed-off-by: Josh Wu josh...@atmel.com
[g.liakhovet...@gmx.de: fix label names]
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Signed-off-by: Josh Wu josh...@atmel.com
---
in v2 version, made the label name to be consistent
drivers/media/video/atmel-isi.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/atmel-isi.c b/drivers/media/video/atmel-isi.c
index
data is invalid.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/platform/soc_camera/atmel-isi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera/atmel-isi.c
index
into
atmel_isi.
Thank you all for the replies. That helps a lot even in this small
patch. :)
On 8/30/2012 12:02 AM, Guennadi Liakhovetski wrote:
On Wed, 29 Aug 2012, Sylwester Nawrocki wrote:
Hi,
On 08/29/2012 12:11 PM, Josh Wu wrote:
This patch fix the bug: ISI driver's platform data became
Move the clock detection code to the beginning of the probe().
If we meet any error in the clock detecting, then defer the probe.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/i2c/soc_camera/ov2640.c | 43 +
1 file changed, 28 insertions(+), 15
register a mclk v4l2 clock.
This clock is needed when the soc-camera i2c sensor driver is probed. Otherwise
the
sensor will always defer the probe and can not probe.
Best Regards,
Josh Wu
+
+ ret = v4l2_async_notifier_register(ici-v4l2_dev,
sasc-notifier
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/platform/soc_camera/atmel-isi.c |5 +
include/media/atmel-isi.h |4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions
This patch series add DT support for atmel ISI driver. It can support the
common v4l2 DT interfaces.
Josh Wu (3):
[media] atmel-isi: add v4l2 async probe support
[media] atmel-isi: convert the pdata from pointer to structure
[media] atmel-isi: add primary DT support
.../devicetree
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu josh...@atmel.com
Cc: devicet...@vger.kernel.org
---
.../devicetree/bindings/media/atmel-isi.txt| 51
drivers/media
Hi, Laurent
On 3/18/2014 9:36 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
Thanks for your review.
On Tuesday 18 March 2014 19:19:54 Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt
Hi, Sylwester
Thanks for your review.
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(client-dev, mclk);
+if (IS_ERR(clk))
+return -EPROBE_DEFER;
You should instead make it:
return PTR_ERR(clk
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probing. So move the v4l2_clk_get() to the beginning of the
probe(). Only when we get mclk successfully we continue the probe.
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
just return PTR_ERR(clk) as it can
This patch series add DT support for atmel ISI driver. It can support the
common v4l2 DT interfaces.
v1 -- v2:
modified the device tree binding document to remove the a optional property.
Josh Wu (3):
[media] atmel-isi: add v4l2 async probe support
[media] atmel-isi: convert the pdata from
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 -- v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c |5 +
include/media/atmel-isi.h |4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 -- v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---
1 file changed, 11
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu josh...@atmel.com
Cc: devicet...@vger.kernel.org
---
v1 -- v2:
refine the binding document.
add port node description.
removed the optional
Hi, Sylwester
On 3/20/2014 10:44 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 19/03/14 10:17, Josh Wu wrote:
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(client-dev, mclk);
+if (IS_ERR(clk))
+return -EPROBE_DEFER
Hi, all
since v4l2_clk_get() WON'T return EPROBE_DEFER. So this version of patch
is invalid.
Please drop this version of the patch.
Sorry for the noise.
Best Regards,
Josh Wu
On 3/20/2014 5:01 PM, Josh Wu wrote:
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probing. So
for the mainline.
BTW: I will test Ben's patch with atmel-isi.
thanks and best regards,
Josh Wu
Thanks
Guennadi
On Tue, 25 Mar 2014, Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu
i2c adaptor ID and addr.
So the i2c sensor can not find this registered mclk as the name is not match.
Best Regards,
Josh Wu
+
+ icd-clk = v4l2_clk_register(soc_camera_clk_ops, clk_name, mclk,
icd);
+ if (IS_ERR(icd-clk)) {
+ ret = PTR_ERR(icd-clk);
+ goto
Hi, Ben
On 3/31/2014 6:10 PM, Ben Dooks wrote:
On 31/03/14 10:28, Josh Wu wrote:
Hi, Ben
Thanks for the patch, I just test atmel-isi with the your patch,
I find the mclk registered in soc-camera driver cannot be find
by the soc-camera sensors. See comment in below:
Ok, I guess
.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Guennadi
On 5/19/2014 5:51 AM, Guennadi Liakhovetski wrote:
On Tue, 25 Mar 2014, Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu josh...@atmel.com
Cc: devicet
2014, Josh Wu wrote:
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 -- v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---
1
Regards,
Josh Wu
On Monday 31 March 2014 17:05:13 Josh Wu wrote:
Dear Guennadi
On 3/31/2014 5:20 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Please correct me if I'm wrong, but I don't see how this is going to work
without the central part - building asynchronous V4L2 data structures from
the DT
add check for multiple subdevices]
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
I tested in sama5d3xek board with Atmel-isi dt and ov2640 dt. It works fine.
Tested-by: Josh Wu josh...@atmel.com
Best Regards,
Josh Wu
---
Hi Ben,
How about this version? Could you review and test
This patch series add DT support for atmel ISI driver. It can support the
common v4l2 DT interfaces.
v2 - v3:
support bus-width property for atmel-isi endpoint.
v1 - v2:
modified the device tree binding document to remove an optonal property.
Josh Wu (3):
atmel-isi: add v4l2 async probe
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 5 +
include/media/atmel-isi.h | 4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
use sizeof(isi-pdata) instead of using sizeof(struct).
drivers/media/platform/soc_camera/atmel-isi.c | 22
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu josh...@atmel.com
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
v2 - v3:
add bus-width property
the device tree binding document to remove an optonal property.
Josh Wu (3):
atmel-isi: add v4l2 async probe support
atmel-isi: convert the pdata from pointer to structure
atmel-isi: add primary DT support
.../devicetree/bindings/media/atmel-isi.txt| 51
drivers/media
Signed-off-by: Josh Wu josh...@atmel.com
---
v3 - v4:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 5 +
include/media/atmel-isi.h | 4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu josh...@atmel.com
---
v3 - v4:
no change.
v2 - v3:
use sizeof(isi-pdata) instead of using sizeof(struct).
drivers/media/platform/soc_camera
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu josh...@atmel.com
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
v3 - v4:
When bus width is 10
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu josh...@atmel.com
---
include/media/v4l2-image-sizes.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/media/v4l2-image-sizes.h b/include/media
Reuse the v4l2 size definitions from v4l2-image-sizes.h.
So we can remove the rudundent definitions from ov2640.c.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/i2c/soc_camera/ov2640.c | 82 +--
1 file changed, 30 insertions(+), 52 deletions(-)
diff
The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.
Otherwise sometime it would cause the ISI overflow error.
Reported-by: Bo Shen voice.s...@atmel.com
Signed-off-by: Josh Wu josh...@atmel.com
Hi, Sylwester and Mauro
On 11/25/2014 6:34 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 25/11/14 09:54, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu josh...@atmel.com
---
include/media/v4l2
Hi, Gunenadi
On 11/26/2014 6:21 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.
Otherwise sometime it would cause
SVGA height should be 600 not 680.
Reported-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Josh Wu josh...@atmel.com
---
Hi, Mauro
There a typo in my previous patch, so this patch is the fix for that.
Sorry for the incovenience.
Best Regards,
Josh Wu
include/media/v4l2-image
Hi, Guennadi
On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu josh...@atmel.com
Thanks for your patches. I'm
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
Josh Wu (4):
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640: add a master clock for sensor
media: ov2640: dt: add the device tree
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
Josh Wu (4):
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640: add a master clock for sensor
media: ov2640: dt: add the device tree
()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host's clock as well.
Signed-off-by: Josh Wu josh
The master clock can be optional. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
If you just use a external oscillator clock as the master clock, then,
just don't need set 'mck' in dt node.
Signed-off-by: Josh Wu josh...@atmel.com
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
.../devicetree/bindings/media/i2c/ov2640.txt | 43 ++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2640.txt
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/i2c/soc_camera/ov2640.c | 95 ---
1 file changed, 89 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/ov2640.c
b
Hi, Laurent
On 12/2/2014 6:14 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 28 November 2014 18:28:27 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
.../devicetree/bindings/media/i2c
Hi, Laurent
On 12/2/2014 6:26 AM, Laurent Pinchart wrote:
Hi Josh,
(CC'ing the devicet...@vger.kernel.org mailing list)
Thank you for the patch.
On Friday 28 November 2014 18:28:26 Josh Wu wrote:
The master clock can be optional. It's a common clock framework clock.
It can make sensor
Hi, Laurent
On 12/2/2014 6:33 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 28 November 2014 18:28:25 Josh Wu wrote:
Add device tree support for ov2640.
Cc:devicet...@vger.kernel.org
Signed-off-by: Josh Wujosh...@atmel.com
---
drivers/media/i2c/soc_camera/ov2640
()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host's clock as well.
Signed-off-by: Josh Wu josh
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
v1 - v2:
1. modified the dt bindings according to Laurent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
media: soc
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
1. use gpiod APIs.
2. change the gpio pin's name according to datasheet.
3. reduce the delay for .reset() function.
drivers/media/i2c/soc_camera/ov2640.c | 86
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
1. change the clock's name.
2. Make the clock is mandatory
icd-control is the sub device dev, i.e. i2c device.
icd-pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd-control as well.
Signed-off-by: Josh Wu josh...@atmel.com
---
drivers/media/platform/soc_camera/soc_camera.c | 10 ++
1
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
1. change the compatible string to be consistent with verdor file.
2. change the clock and pins' name.
3. add missed pinctrl in example.
.../devicetree/bindings/media/i2c
Hi, Fabio
On 12/8/2014 11:10 PM, Fabio Estevam wrote:
On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu josh...@atmel.com wrote:
+ priv-master_clk = devm_clk_get(client-dev, xvclk);
+ if (IS_ERR(priv-master_clk))
+ return -EINVAL;
You should return PTR_ERR(priv-master_clk
Hi, Laurent
On 12/9/2014 2:39 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Monday 08 December 2014 19:29:05 Josh Wu wrote:
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
1. use gpiod APIs.
2
Hi, Laurent
On 12/9/2014 2:59 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Monday 08 December 2014 19:29:07 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v1 - v2:
1. change the compatible
suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
media: soc-camera: use icd-control instead of icd-pdev for reset()
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640: add a master clock
icd-control is the sub device dev, i.e. i2c device.
icd-pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd-control as well.
Signed-off-by: Josh Wu josh...@atmel.com
---
v2-v3:
1. check whether icd-control is NULL or not.
drivers/media
()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host's clock as well.
Signed-off-by: Josh Wu josh
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
1. fix gpiod usage.
2. refine the ov2640_probe() function.
v1 - v2:
1. use gpiod APIs.
2. change the gpio pin's name according to datasheet.
3. reduce the delay
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
1. should return PTR_ERR().
v1 - v2:
1. change the clock's name
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
1. fix incorrect description.
2. Add assigned-clocks assigned-clock-rates.
3. resetb pin should be ACTIVE_LOW.
v1 - v2:
1. change the compatible string to be consistent
Hi, Laurent
On 12/11/2014 4:10 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
I only have three minor comments. After fixing them,
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Thanks for the review.
On Thursday 11 December 2014 15:35:37 Josh Wu wrote:
Add
Hi, Laurent
On 12/12/2014 10:17 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 11 December 2014 15:35:39 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v2 - v3:
1. fix incorrect
.
v1 - v2:
1. modified the dt bindings according to Laurent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
media: soc-camera: use icd-control instead of icd-pdev for reset()
media: ov2640: add async probe function
media: ov2640
icd-control is the sub device dev, i.e. i2c device.
icd-pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd-control as well.
Signed-off-by: Josh Wu josh...@atmel.com
---
v3-v4:
none
v2-v3:
1. check whether icd-control is NULL
()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host's clock as well.
Signed-off-by: Josh Wu josh
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
v3 - v4:
1.modify the code comment.
2. Add Laurent's acked by.
v2 - v3:
1. fix gpiod usage.
2. refine
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
v3 - v4:
1. Add
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu josh...@atmel.com
---
v3 - v4:
1. remove aggsigned-clocks as it's general.
2. refine the explation.
v2 - v3:
1. fix incorrect description.
2. Add assigned-clocks assigned-clock-rates.
3. resetb pin
: sama5d3: add missing pins of isi
ARM: at91: dts: sama5d3: move the isi mck pin to mb
Josh Wu (4):
ARM: at91: dts: sama5d3: add isi clock
ARM: at91: dts: sama5d3: change name of pinctrl_isi_{power,reset}
ARM: at91: dts: sama5d3: add ov2640 camera sensor support
ARM: at91: sama5: enable atmel
nicolas.fe...@atmel.com
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/boot/dts/sama5d3.dtsi| 11 ---
arch/arm/boot/dts/sama5d3xmb.dtsi | 2 +-
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 61746ef
From: Bo Shen voice.s...@atmel.com
The ISI has 12 data lines, add the missing two data lines.
Signed-off-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
---
arch/arm/boot/dts/sama5d3.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git
Add ISI peripheral clock in sama5d3.dtsi.
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/boot/dts/sama5d3.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 5f4144d..61746ef 100644
--- a/arch/arm/boot/dts
For sama5d3xmb board, the pins: pinctrl_isi_{power,reset} is used to
power-down or reset camera sensor.
So we should let camera sensor instead of ISI to configure the pins.
This patch will change pinctrl name from pinctrl_isi_{power,reset} to
pinctrl_sensor_{power,reset}.
Signed-off-by: Josh Wu
From: Bo Shen voice.s...@atmel.com
The mck is decided by the board design, move it to mb related
dtsi file.
Signed-off-by: Bo Shen voice.s...@atmel.com
Acked-by: Nicolas Ferre nicolas.fe...@atmel.com
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm/boot/dts/sama5d3.dtsi| 5 -
arch
According to v4l2 dt document, we add:
a camera host: ISI port.
a i2c camera sensor: ov2640 port.
to sama5d3xmb.dtsi.
In the ov2640 node, it defines the pinctrls, clocks and isi port.
In the ISI node, it also reference to a ov2640 port.
Signed-off-by: Josh Wu josh...@atmel.com
---
arch/arm
1 - 100 of 229 matches
Mail list logo
