On Thu, 2018-05-31 at 17:30 -0700, Steve Longerbeam wrote:
> The output pad's field type was being passed to ipu_csi_init_interface(),
> in order to deal with field type 'alternate' at the sink pad, which
> is not understood by ipu_csi_init_interface().
>
> Remove that code and pass the sink pad f
The IPU also supports interlaced buffers that start with the bottom field.
To achieve this, the the base address EBA has to be increased by a stride
length and the interlace offset ILO has to be set to the negative stride.
Signed-off-by: Philipp Zabel
---
drivers/gpu/ipu-v3/ipu-cpmem.c | 8
Hi Krzysztof,
On Fri, 2018-06-01 at 12:02 +0200, Krzysztof Hałasa wrote:
> Steve Longerbeam writes:
>
> > I tend to agree, I've found conflicting info out there regarding
> > PAL vs. NTSC field order. And I've never liked having to guess
> > at input analog standard based on input # lines. I wil
On Wed, May 30, 2018 at 01:56:34PM -0700, Steve Longerbeam wrote:
>
>
> On 05/30/2018 11:46 AM, Krzysztof Hałasa wrote:
> > Steve Longerbeam writes:
> >
> > > > but it should be possible for the user to explicitly request the field
> > > > order on CSI output (I can make a patch I guess).
> > >
On Mon, May 28, 2018 at 09:38:42AM -0700, Steve Longerbeam wrote:
> On 05/28/2018 12:59 AM, Ian Arkver wrote:
> > If your intent here is to de-interweave the two fields back to two
> > sequential fields, I don't believe the IDMAC operation would achieve
> > that. It's basically line stride doubling
On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote:
> Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC
> output pad if the input field type is 'alternate' (in addition to field
> types 'seq-tb' and 'seq-bt').
>
> Which brings up whether V4L2_FIELD_HAS_BOTH() macro shou
Hi Steve,
On Thu, 2018-05-24 at 14:33 -0700, Steve Longerbeam wrote:
> Hi Krzysztof, Philipp,
>
> And I can confirm that capturing planar 4:2:0 (YU12, YV12, or NV12),
> is broken because of the call to ipu_cpmem_skip_odd_chroma_rows().
> YU12 or NV12 images look correct again when commenting out
On Thu, 2018-05-24 at 11:12 -0700, Steve Longerbeam wrote:
[...]
> > The following is required as well. Now the question is why we can't skip
> > writing those odd UV rows. Anyway, with these 2 changes, I get a stable
> > NTSC (and probably PAL) interlaced video stream.
> >
> > The manual says: Re
Limit frame sizes to the [1, 65536] interval, media bus formats to
the available list of formats, and initialize pad and try formats.
Reported-by: Rui Miguel Silva
Signed-off-by: Philipp Zabel
Tested-by: Rui Miguel Silva
Acked-by: Sakari Ailus
---
Changes since v2:
- Make loop variables
Hi Sakari,
thank you for the review comments.
On Thu, 2018-05-24 at 14:38 +0300, Sakari Ailus wrote:
> Hi Philipp,
>
> Thanks for the patch.
>
> On Wed, May 23, 2018 at 11:24:23AM +0200, Philipp Zabel wrote:
> > Limit frame sizes to the [1, 65536] interval, media b
Hi Jan,
Hans just pointed out a few issues in my video-mux compliance patch [1]
that also apply to this driver, see below.
[1] v1: https://patchwork.linuxtv.org/patch/49827/
v2: https://patchwork.linuxtv.org/patch/49839/
On Fri, 2018-05-04 at 14:49 +0200, Jan Luebbe wrote:
[...]
> diff --git
On Wed, 2018-05-23 at 10:53 +0200, Hans Verkuil wrote:
> On 23/05/18 10:47, Philipp Zabel wrote:
> > Hi Hans,
> >
> > thank you for the review comments.
> >
> > On Tue, 2018-05-22 at 19:47 +0200, Hans Verkuil wrote:
> > > On 22/05/18 18:29, Philipp Zab
Limit frame sizes to the [1, 65536] interval, media bus formats to
the available list of formats, and initialize pad and try formats.
Reported-by: Rui Miguel Silva
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Limit to [1, 65536] instead of [1, UINT_MAX - 1]
- Add missing break in
Hi Hans,
thank you for the review comments.
On Tue, 2018-05-22 at 19:47 +0200, Hans Verkuil wrote:
> On 22/05/18 18:29, Philipp Zabel wrote:
> > Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to
> > the available list of formats, and initialize pad
Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to
the available list of formats, and initialize pad and try formats.
Reported-by: Rui Miguel Silva
Signed-off-by: Philipp Zabel
---
drivers/media/platform/video-mux.c | 110 +
1 file changed, 110
Hi Marek,
On Fri, 2018-05-18 at 18:21 +0200, Marek Vasut wrote:
> On 05/18/2018 05:51 PM, Philipp Zabel wrote:
> > Hi Marek,
> >
> > On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote:
> > > The BT1120 interlaced CCIR codes are the same as BT656 ones
> > &g
probe error path. This also allows to remove the temporary additional
reference in uvc_unregister_video.
Fixes: 9d15cd958c17 ("media: uvcvideo: Convert from using an atomic variable to
a reference count")
Signed-off-by: Philipp Zabel
---
drivers/media/usb/uvc/uvc_driver.c | 11 ++---
On Fri, 2018-05-18 at 10:28 +0100, Rui Miguel Silva wrote:
> Add bindings documentation for i.MX7 media drivers.
>
> Signed-off-by: Rui Miguel Silva
> ---
> .../devicetree/bindings/media/imx7.txt| 125 ++
> 1 file changed, 125 insertions(+)
> create mode 100644 Documenta
erbeam
> Cc: Philipp Zabel
> ---
> drivers/gpu/ipu-v3/ipu-csi.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c
> index caa05b0702e1..301a729581ce 100644
> --- a/drivers/gpu/ipu-
es handling the different configurations for RGB565 between
> parallel and MIPI CSI-2, as we don't need to check the details of the
> format anymore.
>
> Signed-off-by: Jan Luebbe
Reviewed-by: Philipp Zabel
regards
Philipp
is used for generic formats on the parallel bus.
>
> Based on the selected format and bus, we then update the width to
> account for the multiple cycles per pixel.
>
> Signed-off-by: Jan Luebbe
> Signed-off-by: Steve Longerbeam
I only have a small suggestion below, either wa
On Fri, 2018-05-18 at 10:27 +0100, Rui Miguel Silva wrote:
> This add the media entity subdevice and control driver for the i.MX7
> CMOS Sensor Interface.
>
> Signed-off-by: Rui Miguel Silva
> ---
[...]
> +static int imx7_csi_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &
Hi Rui,
thank you for refactoring, I think this is much better than having the
pretend capture-subsytem device in the DT.
I would like to get rid of the ipu_present flag, if it can be done
reasonably. For details, see below.
On Fri, 2018-05-18 at 10:27 +0100, Rui Miguel Silva wrote:
> Refactor a
> The remaining patches update the subdev drivers to register a
> subdev notifier with endpoint parsing, and the changes to imx-media
> to support that.
>
> Signed-off-by: Steve Longerbeam
> Acked-by: Philipp Zabel
Patches 07-14 (video-mux and the imx patches) are
Reviewed-by: Philipp Zabel
The series is
Tested-by: Philipp Zabel
on i.MX6 with Toshiba TC358743 connected via MIPI CSI-2.
regards
Philipp
ible = "mmio-mux";
> + #mux-control-cells = <1>;
> + mux-reg-masks = <0x14 0x0010>;
> + };
> };
>
> ocotp: ocotp-ctrl@3035 {
Reviewed-by: Philipp Zabel
regards
Philipp
On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote:
> This patch adds the device tree nodes for csi, video multiplexer and mipi-csi
> besides the graph connecting the necessary endpoints to make the media capture
> entities to work in imx7 Warp board.
>
> Also add the pin control related wi
On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote:
> Add bindings documentation for i.MX7 media drivers.
>
> Signed-off-by: Rui Miguel Silva
> ---
> .../devicetree/bindings/media/imx7.txt| 152 ++
> 1 file changed, 152 insertions(+)
> create mode 100644 Documenta
y pass on the format in the second patch.
>
> Changes since v1:
> - fixed problems reported the kbuild test robot
> - added helper functions as suggested by Steve Longerbeam
> (is_parallel_bus and requires_passthrough)
> - removed passthough format check in csi_link_valida
quot;media: imx-
csi: fix burst size"), but for 16-bit formats.
Acked-by: Philipp Zabel
regards
Philipp
tured from sensors
that provide MEDIA_BUS_FMT_Y10_1X10 or MEDIA_BUS_FMT_Y12_1X12 data.
Cc: Jan Luebbe
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
drivers/staging/media/imx/imx-media-utils.c | 9 +
2 files changed, 10 insertions(+)
diff --git a/drive
Instead of duplicating the same code, call into coda_s_fmt_vid_out to
propagate the output format to the capture queue.
Signed-off-by: Philipp Zabel
---
Changes since v1 [1]:
- split out into a separate patch
[1] https://patchwork.linuxtv.org/patch/48266/
This is what coda_s_fmt_vid_cap
-by: Philipp Zabel
---
Added patch since v1 [1]:
- remove automatic format propagation on S_FMT(OUT) for encoders
- adding S_FMT(CAP) propagation from capture to output queue for
encoders is left for a later time, this isn't even documented yet.
[1] https://patchwork.linuxtv.org/patch/
The driver helpfully resets the capture queue format and selection
rectangle whenever output format is changed. This only works while
the capture queue is not busy.
Signed-off-by: Philipp Zabel
---
Changes since v1 [1]:
- split out into a separate patch
[1] https://patchwork.linuxtv.org/patch
Hi Javier,
On Mon, 2018-04-23 at 11:29 +0200, Javier Martin wrote:
> Sorry for resurrecting this thread but I'm still quite interested on
> making this scenario work:
>
> > OK, I've performed some tests with several resolutions and gop sizes,
> here is the table with the results:
> >
> > A
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote:
> Add imx7 capture subsystem to imx-media core to allow the use some of the
> existing modules for i.MX5/6 with i.MX7 SoC.
>
> Since i.MX7 does not have an IPU unset the ipu_present flag to differentiate
> some runtime behaviors.
>
> Sign
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote:
> This patch adds the device tree nodes for csi, video multiplexer and mipi-csi
> besides the graph connecting the necessary endpoints to make the media capture
> entities to work in imx7 Warp board.
>
> Also add the pin control related wi
t; > This issue was detected with the help of Coccinelle.
> >
> > Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used")
> > Signed-off-by: Gustavo A. R. Silva
> > Signed-off-by: Fabio Estevam
> > Acked-by: Philipp Zabel
Reviewed-by: Philipp Zabel
Tested-by: Philipp Zabel
regards
Philipp
Hi Paul,
On Thu, 2018-04-19 at 17:45 +0200, Paul Kocialkowski wrote:
> This adds a device-tree binding document that specifies the properties
> used by the Sunxi-Cedurs VPU driver, as well as examples.
>
> Signed-off-by: Paul Kocialkowski
> ---
> .../devicetree/bindings/media/sunxi-cedrus.txt
On Thu, 2018-04-19 at 11:18 +0100, Rui Miguel Silva wrote:
> Some sensors can only output 10 bit bayer formats, like the OV2680. Add
> support
> for that in imx-media.
>
> Signed-off-by: Rui Miguel Silva
> ---
> drivers/staging/media/imx/imx-media-utils.c | 24 +
> 1 file ch
Printing the queried and current DV timings is already supported as part
of the --print-topology option. Add a --get-dv option to print DV
timings of an individual entitiy, to complement --set-dv.
Signed-off-by: Philipp Zabel
---
utils/media-ctl/media-ctl.c | 12
utils/media-ctl
On Tue, 2018-04-17 at 11:32 +0200, Ibtsam Ul-Haq wrote:
> On Tue, Apr 17, 2018 at 10:34 AM, Philipp Zabel
> wrote:
> > Hi Ibtsam,
> >
> > On Tue, 2018-04-17 at 09:26 +0200, Ibtsam Ul-Haq wrote:
> > > On Mon, Apr 16, 2018 at 11:30 AM, Philipp Zabel
> > &g
Hi Ibtsam,
On Tue, 2018-04-17 at 09:26 +0200, Ibtsam Ul-Haq wrote:
> On Mon, Apr 16, 2018 at 11:30 AM, Philipp Zabel
> wrote:
> > On Mon, 2018-04-16 at 09:54 +0200, Ibtsam Ul-Haq wrote:
> > [...]
> > > This indeed looks the case. But then, is 'GR16' the Fo
h the help of Coccinelle.
>
> Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used")
> Signed-off-by: Gustavo A. R. Silva
> Signed-off-by: Fabio Estevam
> Acked-by: Philipp Zabel
> ---
> Changes since v2:
> - None
> Changes since v1:
&g
On Sun, 2018-04-15 at 18:39 -0700, Samuel Bobrowicz wrote:
> Can anyone verify if the OV5640 driver works with input clocks other
> than the typical 24MHz? The driver suggests anything from 6MHz-24MHz
> is acceptable, but I am running into issues while bringing up a module
> that uses a 12MHz oscil
On Mon, 2018-04-16 at 09:54 +0200, Ibtsam Ul-Haq wrote:
[...]
> This indeed looks the case. But then, is 'GR16' the FourCC for 'SGRBG16'?
Yes, see Documentation/media/uapi/v4l/pixfmt-srggb16.rst:
https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/pixfmt-srggb16.html
> To be honest, I had not
Hi Ibtsam,
On Thu, 2018-04-12 at 16:00 +0200, Ibtsam Ul-Haq wrote:
> Greetings everyone,
> I am using Linux 4.14.31 on an IMX6 platform, with an MT9P031 sensor
> attached to the ipu1_csi0 (parallel).
> My Gstreamer version is 1.14.0 and v4l-utils version is 1.14.2.
> The problem is that I am unabl
On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote:
> In VDIC direct mode, the VDIC applies combing filter during and
> doubles the framerate, that is, after the first two half-frames
> are received and the first frame is emitted by the VDIC, every
> subsequent half-frame is patched into the resu
Hi Tomasz,
On Tue, 2018-04-03 at 10:13 +, Tomasz Figa wrote:
> Hi Philipp,
>
> On Thu, Mar 29, 2018 at 2:12 AM Philipp Zabel
> wrote:
>
> > The driver helpfully resets the capture queue format and selection
> > rectangle whenever output format is changed. Th
Hi Ian,
On Fri, 2018-04-06 at 09:40 +0100, Ian Arkver wrote:
> > - ret = coda_try_fmt_vid_cap(file, priv, &f_cap);
> > - if (ret)
> > - return ret;
> > -
> > - q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
> > - r.left = 0;
> > - r.top = 0;
> > - r.width = q_data
Hi Ibtsam,
On Thu, 2018-04-05 at 16:24 +0200, Ibtsam Ul-Haq wrote:
> Hi Fabio,
>
> Thanks for your reply.
>
> On Thu, Apr 5, 2018 at 3:31 PM, Fabio Estevam wrote:
> > Hi Ibtsam,
> >
> > [Adding Steve and Philipp in case they can provide some suggestions]
> >
> > On Thu, Apr 5, 2018 at 9:30 AM
t;
>
> + /* Propagate the format from an active sink to source */
> + if ((pad->flags & MEDIA_PAD_FL_SINK) && (pad->index == vmux->active))
The flags check could be removed. It is not necessary since vmux->active
is never set to the source pad index.
> + *source_mbusformat = sdformat->format;
> +
> mutex_unlock(&vmux->lock);
>
> return 0;
Reviewed-by: Philipp Zabel
regards
Philipp
The driver helpfully resets the capture queue format and selection
rectangle whenever output format is changed. This only works while
the capture queue is not busy.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 28 +++-
1 file changed, 15
Hi Javier,
On Wed, 2018-03-14 at 15:35 +0100, Javier Martin wrote:
[...]
> The encoder is running on a different system with an older 4.1.0 kernel.
> Altough the firmware version in the code is 3.1.1 as well.
>
> Do you think I should try updating the system in the encoder to kernel
> 4.15 too
On Wed, 2018-03-14 at 13:05 +0100, Javier Martin wrote:
> Sorry everyone about my previous e-mail with all the HTML garbage. Here
> is the plain text answer instead.
>
> Hi Philipp,
>
> thanks for your answer.
>
> On 13/03/18 12:20, Philipp Zabel wrote:
> > Hi
Hi Javier,
On Mon, 2018-03-12 at 17:54 +0100, Javier Martin wrote:
> Hi,
> we have an i.MX6 Solo based board running the latest mainline kernel
> (4.15.3).
>
> As part of our development we were measuring the decoding performance of
> the i.MX6 coda chip.
>
> For that purpose we are feeding th
Hi Fabio,
On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote:
> On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote:
>
> > Oh, this only works for csi ports that have pinctrl in their csi port
> > node, like:
> >
> > &ipu1_csi0 {
> > pinctrl-
On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote:
> On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva
> wrote:
> > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe.
> > The proper pointer to be passed as argument is pinctrl
> > instead of priv->vdev.
> >
> > This issue was detected wi
gt;dev->of_node = pdata->of_node;
> pinctrl = devm_pinctrl_get_select_default(priv->dev);
> if (IS_ERR(pinctrl)) {
> - ret = PTR_ERR(priv->vdev);
> + ret = PTR_ERR(pinctrl);
> goto free;
> }
Thanks,
Acked-by: Philipp Zabel
regards
Philipp
Hi Sakari,
On Fri, 2018-02-23 at 14:47 +0200, Sakari Ailus wrote:
> Hi Philipp,
>
> On Fri, Feb 23, 2018 at 12:16:17PM +0100, Philipp Zabel wrote:
> > Hi Laurent,
> >
> > On Fri, 2018-02-23 at 12:05 +0200, Laurent Pinchart wrote:
> > > Hi Philipp,
> >
hat's missing there
> is an error handling code, in case it fails. Add it.
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Philipp Zabel
regards
Philipp
Hi Hans,
On Thu, 2018-02-15 at 15:43 +0100, Hans Verkuil wrote:
> Hi Philipp,
>
> Can you let me know if/when I can merge this? It looks good, so when the other
> patch is merged, then this can be merged as well.
Thank you for the reminder, the required patch is now merged into
v4.16-rc3, commit
On Tue, 2018-02-27 at 10:07 +0800, Yong Deng wrote:
> Add binding documentation for Allwinner V3s CSI.
>
> Acked-by: Maxime Ripard
> Acked-by: Sakari Ailus
> Reviewed-by: Rob Herring
> Signed-off-by: Yong Deng
> ---
> .../devicetree/bindings/media/sun6i-csi.txt| 59
>
Hi Laurent,
On Fri, 2018-02-23 at 12:05 +0200, Laurent Pinchart wrote:
> Hi Philipp,
>
> On Friday, 23 February 2018 11:56:52 EET Philipp Zabel wrote:
> > On Fri, 2018-02-23 at 11:29 +0200, Laurent Pinchart wrote:
> > > On Thursday, 22 February 2018 03:39:37 EE
Hi Laurent,
On Fri, 2018-02-23 at 11:29 +0200, Laurent Pinchart wrote:
> Hi Steve,
>
> Thank you for the patch.
>
> On Thursday, 22 February 2018 03:39:37 EET Steve Longerbeam wrote:
> > For some subdevices, a fwnode endpoint that has no connection to a remote
> > endpoint may not be an error. L
*fmt,
> bool ic_route);
> diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c
> b/drivers/staging/media/imx/imx6-mipi-csi2.c
> index 477d191..f74c610 100644
> --- a/drivers/staging/media/imx/imx6-mipi-csi2.c
> +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c
> @@ -531,6 +531,7 @@ static const struct v4l2_subdev_video_ops csi2_video_ops
> = {
> };
>
> static const struct v4l2_subdev_pad_ops csi2_pad_ops = {
> + .init_cfg = imx_media_init_cfg,
> .get_fmt = csi2_get_fmt,
> .set_fmt = csi2_set_fmt,
> };
Reviewed-by: Philipp Zabel
regards
Philipp
;format_mbus;
>
> - if (sdformat->which == V4L2_SUBDEV_FORMAT_TRY)
> - cfg->try_fmt = sdformat->format;
> - else
> - csi2->format_mbus = sdformat->format;
> + fmt = __csi2_get_fmt(csi2, cfg, sdformat->pad, sdformat->which);
> +
> + *fmt = sdformat->format;
> out:
> mutex_unlock(&csi2->lock);
> return ret;
Reviewed-by: Philipp Zabel
regards
Philipp
Hi Gustavo,
On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote:
> Hi all,
>
> I was just wondering about the status of this patch.
It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix
inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:
git://linuxtv.org/hver
On Fri, 2018-02-16 at 17:54 -0800, Steve Longerbeam wrote:
> Fix a few formatting errors.
>
> Signed-off-by: Steve Longerbeam
Reviewed-by: Philipp Zabel
regards
Philipp
If no imx_media_pixfmt is found for a given mbus format code,
we shouldn't crash. Return -EINVAL for any index.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-csi.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/imx/imx-media-csi.c
b/dr
On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote:
> On 02/07/2018 11:05 PM, Tim Harvey wrote:
> > On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote:
> > > On 02/07/18 09:22, Hans Verkuil wrote:
> > > > On 02/07/2018 12:29 AM, Tim Harvey wrote:
> > > > > Media Controller ioctls:
> > > > >
The IPUv3 code has 8-bit grayscale capture support.
Enable imx-media to use it.
Signed-off-by: Philipp Zabel
---
This patch depends on https://patchwork.kernel.org/patch/10178777/
to work, otherwise STREAMON will fail with -EINVAL.
---
drivers/staging/media/imx/imx-media-csi.c | 1 +
drivers
On Tue, 2018-01-16 at 19:23 +0200, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote:
> > Both uvc_start_streaming(), and uvc_stop_streaming() are called from
> > userspace context. As such, they do not need to save
appreciate if
> anyone can test this on a range of USB cameras.
FWIW,
Tested-by: Philipp Zabel
with a Lite-On internal Laptop Webcam, Logitech C910 (USB2 isoc),
Oculus Sensor (USB3 isoc), and Microsoft HoloLens Sensors (USB3 bulk).
regards
Philipp
Hi Florian,
On Fri, 2018-01-12 at 01:16 +0100, Florian Boor wrote:
> Hello all,
>
> I have a Phytec VM-009 camera based on MT9M131 connected to CSI0 of a I.MX6DL
> based board running mainline 4.13.0 + custom devicetree. Its using the
> parallel
> interface, 8 bit bus width on pins 12 to 19.
>
Hi Laurent,
On Fri, 2018-01-05 at 15:30 +0200, Laurent Pinchart wrote:
> Hi Philipp,
>
> Thank you for the patch.
>
> On Friday, 5 January 2018 00:51:29 EET Philipp Zabel wrote:
> > The Microsoft HoloLens Sensors device has two separate frame descriptors
> > with the
Windows Mixed Reality headset.
Signed-off-by: Philipp Zabel
---
Changes since v1 [1]:
- Break out of frame size loop if maxd == 0 in uvc_v4l2_set_streamparm.
- Moved d and tmp variables in uvc_v4l2_set_streamparm into loop,
renamed tmp variable to tmp_ival.
- Changed i loop variables to unsigned int
.
Lift the current maximum of 17 internal framebuffers to allow playback
of high profile streams that require more than 14 reference frames.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media
rong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-dt-bindings-coda-Add-compatible-for-CodaHx4-on-i-MX51/20171221-050217
> base: git://linuxtv.org/media_tree.git master
> config: x
xed, but, as both drivers
> are obsolete and in the process of cleanings, I opted to just
> keep the behavior, using an unsigned int inside those two
> drivers.
>
> Acked-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
For imx-media,
Acked-by: Philipp Zabel
thanks
Philipp
On Tue, 2017-12-19 at 12:42 +0100, Philipp Zabel wrote:
> Allow building this driver for other platforms under COMPILE_TEST.
>
> Suggested-by: Mauro Carvalho Chehab
> Signed-off-by: Philipp Zabel
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
> 1 file changed, 2 inse
Allow building this driver for other platforms under COMPILE_TEST.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/Kconfig
b/drivers/staging
Hi Neil,
On Tue, 2017-11-21 at 10:50 +0100, Neil Armstrong wrote:
> Hi,
>
> I'm trying to make the coda960 h.264 encoder work on an i.MX6q SoC with Linux
> 4.14 and the 3.1.1 firmware.
>
> # dmesg | grep coda
> [4.846574] coda 204.vpu: Direct firmware load for vpu_fw_imx6q.bin
> failed
Hi Mauro,
On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote:
> There is a mess with media bus flags: there are two sets of
> flags, one used by parallel and ITU-R BT.656 outputs,
> and another one for CSI2.
>
> Depending on the type, the same bit has different meanings.
>
> That's v
Nawrocki
> Signed-off-by: Mauro Carvalho Chehab
Thanks, this does improve readability in the drivers. For imx-media,
Acked-by: Philipp Zabel
regards
Philipp
> ---
> drivers/media/platform/am437x/am437x-vpfe.c| 6 +++---
> drivers/media/platform/atmel/atmel-isc.c |
On Mon, 2017-12-18 at 22:58 -0200, Fabio Estevam wrote:
> From: Fabio Estevam
>
> The 'irq' member of the vdoa_data struct is only used inside probe,
> so there is no need for it. Use a local variable 'ret' instead.
>
> Signed-off-by: Fabio Estevam
Review
Windows Mixed Reality headset.
Signed-off-by: Philipp Zabel
---
drivers/media/usb/uvc/uvc_v4l2.c | 66 ++--
1 file changed, 50 insertions(+), 16 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
index 3e7e283a44a8
Add support for the CodaHx4 VPU used on i.MX51.
Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding
h.264. MPEG-4 encoding is not enabled, it currently produces visual
artifacts.
Signed-off-by: Philipp Zabel
---
No changes since v1 [1].
[1] https://patchwork.linuxtv.org/patch
Add a compatible for the CodaHx4 VPU used on i.MX51.
Signed-off-by: Philipp Zabel
Reviewed-by: Rob Herring
---
Changes since v1 [1]:
- Fix list enumerators, suggested by Baruch
[1] https://patchwork.linuxtv.org/patch/45929/
---
Documentation/devicetree/bindings/media/coda.txt | 5 +++--
1
Hi Hans,
On Fri, 2017-12-15 at 15:22 +0100, Hans Verkuil wrote:
> Hi Philipp,
>
> On 13/12/17 15:09, Philipp Zabel wrote:
> > Add support for the CodaHx4 VPU used on i.MX51.
> >
> > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding
> > h.264. M
Hi Baruch,
On Wed, 2017-12-13 at 16:21 +0200, Baruch Siach wrote:
> Hi Philipp,
>
> On Wed, Dec 13, 2017 at 03:09:17PM +0100, Philipp Zabel wrote:
> > Add a compatible for the CodaHx4 VPU used on i.MX51.
> >
> > Signed-off-by: Philipp Zabel
> > ---
> >
Add a compatible for the CodaHx4 VPU used on i.MX51.
Signed-off-by: Philipp Zabel
---
Documentation/devicetree/bindings/media/coda.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/coda.txt
b/Documentation/devicetree/bindings/media/coda.txt
index
Add support for the CodaHx4 VPU used on i.MX51.
Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding
h.264. MPEG-4 encoding is not enabled, it currently produces visual
artifacts.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c| 45
signal EOS
prematurely, as soon as the already flagged buffer is dequeued.
Signed-off-by: Philipp Zabel
---
drivers/media/v4l2-core/videobuf2-v4l2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/v4l2-core/videobuf2-v4l2.c
b/drivers/media/v4l2-core/videobuf2-v4l2.c
index
The MPEG-4 decoder mvcol buffer was registered, but its size not added
to a frame buffer allocation. This could cause the decoder to write past
the end of the allocated buffer for large frame sizes.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 6 --
1 file
The mvcol buffer needs to be placed behind the chroma plane(s) when
decoding MPEG-4, same as for the h.264 decoder. Use the real offset
with the required rounding.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 16 +++-
1 file changed, 7 insertions(+), 9
We need internal frames to be rounded up to full macroblocks for MPEG-4
decoding as well.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-bit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/coda/coda-bit.c
b/drivers/media/platform/coda/coda-bit.c
the valid image rectange via G_SELECTION (V4L2_SEL_TGT_COMPOSE_DEFAULT),
but that would require all applications to handle the compose default
rectangle properly.
Signed-off-by: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions
From: Lucas Stach
The current driver implementation expects at least one buffer on
all queues to start streaming. Properly signal this to the vb2
core, to avoid confusion when streamon is racing with qbuf.
Signed-off-by: Lucas Stach
Signed-off-by: Philipp Zabel
---
drivers/media/platform
Hi Martin,
On Fri, 2017-11-17 at 15:30 +0100, Martin Kepplinger wrote:
> At this point the driver looks the currently decoded frame's index
> and compares is to VPU-specific state values. Directly before this
> if and else statements the indexes are read (index for decoded and
> for displayed fram
Hi Martin,
On Thu, 2017-11-09 at 23:14 +0100, Martin Kepplinger wrote:
> Hi Philipp,
>
> As I'm reading up on the coda driver a little, I can't seem to find the
> vendor's sources for the coda_regs.h definitions. Could you point me to
> them?
I don't know for sure what information Javier based t
501 - 600 of 1896 matches
Mail list logo
