Re: [PATCH] v4l: vsp1: Add support for capture and output in HSV formats

2016-09-07 Thread Ricardo Ribalda Delgado
ed-off-by: Ricardo Ribalda Delgado -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] v4l: vsp1: Add support for capture and output in HSV formats

2016-09-07 Thread Ricardo Ribalda Delgado
Hi Laurent, On Wed, Sep 7, 2016 at 9:09 AM, Laurent Pinchart wrote: >> >> Signed-off-by: Ricardo Ribalda Delgado > > Do you mean Acked-by ? Acked-by: Ricardo Ribalda Delgado Ups, my bad > > Feel free to take the patch in your tree to get it merged along with the

[GIT PULL] HSV formats

2016-09-07 Thread Ricardo Ribalda Delgado
1242d7e43b9053cd649ac5ec81aad8597e88ab46: [media] vsp1: Add support for capture and output in HSV formats (2016-09-07 10:41:52 +0200) Laurent Pinchart (1): [media] vsp1: Add support for capture and output in HSV formats Ricardo Ribalda Delgado (12

[GIT PULL] HSV formats v2

2016-10-17 Thread Ricardo Ribalda Delgado
: vsp1: Add support for capture and output in HSV formats Ricardo Ribalda Delgado (12): videodev2.h Add HSV formats Documentation: Add HSV format Documentation: Add Ricardo Ribalda vivid: Code refactor for color encoding vivid: Add support for HSV formats vivid

[RFP] Media Summit: Save/Restore controls from MTD

2018-09-14 Thread Ricardo Ribalda Delgado
Industrial/Scientific sensors usually come with very extensive calibration information such as: per column gain, list of dead/pixels, temperature sensor offset... etc We are saving that information on an flash device that is located by the sensor. I would like some minutes (15 max) to show you ho

[PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-20 Thread Ricardo Ribalda Delgado
Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c

ad5820: Sorry for the invalid v3

2018-09-20 Thread Ricardo Ribalda Delgado
HI Sorry, I did not check the produced files before sending them with git send-email. It has been a long day. Please ignore v3 and use v4. I will write 100 times: I will check my patches before sending them to the mailing list Cheers -- Ricardo Ribalda

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Ricardo Ribalda Delgado
HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Ricardo Ribalda Delgado
Hi Hans On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote: > > Hi, > > On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: > > Add support for 10 bit packet Bayer formats: > > -V4L2_PIX_FMT_SBGGR10P > > -V4L2_PIX_FMT_SGBRG10P > > -V4L2_PIX_FMT_SGRBG10P >

[PATCH v2] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Ricardo Ribalda Delgado
Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c

Power Management and lens-focus

2018-09-21 Thread Ricardo Ribalda Delgado
Hello I have started using the lens-focus property: ad5820: dac@0c { compatible = "adi,ad5820"; reg = <0x0c>; VANA-supply = <&pm8994_l23>; enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>; }; camera_rear@60 { lens-focus = <&ad5820>; }; I was testing my device using the following setup: qv4l2 grabb

[PATCH] media: smiapp: Remove unused loop

2018-09-25 Thread Ricardo Ribalda Delgado
The loop seemed to be made to calculate max, but max is not used in that function. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/smiapp/smiapp-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c

[PATCH v3 1/2] [media] imx214: device tree binding

2018-10-02 Thread Ricardo Ribalda Delgado
Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- Changelog from v2: Laurent Pinchart: -Spell checks -Remove frequency -Identation -Data lanes order Thanks! .../devicetree/bindings/media/i2c/imx214.txt | 52

Re: uvcvideo: IR camera lights only every second frame

2018-11-01 Thread Ricardo Ribalda Delgado
Hi On Tue, Oct 30, 2018 at 4:49 PM Kieran Bingham wrote: > > Hi Jiri, > > On 30/10/2018 14:36, Jiri Slaby wrote: > > Hi, > > > > I have a Dell Lattitude 7280 with two webcams. The standard one works > > fine (/dev/video0). The other one is an IR camera (/dev/video1). The > > camera proper works fi

[PATCH v8 2/3] [media] imx214: Add imx214 camera sensor driver

2018-10-05 Thread Ricardo Ribalda Delgado
Add a V4L2 sub-device driver for the Sony IMX214 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Jacopo Mondi --- Changelog from

[PATCH v8 1/3] [media] imx214: device tree binding

2018-10-05 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Delgado --- .../devicetree/bindings/media/i2c/imx214.txt | 53 +++ 1 file changed, 53 insertions(+) create mode

[PATCH v8 3/3] [media] imx214: Fix range for V4L2_CID_EXPOSURE

2018-10-05 Thread Ricardo Ribalda Delgado
-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 46a2fdfbd049..0b99123161b8 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c

[PATCH v9 1/3] [media] imx214: device tree binding

2018-10-05 Thread Ricardo Ribalda Delgado
Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Delgado --- Changelog from v8: Rob Herring: -rename file -Move address to reg -rename name on example -Patch author Sakari Ailus: -should->sh

Re: [PATCH v9 1/3] [media] imx214: device tree binding

2018-10-05 Thread Ricardo Ribalda Delgado
Hi Sakari On Sat, Oct 6, 2018 at 12:02 AM Sakari Ailus wrote: > > Hi Ricardo, > > On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote: > > Document bindings for imx214 camera sensor > > > > Cc: devicet...@vger.kernel.org > > Reviewed-by:

[PATCH v10 1/3] [media] imx214: device tree binding

2018-10-05 Thread Ricardo Ribalda Delgado
Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Delgado --- Changelog from v10: Sakari Ailus: -remove clock name .../bindings/media/i2c/sony,imx214.txt| 51 +++ 1 file changed, 51

[PATCH v11 1/3] [media] imx214: device tree binding

2018-10-05 Thread Ricardo Ribalda Delgado
Document bindings for imx214 camera sensor Cc: devicet...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Ricardo Ribalda Delgado --- Changelog from v10: Sakari Ailus: -Re-introduce clock-frequency property .../bindings/media/i2c/sony,imx214.txt| 53

[PATCH v11 2/3] [media] imx214: Add imx214 camera sensor driver

2018-10-05 Thread Ricardo Ribalda Delgado
Add a V4L2 sub-device driver for the Sony IMX214 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Jacopo Mondi --- Changelog from

[PATCH v11 3/3] [media] imx214: Fix range for V4L2_CID_EXPOSURE

2018-10-05 Thread Ricardo Ribalda Delgado
-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index fe01a13f13c5..284b9b49ebde 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c

[PATCH] media: doc-rst: Fix broken references

2018-11-09 Thread Ricardo Ribalda Delgado
Documentation and code was linking the old documentation at: http://v4l2spec.bytesex.org/spec/x1904.htm Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/v4l-drivers/sh_mobile_ceu_camera.rst | 2 +- drivers/media/platform/sh_vou.c | 2 +- 2 files changed, 2

Re: [PATCH] media: imx214: don't de-reference a NULL pointer

2018-12-12 Thread Ricardo Ribalda Delgado
h > > should also set it). > > > > Also, the entire logic there depends on having format != NULL, so > > just remove the bogus broken support for a null format. I believe it is a relic for when I did not use imx214_entity_init_cfg. Sorry about that. > > > > Signed-o

[PATCH] libv4lconvert: Fix support for compressed bayer formats

2019-02-05 Thread Ricardo Ribalda Delgado
10 bit packet Bayer format broke the support for the other compressed bayer formats. Due to the fallthrough of the compressed formats, 10b code will be executed for every 10b format. Fixes: c44b30096589 ("libv4l: Add support for BAYER10P format conversion") Signed-off-by: Ricardo Ribal

Re: [PATCH 2/2] libv4lconvert: add support for BAYER16

2019-02-27 Thread Ricardo Ribalda Delgado
Hi Daniel, On Wed, Feb 27, 2019 at 3:47 PM Daniel Gomez wrote: > > Add support for 16 bit Bayer formats: > -V4L2_PIX_FMT_SBGGR16 > -V4L2_PIX_FMT_SGBRG16 > -V4L2_PIX_FMT_SGRBG16 > -V4L2_PIX_FMT_SRGGB16 > > Tested using vivid included in linux v5.0-rc8. > > Signed-of

Re: [PATCH 1/2] libv4lconvert: add support for BAYER10

2019-02-27 Thread Ricardo Ribalda Delgado
Hi Daniel, Thanks for both patches On Wed, Feb 27, 2019 at 3:47 PM Daniel Gomez wrote: > > Add support for 10 bit Bayer formats: > -V4L2_PIX_FMT_SBGGR10 > -V4L2_PIX_FMT_SGBRG10 > -V4L2_PIX_FMT_SRGGB10 > > Previous BAYER10 format declared (V4L2_PIX_FMT_SGRBG10) now is grou

Re: [media-workshop] [ANN] Edinburgh Media Summit 2018 meeting report

2019-03-11 Thread Ricardo Ribalda Delgado
Hi On Mon, Mar 11, 2019 at 1:29 PM Laurent Pinchart wrote: > > Hello, > > On Mon, Mar 11, 2019 at 01:23:58PM +0200, Sakari Ailus wrote: > > On Wed, Dec 12, 2018 at 05:30:02AM -0200, Mauro Carvalho Chehab wrote: > > > Em Sun, 18 Nov 2018 00:45:02 +0200 Sakari Ailus escreveu: > > > > > > > Hello e

[PATCH] libv4lconvert: Add support for V4L2_PIX_FMT_NV12

2019-04-16 Thread Ricardo Ribalda Delgado
NV12 is a two-plane version YUV 4:2:0, where the U and V components are subsampled 2x2. Signed-off-by: Ricardo Ribalda Delgado --- The code has ben tested with qv4l2 and vivid. v4lconvert_nv12_to_yuv420 has not been tested!!, any suggestions for how to do it? Thanks! lib/libv4lconvert

Re: [PATCH] libv4lconvert: Add support for V4L2_PIX_FMT_NV12

2019-04-17 Thread Ricardo Ribalda Delgado
Hi Hans On Tue, Apr 16, 2019 at 6:00 PM Hans de Goede wrote: > > Hi Ricardo, > > On 16-04-19 14:02, Ricardo Ribalda Delgado wrote: > > NV12 is a two-plane version YUV 4:2:0, where the U and V components > > are subsampled 2x2. > > > > Signed-off-by: Ricardo R

[PATCH v2 2/2] libv4lconvert: Add support for V4L2_PIX_FMT_NV12

2019-04-17 Thread Ricardo Ribalda Delgado
NV12 is a two-plane version YUV 4:2:0, where the U and V components are subsampled 2x2. Signed-off-by: Ricardo Ribalda Delgado --- Changelog v2: - None The code has ben tested with qv4l2 and vivid. v4lconvert_nv12_to_yuv420 has not been tested!!, any suggestions for how to do it? lib

[PATCH v2 1/2] libv4lconvert: Port supported_src_formats to bit-ops

2019-04-17 Thread Ricardo Ribalda Delgado
We have passed the barrier of 64 supported formats, therefore a int64_t is not enough for holding the bitfield. Instead use bit-ops ala kernel. Signed-off-by: Ricardo Ribalda Delgado Suggested-by: Hans de Goede --- lib/libv4lconvert/libv4lconvert-priv.h | 3 +- lib/libv4lconvert

[PATCH v3 7/7] imx214: Use v4l2_ctrl_new_area helper

2019-08-23 Thread Ricardo Ribalda Delgado
Instead of creating manually the V4L2_CID_UNIT_CELL_SIZE control, lets use the helper. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v3 2/7] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Ricardo Ribalda Delgado
New control to pass to userspace the width/height of a pixel. Which is needed for calibration and lens selection. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/media

[PATCH v3 4/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Ricardo Ribalda Delgado
According to the product brief, the unit cell size is 1120 nanometers^2. https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 23 +++ 1 file changed, 23

[PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Ricardo Ribalda Delgado
Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, try to minimize it by adding a new helper. Suggested-by: Philipp Zabel Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 25 - include/media/v4l2-ctrls.h

[PATCH v3 6/7] Documentation: Document v4l2_ctrl_new area

2019-08-23 Thread Ricardo Ribalda Delgado
Helper for creating area controls. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/kapi/v4l2-controls.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Documentation/media/kapi/v4l2-controls.rst index ebe2a55908be

[PATCH v3 3/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA

2019-08-23 Thread Ricardo Ribalda Delgado
A struct v4l2_area containing the width and the height of a rectangular area. Signed-off-by: Ricardo Ribalda Delgado Suggested-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/media/uapi/v4l/vidioc

[PATCH v3 1/7] media: add V4L2_CID_UNIT_CELL_SIZE control

2019-08-23 Thread Ricardo Ribalda Delgado
This control returns the unit cell size in nanometres. The struct provides the width and the height in separated fields to take into consideration asymmetric pixels and/or hardware binning. This control is required for automatic calibration of sensors/cameras. Signed-off-by: Ricardo Ribalda

Re: [PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Ricardo Ribalda Delgado
On Fri, Aug 23, 2019 at 2:56 PM Philipp Zabel wrote: > > On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > > Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, > > try to minimize it by adding a new helper. > > > > Suggested-by:

[PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
Implement v4l2_ctrl_new_std_compound. This is just a discussion patch, do not merge as is, and be gentle with the author ;P. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 13 +++-- drivers/media/v4l2-core/v4l2-ctrls.c | 79

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
:19 PM Ricardo Ribalda Delgado wrote: > > Implement v4l2_ctrl_new_std_compound. This is just a discussion patch, > do not merge as is, and be gentle with the author ;P. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/i2c/imx214.c | 13 +++-- >

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-20 Thread Ricardo Ribalda Delgado
Hello Hans Thanks for your review! I will implement the changes and resend, just one comment. On Fri, Sep 20, 2019 at 12:07 PM Hans Verkuil wrote: > > On 9/17/19 6:21 PM, Ricardo Ribalda Delgado wrote: > > Hi Hans > > > > Is this something close to what you were havi

Re: [ANN] Media sessions in Lyon in October: codecs

2019-10-07 Thread Ricardo Ribalda Delgado
HI Nicolas Sorry to hijack the thread. Do you know if anyone at AMD is working on making a v4l driver for the encoder? Or they want to continue with their mesa approach? Converting a mesa-vappi to v4l is something doable by the mortals? Just changing the API or is a complete rewrite of the code?

Re: [ANN] Media sessions in Lyon in October: codecs

2019-10-07 Thread Ricardo Ribalda Delgado
HI Tomasz On Mon, Oct 7, 2019 at 11:43 AM Tomasz Figa wrote: > > Hi Ricardo, > > On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado > wrote: > > > > HI Nicolas > > > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > >

[PATCH 2/2] [media] vb2-memops: Use bool macros instead of 1

2016-03-03 Thread Ricardo Ribalda Delgado
This is the prototype of the called function: int get_vaddr_frames(unsigned long start, unsigned int nr_pfns, bool write, bool force, struct frame_vector *vec); Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/videobuf2-memops.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2] [media] vb2-memops: Fix over allocation of frame vectors

2016-03-03 Thread Ricardo Ribalda Delgado
] vb2: Provide helpers for mapping virtual addresses") Reported-by: Albert Antony Signed-off-by: Ricardo Ribalda Delgado --- Maybe we should cc stable. This error has not pop-out yet because userptr is usually called with memory on the heap and malloc usually overallocate. This error has been

[PATCH] media: vb2: Fix regression on poll() for RW mode

2016-04-21 Thread Ricardo Ribalda Delgado
a previous check. Reported-by: Dimitrios Katsaros Cc: Junghak Sung Cc: sta...@vger.kernel.org Fixes: 49d8ab9feaf2 ("media] media: videobuf2: Separate vb2_poll()") Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/videobuf2-core.c | 8 drivers/media/v4l2-core

[PATCH v2] media: vb2: Fix regression on poll() for RW mode

2016-04-25 Thread Ricardo Ribalda Delgado
enabled by a quirk flag, that avoids this check by other subsystems like DVB. Reported-by: Dimitrios Katsaros Cc: Junghak Sung Fixes: 49d8ab9feaf2 ("media] media: videobuf2: Separate vb2_poll()") Cc: sta...@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- v2: By Hans Ve

[PATCH v3] media: vb2: Fix regression on poll() for RW mode

2016-04-25 Thread Ricardo Ribalda Delgado
enabled by a quirk flag, that avoids this check by other subsystems like DVB. Reported-by: Dimitrios Katsaros Cc: Junghak Sung Fixes: 49d8ab9feaf2 ("media] media: videobuf2: Separate vb2_poll()") Cc: sta...@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- v3: By Ha

[PATCH v4] media: vb2: Fix regression on poll() for RW mode

2016-04-25 Thread Ricardo Ribalda Delgado
enabled by a quirk flag, that avoids this check by other subsystems like DVB. Reported-by: Dimitrios Katsaros Cc: Junghak Sung Fixes: 49d8ab9feaf2 ("media] media: videobuf2: Separate vb2_poll()") Cc: sta...@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- v4: Reported by Hans

[PATCH] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

2017-09-08 Thread Ricardo Ribalda Delgado
max_width and max_height are swap with step_width and step_height. Signed-off-by: Ricardo Ribalda Delgado --- Since that this bug has been here for ever. I do not know if we should notify stable or not I have also cut the lines to respect the 80 char limit drivers/media/v4l2-core/v4l2

[PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

2017-09-13 Thread Ricardo Ribalda Delgado
max_width and max_height are swap with step_width and step_height. Signed-off-by: Ricardo Ribalda Delgado --- Since that this bug has been here for ever. I do not know if we should notify stable or not I have also cut the lines to respect the 80 char limit v2: Suggested by Laurent Pinchart

[PATCH] media: v4l2-ctrl: Fix flags field on Control events

2017-10-17 Thread Ricardo Ribalda Delgado
that exports the internal flags to userspace. Reported-by: Dimitrios Katsaros Signed-off-by: Ricardo Ribalda Delgado --- Maybe we should cc stable on this one. drivers/media/v4l2-core/v4l2-ctrls.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2] media: v4l2-ctrl: Fix flags field on Control events

2017-10-17 Thread Ricardo Ribalda Delgado
that exports the internal flags to userspace. Reported-by: Dimitrios Katsaros Signed-off-by: Ricardo Ribalda Delgado --- Attention: Maybe we want to cc stable. v2: Suggested-by Hans Verkuil -Define struct v4l2_ctrl as const drivers/media/v4l2-core/v4l2-ctrls.c | 16 1 file

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

2017-09-05 Thread Ricardo Ribalda Delgado
Hi Hans On Fri, Sep 1, 2017 at 11:46 AM, Hans Verkuil wrote: > > > Also, if you plan to attend, please let me know. It is open for all, but it is > nice if we know beforehand who we can expect. > I plan to attend. I do not have any specific topic right now, but as the date gets closer I might ad

[PATCH] v4l2_compliance: -EINVAL is expected when ret is not 0

2013-07-30 Thread Ricardo Ribalda Delgado
Otherwise the driver can never return a register Signed-off-by: Ricardo Ribalda Delgado --- utils/v4l2-compliance/v4l2-test-debug.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/v4l2-compliance/v4l2-test-debug.cpp b/utils/v4l2-compliance/v4l2-test-debug.cpp

Question about v4l2-compliance: cap->readbuffers

2013-07-30 Thread Ricardo Ribalda Delgado
Hello I am developing a driver for a camera that supports read/write and mmap access to the buffers. When I am running the compliance test, I cannot pass it because of this test on v4l2-test-formats.cpp 904 if (!(node->caps & V4L2_CAP_READWRITE)) 905 fail_

Re: Question about v4l2-compliance: cap->readbuffers

2013-07-30 Thread Ricardo Ribalda Delgado
On Tue, Jul 30, 2013 at 3:45 PM, Hans Verkuil wrote: > On Tue 30 July 2013 15:12:57 Ricardo Ribalda Delgado wrote: >> Hello >> >> I am developing a driver for a camera that supports read/write and >> mmap access to the buffers. >> >> When I am running the

Re: Question about v4l2-compliance: cap->readbuffers

2013-07-30 Thread Ricardo Ribalda Delgado
. I could return -EINVAL, but I rather not show the controls to the user. What would be the proper way to do this? Thanks gain. On Tue, Jul 30, 2013 at 5:29 PM, Hans Verkuil wrote: > On Tue 30 July 2013 17:18:58 Ricardo Ribalda Delgado wrote: >> Thanks for the explanation Hans

Re: Question about v4l2-compliance: cap->readbuffers

2013-07-31 Thread Ricardo Ribalda Delgado
dont like that either, is this a false positive or I should behave differently?. Thank you again! On Tue, Jul 30, 2013 at 6:17 PM, Hans Verkuil wrote: > Hi Ricardo, > > On 07/30/2013 05:46 PM, Ricardo Ribalda Delgado wrote: >> Hello >> >> I have a camera that w

[PATCH] libv4lconvert: Support for Y16 pixel format

2013-08-01 Thread Ricardo Ribalda Delgado
This patch adds support for V4L2_PIX_FMT_Y16 format. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/libv4lconvert.c | 19 +++ lib/libv4lconvert/rgbyuv.c| 30 ++ 2 files changed, 49 insertions(+) diff --git a/lib

[PATCH 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-01 Thread Ricardo Ribalda Delgado
This patch adds support for V4L2_PIX_FMT_BGR32 and V4L2_PIX_FMT_BGR32 formats. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/libv4lconvert-priv.h |5 ++- lib/libv4lconvert/libv4lconvert.c | 58 +--- lib/libv4lconvert/rgbyuv.c | 66

[PATCH 0/2] Add support for V4L2_PIX_FMT_Y16, V4L2_PIX_FMT_RGB32 and V4L2_PIX_FMT_BGR32

2013-08-01 Thread Ricardo Ribalda Delgado
This patch adds support for 3 new formats. Ricardo Ribalda Delgado (2): libv4lconvert: Support for Y16 pixel format libv4lconvert: Support for RGB32 and BGR32 format lib/libv4lconvert/libv4lconvert-priv.h | 11 +++- lib/libv4lconvert/libv4lconvert.c | 77

[PATCH 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-01 Thread Ricardo Ribalda Delgado
This patch adds support for V4L2_PIX_FMT_Y16 format. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/libv4lconvert-priv.h |6 ++ lib/libv4lconvert/libv4lconvert.c | 19 +++ lib/libv4lconvert/rgbyuv.c | 30

Re: [PATCH 1/2] videobuf2-dma-sg: Allocate pages as contiguous as possible

2013-08-01 Thread Ricardo Ribalda Delgado
Hi Sakarius I think the whole point of the videobuf2 is sharing pages with the user space, so until vm_insert_page does not support high order pages we should split them. Unfortunately the mm is completely out of my topic, so I don't think that I could be very useful there. With my patch, in the

[PATCH v3 2/2] videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table

2013-08-02 Thread Ricardo Ribalda Delgado
Szyprowski Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/platform/marvell-ccic/mcam-core.c| 14 +-- drivers/media/v4l2-core/videobuf2-dma-sg.c | 103 drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 20 ++-- include/media/videobuf2-dma-sg.h

[PATCH v3 1/2] videobuf2-dma-sg: Allocate pages as contiguous as possible

2013-08-02 Thread Ricardo Ribalda Delgado
) that could not be handled by some DMA engines. This patch tries to minimize the number of DMA segments by using alloc_pages. In the worst case it will behave as before, but most of the times it will reduce the number of dma segments Acked-by: Marek Szyprowski Signed-off-by: Ricardo Ribalda

[PATCH 0/2] videobuf2-dma-sg: Contiguos memory allocation

2013-08-02 Thread Ricardo Ribalda Delgado
possible. v3: Constains feedback from Andre Heider Andre: Fix error handling (--pages) was wrongly fixed v2: Contains feedback from Andre Heider and Sylwester Nawrocki Andre: Fix error handling (--pages) Sylwester: Squash p3 and p4 into p2 Ricardo Ribalda Delgado (2): videobuf2-dma-sg

Re: [PATCH 1/2] videobuf2-dma-sg: Allocate pages as contiguous as possible

2013-08-02 Thread Ricardo Ribalda Delgado
he leak I mentioned in my first reply is > still there, see below. > > On Fri, Jul 19, 2013 at 07:02:33PM +0200, Ricardo Ribalda Delgado wrote: >> Most DMA engines have limitations regarding the number of DMA segments >> (sg-buffers) that they can handle. Videobuffers can easily

[PATCH v4 1/2] videobuf2-dma-sg: Allocate pages as contiguous as possible

2013-08-02 Thread Ricardo Ribalda Delgado
-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 60 +++- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/videobuf2-dma-sg.c index 16ae3dc..4999c48 100644

[PATCH v4 2/2] videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table

2013-08-02 Thread Ricardo Ribalda Delgado
Szyprowski Reviewed-by: Andre Heider Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/platform/marvell-ccic/mcam-core.c| 14 +-- drivers/media/v4l2-core/videobuf2-dma-sg.c | 103 drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 20 ++-- include/media

[PATCH v4 0/2] videobuf2-dma-sg: Contiguos memory allocation

2013-08-02 Thread Ricardo Ribalda Delgado
g (--pages) Sylwester: Squash p3 and p4 into p2 Ricardo Ribalda Delgado (2): videobuf2-dma-sg: Allocate pages as contiguous as possible videobuf2-dma-sg: Replace vb2_dma_sg_desc with sg_table drivers/media/platform/marvell-ccic/mcam-core.c| 14 +- drivers/media/v4l2-core/videobuf

Re: [PATCH 1/2] videobuf2-dma-sg: Allocate pages as contiguous as possible

2013-08-02 Thread Ricardo Ribalda Delgado
Thanks, I have just send a new version. Regards! On Fri, Aug 2, 2013 at 3:47 PM, Andre Heider wrote: > Hi Ricardo, > > I messed up one thing in my initial reply, sorry :( > > And two additional nitpicks, while we're at it. > > On Fri, Jul 19, 2013 at 07:02:33PM +020

[PATCH v2 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-02 Thread Ricardo Ribalda Delgado
This patch adds support for V4L2_PIX_FMT_Y16 format. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/libv4lconvert-priv.h |6 ++ lib/libv4lconvert/libv4lconvert.c | 19 +++ lib/libv4lconvert/rgbyuv.c | 30

[PATCH v2 0/2] Add support for V4L2_PIX_FMT_Y16, V4L2_PIX_FMT_RGB32 and V4L2_PIX_FMT_BGR32

2013-08-02 Thread Ricardo Ribalda Delgado
This patch adds support for 3 new formats. v2: Includes feedback from Gregor Jasny Gregor: Replaces rbg32 flag with bytesperpixes Ricardo Ribalda Delgado (2): libv4lconvert: Support for Y16 pixel format libv4lconvert: Support for RGB32 and BGR32 format lib/libv4lconvert/libv4lconvert

[PATCH v2 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-02 Thread Ricardo Ribalda Delgado
This patch adds support for V4L2_PIX_FMT_BGR32 and V4L2_PIX_FMT_BGR32 formats. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/libv4lconvert-priv.h |5 ++- lib/libv4lconvert/libv4lconvert.c | 58 lib/libv4lconvert/rgbyuv.c

Re: [PATCH 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-02 Thread Ricardo Ribalda Delgado
Hello Gregor Totally agree, I have just uploaded a new set. Thanks! On Sat, Aug 3, 2013 at 12:15 AM, Gregor Jasny wrote: > Hello, > > > On 8/1/13 3:04 PM, Ricardo Ribalda Delgado wrote: >> >> --- a/lib/libv4lconvert/libv4lconvert-priv.h >> +++ b/lib/libv

Re: [PATCH v2 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-04 Thread Ricardo Ribalda Delgado
Hello Gregor Thanks for your comments. I have replied inline. On Sat, Aug 3, 2013 at 6:42 PM, Gregor Jasny wrote: > On 8/3/13 12:42 AM, Ricardo Ribalda Delgado wrote: >> >> + case V4L2_PIX_FMT_RGB32: >> + switch (dest_pix_fmt) { >> +

Re: [PATCH v2 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-09 Thread Ricardo Ribalda Delgado
ping? On Sun, Aug 4, 2013 at 10:05 AM, Ricardo Ribalda Delgado wrote: > Hello Gregor > > Thanks for your comments. I have replied inline. > > On Sat, Aug 3, 2013 at 6:42 PM, Gregor Jasny wrote: >> On 8/3/13 12:42 AM, Ricardo Ribalda Delgado wrote: >>> >&

Re: [PATCH v2 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-09 Thread Ricardo Ribalda Delgado
ping? On Sat, Aug 3, 2013 at 12:42 AM, Ricardo Ribalda Delgado wrote: > This patch adds support for V4L2_PIX_FMT_Y16 format. > > Signed-off-by: Ricardo Ribalda Delgado > --- > lib/libv4lconvert/libv4lconvert-priv.h |6 ++ > lib/libv4lconvert/libv4lcon

Re: [PATCH v2 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-12 Thread Ricardo Ribalda Delgado
Hello Gregor I am using some cameras from qtec.com. In fact, I am developing the firmware for them :) qv4l2 has been very useful for testing. Thanks for your response. On Mon, Aug 12, 2013 at 9:39 PM, Gregor Jasny wrote: > On 8/9/13 6:04 PM, Ricardo Ribalda Delgado wrote: >>

[PATCH] v4l2-dev: Fix race condition on __video_register_device

2013-08-13 Thread Ricardo Ribalda Delgado
ter failed Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-dev.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c index 5923c5d..3f75f99 100644 --- a/drivers/media/v4l2-core/

[PATCH] videobuf2: Fix vb2_write prototype

2013-08-28 Thread Ricardo Ribalda Delgado
/qtec_xform.c:817:2: warning: (near initialization for ‘qtec_xform_v4l_fops.write’) [enabled by default] Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/videobuf2-core.c |7 --- include/media/videobuf2-core.h |4 ++-- 2 files changed, 6

RFC> multi-crop (was: Multiple Rectangle cropping)

2013-09-05 Thread Ricardo Ribalda Delgado
Hello I am working porting a industrial camera driver to v4l. So far I have been able to describe most of the old functionality with v4l equivalents. The only thing that I am missing is multi cropping. The sensor (both a cmosis and a ccd chips) supports skipping lines from up to 8 regions. This

Re: RFC> multi-crop (was: Multiple Rectangle cropping)

2013-09-06 Thread Ricardo Ribalda Delgado
this? Of course the names should be better chosen, this is just a declaration of intentions. Cheers! On Thu, Sep 5, 2013 at 11:44 PM, Sylwester Nawrocki wrote: > On 09/05/2013 11:10 PM, Ricardo Ribalda Delgado wrote: >> >> Hello > > > Hi, > > >> I am workin

videobuf2: V4L2_BUF_TYPE_VIDEO_CAPTURE and V4L2_BUF_TYPE_VIDEO_OUTPUT at the same time?

2013-09-10 Thread Ricardo Ribalda Delgado
Hello! I am writing the driver for a device that can work as an input and as output at the same time. It is used for debugging of the video pipeline. Is it possible to have a vb2 queue that supports capture and out at the same time? After a fast look on the code it seems that the code flow is di

Re: RFC> multi-crop

2013-09-11 Thread Ricardo Ribalda Delgado
Hello Thanks for your comments On Wed, Sep 11, 2013 at 12:05 AM, Sylwester Nawrocki wrote: > Hi All, > > On 09/10/2013 11:41 PM, Sakari Ailus wrote: >> >> Hi Ricardo, >> >> On Fri, Sep 06, 2013 at 10:30:18AM +0200, Ricardo Ribalda Delgado wrote: >>>

Re: RFC> multi-crop (was: Multiple Rectangle cropping)

2013-09-11 Thread Ricardo Ribalda Delgado
Hello Sakari On Wed, Sep 11, 2013 at 12:35 AM, Sakari Ailus wrote: > Hi Ricardo, > > On Fri, Sep 06, 2013 at 10:30:18AM +0200, Ricardo Ribalda Delgado wrote: >> Any comment on this? Of course the names should be better chosen, this >> is just a declaration of intentions. &g

[PATCH] RFC: Support for multiple selections

2013-09-11 Thread Ricardo Ribalda Delgado
needed in cases where the user has to change multiple selections at the same time to get a valid combination. On devices where the control V4L2_CID_SELECTION_BITMASK does not exist, the id field is ignored Signed-off-by: Ricardo Ribalda Delgado --- Documentation/DocBook/media/v4l/controls.xml

Re: [PATCH] RFC: Support for multiple selections

2013-09-11 Thread Ricardo Ribalda Delgado
Hi Hans Thanks for your feedback On Wed, Sep 11, 2013 at 11:04 AM, Hans Verkuil wrote: > Hi Ricardo, > > On 09/11/2013 10:30 AM, Ricardo Ribalda Delgado wrote: >> A new id field is added to the struct selection. On devices that >> supports multiple sections this id

Re: [PATCH] RFC: Support for multiple selections

2013-09-11 Thread Ricardo Ribalda Delgado
Hello Hans On Wed, Sep 11, 2013 at 12:49 PM, Hans Verkuil wrote: > Hi Ricardo, > > On 09/11/2013 11:34 AM, Ricardo Ribalda Delgado wrote: >> Hi Hans >> >> Thanks for your feedback >> >> On Wed, Sep 11, 2013 at 11:04 AM, Hans Verkuil wrote: >>> Hi

[PATCH] RFCv2: Support for multiple selections

2013-09-12 Thread Ricardo Ribalda Delgado
the pr array is used instead of the r field. A new structure v4l2_ext_rect has been defined, containing 4 reserved fields for future improvements, as suggested by Hans. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ioctl.c | 54

Re: [PATCH] RFC: Support for multiple selections

2013-09-12 Thread Ricardo Ribalda Delgado
Hi Hans On Wed, Sep 11, 2013 at 3:02 PM, Hans Verkuil wrote: > Hi Ricardo, > > On 09/11/2013 02:13 PM, Ricardo Ribalda Delgado wrote: >> Hello Hans >> >> On Wed, Sep 11, 2013 at 12:49 PM, Hans Verkuil wrote: >>> Hi Ricardo, >>> >>> On 09/11

[PATCH] v4l2: Support for multiple selections

2013-09-16 Thread Ricardo Ribalda Delgado
item to a flatten struct. This function is used in all the old drivers that dont support multiple selections. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/platform/exynos-gsc/gsc-m2m.c | 6 +++ drivers/media/platform/exynos4-is/fimc-capture.c | 6 +++ drivers/media/platform

Patchwork is down or only for me?

2013-09-16 Thread Ricardo Ribalda Delgado
Hello I have sent a patch and it does not appear on patchwork, it is also slower than usual. Also a patch from David Jedelsky is not there. Regards! -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.or

Re: Patchwork is down or only for me?

2013-09-16 Thread Ricardo Ribalda Delgado
I was looking to this one: https://patchwork.linuxtv.org/project/linux-media/list/ Where the latest patch is https://patchwork.linuxtv.org/patch/20090/ On Mon, Sep 16, 2013 at 4:58 PM, Antti Palosaari wrote: > On 09/16/2013 05:48 PM, Ricardo Ribalda Delgado wrote: >> >> Hello &g

Re: Patchwork is down or only for me?

2013-09-16 Thread Ricardo Ribalda Delgado
Yes, it is working fine. Thanks! On Mon, Sep 16, 2013 at 9:04 PM, Johannes Stezenbach wrote: > On Mon, Sep 16, 2013 at 05:01:36PM +0200, Ricardo Ribalda Delgado wrote: >> I was looking to this one: >> https://patchwork.linuxtv.org/project/linux-media/list/ >> >> Wher

Re: [PATCH] v4l2: Support for multiple selections

2013-09-30 Thread Ricardo Ribalda Delgado
I'm ignoring the platform > driver patches for now until the core support is correct. > > On 09/16/2013 02:54 PM, Ricardo Ribalda Delgado wrote: >> From: Ricardo Ribalda >> >> Extend v4l2 selection API to support multiple selection areas, this way >> sensors that su

  1   2   3   4   5   >