Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-19 Thread Trent Piepho
On Thu, 19 Mar 2009, Trent Piepho wrote: > Since the driver often needs to use a logarithm from dvb-math to find SNR, > you have code like this in the driver (from lgdt3305.c): > /* report SNR in dB * 10 */ > *snr = (state->snr / ((1 << 24) / 10)); > >

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-19 Thread Trent Piepho
On Thu, 19 Mar 2009, Mauro Carvalho Chehab wrote: > that we should discuss about it for some time, comparing each alternatives we > have, focused on SNR only. Later, use can use the same approach for the > other quality measurements on DVB. > > In order to start such discussions, I'm summarizing bo

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-19 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: > On Sunday 15 March 2009 17:39:11 Trent Piepho wrote: > > Because there are patches that touch both the media tree and outside it? > > I don't buy it. Even for sub-systems that only use full git trees, you > > almost neve

Re: [PATCH] gspca: add missing .type field check in VIDIOC_G_PARM

2009-03-19 Thread Trent Piepho
On Thu, 19 Mar 2009, [ISO-8859-1] N?meth M?rton wrote: > David Ellingsworth wrote: > > 2009/3/18 N?meth M?rton : > >> From: M?rton N?meth > >> > >> The gspca webcam driver does not check the .type field of struct > >> v4l2_streamparm. > >> This field is an input parameter for the driver according

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-18 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: > On Sunday 15 March 2009 18:28:42 Trent Piepho wrote: > > On Sun, 15 Mar 2009, Hans Verkuil wrote: > > > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote: > > > > On Sun, 15 Mar 2009, Hans Verkuil wrote: > > > &g

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-17 Thread Trent Piepho
On Tue, 17 Mar 2009, Jean Delvare wrote: > On Mon, 16 Mar 2009 15:47:17 -0700 (PDT), Trent Piepho wrote: > > On Mon, 16 Mar 2009, Jean Delvare wrote: > > > You are unfair. The pull request came with a short log of all the > > > changes. > > > > "shor

Re: Improve DKMS build of v4l-dvb?

2009-03-17 Thread Trent Piepho
On Tue, 17 Mar 2009, Alain Kalker wrote: > Op vrijdag 13-03-2009 om 02:12 uur [tijdzone -0700], schreef Trent > Piepho: > > On Mon, 9 Mar 2009, Alain Kalker wrote: > > > Firstly: generating a .config with just one config variable for the > > > requested driver set to

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Jean Delvare wrote: > On Mon, 16 Mar 2009 12:43:33 -0700 (PDT), Trent Piepho wrote: > > On Mon, 16 Mar 2009, Jean Delvare wrote: > > > Come on, just look at ir-kbd-i2c and tvaudio again, see how great are > > > these drivers which have been "de

Re: [PATCH v2 3/4] pxa_camera: Redesign DMA handling

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > What is QIF? Do you mean Quick Capture Interface - QCI? I also see CIF > > used in the datasheet, probably, for "Capture InterFace," but I don't see > > QIF anywhere. Also, please explain the first time you use the > >

Re: [PATCH v2 1/4] pxa_camera: Enforce YUV422P frame sizes to be 16 multiples

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Robert Jarzmik wrote: > >> + if (xlate->host_fmt->fourcc == V4L2_PIX_FMT_YUV422P) { > >> + if (!IS_ALIGNED(pix->width * pix->height, PIX_YUV422P_ALIGN)) > >> + pix->height = ALIGN(pix->height, PIX_YUV422P_ALIGN / 2); > >> + if (!IS_ALIGNED(pi

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Jean Delvare wrote: > Come on, just look at ir-kbd-i2c and tvaudio again, see how great are > these drivers which have been "designed" on top of the legacy i2c > binding model. Look at the bttv mess. Look at the zoran driver > conversion done by Hans a few weeks ago, which kill

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-16 Thread Trent Piepho
On Mon, 16 Mar 2009, Hans Verkuil wrote: > >> +++ b/linux/drivers/media/video/bt8xx/bttvp.h Sun Mar 15 13:07:15 2009 > >> +0100 > >> @@ -331,6 +331,7 @@ struct bttv { > >>unsigned int tuner_type; /* tuner chip type */ > >>unsigned int tda9887_conf; > >>unsigned int svhs, dig; > >>

Re: [PULL] http://linuxtv.org/hg/~dheitmueller/hvr950q-analog2/

2009-03-16 Thread Trent Piepho
On Sun, 15 Mar 2009, Devin Heitmueller wrote: > au0828: remove memset calls in v4l2 routines. "The userland callers are responsible for clearing the output buffers, so remove the unneeded memset calls." A driver should not assume that _userspace_ has cleared the buffers. In some cases userspace

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Andy Walls wrote: > On Sun, 2009-03-15 at 18:12 +0100, Jean Delvare wrote: > > > This is the typical multifunction device problem. It isn't specifically > > related to I2C, > > But the specific problem that Hans' brings up is precisely a Linux > kernel I2C subsystem *software*

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Andy Walls wrote: > On Sun, 2009-03-15 at 10:28 -0700, Trent Piepho wrote: > > > Why are the i2c addresses from various i2c chips moved into the bttv > > driver? Doesn't it make more sense that the addresses for chip X should be > > in the driv

Re: bttv, tvaudio and ir-kbd-i2c probing conflict

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Jean Delvare wrote: > On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote: > This is the typical multifunction device problem. It isn't specifically > related to I2C, the exact same problem happens for other devices, for > example a PCI south bridge including hardware monito

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: > On Sunday 15 March 2009 17:04:43 Trent Piepho wrote: > > On Sun, 15 Mar 2009, Hans Verkuil wrote: > > > Hi Mauro, > > > > > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree? > > > > It would be a lo

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-15 Thread Trent Piepho
On Sat, 7 Mar 2009, Guennadi Liakhovetski wrote: > On Fri, 6 Mar 2009, Trent Piepho wrote: > > On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > > > On Thu, 5 Mar 2009, Trent Piepho wrote: > > > > ALSA used a partial tree, but their system was much worse than >

Re: REVIEW: bttv conversion to v4l2_subdev

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Hans Verkuil wrote: > Hi Mauro, > > Can you review my ~hverkuil/v4l-dvb-bttv2 tree? It would be a lot easier if you would provide patch descriptions. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] LED control

2009-03-15 Thread Trent Piepho
On Sun, 15 Mar 2009, Jean-Francois Moine wrote: > On Sat, 14 Mar 2009 13:16:11 -0700 (PDT) > Trent Piepho wrote: > > > There is already a sysfs led interface, you could just have the driver > > export the leds to the led subsystem and use that. > > Yes, but: >

Re: [PATCH] LED control

2009-03-14 Thread Trent Piepho
On Sat, 14 Mar 2009, Mauro Carvalho Chehab wrote: > On Sat, 14 Mar 2009 12:59:23 +0100 > Jean-Francois Moine wrote: > > > + V4L2_CID_LEDS > > + integer > > + Switch on or off the LEDs or illuminators of the device. > > +In the control value, each LED may be coded in one bit (0: o

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-13 Thread Trent Piepho
On Fri, 13 Mar 2009, Andy Walls wrote: > On Fri, 2009-03-13 at 10:27 -0400, Devin Heitmueller wrote: > > On Fri, Mar 13, 2009 at 12:19 AM, Ang Way Chuang wrote: > > > > > > Yes, please :) > > > > Yeah, Michael Krufky and I were discussing it in more detail yesterday > > on the #linuxtv ML. Essent

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-13 Thread Trent Piepho
On Fri, 13 Mar 2009, Devin Heitmueller wrote: > On Fri, Mar 13, 2009 at 5:11 PM, Trent Piepho wrote: > > I like 8.8 fixed point a lot better. ?It gives more precision. ?The range > > is more in line with that the range of real SNRs are. ?Computers are > > binary, so the m

Re: The right way to interpret the content of SNR, signal strength and BER from HVR 4000 Lite

2009-03-13 Thread Trent Piepho
On Fri, 13 Mar 2009, Devin Heitmueller wrote: > On Fri, Mar 13, 2009 at 12:19 AM, Ang Way Chuang wrote: > > > > Yes, please :) > > Yeah, Michael Krufky and I were discussing it in more detail yesterday > on the #linuxtv ML. Essentially there are a few issues: > > 1. Getting everyone to agree on

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-13 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following changeset: 01/01: build: have make_kconfig.pl ignore comments http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=9debb0a2ec70 make_kconfig.pl | 13 + 1 files changed, 9 insertions(+), 4 deletions(-)

Re: Improve DKMS build of v4l-dvb?

2009-03-13 Thread Trent Piepho
On Mon, 9 Mar 2009, Alain Kalker wrote: > Martin has an older version of the drivers packaged for building with > DKMS on Ubuntu in his PPA[5], but it currently has some disadvantages: > > A. It builds all available drivers, no matter which hardware is actually > installed in the system. This takes

Re: Kconfig changes in /hg/v4l-dvb caused dvb_usb_cxusb to stop building (fwd)

2009-03-13 Thread Trent Piepho
On Mon, 9 Mar 2009, Mauro Carvalho Chehab wrote: > Btw, if you look at DVB_FE_CUSTOMISE help, it is recommended tho unselect it, > if you're not sure what to do. > > > > > Anyways, here's what I get: > > > > $ grep "^CONFIG" .config > > [everything is 'm'] > > CONFIG_DVB_VES1820=m > > CONFIG

Re: [PATCH] cx88: Add IR support to pcHDTV HD3000 & HD5500

2009-03-13 Thread Trent Piepho
On Thu, 5 Mar 2009, Erik S. Beiser wrote: > Thanks for your comments, Trent. My responses below: > > Trent Piepho wrote: > > On Sat, 28 Feb 2009, Erik S. Beiser wrote: > > > >> cx88: Add IR support to pcHDTV HD3000 & HD5500 > >> > >> Signed-

Re: identifying camera sensor

2009-03-13 Thread Trent Piepho
On Thu, 5 Mar 2009, Hans Verkuil wrote: > Reserved bits are there for a reason. If a particular bit of information > it a perfect match with for that API, then it seems utterly pointless to > me to decide not to use them 'just because we might run out in the > future'. It would be one thing if the

Re: [PATCH] Add support for ProVideo PV-183 to bttv

2009-03-12 Thread Trent Piepho
On Fri, 13 Mar 2009, Alan McIvor wrote: > + > +{ 0x15401830, BTTV_BOARD_PV183, "Provideo PV183-1" }, > +{ 0x15401831, BTTV_BOARD_PV183, "Provideo PV183-2" }, > +{ 0x15401832, BTTV_BOARD_PV183, "Provideo PV183-3" }, > +{ 0x15401833, BTTV_BOARD_

[pull] http://linuxtv.org/hg/~tap/v4l-dvb-zoran

2009-03-10 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb-zoran for the following 6 changesets: 01/06: build: Clean up FM801-TEA575x Kconfig http://linuxtv.org/hg/~tap/v4l-dvb-zoran?cmd=changeset;node=a9792eb3e828 02/06: zoran: Unify buffer descriptors http://linuxtv.org/hg/~tap/v4l-dvb-zoran?

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Andy Walls wrote: > On Mon, 2009-03-09 at 08:16 +0100, Hans Verkuil wrote: > > On Monday 09 March 2009 02:07:33 Trent Piepho wrote: > > > > > > Switching on the whole ioctl makes the switch statement a lot less > > > efficient. I'd r

Re: [linuxtv-commits] [hg:v4l-dvb] v4l2-ioctl: get rid of video_decoder.h

2009-03-10 Thread Trent Piepho
On Tue, 10 Mar 2009, Hans Verkuil wrote: > > On Tue, 10 Mar 2009 08:31:32 +0100 > > I suspect that it shouldn't hard to remove the few V4L1 bits from > > zoran_driver, after all > > the conversions made. Yet, there are some Zoran specific ioctls that use > > this. > > We should probably discontinue

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-10 Thread Trent Piepho
On Tue, 10 Mar 2009, Hans Verkuil wrote: > On Tuesday 10 March 2009 00:50:41 Mauro Carvalho Chehab wrote: > > On Mon, 9 Mar 2009 08:16:53 +0100 > > Hans Verkuil wrote: > > > On Monday 09 March 2009 02:07:33 Trent Piepho wrote: > > > > On Sun, 8 Mar 2009, Hans V

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-notify

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Mauro Carvalho Chehab wrote: > On Mon, 9 Mar 2009 08:45:42 +0100 > Hans Verkuil wrote: > > > On Monday 09 March 2009 02:20:19 Trent Piepho wrote: > > > On Sun, 8 Mar 2009, Hans Verkuil wrote: > > > > - zoran/bt819: use new notify functional

Re: V4L2 spec

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Hans Verkuil wrote: > On Monday 09 March 2009 12:08:39 Mauro Carvalho Chehab wrote: > > On Fri, 6 Mar 2009, wk wrote: > > > Hans Verkuil wrote: > > >> Hi Mauro, > > >> > > >> I noticed that there is an ancient V4L2 spec in our tree in the > > >> v4l/API directory. Is that spec

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-10 Thread Trent Piepho
On Mon, 9 Mar 2009, Robert Jarzmik wrote: > > Ok, this one will change I presume - new alignment calculations and > > line-breaking. In fact, if you adjust width and height earlier in set_fmt, > > maybe you'll just remove any rounding here completely. > Helas, not fully. > The problem is with passt

Re: [PULL] http://linuxtv.org/hg/~mkrufky/sms1xxx-gpio

2009-03-09 Thread Trent Piepho
On Mon, 9 Mar 2009, Mauro Carvalho Chehab wrote: > in kernel. That means that we shouldn't add a changeset that we know that it > will break a device, except if we are committing, in the same patch series, > another patch fixing it. I wouldn't even do that. If you know the patch has a problem wit

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-notify

2009-03-08 Thread Trent Piepho
On Sun, 8 Mar 2009, Hans Verkuil wrote: > > - zoran/bt819: use new notify functionality. You put compat.h in the wrong spot in this patch. It goes before any header file that are in v4l-dvb, but you've moved it to after v4l2-common. -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-08 Thread Trent Piepho
On Sun, 8 Mar 2009, Hans Verkuil wrote: > The last one fixes an ivtv regression caused by this change: > > changeset: 10811:0a0eba8e64d5 > user: Trent Piepho > date:Tue Mar 03 20:21:02 2009 -0800 > summary: videodev: only copy needed part of RW ioctl'

Re: [PATCH] zoran: Drop the lock_norm module parameter

2009-03-07 Thread Trent Piepho
On Sat, 7 Mar 2009, Jean Delvare wrote: > The lock_norm module parameter doesn't look terribly useful. If you > don't want to change the norm, just don't change it. As a matter of > fact, no other v4l driver has such a parameter. > > Signed-off-by: Jean Delvare

Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-netup

2009-03-06 Thread Trent Piepho
On Sat, 7 Mar 2009, Igor M. Liplianin wrote: > 01/01: stv0900: delete debug messages not related to stv0900 tuning algorythm > http://udev.netup.ru/hg/v4l-dvb-netup?cmd=changeset;node=c79e4df8a4c2 BTW, This will conflict with the changeset Hans just posted that fixes the casts in those same dprint

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-06 Thread Trent Piepho
On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > On Thu, 5 Mar 2009, Trent Piepho wrote: > > ALSA used a partial tree, but their system was much worse than v4l-dvb's. > > I think the reason more systems don't do it is that setting up the build > > system we have

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-06 Thread Trent Piepho
On Fri, 6 Mar 2009, Hans Verkuil wrote: > On Friday 06 March 2009 22:36:57 Trent Piepho wrote: > > On Fri, 6 Mar 2009, Hans Verkuil wrote: > > > - zl10036: fix compile warning on kernel 2.6.23. > > > - bttv: fix compile warnings for kernels < 2.6.20. > > &g

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-06 Thread Trent Piepho
On Fri, 6 Mar 2009, Guennadi Liakhovetski wrote: > On Fri, 6 Mar 2009, robert.jarz...@free.fr wrote: > > > > This implies that even if DMA is 8 bytes aligned, width x height should > > be a multiple of 16, not 8 as I stated in the first git comment. So that > > would align : > > - width on 4 bytes

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-03-06 Thread Trent Piepho
On Fri, 6 Mar 2009, Hans Verkuil wrote: > - zl10036: fix compile warning on kernel 2.6.23. > - bttv: fix compile warnings for kernels < 2.6.20. > - cx88-alsa: fix compile warning for kernels <=2.6.20. Do we need to fix warnings for old kernels? If it's an easy fix that can go in compat.h that's o

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-06 Thread Trent Piepho
On Fri, 6 Mar 2009 robert.jarz...@free.fr wrote: > - Mail Original - > De: "Guennadi Liakhovetski" > ??: "Trent Piepho" > Cc: "Robert Jarzmik" , m...@compulab.co.il, "Linux > Media Mailing List" > Envoy??: Jeudi 5 Mars 200

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-06 Thread Trent Piepho
On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > On Thu, 5 Mar 2009, Trent Piepho wrote: > > On Thu, 5 Mar 2009, Robert Jarzmik wrote: > > > Guennadi Liakhovetski writes: > > > > This is not a review yet - just an explanation why I was suggesting to > > &

Re: [PATCH 1/4] pxa_camera: Remove YUV planar formats hole

2009-03-05 Thread Trent Piepho
On Thu, 5 Mar 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > This is not a review yet - just an explanation why I was suggesting to > > adjust height and width - you say yourself, that YUV422P (I think, this is > > wat you meant, not just YUV422) requires planes to immediately f

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-05 Thread Trent Piepho
On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > On Thu, 5 Mar 2009, Trent Piepho wrote: > > On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > > > On Wed, 4 Mar 2009, Mauro Carvalho Chehab wrote: > > > > Beside the fact that we don't need to strip suppo

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-05 Thread Trent Piepho
On Thu, 5 Mar 2009, Guennadi Liakhovetski wrote: > On Wed, 4 Mar 2009, Mauro Carvalho Chehab wrote: > > Beside the fact that we don't need to strip support for legacy kernels, the > > advantage of using this method is that we can evolute to a new development > > model. As several developers already

[PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-05 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 2 changesets: 01/02: compat: Add INIT_DELAYED_WORK http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=f6382daee1df 02/02: zoran: Change first argument to zoran_v4l2_buffer_status http://linuxtv.org/hg/~tap/v4l-dvb?c

Re: [PATCH] cx88: Prevent general protection fault on rmmod

2009-03-05 Thread Trent Piepho
On Thu, 5 Mar 2009, Jean Delvare wrote: > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20) > struct work_struct work; > struct timer_list timer; > +#else > + struct delayed_work work; > +#endif You don't need this compat stuff. compat.h will take are of it for you. Just code it li

Re: identifying camera sensor

2009-03-05 Thread Trent Piepho
On Thu, 5 Mar 2009, Hans Verkuil wrote: > > ENUMINPUT is probably a better solution: you can say something like > "Camera 1 (sensor1)", "Camera 2 (sensor2)". > > It remains a bit of a hack, though. Maybe use some of the reserved bits in v4l2_input to show not only the sensor orientation, but also

Re: identifying camera sensor

2009-03-05 Thread Trent Piepho
y.card: `omap3/smia-sensor-12-1234-5678//' > > > where 12 would be manufacturer_id, 1234 model_id, and > > > 5678 revision_number? > > > > Yuck :-) > > Agreed :) > > Also, if there are many slaves, the length of the capability.card > field i

Re: General protection fault on rmmod cx8800

2009-03-04 Thread Trent Piepho
On Mon, 2 Mar 2009, Andy Walls wrote: > On Mon, 2009-03-02 at 17:03 +0100, Jean Delvare wrote: > > > if (ir->polling) { > > > del_timer_sync(&ir->timer); <--- Wrong order? > > > flush_scheduled_work(); <--- Wrong order? > > > } > > > } > > > >

Re: [PATCH 3/5] OV3640: Add driver

2009-03-04 Thread Trent Piepho
On Tue, 3 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: > + { > + /* Note: V4L2 defines RGB565 as: > +* > +* Byte 0Byte 1 > +* g2 g1 g0 r4 r3 r2 r1 r0 b4 b3 b2 b1 b0 g5 g4 g3 > +

RE: [REVIEW PATCH 11/14] OMAP34XXCAM: Add driver

2009-03-04 Thread Trent Piepho
On Wed, 4 Mar 2009, Aguirre Rodriguez, Sergio Alberto wrote: > As what I understand, we have 2 possible situations for multiple opens here: > > Situation 1 > - Instance1: Select sensor 1, and Do queue/dequeue of buffers. > - Instance2: If sensor 1 is currently selected, Begin loop requesting > i

RE: [Camera] identifying camera sensor

2009-03-04 Thread Trent Piepho
On Wed, 4 Mar 2009, ribrishimov wrote: > I am planning to export the chip identification information > to user space using VIDIOC_DBG_G_CHIP_IDENT. > Here's a sketch: > #define V4L2_IDENT_SMIA_BASE(0x53 << 24) > then in sensor driver's VIDIOC_DBG_G_CHIP_IDENT ioctl handler: > struct v4l

Re: [PATCH] cx88: Add IR support to pcHDTV HD3000 & HD5500

2009-03-04 Thread Trent Piepho
On Sat, 28 Feb 2009, Erik S. Beiser wrote: > cx88: Add IR support to pcHDTV HD3000 & HD5500 > > Signed-off-by: Erik S. Beiser > > --- > > Idea originally from http://www.pchdtv.com/forum/viewtopic.php?t=1529 > I made it into this small patch and added the HD3000 support also, which I > have I'v

Re: [PULL] http://mercurial.intuxication.org/hg/v4l-dvb-commits

2009-03-04 Thread Trent Piepho
On Tue, 3 Mar 2009, Mauro Carvalho Chehab wrote: > On Mon, 2 Mar 2009 13:31:11 -0800 (PST) > Trent Piepho wrote: > > Hi Trent, > > > Here's the latest patch for pluto2. It's a much simpler chip than cx18. > > I've used atomic operations to design a lo

[PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-03 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 11 changesets: 01/11: build: fix fix_kconfig.pl http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=3b964d818edc 02/11: videodev: only copy needed part of RW ioctl's parameter http://linuxtv.org/hg/~tap/v4l-dvb?cmd=c

Re: [PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-03 Thread Trent Piepho
On Tue, 3 Mar 2009, Mauro Carvalho Chehab wrote: > On Tue, 3 Mar 2009 13:59:27 -0800 (PST) > Trent Piepho wrote: > > > 04/04: v4l2: Move code to zero querybuf output struct to v4l2_ioctl > > http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=d31e6e7a8241 > > Hmm.. Th

[PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-03 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 4 changesets: 01/04: videodev: not possible to register NULL video_device http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=3c87763acae5 02/04: cx88: remove unnecessary forward declaration of cx88_core http://linux

Re: General protection fault on rmmod cx8800

2009-03-03 Thread Trent Piepho
On Tue, 3 Mar 2009, Jean Delvare wrote: > On Tue, 3 Mar 2009 01:40:00 -0800 (PST), Trent Piepho wrote: > > On Mon, 2 Mar 2009, Jean Delvare wrote: > > In 2.6.20 delayed_work was split from work_struct. The concept of delayed > > work was already there and schedule_delayed_

Re: General protection fault on rmmod cx8800

2009-03-03 Thread Trent Piepho
On Tue, 3 Mar 2009, Trent Piepho wrote: > On Mon, 2 Mar 2009, Jean Delvare wrote: > > be fairly easy, I can take care of it. The difficult part will be to > > handle the compatibility with kernels < 2.6.20 because delayed_work was > > introduced in 2.6.20. Probably "co

Re: General protection fault on rmmod cx8800

2009-03-03 Thread Trent Piepho
On Mon, 2 Mar 2009, Jean Delvare wrote: > > Makes the most sense to me. I was just about to make a patch to do the > > same thing when I got your email. Though I was going to patch the v4l-dvb > > sources to avoid porting work. > > It was easier for me to test on an upstream kernel. The porting s

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-03 Thread Trent Piepho
On Tue, 3 Mar 2009, Hans Verkuil wrote: > On Monday 02 March 2009 23:47:31 Trent Piepho wrote: > > On Mon, 2 Mar 2009, Hans Verkuil wrote: > > > There are good reasons as a developer for keeping backwards > > > compatibility with older kernels: > > > > Do y

Re: Results of the 'dropping support for kernels <2.6.22' poll

2009-03-02 Thread Trent Piepho
On Mon, 2 Mar 2009, Hans Verkuil wrote: > There are good reasons as a developer for keeping backwards compatibility > with older kernels: Do you mean no backwards compatibility with any older kernels? Or do you mean just dropping support for the oldest kernels now supported. What you've said abo

Re: [PULL] http://mercurial.intuxication.org/hg/v4l-dvb-commits

2009-03-02 Thread Trent Piepho
On Sat, 28 Feb 2009, Andy Walls wrote: > On Fri, 2009-02-27 at 21:05 +0200, Igor M. Liplianin wrote: > > On 27 ?? 2009, "Igor M. Liplianin" wrote: > > > On Fri, 27 Feb 2009, Igor M. Liplianin wrote: > > > > 01/02: dm1105: not demuxing from interrupt context. > > > > http://mercurial.in

Re: General protection fault on rmmod cx8800

2009-03-02 Thread Trent Piepho
On Mon, 2 Mar 2009, Jean Delvare wrote: > On Mon, 2 Mar 2009 17:03:49 +0100, Jean Delvare wrote: > > As far as I can see the key difference between bttv-input and > > cx88-input is that bttv-input only uses a simple self-rearming timer, > > while cx88-input uses a timer and a separate workqueue. Th

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran

2009-03-01 Thread Trent Piepho
On Sun, 1 Mar 2009, Hans Verkuil wrote: > > Even though kmalloc supports higher order allocations now, they can > > easily fail. > > The right approach which most drivers take is to allocate up front when the > driver is loaded. Zoran should be modified to do the same. Still, it's a shame to waste

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran

2009-03-01 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans Verkuil wrote: > Also the v4l1 ioctls have been removed and instead zoran relies on the v4l1 > compat layer. I tried testing v4l1 with mplayer and it doesn't seem to work correctly. [pid 29030] ioctl(3, VIDIOCSYNC, 0x884d790) = -1 EBUSY (Device or resource busy) [pid 290

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran

2009-03-01 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans Verkuil wrote: > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran for the > following: I have some questions about your changes. > - zoran: convert to video_ioctl2 and remove 'ready_to_be_freed' hack. It looks like this patch deleted the code relating

Re: [PULL] http://mercurial.intuxication.org/hg/v4l-dvb-commits

2009-02-26 Thread Trent Piepho
On Fri, 27 Feb 2009, Igor M. Liplianin wrote: > 01/02: dm1105: not demuxing from interrupt context. > http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=6faf0753950b I'm not sure if you considered this, but the default work queue is multi-threaded with a kernel thread for each

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran

2009-02-24 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans Verkuil wrote: > Hi Mauro, > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran for the > following: You might consider posting to the mjpeg users list. Maybe there are some people who used the playback feature more often. -- To unsubscribe from this l

Re: POLL: for/against dropping support for kernels < 2.6.22

2009-02-23 Thread Trent Piepho
On Mon, 23 Feb 2009, David Ellingsworth wrote: > On Sun, Feb 22, 2009 at 5:15 AM, Hans Verkuil wrote: > > Optional question: > > Why can't we drop support for all but the latest kernel? > > > > > Why: > > As others have already pointed out, it is a waste of time for > developers who volunteer thei

Re: POLL: for/against dropping support for kernels < 2.6.22

2009-02-23 Thread Trent Piepho
On Mon, 23 Feb 2009, Jean Delvare wrote: > > There are lot's of discussions, but it can be hard sometimes to actually > > determine someone's opinion. > > > > So here is a quick poll, please reply either to the list or directly to me > > with your yes/no answer and (optional but welcome) a short ex

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Mon, 23 Feb 2009, Hans de Goede wrote: > Trent Piepho wrote: > > On Sun, 22 Feb 2009, Hans de Goede wrote: > >> Trent Piepho wrote: > >>> On Sun, 22 Feb 2009, Hans de Goede wrote: > >>>> Yes that is what we are talking about, the camera havin

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Mon, 23 Feb 2009, Hans Verkuil wrote: > On Sunday 22 February 2009 23:54:42 Hans de Goede wrote: > > Trent Piepho wrote: > > > On Sun, 22 Feb 2009, Hans de Goede wrote: > > >> Yes that is what we are talking about, the camera having a gravity > > >>

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans de Goede wrote: > Trent Piepho wrote: > > On Sun, 22 Feb 2009, Hans de Goede wrote: > >> Yes that is what we are talking about, the camera having a gravity switch > >> (usually nothing as advanced as a gyroscope). Also the bits we are talking

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans de Goede wrote: > Yes that is what we are talking about, the camera having a gravity switch > (usually nothing as advanced as a gyroscope). Also the bits we are talking > about are in a struct which communicates information one way, from the camera > to userspace, so there

Re: Minimum kernel version supported by v4l-dvb

2009-02-21 Thread Trent Piepho
On Sat, 21 Feb 2009, Jean Delvare wrote: > On Sat, 21 Feb 2009 04:06:53 -0800 (PST), Trent Piepho wrote: > > The new i2c driver interface also supports a ->detect() method and a list > > of address_data to use it with. This is much more like the legacy model > > than usi

Re: RFCv1: v4l-dvb development models & old kernel support

2009-02-21 Thread Trent Piepho
On Sat, 21 Feb 2009, wk wrote: > Hans Verkuil wrote: > > Comments? > > > > Hans > > > > As only beeing reader of this list.., why not simply reduce the work load by > > - reducing the number of supported kernel versions to five major > versions? Currently 2.6.28 would mean down to 2.6.23, > thi

Re: Minimum kernel version supported by v4l-dvb

2009-02-21 Thread Trent Piepho
On Fri, 20 Feb 2009, Mauro Carvalho Chehab wrote: > On Sat, 21 Feb 2009 02:12:53 +0100 > Hans Verkuil wrote: > > > I think that maybe we'll need some legacy-like support for bttv and cx88, > > > since there are some boards that relies on the old i2c method to work. On > > > those boards (like cx88

Re: Questions about VIDIOC_G_JPEGCOMP / VIDIOC_S_JPEGCOMP

2009-02-20 Thread Trent Piepho
On Fri, 20 Feb 2009, Jean-Francois Moine wrote: > So, I propose to remove these ioctls, and to add two controls: one to > set the JPEG quality (range 15..95 %) and the other to set a webcam > quality which might be a boolean or any value depending on some > associated webcam parameter. A control c

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-18 Thread Trent Piepho
On Wed, 18 Feb 2009, Steven Toth wrote: > Trent Piepho wrote: > > On Tue, 17 Feb 2009, Steven Toth wrote: > >> Trent Piepho wrote: > >>> On Mon, 16 Feb 2009, Steven Toth wrote: > >>>> Fixing the demux... Would this require and extra buffer copy?

not demuxing from interrupt context

2009-02-18 Thread Trent Piepho
it should have been.# HG changeset patch # User Trent Piepho # Date 1234955305 28800 # Node ID a5aea1a8b5bc1866d3559294a4caff90f7847ee3 # Parent 960985ba30c69c03fb030edd451bb26846ca75a0 pluto2: Demux packets from a work queue From: Trent Piepho This driver was demuxing the transport stream from its i

Re: [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-18 Thread Trent Piepho
On Tue, 17 Feb 2009, Andreas Oberritter wrote: > Oliver Endriss wrote: > > Trent Piepho wrote: > >> I agree, this is bad. The demuxer is far too much work to be done with > >> IRQs off. IMHO, even doing it under a spin-lock is excessive. It should > >> be

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-17 Thread Trent Piepho
On Wed, 18 Feb 2009, Oliver Endriss wrote: > [1] If you want to lock a process against an interrupt handler, > - the process must use spin_lock_irq() > - the interrupt can use spin_lock() > > A routine has to use spin_lock_irqsave if (and only if) process and irq > call the routine concurrently. I

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-17 Thread Trent Piepho
On Tue, 17 Feb 2009, Steven Toth wrote: > Trent Piepho wrote: > > On Mon, 16 Feb 2009, Steven Toth wrote: > >>> Hartmut, Oliver and Trent: Thanks for helping with this issue. I've just > >>> reverted the changeset. We still need a fix at dm1105, au0828-dvb and

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-16 Thread Trent Piepho
On Mon, 16 Feb 2009, Steven Toth wrote: > > Hartmut, Oliver and Trent: Thanks for helping with this issue. I've just > > reverted the changeset. We still need a fix at dm1105, au0828-dvb and maybe > > other drivers that call the filtering routines inside IRQ's. > > Fix the demux, add a worker threa

Re: [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-16 Thread Trent Piepho
On Sun, 15 Feb 2009, Oliver Endriss wrote: > e9hack wrote: > > this change set is wrong. The affected functions cannot be called from an > > interrupt > > context, because they may process large buffers. In this case, interrupts > > are disabled for > > a long time. Functions, like dvb_dmx_swfilt

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Trent Piepho
On Mon, 16 Feb 2009, Hans Verkuil wrote: > >> If you want to add two bits with > >> mount information, feel free. But don't abuse them for pivot > >> information. > >> If you want that, then add another two bits for the rotation: > > > > Ok, this seems good. But if we want to distinguish between st

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: > On Sun, 15 Feb 2009 10:29:03 +0100 > Hans de Goede wrote: > > > I think we should also be able to detect 90 and 270 degree rotations. Or > > > at > > > the very least prepare for it. It's a safe bet to assume that webcams will > > > arrive that

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009 kilg...@banach.math.auburn.edu wrote: > On Sun, 15 Feb 2009, Trent Piepho wrote: > > On Sun, 15 Feb 2009, Hans de Goede wrote: > >>>>> I think we should also be able to detect 90 and 270 degree rotations. > >>>>> Or at > >>

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Hans de Goede wrote: > Trent Piepho wrote: > > On Sun, 15 Feb 2009, Hans de Goede wrote: > >> Hans Verkuil wrote: > >>> On Sunday 15 February 2009 10:08:04 Hans de Goede wrote: > >>>> kilg...@banach.math.auburn.edu wrote: &g

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Hans de Goede wrote: > Hans Verkuil wrote: > > On Sunday 15 February 2009 10:08:04 Hans de Goede wrote: > >> kilg...@banach.math.auburn.edu wrote: > >>> On Sat, 14 Feb 2009, Hans Verkuil wrote: > On Saturday 14 February 2009 22:55:39 Hans de Goede wrote: > > Adam Baker

Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote: > On Sat, Feb 14, 2009 at 11:54 AM, Trent Piepho wrote: > >> Didn't you say in your original post that you _haven't_ tested the > >> code because of a conflict with your sata driver? It's not safe to > > > > I

Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote: > On Fri, Feb 13, 2009 at 5:07 PM, Trent Piepho wrote: > > I tested it on my bttv card. I assume Mauro was able to test it too. Have > > you found a problem? > > Didn't you say in your original post that you _haven't_ tested t

<    1   2   3   >