Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
On 28/08/18 12:40, Philippe De Muyter wrote: > Hi Hans, > > On Tue, Aug 28, 2018 at 12:29:21PM +0200, Hans Verkuil wrote: >> On 28/08/18 12:26, Philippe De Muyter wrote: >>> Hi Hans, >>> >>> On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: This is a bit too magical for my

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
Hi Hans, On Tue, Aug 28, 2018 at 12:29:21PM +0200, Hans Verkuil wrote: > On 28/08/18 12:26, Philippe De Muyter wrote: > > Hi Hans, > > > > On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: > >> This is a bit too magical for my tastes. I'd add a type field: > >> > >> #define

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
On 28/08/18 12:26, Philippe De Muyter wrote: > Hi Hans, > > On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: >> Hi Philippe, >> >> On 28/08/18 09:55, Philippe De Muyter wrote: >>> add max_interval and step_interval to struct >>> v4l2_subdev_frame_interval_enum. >> >> Yeah, I never

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
Hi Hans, On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: > Hi Philippe, > > On 28/08/18 09:55, Philippe De Muyter wrote: > > add max_interval and step_interval to struct > > v4l2_subdev_frame_interval_enum. > > Yeah, I never understood why this wasn't supported when this API was

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
Hi Philippe, On 28/08/18 09:55, Philippe De Muyter wrote: > add max_interval and step_interval to struct > v4l2_subdev_frame_interval_enum. Yeah, I never understood why this wasn't supported when this API was designed. Clearly an oversight. > > When filled correctly by the sensor driver, those

[PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
add max_interval and step_interval to struct v4l2_subdev_frame_interval_enum. When filled correctly by the sensor driver, those fields must be used as follows by the intermediate level : struct v4l2_frmivalenum *fival; struct v4l2_subdev_frame_interval_enum fie; if