Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-13 Thread Devin Heitmueller
On Sat, Jan 11, 2014 at 5:12 PM, Tim Mester tmes...@ieee.org wrote: My device is the 950q, so it uses the AU8522_DEMODLOCKING method. No devices do tuner locking for digital (it's always the demodulator). That code should really just be ripped out. It does not appear to be an xc5000 issue

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-11 Thread Tim Mester
On Wed, Jan 8, 2014 at 1:26 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: Hi Tim, On Wed, Jan 8, 2014 at 12:12 AM, Tim Mester tmes...@ieee.org wrote: Commit 2e68a75990011ccd looks interesting. It makes sense to me that if we are gating the clock, and it is possible that we are

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-08 Thread Devin Heitmueller
Hi Tim, On Wed, Jan 8, 2014 at 12:12 AM, Tim Mester tmes...@ieee.org wrote: Commit 2e68a75990011ccd looks interesting. It makes sense to me that if we are gating the clock, and it is possible that we are glitching the clock line, it could put the internal synchronous logic into a bad

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Mauro Carvalho Chehab
Hi Devin, Em Mon, 06 Jan 2014 23:53:15 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: What is the actual corruption that you are seeing? Can you describe it in greater detail? The original fix was specifically related to the internal FIFO on the au0828 where it can get

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Devin Heitmueller
On Tue, Jan 7, 2014 at 9:58 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Patches 1 and 2 are ok? If so, could you please reply to them with your ack? Sure, no problem. http://git.kernellabs.com/?p=dheitmueller/linuxtv.git;a=shortlog;h=refs/heads/950q_improv I'm not against the hack

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Tim Mester
On Mon, Jan 6, 2014 at 9:45 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Mon, Jan 6, 2014 at 11:29 PM, Tim Mester ttmest...@gmail.com wrote: The demodulator can get in a state in ATSC mode where just restarting the feed alone does not correct the corrupted stream. The

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Tim Mester
On Mon, Jan 6, 2014 at 9:53 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: I suspect this is actually a different problem which out of dumb luck gets fixed by resetting the chip. Without more details on the specific behavior you are seeing though I cannot really advise on what the

[PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-06 Thread Tim Mester
The demodulator can get in a state in ATSC mode where just restarting the feed alone does not correct the corrupted stream. The demodulator reset in addition to the feed restart seems to correct the condition. The au8522 driver has been modified so that when set_frontend() is called with the

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-06 Thread Devin Heitmueller
On Mon, Jan 6, 2014 at 11:29 PM, Tim Mester ttmest...@gmail.com wrote: The demodulator can get in a state in ATSC mode where just restarting the feed alone does not correct the corrupted stream. The demodulator reset in addition to the feed restart seems to correct the condition. The au8522

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-06 Thread Devin Heitmueller
I suspect this is actually a different problem which out of dumb luck gets fixed by resetting the chip. Without more details on the specific behavior you are seeing though I cannot really advise on what the correct change is. Tim, It might be worth trying out the following patch series and