Re: Patch review

2018-03-08 Thread Mauro Carvalho Chehab
s don't get reviewed for many months, adding up to more than a year > > (in this specific case the first version submitted in June 2016)? > > I assume you're talking about the "[PATCH 0/2 v6] uvcvideo: asynchronous > controls" series, is that correct ? What's the situation of such

Re: Patch review

2018-02-28 Thread Guennadi Liakhovetski
Hi Laurent, Yes, that's correct. Thanks Guennadi On Wed, 28 Feb 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday, 28 February 2018 17:07:00 EET Guennadi Liakhovetski wrote: > > Hi, > > > > I know the "development process and responsibilities" was the main topic > > during the

Re: Patch review

2018-02-28 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 28 February 2018 17:07:00 EET Guennadi Liakhovetski wrote: > Hi, > > I know the "development process and responsibilities" was the main topic > during the last media summit. Unfortunately I haven't attended it, from > the etherpad notes I also cannot quite conclude

Patch review

2018-02-28 Thread Guennadi Liakhovetski
Hi, I know the "development process and responsibilities" was the main topic during the last media summit. Unfortunately I haven't attended it, from the etherpad notes I also cannot quite conclude what decisions have been made. Have any measures been discussed and agreed upon for cases, when

Re: [PATCH REVIEW 03/18] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-12-18 Thread Mauro Carvalho Chehab
Hi Antti, Em Mon, 9 Dec 2013 00:31:20 +0200 Antti Palosaari cr...@iki.fi escreveu: DVB-S/S2 satellite television demodulator driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1

Re: [PATCH REVIEW 03/18] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-12-18 Thread Antti Palosaari
On 18.12.2013 14:35, Mauro Carvalho Chehab wrote: Hi Antti, Em Mon, 9 Dec 2013 00:31:20 +0200 Antti Palosaari cr...@iki.fi escreveu: DVB-S/S2 satellite television demodulator driver. + *You should have received a copy of the GNU General Public License along + *with this program; if

[PATCH REVIEW 00/18] M88DS3103 / M88TS2022 / PCTV 461e

2013-12-08 Thread Antti Palosaari
I think these patches are now in a rather good shape and I will make PULL request soon. I decided to convert M88TS2022 RF tuner to Kernel I2C driver model, which is new thing as there is no any other tuner driver using that model. Testers are still wanted. Git tree is waiting for you:

[PATCH REVIEW 05/18] em28xx: add support for PCTV DVB-S2 Stick (461e) [2013:0258]

2013-12-08 Thread Antti Palosaari
Device has following chips: Empia EM28178, Montage M88DS3103, Montage M88TS2022, Allegro A8293. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/em28xx/Kconfig| 2 ++ drivers/media/usb/em28xx/em28xx-cards.c | 35 ++

[PATCH REVIEW 02/18] a8293: add small sleep in order to settle LNB voltage

2013-12-08 Thread Antti Palosaari
PCTV 461e requires that small delay. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/a8293.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/dvb-frontends/a8293.c b/drivers/media/dvb-frontends/a8293.c index 74fbb5d..780da58 100644 ---

[PATCH REVIEW 03/18] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-12-08 Thread Antti Palosaari
DVB-S/S2 satellite television demodulator driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1 + drivers/media/dvb-frontends/m88ds3103.c | 1293 ++

[PATCH REVIEW 15/18] m88ds3103: add default value for reg 56

2013-12-08 Thread Antti Palosaari
Reg 0x56 should be programmed to 0x01. Add default to inittab. Reported-by: David Howells dhowe...@redhat.com Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103_priv.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH REVIEW 12/18] m88ds3103: fix TS mode config

2013-12-08 Thread Antti Palosaari
TS mode was configured wrongly. Reported-by: David Howells dhowe...@redhat.com Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c

[PATCH REVIEW 14/18] m88ds3103: remove unneeded AGC from inittab

2013-12-08 Thread Antti Palosaari
Optimal AGC is highly depended on used RF tuner and due to that it is already included to chip configuration. However, inittab has default AGC value, which was later replaced by one from config. Add also comment to all chip configuration options about default values and if those are needed to set

[PATCH REVIEW 04/18] Montage M88TS2022 silicon tuner driver

2013-12-08 Thread Antti Palosaari
M88TS2022 is DVB-S/S2 RF tuner used usually in conjunction with Montage M88DS3103 DVB-S/S2 demodulator. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/Kconfig | 7 + drivers/media/tuners/Makefile | 1 + drivers/media/tuners/m88ts2022.c | 664

[PATCH REVIEW 08/18] m88ts2022: do not use dynamic stack allocation

2013-12-08 Thread Antti Palosaari
I2C transfer were using dynamic stack allocation. Get rid of it. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/m88ts2022.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/m88ts2022.c

[PATCH REVIEW 10/18] m88ds3103: use I2C mux for tuner I2C adapter

2013-12-08 Thread Antti Palosaari
Switch standard I2C adapter to muxed I2C adapter. David reported that I2C adapter implementation caused deadlock. I discussed with Jean and he suggested to implement it as a multiplexed i2c adapter because tuner I2C bus could be seen like own I2C segment. Reported-by: David Howells

[PATCH REVIEW 07/18] MAINTAINERS: add M88TS2022

2013-12-08 Thread Antti Palosaari
It is Montage M88TS2022 DVB-S/S2 silicon tuner driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0604247..16661e4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5365,6 +5365,16 @@ Q:

[PATCH REVIEW 16/18] m88ds3103: I/O optimize inittab write

2013-12-08 Thread Antti Palosaari
Write inittab using reg address auto-increment in order to reduce I/O a little bit. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103.c | 43 +++-- 1 file changed, 36 insertions(+), 7 deletions(-) diff --git

[PATCH REVIEW 18/18] m88ds3103: fix possible i2c deadlock

2013-12-08 Thread Antti Palosaari
Adapter is locked by I2C core already. Use unlocked i2c_transfer() version __i2c_transfer() to avoid deadlock. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH REVIEW 06/18] MAINTAINERS: add M88DS3103

2013-12-08 Thread Antti Palosaari
It is Montage M88DS3103 DVB-S/S2 demodulator driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8285ed4..0604247 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5347,6 +5347,16 @@ W:

[PATCH REVIEW 11/18] m88ds3103: use kernel macro to round division

2013-12-08 Thread Antti Palosaari
DIV_ROUND_CLOSEST does the job and looks better. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c

[PATCH REVIEW 01/18] em28xx: add support for Empia EM28178

2013-12-08 Thread Antti Palosaari
New chip version, which is very similar than EM28174. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/em28xx/em28xx-cards.c | 5 + drivers/media/usb/em28xx/em28xx-core.c | 9 ++--- drivers/media/usb/em28xx/em28xx-input.c | 2 ++ drivers/media/usb/em28xx/em28xx-reg.h

[PATCH REVIEW 17/18] m88ts2022: convert to Kernel I2C driver model

2013-12-08 Thread Antti Palosaari
Convert driver from proprietary DVB driver model to standard I2C driver model. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/m88ts2022.c | 121 -- drivers/media/tuners/m88ts2022.h | 24 ++-

[PATCH REVIEW 13/18] m88ts2022: reimplement synthesizer calculations

2013-12-08 Thread Antti Palosaari
Used synthesizer is very typical integer-N PLL, with configurable reference frequency divider, output frequency divider and of course N itself. Most common method to calculate values is first select output divider, then calculate VCO frequency and finally calculate PLL N from VCO frequency. Do it

[PATCH REVIEW 09/18] m88ds3103: do not use dynamic stack allocation

2013-12-08 Thread Antti Palosaari
I2C transfer were using dynamic stack allocation. Get rid of it. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb-frontends/m88ds3103.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c

Re: [PATCH REVIEW 03/18] Montage M88DS3103 DVB-S/S2 demodulator driver

2013-12-08 Thread Matthias Schwarzott
Hi Antti, I have a small suggestion, see below. On 08.12.2013 23:31, Antti Palosaari wrote: diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c new file mode 100644 index 000..91b3729 --- /dev/null +++ b/drivers/media/dvb-frontends/m88ds3103.c

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Michael Krufky
This kinda makes me a bit nervous. The patch itself looks OK but the cascading effects that it will have across the DVB subsystem need to be discussed. Is there a discussion about this kind of conversion on the mailing list somewhere that I've missed? -Mike On Tue, Oct 15, 2013 at 7:33 PM,

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 11:54:57 -0400 Michael Krufky mkru...@linuxtv.org escreveu: This kinda makes me a bit nervous. The patch itself looks OK but the cascading effects that it will have across the DVB subsystem need to be discussed. Is there a discussion about this kind of conversion on the

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Antti Palosaari
On 16.10.2013 18:54, Michael Krufky wrote: This kinda makes me a bit nervous. The patch itself looks OK but the cascading effects that it will have across the DVB subsystem need to be discussed. Basically, the only effect is that you must use i2c_new_device() or i2c_new_probed_device()

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Michael Krufky
On Wed, Oct 16, 2013 at 12:43 PM, Antti Palosaari cr...@iki.fi wrote: On 16.10.2013 18:54, Michael Krufky wrote: This kinda makes me a bit nervous. The patch itself looks OK but the cascading effects that it will have across the DVB subsystem need to be discussed. Basically, the only

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Michael Krufky
On Wed, Oct 16, 2013 at 1:01 PM, Michael Krufky mkru...@linuxtv.org wrote: On Wed, Oct 16, 2013 at 12:43 PM, Antti Palosaari cr...@iki.fi wrote: On 16.10.2013 18:54, Michael Krufky wrote: This kinda makes me a bit nervous. The patch itself looks OK but the cascading effects that it will have

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Jean Delvare
Hi Michael, On Wed, 16 Oct 2013 13:04:42 -0400, Michael Krufky wrote: YIKES!! i2c_new_probed_device() does indeed probe the hardware -- this is unacceptable, as such an action can damage the ic. Is there some additional information that I'm missing that lets this perform an attach without

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Michael Krufky
On Wed, Oct 16, 2013 at 1:09 PM, Jean Delvare kh...@linux-fr.org wrote: Hi Michael, On Wed, 16 Oct 2013 13:04:42 -0400, Michael Krufky wrote: YIKES!! i2c_new_probed_device() does indeed probe the hardware -- this is unacceptable, as such an action can damage the ic. Is there some

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Antti Palosaari
On 16.10.2013 20:19, Michael Krufky wrote: On Wed, Oct 16, 2013 at 1:09 PM, Jean Delvare kh...@linux-fr.org wrote: Hi Michael, On Wed, 16 Oct 2013 13:04:42 -0400, Michael Krufky wrote: YIKES!! i2c_new_probed_device() does indeed probe the hardware -- this is unacceptable, as such an action

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Michael Krufky
On Wed, Oct 16, 2013 at 1:22 PM, Antti Palosaari cr...@iki.fi wrote: On 16.10.2013 20:19, Michael Krufky wrote: On Wed, Oct 16, 2013 at 1:09 PM, Jean Delvare kh...@linux-fr.org wrote: Hi Michael, On Wed, 16 Oct 2013 13:04:42 -0400, Michael Krufky wrote: YIKES!! i2c_new_probed_device()

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Jean Delvare
On Wed, 16 Oct 2013 20:45:39 +0300, Antti Palosaari wrote: On 16.10.2013 20:33, Michael Krufky wrote: OK, I get it and it does seem OK. I'm just curious what kind of impact this refactoring would have over something like the b2c2-flexcop-fe driver, who does not know which ic's to attach

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-16 Thread Antti Palosaari
On 16.10.2013 20:33, Michael Krufky wrote: On Wed, Oct 16, 2013 at 1:22 PM, Antti Palosaari cr...@iki.fi wrote: On 16.10.2013 20:19, Michael Krufky wrote: On Wed, Oct 16, 2013 at 1:09 PM, Jean Delvare kh...@linux-fr.org wrote: Hi Michael, On Wed, 16 Oct 2013 13:04:42 -0400, Michael Krufky

[PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-15 Thread Antti Palosaari
Initial driver conversion from proprietary DVB tuner model to more general I2C driver model. That commit has just basic binding stuff and driver itself still needs to be converted more complete later. Cc: Jean Delvare kh...@linux-fr.org Signed-off-by: Antti Palosaari cr...@iki.fi ---

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

2013-10-15 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 01:31:04 +0300 Antti Palosaari cr...@iki.fi escreveu: Initial driver conversion from proprietary DVB tuner model to more general I2C driver model. That commit has just basic binding stuff and driver itself still needs to be converted more complete later. Cc: Jean

Re: [patch review 01/02] add driver for Masterkit MA901 usb radio

2012-11-26 Thread Alexey Klimov
Hi Hans, On Fri, Nov 23, 2012 at 3:42 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Alexey, Some (small) comments below... On Mon October 29 2012 02:41:10 Alexey Klimov wrote: This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices.

Re: [patch review 01/02] add driver for Masterkit MA901 usb radio

2012-11-26 Thread Hans Verkuil
On Mon 26 November 2012 13:47:36 Alexey Klimov wrote: Hi Hans, On Fri, Nov 23, 2012 at 3:42 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Alexey, Some (small) comments below... On Mon October 29 2012 02:41:10 Alexey Klimov wrote: This patch creates a new usb-radio driver,

Re: [patch review 01/02] add driver for Masterkit MA901 usb radio

2012-11-23 Thread Hans Verkuil
Hi Alexey, Some (small) comments below... On Mon October 29 2012 02:41:10 Alexey Klimov wrote: This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this

[patch review 00/02] driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
-4.7. I tested it on kernel 3.5.7 on x86_64 and on linux kernel 3.6.2 on ARM platform (odroid-x). Looks fine. Here we have two patches: [patch review 01/02] add driver for Masterkit MA901 usb radio [patch review 02/02] usb hid quirks for Masterkit MA901 usb radio I used a lot of code from radio

[patch review 01/02] add driver for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
This patch creates a new usb-radio driver, radio-ma901.c, that supports Masterkit MA 901 USB FM radio devices. This device plugs into both the USB and an analog audio input or headphones, so this thing only deals with initialization and frequency setting. Signed-off-by: Alexey Klimov

[patch review 02/02] usb hid quirks for Masterkit MA901 usb radio

2012-10-28 Thread Alexey Klimov
Don't let Masterkit MA901 USB radio be handled by usb hid drivers. This device will be handled by radio-ma901.c driver. Signed-off-by: Alexey Klimov klimov.li...@gmail.com diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 5de3bb3..8e06569 100644 --- a/drivers/hid/hid-core.c +++

Re: [patch review 5/6] radio-mr800: update suspend/resume procedure

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:46 PM, Alexey Klimovklimov.li...@gmail.com wrote: Patch fixes suspend/resume procedure. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 05754a500f80 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c   Sat Aug 08

Re: [patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:45 PM, Alexey Klimovklimov.li...@gmail.com wrote: Remove redundant lock/unlock_kernel() calls from usb_amradio_open/close functions. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r ee6cf88cb5d3 linux/drivers/media/radio/radio-mr800.c ---

Re: [patch review 3/6] radio-mr800: no need to pass curfreq value to amradio_setfreq()

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:46 PM, Alexey Klimovklimov.li...@gmail.com wrote: Small cleanup of amradio_setfreq(). No need to pass radio-curfreq value to this function. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 5f3329bebfe4 linux/drivers/media/radio/radio-mr800.c ---

Re: [patch review 4/6] radio-mr800: make radio-status variable

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:46 PM, Alexey Klimovklimov.li...@gmail.com wrote: Remove radio-muted and radio-removed variables from amradio_device structure. Instead patch creates radio-status variable and updates code. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r a1ccdea5a182

Re: [patch review 6/6] radio-mr800: redesign radio-users counter

2009-08-10 Thread David Ellingsworth
On Sat, Aug 8, 2009 at 1:46 PM, Alexey Klimovklimov.li...@gmail.com wrote: Redesign radio-users counter. Don't allow more that 5 users on radio in usb_amradio_open() and don't stop radio device if other userspace application uses it in usb_amradio_close(). Signed-off-by: Alexey Klimov

Re: [patch review 6/6] radio-mr800: redesign radio-users counter

2009-08-09 Thread Hans Verkuil
On Saturday 08 August 2009 22:16:28 wk wrote: Alexey Klimov schrieb: On Sat, Aug 8, 2009 at 10:01 PM, Trent Piephoxy...@speakeasy.org wrote: On Sat, 8 Aug 2009, Alexey Klimov wrote: Redesign radio-users counter. Don't allow more that 5 users on radio in Why?

[patch review 0/6] radio-mr800

2009-08-08 Thread Alexey Klimov
Hello all, Here are some radio-mr800 patches against hg v4l-dvb tree. Patchset removes lock_kernel calls, fixes suspend/resume, cleanups, introduces status variable and redesigns users counter in driver. As usual comments, remarks, ideas are more than welcome :) [1/6] radio-mr800: remove

[patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel

2009-08-08 Thread Alexey Klimov
Remove redundant lock/unlock_kernel() calls from usb_amradio_open/close functions. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r ee6cf88cb5d3 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 01:42:02 2009 -0300 +++

[patch review 2/6] radio-mr800: cleanup of usb_amradio_open/close

2009-08-08 Thread Alexey Klimov
Patch removes functions that shouldn't be in usb_amradio_open/close: amradio_set_mute(), amradio_set_stereo(), amradio_setfreq(). Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 34b4e5c9d5c2 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c

[patch review 3/6] radio-mr800: no need to pass curfreq value to amradio_setfreq()

2009-08-08 Thread Alexey Klimov
Small cleanup of amradio_setfreq(). No need to pass radio-curfreq value to this function. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 5f3329bebfe4 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 12:36:46 2009 +0400 +++

[patch review 5/6] radio-mr800: update suspend/resume procedure

2009-08-08 Thread Alexey Klimov
Patch fixes suspend/resume procedure. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 05754a500f80 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Sat Aug 08 20:06:36 2009 +0400 +++ b/linux/drivers/media/radio/radio-mr800.c Sat Aug 08

Re: [patch review 6/6] radio-mr800: redesign radio-users counter

2009-08-08 Thread wk
Alexey Klimov schrieb: On Sat, Aug 8, 2009 at 10:01 PM, Trent Piephoxy...@speakeasy.org wrote: On Sat, 8 Aug 2009, Alexey Klimov wrote: Redesign radio-users counter. Don't allow more that 5 users on radio in Why? Well, v4l2 specs says that multiple opens are optional.

[patch review] gspca - stv06xx: remove needless if check and goto

2009-06-09 Thread Alexey Klimov
Hello, Jean-Francois and Erik André What do you think about such small change? Looks like the code doesn't need if-check and goto here in stv06xx_stopN function. The code after label out does this. -- Patch removes needless if check and goto. Signed-off-by: Alexey Klimov

Re: [patch review] gspca - stv06xx: remove needless if check and goto

2009-06-09 Thread Erik Andrén
2009/6/9 Alexey Klimov klimov.li...@gmail.com: Hello, Jean-Francois and Erik André What do you think about such small change? Looks like the code doesn't need if-check and goto here in stv06xx_stopN function. The code after label out does this. -- Patch removes needless if check and goto.

[patch review 1/4] dsbr100: remove radio-users counter

2009-05-28 Thread Alexey Klimov
Patch removes radio-users counter because it is not in use. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 315bc4b65b4f linux/drivers/media/radio/dsbr100.c --- a/linux/drivers/media/radio/dsbr100.c Sun May 17 12:28:55 2009 + +++ b/linux/drivers/media/radio/dsbr100.c

[patch review 2/4] dsbr100: remove usb_dsbr100_open/close calls

2009-05-28 Thread Alexey Klimov
Patch removes usb_dsbr100_open and usb_dsbr100_close calls. 1. No need to start, set frequency, adjust parameters in open call. 2. This patch tackles issue with lock/unlock_kernel() in open call. 3. With this patch feature Mute on exit? in gnomeradio works. Signed-off-by: Alexey Klimov

[patch review 4/4] dsbr100: change radio-muted to radio-status, update suspend/resume

2009-05-28 Thread Alexey Klimov
Patch renames radio-muted to radio-status, add defines for that variable, and fixes suspend/resume procedure. Radio-status set to STOPPED in usb_dsbr100_probe because of removing open call. Also, patch increases driver version. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r

Re: [patch review] uvc_driver: fix compile warning

2009-04-20 Thread Laurent Pinchart
Hi Alexey, On Sunday 19 April 2009 22:03:09 Alexey Klimov wrote: Hello, all I saw warnings in v4l-dvb daily build. May this patch be helpful? I can't reproduce the problem with gcc 4.3.2. Hans, what's the policy for fixing gcc-related issues ? Should the code use uninitialized_var() to make

[patch review] av7110_hw: fix compile warning

2009-04-19 Thread Alexey Klimov
One more warning fix. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r cda79523a93c linux/drivers/media/dvb/ttpci/av7110_hw.c --- a/linux/drivers/media/dvb/ttpci/av7110_hw.c Thu Apr 16 18:30:38 2009 +0200 +++ b/linux/drivers/media/dvb/ttpci/av7110_hw.c Mon Apr 20 00:17:51 2009 +0400

Re: [patch review] radio-si470x: fix possible bug with freeing memory order

2009-04-01 Thread Alexey Klimov
(add Mauro on c/c) On Wed, Apr 1, 2009 at 9:36 PM, Tobias Lorenz tobias.lor...@gmx.net wrote: Hi, Hi :) hey thanks. I appreciate and approve the patch. Do I have to upload the patch and send Mauro a pull request or is this already done? Bye, Toby Well, as i understand that's to you or

[patch review] radio-si470x: fix possible bug with freeing memory order

2009-03-31 Thread Alexey Klimov
Hello, all There is probably bug when cleanup occurs in si470x_usb_driver_probe. We do kmalloc for radio-buffer and when it's fail we kfree(radio-buffer). The same with si470x_get_all_registers() and si470x_get_scratch_page_versions(). When this functions failed we go to err_all and try to free

[patch review] gspca - mr97310a: return error instead of -1 in sd_mod_init

2009-03-27 Thread Alexey Klimov
Hello, Jean-Francois What do you think about such small cleanup ? --- Patch reformats sd_mod_init in the way to make it return error code from usb_register instead of -1. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 56cf0f1772f7 linux/drivers/media/video/gspca/mr97310a.c ---

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-21 Thread Alain Kalker
Op zaterdag 21-03-2009 om 22:11 uur [tijdzone +0100], schreef Alain Kalker: Op donderdag 19-03-2009 om 15:43 uur [tijdzone -0700], schreef Trent Piepho: On Thu, 19 Mar 2009, Mauro Carvalho Chehab wrote: On Thu, 19 Mar 2009 17:18:47 +0300 Alexey Klimov klimov.li...@gmail.com wrote:

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-21 Thread Alain Kalker
Op zaterdag 21-03-2009 om 22:16 uur [tijdzone +0100], schreef Alain Kalker: Starting out from 'allmodconfig', Pruning (deselecting) all principal modules (i.e. those that actually provide modaliases) for devices that we don't want, and then pruning all of their dependencies that have now

[patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? --- Patch divides/separates radio drivers in Kconfig in 3 groups - ISA, PCI and others. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 626c136ec221

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Hans Verkuil
Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? I think splitting off the ISA drivers is certainly useful. I'm not sure whether you need to split the remainder into PCI and Others. I think that's overkill. Regards,

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Mauro Carvalho Chehab
On Thu, 19 Mar 2009 16:03:20 +0300 Alexey Klimov klimov.li...@gmail.com wrote: Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? Frankly, I don't see any gain: If the user doesn't have ISA (or doesn't want to have), it should

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
On Thu, 2009-03-19 at 14:37 +0100, Hans Verkuil wrote: Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? I think splitting off the ISA drivers is certainly useful. I'm not sure whether you need to split the remainder into

Re: [patch review] radio/Kconfig: introduce 3 groups: isa, pci, and others drivers

2009-03-19 Thread Alexey Klimov
On Thu, Mar 19, 2009 at 5:03 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Thu, 19 Mar 2009 16:03:20 +0300 Alexey Klimov klimov.li...@gmail.com wrote: Hello, all What do you think about such patch that makes selecting of radio drivers in menuconfig more comfortable ? Frankly, I

[patch review] radio-terratec: remove unused delay.h

2009-03-10 Thread Alexey Klimov
Hello, all I don't know if this patch okay, so it should be tested/reviewed. Anyway, compilation process shows no warnings. --- Patch removes linux/delay.h which hadn't been used. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 615fb8f01610

Re: [patch review] radio-terratec: remove unused delay.h

2009-03-10 Thread Hans Verkuil
Hello, all I don't know if this patch okay, so it should be tested/reviewed. Anyway, compilation process shows no warnings. --- Patch removes linux/delay.h which hadn't been used. Signed-off-by: Alexey Klimov klimov.li...@gmail.com Looks good. Signed-off-by: Hans Verkuil

[patch review] em28xx-audio: replace printk with em28xx_errdev

2009-02-08 Thread Alexey Klimov
Hello all, i hope this patch will be useful. Probably this change should looks like: printk(KERN_ERR em28xx-audio.c:..) but i suppose that em28xx_errdev is better. -- Patch removes printk and place em28xx_errdev macros to provide information about driver name to dmesg. Signed-off-by: Alexey

Re: [patch review 6/8] radio-mr800: add stereo support

2009-02-04 Thread Alexey Klimov
Reformatted patch, version 2. Corrects checking of returned value after usb_bulk_msg. --- Patch introduces new amradio_set_stereo function. Driver calls this func to make stereo radio reception. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 34b045702595

[patch review 9/8] radio-mr800: fix checking of retval after usb_bulk_msg

2009-02-04 Thread Alexey Klimov
Patch corrects checking of returned value after usb_bulk_msg. Now we also check if number of transferred bytes equals to BUFFER_LENGTH. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 2876e91adef9 linux/drivers/media/radio/radio-mr800.c ---

[patch review 1/8] radio-mr800: codingstyle cleanups

2009-02-02 Thread Alexey Klimov
Cleanups of many if-check constructions. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 1dce9d4e2179 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Sun Feb 01 11:40:27 2009 -0200 +++ b/linux/drivers/media/radio/radio-mr800.c Mon Feb 02

[patch review 3/8] radio-mr800: add more dev_err messages in probe

2009-02-02 Thread Alexey Klimov
Patch adds 3 dev_err messages in usb_amradio_probe() function. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r c9f51bda84de linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:53:50 2009 +0300 +++

[patch review 6/8] radio-mr800: add stereo support

2009-02-02 Thread Alexey Klimov
Patch introduces new amradio_set_stereo function. Driver calls this func to make stereo radio reception. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 34b045702595 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Tue Feb 03 03:02:39 2009

Re: [patch review] em28xx: correct mailing list

2009-01-25 Thread Douglas Schilling Landgraf
Hi Alexey, Applied, thanks. Cheers, Douglas On Sun, 25 Jan 2009 06:36:33 +0300 Alexey Klimov klimov.li...@gmail.com wrote: Hello all I'm not sure is this patch really suitable. But looks that main development mail-list moved to linux-media.. --- Correct mailing list in 3 places in

[patch review] em28xx: correct mailing list

2009-01-24 Thread Alexey Klimov
Hello all I'm not sure is this patch really suitable. But looks that main development mail-list moved to linux-media.. --- Correct mailing list in 3 places in em28xx-cards.c Move to linux-media on vger.kernel.org. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 6a6eb9efc6cd