On Tuesday 06 April 2010 00:58:54 Hans Verkuil wrote:
On Tuesday 06 April 2010 00:46:11 Laurent Pinchart wrote:
On Sunday 04 April 2010 05:14:17 David Ellingsworth wrote:
After looking at the proposed solution, I personally find the
suggestion for a serialization flag to be quite
On Tuesday 06 April 2010 00:12:48 Hans Verkuil wrote:
On Monday 05 April 2010 23:47:10 Hans Verkuil wrote:
Hi all,
The new control framework makes it very easy to expose controls in sysfs.
The way it is implemented now in the framework is that each device node
will get a 'controls'
Hi on one (and only one I think) multiplex after digital switchover I
am getting the following
[6440]:530167000:INVERSION_AUTO:BANDWIDTH_8_MHZ:FEC_2_3:FEC_AUTO:QAM_64:TRANSMISSION_MODE_2K:GUARD_INTERVAL_1_32:HIERARCHY_NONE:101:102:25664
Hi !
Ok, that puts the problem firmly into uvcvideo area.
Try changing its _resume routine to whatever is done on device
unplug... it should be rather easy, and is quite close to correct
solution.
I am waiting to try that.
If I always need to rmmod/modprobe everytime, that is meaning that
drivers/media/IR/ir-raw-event.c is currently written with the assumption that
all raw hardware will generate events only on state change (i.e. when
a pulse or space starts).
However, some hardware (like mceusb, probably the most popular IR receiver
out there) only generates duration data (and
On Tue, 2010-04-06 at 08:37 +0200, Hans Verkuil wrote:
On Tuesday 06 April 2010 00:12:48 Hans Verkuil wrote:
On Monday 05 April 2010 23:47:10 Hans Verkuil wrote:
One thing that might be useful is to prefix the name with the control class
name. E.g. hue becomes user_hue and audio_crc
Hi Andy,
On Tuesday 06 April 2010 13:06:18 Andy Walls wrote:
On Tue, 2010-04-06 at 08:37 +0200, Hans Verkuil wrote:
[snip]
Again, I still don't know whether we should do this. It is dangerously
seductive because it would be so trivial to implement.
It's like watching ships run aground
On Tue, Apr 6, 2010 at 1:27 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Andy,
On Tuesday 06 April 2010 13:06:18 Andy Walls wrote:
On Tue, 2010-04-06 at 08:37 +0200, Hans Verkuil wrote:
[snip]
Again, I still don't know whether we should do this. It is dangerously
Oliver Endriss o.endr...@gmx.de writes:
Bjørn Mork wrote:
As discussed many times, e.g. in http://lkml.org/lkml/2007/7/26/401
mixing IRQF_DISABLED with IRQF_SHARED may cause unpredictable and
unexpected results.
Add a module parameter to allow fine tuning the request_irq
flags based on
Hans Verkuil wrote:
On Tuesday 06 April 2010 00:58:54 Hans Verkuil wrote:
On Tuesday 06 April 2010 00:46:11 Laurent Pinchart wrote:
On Sunday 04 April 2010 05:14:17 David Ellingsworth wrote:
After looking at the proposed solution, I personally find the
suggestion for a serialization flag to
Hans Verkuil wrote:
On Tuesday 06 April 2010 00:12:48 Hans Verkuil wrote:
On Monday 05 April 2010 23:47:10 Hans Verkuil wrote:
Hi all,
The new control framework makes it very easy to expose controls in sysfs.
The way it is implemented now in the framework is that each device node
will get a
On Tue 2010-04-06 11:32:46, Mohamed Ikbel Boulabiar wrote:
Hi !
Ok, that puts the problem firmly into uvcvideo area.
Try changing its _resume routine to whatever is done on device
unplug... it should be rather easy, and is quite close to correct
solution.
I am waiting to try that.
Hans Verkuil wrote:
$ ls /sys/class/video4linux/video1/controls
balance mpeg_insert_navigation_packets
mpeg_video_aspect
brightnessmpeg_median_chroma_filter_maximum
mpeg_video_b_frames
chroma_agc
Hans Verkuil wrote:
On Tuesday 06 April 2010 00:58:54 Hans Verkuil wrote:
On Tuesday 06 April 2010 00:46:11 Laurent Pinchart wrote:
On Sunday 04 April 2010 05:14:17 David Ellingsworth wrote:
After looking at the proposed solution, I personally find the
suggestion for a serialization flag to
On Tue, Apr 6, 2010 at 9:44 AM, Hans Verkuil hverk...@xs4all.nl wrote:
1) We don't have that information.
2) It would make a simple scheme suddenly a lot more complicated (see
Andy's comments)
3) The main interface is always the application's GUI through ioctls, not
sysfs.
4) Remember that
Hi David,
Em Tue, 6 Apr 2010 12:48:11 +0200
David Härdeman da...@hardeman.nu escreveu:
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-raw
Thunderbird 2 really don't like this. It considers the entire body as a file,
and
refuses
Hans Verkuil wrote:
Hans Verkuil wrote:
$ ls /sys/class/video4linux/video1/controls
balance mpeg_insert_navigation_packets
mpeg_video_aspect
brightnessmpeg_median_chroma_filter_maximum
mpeg_video_b_frames
chroma_agc
Comments below...
On Mon, 5 Apr 2010, Hans Verkuil wrote:
Hi all,
The new control framework makes it very easy to expose controls in sysfs.
The way it is implemented now in the framework is that each device node
will get a 'controls' subdirectory in sysfs. Below which are all the controls
On Tue, 6 Apr 2010, Hans Verkuil wrote:
[...]
One thing that might be useful is to prefix the name with the control class
name. E.g. hue becomes user_hue and audio_crc becomes mpeg_audio_crc. It would
groups them better. Or one could make a controls/user and controls/mpeg
directory.
Hans Verkuil wrote:
Hans Verkuil wrote:
- performance is important only for the ioctl's that directly handles
the streaming (dbuf/dqbuf friends);
What performance? These calls just block waiting for a frame. How the hell
am I suppose to test performance anyway on something like that?
On Tue, 6 Apr 2010, Devin Heitmueller wrote:
[...]
I tend to agree with Hans. We've already got *too many* interfaces
that do the same thing. The testing matrix is already a nightmare -
V4L1 versus V4L2, mmap() versus read(), legacy controls versus
extended controls, and don't get
On Tue, 6 Apr 2010, Markus Rechberger wrote:
[...]
how about security permissions? while you can easily change the
permission levels for nodes in /dev you can't do this so easily with
sysfs entries.
I don't really think this is needed at all some applications will
start to use ioctl
On Tue, 6 Apr 2010, Laurent Pinchart wrote:
Hi Andy,
On Tuesday 06 April 2010 13:06:18 Andy Walls wrote:
On Tue, 2010-04-06 at 08:37 +0200, Hans Verkuil wrote:
[snip]
Again, I still don't know whether we should do this. It is dangerously
seductive because it would be so trivial
On 04/06/10 15:32, Mauro Carvalho Chehab wrote:
Hans Verkuil wrote:
Hans Verkuil wrote:
$ ls /sys/class/video4linux/video1/controls
balance mpeg_insert_navigation_packets
mpeg_video_aspect
brightnessmpeg_median_chroma_filter_maximum
On 04/06/10 15:41, Mike Isely wrote:
On Tue, 6 Apr 2010, Hans Verkuil wrote:
[...]
One thing that might be useful is to prefix the name with the control class
name. E.g. hue becomes user_hue and audio_crc becomes mpeg_audio_crc. It
would
groups them better. Or one could make a
Hi Mauro,
On Tue, 06 Apr 2010 02:34:46 -0300, Mauro Carvalho Chehab wrote:
Jean Delvare wrote:
On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote:
Please, don't add new things at ir-common module. It basically contains the
decoding functions for RC5 and pulse/distance, plus
On 6 April 2010 18:06, Jonathan Cameron ji...@cam.ac.uk wrote:
On 04/06/10 15:32, Mauro Carvalho Chehab wrote:
Hans Verkuil wrote:
Hans Verkuil wrote:
$ ls /sys/class/video4linux/video1/controls
balance mpeg_insert_navigation_packets
mpeg_video_aspect
brightness
-Original Message-
From: Muralidharan Karicheri [mailto:mkarich...@gmail.com]
Sent: Saturday, April 03, 2010 1:33 AM
To: Hiremath, Vaibhav
Cc: linux-media@vger.kernel.org; Karicheri, Muralidharan;
mche...@redhat.com; linux-o...@vger.kernel.org; t...@atomide.com
Subject: Re: [PATCH
The code that enables IRQ for the Remote Controller on saa7134 is a little
messy: it is outside saa7134-input, it checks if RC is GPIO based, and
it mixes both serial raw decode with parallel reads from a hardware-based
IR decoder.
Also, currently, it doesn't allow to trigger both transition
The usage of macros ensures that the proper namespace is being used
by all tables. It also makes easier to associate a keytable with
the name used inside the drivers.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-keymaps.c
Reimplement the RC-5 decoder state machine. Code is now clear, and works
properly. It is also simpler than the previous implementations.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-rc5-decoder.c
b/drivers/media/IR/ir-rc5-decoder.c
index
There's an error at the IRQ2 bit map registers. Also, it doesn't
show what bits are needed for positive and for negative edge.
In the case of IR raw decoding, for some protocols, it is important
to detect both positive and negative edges. So, a latter patch
will need to use the other values.
Several DVB drivers use a different name convention. As we're moving
the keytables, we need to use the same convention on all places.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/dvb/dvb-usb/a800.c b/drivers/media/dvb/dvb-usb/a800.c
index 6247239..b6cbb1d
A previous cleanup patch removed more than needed. Re-add the logic that
disable the decoders.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-nec-decoder.c
b/drivers/media/IR/ir-nec-decoder.c
index 28d7735..9d1ada9 100644
---
The keymaps don't need to be recompiled every time a change at ir-core.h
happens, since it only depends on rc-map defines. By moving those
definitions to the proper header, the code became cleaner, and avoids
needing to recompile all the RC maps every time a non-related change
is introduced.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/include/media/ir-common.h b/include/media/ir-common.h
index 800fc98..2e27515 100644
--- a/include/media/ir-common.h
+++ b/include/media/ir-common.h
@@ -112,69 +112,69 @@ void ir_rc5_timer_keyup(unsigned long data);
#define
Instead of using the ugly keymap sequences, use the new rc-*.ko keymap
files. For now, it is still needed to have one keymap loaded, for the
RC code to work. Later patches will remove this depenency.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
create mode 100644
This is the first patch of a series of changes that will break the IR
tables into a series of small modules that can be dynamically loaded,
or just loaded from userspace.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/include/media/ir-common.h b/include/media/ir-common.h
Replaces most of the occurences of IR keytables on V4L drivers by a macro
that evaluates to provide the name of the exported symbol.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/dvb/dm1105/dm1105.c
b/drivers/media/dvb/dm1105/dm1105.c
index f1721e9..17003ed
Now that the decoders are state machine, there's no need to create
an ancillary buffer while decoding the protocol. Just call the decoders
code directly, event by event.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-nec-decoder.c
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/video/cx88/cx88-input.c
b/drivers/media/video/cx88/cx88-input.c
index f5d6130..9dbec1c 100644
--- a/drivers/media/video/cx88/cx88-input.c
+++ b/drivers/media/video/cx88/cx88-input.c
@@ -315,9 +315,9 @@ int
This decoder is also based on a state machine, just like the NEC protocol
decoder. It is pedantic in the sense that accepts only 14 bits. As there
are some variants that outputs less bits, it needs to be improved to also
handle those.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
This is the new set of ir-core changes, with several new improvements.
The most remarkable one is that the IR keymaps were removed from
ir-common module. Now, they are mapped as separate kernel modules, that
can be disabled or enabled as a hole. A future patch may be add a
specific CONFIG_foo
A latter patch will reuse the ir_input_register with a different meaning.
Before it, change all occurrences to a temporary name.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index db54562..1d9c467 100644
---
Remove dead code and properly name a few constants
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-nec-decoder.c
b/drivers/media/IR/ir-nec-decoder.c
index 33b260f..087211c 100644
--- a/drivers/media/IR/ir-nec-decoder.c
+++
Thanks to Andy Walls awa...@md.metrocast.net for pointing me his
code, that gave me some ideas to better implement it.
After some work with saa7134 bits, I found a way to catch both IRQ
edge pulses. By enabling it, the NEC decoder can now take both
pulse and spaces into account, making it more
Instead of having all RC tables hardcoded on one file with
all tables there, add infrastructure for registering and dynamically
load the table(s) when needed.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
create mode 100644 drivers/media/IR/rc-map.c
diff --git
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c
index d3bc909..00db928 100644
--- a/drivers/media/IR/ir-keytable.c
+++ b/drivers/media/IR/ir-keytable.c
@@ -99,6 +99,8 @@ static int ir_do_setkeycode(struct
Vaibhav,
[Hiremath, Vaibhav] Thanks Murali, I really appreciate your comments here.
Please find response below -
You had responded only to some comments. Can I assume that you are taking care
of the other comments as well? I have also asked Hans to provide
his comments since this is a new
The following changes since commit a6eb7bc8e0eea78f96ad1b0f0195ec52b88c6a00:
Laurent Pinchart (1):
V4L/DVB: uvcvideo: Use POLLOUT and POLLWRNORM for output devices
are available in the git repository at:
ssh://linuxtv.org/git/hverkuil/v4l-dvb.git fixes
Hans Verkuil (10):
V4L2
On Wednesday 24 March 2010 14:45:50 Douglas Schilling Landgraf wrote:
Hello Ricardo,
On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini xrma...@gmail.com
wrote:
Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com
--- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23
From: David Härdeman da...@hardeman.nu
The attached patch rewrites much of the keytable code in
drivers/media/IR/ir-keytable.c.
The scancodes are now inserted into the array in sorted
order which allows for a binary search on lookup.
The code has also been shrunk by about 150
From: David Härdeman da...@hardeman.nu
Rewrites the keyup/keydown logic in drivers/media/IR/ir-keytable.c.
All knowledge of keystates etc is now internal to ir-keytable.c
and not scattered around ir-raw-event.c and ir-nec-decoder.c (where
it doesn't belong).
In addition, I've
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Tue Apr 6 19:00:27 CEST 2010
path:http://www.linuxtv.org/hg/v4l-dvb
changeset: 14561:7c0b887911cf
git master:
Hello Mauro,
Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for
the following:
- FusionHDTV: Use quick reads for I2C IR device probingdefault tip
- vpfe capture - fix for kernel crash
- ov511: Fix continuation lines
- saa7134-cards: Add support new TV cards
- saa7134: add
55 matches
Mail list logo
