Re: LibV4L2 and CREATE_BUFS issues

Hi, On 10-12-14 17:27, Nicolas Dufresne wrote: Hi, we recently fixed our CREATE_BUFS support in GStreamer master. It works nicely with UVC drivers. The problem is that libv4l2 isn't aware of it, and endup taking terribly decision the least quickly lead to crash. I'm not sure what that right

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

On 12/13/2014 05:02 AM, Antti Palosaari wrote: I am not sure even idea of that. You didn't add even commit description, like all the other patches too :( You should really start adding commit messages explaining why and how commit is. So the question is why that patch should be applied?

Re: [PATCH 4/4] mn88472: implemented ber reporting

On 12/13/2014 05:15 AM, Antti Palosaari wrote: On 12/13/2014 02:18 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson benja...@southpole.se Reviewed-by: Antti Palosaari cr...@iki.fi Even I could accept that, as a staging driver, I see there some issues: * missing commit message

Re: [PATCH 1/4] mn88472: implement dvb-t signal lock

On 12/13/2014 04:52 AM, Antti Palosaari wrote: That breaks DVB-C lock check as old utmp = 0x08 was set according to DVB-C lock check, right? Antti I have a dvb-c setup now. I will respin this patch with dvb-c support tested properly. MvH Benjamin Larsson -- To unsubscribe from this list:

[PATCH 00/10] Sparse fixes

This patch series fixes almost all remaining sparse warnings. The only one still there is this one in this platform driver: .../platform/timblogiw.c:562:22: warning: context imbalance in 'buffer_queue' - unexpected unlock Note that due to a bug in the daily build process not all media drivers

[PATCH 05/10] media-entity: fix sparse warnings

From: Hans Verkuil hans.verk...@cisco.com drivers/media/media-entity.c:238:17: warning: Variable length array is used. drivers/media/media-entity.c:239:17: warning: Variable length array is used. Replace variable length by MEDIA_ENTITY_ENUM_MAX_ID. Signed-off-by: Hans Verkuil

[PATCH 04/10] videobuf2-vmalloc: fix sparse warning

From: Hans Verkuil hans.verk...@cisco.com Fix this warning: drivers/media/v4l2-core/videobuf2-vmalloc.c:98:28: warning: incorrect type in assignment (different address spaces) drivers/media/v4l2-core/videobuf2-vmalloc.c:158:28: warning: incorrect type in argument 1 (different address spaces)

[PATCH 03/10] ivtv: fix sparse warning

From: Hans Verkuil hans.verk...@cisco.com Fix this warning: drivers/media/pci/ivtv/ivtv-irq.c:418:9: warning: context imbalance in 'ivtv_dma_stream_dec_prepare' - different lock contexts for basic block sparse didn't quite understand the locking scheme, so rewrite it to keep sparse happy.

[PATCH 07/10] m5mols: fix sparse warnings

From: Hans Verkuil hans.verk...@cisco.com drivers/media/i2c/m5mols/m5mols_core.c:128:24: warning: cast to restricted __be16 drivers/media/i2c/m5mols/m5mols_core.c:128:24: warning: cast to restricted __be16 drivers/media/i2c/m5mols/m5mols_core.c:128:24: warning: cast to restricted __be16

[PATCH 06/10] hd29l2: fix sparse error and warnings

From: Hans Verkuil hans.verk...@cisco.com drivers/media/dvb-frontends/hd29l2.c:29:18: warning: Variable length array is used. drivers/media/dvb-frontends/hd29l2.c:34:32: error: cannot size expression drivers/media/dvb-frontends/hd29l2.c:125:5: warning: symbol 'hd29l2_rd_reg_mask' was not

[PATCH 09/10] s5k6aa: fix sparse warnings

From: Hans Verkuil hans.verk...@cisco.com drivers/media/i2c/s5k6aa.c:351:16: warning: cast to restricted __be16 drivers/media/i2c/s5k6aa.c:351:16: warning: cast to restricted __be16 drivers/media/i2c/s5k6aa.c:351:16: warning: cast to restricted __be16 drivers/media/i2c/s5k6aa.c:351:16: warning:

Re: [PATCH 05/10] media-entity: fix sparse warnings

Hi Hans, On Sat, Dec 13, 2014 at 12:52:55PM +0100, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com drivers/media/media-entity.c:238:17: warning: Variable length array is used. drivers/media/media-entity.c:239:17: warning: Variable length array is used. Replace variable

Re: [PATCH 06/10] hd29l2: fix sparse error and warnings

On 12/13/2014 01:52 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com drivers/media/dvb-frontends/hd29l2.c:29:18: warning: Variable length array is used. drivers/media/dvb-frontends/hd29l2.c:34:32: error: cannot size expression drivers/media/dvb-frontends/hd29l2.c:125:5:

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

On 12/13/2014 01:09 PM, Benjamin Larsson wrote: On 12/13/2014 05:02 AM, Antti Palosaari wrote: I am not sure even idea of that. You didn't add even commit description, like all the other patches too :( You should really start adding commit messages explaining why and how commit is. So the

Re: LibV4L2 and CREATE_BUFS issues

Le 2014-12-13 05:41, Hans de Goede a écrit : I think making CREATE_BUFS fail when doing conversion is probably best, note that gstreamer should be able to tell which formats will lead to doing conversion, and that it can try to avoid those. Those format indeed have a flag. The problem is

Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators

On 12/13/2014 02:35 PM, Antti Palosaari wrote: Do you understand that code at all? No I can't really say I understand all the workings of the media api. Now it is: FE0 == (fe-id == 0) == RTL2832 FE1 == (fe-id == 1) == MN88472 you changed it to: FE0 == (fe-id == 0) == MN88472 FE1 ==

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Dec 14 04:00:23 CET 2014 git branch: test git hash: e272d95f8c0544cff55c485a10828b063c8e417c gcc

[PATCH] media: stb0899_drv: use time_after()

To be future-proof and for better readability the time comparisons are modified to use time_after() instead of plain, error-prone math. Signed-off-by: Asaf Vertz asaf.ve...@tandemg.com --- drivers/media/dvb-frontends/stb0899_drv.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-)