Hi Ulrich,
On Fri, Sep 16, 2016 at 3:09 PM, Ulrich Hecht
wrote:
> Signed-off-by: Ulrich Hecht
Reviewed-by: Geert Uytterhoeven
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -30,6 +30,8 @@
> i2c7 = &i2c7;
> i2c8 = &i2c8;
>
Improve the MT21C documentation, making it clearer that this format requires
the MDP
for further processing.
Also fix the fourcc (it was a fivecc :-) )
Signed-off-by: Hans Verkuil
---
diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
b/Documentation/media/uapi/v4l/pixfmt-reserved.r
Fix smatch error:
media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100
mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock'
Signed-off-by: Hans Verkuil
---
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c
index
Hi Mauro,
This adds the mediatek video decoder and MDP driver.
This patch series depends on a bunch of fixes that are currently pending for
4.8:
a21cb70 vcodec:mediatek: Refine VP8 encoder driver
84b313f vcodec:mediatek: Refine H264 encoder driver
55673f3 vcodec:mediatek: change H264 profile de
On Mon, 2016-09-19 at 10:00 +0200, Hans Verkuil wrote:
> Fix smatch error:
>
> media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100
> mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock'
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Minghsiu Tsai
> ---
> diff --gi
Hi Hans,
On Mon, 2016-09-19 at 09:22 +0200, Hans Verkuil wrote:
> Improve the MT21C documentation, making it clearer that this format requires
> the MDP
> for further processing.
>
> Also fix the fourcc (it was a fivecc :-) )
>
reviewed-by: Tiffany Lin
Thanks. I did not notice it become fivec
On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
> This consists of video decoder implementation plus decoder
> controls.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/vidc/vdec.c | 1091
> +
> drivers/media/platform/qcom/vidc/vdec.h
On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
> This consists of video decoder implementation plus decoder
> controls.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/vidc/vdec.c | 1091
> +
> drivers/media/platform/qcom/vidc/vdec.h
Many of my review comments for the decoder apply to the encoder as well,
so I won't repeat those.
On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
> This adds encoder part of the driver plus encoder controls.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/vidc/venc.c
On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
> Makefile and Kconfig files to build the video codec driver.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/Kconfig | 8
> drivers/media/platform/qcom/Makefile | 6 ++
> drivers/media/platform/q
Hi Stanimir,
I've finished my review of this patch series.
I'll be traveling for the next three weeks, so you can take your time with
making a v3 since it is very unlikely I'll be able to review it before I'm
back mid-October.
Thanks for working on this!
Regards,
Hans
On 09/07/2016 01
v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols
are found by the linker only if these libraries are specified after the
objects that depend on them.
As LDFLAGS variable end up expanded on libtool command line before LDADD,
move the libraries to LDADD after local objects. -
Em Mon, 19 Sep 2016 13:50:25 +0300
Sakari Ailus escreveu:
> v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols
> are found by the linker only if these libraries are specified after the
> objects that depend on them.
>
> As LDFLAGS variable end up expanded on libtool command
Hi Mauro,
sorry for my late reply (so much work to do) ..
Am 09.09.2016 um 14:25 schrieb Markus Heiser :
>> Using either this approach or my kernel-doc patch, I'm now getting
>> only two warnings:
>>
>> 1) at media-entity.h, even without nitpick mode:
>>
>> ./include/media/media-entity.h:1053
Moving the pxa_camera driver from soc_camera lots the implied
VIDEO_V4L2 Kconfig dependency, and building the driver without
V4L2 results in a kernel that cannot link:
drivers/media/platform/pxa_camera.o: In function `pxa_camera_remove':
pxa_camera.c:(.text.pxa_camera_remove+0x10): undefined refer
On October 10 and 11 we will have a Codec & Request API brainstorm meeting.
It will be held in room 'Salon 13 Paris' located on level 1 of the Maritim
Berlin Hotel
from 9am to 5pm each day.
The main reason for doing this is that we have at least two codec drivers that
are
blocked due to the fac
Hi Mauro,
On 09/19/16 14:22, Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 13:50:25 +0300
> Sakari Ailus escreveu:
>
>> v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols
>> are found by the linker only if these libraries are specified after the
>> objects that depend
Add a new variable STATIC_LDFLAGS to add the linker flags required for
static linking for each binary built.
Static and dynamic libraries are built by default but the binaries are
otherwise linked dynamically. --with-static-binaries requires that static
libraries are built.
Signed-off-by: Sakari
Em Mon, 19 Sep 2016 16:21:30 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On 09/19/16 14:22, Mauro Carvalho Chehab wrote:
> > Em Mon, 19 Sep 2016 13:50:25 +0300
> > Sakari Ailus escreveu:
> >
> >> v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols
> >> are found by the
Em Mon, 19 Sep 2016 16:22:30 +0300
Sakari Ailus escreveu:
> Add a new variable STATIC_LDFLAGS to add the linker flags required for
> static linking for each binary built.
>
> Static and dynamic libraries are built by default but the binaries are
> otherwise linked dynamically. --with-static-bina
Hi Mauro,
On Mon, Sep 19, 2016 at 11:21:50AM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 16:22:30 +0300
> Sakari Ailus escreveu:
>
> > Add a new variable STATIC_LDFLAGS to add the linker flags required for
> > static linking for each binary built.
> >
> > Static and dynamic librar
On 03/08/16 19:03, Steve Longerbeam wrote:
Steve Longerbeam (8):
media: adv7180: fix field type
media: adv7180: define more registers
media: adv7180: add support for NEWAVMODE
media: adv7180: add power pin control
media: adv7180: implement g_parm
media: adv7180: change mbus format t
Em Mon, 19 Sep 2016 13:36:55 +0200
Markus Heiser escreveu:
> Hi Mauro,
>
> sorry for my late reply (so much work to do) ..
>
> Am 09.09.2016 um 14:25 schrieb Markus Heiser :
>
> >> Using either this approach or my kernel-doc patch, I'm now getting
> >> only two warnings:
> >>
> >> 1) at medi
On 09/19/2016 04:19 PM, Jack Mitchell wrote:
>
>
> On 03/08/16 19:03, Steve Longerbeam wrote:
>> Steve Longerbeam (8):
>> media: adv7180: fix field type
>> media: adv7180: define more registers
>> media: adv7180: add support for NEWAVMODE
>> media: adv7180: add power pin control
>> medi
Changeset ab6343956f9c ("[media] V4L2: Add documentation for SDI timings
and related flags") added documentation for new V4L2 defines, but
it forgot to update videodev2.h.rst.exceptions to point to where
the documentation for those new values will be inside the book,
causing those warnings:
Do
WARNING: line over 80 characters
+GS_HEIGHT_MAX, GS_PIXELCLOCK_MIN,
GS_PIXELCLOCK_MAX,
WARNING: line over 80 characters
+ if (v4l2_match_dv_timings(timings, ®_fmt[i].format, 0,
false))
WARNING: Block comments use a trailing */ on a separate line
+
On 09/19/2016 07:32 PM, Mauro Carvalho Chehab wrote:
> Changeset ab6343956f9c ("[media] V4L2: Add documentation for SDI timings
> and related flags") added documentation for new V4L2 defines, but
> it forgot to update videodev2.h.rst.exceptions to point to where
> the documentation for those new va
Em Wed, 14 Sep 2016 02:16:59 +0300
Laurent Pinchart escreveu:
> Cropping on the WPF sink pad restricts the left and top coordinates to
> 0-255. The same result can be obtained by cropping on the RPF without
> any such restriction, this feature isn't useful. Disable it.
>
> Signed-off-by: Laurent
Hi Mauro,
On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu:
> > Cropping on the WPF sink pad restricts the left and top coordinates to
> > 0-255. The same result can be obtained by cropping on the RPF without
> > any such re
I'm going to have quite constrained time for participation in this
driver development, but still I think this is perspective project which
is in line with trend of exposing internal details of complex media
hardware for configuration by V4L2 framework. Also tw286x are used in
both tw5864 and solo6x
Em Mon, 19 Sep 2016 20:59:56 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> > Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu:
> > > Cropping on the WPF sink pad restricts the left and top coordinates to
> > > 0-255.
Several multi-line comments added at the vsp1 patch series
violate the Kernel CodingStyle. Fix them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vsp1/vsp1_bru.c| 3 ++-
drivers/media/platform/vsp1/vsp1_clu.c| 3 ++-
drivers/media/platform/vsp1/vsp1_dl.c | 21 +++
Hi Mauro,
On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu:
> > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> >> Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu:
> >>> Cropping on the WPF sink pa
Hi Mauro,
Thank you for the patch.
On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote:
> Several multi-line comments added at the vsp1 patch series
> violate the Kernel CodingStyle. Fix them.
>
> Signed-off-by: Mauro Carvalho Chehab
I prefer the current style but that seems to be a hop
Em Mon, 19 Sep 2016 21:33:13 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote:
> > Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu:
> > > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote:
> > >> Em Wed, 14 Sep
Em Mon, 19 Sep 2016 21:35:36 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> Thank you for the patch.
>
>
> On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote:
> > Several multi-line comments added at the vsp1 patch series
> > violate the Kernel CodingStyle. Fix them.
> >
> > Signed-o
On Sun, 18 Sep 2016, Hans Verkuil wrote:
Fix a regression caused by commit 2bc46b3a (media/pci: convert drivers to use
the
new vb2_queue dev field). Three places where q->dev should be set were missed,
causing
a WARN.
Signed-off-by: Hans Verkuil
Reported-by: Marton Balint
---
Tested-by:
Hi,
On Thu, Sep 15, 2016 at 02:22:16PM +0300, Sakari Ailus wrote:
> Define the number of pads explicitly in initialising the sub-devices.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, Sep 15, 2016 at 02:22:15PM +0300, Sakari Ailus wrote:
> Simplify smiapp_init() by moving the initialisation of individual
> sub-devices to a separate function.
Reviewed-By: Sebastian Reichel
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 108
>
Hi,
On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote:
> Remove the loop in sub-device registration and create each sub-device
> explicitly instead.
Reviewed-By: Sebastian Reichel
> +static int smiapp_register_subdevs(struct smiapp_sensor *sensor)
> +{
> + int rval;
> +
> + i
Hi,
On Thu, Sep 15, 2016 at 02:22:19PM +0300, Sakari Ailus wrote:
> The same pixel array size is required for the active format of each
> sub-device sink pad and try format of each sink pad of each opened file
> handle as well as for the native size rectangle.
Reviewed-By: Sebastian Reichel
--
Hi,
On Thu, Sep 15, 2016 at 02:22:20PM +0300, Sakari Ailus wrote:
> Instead, calculate how much is needed and then allocate the memory
> dynamically.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
> "Christoph" == Christoph Hellwig writes:
Christoph> Switch the ipr driver to use pci_alloc_irq_vectors. We need
Christoph> to two calls to pci_alloc_irq_vectors as ipr only supports
Christoph> multiple MSI-X vectors, but not multiple MSI vectors.
Christoph> Otherwise this cleans up a lot
> "Christoph" == Christoph Hellwig writes:
Christoph> Switch the arcmsr driver to use pci_alloc_irq_vectors. We
Christoph> need to two calls to pci_alloc_irq_vectors as arcmsr only
Christoph> supports multiple MSI-X vectors, but not multiple MSI
Christoph> vectors.
Christoph> Otherwise this
Hi Sebastian,
Sebastian Reichel wrote:
Hi,
On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote:
Remove the loop in sub-device registration and create each sub-device
explicitly instead.
Reviewed-By: Sebastian Reichel
Thanks!
+static int smiapp_register_subdevs(struct smiapp_s
Hi Sebastian,
Thank you for the review!
Sebastian Reichel wrote:
Hi,
On Thu, Sep 15, 2016 at 02:22:15PM +0300, Sakari Ailus wrote:
Simplify smiapp_init() by moving the initialisation of individual
sub-devices to a separate function.
Reviewed-By: Sebastian Reichel
Signed-off-by: Sakari Ai
Hi,
On Thu, Sep 15, 2016 at 02:22:21PM +0300, Sakari Ailus wrote:
> Initialise the sensor in probe. The reason why it wasn't previously done
> in case of platform data was that the probe() of the driver that provided
> the clock through the set_xclk() callback would need to finish before the
> pro
Hi,
On Mon, Sep 19, 2016 at 11:50:02PM +0300, Sakari Ailus wrote:
> Hi Sebastian,
>
> Sebastian Reichel wrote:
> > Hi,
> >
> > On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote:
> > > Remove the loop in sub-device registration and create each sub-device
> > > explicitly instead.
> >
Hi,
On Thu, Sep 15, 2016 at 02:22:22PM +0300, Sakari Ailus wrote:
> The smiapp_probe() is the sole caller of smiapp_init(). Unify the two.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Sebastian Reichel wrote:
Hi,
On Thu, Sep 15, 2016 at 02:22:21PM +0300, Sakari Ailus wrote:
Initialise the sensor in probe. The reason why it wasn't previously done
in case of platform data was that the probe() of the driver that provided
the clock through the set_xclk() callback would need to f
Hi,
On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote:
> The information gathered during frame format reading will be required
> earlier in the initialisation when it was available. Also return an error
> if frame format cannot be obtained.
>
> Signed-off-by: Sakari Ailus
> ---
> dri
Hi,
On Thu, Sep 15, 2016 at 02:22:25PM +0300, Sakari Ailus wrote:
> Replace plain value 2 with SMIAPP_PADS when referring to the number of
> pads.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, Sep 15, 2016 at 02:22:24PM +0300, Sakari Ailus wrote:
> The initialisation of the source sub-device is somewhat different as it's
> not created by the smiapp driver itself. Remove redundancy in initialising
> the two kind of sub-devices.
Reviewed-By: Sebastian Reichel
-- Sebastian
Hi Sebastian,
Sebastian Reichel wrote:
Hi,
On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote:
The information gathered during frame format reading will be required
earlier in the initialisation when it was available. Also return an error
if frame format cannot be obtained.
Signed-o
Hi,
On Thu, Sep 15, 2016 at 02:22:26PM +0300, Sakari Ailus wrote:
> Besides the image data, SMIA++ compliant sensors also provide embedded
> data in form of registers used to capture the image. Store this
> information for later use in frame descriptor and routing.
Reviewed-By: Sebastian Reichel
Hi,
On Tue, Sep 20, 2016 at 12:19:54AM +0300, Sakari Ailus wrote:
> Hi Sebastian,
>
> Sebastian Reichel wrote:
> > Hi,
> >
> > On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote:
> > > The information gathered during frame format reading will be required
> > > earlier in the initialisa
Hi,
On Thu, Sep 15, 2016 at 02:22:27PM +0300, Sakari Ailus wrote:
> Provide more debugging information on reading the frame layout.
>
> [...]
>
> @@ -130,7 +127,7 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor
> *sensor)
> pixels = desc & SMIAPP_FRAME_FORMAT_DESC_
Hi,
On Thu, Sep 15, 2016 at 02:22:28PM +0300, Sakari Ailus wrote:
> The code probably has been unindented at some point but rewrapping has not
> been done. Do it now.
>
> Also remove a useless memory allocation failure message.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Descri
Hi,
On Thu, Sep 15, 2016 at 02:22:29PM +0300, Sakari Ailus wrote:
> The media bus code obtained for try format may have been a code that the
> sensor did not even support. Use a supported code with the current pixel
> order.
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Descriptio
Hi,
On Thu, Sep 15, 2016 at 02:22:30PM +0300, Sakari Ailus wrote:
> The first time the sensor is powered on, the information is not yet
> available.
>
> Signed-off-by: Sakari Ailus
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, Sep 15, 2016 at 02:22:31PM +0300, Sakari Ailus wrote:
> Don't complain about a failure to compute the pre_pll divisor. The
> function is used to determine whether a particular combination of bits per
> sample value and a link frequency can be used, in which case there are
> lots of unn
Simplify smiapp_init() by moving the initialisation of individual
sub-devices to a separate function.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 110 +++--
1 file changed, 51 insertions(+), 59 deletions(-)
diff --git a/drivers/media/i2c/
Hi,
On Thu, Sep 15, 2016 at 02:22:17PM +0300, Sakari Ailus wrote:
> This allows determining the number of pads in the entity based on the
> sensor.
>
> Signed-off-by: Sakari Ailus
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Hi,
This set further cleans up the smiapp driver and prepares for later
changes.
since v2:
- Fix badly formatted debug message on wrong frame format model type
- Add a debug message on faulty frame descriptor (image data lines are
among embedded data lines)
- Fix error handling in registered
Define the number of pads explicitly in initialising the sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/s
The smiapp_probe() is the sole caller of smiapp_init(). Unify the two.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 423 -
1 file changed, 204 insertions(+), 219 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drive
Instead, calculate how much is needed and then allocate the memory
dynamically.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 24 ++--
drivers/media/i2c/smiapp/smiapp.h | 8 ++--
2 files changed, 20 insertions(+), 12 deletions(-)
diff --g
The code probably has been unindented at some point but rewrapping has not
been done. Do it now.
Also remove a useless memory allocation failure message.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 33 +
1 file changed, 13 insertions(
The media bus code obtained for try format may have been a code that the
sensor did not even support. Use a supported code with the current pixel
order.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/d
Besides the image data, SMIA++ compliant sensors also provide embedded
data in form of registers used to capture the image. Store this
information for later use in frame descriptor and routing.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 46 +++---
The first time the sensor is powered on, the information is not yet
available.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiapp-core.c
index 5f
Replace plain value 2 with SMIAPP_PADS when referring to the number of
pads.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp.h
b/drivers/media/i2c/smiapp/smiapp.h
index e712
Don't complain about a failure to compute the pre_pll divisor. The
function is used to determine whether a particular combination of bits per
sample value and a link frequency can be used, in which case there are
lots of unnecessary driver messages. During normal operation the failure
generally doe
Provide more debugging information on reading the frame layout.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/smiap
The same pixel array size is required for the active format of each
sub-device sink pad and try format of each sink pad of each opened file
handle as well as for the native size rectangle.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 39 +--
The information gathered during frame format reading will be required
earlier in the initialisation when it was available. Also return an error
if frame format cannot be obtained.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 8 ++--
1 file changed, 6 insertions(+)
Remove the loop in sub-device registration and create each sub-device
explicitly instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 82 +++---
1 file changed, 45 insertions(+), 37 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiap
If the registered() callback failed, resources were left unaccounted for.
Fix this, as well as add unregistering the sub-devices in driver
unregistered() callback.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 22 +-
1 file changed, 21 insertions(+)
The initialisation of the source sub-device is somewhat different as it's
not created by the smiapp driver itself. Remove redundancy in initialising
the two kind of sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 5 +
1 file changed, 1 insertion(+), 4 de
This allows determining the number of pads in the entity based on the
sensor.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c/smiapp/s
Initialise the sensor in probe. The reason why it wasn't previously done
in case of platform data was that the probe() of the driver that provided
the clock through the set_xclk() callback would need to finish before the
probe() function of the smiapp driver. The set_xclk() callback no longer
exist
When sending a pulse-space file with consecutive spaces or pulses, add them
together correctly. For example:
pulse 100
space 150
space 100
pulse 150
pulse 200
Would send pulse 100, space 250, and pulse 350.
Signed-off-by: Sean Young
---
utils/ir-ctl/ir-ctl.c | 4 ++--
1 file changed, 2 inserti
The hardware does not decode the 16, 20 or 24 bit variety.
Signed-off-by: Sean Young
---
drivers/media/i2c/ir-kbd-i2c.c | 90 ++--
drivers/media/pci/cx18/cx18-i2c.c| 3 +-
drivers/media/pci/cx88/cx88-input.c | 3 +-
drivers/media/pci/i
If a transmitter does not exist when setting using -e, you get the error:
warning: /dev/lirc0: failed to set send transmitters: Success
Signed-off-by: Sean Young
---
utils/ir-ctl/ir-ctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl
When reporting decoded protocol use the enum rather than the bitmap.
Signed-off-by: Sean Young
---
drivers/media/rc/ir-rc6-decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/rc/ir-rc6-decoder.c
b/drivers/media/rc/ir-rc6-decoder.c
index e0e2ede..5cc54
Hi,
On Fri, Sep 16, 2016 at 01:53:29AM +0300, Sakari Ailus wrote:
> [...]
>
> diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c
> b/drivers/media/i2c/smiapp/smiapp-regs.c
> index 1e501c0..a9c7baf 100644
> --- a/drivers/media/i2c/smiapp/smiapp-regs.c
> +++ b/drivers/media/i2c/smiapp/smiapp-regs.
Hi,
On Thu, Sep 15, 2016 at 02:29:21PM +0300, Sakari Ailus wrote:
> Delay suspending the device by 1000 ms by default.
>
> Signed-off-by: Sakari Ailus
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, Sep 15, 2016 at 02:29:19PM +0300, Sakari Ailus wrote:
> Use the suspend and resume ops for freeze, thaw, poweroff and restore
> callbacks as well.
>
> Signed-off-by: Sakari Ailus
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Thu, Sep 15, 2016 at 02:29:18PM +0300, Sakari Ailus wrote:
> The dev field of the v4l2_subdev was left NULL for the pixel array and
> binner sub-devices. Fix this.
>
> Signed-off-by: Sakari Ailus
Reviewed-By: Sebastian Reichel
-- Sebastian
signature.asc
Description: PGP signature
Hi,
On Tue, Sep 20, 2016 at 01:02:33AM +0300, Sakari Ailus wrote:
> This set further cleans up the smiapp driver and prepares for
> later changes.
>
> since v2:
>
> - Fix badly formatted debug message on wrong frame format model type
>
> - Add a debug message on faulty frame descriptor (image d
Hi people,
In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a
null pointer dereference at line 1480.
Code in the function "static int init_channel(struct ngene_channel *chan)"
==
if (io & NGENE_IO_TSIN) {
chan->fe = NULL;
Hello all media staff
Dear Mr.Verkuil
Dear Mr.Osciak
I talked with Nicolas and Mr.ceyusa in the yesterday and early morning
of today.
I think I have made them get the situation of state-less Video
Acceleration Unit(VPU) and Rockchip for VA-API driver. We both agree
that creating a new C API
On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux
wrote:
> Hi people,
>
> In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a
> null pointer dereference at line 1480.
>
> Code in the function "static int init_channel(struct ngene_channel *chan)"
> ==
On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux
wrote:
> Hi people,
>
> In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a
> null pointer dereference at line 1480.
>
> Code in the function "static int init_channel(struct ngene_channel *chan)"
> ==
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Sep 20 04:00:17 CEST 2016
git branch: test
git hash: 142a0e11b52c18a82c4fe55132b762005dda05c0
gcc versi
Hi Mauro,
On Monday 19 Sep 2016 16:10:31 Mauro Carvalho Chehab wrote:
> Em Mon, 19 Sep 2016 21:35:36 +0300 Laurent Pinchart escreveu:
> > On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote:
> >> Several multi-line comments added at the vsp1 patch series
> >> violate the Kernel CodingStyle.
96 matches
Mail list logo