Re: Chroma gain configuration

2010-02-24 Thread Devin Heitmueller
On Tue, Feb 23, 2010 at 2:53 AM, Hans Verkuil hverk...@xs4all.nl wrote: Control enumeration is actually working fine.  The queryctrl does properly return all of the controls, including my new private control. OK. So the problem is that v4l2-ctl uses G/S_EXT_CTRLS for non-user controls, right?

Re: Chroma gain configuration

2010-02-23 Thread Andy Walls
On Tue, 2010-02-23 at 08:53 +0100, Hans Verkuil wrote: On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: Of course, if you and Mauro wanted to sign off on the creation of a new non-private user control

Re: Chroma gain configuration

2010-02-23 Thread Devin Heitmueller
On Tue, Feb 23, 2010 at 2:53 AM, Hans Verkuil hverk...@xs4all.nl wrote: OK. So the problem is that v4l2-ctl uses G/S_EXT_CTRLS for non-user controls, right? Why not change v4l2-ctl: let it first try the EXT version but if that fails with EINVAL then try the old control API. Well, that's what

Re: Chroma gain configuration

2010-02-23 Thread Andy Walls
On Tue, 2010-02-23 at 15:41 +0100, Hans Verkuil wrote: On Tue, 2010-02-23 at 08:53 +0100, Hans Verkuil wrote: On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: Of course, if you and Mauro wanted to

Re: Chroma gain configuration

2010-02-23 Thread Andy Walls
On Tue, 2010-02-23 at 10:33 -0500, Andy Walls wrote: On Tue, 2010-02-23 at 15:41 +0100, Hans Verkuil wrote: On Tue, 2010-02-23 at 08:53 +0100, Hans Verkuil wrote: On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil

My TV's standard video controls (Re: Chroma gain configuration)

2010-02-23 Thread Andy Walls
On Tue, 2010-02-23 at 10:33 -0500, Andy Walls wrote: On Tue, 2010-02-23 at 15:41 +0100, Hans Verkuil wrote: On Tue, 2010-02-23 at 08:53 +0100, Hans Verkuil wrote: On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil

Re: Chroma gain configuration

2010-02-22 Thread Frej Drejhammar
I'm asking because it seems a bit strange that someone would introduce a v4l2 standard control to disable the AGC but not have the ability to manually set the gain once it was disabled. As the person who introduced V4L2_CID_CHROMA_AGC for cx2388x I can explain that part. The AGC was actually

Re: Chroma gain configuration

2010-02-22 Thread Andy Walls
On Sun, 2010-02-21 at 23:07 -0500, Devin Heitmueller wrote: I am doing some work on the saa711x driver, and ran into a case where I need to disable the chroma AGC and manually set the chroma gain. Sakari, Hans, or anyone else, On a somewhat related note, what is the status of the media

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
Thanks everybody for the feedback. On Mon, Feb 22, 2010 at 7:15 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: The issue with cx88 chips is that, with some video input sources, the AGC over-saturates the color pattern. So, depending on the analog video standard and the quality of the

Re: Chroma gain configuration

2010-02-22 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: Thanks everybody for the feedback. On Mon, Feb 22, 2010 at 7:15 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: The issue with cx88 chips is that, with some video input sources, the AGC over-saturates the color pattern. So, depending on the analog video

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
On Mon, Feb 22, 2010 at 8:40 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I think that the control you want is V4L2_CID_GAIN. I would have guessed the CID_GAIN control would have been responsible for *luma* gain. I could be wrong about that of course (but that is what I believe people

Re: Chroma gain configuration

2010-02-22 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 8:40 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I think that the control you want is V4L2_CID_GAIN. I would have guessed the CID_GAIN control would have been responsible for *luma* gain. I could be wrong about that of course (but

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
On Mon, Feb 22, 2010 at 8:58 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Ok then.  I'll add the 15-20 lines of code which add the extended controls mechanism to the 7115, which just operates as a passthrough for the older control interface. The better is to do the opposite: extended

Re: Chroma gain configuration

2010-02-22 Thread Mauro Carvalho Chehab
Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 8:58 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Ok then. I'll add the 15-20 lines of code which add the extended controls mechanism to the 7115, which just operates as a passthrough for the older control interface. The better is to

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
On Mon, Feb 22, 2010 at 4:32 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Devin Heitmueller wrote: In fact, I would be in favor of taking the basic logic found in cx18_g_ext_ctrls(), and making that generic to the videodev interface, such that any driver which provides a user control

Re: Chroma gain configuration

2010-02-22 Thread Hans Verkuil
On Monday 22 February 2010 22:17:24 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 8:58 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Ok then. I'll add the 15-20 lines of code which add the extended controls mechanism to the 7115, which just operates as a passthrough for the older

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
On Mon, Feb 22, 2010 at 4:41 PM, Hans Verkuil hverk...@xs4all.nl wrote: I am still planning to continue my work for a general control handling framework. I know how to do it and it's just time that I lack. Converting all drivers to support the extended control API is quite complicated since

Re: Chroma gain configuration

2010-02-22 Thread Hans Verkuil
On Monday 22 February 2010 22:38:56 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:32 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Devin Heitmueller wrote: In fact, I would be in favor of taking the basic logic found in cx18_g_ext_ctrls(), and making that generic to the videodev

Re: Chroma gain configuration

2010-02-22 Thread Devin Heitmueller
On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: Ah, that's another matter. The original approach for handling private controls is seriously flawed. Drivers that want to use private controls are strongly encouraged to use the extended control mechanism for them, and to

Re: Chroma gain configuration

2010-02-22 Thread Sakari Ailus
Andy Walls wrote: On Sun, 2010-02-21 at 23:07 -0500, Devin Heitmueller wrote: I am doing some work on the saa711x driver, and ran into a case where I need to disable the chroma AGC and manually set the chroma gain. Sakari, Hans, or anyone else, Hi Andy, On a somewhat related note, what is

Re: Chroma gain configuration

2010-02-22 Thread Hans Verkuil
On Monday 22 February 2010 23:00:32 Devin Heitmueller wrote: On Mon, Feb 22, 2010 at 4:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: Ah, that's another matter. The original approach for handling private controls is seriously flawed. Drivers that want to use private controls are strongly

Chroma gain configuration

2010-02-21 Thread Devin Heitmueller
I am doing some work on the saa711x driver, and ran into a case where I need to disable the chroma AGC and manually set the chroma gain. I see there is an existing boolean control called V4L2_CID_CHROMA_AGC, which would be the logical candidate for allowing the user to disable the chroma AGC.