Re: [PATCH v4 2/5] media: ov2640: add async probe function

2015-01-01 Thread Laurent Pinchart
Hi Josh, On Tuesday 30 December 2014 18:02:23 Josh Wu wrote: On 12/30/2014 8:15 AM, Laurent Pinchart wrote: On Monday 29 December 2014 16:28:02 Josh Wu wrote: On 12/26/2014 6:06 PM, Laurent Pinchart wrote: On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2015-01-01 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 30 December 2014 13:12:27 Guennadi Liakhovetski wrote: On Tue, 30 Dec 2014, Josh Wu wrote: [snip] And until omap1 is in the mainline we cannot drop v4l2_clk. s/until/as lonh as/ So I think the better way right now for ov2640 driver is still request both

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Guennadi Liakhovetski
Hi Laurent, First of all, sorry, I am currently on a holiday, so, replies are delayed, real work (reviewing or anything else) is impossible. On Tue, 30 Dec 2014, Laurent Pinchart wrote: Hi Guennadi, On Friday 26 December 2014 11:38:11 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014,

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 30 December 2014 09:36:31 Guennadi Liakhovetski wrote: Hi Laurent, First of all, sorry, I am currently on a holiday, so, replies are delayed, real work (reviewing or anything else) is impossible. Sure, no worries. Enjoy your holidays without thinking too much about

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Josh Wu
Hi, Laurent On 12/30/2014 8:15 AM, Laurent Pinchart wrote: Hi Josh, On Monday 29 December 2014 16:28:02 Josh Wu wrote: On 12/26/2014 6:06 PM, Laurent Pinchart wrote: On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Josh Wu
Hi, Guennadi On 12/30/2014 4:36 PM, Guennadi Liakhovetski wrote: Hi Laurent, First of all, sorry, I am currently on a holiday, so, replies are delayed, real work (reviewing or anything else) is impossible. Thanks for your review in holiday. That's very helpful. On Tue, 30 Dec 2014, Laurent

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-30 Thread Guennadi Liakhovetski
On Tue, 30 Dec 2014, Josh Wu wrote: [snip] And until omap1 is in the mainline we cannot drop v4l2_clk. s/until/as lonh as/ So I think the better way right now for ov2640 driver is still request both the v4l2_clock: mclk, and the clock: xvclk in probe(). In that way, we can take our time

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-29 Thread Josh Wu
Hi, Laurent and Guennadi On 12/26/2014 6:06 PM, Laurent Pinchart wrote: Hi Guennadi, On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-29 Thread Laurent Pinchart
Hi Josh, On Monday 29 December 2014 16:28:02 Josh Wu wrote: On 12/26/2014 6:06 PM, Laurent Pinchart wrote: On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-29 Thread Laurent Pinchart
Hi Guennadi, On Friday 26 December 2014 11:38:11 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote:

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Laurent Pinchart
Hi Josh, On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22 Dec 2014, Josh Wu wrote: On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014, Josh Wu wrote: On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote:

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 26 Dec 2014, Laurent Pinchart wrote: Hi Josh, On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22 Dec 2014, Josh Wu wrote: On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014,

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Laurent Pinchart
Hi Guennadi, On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22 Dec 2014, Josh Wu wrote: On 12/20/2014 6:16 AM,

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-26 Thread Guennadi Liakhovetski
On Fri, 26 Dec 2014, Laurent Pinchart wrote: Hi Guennadi, On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote: On Fri, 26 Dec 2014, Laurent Pinchart wrote: On Friday 26 December 2014 14:37:14 Josh Wu wrote: On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: On Mon, 22

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-25 Thread Josh Wu
Hi, Guennadi Thanks for the reply. And Merry Christmas and happy new year. On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote: Hi Josh, On Mon, 22 Dec 2014, Josh Wu wrote: Hi, Guennadi On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014, Josh Wu wrote: Hi, Guennadi

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-24 Thread Guennadi Liakhovetski
Hi Josh, On Mon, 22 Dec 2014, Josh Wu wrote: Hi, Guennadi On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014, Josh Wu wrote: Hi, Guennadi Thanks for the review. On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-22 Thread Josh Wu
Hi, Guennadi On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote: On Fri, 19 Dec 2014, Josh Wu wrote: Hi, Guennadi Thanks for the review. On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for your patches! On Thu, 18 Dec 2014, Josh Wu wrote: To support async probe for

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-19 Thread Guennadi Liakhovetski
On Fri, 19 Dec 2014, Josh Wu wrote: Hi, Guennadi Thanks for the review. On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for your patches! On Thu, 18 Dec 2014, Josh Wu wrote: To support async probe for ov2640, we need remove the code to get 'mclk' in

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-18 Thread Guennadi Liakhovetski
Hi Josh, Thanks for your patches! On Thu, 18 Dec 2014, Josh Wu wrote: To support async probe for ov2640, we need remove the code to get 'mclk' in ov2640_probe() function. oterwise, if soc_camera host is not probed in the moment, then we will fail to get 'mclk' and quit the ov2640_probe()

Re: [PATCH v4 2/5] media: ov2640: add async probe function

2014-12-18 Thread Josh Wu
Hi, Guennadi Thanks for the review. On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote: Hi Josh, Thanks for your patches! On Thu, 18 Dec 2014, Josh Wu wrote: To support async probe for ov2640, we need remove the code to get 'mclk' in ov2640_probe() function. oterwise, if soc_camera host is