Re: [ndctl PATCH v2 3/4] ndctl: add a new command - inject-smart

2018-02-08 Thread Dan Williams
On Thu, Feb 8, 2018 at 9:34 PM, Vishal Verma wrote: > Add an inject-smart command to ndctl to allow injection of smart fields, > and setting of smart thresholds. If a field is injected that breaches > the threshold, or sets a fatal flag, or if a new threshold is set that

[ndctl PATCH v2 1/4] ndctl, inject-error: error out for a non-existent namespace

2018-02-08 Thread Vishal Verma
When an invalid namespace was specified, inject-error would simply walk through a loop trying to matching namespace, and at the end, exit out silently. This could make it look as though the operation had been successful, when in reality, nothing had been done. Fix to print a message, and exit

[ndctl PATCH v2 2/4] ndctl: add ndctl_encode_smart_temperature()

2018-02-08 Thread Vishal Verma
This provides for encoding of a human-readable temperature value into the format expected by the smart command Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/lib/libndctl.c | 16 ndctl/lib/libndctl.sym | 1 +

[ndctl PATCH v2 4/4] ndctl, bash-completion: Add bash completion for inject-smart

2018-02-08 Thread Vishal Verma
This adds bash completion for the enw ndctl inject-smart command. non-option arguments are completed with dimms, and new options requiring data are marked as such. Cc: Dan Williams Signed-off-by: Vishal Verma --- contrib/ndctl | 12

[ndctl PATCH v2 3/4] ndctl: add a new command - inject-smart

2018-02-08 Thread Vishal Verma
Add an inject-smart command to ndctl to allow injection of smart fields, and setting of smart thresholds. If a field is injected that breaches the threshold, or sets a fatal flag, or if a new threshold is set that causes the same effect, generate an acpi health even notification. Cc: Dan Williams

[PATCH v3 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX

2018-02-08 Thread Dave Jiang
In a situation where the rt_dev is DAX and data_dev is not DAX, if the user requests to remove the realtime flag via ioctl we can no longer support DAX for that file. Dynamic changing of S_DAX on the inode is not supported due to various complications in the existing implementation. Therefore

[PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-08 Thread Dave Jiang
The function return values are confusing with the way the function is named. We expect a true or false return value but it actually returns 0/-errno. This makes the code very confusing. Changing the return values to return a bool where if DAX is supported then return true and no DAX support

[PATCH v3 1/3] fs: allow per-device dax status checking for filesystems

2018-02-08 Thread Dave Jiang
From: Darrick J. Wong Refactor __bdev_dax_supported into a sb_dax_supported helper for single-bdev filesystems and a regular bdev_dax_supported that takes a bdev parameter. This enables multi-device filesystems like xfs to check that a dax device can work for the

[PATCH v3 0/3] minimal DAX support for XFS realtime device

2018-02-08 Thread Dave Jiang
Darrick, After reading the comments from you, Dave Chinner, and Dan, it looks like the dyanmic S_DAX flag support won't be coming or not any time soon at the least. Here are the the collection of patches so far to address yours and Dave C's comments for minimal support. Please let me know what

Re: [ndctl PATCH 3/4] ndctl: add a new command - inject-smart

2018-02-08 Thread Dan Williams
On Thu, Feb 8, 2018 at 1:04 PM, Vishal Verma wrote: > Add an inject-smart command to ndctl to allow injection of smart fields, > and setting of smart thresholds. If a field is injected that breaches > the threshold, or sets a fatal flag, or if a new threshold is set that

[PATCH v6] ndctl: add firmware update command option for ndctl

2018-02-08 Thread Dave Jiang
Adding option "update-firmware" to ndctl for update firmware support from Intel DSM v1.6. ndctl update-firmware takes an option of -f for a firmware binary and a -d for the DIMM name: ndctl update-firmware -d nmem0 -f new_firmware.bin Signed-off-by: Dave Jiang --- Fixed

[PATCH v4 1/2] libnvdimm, testing: Add emulation for smart injection commands

2018-02-08 Thread Vishal Verma
Add support for the smart injection command in the nvdimm unit test framework. This allows for directly injecting to smart fields and flags that are supported in the injection command. If the injected values are past the threshold, then an acpi notification is also triggered. Cc: Dan Williams

[PATCH v4 2/2] libnvdimm, testing: update the default smart ctrl_temperature

2018-02-08 Thread Vishal Verma
The default value for smart ctrl_temperature was the same as the threshold for ctrl_temperature. As a result, any arbitrary smart injection to the nfit_test dimm could cause this alarm to trigger and cause an acpi notification. Drop the default value to below the threshold, so that unrelated

Re: [PATCH v3] libnvdimm, testing: Add emulation for smart injection commands

2018-02-08 Thread Verma, Vishal L
On Thu, 2018-02-08 at 12:54 -0800, Dan Williams wrote: > On Thu, Feb 8, 2018 at 12:49 PM, Vishal Verma om> wrote: > > Add support for the smart injection command in the nvdimm unit test > > framework. This allows for directly injecting to smart fields and > > flags > >

[ndctl PATCH 2/4] ndctl: add ndctl_encode_smart_temperature()

2018-02-08 Thread Vishal Verma
This provides for encoding of a human-readable temperature value into the format expected by the smart command Cc: Dan Williams Signed-off-by: Vishal Verma --- ndctl/lib/libndctl.c | 16 ndctl/lib/libndctl.sym | 1 +

[ndctl PATCH 4/4] ndctl, bash-completion: Add bash completion for inject-smart

2018-02-08 Thread Vishal Verma
This adds bash completion for the enw ndctl inject-smart command. non-option arguments are completed with dimms, and new options requiring data are marked as such. Cc: Dan Williams Signed-off-by: Vishal Verma --- contrib/ndctl | 5 - 1

[ndctl PATCH 1/4] ndctl, inject-error: error out for a non-existent namespace

2018-02-08 Thread Vishal Verma
When an invalid namespace was specified, inject-error would simply walk through a loop trying to matching namespace, and at the end, exit out silently. This could make it look as though the operation had been successful, when in reality, nothing had been done. Fix to print a message, and exit

Re: [PATCH v3] libnvdimm, testing: Add emulation for smart injection commands

2018-02-08 Thread Dan Williams
On Thu, Feb 8, 2018 at 12:49 PM, Vishal Verma wrote: > Add support for the smart injection command in the nvdimm unit test > framework. This allows for directly injecting to smart fields and flags > that are supported in the injection command. If the injected values are

[PATCH v3] libnvdimm, testing: Add emulation for smart injection commands

2018-02-08 Thread Vishal Verma
Add support for the smart injection command in the nvdimm unit test framework. This allows for directly injecting to smart fields and flags that are supported in the injection command. If the injected values are past the threshold, then an acpi notification is also triggered. Also update the

[PATCH v2] libnvdimm, testing: Add emulation for smart injection commands

2018-02-08 Thread Vishal Verma
Add support for the smart injection command in the nvdimm unit test framework. This allows for directly injecting to smart fields and flags that are supported in the injection command. If the injected values are past the threshold, then an acpi notification is also triggered. Cc: Dan Williams

[no subject]

2018-02-08 Thread Automatic Email Delivery Software
The original message was received at Thu, 8 Feb 2018 22:40:15 +0800 from lists.01.org [63.188.95.85] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL From:"Automatic