[PATCH v4] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dave Jiang
Adding firmware output of firmware information when ndctl list -D -F is used. Components displayed are current firmware version, updated firmware version, and if a coldboot is required (firmware updated). Signed-off-by: Dave Jiang Tested-by: Jeff Moyer

Re: [PATCH v3] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 11:41 AM, Dave Jiang wrote: > Adding firmware output of firmware information when ndctl list -D -F is used. > Components displayed are current firmware version, updated firmware version, > and if a coldboot is required (firmware updated). > >

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 11:22 AM, Ross Zwisler wrote: > On Tue, Feb 13, 2018 at 03:54:04PM +0100, Christoph Hellwig wrote: >> Looks good: >> >> Reviewed-by: Christoph Hellwig >> >> Can you wire up your test cases for blktests? > > Is blktests really the

Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Ross Zwisler
On Tue, Feb 13, 2018 at 01:35:19PM -0700, Dave Jiang wrote: > > > On 02/13/2018 01:31 PM, Ross Zwisler wrote: > > On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: > >> The function return values are confusing with the way the function is > >> named. We expect a true or false return

Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Dave Jiang
On 02/13/2018 01:31 PM, Ross Zwisler wrote: > On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: >> The function return values are confusing with the way the function is >> named. We expect a true or false return value but it actually returns >> 0/-errno. This makes the code very

Re: [PATCH v3 2/3] dax: change bdev_dax_supported() to support boolean returns

2018-02-13 Thread Ross Zwisler
On Thu, Feb 08, 2018 at 05:38:19PM -0700, Dave Jiang wrote: > The function return values are confusing with the way the function is > named. We expect a true or false return value but it actually returns > 0/-errno. This makes the code very confusing. Changing the return values > to return a bool

Re: [PATCH v3] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Jeff Moyer
Dave Jiang writes: > Adding firmware output of firmware information when ndctl list -D -F is used. > Components displayed are current firmware version, updated firmware version, > and if a coldboot is required (firmware updated). > > Signed-off-by: Dave Jiang

[PATCH v3] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dave Jiang
Adding firmware output of firmware information when ndctl list -D -F is used. Components displayed are current firmware version, updated firmware version, and if a coldboot is required (firmware updated). Signed-off-by: Dave Jiang --- v3: - Fixed issue where it skips

Re: [PATCH v2] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dave Jiang
On 02/13/2018 12:03 PM, Jeff Moyer wrote: > Dave Jiang writes: > >> Adding firmware output of firmware information when ndctl list -D -F is used. >> Components displayed are current firmware version, updated firmware version, >> and if a coldboot is required (firmware

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Ross Zwisler
On Tue, Feb 13, 2018 at 03:54:04PM +0100, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > Can you wire up your test cases for blktests? Is blktests really the right place for this test? This failure is highly dependent on the configuration of the

Re: [PATCH v2] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 11:03 AM, Jeff Moyer wrote: > Dave Jiang writes: > >> Adding firmware output of firmware information when ndctl list -D -F is used. >> Components displayed are current firmware version, updated firmware version, >> and if a

Re: [PATCH v2] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Jeff Moyer
Dave Jiang writes: > Adding firmware output of firmware information when ndctl list -D -F is used. > Components displayed are current firmware version, updated firmware version, > and if a coldboot is required (firmware updated). So now I don't get any output if I run:

[PATCH v2] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Dave Jiang
Adding firmware output of firmware information when ndctl list -D -F is used. Components displayed are current firmware version, updated firmware version, and if a coldboot is required (firmware updated). Signed-off-by: Dave Jiang --- v2: - Added copyright - Added support

Re: [PATCH v2] libnvdimm: re-enable deep flush for pmem devices

2018-02-13 Thread Dan Williams
On Tue, Feb 13, 2018 at 5:17 AM, Jeff Moyer wrote: > Dan Williams writes: > >> On Mon, Feb 12, 2018 at 2:53 PM, Jeff Moyer wrote: >>> Dave Jiang writes: >>> Re-enable deep flush so that users always have

Re: [PATCH] loop: Fix lost writes caused by missing flag

2018-02-13 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig Can you wire up your test cases for blktests? ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [PATCH] ndctl: add option to list firmware information for a DIMM

2018-02-13 Thread Jeff Moyer
Hi, Dave, Dave Jiang writes: > Adding firmware output of firmware information when ndctl list -D -F is used. > Components displayed are current firmware version, updated firmware version, > and if a coldboot is required (firmware updated). > > Signed-off-by: Dave Jiang

Re: [PATCH v2] libnvdimm: re-enable deep flush for pmem devices

2018-02-13 Thread Jeff Moyer
Dan Williams writes: > On Mon, Feb 12, 2018 at 2:53 PM, Jeff Moyer wrote: >> Dave Jiang writes: >> >>> Re-enable deep flush so that users always have a way to be sure that a write >>> does make it all the way out to the NVDIMM.

Re: [RFC PATCH v3 2/5] ndctl: monitor: add ndctl create-monitor command

2018-02-13 Thread Yasunori Goto
> Hi, > > > On Fri, Feb 9, 2018 at 12:02 AM, QI Fuli wrote: > > > This patch is used to add $ndctl create-monitor command, by which users > > > can > > > create a new monitor. Users can select the DIMMS to be monitored by using > > > [--dimm] [--bus] [--region]

Re: [RFC PATCH v3 2/5] ndctl: monitor: add ndctl create-monitor command

2018-02-13 Thread Yasunori Goto
Hi, > On Fri, Feb 9, 2018 at 12:02 AM, QI Fuli wrote: > > This patch is used to add $ndctl create-monitor command, by which users can > > create a new monitor. Users can select the DIMMS to be monitored by using > > [--dimm] [--bus] [--region] [--namespace] options. The