Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-23 Thread J, KEERTHY
On Tue, Aug 23, 2011 at 9:48 AM, Rajendra Nayak rna...@ti.com wrote: On 8/23/2011 5:28 AM, Kevin Hilman wrote: Rajendra Nayakrna...@ti.com  writes: [...] FWIK, its a one time requirement to set the clock rate to the right rate the device can operate in based on what a platform supports.

Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [110821 08:11]: From: Tomi Valkeinen tomi.valkei...@ti.com Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset properly. Can you please add what this fixes so this can be justified as a fix? Add missing ick opt-clock for rfbi. Rfbi uses the

Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [110823 09:20]: * Paul Walmsley p...@pwsan.com [110821 08:11]: From: Tomi Valkeinen tomi.valkei...@ti.com Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset properly. Can you please add what this fixes so this can be justified as a

Re: [PATCH 1/5] OMAP2xxx: HWMOD: fix DSS opt clocks

2011-08-23 Thread Paul Walmsley
Hi Tomi, On Tue, 23 Aug 2011, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [110821 08:11]: From: Tomi Valkeinen tomi.valkei...@ti.com Set HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core to allow DSS reset properly. Can you please add what this fixes so this can be justified as a

Re: [PATCHv4 2/4] regulator: omap smps regulator driver

2011-08-23 Thread Liam Girdwood
On 22/08/11 23:39, Hilman, Kevin wrote: Liam Girdwood l...@ti.com writes: On 05/08/11 20:33, Hilman, Kevin wrote: Mark Brown broo...@opensource.wolfsonmicro.com writes: On Thu, Jul 28, 2011 at 02:48:57PM +0300, Tero Kristo wrote: OMAP SMPS regulator driver provides access to OMAP voltage

[GIT PULL v2] OMAP: clock/powerdomain/clockdomain/hwmod: fixes for 3.1-rc

2011-08-23 Thread Paul Walmsley
Hi Tony, The following changes since commit fcb8ce5cfe30ca9ca5c9a79cdfe26d1993e65e0c: Linux 3.1-rc3 (2011-08-22 11:42:53 -0700) are available in the git repository at: git://git.pwsan.com/linux-2.6 prcm-fixes-a-3.1rc I've dropped Tomi's patches until the changelogs for those are fixed.

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Sebastian Andrzej Siewior
* Paul Walmsley | 2011-08-22 23:10:21 [-0600]: IRQ handler type mismatch for IRQ 74 It turns out that the omap-serial code used one threaded IRQ handler[1][2] and one non-threaded IRQ handler[3] that shared the same IRQ. During the 3.1-rc series, a patch was merged[4] that caused IRQF_ONESHOT

Re: [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers

2011-08-23 Thread Rajendra Nayak
On 8/23/2011 10:33 AM, G, Manjunath Kondaiah wrote: Add omap4 soc dts file for handling omap4 soc i2c controllers existing on l4-core bus. Signed-off-by: G, Manjunath Kondaiahmanj...@ti.com --- arch/arm/boot/dts/omap4-panda.dts |7 +--- arch/arm/boot/dts/omap4.dtsi | 68

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Alan Cox
On Mon, 22 Aug 2011 23:10:21 -0600 (MDT) Paul Walmsley p...@pwsan.com wrote: Convert the omap-serial hardirq handler to a threaded IRQ handler. Without this patch, OMAP boards which use the on-board OMAP UARTs and the omap-serial driver will not boot to userspace after commit

Re: [RFC/PATCH v2 07/13] dt: omap: create platform bus for omap devices

2011-08-23 Thread Jamie Iles
Hi, This creates a build failure for non-omap platforms as they don't know about struct omap_device_pm_latency, struct omap_hwmod etc. An empty of_omap_device_create() as inline should do the trick. Jamie On Tue, Aug 23, 2011 at 10:03:35AM +0500, G, Manjunath Kondaiah wrote: The omap

Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified

2011-08-23 Thread Felipe Balbi
Hi, On Mon, Aug 22, 2011 at 05:45:06PM -0600, Paul Walmsley wrote: On Fri, 19 Aug 2011, Felipe Balbi wrote: On Thu, Aug 18, 2011 at 07:22:39PM +0200, Sebastian Andrzej Siewior wrote: Pantelis Antoniou wrote: Let me report that with this change Beagle board fails to boot, hangs

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Felipe Balbi
Hi, On Mon, Aug 22, 2011 at 11:10:21PM -0600, Paul Walmsley wrote: Convert the omap-serial hardirq handler to a threaded IRQ handler. Without this patch, OMAP boards which use the on-board OMAP UARTs and the omap-serial driver will not boot to userspace after commit

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-23 Thread Mark Brown
On Sun, Aug 21, 2011 at 08:05:53PM +0200, Rafael J. Wysocki wrote: On Sunday, August 21, 2011, Mark Brown wrote: I don't understand why the driver would need to know what situation it's in. I'd been working on the basis that the idea was that the driver said what the constraints it has

Re: [PATCH 3/4] drivers/usb/host/ohci-omap3.c: test the just-initialized value

2011-08-23 Thread Felipe Balbi
On Mon, Aug 22, 2011 at 04:00:35PM +0200, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk Test the just-initialized value rather than some other one. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier

Re: Passing camera module type using camera argument.

2011-08-23 Thread Laurent Pinchart
Hi Javier, On Tuesday 23 August 2011 12:16:16 javier Martin wrote: On 22 August 2011 18:15, Koen Kooi k...@beagleboard.org wrote: Op 22 aug. 2011, om 08:42 heeft javier Martin het volgende geschreven: On 19 August 2011 17:07, Koen Kooi k...@beagleboard.org wrote: Op 19 aug. 2011 om 14:39

[PATCH 0/9] OMAP: HWMOD: DSS patches

2011-08-23 Thread Tomi Valkeinen
These are the previously sent HWMOD patches split into smaller pieces and with improved commit messages. I'm not sure if these are strictly needed to be sent for -rc. The DSS patches 9ede365aa6f74428a1f69c21ca1cf21213167576 (HACK: OMAP: DSS2: clk hack for OMAP2/3) and

[PATCH 1/9] OMAP2xxx: HWMOD: Fix DSS reset

2011-08-23 Thread Tomi Valkeinen
DSS needs all DSS clocks to be enabled to be able to finish reset properly. Before v3.1-rc1 the omapdss driver was managing clocks and resets correctly. However, when omapdss started using runtime PM at v3.1-rc1, the responsibility for the reset moved to HWMOD framework. HWMOD framework does not

[PATCH 2/9] OMAP2xxx: HWMOD: fix DSS clock data

2011-08-23 Thread Tomi Valkeinen
The OMAP2xxx HWMOD data currently contains two errors with DSS clocks: - dss_rfbi is missing ick opt-clock, which is needed for RFBI to calculate timings - dss_venc's interface and main clocks are wrong, causing VENC to fail to start These problems were temporarily fixed with a DSS patch

[PATCH 3/9] OMAP3: HWMOD: Fix DSS reset

2011-08-23 Thread Tomi Valkeinen
DSS needs all DSS clocks to be enabled to be able to finish reset properly. Before v3.1-rc1 the omapdss driver was managing clocks and resets correctly. However, when omapdss started using runtime PM at v3.1-rc1, the responsibility for the reset moved to HWMOD framework. HWMOD framework does not

[PATCH 4/9] OMAP3: HWMOD: fix DSS clock data

2011-08-23 Thread Tomi Valkeinen
The OMAP3 HWMOD data currently contains these errors with DSS clocks: - dss_rfbi is missing ick opt-clock, which is needed for RFBI to calculate timings - dss_dsi is missing ick and sys_clk - dss_venc is missing dss_96m_fck opt-clock, which is required on OMAP3430 - dss_venc's interface

[PATCH 5/9] OMAP4: HWMOD: remove extra clocks

2011-08-23 Thread Tomi Valkeinen
Remove the dss_dss_clk from dss_core's opt-clocks. dss_dss_clk already defined as the dss main_clk, and thus is not needed as an opt-clock. Remove opt-clocks for dss_dispc, as dispc only uses the main_clk. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com ---

[PATCH 6/9] OMAP4: HWMOD: Add HWMOD_CONTROL_OPT_CLKS_IN_RESET for dss_core

2011-08-23 Thread Tomi Valkeinen
DSS needs all DSS clocks to be enabled to be able to finish reset properly. Before v3.1-rc1 the omapdss driver was managing clocks and resets correctly. However, when omapdss started using runtime PM at v3.1-rc1, the responsibility for the reset moved to HWMOD framework. HWMOD framework does not

[PATCH 7/9] OMAP4: HWMOD: fix DSS clock data

2011-08-23 Thread Tomi Valkeinen
The OMAP4 HWMOD data currently contains errors with DSS clocks: dss_hdmi and dss_venc have their main_clks wrong. The clocks should be dss_48mhz_clk and dss_tv_clk, respectively. These problems were temporarily fixed with the DSS patches 9ede365aa6f74428a1f69c21ca1cf21213167576 (HACK: OMAP:

[PATCH 8/9] OMAP2/3: HWMOD: Add SYSS_HAS_RESET_STATUS for dss

2011-08-23 Thread Tomi Valkeinen
OMAP2/3 dss_core has a reset status flag in sysstatus register. Add SYSS_HAS_RESET_STATUS flag to HWMOD data so it can be used. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Paul Walmsley p...@pwsan.com --- .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c |3 ++- 1

[PATCH 9/9] OMAP: HWMOD: Unify DSS resets for OMAPs

2011-08-23 Thread Tomi Valkeinen
This patch adds a custom DSS reset function used on OMAPs from OMAP2 forward. The function doesn't actually do a reset, it only waits for the reset to complete. The reason for this is that on OMAP4 there is no possibility to do a SW reset, and on OMAP2/3 doing a SW reset for dss_core resets all

[PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs

2011-08-23 Thread Janusz Krzysztofik
With commit f64ad1a0e21a, gpio/omap: cleanup _set_gpio_wakeup(), remove ifdefs, access to build time conditionally omitted 'suspend_wakeup' member of the 'gpio_bank' structure has been placed unconditionally in function _set_gpio_wakeup(), which is always built. This resulted in the driver

Re: [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com The gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this dependency from the driver by using list. Also remove the dependency on array of pointers to gpio_bank struct of all

Re: [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1

2011-08-23 Thread Cousson, Benoit
Hi Manju, Few minor comments about your subjects in this series. Patch series reworked from: http://permalink.gmane.org/gmane.linux.ports.arm.omap/61674 Also added support for i2c1 controller on omap4 based panda board. Baseline: = git://git.secretlab.ca/git/linux-2.6.git Branch:

Re: [PATCH v5 02/22] gpio/omap: use flag to identify wakeup domain

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com In omap3, save/restore context is implemented for GPIO banks 2-6 as GPIO bank1 is in wakeup domain. Instead of identifying bank's power domain by bank id, use 'loses_context' flag which is filled by

Re: [PATCH v5 03/22] gpio/omap: make gpio_context part of gpio_bank structure

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Currently gpio_context array used to save gpio bank's context, is used only for OMAP3 architecture. Move gpio_context as part of gpio_bank structure so that it can be specific to each gpio bank and

Re: [PATCH v5 04/22] gpio/omap: fix pwrdm_post_transition call sequence

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com The context lost count is modified in omap_sram_idle() path when pwrdm_post_transition() is called. But pwrdm_post_transition() is called only after omap_gpio_resume_after_idle() is called. Correct

Re: [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Modify omap_gpio_prepare_for_idle() omap_gpio_resume_after_idle() functions to handle save context restore context respectively in the OMAP GPIO driver itself instead of calling these functions

Re: [PATCH v5 06/22] gpio/omap: make non-wakeup GPIO part of pdata

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Non-wakeup GPIOs are available only in OMAP2. Avoid cpu_is checks by making non_wakeup_gpios as part of pdata. Signed-off-by: Charulatha Vch...@ti.com --- Nice !! Reviewed-by: Santosh Shilimkar

Re: [PATCH v5 07/22] gpio/omap: avoid cpu checks during module ena/disable

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Remove cpu-is checks while enabling/disabling OMAP GPIO module during a gpio request/free. Signed-off-by: Charulatha Vch...@ti.com --- Looks good. Reviewed-by: Santosh Shilimkar

Re: [PATCH v5 08/22] gpio/omap: further cleanup using wakeup_status register

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Wakeup istatus register offset initialized according to OMAP versions /s/ istatus / status during device registration. Use this to avoid version checks. Starting with OMAP4, legacy registers should not be used in combination

Re: [PATCH v5 09/22] gpio/omap: cleanup omap1 related macros

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com mpuio_init() function is defined under #ifdefs. It is required only in case of MPUIO bank type and only when PM operations are supported by it. This is applicable only in case of OMAP16xx SoC's MPUIO

Re: Fwd: [RFC/PATCH v2 11/13] dt: omap4: add generic board file for dt support

2011-08-23 Thread Cousson, Benoit
From: G, Manjunath Kondaiahmanj...@ti.com The generic board file is created and derived from omap4 panda board file. The changes here focus on minimal configuration to boot panda board with dt enabled which provides basic platform for converting device drivers for using dt. Signed-off-by: G,

Re: [PATCH v5 10/22] gpio/omap: use level/edge detect reg offsets

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: By adding level and edge detection register offsets and then initializing them correctly according to OMAP versions during device registrations we can now remove lot of revision checks in these functions. Signed-off-by: Tarun

Re: [PATCH v5 11/22] gpio/omap: remove hardcoded offsets in ctxt save/restore

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: It is not required to use hard-coded offsets any more in context save and restore functions and instead use the generic offsets which have been correctly initialized during device registration. Signed-off-by: Tarun Kanti

[PATCH v2 1/2] AM35x: Using OMAP3 generic hwmods

2011-08-23 Thread Abhilash K V
This patch enables AM35x SoCs to use generic OMAP3 hwmods (i,e. omap3xxx_hwmods) by allowing board-am3517evm.c to disable the modules which are not present in AM3517. Reviewed-by: Sanjeev Premi pr...@ti.com Signed-off-by: Abhilash K V abhilash...@ti.com --- arch/arm/mach-omap2/board-am3517evm.c

[PATCH v2 0/2] AM3517: Booting up

2011-08-23 Thread Abhilash K V
This patch-set gets the kernel booting up on a AM3517 EVM. The board is able to boot with ramdisk after this,but the MMC and Ethernet drivers are not up yet. Lots of warnings remain which will be addressed in subsequent patches. The patches are tested on master of tmlind/linux-omap-2.6.git.

[PATCH v2 2/2] omap_twl: Prevent SR to enable for am3517/am3505 devices

2011-08-23 Thread Abhilash K V
From: Vaibhav Hiremath hvaib...@ti.com In case of AM3517 AM3505, Smart Reflex is not applicable so we must not enable it. So add check for absence of SR feature in omap3_twl_init() and return -ENODEV if absence, else continue. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Signed-off-by:

Re: [PATCH v5 12/22] gpio/omap: cleanup set_gpio_triggering function

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Getting rid of ifdefs within the function by adding register offset intctrl and associating OMAP_GPIO_INT_CONTROL in respective SoC specific files. Also, use wkup_status register consistently instead of referring to wakeup

Re: [PATCH v5 13/22] gpio/omap: cleanup omap_gpio_mod_init function

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: With register offsets now defined for respective OMAP versions we can get rid of cpu_class_* checks. This function now has common initialization code for all OMAP versions. Initialization specific to OMAP16xx has been moved within

Re: [PATCH v5 14/22] gpio/omap: use pinctrl offset instead of macro

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Use regs-pinctrl field instead of using the macro OMAP1510_GPIO_PIN_CONTROL Signed-off-by: Charulatha Vch...@ti.com --- Ok. Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com Regards Santosh

RE: [PATCH v2 2/2] omap_twl: Prevent SR to enable for am3517/am3505devices

2011-08-23 Thread Vishwanath Sripathy
-Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux- arm-kernel-boun...@lists.infradead.org] On Behalf Of Abhilash K V Sent: Tuesday, August 23, 2011 6:51 PM To: linux-omap@vger.kernel.org Cc: p...@pwsan.com; li...@arm.linux.org.uk; b-cous...@ti.com;

Re: Fwd: [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers

2011-08-23 Thread Cousson, Benoit
From: G, Manjunath Kondaiahmanj...@ti.com To: devicetree-disc...@lists.ozlabs.org CC: linux-omap@vger.kernel.org, linux-arm-ker...@lists.infradead.org Add omap4 soc dts file for handling omap4 soc i2c controllers existing on l4-core bus. The subject and changelog is not accurate. You are

Re: [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API

2011-08-23 Thread Roedel, Joerg
On Wed, Aug 17, 2011 at 07:10:02PM -0400, Ohad Ben-Cohen wrote: +/** + * omap_iommu_attach() - attach iommu device to an iommu domain + * @dev: target omap iommu device + * @iopgd: page table **/ -struct iommu *iommu_get(const char *name) +static struct iommu

[POWER DOMAIN suspend callbacks] Observation.

2011-08-23 Thread Santosh
Rafael, Kevin, On latest kernel( V3.1-rc1+), the subsystem(driver) suspend callbacks are not getting called because power domain callbcaks are populated. And as per commit 4d27e9dc{PM: Make power domain callbacks take precedence over subsystem ones}, it's expected bahavior. Who is suppose to

Re: [PATCH v5 15/22] gpio/omap: use readl in irq_handler for all access

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Even when bank-width is 16, all the OMAP1 registers are 4-byte aligned, so just use a 4-byte read. The 'enabled' mask is already taking care to mask for bank width. Signed-off-by: Charulatha

Re: [PATCH 0/7] omap: iommu migration, relocation and cleanups

2011-08-23 Thread Roedel, Joerg
On Wed, Aug 17, 2011 at 07:10:01PM -0400, Ohad Ben-Cohen wrote: 1. Migrate OMAP's iommu driver to the generic IOMMU API, and move it to the dedicated iommu folder. 2. Fix omap3isp appropriately so it doesn't break. 3. Adapt OMAP's iovmm appropriately as well, because omap3isp still relies

Re: [PATCH v5 16/22] gpio/omap: remove bank-method METHOD_* macros

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com The only bank-type (method) used in the OMAP GPIO driver is MPUIO type as they need to be handled separately. Identify the same using a flag and remove all METHOD_* macros. Signed-off-by: Charulatha

Re: [PATCH v5 17/22] gpio/omap: fix bankwidth for OMAP7xx MPUIO

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com In all OMAP1 SoCs, the MPUIO bank width is 16 bits. But, in OMAP7xx, it is wrongly initialised to 32. Fix this. Signed-off-by: Charulatha Vch...@ti.com --- Looks like a proper BUG fix. Reviewed-by:

Re: [PATCH v5 18/22] gpio/omap: use pm-runtime framework

2011-08-23 Thread Santosh
+ Rajendra and Benoit to comment on optional clock handling. On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() for enabling/disabling clocks appropriately. Remove syscore_ops and instead use dev_pm_ops now.

Re: [PATCH v5 19/22] gpio/omap: optimize suspend and resume functions

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: There is no need to operate on all the banks every time the function is called. Just operate on the current bank passed by the framework. Signed-off-by: Tarun Kanti DebBarmatarun.ka...@ti.com --- Good. Reviewed-by: Santosh

Re: [PATCH v5 20/22] gpio/omap: cleanup prepare_for_idle and resume_after_idle

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Simplify omap2_gpio_prepare_for_idle() and omap2_gpio_resume_after_idle() /s /Simplify /Cleanup by moving most of the stuff to *_runtime_suspend() and *_runtime_resume(). Signed-off-by: Tarun Kanti DebBarmatarun.ka...@ti.com

Re: [PATCH v5 21/22] gpio/omap: skip operations in runtime callbacks

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Most operations within runtime callbacks should be skipped when *_runtime_get_sync() and *_runtime_put_sync() are called in probe(), *_gpio_request() and *_gpio_free(). We just need clock enable/disable. Signed-off-by: Tarun Kanti

Re: [PATCH v5 22/22] gpio/omap: remove omap_gpio_save_context overhead

2011-08-23 Thread Santosh
On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Context is now saved dynamically in respective functions whenever and whichever registers are modified. This avoid overhead of saving all registers context in the runtime callback. Signed-off-by: Tarun Kanti

Re: [PATCH] DMAEngine: Define generic transfer request api

2011-08-23 Thread Matt Porter
On Aug 19, 2011, at 9:43 AM, Koul, Vinod wrote: On Tue, 2011-08-16 at 15:06 +0200, Linus Walleij wrote: On Tue, Aug 16, 2011 at 2:56 PM, Koul, Vinod vinod.k...@intel.com wrote: Currently we have two approaches to solve this problem first being the DMA_STRIDE_CONFIG proposed by Linus W, I

Re: [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver

2011-08-23 Thread Santosh
On Tuesday 23 August 2011 06:23 PM, Santosh wrote: On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: From: Charulatha Vch...@ti.com Modify omap_gpio_prepare_for_idle() omap_gpio_resume_after_idle() functions to handle save context restore context respectively in the OMAP GPIO

Re: [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API

2011-08-23 Thread Ohad Ben-Cohen
On Tue, Aug 23, 2011 at 5:07 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Can this be easily converted to a spin_lock? Sure, thanks for reviewing. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [POWER DOMAIN suspend callbacks] Observation.

2011-08-23 Thread Govindraj
On Tue, Aug 23, 2011 at 7:49 PM, Santosh santosh.shilim...@ti.com wrote: Rafael, Kevin, On latest kernel( V3.1-rc1+), the subsystem(driver) suspend callbacks are not getting called because power domain callbcaks are populated. And as per commit 4d27e9dc{PM: Make power domain callbacks take

Re: [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers

2011-08-23 Thread G, Manjunath Kondaiah
On Tue, Aug 23, 2011 at 01:53:54PM +0530, Rajendra Nayak wrote: On 8/23/2011 10:33 AM, G, Manjunath Kondaiah wrote: Add omap4 soc dts file for handling omap4 soc i2c controllers existing on l4-core bus. Signed-off-by: G, Manjunath Kondaiahmanj...@ti.com ---

Re: [PATCH 0/7] omap: iommu migration, relocation and cleanups

2011-08-23 Thread Ohad Ben-Cohen
On Tue, Aug 23, 2011 at 5:26 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Besides the locking issue these patches look good to me. Please repost when this is solved and I will put it in my tree then. Great, thanks ! I'll do a quick re-spin with the collected comments and ACKs and repost. At

[PATCH] OMAP3EVM: ehci: Fix EHCI support

2011-08-23 Thread Bryan DE FARIA
Set the VAUX2 regulator supply to 1.8V for the HSUSB host interface. Gpio 2 of the TPS65950 has to be set to zero in order to enable the HSUBS2 clock. Signed-off-by: Bryan DE FARIA bdefa...@adeneo-embedded.com --- arch/arm/mach-omap2/board-omap3evm.c | 24 1 files

Re: Fwd: [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers

2011-08-23 Thread G, Manjunath Kondaiah
On Tue, Aug 23, 2011 at 03:48:15PM +0200, Cousson, Benoit wrote: From: G, Manjunath Kondaiahmanj...@ti.com To: devicetree-disc...@lists.ozlabs.org CC: linux-omap@vger.kernel.org, linux-arm-ker...@lists.infradead.org Add omap4 soc dts file for handling omap4 soc i2c controllers existing on

Re: [RFC/PATCH v2 07/13] dt: omap: create platform bus for omap devices

2011-08-23 Thread G, Manjunath Kondaiah
On Tue, Aug 23, 2011 at 10:07:05AM +0100, Jamie Iles wrote: Hi, This creates a build failure for non-omap platforms as they don't know about struct omap_device_pm_latency, struct omap_hwmod etc. An empty of_omap_device_create() as inline should do the trick. Thanks. I will introduce this.

Re: Fwd: [RFC/PATCH v2 11/13] dt: omap4: add generic board file for dt support

2011-08-23 Thread G, Manjunath Kondaiah
On Tue, Aug 23, 2011 at 03:05:01PM +0200, Cousson, Benoit wrote: From: G, Manjunath Kondaiahmanj...@ti.com The generic board file is created and derived from omap4 panda board file. The changes here focus on minimal configuration to boot panda board with dt enabled which provides basic

Re: [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1

2011-08-23 Thread G, Manjunath Kondaiah
On Tue, Aug 23, 2011 at 10:03:28AM +0500, G, Manjunath Kondaiah wrote: Patch series reworked from: http://permalink.gmane.org/gmane.linux.ports.arm.omap/61674 Also added support for i2c1 controller on omap4 based panda board. Baseline: = git://git.secretlab.ca/git/linux-2.6.git

Re: [RFC/PATCH v2 08/13] dt: omap: i2c: add dt support for i2c1 controller

2011-08-23 Thread G, Manjunath Kondaiah
Hi Grant, On Tue, Aug 23, 2011 at 10:03:36AM +0500, G, Manjunath Kondaiah wrote: The device tree support has been added to i2c1 controller and corresponding i2c initilization in generic board file is cleaned up so that platfom device is registered through dt and omap device and not through

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Linus Torvalds
On Tue, Aug 23, 2011 at 1:57 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Mon, 22 Aug 2011 23:10:21 -0600 (MDT) Paul Walmsley p...@pwsan.com wrote: Convert the omap-serial hardirq handler to a threaded IRQ handler. Without this patch, OMAP boards which use the on-board OMAP UARTs and the

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Thomas Gleixner
Linus, On Tue, 23 Aug 2011, Linus Torvalds wrote: but the there is no difference for others seems to be total crap, exactly because it results in this IRQF mismatch. So I think that commit should just be reverted. Thomas? Yes. I missed that detail when I applied that patch. Reverting it

Re: [POWER DOMAIN suspend callbacks] Observation.

2011-08-23 Thread Kevin Hilman
Hi Santosh, Santosh santosh.shilim...@ti.com writes: Rafael, Kevin, On latest kernel( V3.1-rc1+), the subsystem(driver) suspend callbacks are not getting called because power domain callbcaks are populated. And as per commit 4d27e9dc{PM: Make power domain callbacks take precedence over

Re: [PATCH 3.1-rc3] gpio/omap: fix build error with certain OMAP1 configs

2011-08-23 Thread Kevin Hilman
Janusz Krzysztofik jkrzy...@tis.icnet.pl writes: With commit f64ad1a0e21a, gpio/omap: cleanup _set_gpio_wakeup(), remove ifdefs, access to build time conditionally omitted 'suspend_wakeup' member of the 'gpio_bank' structure has been placed unconditionally in function _set_gpio_wakeup(),

[RFC PATCH v2 0/6] TI81XX: Add clock and hwmod data

2011-08-23 Thread Hemant Pedanekar
This patch set is the v2 of TI816X clock and hwmods patches sent earlier. The clock data is currently added only for TI816X, while minimal hwmod data common for TI816X and TI814X is added. This patch set depends on following patches: TI81XX: Prepare for addition of TI814X support

[RFC PATCH v2 1/6] TI816X: prcm: Add module and register offsets

2011-08-23 Thread Hemant Pedanekar
This patch adds PRCM register offsets for TI816X device as required for the clock data. Signed-off-by: Hemant Pedanekar hema...@ti.com --- arch/arm/mach-omap2/cm816x.h | 368 arch/arm/mach-omap2/prm2xxx_3xxx.h | 17 ++ 2 files changed, 385

[RFC PATCH v2 2/6] TI816X: clock: Add clock data

2011-08-23 Thread Hemant Pedanekar
This patch adds data for various clocks present in TI816X. Note that this data is not automatically generated and not all clocks are covered currently. Signed-off-by: Hemant Pedanekar hema...@ti.com --- arch/arm/mach-omap2/clock816x.h | 21 + arch/arm/mach-omap2/clock816x_data.c | 1108

[RFC PATCH v2 3/6] TI816X: clock: Add clockdomains and powerdomains data

2011-08-23 Thread Hemant Pedanekar
This patch adds data for various clock domains and power domains in TI816X. Note that at present this is not exhaustive and need to add missing domains. Signed-off-by: Hemant Pedanekar hema...@ti.com --- arch/arm/mach-omap2/clockdomains816x_data.c | 172 +++

[RFC PATCH v2 4/6] clock: Integrate TI816X clock data into OMAP clock framework

2011-08-23 Thread Hemant Pedanekar
This patch hooks clock initialization and clockdomain/powerdomain setup into OMAP clock framework. Signed-off-by: Hemant Pedanekar hema...@ti.com --- arch/arm/mach-omap2/Makefile |3 ++ arch/arm/mach-omap2/clock3xxx_data.c |5 ++-

[RFC PATCH v2 5/6] TI81XX: Add minimal hwmod data

2011-08-23 Thread Hemant Pedanekar
This patch adds minimum required hwmod data (e.g., UARTs) for bootup of TI81XX devices (currently common data for TI816X and TI814X is added). Signed-off-by: Hemant Pedanekar hema...@ti.com --- arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 677 1 files changed, 677

[RFC PATCH v2 6/6] hwmods: Integrate TI81XX hwmods

2011-08-23 Thread Hemant Pedanekar
This patch integrates TI816X and TI814X hwmods into hwmods framework. Note that a TI81XX specific function ti81xx_cm_wait_module_ready() is added to wait for module to become ready since corresponding OMAP2/3 function omap2_cm_wait_module_ready() cannot be used as there are no IDLEST registers in

Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: On 8/23/2011 5:28 AM, Kevin Hilman wrote: Rajendra Nayakrna...@ti.com writes: [...] FWIK, its a one time requirement to set the clock rate to the right rate the device can operate in based on what a platform supports. Except $SUBJECT patch

Re: [PATCH] tty: omap-serial: fix boot hang by converting to use a threaded IRQ handler (was Re: [PATCH] irq: always set IRQF_ONESHOT if no primary handler is specified)

2011-08-23 Thread Paul Walmsley
On Tue, 23 Aug 2011, Felipe Balbi wrote: if you're not running on a slow bus, you should use top half to check if IRQs are really from this device. I don't think this applies in this case, since the IRQ isn't shared between different hardware devices - it's shared for the purposes of a

[PATCH -next] usb: fix dwc3 build when USB_GADGET_DWC3 is not enabled

2011-08-23 Thread Randy Dunlap
(+) --- linux-next-20110823.orig/drivers/usb/dwc3/debugfs.c +++ linux-next-20110823/drivers/usb/dwc3/debugfs.c @@ -437,7 +437,9 @@ static int dwc3_testmode_open(struct ino struct dwc3_gadget_ep_cmd_params par0; struct dwc3_gadget_ep_cmd_params par1; struct dwc3_trb trb

Re: [PATCH -next] usb: fix dwc3 build when USB_GADGET_DWC3 is not enabled

2011-08-23 Thread Felipe Balbi
--- drivers/usb/dwc3/debugfs.c |4 1 file changed, 4 insertions(+) --- linux-next-20110823.orig/drivers/usb/dwc3/debugfs.c +++ linux-next-20110823/drivers/usb/dwc3/debugfs.c @@ -437,7 +437,9 @@ static int dwc3_testmode_open(struct ino struct dwc3_gadget_ep_cmd_params par0

Re: [RFC/PATCH v2 10/13] dt: omap4: panda board: set clock freq for i2c devices

2011-08-23 Thread Cousson, Benoit
From: G, Manjunath Kondaiahmanj...@ti.com To: devicetree-disc...@lists.ozlabs.org CC: linux-omap@vger.kernel.org, linux-arm-ker...@lists.infradead.org Update omap4 panda dts file with required clock frequencies for the i2c client devices existing on panda board. Signed-off-by: G, Manjunath

Re: [RFC/PATCH v2 10/13] dt: omap4: panda board: set clock freq for i2c devices

2011-08-23 Thread G, Manjunath Kondaiah
Hi Benoit, On Wed, Aug 24, 2011 at 12:33 AM, Cousson, Benoit b-cous...@ti.com wrote: From: G, Manjunath Kondaiahmanj...@ti.com To: devicetree-disc...@lists.ozlabs.org CC: linux-omap@vger.kernel.org, linux-arm-ker...@lists.infradead.org Update omap4 panda dts file with required clock

Re: Fwd: [RFC/PATCH v2 08/13] dt: omap: i2c: add dt support for i2c1 controller

2011-08-23 Thread Cousson, Benoit
The device tree support has been added to i2c1 controller and corresponding i2c initilization in generic board file is cleaned up so that platfom device is registered through dt and omap device and not through board i2c initilization. A couple of typos in the changelog. That patch should be in

Re: Fwd: [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers

2011-08-23 Thread Cousson, Benoit
On 8/23/2011 5:18 PM, G, Manjunath Kondaiah wrote: On Tue, Aug 23, 2011 at 03:48:15PM +0200, Cousson, Benoit wrote: From: G, Manjunath Kondaiahmanj...@ti.com To: devicetree-disc...@lists.ozlabs.org CC: linux-omap@vger.kernel.org, linux-arm-ker...@lists.infradead.org Add omap4 soc dts file

[PATCH -next v2] usb: fix dwc3 build when USB_GADGET_DWC3 is not enabled

2011-08-23 Thread Randy Dunlap
(+) --- linux-next-20110823.orig/drivers/usb/dwc3/gadget.h +++ linux-next-20110823/drivers/usb/dwc3/gadget.h @@ -202,6 +202,11 @@ void dwc3_gadget_exit(struct dwc3 *dwc); #else static inline int dwc3_gadget_init(struct dwc3 *dwc) { return 0; } static inline void dwc3_gadget_exit(struct dwc3 *dwc

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-23 Thread Rafael J. Wysocki
On Tuesday, August 23, 2011, Mark Brown wrote: On Sun, Aug 21, 2011 at 08:05:53PM +0200, Rafael J. Wysocki wrote: On Sunday, August 21, 2011, Mark Brown wrote: I don't understand why the driver would need to know what situation it's in. I'd been working on the basis that the idea was

Re: tidspbridge issue with omap_dm_timer_free

2011-08-23 Thread Ramirez Luna, Omar
Hi, On Sun, Aug 14, 2011 at 2:44 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Yeah, but with the current approach it would be possible that everything works fine, and then the DSP goes to hibernation, a module is loaded that uses one dm timer, and then when the DSP wakes up, that

[GIT PULL] I2C: OMAP: major cleanup for v3.2 (was for v3.1)

2011-08-23 Thread Kevin Hilman
Ben, This series fell through the cracks for v3.1, so I've now rebased it onto v3.1-rc3 and am submitting it for v3.2. It no longer has any dependencies on OMAP trees, so could you please pull this into your tree for linux-next? A few more OMAP I2C series will be coming on top of this one.

[GIT PULL] I2C: OMAP: misc. fixes for v3.2

2011-08-23 Thread Kevin Hilman
Hi Ben, Initially, these fixes were planned to be queued for v3.1-rc, but since the previous series from Andy didn't make it into v3.1, it should be queued for v3.2. This branch is based on the for_3.2/i2c-andy branch (previous pull request.) Please pull into your tree for linux-next. Thanks,

[GIT PULL] I2C: OMAP: misc. cleanup for v3.2

2011-08-23 Thread Kevin Hilman
Ben, Here's one more I2C cleanup series for v3.2. It applies on top of my for_3.2/i2c-fixes branch just submitted. Please pull into your tree for linux-next. Thanks, Kevin The following changes since commit f3cb1e11c4e54f4dc7e60f9513d43ffa0bbebc25: Revert i2c-omap: fix static suspend vs.

Re: [PATCH v5 18/22] gpio/omap: use pm-runtime framework

2011-08-23 Thread Rajendra Nayak
On 8/23/2011 8:04 PM, Santosh wrote: + Rajendra and Benoit to comment on optional clock handling. On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() for enabling/disabling clocks appropriately. Remove

Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver

2011-08-23 Thread Rajendra Nayak
On 8/23/2011 10:45 PM, Kevin Hilman wrote: Rajendra Nayakrna...@ti.com writes: On 8/23/2011 5:28 AM, Kevin Hilman wrote: Rajendra Nayakrna...@ti.com writes: [...] FWIK, its a one time requirement to set the clock rate to the right rate the device can operate in based on what a platform