RE: [RFC PATCH 1/5] arm:omap1/2/3/4:Convert 32k-Sync clocksource driver to platform_driver

2012-01-30 Thread Hiremath, Vaibhav
On Thu, Jan 26, 2012 at 05:23:30, john stultz wrote: On Wed, 2012-01-18 at 16:58 +0530, Vaibhav Hiremath wrote: +/** + * read_persistent_clock - Return time from a persistent clock. + * + * Reads the time from a source which isn't disabled during PM, the + * 32k sync timer. Convert

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread Ming Lei
Hi, On Mon, Jan 30, 2012 at 1:36 AM, stephane eranian eran...@googlemail.com wrote: Hi, Ok, so I did a few more tests and there is a serious issue when sampling in frequency mode (the default). I noticed wrong number of samples, so I investigated this some more and instrumented the

[PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements

2012-01-30 Thread Paul Walmsley
This series optimizes some of the powerdomain-related code in arch/arm/mach-omap2/pm*, and fixes a bug or two. These were noticed while working on the functional powerstate code. Rajendra and Santosh, if you have a spare moment, could you please peek at the OMAP4 LOWPOWERSTATECHANGE part of the

[PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state()

2012-01-30 Thread Paul Walmsley
Clean up a few different parts of omap_set_pwrdm_state(): - Remove a superfluous call to pwrdm_state_switch(). Not needed unless LOWPOWERSTATECHANGE is used, because the state switch code is called by either clkdm_sleep() or clkdm_allow_idle(). - Add code to wait for the power state

[PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Paul Walmsley
Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). pwrdm_pre_transition(), which appears a few lines after these calls, invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no need to do it twice. N.B.: some of us have observed that accesses to the previous powerstate

Re: ARM/ARM-SoC plans for v3.4 merge window

2012-01-30 Thread Nicolas Ferre
On 01/29/2012 12:57 AM, Olof Johansson : Hi, On Thu, Jan 26, 2012 at 1:23 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: And we're now there. So... Arnd, Olaf, Please incorporate the latest ARM (for-armsoc branch) changes, which can be found at:

[PATCH 0/7] ARM: OMAP2+: hwmod/timer: first set of cleanups for 3.4

2012-01-30 Thread Paul Walmsley
This series does some cleanup and documentation on the OMAP hwmod code (and a bit of the OMAP4 data) and timer code. It is the first prerequisite series to removing a big chunk of hwmod data -- that will be done in a later series. Boot-tested on an OMAP35xx BeagleBoard and OMAP44xx ES2

[PATCH 1/7] ARM: OMAP2+: hwmod: control all hardreset lines attached to a hwmod

2012-01-30 Thread Paul Walmsley
Parts of the hwmod code test to see if a module has one and only one hardreset line before taking an action. It seems more appropriate to control all hardreset lines associated with a hwmod, not just one. It so happens that with the current hwmod data, this will not change any behavior, since

[PATCH 4/7] ARM: OMAP2+: hwmod: provide a function to return the address space of the MPU RT

2012-01-30 Thread Paul Walmsley
A subsequent patch will need to know the struct omap_hwmod_addr_space record corresponding to the module's register target, used by the MPU. So, convert _find_mpu_rt_base() into _find_mpu_rt_addr_space(). Then modify its sole current user, _populate_mpu_rt_base(), to extract the MPU RT base

[PATCH 7/7] ARM: OMAP2+: hwmod: split the _setup() function

2012-01-30 Thread Paul Walmsley
Split the interface clock setup from _setup() into _setup_iclk_autoidle() and split the post-setup state code from _setup() into _enter_postsetup_state(). Fix the existing, incorrect documentation for _setup(), and add documentation for the other two functions. The goal is to shrink the size of

[PATCH 6/7] ARM: OMAP2+: timer: use a proper interface to get hwmod data

2012-01-30 Thread Paul Walmsley
arch/arm/mach-omap2/timer.c pokes around inside the hwmod data structures. Since the hwmod data structures are about to change, this code will break. This patch modifies the timer code to use recently-added hwmod functions instead. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Tony Lindgren

[PATCH 2/7] ARM: OMAP4: hwmod data: remove pseudo-hwmods associated with hardreset lines

2012-01-30 Thread Paul Walmsley
Remove the pseudo-hwmods associated with hardreset lines from the OMAP4 data file. Future patches will convert this data to register hwmods by interfaces, rather than registering hwmods directly; and these pseudo-hwmods aren't associated with any interfaces. The hwmod code now resets processor

[PATCH 3/7] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-01-30 Thread Paul Walmsley
Move the code that reprograms the OCP_SYSCONFIG bits into the _reset() function to ensure that it is called after every reset. The code was previously in the _setup() function. So, before this patch, if _reset() was called from another function, the SYSCONFIG register won't be reprogrammed.

[PATCH 5/7] ARM: OMAP2+: hwmod: add omap_hwmod_get_mpu_irq() and omap_hwmod_get_mpu_rt_pa()

2012-01-30 Thread Paul Walmsley
The timer integration code pokes around in hwmod data structures. Those data structures are about to change. Define some functions for the timer integration code to use instead. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Benoît Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com ---

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
Ok, let me try again with 3.3.0-rc1, that was with 3.2.0. The only thing that changed was that one line and it made a big difference. On Mon, Jan 30, 2012 at 10:40 AM, Ming Lei ming@canonical.com wrote: Hi, On Mon, Jan 30, 2012 at 1:36 AM, stephane eranian eran...@googlemail.com wrote:

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Shilimkar, Santosh
On Mon, Jan 30, 2012 at 3:13 PM, Paul Walmsley p...@pwsan.com wrote: Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). pwrdm_pre_transition(), which appears a few lines after these calls, invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no need to do it twice.

Re: omap_hsmmc.c and MMC_CAP_SDIO_IRQ

2012-01-30 Thread Michael Hunold
Hello Steve, on 01/27/2012 03:09 PM Steve Sakoman said the following: On Tue, Jan 24, 2012 at 6:33 AM, Michael Hunold hun...@linuxtv.org wrote: Your summary below is a pretty accurate description of the current state. Ok. I've made an attempt at creating a patch for 3.2 that follows David

Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented

2012-01-30 Thread Artem Bityutskiy
On Tue, 2012-01-24 at 09:06 +, Russell King - ARM Linux wrote: However, the bug made it into the 3.3 merge window, so shouldn't this bugfix be sent upstream immediately? David is the MTD maintainer, and Artem just helps out. I believe Artem is waiting for David to finish travelling

Re: [PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state()

2012-01-30 Thread Shilimkar, Santosh
On Mon, Jan 30, 2012 at 3:13 PM, Paul Walmsley p...@pwsan.com wrote: Clean up a few different parts of omap_set_pwrdm_state(): - Remove a superfluous call to pwrdm_state_switch().  Not needed  unless LOWPOWERSTATECHANGE is used, because the state switch code is  called by either clkdm_sleep()

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
Same results for me with 3.3.0-rc1 + 5 patches. top - 14:42:34 up 8 min,  1 user,  load average: 0.70, 0.29, 0.15 Tasks:  75 total,   2 running,  73 sleeping,   0 stopped,   0 zombie Cpu(s): 32.9%us,  1.3%sy,  0.0%ni, 65.8%id,  0.0%wa,  0.0%hi,  0.0%si,  0.0%st Mem:    940232k total,   118520k

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread Ming Lei
On Mon, Jan 30, 2012 at 9:43 PM, stephane eranian eran...@googlemail.com wrote: Same results for me with 3.3.0-rc1 + 5 patches. In fact, I think the only effect of the patch is to enable pmu interrupt handling, which may cause so much difference? Also maybe you should put 'noploop' to run on

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
Same result for me on CPU1: top - 16:20:24 up 1:45, 1 user, load average: 0.29, 0.08, 0.07 Tasks: 70 total, 2 running, 68 sleeping, 0 stopped, 0 zombie Cpu(s): 30.7%us, 2.7%sy, 0.0%ni, 66.7%id, 0.0%wa, 0.0%hi, 0.0%si, 0.0%st Mem:940232k total, 228984k used, 711248k free,

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread Måns Rullgård
stephane eranian eran...@googlemail.com writes: Same result for me on CPU1: top - 16:20:24 up 1:45, 1 user, load average: 0.29, 0.08, 0.07 Tasks: 70 total, 2 running, 68 sleeping, 0 stopped, 0 zombie Cpu(s): 30.7%us, 2.7%sy, 0.0%ni, 66.7%id, 0.0%wa, 0.0%hi, 0.0%si, 0.0%st

Re: [PATCH 5/7] ARM: OMAP2+: hwmod: add omap_hwmod_get_mpu_irq() and omap_hwmod_get_mpu_rt_pa()

2012-01-30 Thread Tony Lindgren
Hi, * Paul Walmsley p...@pwsan.com [120130 01:47]: The timer integration code pokes around in hwmod data structures. Those data structures are about to change. Define some functions for the timer integration code to use instead. Maybe these should use struct resource instead to make these

Re: [PATCH 1/5] staging: tidspbridge: more readable code

2012-01-30 Thread Ramirez Luna, Omar
2012/1/24 Felipe Contreras felipe.contre...@gmail.com: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: Uppercase function names are not pretty. Also the code flow readability is enhanced. Looks good to me. FWIW, I agree. Regards, Omar -- To unsubscribe from this list: send the line

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
On Mon, Jan 30, 2012 at 5:08 PM, Måns Rullgård m...@mansr.com wrote: stephane eranian eran...@googlemail.com writes: Same result for me on CPU1: top - 16:20:24 up  1:45,  1 user,  load average: 0.29, 0.08, 0.07 Tasks:  70 total,   2 running,  68 sleeping,   0 stopped,   0 zombie Cpu(s):

Re: [PATCH 2/5] staging: tidspbridge: remove unused header

2012-01-30 Thread Ramirez Luna, Omar
2012/1/24 Felipe Contreras felipe.contre...@gmail.com: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. The header file drv_interface.h was only used locally, hence there's no need to have it. Also the only prototyped functions were the file_operations

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread Will Deacon
On Mon, Jan 30, 2012 at 05:15:53PM +, stephane eranian wrote: Still need to investigate why the frequency mode does not yield the correct number of samples even with low frequency. $ taskset -c 1 perf record -e cycles -F 100 noploop 10 $ perf report -D | tail -20 Aggregated stats:

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Ramirez Luna, Omar
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Usually lindent tends to do whatever it wants, unless carefully configured... ... @@

Re: [PATCH 4/5] staging: tidspbridge: silence the compiler

2012-01-30 Thread Ramirez Luna, Omar
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: Silence the warning when compiling drv_interface.c Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com ---  drivers/staging/tidspbridge/rmgr/drv_interface.c |    5 +++--  1 files changed, 3 insertions(+), 2 deletions(-) diff

Re: [PATCH] tidspbridge: Rename module from bridgedriver to tidspbridge

2012-01-30 Thread Ramirez Luna, Omar
On Tue, Jan 24, 2012 at 3:25 PM, Joe Perches j...@perches.com wrote: tidspbridge when built as a module is named bridgedriver. bridgedriver is not a particularly good module name. tidspbridge is what the source is named.  That seems a more appropriate module name too as it describes the

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
Will, There you go, no attachment, not sure the omap list supports this. There is something quite interesting to observe. While I run perf record -e cycles -F 100 noploop 10, I watch /proc/interrupts. The number of interrupts is way lower than expected. Therefore the number of samples is way

Re: [PATCH] tidspbridge: Rename module from bridgedriver to tidspbridge

2012-01-30 Thread Felipe Contreras
On Mon, Jan 30, 2012 at 7:34 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Tue, Jan 24, 2012 at 3:25 PM, Joe Perches j...@perches.com wrote: tidspbridge when built as a module is named bridgedriver. bridgedriver is not a particularly good module name. tidspbridge is what the source is

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Víctor M . Jáquez L .
On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Usually

Re: [PATCH v2 0/3] tty: serial: OMAP: work around broken IP block, driver

2012-01-30 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: [ This series is targeted for merging during v3.3-rc ] Hi Here's an updated version of OMAP serial bugfix series against v3.3-rc1. This revision has: Reviewed-by: Kevin Hilman khil...@ti.com Tested-by: Kevin Hilman khil...@ti.com Tested on 3430/n900,

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread Will Deacon
On Mon, Jan 30, 2012 at 05:45:19PM +, stephane eranian wrote: There you go, no attachment, not sure the omap list supports this. Cheers Stephane. There is something quite interesting to observe. While I run perf record -e cycles -F 100 noploop 10, I watch /proc/interrupts. The number

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Dan Carpenter
On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: +                       pr_info(%s:%d handle(s) still opened\n, __func__, +                               atomic_read(bridge_cref)); I remember the rule was to break lines as far to the right as possible, no? Chapter 2

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Kevin Hilman
Grazvydas Ignotas nota...@gmail.com writes: Hi, On 3.2 (I think some earlier versions too), with CONFIG_CPU_IDLE enabled GPIO based buttons are not working properly on OMAP3 pandora, button presses are almost never registered. The buttons are connected GPIO bank4 and have hardware debounce

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Joe Perches
On Mon, 2012-01-30 at 22:29 +0300, Dan Carpenter wrote: On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: + pr_info(%s:%d handle(s) still opened\n, __func__, + atomic_read(bridge_cref)); I remember the rule was to

Re: How do I get slimbus hwmod information?

2012-01-30 Thread Marc Butler
On Wed, Jan 25, 2012 at 12:46:50PM -0700, Paul Walmsley wrote: sorry for the delay, just caught this during a list sweep. The maintainer of the OMAP4 hwmod data is Benoît, so I'd suggest cc'ing him for OMAP4 hwmod data requests. No worries and thanks for the reply. On Wed, 4 Jan 2012,

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Víctor M . Jáquez L .
On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote: On Mon, 2012-01-30 at 22:29 +0300, Dan Carpenter wrote: On Mon, Jan 30, 2012 at 11:25:34AM -0600, Ramirez Luna, Omar wrote: + pr_info(%s:%d handle(s) still opened\n, __func__, +

Re: [PATCH 3/5] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Joe Perches
On Mon, 2012-01-30 at 21:33 +0100, Víctor M. Jáquez L. wrote: On Mon, Jan 30, 2012 at 11:53:00AM -0800, Joe Perches wrote: I've done a patch here to tidspbridge that standardizes printk output. Basically, the patch adds #define pr_fmt(fmt) KBUILD_MODNAME %s: , __func__ to prefix

Re: oprofile and ARM A9 hardware counter

2012-01-30 Thread stephane eranian
On Mon, Jan 30, 2012 at 8:14 PM, Will Deacon will.dea...@arm.com wrote: On Mon, Jan 30, 2012 at 05:45:19PM +, stephane eranian wrote: There you go, no attachment, not sure the omap list supports this. Cheers Stephane. There is something quite interesting to observe. While I run perf

Re: [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements

2012-01-30 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: This series optimizes some of the powerdomain-related code in arch/arm/mach-omap2/pm*, and fixes a bug or two. These were noticed while working on the functional powerstate code. Rajendra and Santosh, if you have a spare moment, could you please peek at

Re: [PATCH 5/7] ARM: OMAP2+: hwmod: add omap_hwmod_get_mpu_irq() and omap_hwmod_get_mpu_rt_pa()

2012-01-30 Thread Paul Walmsley
Hi On Mon, 30 Jan 2012, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [120130 01:47]: The timer integration code pokes around in hwmod data structures. Those data structures are about to change. Define some functions for the timer integration code to use instead. Maybe these

Re: Why was the gptimer_wakup from suspend removed?

2012-01-30 Thread Kevin Hilman
Hello, Tasslehoff Kjappfot tasskj...@gmail.com writes: It was removed in: http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=98e182a26bbbf5575457622337684ef61493e864 The commit message says a bit about what was done, but not why. The reason why was because the way it

Re: How do I get slimbus hwmod information?

2012-01-30 Thread Paul Walmsley
cc Peter, Liam, Kevin, Mike On Mon, 30 Jan 2012, Marc Butler wrote: On Wed, Jan 25, 2012 at 12:46:50PM -0700, Paul Walmsley wrote: The driver shouldn't have any hwmod code in it. Any omap_device/omap_hwmod code that's needed should go into an appropriate file in arch/arm/mach-omap2.

[PATCH] ARM: OMAP2+: clock: cleanup CPUfreq leftovers

2012-01-30 Thread Kevin Hilman
Now that we have OPP layer, and OMAP CPUfreq driver is using it, we no longer need/use the clock framework code for filling up CPUfreq tables. Remove it. Signed-off-by: Kevin Hilman khil...@ti.com --- Paul, now that the CPUfreq driver is in mainline (v3.3), this can be safely removed.

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Grazvydas Ignotas
On Mon, Jan 30, 2012 at 9:36 PM, Kevin Hilman khil...@ti.com wrote: Grazvydas Ignotas nota...@gmail.com writes: Hi, On 3.2 (I think some earlier versions too), with CONFIG_CPU_IDLE enabled GPIO based buttons are not working properly on OMAP3 pandora, button presses are almost never

Re: [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend

2012-01-30 Thread NeilBrown
On Mon, 30 Jan 2012 00:57:13 +0200 Grazvydas Ignotas nota...@gmail.com wrote: Hello, I've been trying to get suspend working with musb compiled in on 3.2. It seems both patches from this thread are needed, Kevin's patch stops omap2430_runtime_suspend() from being called at inappropriate

Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented

2012-01-30 Thread Rafael J. Wysocki
On Monday, January 30, 2012, Artem Bityutskiy wrote: On Tue, 2012-01-24 at 09:06 +, Russell King - ARM Linux wrote: However, the bug made it into the 3.3 merge window, so shouldn't this bugfix be sent upstream immediately? David is the MTD maintainer, and Artem just helps out. I

[PATCH v2 0/8] staging: tidspbridge: clean up drv_interface.c

2012-01-30 Thread Víctor Manuel Jáquez Leal
I'm trying to learn how to contribute to the kernel and dsp/bridge is a module that I have used for a while. These patches are the result of this first effort. It is a clean up of the file drv_interface.c which is the entry point of the kernel module. Thanks v2: * Removed changes in lines with

[PATCH v2 2/8] staging: tidspbridge: remove unused header

2012-01-30 Thread Víctor Manuel Jáquez Leal
No functional changes. The header file drv_interface.h was only used locally, hence there's no need to have it. Also the only prototyped functions were the file_operations callbacks, then this commit moves them up to avoid prototyping too. Signed-off-by: Víctor Manuel Jáquez Leal

[PATCH v2 8/8] staging: tidspbridge: use the driver name string

2012-01-30 Thread Víctor Manuel Jáquez Leal
Instead of assign it to a global variable which is not used anymore. --- drivers/staging/tidspbridge/rmgr/drv_interface.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c

[PATCH v2 7/8] staging: tidspbridge: clean up bridge_mmap()

2012-01-30 Thread Víctor Manuel Jáquez Leal
The variable offset is not used but in the debug log, so I don't see reason to calculate it here. Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 6/8] staging: tidspbridge: remove trivial assert

2012-01-30 Thread Víctor Manuel Jáquez Leal
The function dsp_deinit() always return true, so assert its output is pointless. As consequence the variable were the returned value is stored, is no longer needed. Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c |4 +--- 1

[PATCH v2 4/8] staging: tidspbridge: silence the compiler

2012-01-30 Thread Víctor Manuel Jáquez Leal
Silence the warning when compiling drv_interface.c Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c

Re: [PATCH 0/7] ARM: OMAP2+: hwmod/timer: first set of cleanups for 3.4

2012-01-30 Thread Kevin Hilman
Hi Paul, Paul Walmsley p...@pwsan.com writes: This series does some cleanup and documentation on the OMAP hwmod code (and a bit of the OMAP4 data) and timer code. It is the first prerequisite series to removing a big chunk of hwmod data -- that will be done in a later series. Boot-tested

[PATCH v2 3/8] staging: tidspbridge: Lindent to drv_interface.c

2012-01-30 Thread Víctor Manuel Jáquez Leal
No functional changes. According to Lindent, the file drv_internface.c had some lines with bad indentation. This commit is the output of Lindent. Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c | 12 ++-- 1 files

[PATCH v2 5/8] staging: tidspbridge: remove header inclusions

2012-01-30 Thread Víctor Manuel Jáquez Leal
drv_interface.c include several header files that are not really used. Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git

[PATCH v2 1/8] staging: tidspbridge: more readable code

2012-01-30 Thread Víctor Manuel Jáquez Leal
Uppercase function names are not pretty. Also the code flow readability is enhanced. Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com --- drivers/staging/tidspbridge/rmgr/drv_interface.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Kevin Hilman
Grazvydas Ignotas nota...@gmail.com writes: On Mon, Jan 30, 2012 at 9:36 PM, Kevin Hilman khil...@ti.com wrote: Grazvydas Ignotas nota...@gmail.com writes: Hi, On 3.2 (I think some earlier versions too), with CONFIG_CPU_IDLE enabled GPIO based buttons are not working properly on OMAP3

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Paul Walmsley
On Mon, 30 Jan 2012, Kevin Hilman wrote: Grazvydas Ignotas nota...@gmail.com writes: On Mon, Jan 30, 2012 at 9:36 PM, Kevin Hilman khil...@ti.com wrote: Grazvydas Ignotas nota...@gmail.com writes: On 3.2 (I think some earlier versions too), with CONFIG_CPU_IDLE enabled GPIO based

Re: [PATCH 0/7] ARM: OMAP2+: hwmod/timer: first set of cleanups for 3.4

2012-01-30 Thread Paul Walmsley
On Mon, 30 Jan 2012, Kevin Hilman wrote: Paul Walmsley p...@pwsan.com writes: This series does some cleanup and documentation on the OMAP hwmod code (and a bit of the OMAP4 data) and timer code. It is the first prerequisite series to removing a big chunk of hwmod data -- that will be

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). pwrdm_pre_transition(), which appears a few lines after these calls, invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no need to do it twice. It looks like these two for

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: On Mon, 30 Jan 2012, Kevin Hilman wrote: Grazvydas Ignotas nota...@gmail.com writes: On Mon, Jan 30, 2012 at 9:36 PM, Kevin Hilman khil...@ti.com wrote: Grazvydas Ignotas nota...@gmail.com writes: On 3.2 (I think some earlier versions too), with

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Grazvydas Ignotas
On Tue, Jan 31, 2012 at 1:34 AM, Paul Walmsley p...@pwsan.com wrote: On Mon, 30 Jan 2012, Kevin Hilman wrote: Grazvydas Ignotas nota...@gmail.com writes: Hmm but it doesn't work here (OMAP3530 ES2.1), /proc/interrupts doesn't increase when I hit buttons unless something else is happening

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Grazvydas Ignotas
On Tue, Jan 31, 2012 at 2:22 AM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: That's probably I/O ring/pad wakeups happening there, not GPIO wakeups. Gražvydas, you are referring to the case where the CORE powerdomain is on, but the GPIO IP block is idle? Right

Re: [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend

2012-01-30 Thread Grazvydas Ignotas
On Tue, Jan 31, 2012 at 12:37 AM, NeilBrown ne...@suse.de wrote: 1/ I don't know what your problem might be, but I have suspend working  quite well with musb compiled in.  CORE goes to RET.  The code is at git://neil.brown.name/gta04 in the 3.2-gta04 branch.  There are various additions and

[PATCH 0/2] staging: tidspbridge: memory leak fixes

2012-01-30 Thread Omar Ramirez Luna
These patches solve two lingering memory leak scenarios introduced in tidspbridge code. 1. Due to missing balanced calls during bridge_release deallocation, and a potential leak in bridge_open because of missing cleanup path. 2. Leaks because of a misuse of an already freed pointer, which

[PATCH 1/2] staging: tidspbridge: fix bridge_open memory leaks

2012-01-30 Thread Omar Ramirez Luna
There are two members of pr_ctxt allocated during bridge_open that are never freed resulting in memory leaks, these are stream_id and node_id, they are now freed on release of the handle (bridge_release) right before freeing pr_ctxt. Error path for bridge_open was also fixed since the same

[PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap

2012-01-30 Thread Omar Ramirez Luna
This structure is still used after it has been freed, since it is being allocated in probe, calls to free it have been moved to module's remove routine. This should fix the follwoing messages when attempting to remove the module: drv_get_first_dev_extension: Failed to retrieve the object handle

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Paul Walmsley
Hi Gražvydas On Tue, 31 Jan 2012, Grazvydas Ignotas wrote: On Tue, Jan 31, 2012 at 1:34 AM, Paul Walmsley p...@pwsan.com wrote: So apparently, looking at these references, the following registers should be configured: 1. at least one of GPIO_LEVELDETECT{0,1} or

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Paul Walmsley
On Tue, 31 Jan 2012, Grazvydas Ignotas wrote: On Tue, Jan 31, 2012 at 1:34 AM, Paul Walmsley p...@pwsan.com wrote: So apparently, looking at these references, the following registers should be configured: 1. at least one of GPIO_LEVELDETECT{0,1} or GPIO_{RISING,FALLING}DETECT 2.

Re: [PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state()

2012-01-30 Thread Rajendra Nayak
Hi Paul, On Monday 30 January 2012 03:13 PM, Paul Walmsley wrote: Clean up a few different parts of omap_set_pwrdm_state(): - Remove a superfluous call to pwrdm_state_switch(). Not needed unless LOWPOWERSTATECHANGE is used, because the state switch code is called by either clkdm_sleep()

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Rajendra Nayak
On Tuesday 31 January 2012 05:44 AM, Kevin Hilman wrote: Paul Walmsleyp...@pwsan.com writes: Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). pwrdm_pre_transition(), which appears a few lines after these calls, invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's

Re: OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)?

2012-01-30 Thread Aneesh V
Hi Catalin, On Friday 27 January 2012 11:00 PM, Catalin Marinas wrote: On Fri, Jan 20, 2012 at 08:57:11AM +, Joe Woodward wrote: So I re-iterate that we need to have solution to this problem. ... I don't want to be a pain, but it seems to me that this dicussion didn't reach a full

Re: GPIO debounce problems on 3.2

2012-01-30 Thread Paul Walmsley
On Mon, 30 Jan 2012, Paul Walmsley wrote: It seems highly suspicious to me that nothing in set_24xx_gpio_triggering() in our GPIO code seems to touch the WAKEUPENABLE register. Heh. Just wanted to follow up on this for anyone who cares. Gražvydas noticed that the bit was indeed being

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Shilimkar, Santosh
On Tue, Jan 31, 2012 at 5:44 AM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). pwrdm_pre_transition(), which appears a few lines after these calls, invokes pwrdm_clear_all_prev_pwrst() on each powerdomain

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Paul Walmsley
Hi just a few thoughts. On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: In this code the need is to clear only CPU and MPUPD, and hence they are explicitly cleared since the pre/post transition calls can be moved to PM_DEBUG in production kernels. But as you stated in current mainline

Re: [PATCH 0/2] ARM: OMAP2+: PM: miscellaneous powerdomain-related improvements

2012-01-30 Thread Tero Kristo
On Mon, 2012-01-30 at 13:27 -0800, Kevin Hilman wrote: Paul Walmsley p...@pwsan.com writes: This series optimizes some of the powerdomain-related code in arch/arm/mach-omap2/pm*, and fixes a bug or two. These were noticed while working on the functional powerstate code. Rajendra and

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Shilimkar, Santosh
On Tue, Jan 31, 2012 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: Hi just a few thoughts. On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: In this code the need is to clear only CPU and MPUPD, and hence they are explicitly cleared since the pre/post transition calls can be moved to

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Paul Walmsley
On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: On Tue, Jan 31, 2012 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: In this code the need is to clear only CPU and MPUPD, and hence they are explicitly cleared since the pre/post transition

Re: OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)?

2012-01-30 Thread Catalin Marinas
On 31 January 2012 05:21, Aneesh V ane...@ti.com wrote: On Friday 27 January 2012 11:00 PM, Catalin Marinas wrote: On Fri, Jan 20, 2012 at 08:57:11AM +, Joe Woodward wrote: So I re-iterate that we need to have solution to this problem. ... I don't want to be a pain, but it seems to me

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Shilimkar, Santosh
On Tue, Jan 31, 2012 at 12:57 PM, Paul Walmsley p...@pwsan.com wrote: On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: On Tue, Jan 31, 2012 at 12:45 PM, Paul Walmsley p...@pwsan.com wrote: On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: In this code the need is to clear only CPU and MPUPD,

Re: OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)?

2012-01-30 Thread Shilimkar, Santosh
On Tue, Jan 31, 2012 at 1:01 PM, Catalin Marinas catalin.mari...@arm.com wrote: On 31 January 2012 05:21, Aneesh V ane...@ti.com wrote: On Friday 27 January 2012 11:00 PM, Catalin Marinas wrote: On Fri, Jan 20, 2012 at 08:57:11AM +, Joe Woodward wrote: So I re-iterate that we need to have

Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

2012-01-30 Thread Paul Walmsley
On Tue, 31 Jan 2012, Shilimkar, Santosh wrote: A week back I was discussing with Benoit and Tony about having some infrastructure like unused clocks so that we can shutdown those modules, and if possible some power domains. That way they get removed at one single place and they the power