Re: [PATCH 02/11] iommu/omap: Remove all module references

2015-07-21 Thread Laurent Pinchart
Hi Suman, On Monday 20 July 2015 17:33:24 Suman Anna wrote: The OMAP IOMMU driver has been adapted to the IOMMU framework for a while now, and it does not support being built as a module anymore. So, remove all the module references from the OMAP IOMMU driver. While at it, also relocate a

Re: [PATCH v3 07/46] usb: dwc3: gadget: add ep capabilities support

2015-07-21 Thread Felipe Balbi
Hi, On Wed, Jul 15, 2015 at 08:31:54AM +0200, Robert Baldyga wrote: Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git

Re: [PATCH 07/11] iommu/omap: Remove unnecessary error traces on alloc failures

2015-07-21 Thread Laurent Pinchart
Hi Suman, Thank you for the patch. On Monday 20 July 2015 17:33:29 Suman Anna wrote: Fix couple of checkpatch warnings of the type, WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Suman Anna s-a...@ti.com The commit message could also mention that the reason to

[PATCH] gpio: omap: use raw locks for locking

2015-07-21 Thread Sebastian Andrzej Siewior
This patch converts gpio_bank.lock from a spin_lock into a raw_spin_lock. The call path is to access this lock is always under a raw_spin_lock, for instance - __setup_irq() holds desc-lock with irq off + __irq_set_trigger() + omap_gpio_irq_type() - handle_level_irq() (runs with irqs off

Re: [PATCH 01/11] Documentation: dt: Add #iommu-cells info to OMAP iommu bindings

2015-07-21 Thread Laurent Pinchart
Hi Suman, Thank you for the patch. On Monday 20 July 2015 17:33:23 Suman Anna wrote: The OMAP IOMMU bindings is updated to reflect the required #iommu-cells property. Signed-off-by: Suman Anna s-a...@ti.com This brings the documentation in sync with both mainline DT sources and code so it

Re: [PATCH 04/11] iommu/omap: Protect omap-iopgtable.h against double inclusion

2015-07-21 Thread Laurent Pinchart
Hi Suman, Thank you for the patch. On Monday 20 July 2015 17:33:26 Suman Anna wrote: Protect the omap-pgtable.h header against double inclusion in source code by using the standard include guard mechanism. Signed-off-by: Suman Anna s-a...@ti.com Reviewed-by: Laurent Pinchart

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-21 Thread Vignesh R
Hi Dmitry, On 07/20/2015 11:54 AM, Dmitry Torokhov wrote: On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:53]: @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, %s: x %d, y

Re: [PATCH 2/2] iommu/omap: Add support for configuring dsp iommus on DRA7xx

2015-07-21 Thread Tony Lindgren
* Suman Anna s-a...@ti.com [150721 16:58]: --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -26,6 +26,8 @@ #include linux/of_iommu.h #include linux/of_irq.h #include linux/of_platform.h +#include linux/regmap.h +#include linux/mfd/syscon.h #include

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Sebastian Reichel
Hi, On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built into the kernel. I also found that with the patch below the

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Wed, Jul 22, 2015 at 04:03:07AM +0200, Sebastian Reichel wrote: Hi, On Tue, Jul 21, 2015 at 07:17:41PM -0500, Michael Welling wrote: On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Felipe Balbi
On Tue, Jul 14, 2015 at 02:29:46PM -0500, Franklin S Cooper Jr wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a kernel panic. Signed-off-by: Roger Quadros

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Franklin S Cooper Jr.
On 07/21/2015 06:40 AM, Ulf Hansson wrote: On 14 July 2015 at 21:29, Franklin S Cooper Jr fcoo...@ti.com wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: Actually.. for the record I'm _not_ using modules. So either I hit something different, or problem happens regardless of modules. Pavel I was able to reproduce

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Felipe Balbi
On Tue, Jul 21, 2015 at 03:11:21PM -0500, Franklin S Cooper Jr. wrote: On 07/21/2015 02:57 PM, Felipe Balbi wrote: On Tue, Jul 14, 2015 at 02:29:46PM -0500, Franklin S Cooper Jr wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Franklin S Cooper Jr.
On 07/21/2015 02:57 PM, Felipe Balbi wrote: On Tue, Jul 14, 2015 at 02:29:46PM -0500, Franklin S Cooper Jr wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a

Re: [PATCH 02/11] iommu/omap: Remove all module references

2015-07-21 Thread Suman Anna
Hi Laurent, On Monday 20 July 2015 17:33:24 Suman Anna wrote: The OMAP IOMMU driver has been adapted to the IOMMU framework for a while now, and it does not support being built as a module anymore. So, remove all the module references from the OMAP IOMMU driver. While at it, also relocate

[PATCH 2/2] iommu/omap: Add support for configuring dsp iommus on DRA7xx

2015-07-21 Thread Suman Anna
The DSP MMUs on DRA7xx SoC requires configuring an additional MMU_CONFIG register present in the DSP_SYSTEM sub module. This setting dictates whether the DSP Core's MDMA and EDMA traffic is routed through the respective MMU or not. Add the support to the OMAP iommu driver so that the traffic is

[PATCH 0/2] DRA7 DSP MMU config support

2015-07-21 Thread Suman Anna
Hi, This series adds the basic support in the OMAP IOMMU driver to enable/disable DSP IOMMUs for the DRA7xx family of SoCs. The DRA7 family has two MMUs within the DSP processor subsystems. This is the first time this was designed so in the silicon compared to the equivalent ones on OMAP2+ SoCs.

[PATCH 1/2] Documentation: dt: Update OMAP iommu bindings for DRA7 DSPs

2015-07-21 Thread Suman Anna
The DSP processor sub-systems on DRA7xx have two MMU instances each, one for the processor core and the other for an internal EDMA block. These MMUs need an additional shared register to be programmed in the DSP_SYSTEM sub-module to be enabled properly. The OMAP IOMMU bindings is updated to

[PATCH 3/4] ARM: dts: DRA7: Add common IOMMU nodes

2015-07-21 Thread Suman Anna
The DRA7xx family of SOCs have two IPUs and one DSP processor subsystems in common. The IOMMU DT nodes have been added for these processor subsystems, and have been disabled by default. These MMUs are very similar to those on OMAP4 and OMAP5, with the only difference being the presence of a

[PATCH 1/4] ARM: dts: DRA7: Add dsp1_system syscon node

2015-07-21 Thread Suman Anna
The DSP_SYSTEM sub-module is a dedicated system control logic module present within a DRA7 DSP processor sub-system. This module is responsible for power management, clock generation and connection to the device PRCM module. Add a syscon node for this module for the DSP1 processor sub-system.

[PATCH 4/4] ARM: dts: DRA74x: Add IOMMU nodes for DSP2

2015-07-21 Thread Suman Anna
The DRA74x family of SoCs have a second DSP, that also has two MMUs just like the DSP1 subsystem. Add the IOMMU nodes for this DSP2 subsystem in disabled state to the DRA74x specific DTS file, the nodes would need to be enabled appropriately in the respective board DTS files. Signed-off-by: Suman

[PATCH 2/4] ARM: dts: DRA74x: Add dsp2_system syscon node

2015-07-21 Thread Suman Anna
The DSP_SYSTEM sub-module is a dedicated system control logic module present within a DRA7 DSP processor sub-system. This module is responsible for power management, clock generation and connection to the device PRCM module. Add a syscon node for this module for the DSP2 processor sub-system.

[PATCH 0/4] Add DRA7 IOMMU DT nodes

2015-07-21 Thread Suman Anna
Hi Tony, The following patches add the basic DT nodes for the DSP and IPU IOMMU devices for the DRA7xx SoC family. The first two patches add syscon nodes for DSP_SYSTEM sub-modules, while the last two add the IOMMU nodes. The IPU IOMMU nodes mostly are similar to existing ones on OMAP4 and

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Michael Welling
On Tue, Jul 21, 2015 at 11:34:41AM +0200, Pavel Machek wrote: This code has my head spinning. I found that the errors do not occur when the driver is built into the kernel. I also found that with the patch below the errors go away. Not sure if it is acceptible but see if it fixes things on

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Pavel Machek
On Tue 2015-07-21 09:31:27, Pavel Machek wrote: On Wed 2015-07-15 15:10:48, Michael Welling wrote: On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed in

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Pali Rohár
On Tuesday 21 July 2015 09:33:00 Pavel Machek wrote: On Tue 2015-07-21 09:31:27, Pavel Machek wrote: On Wed 2015-07-15 15:10:48, Michael Welling wrote: On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC.

[PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Sascha Hauer
The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures near UINT_MAX for temperatures below 0°C. This will probably

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Pavel Machek
On Wed 2015-07-15 15:10:48, Michael Welling wrote: On Wed, Jul 15, 2015 at 09:49:33PM +0200, Pavel Machek wrote: Hi! Ok, so: 4.2-rc1 worked for me, IIRC. This does not make sense. Nothing has changed in drivers/spi between these versions. Are you sure that

Re: [PATCH] thermal: consistently use int for temperatures

2015-07-21 Thread Sascha Hauer
Hi Punit, On Fri, Jul 17, 2015 at 12:14:36PM +0100, Punit Agrawal wrote: Hi Sascha, Sascha Hauer s.ha...@pengutronix.de writes: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive

Re: [PATCH 3/3] mmc: host: omap_hsmmc: Add custom card detect irq handler

2015-07-21 Thread Andreas Fenkart
Hi Vignesh, Generally I don't like this patch, it will make it harder, not easier, to maintain the omap hsmmc driver. Also given that the bug occurs rarely, people will be reluctant to clean it up later or accept patches. see also comments below 2015-06-22 15:18 GMT+02:00 Vignesh R

Re: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Punit Agrawal
Hi Sascha, Sascha Hauer s.ha...@pengutronix.de writes: The thermal code uses int, long and unsigned long for temperatures in different places. Using an unsigned type limits the thermal framework to positive temperatures without need. Also several drivers currently will report temperatures

Re: [PATCH v3 0/5] ARM: dts: OMAP2+: Enable USB dual-role on supported boards

2015-07-21 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [150708 03:45]: Hi, Enables dual-role feaure on supported boards. Depends on [1] - core USB DRD support - http://thread.gmane.org/gmane.linux.kernel/1991413 [2] - dwc3 DRD support - http://thread.gmane.org/gmane.linux.usb.general/127890 Is this series

Re: [PATCH] mmc: omap_hsmmc: Update driver to support without regulators

2015-07-21 Thread Ulf Hansson
On 14 July 2015 at 21:29, Franklin S Cooper Jr fcoo...@ti.com wrote: From: Roger Quadros rog...@ti.com Update driver to support without regulators. Without this patch boards that do not enable regulator config options will fail to boot with a kernel panic. I guess that's because the rootfs

Re: [PATCH 1/1] ARM: dts: omap3: correct the format of u16 values for tsc2046 node

2015-07-21 Thread Tony Lindgren
* Fugang Duan b38...@freescale.com [150716 01:36]: From: Fugang Duan b38...@freescale.com In tsc2046 touch driver, the values such as ti,x-min is defined as a u16 value. the driver use API of_property_read_u16() read the value. For these u16 value, the dts entry should be like:

Re: [PATCH 1/2] ARM: dts: Add support for phyCORE-AM335x SoM

2015-07-21 Thread Tony Lindgren
* Teresa Remmet t.rem...@phytec.de [150716 01:36]: phyCORE-AM335x is a SoM (System on Module) containing a AM335x SOC. The module can be connected to different carrier boards. Some hardware parts are configurable on the phyCORE-AM335x. So they are disabled on default in this som dtsi file.

Re: [PATCH] ARM: dts: am437x: add aliases for all UART instances

2015-07-21 Thread Tony Lindgren
* Sekhar Nori nsek...@ti.com [150720 04:15]: Add serialN aliases for all 6 UART instances on the AM437x SoC so each board's .dts file does not have to define its own aliases. Remove the alias added for am437x-gp-evm.dts now that we have the aliases defined in am4372.dtsi file. Applying

Re: [PATCH] ARM: dts: omap5-uevm: Add Palmas power button support

2015-07-21 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [150720 14:00]: On 07/20/2015 04:07 PM, Aparna Balasubramanian wrote: Palmas on OMAP5uevm has support for power button, so enable it. Signed-off-by: Aparna Balasubramanian apar...@ti.com --- Based on kernel tag 4.2.0-rc1 and test result log is at

Re: [PATCH 1/4] ARM: dts: omap3-pandora: miscellaneous corrections

2015-07-21 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [150720 18:14]: - add pandora specific compatible name - fix mmc2 card detect polarity - fix mmc1 and mmc2 write protect polarity - disable write protect pins because of production issue and add an explanation why they are disabled - fix NAND partition

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-07-21 Thread Li Jun
Hi, [...] + otg_timer_init(A_WAIT_ENUM, otgd, set_tmout, TB_SRP_FAIL, NULL); 2 timers are missing: B_DATA_PLS, B_SSEND_SRP. Those 2 are not used by usb-otg-fsm.c. We can add it when usb-otg-fsm.c is updated. ok. +} [...] + +/** + * OTG FSM ops function to start/stop

Re: linux 4.2-rc1 broken Nokia N900

2015-07-21 Thread Pavel Machek
On Mon 2015-07-20 15:46:47, Michael Welling wrote: On Tue, Jul 14, 2015 at 09:14:12AM +0200, Pali Rohár wrote: On Monday 13 July 2015 17:36:07 Michael Welling wrote: On Tue, Jul 14, 2015 at 12:02:44AM +0200, Pali Rohár wrote: I think nothing special. I just call: export ARCH=arm

RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Zhang, Rui
-Original Message- From: Punit Agrawal [mailto:punit.agra...@arm.com] Sent: Tuesday, July 21, 2015 6:52 PM To: Sascha Hauer Cc: linux...@vger.kernel.org; Zhang, Rui; Eduardo Valentin; linux- ker...@vger.kernel.org; Jean Delvare; Peter Feuerer; Heiko Stuebner; Lukasz Majewski;