Re: Passing camera module type using camera argument.

2011-08-23 Thread Laurent Pinchart
instead. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] omap: iommu: migrate to the generic IOMMU API

2011-08-18 Thread Laurent Pinchart
)); + + clean_dcache_area(omap_domain-pgtable, IOPGD_TABLE_SIZE); + mutex_init(omap_domain-lock); + + domain-priv = omap_domain; + + return 0; + +fail_nomem: + kfree(omap_domain); +out: + return -ENOMEM; +} -- Regards, Laurent Pinchart -- To unsubscribe from

Re: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally

2011-08-18 Thread Laurent Pinchart
on MEDIA_CONTROLLER? Yes it is. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] omap: iommu migration, relocation and cleanups

2011-08-18 Thread Laurent Pinchart
!) You're welcome. 3. Rebase to 3.1-rc2 For the OMAP3 ISP driver changes, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/2] omap3: ISP: Kernel crash when attempting suspend

2011-08-15 Thread Laurent Pinchart
; - if (list_empty(video-dmaqueue)) { + if (list_empty(video-dmaqueue) + ccdc-state != ISP_PIPELINE_STREAM_STOPPED) { err = isp_video_deq_enq(queue); } else if (head-next-next == head) { /* only one buffer is left on dmaqueue */ -- Regards, Laurent

Re: ISP

2011-08-01 Thread Laurent Pinchart
/p/rowboat/wiki/Source there's omap3cam master driver and ISP driver in rowboat kernel. Please don't. That's really old deprecated code. You should use the OMAP3 ISP driver found in mainline. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap

[PATCH 0/3] OMAP3 ISP patches for v3.1

2011-07-15 Thread Laurent Pinchart
Hi everybody, Here are the OMAP3 ISP patches in my queue for v3.1. I'll send a pull request in a couple of days if there's no objection. Kalle Jokiniemi (2): OMAP3: ISP: Add regulator control for omap34xx OMAP3: RX-51: define vdds_csib regulator supply Laurent Pinchart (1): omap3isp

[PATCH 2/3] OMAP3: RX-51: define vdds_csib regulator supply

2011-07-15 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: t...@atomide.com --- arch/arm/mach-omap2/board-rx51-peripherals.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Tony, can I push this patch through the V4L/DVB tree, or would you like to pick it yourself ? diff --git

[PATCH 3/3] omap3isp: Support configurable HS/VS polarities

2011-07-15 Thread Laurent Pinchart
Add two fields to the ISP parallel platform data to set the HS and VS signals polarities. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/isp.h |6 ++ drivers/media/video/omap3isp/ispccdc.c |4 ++-- 2 files changed, 8 insertions

[PATCH 1/3] OMAP3: ISP: Add regulator control for omap34xx

2011-07-15 Thread Laurent Pinchart
From: Kalle Jokiniemi kalle.jokini...@nokia.com The current omap3isp driver is missing regulator handling for CSIb complex in omap34xx based devices. This patch adds a mechanism for this to the omap3isp driver. Signed-off-by: Kalle Jokiniemi kalle.jokini...@nokia.com Acked-by: Laurent Pinchart

Re: [PATCH 0/2] OMAP3 IOMMU fixes

2011-06-13 Thread Laurent Pinchart
Hi Tony, On Monday 13 June 2011 15:40:34 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [110608 03:43]: Hi Tony, On Monday 30 May 2011 14:47:07 Laurent Pinchart wrote: Hi everybody, Here are two OMAP3 IOMMU fixes required to support big

Re: [PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-08 Thread Laurent Pinchart
Hi Russell, On Monday 06 June 2011 20:00:52 Russell King - ARM Linux wrote: On Mon, Jun 06, 2011 at 06:54:10PM +0200, Laurent Pinchart wrote: Of course not, but if the scatterlist is only touched by kernel code, it doesn't need to be contiguous in memory. It could be allocated with vmalloc

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-08 Thread Laurent Pinchart
Hi Ohad, On Tuesday 07 June 2011 15:46:26 Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 2:26 PM, Laurent Pinchart wrote: Right now we have a BUG_ON if pa is unaligned, but that can be changed if needed (do we want it to handle offsets ?). At least for the OMAP3 ISP we need to, as video

Re: [PATCH 0/2] OMAP3 IOMMU fixes

2011-06-08 Thread Laurent Pinchart
Hi Tony, On Monday 30 May 2011 14:47:07 Laurent Pinchart wrote: Hi everybody, Here are two OMAP3 IOMMU fixes required to support big and/or unaligned memory buffers. Laurent Pinchart (2): omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU omap3: iovmm: Support non

Re: [PATCH] omap: iovmm: s/sg_dma_len(sg)/sg-length/

2011-06-08 Thread Laurent Pinchart
...@arm.linux.org.uk Signed-off-by: Ohad Ben-Cohen o...@wizery.com Tested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
); - BUG_ON(!iopgsz_ok(bytes)); + /* ignore failures.. we're already handling one */ + iommu_unmap(domain, da, order); da += bytes; } -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [RFC 1/6] omap: iommu: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
); + } + + return ret; You return 0 in the bogus pte/pgd cases. Is that intentional ? +} -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 2/6] omap: iovmm: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
Hi Ohad, On Tuesday 07 June 2011 12:28:53 Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 12:05 PM, Laurent Pinchart wrote: pgsz isn't used anymore, you can remove it. Ok. + order = get_order(bytes); Does iommu_map() handle offsets correctly, or does it expect pa

Re: [RFC 1/6] omap: iommu: generic iommu api migration

2011-06-07 Thread Laurent Pinchart
Hi Ohad, On Tuesday 07 June 2011 13:19:05 Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 12:22 PM, Laurent Pinchart wrote: + BUG_ON(!IS_ALIGNED((long)omap_domain-pgtable, IOPGD_TABLE_SIZE)); Either __get_free_pages() guarantees that the allocated memory will be aligned

Re: [PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-06 Thread Laurent Pinchart
Hi Russell, On Friday 03 June 2011 08:32:12 Russell King - ARM Linux wrote: On Fri, Jun 03, 2011 at 02:12:47AM +0200, Laurent Pinchart wrote: On Wednesday 01 June 2011 16:03:06 Russell King - ARM Linux wrote: On Wed, Jun 01, 2011 at 03:50:50PM +0200, Laurent Pinchart wrote

Re: [PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-06 Thread Laurent Pinchart
Hi Russell, On Monday 06 June 2011 18:44:00 Russell King - ARM Linux wrote: On Mon, Jun 06, 2011 at 06:23:18PM +0200, Laurent Pinchart wrote: Hi Russell, On Friday 03 June 2011 08:32:12 Russell King - ARM Linux wrote: SG chaining has _nothing_ to do with hardware. It's all to do

Re: [PATCH] media: omap3isp: fix a pontential NULL deref

2011-06-02 Thread Laurent Pinchart
; ++subdevs) { struct v4l2_subdev *sensor; struct media_entity *input; unsigned int flags; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-02 Thread Laurent Pinchart
Hi Russell, On Wednesday 01 June 2011 16:03:06 Russell King - ARM Linux wrote: On Wed, Jun 01, 2011 at 03:50:50PM +0200, Laurent Pinchart wrote: In the specific iovmm case, the driver uses the sglist API to build a list of page-size sg entries, and then process it in software

[PATCH v2 2/2] omap3: iovmm: Support non page-aligned buffers in iommu_vmap

2011-06-01 Thread Laurent Pinchart
The IOMMU virtual memory mapping API requires page-aligned buffers. There's no hardware reason behind such a restriction. Remove it by rounding the address of the first page entry down, and adding the offset back to the IOMMU virtual address. Signed-off-by: Laurent Pinchart laurent.pinch

[PATCH v2 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-01 Thread Laurent Pinchart
__sg_alloc_table instead of sg_alloc_table and allocate all entries in one go. Otherwise trying to use a large userspace to capture video will hit a BUG_ON in __sg_alloc_table. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hiroshi DOYU hiroshi.d...@nokia.com --- arch/arm

Re: [PATCH v2 2/2] omap3: iovmm: Support non page-aligned buffers in iommu_vmap

2011-06-01 Thread Laurent Pinchart
On Wednesday 01 June 2011 14:50:24 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [110601 05:21]: The IOMMU virtual memory mapping API requires page-aligned buffers. There's no hardware reason behind such a restriction. Remove it by rounding the address

[PATCH v3 2/2] omap3: iovmm: Support non page-aligned buffers in iommu_vmap

2011-06-01 Thread Laurent Pinchart
The IOMMU virtual memory mapping API requires page-aligned buffers. There's no hardware reason behind such a restriction. Remove it by rounding the address of the first page entry down, and adding the offset back to the IOMMU virtual address. Signed-off-by: Laurent Pinchart laurent.pinch

[PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-01 Thread Laurent Pinchart
__sg_alloc_table instead of sg_alloc_table and allocate all entries in one go. Otherwise trying to use a large userspace buffers to capture video will hit a BUG_ON in __sg_alloc_table. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hiroshi DOYU hiroshi.d...@nokia.com

Re: [PATCH v3 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-06-01 Thread Laurent Pinchart
Hi Russell, On Wednesday 01 June 2011 15:43:38 Russell King - ARM Linux wrote: On Wed, Jun 01, 2011 at 03:30:11PM +0200, Laurent Pinchart wrote: sg_alloc_table can only allocate multi-page scatter-gather list tables if the architecture supports scatter-gather lists chaining. ARM doesn't

[PATCH 0/2] OMAP3 IOMMU fixes

2011-05-30 Thread Laurent Pinchart
Hi everybody, Here are two OMAP3 IOMMU fixes required to support big and/or unaligned memory buffers. Laurent Pinchart (2): omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU omap3: iovmm: Support non page-aligned buffers in iommu_vmap arch/arm/plat-omap/iovmm.c | 46

[PATCH 1/2] omap3: iovmm: Work around sg_alloc_table size limitation in IOMMU

2011-05-30 Thread Laurent Pinchart
__sg_alloc_table instead of sg_alloc_table and allocate all entries in one go. This avoids hitting a BUG_ON in __sg_alloc_table while still not faking sg list chaining support. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Hiroshi DOYU hiroshi.d...@nokia.com --- arch/arm/plat

[PATCH 2/2] omap3: iovmm: Support non page-aligned buffers in iommu_vmap

2011-05-30 Thread Laurent Pinchart
The IOMMU virtual memory mapping API requires page-aligned buffers. There's no hardware reason behind such a restriction. Remove it by rounding the address of the first page entry down, and adding the offset back to the IOMMU virtual address. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [PATCH] media: omap3isp: fix format string warning

2011-05-30 Thread Laurent Pinchart
(name); i++) { if ((1 i) irqstatus) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor driver.

2011-05-23 Thread Laurent Pinchart
to gpio_request_one(), and then modify this patch to use gpio_request_one(). If you want to learn how to use coccinelle (http://coccinelle.lip6.fr/), now would be a good time. You could use it to replace gpio_request() + gpio_direction_output() through the whole kernel. -- Regards, Laurent Pinchart

Re: dsp

2011-05-15 Thread Laurent Pinchart
or some other abstraction. There's currently no standard user/kernel API to handle communication with DSPs. For the OMAP3, http://code.google.com/p/gst-dsp/downloads/list can be interesting. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [URGENT - PATCH FOR 2.6.39] omap: iommu: Return IRQ_HANDLED in fault handler when no fault occured

2011-05-10 Thread Laurent Pinchart
Hi Tony, On Friday 29 April 2011 12:03:10 Laurent Pinchart wrote: Hi Tony, On Wednesday 27 April 2011 16:03:02 Laurent Pinchart wrote: The iommu shares an interrupt line with the OMAP3 ISP. The iommu interrupt handler must check the fault status and return IRQ_HANDLED when no fault

[PATCH v2 FOR 2.6.39] omap: iommu: Return IRQ_HANDLED in fault handler when no fault occured

2011-05-10 Thread Laurent Pinchart
to the OMAP3 ISP driver. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hiroshi DOYU hiroshi.d...@nokia.com --- arch/arm/plat-omap/iommu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c index

Re: [PATCH v5 03/10] OMAP4 : DSS2 : HDMI: Dispc gamma enable set/reset function for TV.

2011-05-05 Thread Laurent Pinchart
); int dispc_setup_plane(enum omap_plane plane, u32 paddr, u16 screen_width, u16 pos_x, u16 pos_y, -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 2/2] OMAP3: RX-51: define vdds_csib regulator supply

2011-05-03 Thread Laurent Pinchart
can keep your SoB line with that change). }; /* VAUX3 - adds more power to VIO_18 rail */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 2/2] OMAP3: RX-51: define vdds_csib regulator supply

2011-05-03 Thread Laurent Pinchart
Hi Kalle, On Tuesday 03 May 2011 12:51:56 kalle.jokini...@nokia.com wrote: On 3. toukokuuta 2011 13:49 Laurent Pinchart wrote: On Tuesday 03 May 2011 12:41:23 Kalle Jokiniemi wrote: The RX-51 uses the CSIb IO complex for camera operation. The board file is missing definition

Re: [PATCH v2 1/2] OMAP3: ISP: Add regulator control for omap34xx

2011-05-02 Thread Laurent Pinchart
kalle.jokini...@nokia.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispccp2.c | 27 +-- drivers/media/video/omap3isp/ispccp2.h |1 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/media/video

Re: [PATCH v2 2/2] OMAP3: RX-51: define vdds_csib regulator supply

2011-05-02 Thread Laurent Pinchart
), + .consumer_supplies = rx51_vaux2_supplies, }; /* VAUX3 - adds more power to VIO_18 rail */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] OMAP3: ISP: Add regulator control for omap34xx

2011-04-29 Thread Laurent Pinchart
mem_cfg; struct isp_video video_in; struct isp_csiphy *phy; + struct regulator *vdds_csib; unsigned int error; enum isp_pipeline_stream_state state; wait_queue_head_t wait; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH FOR 2.6.39] omap: iommu: Return IRQ_HANDLED in fault handler when no fault occured

2011-04-29 Thread Laurent Pinchart
Hi Tony, On Wednesday 27 April 2011 16:03:02 Laurent Pinchart wrote: The iommu shares an interrupt line with the OMAP3 ISP. The iommu interrupt handler must check the fault status and return IRQ_HANDLED when no fault occured. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[PATCH FOR 2.6.39] omap: iommu: Return IRQ_HANDLED in fault handler when no fault occured

2011-04-27 Thread Laurent Pinchart
The iommu shares an interrupt line with the OMAP3 ISP. The iommu interrupt handler must check the fault status and return IRQ_HANDLED when no fault occured. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/plat-omap/iommu.c |2 ++ 1 files changed, 2 insertions

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-04-06 Thread Laurent Pinchart
Hi David, On Tuesday 05 April 2011 13:54:09 David Cohen wrote: On Tue, Apr 5, 2011 at 2:23 PM, Laurent Pinchart wrote: [snip] We only have iommu2.ko at the moment. I've heard about an iommu1.ko being worked on, but I don't have more information. We don't know whether the OMAP5

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-04-05 Thread Laurent Pinchart
Hi Sakari, On Tuesday 05 April 2011 11:03:21 Sakari Ailus wrote: Laurent Pinchart wrote: [snip] Let me try to summarize the issue and the requirements. IOMMU support on OMAP platforms uses an OMAP-specific implementation, divided into 3 layers: - the IOVMM layer (arch/arm/plat

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-04-04 Thread Laurent Pinchart
Hi David, On Wednesday 30 March 2011 17:50:17 David Cohen wrote: On Wed, Mar 30, 2011 at 4:56 PM, Laurent Pinchart wrote: On Wednesday 30 March 2011 15:50:37 Sakari Ailus wrote: Laurent Pinchart wrote: On Wednesday 30 March 2011 10:16:56 Sakari Ailus wrote: Laurent Pinchart wrote

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-03-30 Thread Laurent Pinchart
Hi Sakari, On Wednesday 30 March 2011 10:16:56 Sakari Ailus wrote: Laurent Pinchart wrote: On Friday 25 March 2011 20:37:55 Ramirez Luna, Omar wrote: On Fri, Mar 25, 2011 at 10:13 AM, Sakari Ailus wrote: Hi, This patchset is aimed to fix a problem in arch_iommu implementation

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-03-30 Thread Laurent Pinchart
On Wednesday 30 March 2011 15:50:37 Sakari Ailus wrote: Laurent Pinchart wrote: Hi Sakari, Hi Laurent, On Wednesday 30 March 2011 10:16:56 Sakari Ailus wrote: Laurent Pinchart wrote: On Friday 25 March 2011 20:37:55 Ramirez Luna, Omar wrote: On Fri, Mar 25, 2011 at 10:13 AM, Sakari

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-03-29 Thread Laurent Pinchart
and played with the pointers, if needed we can give better naming. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] iommu: Prevent oops in iommu_get() and while arch_iommu is in use

2011-03-29 Thread Laurent Pinchart
#include plat/iommu2.h #endif A new else defining the install/uninstall_arch_iommu functions or simply reversing the check to be OMAP2+ and error on anything else. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH] omap: iommu: disallow mapping NULL address

2011-03-08 Thread Laurent Pinchart
Hi David, On Monday 07 March 2011 22:35:31 David Cohen wrote: On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart wrote: On Monday 07 March 2011 20:41:21 David Cohen wrote: On Mon, Mar 7, 2011 at 9:25 PM, Guzman Lugo, Fernando wrote: On Mon, Mar 7, 2011 at 1:19 PM, David Cohen wrote

Re: [PATCH] omap: iommu: disallow mapping NULL address

2011-03-07 Thread Laurent Pinchart
should rely only on pdata. Michael, what about just update ISP's da_start on omap-iommu.c file? Set it to 0x1000. What about patching the OMAP3 ISP driver to use a non-zero value (maybe -1) as an invalid/freed pointer ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send

[PATCH v6 04/10] omap2: Fix camera resources for multiomap

2011-02-14 Thread Laurent Pinchart
From: Sergio Aguirre saagui...@ti.com Make sure the kernel can be compiled with both OMAP2 and OMAP3 camera support linked in, and give public symbols proper omap2/omap3 prefixes. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked

[PATCH v6 10/10] omap3isp: Kconfig and Makefile

2011-02-14 Thread Laurent Pinchart
Add the OMAP3 ISP driver to the kernel build system. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig| 13 + drivers/media/video/Makefile |2 ++ drivers/media/video/omap3-isp/Makefile | 13

[PATCH v6 00/10] OMAP3 ISP driver

2011-02-14 Thread Laurent Pinchart
: Statistics Laurent Pinchart (5): omap3: Add function to register omap3isp platform device structure omap3isp: Video devices and buffers queue omap3isp: CCP2/CSI2 receivers omap3isp: CCDC, preview engine and resizer omap3isp: Kconfig and Makefile Sakari Ailus (1): omap3isp: OMAP3 ISP

[PATCH v6 03/10] omap3: Add function to register omap3isp platform device structure

2011-02-14 Thread Laurent Pinchart
The omap3isp platform device requires platform data. Instead of registering the device in omap2_init_devices(), export an omap3_init_camera() function to fill the device structure with the platform data pointer and register the device. Signed-off-by: Laurent Pinchart laurent.pinch

[PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource

2011-02-14 Thread Laurent Pinchart
From: Sergio Aguirre saagui...@ti.com The ISP CBUFF module isn't use, its resource isn't needed. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/devices.c |5 - 1

[PATCH v6 01/10] ARM: OMAP3: Update Camera ISP definitions for OMAP3630

2011-02-14 Thread Laurent Pinchart
From: Tuukka Toivonen tuukka...@gmail.com Add new/changed base address definitions and resources for OMAP3630 ISP. The OMAP3430 CSI2PHY block is same as the OMAP3630 CSIPHY2 block. But the later name is chosen as it gives more symmetry to the names. Signed-off-by: Tuukka Toivonen

Re: [PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource

2011-02-14 Thread Laurent Pinchart
Hi Felipe, On Monday 14 February 2011 13:31:06 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:29PM +0100, Laurent Pinchart wrote: From: Sergio Aguirre saagui...@ti.com The ISP CBUFF module isn't use, its resource isn't needed. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked

Re: [PATCH v6 03/10] omap3: Add function to register omap3isp platform device structure

2011-02-14 Thread Laurent Pinchart
Hi Felipe, On Monday 14 February 2011 13:34:30 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:30PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index d389756..4cf48ea 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm

Re: [PATCH v6 04/10] omap2: Fix camera resources for multiomap

2011-02-14 Thread Laurent Pinchart
Hi Felipe, Thanks for the review. On Monday 14 February 2011 13:35:59 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 4cf48ea..5d844bd 100644 --- a/arch/arm/mach-omap2

Re: [PATCH v6 07/10] omap3isp: CCP2/CSI2 receivers

2011-02-14 Thread Laurent Pinchart
Hi Felipe, On Monday 14 February 2011 13:37:39 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:34PM +0100, Laurent Pinchart wrote: The OMAP3 ISP CCP2 and CSI2 receivers provide an interface to connect serial MIPI sensors to the device. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [PATCH v6 07/10] omap3isp: CCP2/CSI2 receivers

2011-02-14 Thread Laurent Pinchart
Hi Felipe, On Monday 14 February 2011 13:37:39 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:34PM +0100, Laurent Pinchart wrote: The OMAP3 ISP CCP2 and CSI2 receivers provide an interface to connect serial MIPI sensors to the device. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [PATCH v6 04/10] omap2: Fix camera resources for multiomap

2011-02-14 Thread Laurent Pinchart
Hi Felipe, On Monday 14 February 2011 14:41:16 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 02:19:24PM +0100, Laurent Pinchart wrote: On Monday 14 February 2011 13:35:59 Felipe Balbi wrote: On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: diff --git a/arch/arm/mach-omap2

Re: [PATCH v5 0/5] OMAP3 ISP driver

2011-02-08 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Friday 04 February 2011 12:55:50 Hans Verkuil wrote: On Thursday, January 27, 2011 13:32:16 Laurent Pinchart wrote: Hi everybody, Here's the fifth version of the OMAP3 ISP driver patches, updated to 2.6.37 and the latest changes in the media

[PATCH v5 3/5] omap3: Add function to register omap3isp platform device structure

2011-01-27 Thread Laurent Pinchart
The omap3isp platform device requires platform data. Instead of registering the device in omap2_init_devices(), export an omap3_init_camera() function to fill the device structure with the platform data pointer and register the device. Signed-off-by: Laurent Pinchart laurent.pinch

[PATCH v5 4/5] omap2: Fix camera resources for multiomap

2011-01-27 Thread Laurent Pinchart
From: Sergio Aguirre saagui...@ti.com Make sure the kernel can be compiled with both OMAP2 and OMAP3 camera support linked in, and give public symbols proper omap2/omap3 prefixes. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[PATCH v5 1/5] ARM: OMAP3: Update Camera ISP definitions for OMAP3630

2011-01-27 Thread Laurent Pinchart
From: Tuukka Toivonen tuukka.o.toivo...@nokia.com Add new/changed base address definitions and resources for OMAP3630 ISP. The OMAP3430 CSI2PHY block is same as the OMAP3630 CSIPHY2 block. But the later name is chosen as it gives more symmetry to the names. Signed-off-by: Tuukka Toivonen

[PATCH v5 2/5] omap3: Remove unusued ISP CBUFF resource

2011-01-27 Thread Laurent Pinchart
From: Sergio Aguirre saagui...@ti.com The ISP CBUFF module isn't use, its resource isn't needed. Signed-off-by: Sergio Aguirre saagui...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c |5 - 1 files changed, 0 insertions(+), 5

[PATCH v5 0/5] OMAP3 ISP driver

2011-01-27 Thread Laurent Pinchart
Hi everybody, Here's the fifth version of the OMAP3 ISP driver patches, updated to 2.6.37 and the latest changes in the media controller and sub-device APIs. You can find the patches in http://git.linuxtv.org/pinchartl/media.git as usual (media-0005-omap3isp). Laurent Pinchart (2): omap3: Add

Re: [PATCH 00/13] OMAP: Basic DVFS Framework

2011-01-24 Thread Laurent Pinchart
. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] arm: omap3evm: Add support for an MT9M032 based camera board.

2011-01-18 Thread Laurent Pinchart
); +err_vdsel: + gpio_free(nCAM_VD_SEL); +err: + return -EINVAL; +} + +device_initcall(camera_init); If the code is kept in its own file, you should make camera_init non-static (and rename it) and call it from the OMAP3 EVM initialization function instead. -- Regards, Laurent Pinchart

OMAP3 ISP suspend/resume question

2010-12-21 Thread Laurent Pinchart
on both issues. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dspbridge: Fix atoi to support hexadecimal numbers correctly

2010-12-16 Thread Laurent Pinchart
Hi everybody, Ping ? On Sunday 12 December 2010 14:39:37 Laurent Pinchart wrote: For some strange reason, the DSP base image node/object properties description string stores hexadecimal numbers with a 'h' or 'H' suffix instead of a '0x' prefix. This causes parsing issue because the dspbridge

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Laurent Pinchart
; I will already incorporate this change, and I'll wait for other opinions on the types before changing them. int dvb; /* Sub-device specifications */ /* Nothing needed yet */ __u8 raw[184]; }; }; -- Regards, Laurent

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Laurent Pinchart
that ? What if you have two instances of the same chip (a video sensor, audio mixer, ...) on the same board ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Laurent Pinchart
Hi Clemens, On Tuesday 14 December 2010 14:31:55 Clemens Ladisch wrote: Laurent Pinchart wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: TYPE_EXT describes entities that represent some interface to the external world, TYPE_INT those that are internal to the entire device

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Laurent Pinchart
Hi Hans, On Tuesday 14 December 2010 15:51:08 Hans Verkuil wrote: Laurent Pinchart wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: TYPE_EXT describes entities that represent some interface to the external world, TYPE_INT those that are internal to the entire device

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Laurent Pinchart
Hi Clemens, On Tuesday 14 December 2010 14:49:15 Clemens Ladisch wrote: Laurent Pinchart wrote: On Tuesday 14 December 2010 13:40:21 Hans Verkuil wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: * Entity types TYPE_NODE was renamed to TYPE_DEVICE because node

Re: Inconsistent lock state caused by omap_mbox_msg_send() called from tidspbridge

2010-12-13 Thread Laurent Pinchart
to spin_lock_bh() is justifiable, too, since it adds a sending path which is parallel to the mailbox tasklet. Is this patch set ready for inclusion in the mainline kernel, or does it need to be reworked ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux

OMAP3 DSP baseimage with SYS_printf support

2010-12-13 Thread Laurent Pinchart
are not publicly available, does anyone know if TI plans to provide a binary version with SYS_printf support enabled ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] staging: tidspbridge: use the right type for list_is_last

2010-12-12 Thread Laurent Pinchart
argument 1 of 'list_is_last' from incompatible pointer type include/linux/list.h:170: note: expected 'const struct list_head *' but argument is of type 'struct rmm_ovly_sect *' I was about to send the same patch. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com Acked-by: Laurent Pinchart

Inconsistent lock state caused by omap_mbox_msg_send() called from tidspbridge

2010-12-12 Thread Laurent Pinchart
a status update on this ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] dspbridge: Fix atoi to support hexadecimal numbers correctly

2010-12-12 Thread Laurent Pinchart
/staging/tidspbridge/rmgr/nldr.c, line 1691: Assertion (segid == MEMINTERNALID || segid == MEMEXTERNALID) failed. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/tidspbridge/rmgr/dbdcd.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git

[PATCH 0/2] Misc LED-related IGEPv2 patches

2010-12-12 Thread Laurent Pinchart
Hi, Here are two small patches for the IGEPv2 board file to cleanup LED support and configure the heartbeat LED as active low. The second patch is valid for revision C hardware, I don't know if the LED is active low on revision B hardware as well. Laurent Pinchart (2): omap3: igepv2: Don't

[PATCH 1/2] omap3: igepv2: Don't call gpio_set_value right after gpio_direction_output

2010-12-12 Thread Laurent Pinchart
gpio_direction_output() has a value argument, there's no need to call gpio_set_value() explicitly right after. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/board-igep0020.c | 20 1 files changed, 8 insertions(+), 12 deletions

[PATCH 2/2] omap3: igepv2: LED gpio-led:green:d1 is active low

2010-12-12 Thread Laurent Pinchart
Make sure the LED is turned off at boot time, and configure the GPIO LED device as active low. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/board-igep0020.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-09 Thread Laurent Pinchart
to activated when talking about links ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure

2010-12-09 Thread Laurent Pinchart
Hi Tony, On Monday 06 December 2010 20:32:13 Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [101125 03:13]: Hi, On Thu, Nov 25, 2010 at 12:17:59PM +0100, Laurent Pinchart wrote: pass platform_data as an argument to this call ? Then remove the static inline and export this one

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-03 Thread Laurent Pinchart
Hi Hans, Adding by the original CC list which was dropped by mistake. On Friday 03 December 2010 13:06:18 Hans Verkuil wrote: On Friday, December 03, 2010 11:19:36 Laurent Pinchart wrote: On Sunday 28 November 2010 16:57:00 you wrote: On Sunday, November 28, 2010 13:34:45 Laurent Pinchart

Re: [RFC/PATCH v6 05/12] media: Reference count and power handling

2010-11-28 Thread Laurent Pinchart
could use it if they want graph-based power management. ALSA would have its own use count handler. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-28 Thread Laurent Pinchart
Hi Mark, On Friday 26 November 2010 15:14:42 Mark Brown wrote: On Fri, Nov 26, 2010 at 03:13:36PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 16:49:52 Mark Brown wrote: On Thu, Nov 25, 2010 at 04:40:41PM +0100, Laurent Pinchart wrote: It's supposed to reflect whether

Re: [RFC/PATCH v6 00/12] Media controller (core and V4L2)

2010-11-26 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 15:28:04 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:07AM +0100, Laurent Pinchart wrote: I want to emphasize that the media controller API does *not* replace the V4L, DVB or ALSA APIs. It complements them. Overall this looks relatively good

Re: [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-11-26 Thread Laurent Pinchart
Hi Mark, On Thursday 25 November 2010 16:49:52 Mark Brown wrote: On Thu, Nov 25, 2010 at 04:40:41PM +0100, Laurent Pinchart wrote: On Thursday 25 November 2010 14:36:50 Mark Brown wrote: On Thu, Nov 25, 2010 at 03:28:10AM +0100, Laurent Pinchart wrote: + MEDIA_LINK_FLAG_ACTIVE

Re: [RFC/PATCH v3 6/7] omap3: Export omap3isp platform device structure

2010-11-25 Thread Laurent Pinchart
Hi Felipe, On Thursday 25 November 2010 08:02:41 Felipe Balbi wrote: On Thu, Nov 25, 2010 at 03:54:37AM +0100, Laurent Pinchart wrote: From: Stanimir Varbanov svarba...@mm-sol.com The omap3isp platform device requires platform data. As the data can be provided by a kernel module, the device

Re: [RFC/PATCH v6 11/12] v4l: Make video_device inherit from media_entity

2010-11-25 Thread Laurent Pinchart
Hi Hans, Thanks for the review. On Thursday 25 November 2010 12:38:15 Hans Verkuil wrote: On Thursday, November 25, 2010 03:28:18 Laurent Pinchart wrote: V4L2 devices are media entities. As such they need to inherit from (include) the media_entity structure. When registering

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Laurent Pinchart
Hi Clemens, Thanks for the review. On Thursday 25 November 2010 10:33:02 Clemens Ladisch wrote: Laurent Pinchart wrote: +struct media_device { ... + u8 model[32]; + u8 serial[40]; + u8 bus_info[32]; All drivers and userspace applications have to treat this as char[], so why

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Laurent Pinchart
Hi Clemens, Thanks a lot for the review. On Thursday 25 November 2010 10:38:05 Clemens Ladisch wrote: Laurent Pinchart wrote: A link is a point-to-point oriented connection between two pads, either on the same entity or on different entities. Data flows from a source pad to a sink pad

<    1   2   3   4   5   6   >