Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Ulrik Bech Hald
Sent: Monday, June 22, 2009 3:25 PM
To: linux-omap@vger.kernel.org
Cc: Hald, Ulrik Bech
- if (twl_has_keypad() pdata-keypad) {
+ if (twl_has_keypad() pdata-keypad
+ !(features TLW6030)) {
child = add_child(2, twl4030_keypad,
pdata-keypad, sizeof(*pdata-keypad),
Hi folks,
We have a new TWL6030 chip that is coming in. In brief, the following are the
changes w.r.t. TWL5030:
0. This is the companion chip for OMAP4430.
1. Unlike in TWL5030, audio and power chips are going to be separate chips as
TWL6030 and TWL6031.
2. Keypad and GPIO features are no
This patch:
- Creates a new file twl.c
- Segregates functions common between TWL4030 and TWL6030 and moves
them from twl4030-core.cinto twl.c
Index: linux-omap-2.6/drivers/mfd/twl.c
===
--- /dev/null
+++
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Woodruff, Richard
Sent: Tuesday, February 24, 2009 6:47 PM
To: Aaro Koskinen; ext Nishanth Menon
Cc: Nurkkala Eero.An (EXT-Offcode/Oulu); linux-omap@vger.kernel.org
Kevin,
Did you get a chance to review this patch?
--
Jagadeesh
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Pakaravoor, Jagadeesh
Sent: Thursday, January 22, 2009 12:49 PM
To: linux-omap@vger.kernel.org
Cc
Hi,
omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, dev-iestate);
@@ -300,14 +302,15 @@ static int omap_i2c_init(struct omap_i2c
} else if (dev-rev = OMAP_I2C_REV_ON_3430) {
u32 v;
This local variable is left unused, so you will get a compiler
Hi,
Is it a necesary bugfix, or should it wait for the next merge window?
You can line it up for the next merge window.
-Jagadeesh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Ben,
is this necessary for inclusion as a bugfix, or can it wait
for a merge window?
This patch applies to Linux Omap tree only. It is a bug fix, and preferably
taken ASAP. I'd like to incorporate your review comments, if you have any.
-Jagadeesh
--
To unsubscribe from this list: send the
Ben,
Did you get a chance to look at this patch?
-Original Message-
From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c-ow...@vger.kernel.org]
On Behalf Of Pakaravoor, Jagadeesh
Sent: Friday, January 23, 2009 2:19 PM
To: linux-...@vger.kernel.org
Cc: linux-omap@vger.kernel.org
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Include wake up events for receiver overflow and transmitter
underflow in OMAP_I2C_WE_REG configuration. Also fix a small
typo.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
---
Index:
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Save and restore should include OMAP_I2C_SYSC_REG.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
CC: Jouni Hogander jouni.hogan...@nokia.com
---
Index: linux-omap-2.6/drivers/i2c/busses/i2c-omap.c
]
On Behalf Of Pakaravoor, Jagadeesh
Sent: Friday, January 23, 2009 12:25 PM
To: linux-...@vger.kernel.org; linux-omap@vger.kernel.org
Cc: Jean Delvare
Subject: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore
From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com
Save and restore should
For i2c-omap.c, on the origin/pm branch, upon save and restore,
OMAP_I2C_SYSC_REG is not saved and restored.
Any specific reason, why it is so? Or is it a bug?
TIA.
--
With Regards,
Jagadeesh Bhaskar P
Some men see things as they are and say why - I dream things
Ergo the observation that the TWL5030 ES1.0
parts seem to mis-identify themselves.
The delta TRM between TWL4030 and TWL5030 has a note, which says,
The part code number is meaning less when accessed through the I2C;
which means, over JTAG, the ID code should reflect 0x0009802F.
I have not
What was wrong with this patch?
http://marc.info/?l=linux-omapm=122277286326989w=2
--
Jagadeesh
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Fix a trivial typo.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
---
Index: linux-omap-git/drivers/mfd/twl4030-core.c
===
---
I had sent that fix for the same, though not merged in yet. :)
Oops.. I forgot about V2 patch. :(
==Cut here==
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Return type of gpmc_init() function is void. Also, the error values
returned by the function is not used by the caller. Hence it
The general policy on comments is that they should not
be translating the C code into English. Not only are
such comments pointless (the C code says the same thing,
more precisely) but they also are more likely to become
obsolete as the code changes. (That's a well known
problem: comments
/*
- * twl4030_irq_thread() runs as a kernel thread. It queries the twl4030
- * interrupt controller to see which modules are generating interrupt
requests
- * and then calls the desc-handle method for each module requesting service.
+ * This thread processes interrupts reported by the
/* request Power interruption */
- ret = request_irq(TWL4030_PWRIRQ_CHG_PRES, twl4030charger_interrupt,
+ ret = request_irq(irq, twl4030charger_interrupt,
0, pdev-name, di);
BCI was requesting TWL4030_PWRIRQ_CHG_PRES.
batt_failed:
-
- ret = request_irq(TWL4030_PWRIRQ_RTC, twl4030_rtc_interrupt,
+ ret = request_irq(irq, twl4030_rtc_interrupt,
0, rtc-dev.bus_id, rtc);
RTC was requesting TWL4030_PWRIRQ_RTC.
out2:
- free_irq(TWL4030_MODIRQ_PWR, rtc);
+ free_irq(irq, rtc);
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Following patch taken over the omapzoom.org tree fixes OMAP 3430
errata 1.11 for I2C: if the I2C module is configured as slave,
in autoidle mode (I2C_SYSC.AUTOIDLE=1) and the ARDY (I2C.I2C_STAT[2])
condition and the START condition are
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Return type of gpmc_init() function is void. Also, the error values
returned by the function is not used by the caller. Hence it should
not be returning any value.
Signed-off-by: Anand Gadiyar [EMAIL PROTECTED]
Signed-off-by: Jagadeesh Bhaskar
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Return type of gpmc_init() function is void. Also, the error values
returned by the function is not used by the caller. Hence it should
not be returning any value.
Signed-off-by: Anand Gadiyar [EMAIL PROTECTED]
Signed-off-by: Jagadeesh Bhaskar
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
One twl4030_request_gpio() should not tamper with the pullup
enabling/disabling of the rest of the GPIOs. So removing the default
pullup values written to REG_GPIOPUPDCTR1.
Signed-off-by: Girish S G [EMAIL PROTECTED]
Signed-off-by: Jagadeesh
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of David
Brownell
Sent: Thursday, September 04, 2008 11:19 PM
To: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc5-omap1] rtc-twl4030 cleanup
On Thursday 04 September 2008, David Brownell
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
RTC generates an extra spurious interrupt for every actual periodic
interrupt. This is due to a problem with the RTC_IT bit of
REG_PWR_ISR1. It requires two writes or two reads (when COR is
enabled) to clear it. Since COR is enabled and one
-Original Message-
From: David Brownell [mailto:[EMAIL PROTECTED]
Sent: Friday, September 05, 2008 1:40 PM
To: Pakaravoor, Jagadeesh
Cc: linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc5-omap1] rtc-twl4030 cleanup
On Friday 05 September 2008, Pakaravoor, Jagadeesh wrote
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
TWL4030-RTC: Fix the broken functionality.
rtc_irq_set_freq() function takes only powers of 2 as a valid
argument. This stipulates that an ioctl call on /dev/rtc0
can accept values of 1,2,4 and 8 only. But the function
From: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
TWL4030-RTC: Remove obsolete comment.
Signed-off-by: Jagadeesh Bhaskar Pakaravoor [EMAIL PROTECTED]
Index: my-local-git-dir/drivers/rtc/rtc-twl4030.c
===
---
-Original Message-
From: Felipe Balbi [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 19, 2008 8:12 PM
To: Pakaravoor, Jagadeesh
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] TWL4030-RTC: Remove obsolete comment
On Tue, Aug 19, 2008 at 07:50:26PM +0530, ext Pakaravoor
32 matches
Mail list logo
