Re: [PATCH v2 5/5] ARM: OMAP2+: clean up some cppcheck warnings

2012-03-13 Thread Varadarajan, Charulatha
On Tue, Mar 13, 2012 at 13:42, Paul Walmsley p...@pwsan.com wrote: Resolve some warnings identified by cppcheck in arch/arm/mach-omap2:    [arch/arm/mach-omap2/usb-tusb6010.c:129]: (style) Checking if unsigned variable 'tmp' is less than zero.    [arch/arm/mach-omap2/prm_common.c:241]:

Re: [PATCH v9 01/25] gpio/omap: remove dependency on gpio_bank_count

2012-02-05 Thread Varadarajan, Charulatha
Felipe, On Sun, Feb 5, 2012 at 14:38, Felipe Balbi ba...@ti.com wrote: Hi, On Sun, Feb 05, 2012 at 12:37:55PM +0530, Varadarajan, Charulatha wrote: Felipe, On Sat, Feb 4, 2012 at 21:38, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Feb 03, 2012 at 09:50:19AM -0800, Kevin Hilman wrote

Re: [PATCH v9 01/25] gpio/omap: remove dependency on gpio_bank_count

2012-02-04 Thread Varadarajan, Charulatha
Felipe, On Sat, Feb 4, 2012 at 21:38, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Feb 03, 2012 at 09:50:19AM -0800, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: [...] This question remains. Why do we need those funtions ? These functions are called from the CPUIdle

Re: gpio interrupt is not invoked on Panda board

2011-07-03 Thread Varadarajan, Charulatha
Hong, On Sat, Jul 2, 2011 at 04:45, hong zhang henryzhan...@yahoo.com wrote: --- On Fri, 7/1/11, Jon Hunter jon-hun...@ti.com wrote: From: Jon Hunter jon-hun...@ti.com Subject: Re: gpio interrupt is not invoked on Panda board To: hong zhang henryzhan...@yahoo.com Cc:

Re: [RFC 11/12] omap: mcbsp: Remove conditional compilation for OMAP3

2011-07-01 Thread Varadarajan, Charulatha
Jarkko, On Fri, Jul 1, 2011 at 14:22, Jarkko Nikula jhnik...@gmail.com wrote: Although this increases the build size a little for !OMAP3 builds it makes the code one step more generic. For instance the threshold based DMA transfers seems to be possible with OMAP4 too from quick look of the

Re: [RFC 07/12] omap: mcbsp: Get rid of remaining is_omap tests

2011-07-01 Thread Varadarajan, Charulatha
Jarkko, On Fri, Jul 1, 2011 at 14:22, Jarkko Nikula jhnik...@gmail.com wrote: We can get rid of remaining is_omap tests in the driver by using mcbsp_config_type that is set in omap hwmod data for 2430, 34xx and 44xx. Signed-off-by: Jarkko Nikula jhnik...@gmail.com ---  

Re: [PATCH 15/15] OMAP: GPIO: clean omap_gpio_mod_init function

2011-06-03 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 05:18, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com With register offsets now defined for respective OMAP versions we can get rid of cpu_class_* checks. In addition, organized common

Re: [PATCH 12/15] OMAP: GPIO: Fix: use wake set/clear regs

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:44, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com In set_24xx_gpio_triggering(), for OMAP4, GPIO wakeup request is set for all type of GPIO triggers whereas as per TRM the GPIO wakeup request can

Re: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:31, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: It is not required to use hard-coded offsets any more in context save and restore functions and instead use the generic offsets which have been correctly initialized during device

Re: [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:09, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Make workaround_enabled flag bank-specific instead of using a single flag for all the banks together. This would be helpful while making use of

Re: [PATCH 06/15] OMAP4: GPIO: Save/restore context

2011-05-26 Thread Varadarajan, Charulatha
Kevin, Thanks for the comments on this series. On Thu, May 26, 2011 at 03:13, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Modify the omap_gpio_save/restore_context to support OMAP4 architecture so that the OMAP GPIO

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But the GPIO driver initializes the non-wakeup GPIO bits for OMAP24xx (bothe OMAP

Re: [PATCH 01/15] OMAP: GPIO: Avoid cpu_is checks during module ena/disable

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 02:49, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Remove cpu-is checks while enabling/disabling OMAP GPIO module during a gpio request/free. Signed-off-by: Charulatha V ch...@ti.com This looks

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
-omap@vger.kernel.org Cc: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha; Cousson, Benoit; Paul Walmsley Subject: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids From: Charulatha V ch...@ti.com Non-wakeup

Re: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore

2011-05-26 Thread Varadarajan, Charulatha
: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; DebBarma, Tarun Kanti; Varadarajan, Charulatha Subject: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore It is not required to use hard-coded offsets any more in context save

Re: [PATCH 13/15] OMAP: GPIO: clean set_gpio_triggering function

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 04:57, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Getting rid of ifdefs within the function by adding register offset intctrl and associating OMAP_GPIO_INT_CONTROL in respective SoC

Re: [PATCH 09/15] OMAP: GPIO: cleanup suspend and resume functions

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 04:27, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: Since wake_status, wake_clear, wake_set is common for all banks on a given OMAP version it is enough to get their values once during probe(). Also, register offsets are

Re: [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure

2011-05-26 Thread Varadarajan, Charulatha
, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha Subject: [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure From: Charulatha V ch...@ti.com gpio_context array, which is used to save gpio bank's context, is used only

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 12:15, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Non-wakeup GPIOs

Re: [RFC PATCH 02/10] ZOOM: QUART: Request reset GPIO

2011-05-20 Thread Varadarajan, Charulatha
On Thu, May 19, 2011 at 21:41, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Reset GPIO (OMAP_GPIO_152) for QUART in zoom2/zoom3 debug-board is not requested at all. This would lead to problems if this GPIO is wrongly

Re: [RFC PATCH 04/10] OMAP: GPIO: Remove dependency on gpio_bank_count

2011-05-20 Thread Varadarajan, Charulatha
Kevin, Thanks for the comments. On Thu, May 19, 2011 at 22:09, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this dependency from the driver. Also

Re: [RFC PATCH 06/10] OMAP: GPIO: Use USHRT_MAX for rev offset instead of -1

2011-05-20 Thread Varadarajan, Charulatha
Kevin, On Thu, May 19, 2011 at 21:29, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Use USHRT_MAX for revision offset instead of -1 if revision register is not available for a given SoC since rev offset is a u16 value.

Re: [RFC PATCH 07/10] OMAP: GPIO: cleanup suspend and resume functions

2011-05-20 Thread Varadarajan, Charulatha
Tarun, On Mon, May 16, 2011 at 17:11, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Since wake_status, wake_clear, wake_set is common for all banks on a given OMAP version it is enough to get their values once during probe(). Also, register offsets are already initialzed according to OMAP

Re: [RFC PATCH 09/10] OMAP: GPIO: cleanup omap_gpio_free and triggering functions

2011-05-18 Thread Varadarajan, Charulatha
Tarun, On Mon, May 16, 2011 at 17:11, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: We can get rid of ifdef / if checks of OMAP revision in set_24xx_gpio_triggering() and omap_gpio_free(). Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Cc: Charulatha V ch...@ti.com Cc: Santosh

Re: [PATCH V2 04/16] mmc: omap_hsmmc: reduce a bit the error handlers in probe()

2011-05-06 Thread Varadarajan, Charulatha
On Fri, May 6, 2011 at 14:44, Adrian Hunter adrian.hun...@nokia.com wrote: From: Andy Shevchenko ext-andriy.shevche...@nokia.com Add patch description here. Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com Signed-off-by: Adrian Hunter adrian.hun...@nokia.com ---  

Re: [PATCH V2 16/16] mmc: omap_hsmmc: add a hardware reset before initialization

2011-05-06 Thread Varadarajan, Charulatha
Hi, On Fri, May 6, 2011 at 14:44, Adrian Hunter adrian.hun...@nokia.com wrote: After a warm restart, an eMMC which cannot be powered off is in an unknown state, so reset it to be sure it will initialize. Signed-off-by: Adrian Hunter adrian.hun...@nokia.com ---  drivers/mmc/host/omap_hsmmc.c

Re: [PATCH 0/9] OMAP: GPIO: cleanup, consolidation, etc. (v2)

2011-04-28 Thread Varadarajan, Charulatha
Kevin, On Fri, Apr 22, 2011 at 02:05, Kevin Hilman khil...@ti.com wrote: Here's an updated version of my work-in-progress GPIO cleanups. I now understand that others have some similar work in progress, so these are posted (to linux-omap only, for now) so that we can begin collaboration on

Re: [PATCH 15/15] OMAP: GPIO: cleanup show revision, remove cpu_is checks, display only once

2011-04-26 Thread Varadarajan, Charulatha
Kevin, On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Remove cpu_is_* checks from gpio_show_revision() by passing in the revision address offset from platform data.  SoCs with no revision register (15xx, 7xx, and all MPUIOs) use -1 to signify no register. While here, all

Re: [PATCH 11/15] OMAP: GPIO: convert MPUIO IRQ over to generic irq_chip

2011-04-26 Thread Varadarajan, Charulatha
Kevin, On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Signed-off-by: Kevin Hilman khil...@ti.com ---  arch/arm/plat-omap/gpio.c |   74 ++--  1 files changed, 30 insertions(+), 44 deletions(-) Patch description is missing. -V

Re: [PATCH 10/15] OMAP: GPIO: conslidate enable/disable of GPIO IRQs, remove ifdefs

2011-04-26 Thread Varadarajan, Charulatha
Kevin, On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Cleanup GPIO IRQ enable/disable handling by removing SoC-specific Also split enable/disable IRQ into separate functions for better readability and also facilitate potentially moving to generic irq_chip in the future.

Re: [PATCH 09/15] OMAP: GPIO: consolidate IRQ status handling, remove #ifdefs

2011-04-26 Thread Varadarajan, Charulatha
Kevin, On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Cleanup IRQ status handling by by passing IRQ status register offsets via platform data. Typo: by by Cleans up clearing of GPIO IRQ status and GPIO ISR handler. Signed-off-by: Kevin Hilman khil...@ti.com --- snip

Re: [PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs

2011-04-26 Thread Varadarajan, Charulatha
On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Make _set_gpio_wakeup() generic by removing ifdefs.  Code for the various SoCs/bank-methods was already the same, except for the non-wakeup GPIO checking.  But that flag is set on a per-SoC basis, so can be used for all SoCs.

Re: [PATCH 02/15] OMAP: GPIO: remove MPUIO handling from _clear_gpio_irqbank()

2011-04-25 Thread Varadarajan, Charulatha
Kevin, On Sat, Apr 23, 2011 at 04:31, Kevin Hilman khil...@ti.com wrote: Remove the OMAP1 #ifdef and MPUIO special case for _clear_gpio_irqbank() The MPUIOs do not need a register access to ack/clear the IRQ status, since reading the IRQ status clears it.  In addition, the MPUIO irq_chip has

Re: [RFC PATCH 00/18] OMAP: GPIO: cleanup GPIO driver

2011-04-25 Thread Varadarajan, Charulatha
Kevin, Thanks for your comments. On Sat, Apr 23, 2011 at 04:04, Kevin Hilman khil...@ti.com wrote: Hi Charu, Charulatha V ch...@ti.com writes: Modifies the OMAP GPIO driver to avoid usage of cpu_is* checks for different OMAP architectures. This is done by moving some architecture specific

[PATCH 5/7] OMAP2+: GPIO: make workaround_enabled bank specific

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Make workaround_enabled flag bank-specific instead of using a single flag for all the banks together. This would be helpful while making use of runtime framework in OMAP GPIO driver which would make the driver handle each GPIO bank independently. Also rename

[v2 0/7] OMAP: GPIO: Use PM runtime framework

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Use PM runtime framework in OMAP GPIO driver. Patch series is based on mainline rc3 following commit commit a1b49cb7e2a7961ec3aa8b64860bf480d4ec9077 Merge branch 'i2c-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging Changes in

[PATCH 2/7] OMAP: GPIO: Use flag to identify wkup dmn GPIO

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com In omap3, save/restore context is implemented for GPIO banks 2-6 as GPIO bank1 is in wakeup domain. Instead of identifying bank's power domain by bank id, make use of a flag losses_context which is filled by pwrdm_can_ever_lose_context() during dev_init. For

[PATCH 3/7] OMAP4: GPIO: Save/restore context

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Modify the omap_gpio_save/restore_context to support OMAP4 architecture so that the OMAP GPIO driver need not be modified when OMAP4 off mode support is available. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/plat-omap/gpio.c | 131

[PATCH 1/7] OMAP: GPIO: Make gpio_context part of gpio_bank structure

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com gpio_context array, which is used to save gpio bank's context, is used only for OMAP3 architecture. Move gpio_context as part of gpio_bank structure so that it can be specific to each gpio bank and can be used for any OMAP architecture TODO: extend the gpio

[PATCH 6/7] OMAP: GPIO: Cleanup prepare_for_idle/resume

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Use a function named gpio_bank_handle_idle() in omap_gpio_prepare_for_idle() to do the following: * debounce clock disable * if the next powerdomain state for the bank is off-mode: - remove triggering for all non-wakeup GPIOs (this is handled by a new

[PATCH 4/7] OMAP: GPIO: handle save/restore ctx in GPIO driver

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Modify omap_gpio_prepare_for_idle() omap_gpio_resume_after_idle() functions to handle save context restore context respectively in the OMAP GPIO driver itself instead of calling these functions from pm specific files. For this, in gpio_prepare_for_idle(), use

[PATCH 7/7] OMAP: GPIO: use PM runtime framework

2011-04-18 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() for enabling/disabling the clocks, sysconfig settings and remove usage of clock FW APIs. Note: OMAP16xx OMAP2 has interface and functional clocks whereas OMAP3 4 has interface and debounce

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-09 Thread Varadarajan, Charulatha
Kevin, On Wed, Mar 9, 2011 at 06:54, Varadarajan, Charulatha ch...@ti.com wrote: On Tue, Mar 8, 2011 at 13:23, Kevin Hilman khil...@ti.com wrote: On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified

Re: [PATCH 3/3] OMAP2+: powerdomain: add pwrdm_can_ever_lose_context()

2011-03-08 Thread Varadarajan, Charulatha
On Tue, Mar 8, 2011 at 07:45, Paul Walmsley p...@pwsan.com wrote: Some drivers wish to know whether the device that they control can ever lose context, for example, when the device's enclosing powerdomain loses power.  They can use this information to determine whether it is necessary to save

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-08 Thread Varadarajan, Charulatha
Kevin, On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops instead of sysdev_class. With this approach, gpio_bank_suspend() gpio_bank_resume() are not part of sys_dev_class. Usage

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-08 Thread Varadarajan, Charulatha
Kevin, On Tue, Mar 8, 2011 at 13:23, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: Kevin, On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops

Re: [PATCH 3/3] OMAP2+: powerdomain: add pwrdm_can_ever_lose_context()

2011-03-08 Thread Varadarajan, Charulatha
On Tue, Mar 8, 2011 at 13:10, Paul Walmsley p...@pwsan.com wrote: On Tue, 8 Mar 2011, Varadarajan, Charulatha wrote: Do you really want to return 1 in case of invalid powerdomain pointer? Sure, that's why I wrote it that way.  It seems less risky than returning 0.  Do you have a proposal

Re: [PATCH 2/5] OMAP: GPIO: use pwrdmn name to find wkup dmn GPIO

2011-03-07 Thread Varadarajan, Charulatha
Paul, Kevin, Thanks. On Tue, Mar 8, 2011 at 07:55, Paul Walmsley p...@pwsan.com wrote: Hi On Mon, 7 Mar 2011, Kevin Hilman wrote: Varadarajan, Charulatha ch...@ti.com writes: On Sat, Mar 5, 2011 at 02:21, Kevin Hilman khil...@ti.com wrote: Charulatha V ch...@ti.com writes

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-04 Thread Varadarajan, Charulatha
Hi Kevin, Thanks for the detailed review. On Sat, Mar 5, 2011 at 03:29, Kevin Hilman khil...@ti.com wrote: Charulatha V ch...@ti.com writes: Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get() Minor: I think you mean _get_sync() and _put() Yes, thanks for catching it. It was a

Re: [PATCH 4/5] OMAP: GPIO: call save/restore ctxt from GPIO driver

2011-03-04 Thread Varadarajan, Charulatha
On Sat, Mar 5, 2011 at 02:50, Kevin Hilman khil...@ti.com wrote: Charulatha V ch...@ti.com writes: Make gpio_prepare_for_idle() gpio_resume_after_idle() functions handle save context restore context respectively in OMAP GPIO driver instead of calling these functions directly from pm layer.

Re: [PATCH 2/5] OMAP: GPIO: use pwrdmn name to find wkup dmn GPIO

2011-03-04 Thread Varadarajan, Charulatha
On Sat, Mar 5, 2011 at 02:21, Kevin Hilman khil...@ti.com wrote: Charulatha V ch...@ti.com writes: In omap3, save/restore context is implemented for GPIO banks 2-6 as GPIO bank1 is in wakeup domain. Instead of identifying bank's power domain by bank id, make use of powerdomain name itself.

Re: Nokia n810 LCD (MIPID/blizzard) on 2.6.38

2011-03-01 Thread Varadarajan, Charulatha
Hi, On Mon, Feb 28, 2011 at 15:45, Michael Buesch m...@bu3sch.de wrote: The n810 LCD does not work on the 2.6.38(-rc6) kernel due to changes in the OMAP GPIO-hwmod code. The hwmod code performs a soft-reset on the GPIO module. The first GPIO module carries the MIPID nreset line, which is

Re: Nokia n810 LCD (MIPID/blizzard) on 2.6.38

2011-03-01 Thread Varadarajan, Charulatha
On Tue, Mar 1, 2011 at 21:59, Michael Büsch m...@bu3sch.de wrote: On Tue, 2011-03-01 at 11:23 -0500, Varadarajan, Charulatha wrote: My temporary workaround to this issue is to disable soft reset for the first GPIO module:        static struct omap_hwmod omap2420_gpio1_hwmod

Re: [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads

2011-03-01 Thread Varadarajan, Charulatha
Govind, Couple of minor comments. On Mon, Feb 28, 2011 at 20:09, Govindraj.R govindraj.r...@ti.com wrote: For device pads which have OMAP_DEVICE_PAD_WAKEUP set (which means they are wakeup capable) enable the IO-daisy wakeup capability. During re-muxing avoid direct write with val as this can

Re: [PATCH v3 4/5] OMAP: hwmod data: Add dev_attr and use in the host driver

2011-02-23 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Add a device attribute to hwmod data of omap2430, omap3, omap4. Currently the device attribute holds information regarding dual volt MMC card support by the controller which will be later passed to the host

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of   by hwmod framework. 2) Removing all base address macro defines except keeping one for OMAP2420. why? 3) Using

Re: [PATCH resend] omap: rx51: Add SI4713 FM transmitter

2011-02-20 Thread Varadarajan, Charulatha
On Mon, Feb 21, 2011 at 12:12, Jarkko Nikula jhnik...@gmail.com wrote: Add SI4713 FM transmitter supplies, platform data and setup to RX-51/N900. It is connected to line output signals of TLV320AIC34 codec A part. Driver can be either built-in or a module. It can be tuned with v4l2-ctl from

Re: [RFC/PATCH 1/3] OMAP: IOMMU: Add generic IOMMU errors code

2011-02-13 Thread Varadarajan, Charulatha
On Sat, Feb 12, 2011 at 18:42, David Cohen daco...@gmail.com wrote: Generic IOMMU errors code are necessary to handle errors on generic layer. Signed-off-by: David Cohen daco...@gmail.com ---  arch/arm/plat-omap/include/plat/iommu.h |    7 +++  1 files changed, 7 insertions(+), 0

Re: [PATCH] OMAP: IOMMU: add missing function declaration

2011-02-13 Thread Varadarajan, Charulatha
On Sat, Feb 12, 2011 at 19:09, David Cohen daco...@gmail.com wrote: Function declaration 'iopgtable_lookup_entry' is missing from header file. Is this done because of any error? You may add a comment on why this is required. Signed-off-by: David Cohen daco...@gmail.com ---  

Re: [PATCH v2 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

2011-02-08 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 9, 2011 at 01:23, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care   by hwmod framework. 2) Removing all base address macro defines. 3) Using omap-device layer to register device and utilizing

Re: [PATCH v2 2/2] omap3: beaglexm: fix DVI initialization

2011-02-08 Thread Varadarajan, Charulatha
On Wed, Feb 9, 2011 at 00:13, Ricardo Salveti de Araujo ricardo.salv...@canonical.com wrote: Function beagle_twl_gpio_setup is called after beagle_display_init, what lets reset_gpio with an invalid value at the time it request the gpio. As a side effect the DVI reset GPIO is not properly set.

Re: [PATCH v3 2/2] Input: ads7846: use gpio_request_one to configure pendown_gpio

2011-02-04 Thread Varadarajan, Charulatha
On Thu, Feb 3, 2011 at 22:49, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Feb 03, 2011 at 08:54:05AM -0800, Dmitry Torokhov wrote: On Thu, Feb 03, 2011 at 08:51:46PM +0530, Sourav Poddar wrote: The ads7846 driver requests a gpio but does not currently configure it explicitly as

Re: [PATCH RFC] arm: omap3evm: Add support for an MT9M032 based camera board.

2011-02-04 Thread Varadarajan, Charulatha
On Wed, Jan 19, 2011 at 04:02, Martin Hostettler mar...@neutronstar.dyndns.org wrote: Adds board support for an MT9M032 based camera to omap3evm. Sigend-off-by: Martin Hostettler mar...@neutronstar.dyndns.org ---  arch/arm/mach-omap2/Makefile                |    1 +  

Re: [PATCH 1/2] ads7846: fix gpio free without requesting

2011-02-03 Thread Varadarajan, Charulatha
snip diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 14ea54b..036f245 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1221,6 +1221,7 @@ static int __devinit ads7846_probe(struct spi_device

Re: [PATCHv2 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-03 Thread Varadarajan, Charulatha
Sourav, On Thu, Feb 3, 2011 at 15:28, Felipe Balbi ba...@ti.com wrote: On Thu, Feb 03, 2011 at 03:18:50PM +0530, Sourav Poddar wrote: The ads7846 driver requests a gpio to detect pendown events, but does not configure its direction. Configure this gpio as an input after requesting it.

Re: [PATCH 1/2] ads7846: fix gpio free without requesting

2011-02-02 Thread Varadarajan, Charulatha
Sourav, On Wed, Feb 2, 2011 at 21:00, Sourav Poddar sourav.pod...@ti.com wrote: gpio_pendown in ads7846_probe is not getting initalized (defaulted to 0) resulting in gpio_free being called without a gpio_request. This results in the following backtrace in bootup (at least on an OMAP3430 SDP).

Re: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Varadarajan, Charulatha
On Wed, Feb 2, 2011 at 21:00, Sourav Poddar sourav.pod...@ti.com wrote: The ads7846 driver requests a gpio to detect pendown events, but does not configure its direction. Configure this gpio as an input after requesting it. NACK to this patch too for similar reasons as in patch1 of this

Re: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Varadarajan, Charulatha
On Thu, Feb 3, 2011 at 12:06, Anand Gadiyar gadi...@ti.com wrote: Varadarajan, Charulatha wrote: On Wed, Feb 2, 2011 at 21:00, Sourav Poddar sourav.pod...@ti.com wrote: The ads7846 driver requests a gpio to detect pendown events, but does not configure its direction. Configure this gpio

Re: [PATCH v3 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-28 Thread Varadarajan, Charulatha
snip + +static int omap_dmic_set_dai_sysclk(struct snd_soc_dai *dai, +                                   int clk_id, unsigned int freq, +                                   int dir) +{ +       struct omap_dmic *dmic = snd_soc_dai_get_drvdata(dai); +       struct clk *dmic_clk, *parent_clk;

Re: [PATCH 2/2] omap3: beaglexm: fix DVI initialization

2011-01-27 Thread Varadarajan, Charulatha
On Fri, Jan 28, 2011 at 09:19, Ricardo Salveti de Araujo ricardo.salv...@canonical.com wrote: Function beagle_twl_gpio_setup is called after beagle_display_init, what makes lets reset_gpio with an invalid value at the time it request the gpio. As a side effect the DVI reset GPIO is not properly

Re: [PATCH v3 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-27 Thread Varadarajan, Charulatha
On Wed, Jan 26, 2011 at 03:30, David Lambert dlamb...@ti.com wrote: This patch adds support for the OMAP4 digital microphone DAI. This DAI can support support recording in 2, 4, or 6 channels When provided with a 19.2Mhz functional clock, can encode at 96Khz or 192Khz (all channels must have

Re: [PATCH v3 3/4] OMAP4: DMIC: initializes the DMIC driver

2011-01-27 Thread Varadarajan, Charulatha
On Wed, Jan 26, 2011 at 03:31, David Lambert dlamb...@ti.com wrote: This code is used to read the HWMOD database and initialize use hwmod and not HWMOD the DMIC driver. Signed-off-by: David Lambert dlamb...@ti.com --- snip -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/5] OMAP:board-omap3evm: Change TWL related gpio API's to gpio*_cansleep

2011-01-27 Thread Varadarajan, Charulatha
On Tue, Jan 25, 2011 at 23:07, Vaibhav Hiremath hvaib...@ti.com wrote: Since TWL GPIO's can go into sleep, and using normal gpio_get/set_value() API will lead to kernel dump (WARN_ON()). So replacing standard gpio_get/set_value() to gpio_get/set_value_cansleep(). Signed-off-by: Vaibhav

Re: [PATCH] OMAP3EVM: Made backlight GPIO default state to off

2011-01-24 Thread Varadarajan, Charulatha
On Mon, Jan 24, 2011 at 20:06, hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com If you choose default output to DVI, the LCD backlight stays on, since panel-disable function never gets called. So, during init put backlight GPIO to off state and the driver code will decide

Re: [PATCH] OMAP3EVM: Add vio regulator supply required for ads7846 TSC driver

2011-01-24 Thread Varadarajan, Charulatha
On Mon, Jan 24, 2011 at 20:02, hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com Please add a patch description. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com ---  arch/arm/mach-omap2/board-omap3evm.c |   20  1 files changed, 20 insertions(+), 0

Re: [PATCH] OMAP:board-omap3evm: Change TWL related gpio API's to gpio*_cansleep

2011-01-24 Thread Varadarajan, Charulatha
On Mon, Jan 24, 2011 at 20:01, hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com Since TWL GPIO's can go into sleep, and using normal gpio_get/set_value() API will lead to kernel dump (WARN_ON()). So replacing standard gpio_get/set_value() to gpio_get_set_value_cansleep().

Re: [PATCH] OMAP3EVM:FIX: Reset the SMSC911x Ethernet controller in board_init

2011-01-24 Thread Varadarajan, Charulatha
On Mon, Jan 24, 2011 at 20:11, hvaib...@ti.com wrote: From: Vaibhav Hiremath hvaib...@ti.com Thanks for the patch. I guess this problem was initially reported by Kevin. So you may consider adding his Reported-by. With addition of HWMOD support to GPIO, the Ethernet controller

Re: [PATCH] OMAP3EVM: Made backlight GPIO default state to off

2011-01-24 Thread Varadarajan, Charulatha
On Mon, Jan 24, 2011 at 20:33, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Varadarajan, Charulatha [mailto:ch...@ti.com] Sent: Monday, January 24, 2011 8:12 PM To: Hiremath, Vaibhav Cc: linux-omap@vger.kernel.org; tomi.valkei...@nokia.com; t...@atomide.com

Re: [PATCH-V2] OMAP3EVM: Made backlight GPIO default state to off

2011-01-24 Thread Varadarajan, Charulatha
On Tue, Jan 25, 2011 at 10:18, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Semwal, Sumit Sent: Tuesday, January 25, 2011 8:05 AM To: Hiremath, Vaibhav Cc: linux-omap@vger.kernel.org; t...@atomide.com; tomi.valkei...@nokia.com Subject: Re: [PATCH-V2] OMAP3EVM:

Re: [PATCH-V2] OMAP3EVM: Made backlight GPIO default state to off

2011-01-24 Thread Varadarajan, Charulatha
On Tue, Jan 25, 2011 at 10:50, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Varadarajan, Charulatha [mailto:ch...@ti.com] Sent: Tuesday, January 25, 2011 10:24 AM To: Hiremath, Vaibhav Cc: Semwal, Sumit; linux-omap@vger.kernel.org; t...@atomide.com; tomi.valkei

Re: [PATCH] OMAP3EVM:FIX: Reset the SMSC911x Ethernet controller in board_init

2011-01-24 Thread Varadarajan, Charulatha
snip Missed this one in the previous threads. +        eth_cs = OMAP3EVM_SMSC911X_CS;        l3ck = clk_get(NULL, l3_ck); @@ -136,6 +141,22 @@ static inline void __init omap3evm_init_smsc911x(void)        else                rate = clk_get_rate(l3ck); +       /* Configure

Re: [PATCH] OMAP3EVM:FIX: Reset the SMSC911x Ethernet controller in board_init

2011-01-24 Thread Varadarajan, Charulatha
On Tue, Jan 25, 2011 at 12:26, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Varadarajan, Charulatha Sent: Tuesday, January 25, 2011 12:20 PM To: Hiremath, Vaibhav Cc: linux-omap@vger.kernel.org; Hilman, Kevin; t...@atomide.com Subject: Re: [PATCH] OMAP3EVM:FIX

Re: [PATCH] omap3: Add basic support for 720MHz part

2011-01-20 Thread Varadarajan, Charulatha
On Thu, Jan 20, 2011 at 16:28, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: Varadarajan, Charulatha Sent: Tuesday, January 18, 2011 2:44 PM To: Premi, Sanjeev Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] omap3: Add basic support for 720MHz part Also do not miss

Re: [PATCH] OMAP: omap-mcbsp: Fix building after replacement

2011-01-20 Thread Varadarajan, Charulatha
On Thu, Jan 20, 2011 at 23:49, Tony Lindgren t...@atomide.com wrote: * Poddar, Sourav sourav.pod...@ti.com [110120 07:08]: On Thu, Jan 20, 2011 at 7:42 PM, Thomas Weber we...@corscience.de wrote: Fix building omap-mcbsp after replacing ARCH_OMAP24x0 in commit

Re: [PATCH] OMAP: omap-mcbsp: Fix building after replacement

2011-01-20 Thread Varadarajan, Charulatha
On Fri, Jan 21, 2011 at 12:58, Jarkko Nikula jhnik...@gmail.com wrote: On Fri, 21 Jan 2011 11:55:55 +0530 Varadarajan, Charulatha ch...@ti.com wrote: I was just about to post a patch for this, but you beat me to it! Signed-off-by: Thomas Weber we...@corscience.de Acked-by: Sourav

Re: [PATCHv4 4/4] OMAP3: Devkit8000: Fix indentation of brace

2011-01-19 Thread Varadarajan, Charulatha
On Wed, Jan 19, 2011 at 13:49, Thomas Weber we...@corscience.de wrote: Fix indentation of a closing curly brace. As Manjunath mentioned for the other patch, I guess this patch can also be merged with some other patch in this series. Signed-off-by: Thomas Weber we...@corscience.de ---  

Re: [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin

2011-01-18 Thread Varadarajan, Charulatha
On Tue, Jan 18, 2011 at 12:28, Thomas Weber we...@corscience.de wrote: This patch fixes a wrongly used lcd enable pin. The Devkit8000 uses twl4030_ledA configured as output gpio only for the lcd enable line. twl4030_gpio.1 is used through the generic gpio functions while ledA is used via low

Re: [PATCH] omap3: Add basic support for 720MHz part

2011-01-18 Thread Varadarajan, Charulatha
Couple of minor comments. On Tue, Jan 18, 2011 at 13:19, Sanjeev Premi pr...@ti.com wrote: This patch adds support for new speed enhanced parts with ARM and IVA running at 720MHz and 520MHz respectively. These parts can be probed at run-time by reading PRODID.SKUID[3:0] at 0x4830A20C [1].

Re: [PATCH 7/7] arm: omap2: clksel: fix compile warning

2011-01-17 Thread Varadarajan, Charulatha
On Mon, Jan 17, 2011 at 10:01, Felipe Balbi ba...@ti.com wrote: Fix the following compile warning: arch/arm/mach-omap2/clkt_clksel.c: In function '_get_div_and_fieldval': arch/arm/mach-omap2/clkt_clksel.c:100:35: warning: 'max_clkr' may be used uninitialized in this function While at that,

Re: Spinlock recursion after root nfs mount

2011-01-13 Thread Varadarajan, Charulatha
Sergio, On Wed, Jan 12, 2011 at 02:50, Aguirre, Sergio saagui...@ti.com wrote: Hi all, Has anyone been trying to boot w/k.org lately? I tried with: - commit e0e736fc + 2 patches attached I got from patchworks - 4430SDP w/ES2.1 - Busybox FS through NFS. I see the attached log, which

Re: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+

2011-01-05 Thread Varadarajan, Charulatha
Kevin, On Wed, Jan 5, 2011 at 04:47, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@ti.com [110104 14:45]: On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote: Mika Westerberg ext-mika.1.westerb...@nokia.com writes: In case on OMAP2+ we call set_24xx_gpio_triggering()

Re: [PATCH v1 02/10] OMAP: McBSP: Convert McBSP to platform device model

2010-12-23 Thread Varadarajan, Charulatha
Kishon, On Tue, Dec 21, 2010 at 13:10, Kishon Vijay Abraham I kis...@ti.com wrote: Implement McBSP as platform device and add support for registering through platform device layer using resource structures. Later in this patch series, OMAP2+ McBSP driver would be modified to use hwmod

Re: [PATCH v1] OMAP: GPIO: Correct IP version message during boot

2010-12-17 Thread Varadarajan, Charulatha
Kevin, On Thu, Dec 16, 2010 at 11:49, Kevin Hilman khil...@deeprootsystems.com wrote: Varadarajan, Charulatha ch...@ti.com writes: With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is OMAP: GPIO: Make omap_gpio_show_rev bank specific (see [1]), the IP version information

Re: [PATCH v4 5/5] OMAP: mailbox: use runtime pm for clk and sysc handling

2010-12-16 Thread Varadarajan, Charulatha
On Thu, Dec 16, 2010 at 12:17, Omar Ramirez Luna omar.rami...@ti.com wrote: Use runtime pm APIs to enable/disable mailbox clocks and to configure SYSC register. Based on the patch sent by Felipe Contreras: https://patchwork.kernel.org/patch/101662/ Signed-off-by: Omar Ramirez Luna

Re: [PATCH v4 4/5] OMAP: mailbox: build device using omap_device/omap_hwmod

2010-12-16 Thread Varadarajan, Charulatha
couple of comments. On Thu, Dec 16, 2010 at 12:17, Omar Ramirez Luna omar.rami...@ti.com wrote: From: Felipe Contreras felipe.contre...@gmail.com Remove static platform_device and resource data within omap mailbox driver; use the one defined in the hwmod database along with omap_device

[PATCH v1] OMAP: GPIO: Correct IP version message during boot

2010-12-16 Thread Varadarajan, Charulatha
() so that the bank id is displayed along with the IP version [1] http://www.spinics.net/lists/arm-kernel/msg105872.html Signed-off-by: Varadarajan, Charulatha ch...@ti.com Acked-by: Felipe Balbi ba...@ti.com --- arch/arm/plat-omap/gpio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [PATCH v7] OMAP4:keypad: PM runtime

2010-12-15 Thread Varadarajan, Charulatha
Shubhro, On Wed, Dec 15, 2010 at 13:24, Datta, Shubhrajyoti shubhrajy...@ti.com wrote: On Wed, Dec 15, 2010 at 11:01 AM, Varadarajan, Charulatha ch...@ti.com wrote: * Shubhrajyoti D a0393...@india.ti.com [2010-12-15 09:39:58 +0530]: From: Abraham Arce x0066...@ti.com Enable Runtime PM

Re: [PATCH v7] OMAP4:keypad: PM runtime

2010-12-14 Thread Varadarajan, Charulatha
* Shubhrajyoti D a0393...@india.ti.com [2010-12-15 09:39:58 +0530]: From: Abraham Arce x0066...@ti.com Enable Runtime PM functionality in OMAP4 driver based on the following assumptions A minimal pm runtime get/put approach is implemented in probe/remove calls respectively. -

Re: [PATCH RESEND] ARM: io: fix namespace conflicts

2010-12-08 Thread Varadarajan, Charulatha
Russell, On Fri, Dec 3, 2010 at 12:04, Sourav Poddar sourav.pod...@ti.com wrote: Having __v as the variable name for the definition of different macros leads to the namespace pollution. For example, readl(p) unrolls to: ({ u32 __v = ({ u32 __v = (( __u32)(__le32)(( __le32) ((void)0,

Re: [PATCH v5 10/12] OMAP: dmtimer: switch-over to platform device driver

2010-12-06 Thread Varadarajan, Charulatha
in io.c (c) modify plat-omap/dmtimer routines to use new register map and platform data. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Reviewed-by: Cousson, Benoit b-cous...@ti.com Reviewed-by: Varadarajan, Charulatha ch...@ti.com ---  arch/arm/mach-omap2/clock2420_data.c      |    2

  1   2   3   4   >