e.filter_map.map = info->slave_map;
> ecc->dma_slave.filter_map.mapcnt = info->slavecnt;
> ecc->dma_slave.filter_map.filter_fn = edma_filter_fn;
> }
>
> When neither DT or ACPI lookup is available the dma_request_chan() will
> try to match the requester'
ilter_fn;
One nitpick here.
I think filter_map.filter_fn naming is duplicate.
What about
dma_device
.filter -> filter data (or .filter_data)
.map -> mappings
.map_count -> # of entries in mappings
.fn -> filter function
What do you think?
> }
>
> When neit
ent.txt| 23 ++---
> arch/arm/mach-davinci/devices-da8xx.c | 95 +-
> arch/arm/mach-davinci/devices.c | 19
> arch/arm/mach-davinci/dm355.c | 28 --
> arch/arm/mach-davinci/dm365.c | 30 --
> arch/arm/mach-davinci/dm644x.c
hannel must satisfy
> + *
> + * Returns pointer to appropriate DMA channel on success or an error pointer.
> + */
> +struct dma_chan *dma_request_chan_by_mask(const dma_cap_mask_t *mask)
> +{
> + struct dma_chan *chan;
> +
> + if (!mask)
> + return ERR_PTR(-ENODEV);
> +
> + chan = __dma_request_channel(mask, NULL, NULL);
> + if (!chan)
> + chan = ERR_PTR(-ENODEV);
> +
> + return chan;
> +}
> +EXPORT_SYMBOL_GPL(dma_request_chan_by_mask);
> +
> void dma_release_channel(struct dma_chan *chan)
> {
> mutex_lock(&dma_list_mutex);
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index a2b7c2071cf4..49d48e69c179 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -606,6 +606,18 @@ enum dmaengine_alignment {
> DMAENGINE_ALIGN_64_BYTES = 6,
> };
>
> +struct dma_filter_map {
> +char *devname;
const ?
> +char *slave;
Ditto.
> +void *param;
> +};
> +
> +struct dma_filter {
> +dma_filter_fn filter_fn;
> +int mapcnt;
> +const struct dma_filter_map *map;
> +};
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 1, 2015 at 11:47 AM, Peter Ujfalusi wrote:
> On 11/30/2015 04:35 PM, Andy Shevchenko wrote:
>> On Mon, Nov 30, 2015 at 3:45 PM, Peter Ujfalusi
>> wrote:
>>> Treat as true condition the case when the mask is NULL.
>>
>> What do you think about
On Tue, Dec 1, 2015 at 11:56 AM, Peter Ujfalusi wrote:
> On 11/30/2015 04:51 PM, Andy Shevchenko wrote:
>>> +struct dma_chan *dma_request_chan(struct device *dev, const char *name)
>>> +{
>>> + struct dma_device *device, *_d;
>>> + struct dma_cha
ame(chan));
> - list_del_rcu(&device->global_node);
> - } else if (err)
> - pr_debug("%s: failed to get %s: (%d)\n",
> -__func__, dma_chan_name(chan), er
onst
> dma_cap_mask_t *mask,
> struct dma_chan *dma_request_slave_channel_reason(struct device *dev,
> const char *name);
> struct dma_chan *dma_request_slave_channel(struct device *dev, const char
> *name);
> +
> +struc
p_mask.bits,
> DMA_TX_TYPE_END);
> return bitmap_equal(want->bits, has.bits, DMA_TX_TYPE_END);
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
davinci/dm355.c | 28 ++++--
> arch/arm/mach-davinci/dm365.c | 30 +--
> arch/arm/mach-davinci/dm644x.c| 12 +++
> arch/arm/mach-davinci/dm646x.c| 11 +++
> drivers/dma/dmaengine.c | 160
> +-
> drivers/dma/edma.c| 24 +
> drivers/mmc/host/davinci_mmc.c| 52 +++
> drivers/spi/spi-davinci.c | 76 +---
> include/linux/dmaengine.h | 31 +++
> include/linux/platform_data/edma.h| 5 ++
> 12 files changed, 330 insertions(+), 213 deletions(-)
>
> --
> 2.6.3
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 2:30 PM, Peter Ujfalusi wrote:
> On 11/20/2015 02:24 PM, Andy Shevchenko wrote:
>> On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann wrote:
>>> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote:
>>>> On 11/19/2015 01:25 PM, Arnd Bergm
m data
Why not unified device properties?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 18, 2015 at 5:51 PM, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote:
>> >
>> > I assume that the sst-firmware.c case is a mistake, it should just use a
>> > plain DMA_SLAVE and not DMA_MEMCPY.
>>
>> Other
ful
(IIRC Russel's opinion).
On the other hand there are a lot of drivers that are used on the set
of platforms starting from legacy and abandoned ones (like AVR32) to
relatively new and newest.
And I'm not a fan of those thousands of API calls either.
--
With Best Regards,
Andy Shevchenk
these...
>
> I just had a look myself. carma has been removed fortunately in linux-next,
> so we don't have to worry about that any more.
>
> I assume that the sst-firmware.c case is a mistake, it should just use a
> plain DMA_SLAVE and not DMA_MEMCPY.
Other way around.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
=linux-kernel&m=142469226512289
Agree with Stephen, why should we have the second function doing the
same? Just name changing?
I think you may just incorporate that patch into your series.
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscri
ammatical errors. I'll fix those when posting the final version with all the
> drivers converted.
JFYI: there is nice project called codespell [1].
[1] git://github.com/lucasdemarchi/codespell.git
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "
_map[reg] + (stride * lch);
> - __raw_writel(val, dma_base + offset);
> + __raw_writel(val, addr);
> }
>
> static inline u32 dma_read(int reg, int lch)
> {
> - u8 stride;
> - u32 offset, val;
> + void __iomem *addr = dma_base;
> +
> + addr += reg_m
int omap_system_dma_remove(struct
> platform_device *pdev)
> free_irq(dma_irq, (void *)(irq_rel + 1));
> }
> }
> - kfree(dma_chan);
> return 0;
> }
>
> diff --git a/include/linux/omap-dma.h b/include/linux/omap-dma.h
No go.
Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a
And update you tree, please.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
offset = xbar_chans[i][1] >> 2;
> + offset <<= 2;
Is it offset = xbar_chans[i][1] & 0xfffc; ?
> + mux = readl((void *)((u32)xbar + offset));
> + mux &= ~(0xff << shift);
> + mux |= xbar_chans[i][0] <&l
On Wed, Jan 30, 2013 at 8:41 AM, Matt Porter wrote:
> On Mon, Jan 28, 2013 at 09:27:24PM +0200, Andy Shevchenko wrote:
>> On Tue, Jan 15, 2013 at 10:32 PM, Matt Porter wrote:
>> > Adds support for parsing the TI EDMA DT data into the required
>> > EDMA private API pla
gt; --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Bes
rm_get_irq_byname(pdev, irq_name);
> + if (node)
> + err_irq[j] = irq_of_parse_and_map(node, 2);
> + else {
> + sprintf(irq_name, "edma%d_err", j);
> + err_irq[j] = platform_get_irq_byna
> [Hiremath, Vaibhav] No. I am not in favor of conditional compilation in
> driver code.
>
> > better, port the AM35x driver to the MC API.
> >
> [Hiremath, Vaibhav]
> Why should we use MC if I have very simple device (like AM35x) which only
> supports singl
On Wed, 2011-08-17 at 16:04 +0530, Deepthy Ravi wrote:
> From: Vaibhav Hiremath
>
> Defines the two functions only when CONFIG_MEDIA_CONTROLLER
> is enabled.
Is it not a driver's option to be dependent on MEDIA_CONTROLLER?
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscri
There are two places where the same calculations are done. Let's split them to
separate function.
In addition the new function is simplified by usage DIV_ROUND_UP kernel macro.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c |
The code contains the similarities in the error path of probe function. Let's
combine them at one place.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --
On Fri, May 6, 2011 at 2:34 PM, Varadarajan, Charulatha wrote:
> On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote:
>> From: Andy Shevchenko
>>
>
> Add patch description here.
You mean something like following:
"The code contains similarities in the error path of pro
t work.
IIRC, there is mmc_set_clock() method, but it isn't exported. Anyway,
I have another issue with some specific code which also requires the
same function to be exported.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap&quo
lst_list removal).
I didn't see it at all in my mailbox. And can't find it on patchwork either...
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo i
gt; - return simple_strtoul(pch, NULL, base);
> + ret_val = strict_strtoul(pch, base, &res);
> +
> + return ret_val ? : res;
May be better to use explicit values in condition?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "
essage left opened questions about
http://dev.omapzoom.org/?p=tidspbridge/kernel-dspbridge.git;a=commit;h=b8af1123b47741086ef5a307ad1ec8fec6fc7f0d
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to ma
for (i = 0; i < len; i++) {
> value = hex_to_bin(*buf++);
> --
> 1.6.3.3
>
>
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
There is recently added hex_to_bin() kernel's method which we could use
instead of custom long function.
Signed-off-by: Andy Shevchenko
Cc: Ohad Ben-Cohen
Cc: Greg Kroah-Hartman
Cc: linux-omap@vger.kernel.org
---
drivers/staging/tidspbridge/gen/uuidutil.c |
On Wed, Jun 23, 2010 at 4:02 PM, Ohad Ben-Cohen wrote:
> Add TI's DSP Bridge generic utilities driver sources
> Signed-off-by: Andy Shevchenko
> +++ b/drivers/staging/tidspbridge/gen/uuidutil.c
Following part could be significantly simplified
> +/*
>
hate of u* types not a
reason to bring some useless patches.
Look:
[a...@localhost linux-2.6]$ git grep -n -w u32 | wc
76327 388062 5253203
I guess you don't need further exlanations here.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscr
From: Andy Shevchenko
Try to use simple_strtoul() kernel native method instead.
However, there are opened questions:
- why type of Atoi() is s32 if the sign is used only to detect base?
- should we really to check hex integers like DEAD0123h?
- how many spaces could lead token?
Signed-off
ly to detect base?
This is the question about l vs ul.
>> + } else if (*pch&& (pch[strlen(pch) - 1] | 0x20 == 'h')) {
>
> perhaps tolower(x)
Yep, I saw only internal macro in lib/vsprintf.c, but totally forgot
about ctype.h.
--
With Best Regards,
Andy Sh
do I miss?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko
Try to use simple_strtol() kernel native method instead.
However, there are opened questions:
- why type of Atoi() is s32 if the sign is used only to detect base?
- should we really to check hex integers like DEAD0123h?
- how many spaces could lead token?
Signed-off-by
From: Andy Shevchenko
Remove useless macroses. They were doing nothing, so it's clear to just get rid
of them.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/memdefs.h |3 ---
drivers/dsp/bridge/wmd/tiomap_io.c |5 ++---
2 files chang
nlld be less than zero? Anyway better to test:
(chnlId >= CHNL_MAXCHANNELS || chnlld < 0)
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 30, 2009 at 11:54 PM, Omar Ramirez Luna wrote:
> arch/arm/plat-omap/include/dspbridge/list.h | 36 +-
> drivers/dsp/bridge/services/list.c | 33 -
Sorry, I missed patch that contains above changes. What they about?
--
With Best Regards,
Andy Shev
e channel event only if the queue of IO
> + * completions is empty. If it is not empty, the event is sure to be
> + * signalled by the only IO completion list consumer:
> + * WMD_CHNL_GetIOC(). */
The same as in (2).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
s gumstix.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko
includecheck found few duplicates. So, clean up them.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/rmgr/disp.c |1 -
drivers/dsp/bridge/rmgr/drv_interface.c |1 -
drivers/dsp/bridge/rmgr/proc.c |1 -
drivers/dsp/bridge/wmd/io_sm.c
From: Andy Shevchenko
Remove printS() debuggin method. It's mostly useless and at least dangerous
because of absence of boundary check.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/services/regsup.c | 23 ---
1 files changed, 0 insertions(+), 23 dele
From: Andy Shevchenko
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 ---
drivers/dsp/bridge/rmgr/drv_interface.c | 12
drivers/dsp/bridge/services/cfg.c|5 -
3 files changed, 0 insertions(+), 20 deletions(-)
diff
From: Andy Shevchenko
Simplify REG API by removing useless input parameters.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/reg.h | 102
drivers/dsp/bridge/rmgr/dbdcd.c| 22 +++
drivers/dsp/bridge/rmgr/drv.c
From: Andy Shevchenko
Change implementation of registry to a linked list.
In future this will became to some static structures and probably list for
DCD_REGKEY array.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/services/regsup.c | 216 +++---
drivers
From: Andy Shevchenko
There are several patches which simplify registry API and code.
Andy Shevchenko (5):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
DSPBRIDGE: OSAL: Clean up dbreg.h and move it
DSPBRIDGE: OSAL: Implement registry as linked list
From: Andy Shevchenko
* Clean up dbreg.h - there are plenty of unused definitions
* Move necessary constants to the dbdefs.h
* Remove dbreg.h inclusion from other files
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/dbdefs.h | 26 ++
arch/arm/plat-omap/include
From: Andy Shevchenko
There are two patches which simplify registry API.
Andy Shevchenko (2):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 -
arch/arm/plat-omap/include/dspbridge/reg.h | 102
From: Andy Shevchenko
Simplify REG API by removing useless input parameters.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/reg.h | 102
drivers/dsp/bridge/rmgr/dbdcd.c| 22 +++
drivers/dsp/bridge/rmgr/drv.c
From: Andy Shevchenko
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 ---
drivers/dsp/bridge/rmgr/drv_interface.c | 12
drivers/dsp/bridge/services/cfg.c|5 -
3 files changed, 0 insertions(+), 20 deletions(-)
diff
From: Andy Shevchenko
There are two patches which simplify registry API.
Andy Shevchenko (2):
DSPBRIDGE: OSAL: Simplify REG API
DSPBRIDGE: OSAL: Remove unused registry variables
arch/arm/plat-omap/include/dspbridge/dbreg.h |3 -
arch/arm/plat-omap/include/dspbridge/reg.h | 102
the output for only the ones we want..
> grep "$DIR_FILE" tags | grep -v "^\!" | sed -e
> "s/\/\^.*\"/REPLACE_1/g" > $TMPFILE
sed could match and skip lines like grep -v 'smth.': sed -e '/^!/d; ...'
> dos2unix -n
ents are committed to the
linux-omap tree, but official kernels are provided from certain
repository.
> Is there any how-to or update instruction I can follow?
Perhaps more useful to ask in maemo.org.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "u
From: Andy Shevchenko
It seems BRD_* error codes from this certain file is redundant.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/errbase.h | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/arch/arm/plat-omap/include/dspbridge
From: Andy Shevchenko
* Remove KFILE_Init(), KFILE_Exit() and tracing stuff
* Simplify KFILE_Seek()
* Simplify error checker in KFILE_Open after filp_open() call
* Remove pid/tgid related code: it seems totally useless here
* Get rid of KFILE_FileObj, use regular struct file instead
* Remove
From: Andy Shevchenko
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Change CSL_atoi(s) to the kernel's simple_strtol(s, NULL, 10) in place.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/csl.h |
Hello.
This version is slightly improved (I drop out atoi() wrapper).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
From: Andy Shevchenko
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Change atoi(s) to the kernel's simple_strtol(s, NULL, 10).
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/csl.h | 135 --
dr
From: Andy Shevchenko
Including the list.h in some files looks redundant. So, remove those lines.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/pmgr/chnl.c |1 -
drivers/dsp/bridge/pmgr/dmm.c |1 -
drivers/dsp/bridge/pmgr/msg.c |1 -
drivers/dsp
From: Andy Shevchenko
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Move methods from list.c as inline functions to the l
From: Andy Shevchenko
Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal
way.
Use MEM_Free() instead of LST_Delete(). We can use it without checking because
MEM_Free() validates input parameter.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include
From: Andy Shevchenko
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = &mMan.lst.head;
struct list_head *curr = last->next; /* was: mMan.lst.he
From: Andy Shevchenko
Current DSP bridge driver still contains redudant pieces of CSL code. Get rid
of it finally.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/csl.h | 135 --
drivers/dsp/bridge/pmgr/chnl.c |1 -
drivers/dsp
From: Andy Shevchenko
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = &mMan.lst.head;
struct list_head *curr = last->next; /* was: mMan.lst.he
From: Andy Shevchenko
Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal
way.
Use MEM_Free() instead of LST_Delete(). We can use it without checking because
MEM_Free() validates input parameter.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include
From: Andy Shevchenko
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Move methods from list.c as inline functions to the l
ridge-2.6.29 kernel branch of the
kernel-dspbridge repository.
Please, review them. Thank you.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
From: Andy Shevchenko
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/rmgr/proc.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c
index 832930e..52e2d54 100644
--- a/drivers/dsp/bridge/rmgr/proc.c
I will look into. But probably this mean to revert back to
MEM_* calls when we would like to create or destroy list head...
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.
From: Andy Shevchenko
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Switch to list_head structure instead of LST_ELEM. R
From: Andy Shevchenko
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = &mMan.lst.head;
struct list_head *curr = last->next; /* was: mMan.lst.he
me to native list_head in
whole dsp bridge driver.
All patches are rebased against android-bridge-2.6.29 kernel branch of the
kernel-dspbridge repository.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a me
From: Andy Shevchenko
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM in the list.h.
Signed-off-by
From: Andy Shevchenko
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/arm
From: Andy Shevchenko
I doubt about usefulness of removed piece of code. But it seems to be not used
because of unchanged value of bJustWokeDSP.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/rmgr/node.c | 17 -
1 files changed, 0 insertions(+), 17 deletions(-)
diff
From: Andy Shevchenko
It's more logical to have calls of symmetric functions at single place.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/mem.h |5 +
drivers/dsp/bridge/rmgr/drv_interface.c|2 ++
drivers/dsp/bridge/services/mem.c |
From: Andy Shevchenko
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = &mMan.lst.head;
struct list_head *curr = last->next; /* was: mMan.lst.he
On Thu, Sep 3, 2009 at 12:31 PM, Andy
Shevchenko wrote:
> On Thu, Sep 3, 2009 at 12:17 PM, Artem Bityutskiy wrote:
>> On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
>>> @@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr,
>>>
On Thu, Sep 3, 2009 at 12:17 PM, Artem Bityutskiy wrote:
> On Thu, 2009-09-03 at 12:06 +0300, Andy Shevchenko wrote:
>> @@ -590,7 +589,7 @@ DSP_STATUS CMM_GetInfo(struct CMM_OBJECT *hCmmMgr,
>> /* next node. */
>>
From: Andy Shevchenko
* Change struct LST_ELEM to struct list_head in whole dsp bridge driver
* Remove useless commentaries
* Minor change in the services/mem.c:
...
struct list_head *last = &mMan.lst.head;
struct list_head *curr = last->next; /* was: mMan.lst.he
From: Andy Shevchenko
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Switch to list_head structure instead of LST_ELEM. R
From: Andy Shevchenko
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/list.h | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm
ative list_head in
whole dsp bridge driver.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM in the list.h.
Signed-off-by
From: Andy Shevchenko
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm
From: Andy Shevchenko
Instead of MEM_Calloc()/MEM_Free() use kzalloc()/kfree() calls. Thus we get rid
of mem.h dependency.
Signed-off-by: Andy Shevchenko
---
arch/arm/plat-omap/include/dspbridge/list.h | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/arm
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko
* Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
* Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
* Switch to list_head structure instead of LST_ELEM. R
From: Andy Shevchenko
* Use native list_empty() method instead of LST_IsEmpty() inside list.c. Remove
extra local variables.
* Move methods from list.c as inline functions in the list.h. Get rid of list.c
at all.
* Use list_head natively instead of LST_ELEM in the list.h.
Signed-off-by
From: Andy Shevchenko
- Remove LST_Init() and LST_Exit() calls because they are doing nothing except
tracing, Thus, remove tracing as well.
- Remove DBC_* calls. It's internal kernel business whether to have those
assertions.
- Switch to list_head structure instead of LST_ELEM. R
From: Andy Shevchenko
Check list pointer at every itteration because it could be deleted before we go
into the for loop.
Reworked version of the previous attempts.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/rmgr/drv.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions
From: Andy Shevchenko
Theoretically list could be deleted before we go into the for loop.
Additionally we could delete list immediately if it becomes empty.
Signed-off-by: Andy Shevchenko
---
drivers/dsp/bridge/rmgr/drv.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions
us instead, what do you
> think?
As far as I see this is not the dsp status but just a word to collect
errors. More logical in this piece of your code is to use result word
instead of status.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscri
t; DBC_Assert(status == 0);
> DBC_Assert(DSP_SUCCEEDED(initStatus));
> GT_0trace(driverTrace, GT_ENTER, " <- driver_init\n");
> - return status;
> +
> + return 0;
> +
> +err3:
> + kfree(bridge_device);
> +
> +err2:
> + unregister_chrdev_region(dev, 1);
> +
> +err1:
> + return result;
> }
>
> /* This function is invoked during unlinking of the bridge module from the
--
With Best Regards,
Andy Shevchenko
1 - 100 of 108 matches
Mail list logo
