* Govindraj [100610 11:49]:
>
> -> Shouldn't we just retrieve the offset and then use
> omap_ctrl_writew\ omap_ctrl_readw calls?
Sure that works too. And that actually has the advantage
that it's more likely to keep the mux read/write access
in the platform init code.
> -> I hope muxmode c
On Wed, Jun 9, 2010 at 7:58 PM, Tony Lindgren wrote:
> * Govindraj [100607 17:50]:
>> On Mon, Jun 7, 2010 at 5:02 PM, Govindraj wrote:
>> > On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren wrote:
>> >> * Kevin Hilman [100604 18:30]:
>> >>>
>> >>> > + w &= ~0x7;
>> >>> > + w |= OMAP_MUX_MODE2;
* Govindraj [100607 17:50]:
> On Mon, Jun 7, 2010 at 5:02 PM, Govindraj wrote:
> > On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren wrote:
> >> * Kevin Hilman [100604 18:30]:
> >>>
> >>> > + w &= ~0x7;
> >>> > + w |= OMAP_MUX_MODE2;
> >>> > + omap_ctrl_writew(w, uart->padconf);
> >>
> >> Gen
On Mon, Jun 7, 2010 at 5:02 PM, Govindraj wrote:
> On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren wrote:
>> * Kevin Hilman [100604 18:30]:
>>>
>>> > + w &= ~0x7;
>>> > + w |= OMAP_MUX_MODE2;
>>> > + omap_ctrl_writew(w, uart->padconf);
>>
>> Generic NAK for tinkering with the mux registers d
On Mon, Jun 7, 2010 at 3:36 PM, Tony Lindgren wrote:
> * Kevin Hilman [100604 18:30]:
>>
>> > + w &= ~0x7;
>> > + w |= OMAP_MUX_MODE2;
>> > + omap_ctrl_writew(w, uart->padconf);
>
> Generic NAK for tinkering with the mux registers directly.
>
> Instead, Govindraj, please add omap_mux_reques
* Kevin Hilman [100604 18:30]:
>
> > + w &= ~0x7;
> > + w |= OMAP_MUX_MODE2;
> > + omap_ctrl_writew(w, uart->padconf);
Generic NAK for tinkering with the mux registers directly.
Instead, Govindraj, please add omap_mux_request_signal() into mux.c:
void __iomem * __init omap_mux_request_s
On Fri, Jun 4, 2010 at 9:05 PM, Kevin Hilman
wrote:
> "Govindraj.R" writes:
>
>> This patch makes the following:
>> - Adds missing wakeup padding register handling.
>> - Fixes a hardcode to use PER module ONLY on UART3.
>> - Muxmode usage needed for uart4 for 3630 for padconf
>> wakeup on r
"Govindraj.R" writes:
> This patch makes the following:
> - Adds missing wakeup padding register handling.
> - Fixes a hardcode to use PER module ONLY on UART3.
> - Muxmode usage needed for uart4 for 3630 for padconf
>wakeup on rx line.
The need for this muxmode needs to be better describ
t;>>To: linux-omap@vger.kernel.org
>>>Cc: Kevin Hilman; Aguirre, Sergio
>>>Subject: [pm-wip/uart][PATCH 2/4] OMAP3: serial: Fix uart4 handling for 3630
>>>
>>>This patch makes the following:
>>> - Adds missing wakeup padding register handling.
>>-Original Message-
>>From: linux-omap-ow...@vger.kernel.org
>>[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
>>Govindraj.R
>>Sent: Friday, June 04, 2010 7:14 PM
>>To: linux-omap@vger.kernel.org
>>Cc: Kevin Hilman; Aguirre, Sergio
This patch makes the following:
- Adds missing wakeup padding register handling.
- Fixes a hardcode to use PER module ONLY on UART3.
- Muxmode usage needed for uart4 for 3630 for padconf
wakeup on rx line.
Cc: Kevin Hilman
Signed-off-by: Sergio Aguirre
Signed-off-by: Govindraj.R
---
arch
11 matches
Mail list logo
