Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-08-30 Thread Mark Brown
On Wed, Aug 29, 2012 at 09:31:31AM +0100, Lee Jones wrote: On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: The regulator-name property is used to populate constrains-name. Are you sure you still want them all removed? Yes, of course. There's no way that a generic .dtsi used

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-08-29 Thread Lee Jones
On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote: On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: arch/arm/boot/dts/db8500.dtsi I'm not actually seeing anything terribly problematic here, though the regulator-name properties should really be removed as they're

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-08-28 Thread Lee Jones
Hi Mark, arch/arm/boot/dts/db8500.dtsi I'm not actually seeing anything terribly problematic here, though the regulator-name properties should really be removed as they're fairly useless and seem to be missing the point of having the property. Just looking at this now. The

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-08-28 Thread Mark Brown
On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote: arch/arm/boot/dts/db8500.dtsi I'm not actually seeing anything terribly problematic here, though the regulator-name properties should really be removed as they're fairly useless and seem to be missing the point of having the

RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-23 Thread AnilKumar, Chimata
On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: On Fri, Jul 20, 2012 at 11:27:36AM +, AnilKumar, Chimata wrote: On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: Every regulator here has a rather large voltage range specified with no consumers added. Are you sure these

RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-23 Thread AnilKumar, Chimata
On Mon, Jul 23, 2012 at 12:36:48, AnilKumar, Chimata wrote: On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote: On Fri, Jul 20, 2012 at 11:27:36AM +, AnilKumar, Chimata wrote: On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: Every regulator here has a rather large voltage range

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-23 Thread Mark Brown
On Mon, Jul 23, 2012 at 01:23:50PM +, AnilKumar, Chimata wrote: By the way, if we look at all the regulator added (DT supported) till now have the similar problem. arch/arm/boot/dts/imx6q.dtsi This is fine - the SoC contains integrated regulators which supply other bits of the Soc so we

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-23 Thread Lee Jones
On 23/07/12 14:34, Mark Brown wrote: On Mon, Jul 23, 2012 at 01:23:50PM +, AnilKumar, Chimata wrote: By the way, if we look at all the regulator added (DT supported) till now have the similar problem. arch/arm/boot/dts/imx6q.dtsi This is fine - the SoC contains integrated regulators

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-20 Thread Mark Brown
On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: + vio_reg: regulator@1 { + reg = 1; + regulator-compatible = vio; + regulator-min-microvolt = 150; + regulator-max-microvolt =

RE: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-20 Thread AnilKumar, Chimata
Hi Mark, Thanks for the review. On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: On Fri, Jul 20, 2012 at 12:16:26PM +0530, AnilKumar Ch wrote: + vio_reg: regulator@1 { + reg = 1; + regulator-compatible = vio; +

Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-20 Thread Mark Brown
On Fri, Jul 20, 2012 at 11:27:36AM +, AnilKumar, Chimata wrote: On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote: Every regulator here has a rather large voltage range specified with no consumers added. Are you sure these voltage ranges make sense in your design and you've not just