Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-08-08 Thread Tony Lindgren
* Konstantin Baydarov kbaida...@dev.rtsoft.ru [120627 11:09]: + +/* TODO: Add helpers for 16bit and byte access */ +#ifdef CONFIG_MFD_OMAP_CONTROL +u32 omap_control_status_read(u16 offset); +#else +static inline u32 omap_control_status_read(u16 offset) +{ + return 0; +} +#endif This

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-07-03 Thread Valentin, Eduardo
Hello, On Thu, Jun 28, 2012 at 1:55 PM, Valentin, Eduardo eduardo.valen...@ti.com wrote: Hello again, On Thu, Jun 28, 2012 at 1:51 PM, Valentin, Eduardo eduardo.valen...@ti.com wrote: Hello, On Thu, Jun 28, 2012 at 1:26 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote: On 06/28/2012

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Konstantin Baydarov
Hi. On 06/28/2012 08:50 AM, Eduardo Valentin wrote: Hello, On Wed, Jun 27, 2012 at 10:04:54PM +0400, Konstantin Baydarov wrote: This patch introduces a MFD core device driver for OMAP system control module. The control module allows software control of various static modes supported

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Valentin, Eduardo
Hello, On Thu, Jun 28, 2012 at 12:37 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote:  Hi. On 06/28/2012 08:50 AM, Eduardo Valentin wrote: Hello, On Wed, Jun 27, 2012 at 10:04:54PM +0400, Konstantin Baydarov wrote: This patch introduces a MFD core device driver for OMAP system

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Konstantin Baydarov
Hello. On 06/28/2012 01:49 PM, Valentin, Eduardo wrote: Hello, On Thu, Jun 28, 2012 at 12:37 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote: Hi. On 06/28/2012 08:50 AM, Eduardo Valentin wrote: Hello, On Wed, Jun 27, 2012 at 10:04:54PM +0400, Konstantin Baydarov wrote: This

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Konstantin Baydarov
On 06/28/2012 02:12 PM, Konstantin Baydarov wrote: The interface(design) of omap-control-core.c has already been discussed many times :( Eduardo, in his patch set, suggested following design: - omap-control-core.c ioremaps SCM window and provide functions to read/write SCP register for

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Valentin, Eduardo
Hello, On Thu, Jun 28, 2012 at 1:26 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote: On 06/28/2012 02:12 PM, Konstantin Baydarov wrote: The interface(design) of omap-control-core.c has already been discussed many times :( Eduardo, in his patch set, suggested following design: -

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-28 Thread Valentin, Eduardo
Hello again, On Thu, Jun 28, 2012 at 1:51 PM, Valentin, Eduardo eduardo.valen...@ti.com wrote: Hello, On Thu, Jun 28, 2012 at 1:26 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote: On 06/28/2012 02:12 PM, Konstantin Baydarov wrote: The interface(design) of omap-control-core.c has

Re: [PATCH v3 2/7] mfd: omap: control: core system control driver

2012-06-27 Thread Eduardo Valentin
Hello, On Wed, Jun 27, 2012 at 10:04:54PM +0400, Konstantin Baydarov wrote: This patch introduces a MFD core device driver for OMAP system control module. The control module allows software control of various static modes supported by the device. It is composed of two control submodules: