-Original Message-
From: ext Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: 08 March, 2010 19:16
To: Kristo Tero (Nokia-D/Tampere)
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv6 9/9] OMAP3: PM: Added support for
suspending to INACTIVE state
tero.kri...@nokia.com
-Original Message-
From: ext Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: 08 March, 2010 19:06
To: Kristo Tero (Nokia-D/Tampere)
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP3: GPIO: Added dynamic control logic
for pad wakeups
Tero Kristo tero.kri...@nokia.com
Kevin,
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin
Hilman
Sent: Tuesday, March 09, 2010 12:23 AM
To: linux-omap@vger.kernel.org
Subject: [PATCH/RFT v3] OMAP4: fix temporary hacks that break multi-omap PM
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Monday, March 08, 2010 11:49 PM
To: Gopinath, Thara
Cc: linux-omap@vger.kernel.org; khil...@deeprootsystems.com; p...@pwsan.com;
Menon, Nishanth;
Sripathy, Vishwanath; Sawant, Anand; Cousson, Benoit
Subject: Re:
-Original Message-
From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: Monday, March 08, 2010 11:06 PM
To: Gopinath, Thara
Cc: linux-omap@vger.kernel.org; p...@pwsan.com; Menon, Nishanth; Sripathy,
Vishwanath; Sawant, Anand;
Cousson, Benoit
Subject: Re: [PATCH 0/3] OMAP3: PM:
Hi All,
I'm working on android ported on a beagleboard.using the rowboat version.
I was faced with some errors related to the smart reflex VDD
autocompansation and as a resolution I wanted to change the current
linux kernel to the linux-omap-pm latest branches with smart reflex
patches.
My
Hi,
From: Felipe Balbi [mailto:felipe.ba...@nokia.com]
Sent: Tuesday, March 09, 2010 12:52 AM
On Tue, Mar 09, 2010 at 02:42:36AM +0100, ext Tony Lindgren wrote:
After a quick search for mailing list netiquette I cam up with
the following links:
From: Shweta Gulati shweta.gul...@ti.com
When the Dsp Bridge module is loaded, the state Of Iva Power domain
configured in suspend path (provided enable_off_mode is disabled) by
DspBridge code and PM code are different so IVA does not
enter the target state .Per and Core domain have sleep
* Felipe Balbi m...@felipebalbi.com [100309 06:27]:
Hi,
On Mon, Mar 08, 2010 at 03:04:23PM -0800, Tony Lindgren wrote:
Hmm yeah thanks for digging into this mystery. Looks like we're
hitting some Linux initdata limitation.
We can't mark everything as __initconst. Some platform data
On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote:
But sounds like your fix to mark anything going to init.rodata as const
is correct since it is rodata. I was originally thinking this is somehow
related to __init vs __initconst, but it's for __initconst only, and
we should use
Hi,
On Mon, Mar 08, 2010 at 03:04:23PM -0800, Tony Lindgren wrote:
Hmm yeah thanks for digging into this mystery. Looks like we're
hitting some Linux initdata limitation.
We can't mark everything as __initconst. Some platform data can
get dynamically set based on the board type for
Hi Hari,
Thanks for your comment.
What you're saying is perfectly true, however I find current way is a bit
awkward and potentially dangerous if for any reason value of
OMAP_DMA_SYNC_PACKET changes in the future, or if more constants are defined
later on.
I think proposed patch improves the
* Cory Maccarrone darkstar6...@gmail.com [100308 19:03]:
On Mon, Mar 8, 2010 at 6:46 PM, Tony Lindgren t...@atomide.com wrote:
Alright, I found it. 0c8219f0302d0d27fda52c790d38406801e547ec removed
this code from uncompress.h:
- if (check_port(uart, shift))
-
This bits are exclusive of omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/cm-regbits-34xx.h |2 ++
arch/arm/mach-omap2/prcm-common.h |4
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git
This is for protecting a wrong mapping attempt of a zero-based
physical address.
The result is that, no serial port will be attempted to be mapped.
Also add an additional protection for NULL clocks before attempting
to enable them (if above condition applies)
Signed-off-by: Sergio Aguirre
This is only valid for omap 36xx family of chips.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/clock3xxx_data.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/clock3xxx_data.c
Hi,
This is v3 of my serial work series merge found here: [1].
And it's meant to be applied on top of Thomas's patch: [2]
Changelog compared to previous version:
- Added WARN_ON when no clocks acquired for a uart to be
initialized. (Thanks Felipe and Kevin)
- Added missing patch
To standarize among other uarts (1 to 3), we shall now:
- Enable uart4 autodile bit.
- Enable uart4 wakeup in PER.
- Allow uart4 to wakeup the MPU.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/pm34xx.c |8 ++--
1 files changed, 6 insertions(+), 2
This check is invalid, since we haven't filled the
omap_revision var at this point.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/serial.c | 14 +-
1 files changed, 1 insertions(+), 13 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c
There's no more serial ports available, so, doesn't make sense
to create 4 device nodes.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/configs/omap_zoom2_defconfig |2 +-
arch/arm/configs/omap_zoom3_defconfig |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
All UARTs seem physically reachable, so, enable them all.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-3630sdp.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
mode change 100755 = 100644 arch/arm/mach-omap2/board-3630sdp.c
diff --git
This is useless, since in Zoom2/3 boards, the ports aren't even
physically accessible.
They must be explicitly initted in the board-zoom2.c, board-zoom3.c
and board-3630sdp.c files instead.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c |1 -
This is now changed to PLAT8250_DEV_PLATFORM (= 0), because
it's the only port that's going to be initialized in
Zoom 2/3 boards.
So, it doesn't make sense to keep the hardcoded 3 value anymore.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
arch/arm/mach-omap2/board-zoom-debugboard.c |
This patch makes the following:
- Adds missing wakeup padding register handling.
- Fixes a hardcode to use PER module ONLY on UART3.
- Adds UART4 IRQ number define for 36xx chips.
- Corrects IRQ number for 3630 case.
Signed-off-by: Sergio Aguirre saagui...@ti.com
---
On Tue, Mar 09, 2010 at 10:16:45AM -0600, Sergio Aguirre wrote:
@@ -664,6 +664,12 @@ void __init omap_serial_early_init(void)
struct device *dev = pdev-dev;
struct plat_serial8250_port *p = dev-platform_data;
+ /* Don't map zero-based physical address
Hi Felipe,
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Tuesday, March 09, 2010 10:21 AM
On Tue, Mar 09, 2010 at 10:16:45AM -0600, Sergio Aguirre wrote:
@@ -664,6 +664,12 @@ void __init omap_serial_early_init(void)
struct device *dev = pdev-dev;
struct
Hi,
On a general note.
To avoid spamming with frequent resends and version changes, I'll better
wait for any of you to review it today, and tomorrow I'll resend, grouping
all comments I'll receive today.
Thanks for your attention, comments and time!
Regards,
Sergio
-Original
Shilimkar, Santosh santosh.shilim...@ti.com writes:
Kevin,
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin
Hilman
Sent: Tuesday, March 09, 2010 12:23 AM
To: linux-omap@vger.kernel.org
Subject: [PATCH/RFT v3]
Hi Kishore,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Y, Kishore
Sent: Saturday, March 06, 2010 8:17 AM
To: Tomi Valkeinen
Cc: linux-omap@vger.kernel.org
Subject: [PATCH V4] OMAP: DSS: Add NEC NL8048HL11-01B
multi-OMAP builds are broken in various ways due to conditional code.
Here is a small series of fixes.
Build tested: omap3_defconfig, omap_4430sdp_defconfig
Boot tested: omap3_defconfig on OMAP3EVM
Needs boot testing on OMAP4.
Applies on current l-o master branch.
Kevin Hilman (2):
OMAP2:
Currently if omap2420 is defined but not omap2430, cpu_is_omap2430()
is still defined as a macro, instead of #define'd to zero. This
results in conditional cpu_is_omap2430() code still being compiled,
and leads to possible compile/link errors. In particular for hwmod
init.
To fix, add extra
When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
will be true and prevent included code from building/running for
OMAP2/3 as well.
This problem exists in io.c where some hwmod/PM/SDRC init code is
prevented from running even on OMAP2/3 when OMAP4 is included in a
multi-OMAP
Hi,
On Tue, Mar 09, 2010 at 10:30:08AM -0600, Aguirre, Sergio wrote:
Ok, I didn't do that, since there are other printks in the same function.
I can change it here, no problem.
I guess I can add a separate patch to standardize and change all
printks to dev_* macros... would that make
* Aguirre, Sergio saagui...@ti.com [100309 07:18]:
Hi,
From: Felipe Balbi [mailto:felipe.ba...@nokia.com]
Sent: Tuesday, March 09, 2010 12:52 AM
On Tue, Mar 09, 2010 at 02:42:36AM +0100, ext Tony Lindgren wrote:
After a quick search for mailing list netiquette I cam up with
the
Dear Felipe,
Bug I've reported earlier is still reproducible. Steps are within
earlier mail (one way is to insert USB cable,
use g_file/mass_storage, allow device to mount, rmmod it, load g_ether
get crash).
gnome5:~# insmod ./g_ether.ko
[ 1085.923736] g_ether gadget: using random self ethernet
tero.kri...@nokia.com writes:
-Original Message-
From: ext Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: 08 March, 2010 19:06
To: Kristo Tero (Nokia-D/Tampere)
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP3: GPIO: Added dynamic control logic
for pad wakeups
Tero
* tero.kri...@nokia.com tero.kri...@nokia.com [100309 00:20]:
Changes in wakeup state should not be directly correlated to interrupt
enabled GPIOs. Rather, this should only be done for GPIOs that are
explicitly wakeup enabled (via enable_irq_wake(), which in turn
calls gpio_wake_enable()).
tero.kri...@nokia.com writes:
-Original Message-
From: ext Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: 08 March, 2010 19:16
To: Kristo Tero (Nokia-D/Tampere)
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv6 9/9] OMAP3: PM: Added support for
suspending to INACTIVE
Gopinath, Thara th...@ti.com writes:
-Original Message-
From: Kevin Hilman [mailto:khil...@deeprootsystems.com]
Sent: Monday, March 08, 2010 11:06 PM
To: Gopinath, Thara
Cc: linux-omap@vger.kernel.org; p...@pwsan.com; Menon, Nishanth; Sripathy,
Vishwanath; Sawant, Anand;
Cousson, Benoit
Tony Lindgren t...@atomide.com writes:
* tero.kri...@nokia.com tero.kri...@nokia.com [100309 00:20]:
Changes in wakeup state should not be directly correlated to interrupt
enabled GPIOs. Rather, this should only be done for GPIOs that are
explicitly wakeup enabled (via enable_irq_wake(),
Sripathy, Vishwanath vishwanath...@ti.com writes:
From: Shweta Gulati shweta.gul...@ti.com
When the Dsp Bridge module is loaded, the state Of Iva Power domain
configured in suspend path (provided enable_off_mode is disabled) by
DspBridge code and PM code are different so IVA does not
* Kevin Hilman khil...@deeprootsystems.com [100309 11:23]:
Tony Lindgren t...@atomide.com writes:
* tero.kri...@nokia.com tero.kri...@nokia.com [100309 00:20]:
Changes in wakeup state should not be directly correlated to interrupt
enabled GPIOs. Rather, this should only be done for
I just updated all my Beagle and Overo DSS patches to apply on the
latest linux-omap head.
I ran into a slight issue with parsing defaults, but saw that Tomi had
already posted a workaround for that.
With that patch applied I get pretty good results until I try to do
something like play a DVD or
On Tue, Mar 9, 2010 at 7:56 AM, Tony Lindgren t...@atomide.com wrote:
* Cory Maccarrone darkstar6...@gmail.com [100308 19:03]:
On Mon, Mar 8, 2010 at 6:46 PM, Tony Lindgren t...@atomide.com wrote:
Alright, I found it. 0c8219f0302d0d27fda52c790d38406801e547ec removed
this code from
From: Chunqiu Wang cqw...@motorola.com
Current OMAP resource fwk uses a global res_mutex
for resource_request and resource_release calls
for all the available resources.It may cause dead
lock if resource_request/resource_release is called
recursively.
For current OMAP3 VDD1/VDD2 resource, the
On Tue, Mar 9, 2010 at 4:09 PM, y...@google.com wrote:
From: Chunqiu Wang cqw...@motorola.com
Current OMAP resource fwk uses a global res_mutex
for resource_request and resource_release calls
for all the available resources.It may cause dead
lock if resource_request/resource_release is
* Felipe Balbi m...@felipebalbi.com [100309 07:44]:
On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote:
But sounds like your fix to mark anything going to init.rodata as const
is correct since it is rodata. I was originally thinking this is somehow
related to __init vs
Hi Ambresh,
+ clk_sel_regval = cm_read_mod_reg(PLL_MOD, CM_CLKSEL);
*clk already as reference to CM_CLKSEL:
static struct clk dpll3_m2_ck = {
[...]
.clksel_reg = OMAP_CM_REGADDR(PLL_MOD, CM_CLKSEL1),
.clksel_mask= OMAP3430_CORE_DPLL_CLKOUT_DIV_MASK,
Hi,
On Tue, Mar 09, 2010 at 04:48:27PM -0800, Tony Lindgren wrote:
[snip]
@@ -273,7 +273,7 @@ static void __init am3517_evm_init_irq(void)
omap_gpio_init();
}
-static struct ehci_hcd_omap_platform_data ehci_pdata __initdata = {
+static const struct ehci_hcd_omap_platform_data
Thanks Kevin,
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin
Hilman
Sent: Tuesday, March 09, 2010 10:34 PM
To: linux-omap@vger.kernel.org
Subject: [PATCH/RFT 0/2] fixes for broken PM init with multi-OMAP
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin
Hilman
Sent: Tuesday, March 09, 2010 10:34 PM
To: linux-omap@vger.kernel.org
Subject: [PATCH/RFT 2/2] OMAP4: fix temporary hacks that break multi-omap PM
When
Gurav , Pramod wrote:
Hi Ambresh,
+ clk_sel_regval = cm_read_mod_reg(PLL_MOD, CM_CLKSEL);
*clk already as reference to CM_CLKSEL:
static struct clk dpll3_m2_ck = {
[...]
.clksel_reg = OMAP_CM_REGADDR(PLL_MOD, CM_CLKSEL1),
.clksel_mask=
52 matches
Mail list logo
