Re: [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-07-01 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 1:06 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Balaji, On 6/30/2011 9:04 PM, Krishnamoorthy, Balaji T wrote: Removing the custom state machine - lazy disable framework in omap_hsmmc to make way for runtime pm to handle host controller power states. This allows

Re: [PATCH 1/7] OMAP: ID: introduce chip detection for OMAP4460

2011-07-01 Thread Tony Lindgren
* Rajendra Nayak rna...@ti.com [110630 19:03]: --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-omap2/id.c @@ -331,8 +331,8 @@ static void __init omap3_check_revision(void) static void __init omap4_check_revision(void) { u32 idcode; - u16 hawkeye; u8 rev; + u16

Re: [PATCH 7/7] 4460sdp/blaze/panda: hwmod: Prevent gpio1 reset during hwmod init

2011-07-01 Thread Tony Lindgren
* Rajendra Nayak rna...@ti.com [110630 19:03]: For 4460sdp/blaze/panda, GPIO-7 of bank1 is used for controlling the TPS modes, hence GPIO1 should not be reset during init as reset will cause the TPS voltage to drop to 0.9 V preventing the system from continuing the boot. NAK for this patch.

[GIT PULL] omap iommu fixes for v3.0-rc

2011-07-01 Thread Ohad Ben-Cohen
Hi Tony, Please pull from: git://github.com/ohadbc/omap-iommu.git for-tony To receive trivial iommu/iovmm fixes (iommu clk name fix, pte fix and a fix for iovmm's erroneous usage of sg_dma_len as reported by Russell). All three patches were submitted to linux-omap and linux-arm-kernel for

Re: [GIT PULL] omap iommu fixes for v3.0-rc

2011-07-01 Thread Tony Lindgren
* Ohad Ben-Cohen o...@wizery.com [110630 23:47]: Hi Tony, Please pull from: git://github.com/ohadbc/omap-iommu.git for-tony To receive trivial iommu/iovmm fixes (iommu clk name fix, pte fix and a fix for iovmm's erroneous usage of sg_dma_len as reported by Russell). All three

Re: [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put

2011-07-01 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [110602 14:22]: On Wed, 1 Jun 2011, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk Add missing call to clk_put. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r

Re: [PATCH] DMA: OMAP: Remove extra looping from omap_request_dma

2011-07-01 Thread Tony Lindgren
* Scott Ellis sc...@jumpnowtek.com [110629 20:58]: Break from dma channel search when a free one is found. Care to describe how the current code is not finding a free channel currently? Tony Signed-off-by: Scott Ellis sc...@jumpnowtek.com --- arch/arm/plat-omap/dma.c |5 ++--- 1

Re: [PATCH] OMAP4: DMTIMER: enable autoidle mode

2011-07-01 Thread Tony Lindgren
* K, Ambresh ambr...@ti.com [110615 21:41]: On Wed, Jun 15, 2011 at 9:39 PM, DebBarma, Tarun Kanti tarun.ka...@ti.comwrote: Currently autoidle is only enabled for OMAP2/3; by enabling autoidle, the automatic L4 clock gating strategy is applied based on L4 activity, otherwise L4 clock

Re: [PATCH] ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()

2011-07-01 Thread Tony Lindgren
* Kevin Hilman khil...@ti.com [110617 13:54]: Daniel Mack zon...@gmail.com writes: overo_ads7846_init() is already called from overo_spi_init(), and calling it twice is not only unnecessary but causes a warning as reg-fixed-voltage.1 is already added to the device tree. Excellent,

Re: [PATCH 2/3] Add tps65921 chip

2011-07-01 Thread Tony Lindgren
Samuel, * gr...@linuxhacker.ru gr...@linuxhacker.ru [110614 08:42]: From: Oleg Drokin gr...@linuxhacker.ru Very similar to TPS65920 List of differences: http://www.ti.com/litv/pdf/swcu066b CC: sa...@linux.intel.com Signed-off-by: Oleg Drokin gr...@linuxhacker.ru Looks like this one can

Re: [PATCH v2 1/1] omap: blaze: add mmc5/wl1283 device support

2011-07-01 Thread Tony Lindgren
* Vishal Mahaveer vish...@ti.com [110624 12:43]: Add MMC5 support on BLAZE, which has the wl1283 device hardwired to. The wl1283 is a 4-wire, 1.8V, embedded SDIO WLAN device with an external IRQ line, and power-controlled by a GPIO-based fixed regulator. Applying into devel-board branch.

Re: [PATCH] OMAP4: Keyboard: Mux changes in the board file

2011-07-01 Thread Tony Lindgren
* Shubhrajyoti D shubhrajy...@ti.com [110623 05:10]: The mux settings for keypad are done for omap4430sdp in board file. Applying into devel-board branch. +static struct omap_board_data keypad_data = { + .id = 1, + .pads= keypad_pads, + .pads_cnt =

Re: [GIT PULL] omap iommu fixes for v3.0-rc

2011-07-01 Thread Ohad Ben-Cohen
On Fri, Jul 1, 2011 at 10:00 AM, Tony Lindgren t...@atomide.com wrote: These look like real fixes, but can you please update the commits with something like This fixes an issue with foo when doing bar. Done, please tell me if it's OK now. Otherwise it's easy to claim that these are fixes for

Re: [PATCH 0/2] RETU meets Sparse IRQ

2011-07-01 Thread Tony Lindgren
* Leigh Brown le...@solinno.co.uk [110629 14:14]: On Wed, 29 Jun 2011 14:46:49 +0300, Felipe Balbi wrote: now with Sparse IRQ numbering, we don't need to add a bunch of defines in plat/irqs.h Compile tested with omap2plus_defconfig (+cbus) and omap1_defconfig (+cbus). Felipe Balbi (2):

Re: [PATCH 0/6] OMAP2+: hwmod framework fixes

2011-07-01 Thread Paul Walmsley
Hi Benoît, On Thu, 23 Jun 2011, Benoit Cousson wrote: Here are the latest bug fixes done on the hwmod framework. There are mainly around wakeup capability added in OMAP4. These look good to me too. These need to be cc'ed to lakml also, of course... - Paul

Re: [PATCH 6/6] OMAP2+: hwmod: Fix the HW reset management

2011-07-01 Thread Paul Walmsley
One quick comment here: On Thu, 23 Jun 2011, Benoit Cousson wrote: The HW reset must be de-assert after the clocks are enabled but before waiting for the target to be ready. Otherwise the reset might not work properly since the clock is not running to proceed the reset. De-assert the

Re: [PATCH 6/6] OMAP2+: hwmod: Fix the HW reset management

2011-07-01 Thread Cousson, Benoit
On 7/1/2011 10:44 AM, Paul Walmsley wrote: One quick comment here: On Thu, 23 Jun 2011, Benoit Cousson wrote: The HW reset must be de-assert after the clocks are enabled but before waiting for the target to be ready. Otherwise the reset might not work properly since the clock is not running

Re: [PATCH 0/8] HDMI: Split hdmi.c to seperate HDMI IP dependant code from DSS.

2011-07-01 Thread Tomi Valkeinen
On Thu, 2011-06-30 at 23:16 +0530, K, Mythri P wrote: Hi Tomi, On Wed, Jun 29, 2011 at 9:51 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2011-06-29 at 19:08 +0530, K, Mythri P wrote: Hi Tomi, As the HDMI PLL , PHY and video blocks are logical blocks it would make

[RFC 0/12] McBSP cleanup and generalization

2011-07-01 Thread Jarkko Nikula
Hi Some cleanups to McBSP code and attempts to make it more generic. I'll be out of office in coming days but I'm happy to hear how does this set work on OMAP1 Amstrad Delta as there are changes around register definitions and access. I've tested this on 2420 and 3430 and build tested with

[RFC 01/12] ASoC: OMAP: McBSP: fix build breakage on OMAP1

2011-07-01 Thread Jarkko Nikula
From: Paul Walmsley p...@pwsan.com After commits d13586574d373ef40acd4725c9a269daa355e412 (OMAP: McBSP: implement functional clock switching via clock framework) and cf4c87abe238ec17cd0255b4e21abd949d7f811e (OMAP: McBSP: implement McBSP CLKR and FSR signal muxing via mach-omap2/mcbsp.c), any

[RFC 02/12] omap: mcbsp: Remove rx_/tx_word_length variables

2011-07-01 Thread Jarkko Nikula
These variables got unused after (omap: mcbsp: Drop in-driver transfer support) but was noticed only afterwards. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/plat-omap/include/plat/mcbsp.h |2 -- arch/arm/plat-omap/mcbsp.c |3 --- 2 files changed, 0

[RFC 03/12] omap: mcbsp: Remove port number enums

2011-07-01 Thread Jarkko Nikula
These McBSP port number enums are used only in two places in the McBSP code so we may remove then and just use numeric values like rest of the code does. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/mach-omap1/mcbsp.c |4 ++--

[RFC 04/12] omap: mcbsp: Merge OMAP1 and OMAP2+ McBSP register definitions

2011-07-01 Thread Jarkko Nikula
There is no need to have separate register definitions for OMAP1 since they are ordered similarly than in OMAP2+ and thus register address offsets can be calculated from OMAP2+ register address offsets. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/plat-omap/include/plat/mcbsp.h |

[RFC 05/12] omap: mcbsp: Move out omap_mcbsp_register_board_cfg from plat-omap/devices.c

2011-07-01 Thread Jarkko Nikula
Only OMAP1s are using omap_mcbsp_register_board_cfg after OMAP2+ hwmod conversion so it can be moved to mach-omap1/mcbsp.c. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/mach-omap1/mcbsp.c | 32 + arch/arm/plat-omap/devices.c| 46

[RFC 06/12] omap: mcbsp: Implement generic register and cache access

2011-07-01 Thread Jarkko Nikula
Get rid of is_omap tests in omap_mcbsp_write and omap_mcbsp_read by using register size and register step variables that are passed via platform data Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/mach-omap1/mcbsp.c |2 + arch/arm/mach-omap2/mcbsp.c |

[RFC 07/12] omap: mcbsp: Get rid of remaining is_omap tests

2011-07-01 Thread Jarkko Nikula
We can get rid of remaining is_omap tests in the driver by using mcbsp_config_type that is set in omap hwmod data for 2430, 34xx and 44xx. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/plat-omap/mcbsp.c | 30 ++ 1 files changed, 14 insertions(+), 16

[RFC 08/12] omap: mcbsp: Remove omap device API

2011-07-01 Thread Jarkko Nikula
struct omap_device *od is only set with find_omap_device_by_dev but not used otherwise so remove them and references to omap device API. Signed-off-by: Jarkko Nikula jhnik...@gmail.com --- arch/arm/plat-omap/mcbsp.c | 27 --- 1 files changed, 0 insertions(+), 27

[RFC 09/12] omap: mcbsp: Move OMAP3+ wakeup enable/disable to omap_mcbsp_request/_free

2011-07-01 Thread Jarkko Nikula
There are only enable/disable wakeup behavior code left in omap34xx_mcbsp_request/_free after hwmod conversion so it can be well moved to generic omap_mcbsp_request/_free. Remove also old comments about idle mode settings and HW bug workarounds that were not updated during hwmod conversion.

[RFC 10/12] omap: mcbsp: Move sidetone clock management to mach-omap2/mcbsp.c

2011-07-01 Thread Jarkko Nikula
Active sidetone requires that McBSP interface clock doesn't idle and there is no mechanism in hwmod to turn autoidling on/off in runtime. McBSP2 and 3 in OMAP34xx share their interface clock with McBSP sidetone module and that interface clock must be active when the sidetone is operating.

[RFC 11/12] omap: mcbsp: Remove conditional compilation for OMAP3

2011-07-01 Thread Jarkko Nikula
Although this increases the build size a little for !OMAP3 builds it makes the code one step more generic. For instance the threshold based DMA transfers seems to be possible with OMAP4 too from quick look of the TRM. Signed-off-by: Jarkko Nikula jhnik...@gmail.com ---

[RFC 12/12] omap: mcbsp: Reorganize DMA operating mode and sidetone init/exit code

2011-07-01 Thread Jarkko Nikula
Reorganize DMA operating mode and sidetone initialization/ext code so that they are not tied together and can be extended over OMAP3. Currently DMA operating mode control is added only on OMAP3 but can be extended in the future. Sidetone initialization is alredy platform independed based on if

Re: [PATCH 0/8] HDMI: Split hdmi.c to seperate HDMI IP dependant code from DSS.

2011-07-01 Thread K, Mythri P
Hi Tomi, On Fri, Jul 1, 2011 at 2:21 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2011-06-30 at 23:16 +0530, K, Mythri P wrote: Hi Tomi, On Wed, Jun 29, 2011 at 9:51 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2011-06-29 at 19:08 +0530, K, Mythri P wrote:

Re: [RFC 10/12] omap: mcbsp: Move sidetone clock management to mach-omap2/mcbsp.c

2011-07-01 Thread Paul Walmsley
+ Benoît Hello Jarkko On Fri, 1 Jul 2011, Jarkko Nikula wrote: Active sidetone requires that McBSP interface clock doesn't idle and there is no mechanism in hwmod to turn autoidling on/off in runtime. McBSP2 and 3 in OMAP34xx share their interface clock with McBSP sidetone module and that

Re: [RFC 10/12] omap: mcbsp: Move sidetone clock management to mach-omap2/mcbsp.c

2011-07-01 Thread Cousson, Benoit
On 7/1/2011 11:23 AM, Paul Walmsley wrote: + Benoît Hello Jarkko On Fri, 1 Jul 2011, Jarkko Nikula wrote: Active sidetone requires that McBSP interface clock doesn't idle and there is no mechanism in hwmod to turn autoidling on/off in runtime. McBSP2 and 3 in OMAP34xx share their interface

Re: [RFC 10/12] omap: mcbsp: Move sidetone clock management to mach-omap2/mcbsp.c

2011-07-01 Thread Paul Walmsley
cc'ing Kishon On Fri, 1 Jul 2011, Cousson, Benoit wrote: On 7/1/2011 11:23 AM, Paul Walmsley wrote: On Fri, 1 Jul 2011, Jarkko Nikula wrote: Active sidetone requires that McBSP interface clock doesn't idle and there is no mechanism in hwmod to turn autoidling on/off in runtime.

Re: [PATCH v2 03/13] OMAP4: hwmod: Replace CLKCTRL absolute address with offset macros

2011-07-01 Thread Paul Walmsley
Hi On Mon, 27 Jun 2011, Benoit Cousson wrote: The CLKCTRL register was accessed using an absolute address. The usage of hardcoded macros to calculate virtual address from physical one should be avoided as much as possible. The usage of a offset will allow future improvement like migration

[PATCH v3 00/20] GPIO: OMAP: driver cleanup and fixes

2011-07-01 Thread Tarun Kanti DebBarma
This series is continuation of cleanup of OMAP GPIO driver and fixes. The cleanup include getting rid of cpu_is_* checks wherever possible, use of gpio_bank list instead of static array, use of unique platform specific value associated data member to OMAP platforms to avoid cpu_is_* checks. The

[PATCH v3 01/20] GPIO: OMAP: Remove dependency on gpio_bank_count

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com The gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this dependency from the driver by using list. Also remove the dependency on array of pointers to gpio_bank struct of all GPIO devices. Signed-off-by: Charulatha V ch...@ti.com ---

[PATCH v3 02/20] GPIO: OMAP2+: Use flag to identify wakeup domain

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com In omap3, save/restore context is implemented for GPIO banks 2-6 as GPIO bank1 is in wakeup domain. Instead of identifying bank's power domain by bank id, use 'loses_context' flag which is filled by pwrdm_can_ever_lose_context() during dev_init. For getting the

[PATCH v3 03/20] GPIO: OMAP: Make gpio_context part of gpio_bank structure

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Currently gpio_context array used to save gpio bank's context, is used only for OMAP3 architecture. Move gpio_context as part of gpio_bank structure so that it can be specific to each gpio bank and can be used for any OMAP architecture Signed-off-by: Charulatha V

[PATCH v3 04/20] GPIO: OMAP: Fix pwrdm_post_transition call sequence

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com The context lost count is modified in omap_sram_idle() path when pwrdm_post_transition() is called. But pwrdm_post_transition() is called only after omap_gpio_resume_after_idle() is called. Correct this so that context lost count is modified before calling

[PATCH v3 05/20] GPIO: OMAP: Handle save/restore ctx in GPIO driver

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Modify omap_gpio_prepare_for_idle() omap_gpio_resume_after_idle() functions to handle save context restore context respectively in the OMAP GPIO driver itself instead of calling these functions from pm specific files. For this, in gpio_prepare_for_idle(), call

[PATCH v3 06/20] GPIO: OMAP2+: Make non-wakeup GPIO part of pdata

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Non-wakeup GPIOs are available only in OMAP2. Avoid cpu_is checks by making non_wakeup_gpios as part of pdata. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap2/gpio.c |8 arch/arm/plat-omap/include/plat/gpio.h |1 +

[PATCH v3 08/20] GPIO: OMAP: Use wkup regs off/suspend support flag

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Wakeup register offsets are initialized according to OMAP versions during device registration. These explicit checks are no longer needed. mpuio_init() function is defined under #ifdefs. It is required only in case of MPUIO bank type and only when PM operations

[PATCH v3 09/20] GPIO: OMAP: Use level/edge detect reg offsets

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com By adding level and edge detection register offsets and then initializing them correctly according to OMAP versions during device registrations we can now remove lot of revision checks in these functions. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com

[PATCH v3 07/20] GPIO: OMAP: Avoid cpu checks during module ena/disable

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Remove cpu-is checks while enabling/disabling OMAP GPIO module during a gpio request/free. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap2/gpio.c |2 + arch/arm/plat-omap/include/plat/gpio.h |1 + drivers/gpio/gpio-omap.c

[PATCH v3 10/20] GPIO: OMAP: Remove hardcoded offsets in ctxt save/restore

2011-07-01 Thread Tarun Kanti DebBarma
It is not required to use hard-coded offsets any more in context save and restore functions and instead use the generic offsets which have been correctly initialized during device registration. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Signed-off-by: Charulatha V ch...@ti.com ---

[PATCH v3 11/20] GPIO: OMAP: Clean set_gpio_triggering function

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Getting rid of ifdefs within the function by adding register offset intctrl and associating OMAP_GPIO_INT_CONTROL in respective SoC specific files. Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com ---

[PATCH v3 12/20] GPIO: OMAP: Use wkup_status for all SoCs

2011-07-01 Thread Tarun Kanti DebBarma
On OMAP4 we are not allowed to access wakeup_set/clear registers. So instead of having additional check and separate logics for manipulating the status register use wakup_status regisre consistently for all SoCs wherever applicable. Use the MOD_REG_BIT macro to read, modify and write the status

[PATCH v3 13/20] GPIO: OMAP: Clean omap_gpio_mod_init function

2011-07-01 Thread Tarun Kanti DebBarma
With register offsets now defined for respective OMAP versions we can get rid of cpu_class_* checks. This function now has common initialization code for all OMAP versions. Initialization specific to OMAP16xx has been moved within omap16xx_gpio_init(). Signed-off-by: Tarun Kanti DebBarma

[PATCH v3 14/20] GPIO: OMAP15xx: Use pinctrl offset instead of macro

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Use regs-pinctrl field instead of using the macro OMAP1510_GPIO_PIN_CONTROL Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap1/gpio15xx.c |1 + arch/arm/plat-omap/include/plat/gpio.h |1 + drivers/gpio/gpio-omap.c |

[PATCH v3 15/20] GPIO: OMAP: Use readl in irq_handler for all access

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Even when bank-width is 16, all the OMAP1 registers are 4-byte aligned, so just use a 4-byte read. The 'enabled' mask is already taking care to mask for bank width. Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com

[PATCH v3 16/20] GPIO: OMAP: Remove bank-method METHOD_* macros

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com The only bank-type (method) used in the OMAP GPIO driver is MPUIO type as they need to be handled separately. Identify the same using a flag and remove all METHOD_* macros. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap1/gpio15xx.c |3

[PATCH v3 17/20] GPIO: OMAP: Fix bankwidth for OMAP7xx MPUIO

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com In all OMAP1 SoCs, the MPUIO bank width is 16 bits. But, in OMAP7xx, it is wrongly initialised to 32. Fix this. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap1/gpio7xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH v3 18/20] GPIO: OMAP: Use PM runtime framework

2011-07-01 Thread Tarun Kanti DebBarma
From: Charulatha V ch...@ti.com Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync() for enabling/disabling clocks appropriately. Remove syscore_ops and instead use dev_pm_ops now. Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com ---

[PATCH v3 19/20] GPIO: OMAP: optimize suspend and resume functions

2011-07-01 Thread Tarun Kanti DebBarma
There is no need to operate on all the banks every time the function is called. Just operate on the current bank passed by the framework. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com --- drivers/gpio/gpio-omap.c | 56 ++--- 1 files changed, 27

[PATCH v3 20/20] GPIO: OMAP2+: Clean prepare_for_idle and resume_after_idle

2011-07-01 Thread Tarun Kanti DebBarma
Simplify omap2_gpio_prepare_for_idle() and omap2_gpio_resume_after_idle() by moving most of the stuff to *_pm_runtime_suspend() and *_pm_runtime_resume(). Also, omap_gpio_suspend() and omap_gpio_resume() optimized to operate per GPIO bank instead of operating on entire list every time.

Re: [GIT PULL] omap iommu fixes for v3.0-rc

2011-07-01 Thread Tony Lindgren
* Ohad Ben-Cohen o...@wizery.com [110701 00:46]: On Fri, Jul 1, 2011 at 10:00 AM, Tony Lindgren t...@atomide.com wrote: These look like real fixes, but can you please update the commits with something like This fixes an issue with foo when doing bar. Done, please tell me if it's OK now.

Re: [PATCH 3/3] OMAP4: powerdomain data: Fix core mem states and missing cefuse flag

2011-07-01 Thread Cousson, Benoit
On 7/1/2011 1:48 AM, Paul Walmsley wrote: On Thu, 23 Jun 2011, Benoit Cousson wrote: Since ES2.0, the core ocmram does not support a different state than the main power domain anymore during both ON and RET power domain state. Since PM is not supported at all in ES1.0, update the common

Re: [PATCH v2] arm: omap: fix the alphabetical order

2011-07-01 Thread Felipe Balbi
Hi, On Fri, Jul 01, 2011 at 10:04:00AM +0900, Silesh C V wrote: On Thu, Jun 30, 2011 at 9:06 PM, Felipe Balbi ba...@ti.com wrote: That might have been correct on some ancient dead language, but I like better when things are recent. Fix the alphabetical order. Signed-off-by: Felipe

Re: [PATCH 1/7] OMAP: ID: introduce chip detection for OMAP4460

2011-07-01 Thread Aneesh V
On Friday 01 July 2011 11:55 AM, Tony Lindgren wrote: * Rajendra Nayakrna...@ti.com [110630 19:03]: --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-omap2/id.c @@ -331,8 +331,8 @@ static void __init omap3_check_revision(void) static void __init omap4_check_revision(void) { u32

Re: [RFC 10/12] omap: mcbsp: Move sidetone clock management to mach-omap2/mcbsp.c

2011-07-01 Thread ABRAHAM, KISHON VIJAY
On Fri, Jul 1, 2011 at 3:04 PM, Paul Walmsley p...@pwsan.com wrote: cc'ing Kishon On Fri, 1 Jul 2011, Cousson, Benoit wrote: On 7/1/2011 11:23 AM, Paul Walmsley wrote: On Fri, 1 Jul 2011, Jarkko Nikula wrote: Active sidetone requires that McBSP interface clock doesn't idle and

Re: [PATCH] DMA: OMAP: Remove extra looping from omap_request_dma

2011-07-01 Thread Scott Ellis
A free channel gets found correctly, that's not the problem. The patch is to eliminate the extra passes through the loop after free_ch is assigned. I dropped some printk's into omap_request_dma() [ 158.375885] inside omap_request_dma() [ 158.379577] dev_id = 61 ch = 0 free_ch = -1 [

Re: [RFC 11/12] omap: mcbsp: Remove conditional compilation for OMAP3

2011-07-01 Thread Varadarajan, Charulatha
Jarkko, On Fri, Jul 1, 2011 at 14:22, Jarkko Nikula jhnik...@gmail.com wrote: Although this increases the build size a little for !OMAP3 builds it makes the code one step more generic. For instance the threshold based DMA transfers seems to be possible with OMAP4 too from quick look of the

Re: [RFC 07/12] omap: mcbsp: Get rid of remaining is_omap tests

2011-07-01 Thread Varadarajan, Charulatha
Jarkko, On Fri, Jul 1, 2011 at 14:22, Jarkko Nikula jhnik...@gmail.com wrote: We can get rid of remaining is_omap tests in the driver by using mcbsp_config_type that is set in omap hwmod data for 2430, 34xx and 44xx. Signed-off-by: Jarkko Nikula jhnik...@gmail.com ---  

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Ming Lei
Hi, On Fri, Jul 1, 2011 at 8:33 AM, Rafael J. Wysocki r...@sisk.pl wrote: In theory it is possible that a subsystem (e.g. bus type) will enable runtime PM for devices without drivers and will (for example) put them into low power states until the drivers are loaded.  Then, it makes sense for

Re: [PATCH 2/3] Add tps65921 chip

2011-07-01 Thread Samuel Ortiz
Hi Tony, On Fri, Jul 01, 2011 at 12:35:58AM -0700, Tony Lindgren wrote: Samuel, * gr...@linuxhacker.ru gr...@linuxhacker.ru [110614 08:42]: From: Oleg Drokin gr...@linuxhacker.ru Very similar to TPS65920 List of differences: http://www.ti.com/litv/pdf/swcu066b CC:

Re: [PATCH 0/8] HDMI: Split hdmi.c to seperate HDMI IP dependant code from DSS.

2011-07-01 Thread Tomi Valkeinen
On Fri, 2011-07-01 at 14:52 +0530, K, Mythri P wrote: I don't see a need for a separate file right now. We have the hdmi_ti_4xxx_ip.c file which contains code for the HDMI block as a whole, and could well contain the code that implements the API. if the hdmi_ti_4xxx_ip.c is handling the

Re: [PATCH v3 1/8] OMAP2+: clockdomain: Add an api to read idle mode

2011-07-01 Thread Paul Walmsley
Hi On Mon, 27 Jun 2011, Benoit Cousson wrote: From: Rajendra Nayak rna...@ti.com Add a clockdomain api to check if hardware supervised idle transitions are enabled on a clockdomain. This looks good but I'd also suggest crediting Todd in the changelog for his review comments...

Re: [PATCH v3 2/8] OMAP2+: clockdomain: Add SoC support for clkdm_is_idle

2011-07-01 Thread Paul Walmsley
Hi On Mon, 27 Jun 2011, Benoit Cousson wrote: From: Rajendra Nayak rna...@ti.com Add the SoC specific implemenation for clkdm_is_idle for OMAP2/3 and OMAP4. The subject line and the changelog needs to be updated to read 'clkdm_allows_idle' Other than that, it looks good. - Paul

Re: [PATCH v2 07/13] OMAP4: prm: Replace warm reset API with the offset based version

2011-07-01 Thread Paul Walmsley
Hi minor issue... On Mon, 27 Jun 2011, Benoit Cousson wrote: The warm reset function was still using the obsolete API. Replace it by the new one and move the file to the proper c file. Signed-off-by: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Rajendra Nayak

Re: [PATCH 0/8] HDMI: Split hdmi.c to seperate HDMI IP dependant code from DSS.

2011-07-01 Thread K, Mythri P
Hi Tomi, On Fri, Jul 1, 2011 at 5:14 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-07-01 at 14:52 +0530, K, Mythri P wrote: I don't see a need for a separate file right now. We have the hdmi_ti_4xxx_ip.c file which contains code for the HDMI block as a whole, and could well

Re: [PATCH v2 04/13] OMAP: hwmod: Wait the idle status to be disabled

2011-07-01 Thread Cousson, Benoit
On 7/1/2011 2:34 PM, Paul Walmsley wrote: Hi two comments on this one: On Mon, 27 Jun 2011, Benoit Cousson wrote: It is mandatory to wait for a module to be in disabled state before potentially disabling source clock or re-asserting a reset. omap_hwmod_idle and omap_hwmod_shutdown does not

Re: [RFC 11/12] omap: mcbsp: Remove conditional compilation for OMAP3

2011-07-01 Thread Jarkko Nikula
On Fri, 1 Jul 2011 16:30:09 +0530 Varadarajan, Charulatha ch...@ti.com wrote: --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -63,7 +63,6 @@ static int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache)        }  } -#ifdef CONFIG_ARCH_OMAP3

RE: [PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag

2011-07-01 Thread Elaidi, Djamil
Benoit, HSI has no RESET_STATUS bit in SYSCONFIG register. The SYSC should be : static struct omap_hwmod_class_sysconfig omap44xx_hsi_sysc = { .rev_offs = 0x, .sysc_offs = 0x0010, .syss_offs = 0x0014, .sysc_flags = (SYSC_HAS_AUTOIDLE |

Re: [PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag

2011-07-01 Thread Cousson, Benoit
Hi Djamil, On 7/1/2011 3:50 PM, Elaidi, Djamil wrote: Benoit, HSI has no RESET_STATUS bit in SYSCONFIG register. Yes indeed, the RESETDONE is inside HSI_SYSSTATUS. And this is what that flag is meaning: SYSS_HAS_RESET_STATUS, with the SYSS prefix. The other one will be

Re: [RFC 07/12] omap: mcbsp: Get rid of remaining is_omap tests

2011-07-01 Thread Jarkko Nikula
Hi On Fri, 1 Jul 2011 16:41:23 +0530 Varadarajan, Charulatha ch...@ti.com wrote: @@ -712,7 +710,7 @@ static inline void omap34xx_mcbsp_free(struct omap_mcbsp *mcbsp)        /*         * Disable wakup behavior, smart idle and all wakeups         */ -       if (cpu_is_omap34xx() ||

Build issue.

2011-07-01 Thread Jonathan Cameron
No time to look into this now, but linux next today is giving: CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALLscripts/checksyscalls.sh CHK include/generated/compile.h CC

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Alan Stern
On Thu, 30 Jun 2011, Kevin Hilman wrote: Another curiosity is that, contrary to the above documentation, there is no usage_count increment before the bus/driver -remove() (although there is a _get_sync/_put_sync around the sysfs_remove and notifier just before the bus/driver-remove(). I

Re: runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Kevin Hilman
Kevin Hilman khil...@ti.com writes: [...] If the device bus type's or driver's -probe() or -remove() callback runs pm_runtime_suspend() or pm_runtime_idle() or their asynchronous counterparts, they will fail returning -EAGAIN, because the device's usage counter is incremented

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Kevin Hilman
Ohad Ben-Cohen o...@wizery.com writes: On Fri, Jul 1, 2011 at 3:33 AM, Rafael J. Wysocki r...@sisk.pl wrote: In theory it is possible that a subsystem (e.g. bus type) will enable runtime PM for devices without drivers and will (for example) put them into low power states until the drivers are

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Alan Stern
On Thu, 30 Jun 2011, Kevin Hilman wrote: I'm still confused about the usage_count increment around -probe though. As a few people have already pointed out, some subsystems do perform runtime PM on driverless devices. The basic idea is simple: We don't want any PM callbacks to race with each

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-07-01 Thread Ohad Ben-Cohen
On Wed, Jun 29, 2011 at 6:43 PM, Grant Likely grant.lik...@secretlab.ca wrote: So you are right that device_unregister drops the refcount to zero, but the code still needs to be fixed to not call kfree() directly. Good point, thanks ! It also looks like rpmsg_destroy_channel() needs to be

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Alan Stern
On Fri, 1 Jul 2011, Kevin Hilman wrote: OK, so the -probe() part has been explained and makes sense, but I would expect -remove() to be similarily protected (as the documentation states.) But that is not the case. Is that a bug? If so, patch below makes the code match the documentation. I

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Fri, 1 Jul 2011, Kevin Hilman wrote: OK, so the -probe() part has been explained and makes sense, but I would expect -remove() to be similarily protected (as the documentation states.) But that is not the case. Is that a bug? If so, patch

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Alan Stern
On Fri, 1 Jul 2011, Kevin Hilman wrote: --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -329,13 +329,13 @@ static void __device_release_driver(struct device *dev) blocking_notifier_call_chain(dev-bus-p-bus_notifier,

Re: [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-07-01 Thread T Krishnamoorthy, Balaji
On Fri, Jul 1, 2011 at 4:53 AM, Kevin Hilman khil...@ti.com wrote: Balaji T K balaj...@ti.com writes: +static int omap_hsmmc_runtime_resume(struct device *dev) +{ +     struct omap_hsmmc_host *host; + +     host = platform_get_drvdata(to_platform_device(dev)); +    

Re: [PATCH 0/7] OMAP4: Add 4460 base support

2011-07-01 Thread Kevin Hilman
Hi Rajendra, Rajendra Nayak rna...@ti.com writes: This series adds base support needed to be able to boot on a OMAP4460 device. Patches are based on Benoit's for_3.0.1/7_hwmod_modulemode branch and boot tested on both 4460sdp as well as 4430sdp. Since you're on the delivery path of these

Re: [PATCH 0/7] OMAP4: Add 4460 base support

2011-07-01 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: This series adds base support needed to be able to boot on a OMAP4460 device. Patches are based on Benoit's for_3.0.1/7_hwmod_modulemode branch and boot tested on both 4460sdp as well as 4430sdp. Can you also briefly summarize the dependencies between

Re: [PATCH 0/7] OMAP4: Add 4460 base support

2011-07-01 Thread Kevin Hilman
On Fri, 2011-07-01 at 09:36 -0700, Kevin Hilman wrote: Rajendra Nayak rna...@ti.com writes: This series adds base support needed to be able to boot on a OMAP4460 device. Patches are based on Benoit's for_3.0.1/7_hwmod_modulemode branch and boot tested on both 4460sdp as well as 4430sdp.

[PATCHv4 0/3] OMAP: HSMMC: cleanup and runtime pm

2011-07-01 Thread Balaji T K
Removing the custom state machine - lazy disable framework in omap_hsmmc to make way for runtime pm to handle host controller power states. This allows mmc_host_enable/mmc_host_disable to be replaced by runtime get_sync and put_sync at host controller driver. Enable runtime PM in omap_hsmmc

[PATCHv4 1/3] MMC: OMAP: HSMMC: Remove lazy_disable

2011-07-01 Thread Balaji T K
lazy_disable framework in OMAP HSMMC manages multiple low power states and Card is powered off after inactivity time of 8 seconds. Based on previous discussion on the list, card power (regulator) handling (when to power OFF/ON) should ideally be handled by core layer. Remove usage of lazy disable

[PATCHv4 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-07-01 Thread Balaji T K
add runtime pm support to HSMMC host controller Use runtime pm API to enable/disable HSMMC clock Use runtime autosuspend APIs to enable auto suspend delay Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala Signed-off-by: Balaji T K balaj...@ti.com --- changes since v3

[PATCHv4 3/3] MMC: OMAP: HSMMC: Remove unused iclk

2011-07-01 Thread Balaji T K
After runtime conversion to handle clk, iclk node is not used However fclk node is still used to get clock rate. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/mmc/host/omap_hsmmc.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git

Re: [linux-pm] runtime PM usage_count during driver_probe_device()?

2011-07-01 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Fri, 1 Jul 2011, Kevin Hilman wrote: --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -329,13 +329,13 @@ static void __device_release_driver(struct device *dev) blocking_notifier_call_chain(dev-bus-p-bus_notifier,

Re: [PATCH 0/7] OMAP4: Add 4460 base support

2011-07-01 Thread Rajendra Nayak
On 7/1/2011 9:40 AM, Kevin Hilman wrote: On Fri, 2011-07-01 at 09:36 -0700, Kevin Hilman wrote: Rajendra Nayakrna...@ti.com writes: This series adds base support needed to be able to boot on a OMAP4460 device. Patches are based on Benoit's for_3.0.1/7_hwmod_modulemode branch and boot tested

[PATCH] MMC: OMAP: change HSMMC maintainence to Orphan

2011-07-01 Thread Kevin Hilman
From: Madhusudhan Chikkature madhu...@ti.com Update the OMAP HS MMC entry from the MAINTAINERS file as I will no longer be able to maintain this driver. Signed-off-by: Madhusudhan Chikkature madhu...@ti.com [khil...@ti.com: change to Orphan rather than complete removal] Signed-off-by: Kevin

Re: [PATCH] OMAP: HSMMC maintainence

2011-07-01 Thread Kevin Hilman
S, Venkatraman svenk...@ti.com writes: On Fri, Jul 1, 2011 at 2:37 AM, Chikkature@lina0132712 wrote: From: Madhusudhan Chikkature madhu...@ti.com Removing the OMAP HS MMC entry from the MAINTAINERS file as I will no longer be able to maintain this driver. Signed-off-by: Madhusudhan

gpio interrupt is not invoked on Panda board

2011-07-01 Thread hong zhang
List, I try to get gpio_191 ping interrupted on panda but never succeeded. What I do is 1. set 0x410b on dpm_emu19 register to enable interrupt and wakeup on gpio_191 2. set bit 31 to 1 on GPIO_IRQSTATUS_SET_0 register at 0x4805d034 3. set bit 31 to 1 on GPIO_IRQWAKEN_0 register at

[PATCH 0/6 V2] arm: omap: usb: Runtime PM support for EHCI and OHCI drivers

2011-07-01 Thread Keshava Munegowda
From: Keshava Munegowda keshava_mgo...@ti.com The Hwmod structures and Runtime PM features are implemented For EHCI and OHCI drivers of OMAP3 and OMAP4. The global suspend/resume of EHCI and OHCI is validated on OMAP3430 sdp board with these patches. Benoit Cousson (1): arm: omap: usb: ehci

  1   2   >