re: mmc: omap: Fix DMA configuration to not rely on device id

2013-12-02 Thread Dan Carpenter
Hello Tony Lindgren, This is a semi-automatic email about new static checker warnings. The patch 31ee9181eb92: mmc: omap: Fix DMA configuration to not rely on device id from Nov 26, 2013, leads to the following Smatch complaint: drivers/mmc/host/omap.c:1468 mmc_omap_probe() error: we

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Hi David, On 11/29/2013 03:17 PM, David Laight wrote: From: Of Roger Quadros With u-boot 2013.10, USB devices are sometimes not detected on OMAP4 Panda. To make us independent of what bootloader does with the USB Host module, we must RESET it to get it to a known good state. This patch Soft

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
+Benoit, Tony, Paul. Hi Michael, On 11/30/2013 06:48 AM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros rog...@ti.com wrote: With u-boot 2013.10, USB devices are sometimes not detected on OMAP4 Panda. To make us independent of what bootloader does with

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Michael, On 11/29/2013 05:32 PM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros rog...@ti.com wrote: With u-boot 2013.10, USB devices are sometimes not detected on OMAP4 Panda. To make us independent of what bootloader does with the USB Host module, we

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Michael Trimarchi
Hi Roger On Mon, Dec 2, 2013 at 10:39 AM, Roger Quadros rog...@ti.com wrote: +Benoit, Tony, Paul. Hi Michael, On 11/30/2013 06:48 AM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros rog...@ti.com wrote: With u-boot 2013.10, USB devices are sometimes not

Re: [PATCH V4 1/4] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-12-02 Thread Sricharan R
Hi Mark, Sorry for delayed response. I was away for some time. On Friday 15 November 2013 04:53 PM, Mark Rutland wrote: On Thu, Nov 14, 2013 at 04:46:36PM +, Sricharan R wrote: Hi Mark, On Thursday 14 November 2013 07:31 PM, Mark Rutland wrote: On Thu, Nov 14, 2013 at 12:18:47PM +,

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
Dear Javier Martinez Canillas, On Sun, 1 Dec 2013 13:27:25 +0100, Javier Martinez Canillas wrote: diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index d5cc792..4229e94 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-12-02 Thread Lee Jones
Since currently nobody uses TWL603x platform data and all new Hmm... when you say nobody, how did you come to this conclusion? Without digging into it and probably not that relevant, it appears there is some references to it in platform data still: $ git grep

Re: [RFC/PATCH] NAND bus-width detection extreme makeover

2013-12-02 Thread Alexander Shiyan
Hello. Here's my proposal, based in Pekon's latest work. This patch removes the flash device bus-width configuration, prior to the device detection. With this modification, a NAND driver is no longer able to force the device width, and instead can only obtain the detected bus-width after

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
- sta...@vger.kernel.org since they probably don't care about this unless the patch is merged. On 12/02/2013 10:41 AM, Roger Quadros wrote: Michael, On 11/29/2013 05:32 PM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros rog...@ti.com wrote: With u-boot

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Michael, On 12/02/2013 11:51 AM, Michael Trimarchi wrote: Hi Roger On Mon, Dec 2, 2013 at 10:39 AM, Roger Quadros rog...@ti.com wrote: +Benoit, Tony, Paul. Hi Michael, On 11/30/2013 06:48 AM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 02:01 PM, Sebastian Andrzej Siewior wrote: - sta...@vger.kernel.org since they probably don't care about this unless the patch is merged. On 12/02/2013 10:41 AM, Roger Quadros wrote: Michael, On 11/29/2013 05:32 PM, Michael Trimarchi wrote: Hi Roger On Fri, Nov 29, 2013

[PATCH] ARM: dts: Fix the name of supplies for smsc911x shared by OMAP

2013-12-02 Thread Florian Vaussard
drivers/net/ethernet/smsc/smsc911x.c is expecting supplies named vdd33a and vddvario. Currently the shared DTS file provides vmmc and vmmc_aux, and the supply lookup will fail: smsc911x 2c00.ethernet: Looking up vdd33a-supply from device tree smsc911x 2c00.ethernet: Looking up

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 01:12 PM, Roger Quadros wrote: You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET flag, so hwmod should reset it during boot. Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the USB Host hwmod data, then we don't need to change this driver at

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-12-02 Thread Ruslan Ruslichenko
Since add_children() never called in not-dt boot, this patch does not change current OMAP4 boot behavior and devices initialization. Also as far as I see all these twl603x regulators (apart from CLK32KG) and TWL usb module now have dt-bindings support. Device tree support for CLK32KG have been

Re: [PATCH] mfd: twl-core: Clean up module by removing twl603x pdata handling

2013-12-02 Thread Lee Jones
On Thu, 21 Nov 2013, Ruslan Ruslichenko wrote: Since currently nobody uses TWL603x platform data and all new users will supply it through device tree, handling of these data within twl-core will never be used, so remove it. Signed-off-by: Ruslan Ruslichenko

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 03:04 PM, Sebastian Andrzej Siewior wrote: On 12/02/2013 01:12 PM, Roger Quadros wrote: You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET flag, so hwmod should reset it during boot. Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the USB Host

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 02:35 PM, Roger Quadros wrote: It refers to Errata Id:i660 why it is required. Once you figured what why it has been added you could have an idea if it is okay to remove it and if the reset you do here might lead to it (I dunno). Keshava no longer works @TI. I have no other

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 03:39 PM, Sebastian Andrzej Siewior wrote: On 12/02/2013 02:35 PM, Roger Quadros wrote: It refers to Errata Id:i660 why it is required. Once you figured what why it has been added you could have an idea if it is okay to remove it and if the reset you do here might lead to it (I

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 02:44 PM, Roger Quadros wrote: Errata id: i660 DESCRIPTION In the following configuration : • USBHOST module is set to smart-idle mode • PRCM asserts idle_req to the USBHOST module. (This typically happens when the system is going to a low power mode : all ports have been

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Enric Balletbo Serra
Hi, CCing Pekon Gupta pe...@ti.com 2013/12/2 Thomas Petazzoni thomas.petazz...@free-electrons.com: Dear Javier Martinez Canillas, On Sun, 1 Dec 2013 13:27:25 +0100, Javier Martinez Canillas wrote: diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts

RE: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Gupta, Pekon
Hi, From: Enric Balletbo Serra [mailto:eballe...@gmail.com] CCing Pekon Gupta pe...@ti.com 2013/12/2 Thomas Petazzoni thomas.petazz...@free-electrons.com: Dear Javier Martinez Canillas, On Sun, 1 Dec 2013 13:27:25 +0100, Javier Martinez Canillas wrote: diff --git

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Paul Walmsley
On Mon, 2 Dec 2013, Roger Quadros wrote: It won't be done by omap_hwmod as we set HWMOD_INIT_NO_RESET flag in the hwmod data [1]. Question is do we do it in the driver of leave it to hwmod? It should be done by hwmod (or more broadly, some OMAP bus code). That way the device can be

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
Dear Gupta, Pekon, On Mon, 2 Dec 2013 14:56:09 +, Gupta, Pekon wrote: A query Why are you going backward from BCH8 to HAM1 ? HAM1 is just kept for legacy reasons, it's not at all recommended for new development. As some field results have shown that devices with HAM1 become un-usable

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 04:03 PM, Sebastian Andrzej Siewior wrote: On 12/02/2013 02:44 PM, Roger Quadros wrote: Errata id: i660 DESCRIPTION In the following configuration : • USBHOST module is set to smart-idle mode • PRCM asserts idle_req to the USBHOST module. (This typically happens when the

RE: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Gupta, Pekon
From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 14:56:09 +, Gupta, Pekon wrote: A query Why are you going backward from BCH8 to HAM1 ? HAM1 is just kept for legacy reasons, it's not at all recommended for new development. As some field results have

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Enric Balletbo Serra
Hi all, 2013/12/2 Gupta, Pekon pe...@ti.com: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 14:56:09 +, Gupta, Pekon wrote: A query Why are you going backward from BCH8 to HAM1 ? HAM1 is just kept for legacy reasons, it's not at all recommended for

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
Dear Enric Balletbo Serra, On Mon, 2 Dec 2013 16:39:09 +0100, Enric Balletbo Serra wrote: Thanks for the explanations to all. Although the new ECC schema breaks the compatibility between the board files and new DT based kernel, I think we should use BCH8 scheme. Sorry, because I had not

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 10:51 AM, Thomas Petazzoni wrote: Dear Enric Balletbo Serra, On Mon, 2 Dec 2013 16:39:09 +0100, Enric Balletbo Serra wrote: Thanks for the explanations to all. Although the new ECC schema breaks the compatibility between the board files and new DT based kernel, I think we

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
Dear Tom Rini, On Mon, 2 Dec 2013 11:00:35 -0500, Tom Rini wrote: Although the new ECC schema breaks the compatibility between the board files and new DT based kernel, I think we should use BCH8 scheme. Sorry, because I had not realized that this was configurable in u-boot, so I think,

RE: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Gupta, Pekon
From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 11:00:35 -0500, Tom Rini wrote: Although the new ECC schema breaks the compatibility between the board files and new DT based kernel, I think we should use BCH8 scheme. Sorry, because I had not realized

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Thomas Petazzoni
Dear Gupta, Pekon, On Mon, 2 Dec 2013 16:13:56 +, Gupta, Pekon wrote: Yes, at-least OMAP3 arch u-boot should still supports 'nandecc'. The infrastructure is still in place, however the command 'nandecc' is deprecated in newer versions. References in mainline u-boot:

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 11:13 AM, Gupta, Pekon wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 11:00:35 -0500, Tom Rini wrote: Although the new ECC schema breaks the compatibility between the board files and new DT based kernel, I think we should use BCH8

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Javier Martinez Canillas
Hi Pekon, On Mon, Dec 2, 2013 at 5:13 PM, Gupta, Pekon pe...@ti.com wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 11:00:35 -0500, Tom Rini wrote: Although the new ECC schema breaks the compatibility between the board files and new DT based

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 11:21 AM, Javier Martinez Canillas wrote: Hi Pekon, On Mon, Dec 2, 2013 at 5:13 PM, Gupta, Pekon pe...@ti.com wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 11:00:35 -0500, Tom Rini wrote: Although the new ECC schema breaks the

RE: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread David Laight
From: Roger Quadros [mailto:rog...@ti.com] On 11/29/2013 03:17 PM, David Laight wrote: ... + timeout = jiffies + msecs_to_jiffies(100); + while (!(usbhs_read(omap-uhh_base, OMAP_UHH_SYSSTATUS) + OMAP_UHH_SYSSTATUS_RESETDONE)) { + cpu_relax(); You mean use

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Javier Martinez Canillas
On Mon, Dec 2, 2013 at 5:24 PM, Tom Rini tr...@ti.com wrote: On 12/02/2013 11:21 AM, Javier Martinez Canillas wrote: Hi Pekon, On Mon, Dec 2, 2013 at 5:13 PM, Gupta, Pekon pe...@ti.com wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] On Mon, 2 Dec 2013 11:00:35

[PATCH v4 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com ---

[PATCH v4 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-12-02 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v4 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-12-02 Thread Andreas Fenkart
The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, the GPIO will only wake the module from suspend, SDIO irq detection will still happen through the IP block. Idea of remuxing the

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 11:46 AM, Javier Martinez Canillas wrote: On Mon, Dec 2, 2013 at 5:24 PM, Tom Rini tr...@ti.com wrote: On 12/02/2013 11:21 AM, Javier Martinez Canillas wrote: Hi Pekon, On Mon, Dec 2, 2013 at 5:13 PM, Gupta, Pekon pe...@ti.com wrote: From: Thomas Petazzoni

Re: [PATCH v4 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
Ignore this set, I busted it. 2013/12/2 Andreas Fenkart afenk...@gmail.com: v4: - switch to interrupts-extended format - drop ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified

RE: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Gupta, Pekon
From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] Dear Gupta, Pekon, On Mon, 2 Dec 2013 16:13:56 +, Gupta, Pekon wrote: Yes, at-least OMAP3 arch u-boot should still supports 'nandecc'. The infrastructure is still in place, however the command 'nandecc' is deprecated in

[PATCH v4 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
v4: - switch to interrupts-extended format - drop ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend,

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Michael Trimarchi
Hi Pekon On Mon, Dec 2, 2013 at 6:05 PM, Gupta, Pekon pe...@ti.com wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] Dear Gupta, Pekon, On Mon, 2 Dec 2013 16:13:56 +, Gupta, Pekon wrote: Yes, at-least OMAP3 arch u-boot should still supports 'nandecc'. The

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 12:05 PM, Gupta, Pekon wrote: From: Thomas Petazzoni [mailto:thomas.petazz...@free-electrons.com] Dear Gupta, Pekon, On Mon, 2 Dec 2013 16:13:56 +, Gupta, Pekon wrote: Yes, at-least OMAP3 arch u-boot should still supports 'nandecc'. The infrastructure is still in place,

RE: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Gupta, Pekon
So coming back to the specific problem here. I think we need 'nandecc' back in u-boot till atleast all systems have migrated to BCH16 or whatever highest ecc-scheme which can be supported on OMAP devices. Forgot to mention, one more way of updating boot-loaders with different ecc-scheme via

Re: [PATCH] ARM: dts: omap3-igep00x0: Fix nand ECC to maintain backward compatibility.

2013-12-02 Thread Tom Rini
On 12/02/2013 12:46 PM, Gupta, Pekon wrote: So coming back to the specific problem here. I think we need 'nandecc' back in u-boot till atleast all systems have migrated to BCH16 or whatever highest ecc-scheme which can be supported on OMAP devices. Forgot to mention, one more way of

Re: mmc: omap: Fix DMA configuration to not rely on device id

2013-12-02 Thread Tony Lindgren
* Dan Carpenter dan.carpen...@oracle.com [131202 00:07]: Hello Tony Lindgren, This is a semi-automatic email about new static checker warnings. The patch 31ee9181eb92: mmc: omap: Fix DMA configuration to not rely on device id from Nov 26, 2013, leads to the following Smatch complaint:

Re: [PATCH] ARM: OMAP2+: Powerdomain: Fix unchecked dereference of arch_pwrdm

2013-12-02 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [131127 17:56]: On 11/27/2013 05:57 AM, Rajendra Nayak wrote: Commit 'cd8abed' ARM: OMAP2+: Powerdomain: Remove the need to always have a voltdm associated to a pwrdm leads to the following Smatch complaint: arch/arm/mach-omap2/powerdomain.c:131

Re: [PATCH] ARM: dts: Fix the name of supplies for smsc911x shared by OMAP

2013-12-02 Thread Tony Lindgren
* Florian Vaussard florian.vauss...@epfl.ch [131202 04:54]: drivers/net/ethernet/smsc/smsc911x.c is expecting supplies named vdd33a and vddvario. Currently the shared DTS file provides vmmc and vmmc_aux, and the supply lookup will fail: smsc911x 2c00.ethernet: Looking up vdd33a-supply

[PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path

2013-12-02 Thread Tony Lindgren
Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of the free_mem_region() error path by reusing the struct resource *res for the DMA resources. Fix the error

Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support

2013-12-02 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [131128 09:05]: On 11/28/2013 12:02 AM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [131127 10:48]: This adds typical McBSP2-TWL4030 audio description to the legacy Beagle Board. Nice to see that work almost out of the box :)

[PATCH] ARM: OMAP2+: hwmod: Fix usage of invalid iclk / oclk when clock node is not present

2013-12-02 Thread Nishanth Menon
commit dc75925d(OMAP: hwmod: Fix the missing braces) introduced missing braces, however, we just set return result if clk_get fail and we populate the error pointer in clk pointer and pass it along to clk_prepare. This is wrong. The intent seems to be retry remaining clocks if they are available

[GIT PULL] more omap dt fixes against v3.13-rc1

2013-12-02 Thread Tony Lindgren
The following changes since commit 9cb238c00ba5c1ddfff2c2ed6aa66c15b962e4c3: mmc: omap: Fix I2C dependency and make driver usable with device tree (2013-11-26 15:51:16 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap

Re: [PATCH 1/1] drivers: net: cpsw: fix dt probe for one port ethernet

2013-12-02 Thread David Miller
From: Mugunthan V N mugunthan...@ti.com Date: Mon, 2 Dec 2013 12:53:39 +0530 When only one port of the two port is pinned out, then dt probe is failing because second port phy is not found. fixing this by checking the number of slaves and breaking the loop. Signed-off-by: Mugunthan V N

Re: [PATCH V2] gpio: omap: refresh patch be more aggressive with pm_runtime against v3.12-rc5

2013-12-02 Thread Chao Xu
Sorry for the late reply. On Fri, Nov 29, 2013 at 11:04 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Adding Kevin's Linaro id, + Nishant, On Tuesday 26 November 2013 05:46 PM, Chao Xu wrote: From: Felipe Balbi ba...@ti.com try to keep gpio block suspended as much as possible.

[PATCH v5 0/3] mmc: omap_hsmmc: enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
v5: - fix compile error introduced by last minute fix v4: - switch to interrupts-extended format - drop ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio

[PATCH v5 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com ---

[PATCH v5 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-12-02 Thread Andreas Fenkart
The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, the GPIO will only wake the module from suspend, SDIO irq detection will still happen through the IP block. Idea of remuxing the

[PATCH v5 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-12-02 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

Re: [GIT PULL] more omap dt fixes against v3.13-rc1

2013-12-02 Thread Olof Johansson
On Mon, Dec 2, 2013 at 1:40 PM, Tony Lindgren t...@atomide.com wrote: The following changes since commit 9cb238c00ba5c1ddfff2c2ed6aa66c15b962e4c3: mmc: omap: Fix I2C dependency and make driver usable with device tree (2013-11-26 15:51:16 -0800) are available in the git repository at:

[PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

2013-12-02 Thread Felipe Balbi
we could build that as a driver. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index ad25bfa..975ff9e 100644 --- a/drivers/mfd/menelaus.c +++

[PATCH v2 04/15] mfd: menelaus: Remove unnecessary loop

2013-12-02 Thread Felipe Balbi
we can let irqs refire and give the scheduler a chance to choose when we should be scheduled. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 43 +++ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git

[PATCH v2 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq

2013-12-02 Thread Felipe Balbi
we want to, eventually, get rid of the global the_menelaus pointer, so let's start passing menelaus as argument to some function calls and slowly phase out the_menelaus global pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 48

[PATCH v2 11/15] mfd: menelaus: Start to use irqdomain

2013-12-02 Thread Felipe Balbi
introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). while at that, some better error handling had to be added, so we could free irq descs we allocated. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v2 14/15] mfd: menelaus: IRQ is a requirement

2013-12-02 Thread Felipe Balbi
this driver needs IRQ to work, if client-irq isn't set properly, we won't work. Remove check around request_threaded_irq(). Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v2 13/15] mfd: menelaus: Remove unnecessary definition

2013-12-02 Thread Felipe Balbi
menelaus_i2c_driver isn't referenced on probe, just remove that unnecessary line. No functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index 74eae19..c0219b7

[PATCH v2 03/15] mfd: menelaus: Convert to threaded irq

2013-12-02 Thread Felipe Balbi
we don't need that extra workqueue when we have generic threaded irq handlers support. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH v2 07/15] mfd: menelaus: Limit the usage of the_menelaus

2013-12-02 Thread Felipe Balbi
pass a menelaus_chip pointer as argument to most functions so we can minimize the usage of the global the_menelaus pointer. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 265 ++--- 1 file changed, 142 insertions(+), 123

[PATCH v2 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions

2013-12-02 Thread Felipe Balbi
those functions are static and can receive a menelaus_chip pointer very easily. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 57 ++ 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH v2 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus - time helpers

2013-12-02 Thread Felipe Balbi
time_to_menelaus() and menelaus_to_time() are static and can easily receive a struct menelaus_chip pointer argument. After this patch, the_menelaus is only used on exported functions which are currently being used by board-n8x0.c. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v2 15/15] mfd: menelaus: Use devm_request_threaded_irq()

2013-12-02 Thread Felipe Balbi
by using devm_request_threaded_irq() we can drop a few extra lines of code and rely on device managed resources layer to free our IRQ for us. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH v2 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage

2013-12-02 Thread Felipe Balbi
those functions are static and can easily receive a menelaus_chip pointer argument. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/menelaus.c

[PATCH v2 02/15] mfd: menelaus: Switch over to module_i2c_driver

2013-12-02 Thread Felipe Balbi
just a macro to remove some boilerplate code, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index

[PATCH v2 05/15] mfd: menelaus: Use for_each_set_bit()

2013-12-02 Thread Felipe Balbi
that macro just helps removing some extra line of code and hides ffs() calls. while at that, also fix a variable shadowing bug where 'int irq' was being redeclared inside inner loop while it was also argument to interrupt handler. Signed-off-by: Felipe Balbi ba...@ti.com ---

[PATCH v2 12/15] mfd: menelaus: Switch all children to threaded_irq

2013-12-02 Thread Felipe Balbi
now that we have our own irq_chip, all children can use traditional request_threaded_irq(). While at that, also remove so functions which became unused. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/menelaus.c | 161 +++-- 1 file changed,

Re: [PATCH] ARM: dts: omap3-beagle: Fix USB host on beagle boards (for 3.13)

2013-12-02 Thread Laurent Pinchart
Hi Roger, On Monday 25 November 2013 15:55:45 Roger Quadros wrote: Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply for the USB PHY. As the generic PHY driver can't handle more than one supply at the moment, we configure this supply to be always on. This will cause a very

Re: [PATCH 1/2] ARM: dts: doc: Document missing binding for omap5-mpu

2013-12-02 Thread Rob Herring
On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R r.sricha...@ti.com wrote: The binding and support for omap5-mpu which has a cortex-a15 smp core, gic and integrated L2 cache has been existing for sometime. So Documenting the missing binding here. Cc: Benoit Cousson bcous...@baylibre.com

[PATCH 1/4] mfd: DT bindings for TPS65218 PMIC

2013-12-02 Thread Keerthy
Add DT bindings for TPS65218 PMIC. Signed-off-by: Keerthy j-keer...@ti.com --- Documentation/devicetree/bindings/mfd/tps65218.txt | 27 .../devicetree/bindings/regulator/tps65218.txt | 22 2 files changed, 49 insertions(+) create mode 100644

[PATCH 0/4] mfd: TPS65218: Add support for TPS65218 PMIC

2013-12-02 Thread Keerthy
The TPS65218 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators. - Over Temperature warning and Shut down. This patch adds support for TPS65218 mfd device. At this time only the regulator functionality

[PATCH 4/4] ARM: dts: AM437x: Add TPS65218 device tree nodes

2013-12-02 Thread Keerthy
Add TPS65218 device tree nodes. This patch is tested on am43x-epos-evm board. Signed-off-by: Keerthy j-keer...@ti.com --- arch/arm/boot/dts/am43x-epos-evm.dts | 41 ++ 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts

[PATCH 3/4] Regulators: TPS65218: Add Regulator driver for TPS65218 PMIC

2013-12-02 Thread Keerthy
This patch adds support for TPS65218 PMIC regulators. The regulators set consists of 6 DCDCs and 1 LDO. The output voltages are configurable and are meant to supply power to the main processor and other components. Signed-off-by: Keerthy j-keer...@ti.com --- drivers/regulator/Kconfig

[PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-02 Thread Keerthy
The TPS65218 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators. - Over Temperature warning and Shut down. This patch adds support for tps65218 mfd device. At this time only the regulator functionality